Re: [DISCUSS] Change Jenkins default logging format

2019-06-10 Thread 'Gavin Williams' via Jenkins Developers
Baptiste/Jesse Apologies if any of my comments come across as offensive. It was more out of frustraion that our log ingestion for Jenkins masterslogs was broken by an undocumented and unexpected change. I've filed a Jira as above - https://issues.jenkins-ci.org/browse/JENKINS-57888 Regards On

Re: [DISCUSS] Change Jenkins default logging format

2019-06-10 Thread Baptiste Mathus
This was indeed an undocumented feature you and possibly others were relying on, this is it got broken without anyone realizing. We are sorry about that, but so the right way to have this fixed is as Jesse was saying: please file a JIRA to explain the use case so we can possibly make a user-facing

Re: [DISCUSS] Change Jenkins default logging format

2019-06-10 Thread 'Gavin Williams' via Jenkins Developers
Unfortunately Java dev is not my forte.. It's a shame this change was put in under the radar, with no changelog entry and no documentation update to define the new log format :( On Friday, June 7, 2019 at 8:46:05 PM UTC+1, Jesse Glick wrote: > > Well, you can work on a PR to add a supported

Re: [DISCUSS] Change Jenkins default logging format

2019-06-07 Thread Jesse Glick
Well, you can work on a PR to add a supported log format option to `jenkinsci/winstone`. -- You received this message because you are subscribed to the Google Groups "Jenkins Developers" group. To unsubscribe from this group and stop receiving emails from it, send an email to

Re: [DISCUSS] Change Jenkins default logging format

2019-06-07 Thread 'Gavin Williams' via Jenkins Developers
You're right that Jenkins doesn't provide details via help, but the method is documented on the Jenkins wiki, and is a standard Java mechanism of customising the logging output... I can also see several mentions of the same method in this email thread... However the changes introduced have

Re: [DISCUSS] Change Jenkins default logging format

2019-06-07 Thread Jesse Glick
On Fri, Jun 7, 2019 at 6:23 AM 'Gavin Williams' via Jenkins Developers wrote: > Unfortunately this appears to have broken the ability to provide a custom log > format :( > > See https://issues.jenkins-ci.org/browse/JENKINS-57888 for more info... Seems like an RFE to me. `java -jar jenkins.war

Re: [DISCUSS] Change Jenkins default logging format

2019-06-07 Thread 'Gavin Williams' via Jenkins Developers
Jesse Unfortunately this appears to have broken the ability to provide a custom log format :( See https://issues.jenkins-ci.org/browse/JENKINS-57888 for more info... Ideas? Cheers Gavin On Thursday, April 11, 2019 at 12:27:45 AM UTC+1, Jesse Glick wrote: > > On Wed, Apr 4, 2018 at 8:18 PM

Re: [DISCUSS] Change Jenkins default logging format

2019-04-10 Thread Jesse Glick
On Wed, Apr 4, 2018 at 8:18 PM Jesse Glick wrote: > As to the concrete format to pick, I do not have a strong opinion but > note that there is a compact one-line formatter in `support-core` > (later copied to `jenkins-test-harness` as well). https://github.com/jenkinsci/winstone/pull/63 -- You

Re: [DISCUSS] Change Jenkins default logging format

2018-04-12 Thread Cyrille Le Clerc
As I have already said many times, I fully support this initiative. Tomcat has done this move a while ago and it was a great success. Cyrille On Wednesday, April 4, 2018 at 3:18:00 PM UTC+2, Baptiste Mathus wrote: > > Hello everyone, > > Having worked on more things related to Jenkins logging

Re: [DISCUSS] Change Jenkins default logging format

2018-04-11 Thread Jesse Glick
On Wed, Apr 11, 2018 at 11:18 AM, Jesse Glick wrote: > 2018-04-11 15:15:56.836+ [id=37] INFO > o.j.main.modules.sshd.SSHD#start: Started SSHD at port > Rrrgh, GMail line-wrapping without the RFC to preserve significant newlines. Trying again as HTML: 2018-04-11

Re: [DISCUSS] Change Jenkins default logging format

2018-04-11 Thread Jesse Glick
On Wed, Apr 11, 2018 at 10:01 AM, James Nord wrote: > I think date should always come first though, not level and use a > datetime format that does not have to cope with am/pm or crazy American date > styles! FTR the formatter in `support-core` produces output such as

Re: [DISCUSS] Change Jenkins default logging format

2018-04-11 Thread James Nord
> Anyone can easily change the logging format in Jenkins by passing custom > J.U.L properties file. I know at least one person that did! +1 to change the default. I think date should always come first though, not level and use a datetime format that does not have to cope with am/pm or crazy

Re: [DISCUSS] Change Jenkins default logging format

2018-04-05 Thread Daniel Beck
> On 5. Apr 2018, at 23:24, gsimpson via Jenkins Developers > wrote: > > I am going to go ahead and strongly disagree with the characterization that > changing the logging is easy. I may be the only one that has ever struggled > with getting custom logging for

Re: [DISCUSS] Change Jenkins default logging format

2018-04-05 Thread gsimpson via Jenkins Developers
> On Wednesday, April 4, 2018 at 9:12:39 AM UTC-7, Oleg Nenashev wrote: > Anyone can easily change the logging format in Jenkins by passing custom J.U.L properties file. > I am going to go ahead and strongly disagree with the characterization that changing the logging is easy. I may be the

Re: [DISCUSS] Change Jenkins default logging format

2018-04-04 Thread Daniel Beck
> On 4. Apr 2018, at 21:20, Oleg Nenashev wrote: > > • We enable the new logging format in Essentials + immediately get > benefit from it (e.g. via Logstash/fluentd) > • We offer a feature flag in standard Jenkins. Start from opt-in, then > maybe opt-out at

Re: [DISCUSS] Change Jenkins default logging format

2018-04-04 Thread Baptiste Mathus
2018-04-04 18:12 GMT+02:00 Oleg Nenashev : > Hi Baptiste, > > Anyone can easily change the logging format in Jenkins by passing custom > J.U.L properties file. > Yes. But in practice, I'm convinced virtually nobody does this. > So it should not be a problem to change

Re: [DISCUSS] Change Jenkins default logging format

2018-04-04 Thread Arnaud Héritier
I think I already claimed my hate for this logging format many times. For sure I understand Oleg's concern with the impact of changing the default settings. Like always for such kind of change when we don't really know how it could impact our users I would prefer to introduce the change non

Re: [DISCUSS] Change Jenkins default logging format

2018-04-04 Thread Carlos Sanchez
I'm +1 to change the format. 2 lines is really annoying On Wed, Apr 4, 2018 at 7:24 PM, R. Tyler Croy wrote: > (replies inline) > > On Wed, 04 Apr 2018, Oleg Nenashev wrote: > > > Hi Baptiste, > > > > Anyone can easily change the logging format in Jenkins by passing custom

Re: [DISCUSS] Change Jenkins default logging format

2018-04-04 Thread R. Tyler Croy
(replies inline) On Wed, 04 Apr 2018, Oleg Nenashev wrote: > Hi Baptiste, > > Anyone can easily change the logging format in Jenkins by passing custom > J.U.L properties file. > So it should not be a problem to change logging format even if you do not > add a custom logging appender for ELK.

Re: [DISCUSS] Change Jenkins default logging format

2018-04-04 Thread Daniel Beck
> On 4. Apr 2018, at 18:12, Oleg Nenashev wrote: > > Changing a default logging format may cause regressions in existing > monitoring systems. I would rather be conservative and keep the default > logging format in Jenkins unless there is a strong justification to do

Re: [DISCUSS] Change Jenkins default logging format

2018-04-04 Thread Oleg Nenashev
Hi Baptiste, Anyone can easily change the logging format in Jenkins by passing custom J.U.L properties file. So it should not be a problem to change logging format even if you do not add a custom logging appender for ELK. Changing a default logging format may cause regressions in existing

[DISCUSS] Change Jenkins default logging format

2018-04-04 Thread Baptiste Mathus
Hello everyone, Having worked on more things related to Jenkins logging recently, I've had the opportunity to remember my past pain when I was operating a Jenkins instance and sending logs to an ELK cluster. Compared to almost everything else in the infrastructure, the logstash rules for Jenkins