Re: Jenkins Core pull-requests management

2022-03-28 Thread Adrien Lecharpentier
Hello everyone, I created https://github.com/jenkinsci/jenkins/pull/6413 to move this subject forward. Le mercredi 23 mars 2022 à 10:39:39 UTC+1, Adrien Lecharpentier a écrit : > For everyone, to give data about why I started this discussion: > - we have 66 opens pull-requests, 5 of them are

Re: Jenkins Core pull-requests management

2022-03-23 Thread Adrien Lecharpentier
For everyone, to give data about why I started this discussion: - we have 66 opens pull-requests, 5 of them are marked as ready-for-merge - 10 out of 61 pull-requests are labeled proposed-for-close - of the 10 oldest open pull-requests, 7 are labels proposed-for-close - the 17 oldest open

Re: Jenkins Core pull-requests management

2022-03-23 Thread Adrien Lecharpentier
Alex, I agree that we have the list of labels but even for `ready-for-merge`, we haven't document there what we tend to say when we put the label: the pr should be merge within 24hr (with no negative feedback). It is important that we have a clear guideline, like > * If you do not get feedback

Re: Jenkins Core pull-requests management

2022-03-22 Thread Olivier Lamy
On Wed, 23 Mar 2022 at 02:07, Adrien Lecharpentier < adrien.lecharpent...@gmail.com> wrote: > Hello everyone, > > I've spent some time lately on looking at the pull-requests on > jenkinsci/jenkins repository. For some old, inactive pull-requests I've > pinged the authors and for some, added the

Re: Jenkins Core pull-requests management

2022-03-22 Thread Alex
Heyo, that is an interesting proposal. Currently, there are quite a lot of stale pull requests, whether labeled with a stale-like label or not, which's state is unclear how to proceed with them. I think working with labels is easier, instead of converting the PRs into drafts, because a stale

Re: Jenkins Core pull-requests management

2022-03-22 Thread Jeff
This seems reasonable to me. After some period of time (months? years?) the PR is unlikely to be merged, so why keep it open if it's truly stale? On Tue, Mar 22, 2022 at 9:07 AM Adrien Lecharpentier < adrien.lecharpent...@gmail.com> wrote: > Hello everyone, > > I've spent some time lately on

Jenkins Core pull-requests management

2022-03-22 Thread Adrien Lecharpentier
Hello everyone, I've spent some time lately on looking at the pull-requests on jenkinsci/jenkins repository. For some old, inactive pull-requests I've pinged the authors and for some, added the proposed-for-close label. However, the label description nor any prior discussion on the mailing-list