Re: How to load resources from base module

2017-05-22 Thread Alan Bateman
On 22/05/2017 08:45, wzberger wrote: Hm, so how can ClassA access the resource from module com.b directly - without having a class instance of module b? Does the code in ClassA have any context to work this? How does it know the resource is in com.b? The APIs allow you to locate a resource in

Re: Proposal: Allow illegal reflective access by default in JDK 9

2017-05-19 Thread Alan Bateman
On 19/05/2017 14:48, Stephen Felts wrote: By the way, there is no available API so that one can write If an object is not accessible and setAccessible on the object will succeed call setAccessible That means that the code needs to call setAccessible and handle the exception,

Re: Proposal: Allow illegal reflective access by default in JDK 9

2017-05-19 Thread Alan Bateman
On 19/05/2017 14:54, Peter Levart wrote: : Opening the whole JDK (--illegal-access=permit by default) means that all internal "public" APIs are made accessible if by chance someone can grab an instance of target object and/or an instance of Method/Field object. Imagine a JDK developer that

Re: Attaching to a JVM image that does not include java.instrument

2017-05-19 Thread Alan Bateman
On 19/05/2017 12:28, Andrew Dinn wrote: : I don't think history is the most important guide here (whatever the history might be). If agent support was not optional in the past that is no reason to not make it optional now. My reason for bringing up the history is to make it clear that the

Re: Proposal: Allow illegal reflective access by default in JDK 9

2017-05-19 Thread Alan Bateman
On 19/05/2017 13:02, Peter Levart wrote: Ok, I can understand that such interpretation of "opens" is necessary for JDK 8 compatibility story. If something is "open" then it behaves exactly like in JDK 8 or before (apart from compilation) regardless of packages being exported or not. But

Re: Proposal: Allow illegal reflective access by default in JDK 9

2017-05-19 Thread Alan Bateman
On 19/05/2017 11:58, Peter Levart wrote: : ...the example works (does not throw exception), but when run with: --add-opens java.base/jdk.internal.misc=ALL-UNNAMED ...the example still works OOOPS - this is a bug!!! This is definitely a bug. No, the behavior is correct as

Re: Proposal: Allow illegal reflective access by default in JDK 9

2017-05-19 Thread Alan Bateman
On 19/05/2017 10:48, Volker Simonis wrote: : From my understanding, at run-time, "open" implicates "exports" (i.e. if a module M1 opens a package P for some other module M2 it also, implicitly exports P to M2). The "big kill switch" in both, its old and in the newly proposed form, usually

Re: Attaching to a JVM image that does not include java.instrument

2017-05-19 Thread Alan Bateman
On 19/05/2017 10:20, Rafael Winterhalter wrote: : It is the exact purpose of a Java agent to allow the enhancement of a Java application that is independent of a particular Java process. Therefore, it should not be a decission bound to the creation or bundeling of the Java application if

Re: Attaching to a JVM image that does not include java.instrument

2017-05-19 Thread Alan Bateman
On 19/05/2017 08:08, Rafael Winterhalter wrote: Hi Alan, I just retested with the most recent Java 9 snapshot and this is what I get: rafael@rafc:~/jdk9-test/greetingsapp$ ./bin/java -javaagent:/home/rafael/.m2/repository/sample-agent/sample-agent/1.0-SNAPSHOT/sample-agent-1.0-SNAPSHOT.jar

Re: -Xdiag:resolver

2017-05-18 Thread Alan Bateman
On 18/05/2017 18:35, Paul Deitel wrote: In earlier JDK 9-ea releases, there was the -Xdiag:resolver option to the java command so you could view the module resolution process at app startup. Has this been removed and replaced with --show-module-resolition option? The outputs don’t seem to be

Re: Add-Reads and Add-Modules manifest attributes?

2017-05-18 Thread Alan Bateman
On 18/05/2017 16:47, Andrew Guibert wrote: : A concrete use case for an `Add-Reads` manifest attr is beside the point. Since we have the command line option, why can't we have the equivalent functionality as a manifest attribute (especially since it seems trivial to implement)? As long as

Re: Attaching to a JVM image that does not include java.instrument

2017-05-18 Thread Alan Bateman
On 18/05/2017 15:20, Rafael Winterhalter wrote: Hei, I found that it is impossible to dynamically attach to a JVM that does not include the java.instrument module when built with jlink. This is a result of the instrumentation API and its infrastructure missing from the image.

Re: Add-Reads and Add-Modules manifest attributes?

2017-05-18 Thread Alan Bateman
On 18/05/2017 15:14, Andrew Guibert wrote: : Regarding Add-Reads: You're reading it backwards I'm afraid =) This example is saying "java.base needs to read ALL-UNNAMED modules" But regardless of what example was given, it is a valid use case right? I assumed you had transposed them in your

Re: Add-Reads and Add-Modules manifest attributes?

2017-05-18 Thread Alan Bateman
On 18/05/2017 14:40, Andrew Guibert wrote: I was happy to see that a resolution was reached for #AddExportsInManifest, but why did this stop at Add-Exports and Add-Opens? In order to cover all use cases (for unnamed modules), we would need two more manifest attributes: # Equivalent to:

Re: How to load resources from base module

2017-05-18 Thread Alan Bateman
On 18/05/2017 08:16, wzberger wrote: : public class ClassA{ public ClassA() { //success System.out.println(getClass().getResource("/com/b/resources/test.txt")); The test creates an instance of ClassB (extends ClassA) and so getClass() returns ClassB here, not ClassA. So when

Re: Some suggested patches and improvements

2017-05-18 Thread Alan Bateman
On 18/05/2017 01:29, Gregg Wonderly wrote: I understand that you might feel this is an excessive rant. But, practically I know of Java applications around the world which all use things like Spring. Spring seems to be making great progress, here's a recent write-up from Juergen Hoeller:

Re: Evidence of incompatibility (was Some suggested patches and improvements)

2017-05-18 Thread Alan Bateman
On 18/05/2017 04:28, Ralph Goers wrote: I am afraid I have to echo these sentiments to some degree. In trying to get Log4j to support Java 9 I first tried to use a multi-release jar. This failed miserably when the OSGi build tool failed over finding java classes under META-INF. Then it

Re: Evidence of incompatibility (was Some suggested patches and improvements)

2017-05-17 Thread Alan Bateman
On 17/05/2017 20:56, Robert Gibson wrote: : And of course the intersection of these issues makes things even more complicated. At this point I would settle for being able to add a command-line flag to get our app to run, but despite testing EA builds for over a year and assiduously flagging

Re: Evidence of incompatibility (was Some suggested patches and improvements)

2017-05-17 Thread Alan Bateman
On 17/05/2017 18:26, Eric Johnson wrote: : Here's a challenge back to the Jigsaw team. Can I still do java -jar ... every existing Java application (without recompile!) that currently launches that way? I'm even willing to cut some slack and ignore applications that use com.sun APIs that have

Re: How to load resources from base module

2017-05-17 Thread Alan Bateman
On 17/05/2017 18:22, wzberger wrote: The resources are mainly images and XML files, located in separate packages. By adding the opens clause it works fine for Class B (called from module a) - however, it does not work for Class A (returns null). I wonder if this is the intended behavior? I'm

Re: How to load resources from base module

2017-05-17 Thread Alan Bateman
On 17/05/2017 10:54, wzberger wrote: Looks like I'm having an encapsulation issue with resources. Class B belongs to module b and extends Class A in module a. Class B provides resources which should be loaded from base class A. However, calling getInstance().getClass().getResource(...)

Re: Some suggested patches and improvements

2017-05-16 Thread Alan Bateman
On 16/05/2017 19:11, Gregg Wonderly wrote: At some level, this is the problem that is paramount on the release of JDK-9. Earlier Mark asked if the Eclipse foundation had to approve or be ready to support all of what JDK-9/Jigsaw supports before it could be released. The statement below

Re: AW: Java 9 EA 169 Webstart NoClassDefFoundError: javax/xml/ws/Service

2017-05-16 Thread Alan Bateman
On 16/05/2017 12:26, Reto Merz wrote: So I think Java Web Start is right to align with the policy for applications launched on the command line. The difference is that in case of Webstart the Java version is controlled by the user. They are trained to install the latest Java version and keep

Re: Some suggested patches and improvements

2017-05-16 Thread Alan Bateman
On 12/05/2017 14:31, David M. Lloyd wrote: : There is a lot more to #5, something that will become clear when you work through all the scenarios. The JSR and spec part are minor though but I'd prefer to hold off until there is more discussion on this topic in the JSR. I'd rather not hold

Re: Some suggested patches and improvements

2017-05-16 Thread Alan Bateman
On 12/05/2017 14:31, David M. Lloyd wrote: : #4 seems to be working around the outcome of issue #CyclicDependences in the JSR. I also don't wish to comment on that except to say that introducing system properties to skip specified checks is highly problematic from a conformance perspective.

Re: Java 9 EA 169 Webstart NoClassDefFoundError: javax/xml/ws/Service

2017-05-16 Thread Alan Bateman
On 16/05/2017 09:49, Reto Merz wrote: Thanks Alan. Wouldn't it make sense to add all modules by default in Java 9 in case of Webstart and print a warning to the Webstart console the first time a future non-default module is accessed with the message that the JNLP must be extended with a

Re: What happened to ModuleClassLoader?

2017-05-16 Thread Alan Bateman
On 16/05/2017 09:50, Peter Levart wrote: : If I remember correctly, there was a phase in jigsaw development when there was a class named ModuleClassLoader. There was although it was replaced in 2015. : Above two utility methods (defineModulesWithOneLoader and

Re: Java 9 EA 169 Webstart NoClassDefFoundError: javax/xml/ws/Service

2017-05-16 Thread Alan Bateman
On 15/05/2017 15:10, Reto Merz wrote: Hello, It seems that Java 9 Webstart (still) does not add all modules to the class/module path. Our Webstart app is signed, requests all-permision and works with the latest Java 6, 7 and 8. With 9-ea+169 we get this error:

hg: jigsaw/jake/jdk: 3 new changesets

2017-05-12 Thread alan . bateman
Changeset: c59d273ab6db Author:alanb Date: 2017-05-12 14:37 +0100 URL: http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/c59d273ab6db Fix javadoc links ! src/java.base/share/classes/java/lang/ModuleLayer.java ! src/java.base/share/classes/jdk/internal/loader/Loader.java Changeset:

hg: jigsaw/jake/corba: 2 new changesets

2017-05-12 Thread alan . bateman
Changeset: 72bb2cd3f013 Author:lana Date: 2017-05-11 16:26 + URL: http://hg.openjdk.java.net/jigsaw/jake/corba/rev/72bb2cd3f013 Added tag jdk-9+169 for changeset b2218d41edef ! .hgtags Changeset: b88b0bf4088f Author:alanb Date: 2017-05-12 14:21 +0100 URL:

hg: jigsaw/jake/jdk: 28 new changesets

2017-05-12 Thread alan . bateman
Changeset: 88379fba79d3 Author:amlu Date: 2017-05-04 20:24 +0800 URL: http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/88379fba79d3 8023897: Replace/update/rename executeAndCatch in various tests to assertThrows Reviewed-by: dfuchs, prappo, psandoz, rriggs !

hg: jigsaw/jake/jaxws: 3 new changesets

2017-05-12 Thread alan . bateman
Changeset: 912cf69806d5 Author:lancea Date: 2017-05-05 13:32 -0400 URL: http://hg.openjdk.java.net/jigsaw/jake/jaxws/rev/912cf69806d5 8179566: Add additional jaxws messages to be translated Reviewed-by: alanb, mchung +

hg: jigsaw/jake/jaxp: 5 new changesets

2017-05-12 Thread alan . bateman
Changeset: 60abb1d1cd1d Author:ihse Date: 2017-05-09 12:54 +0200 URL: http://hg.openjdk.java.net/jigsaw/jake/jaxp/rev/60abb1d1cd1d 8179889: Fix typographic errors in copyright headers Reviewed-by: erikj, dholmes !

hg: jigsaw/jake/langtools: 5 new changesets

2017-05-12 Thread alan . bateman
Changeset: 5daed0e904ac Author:lana Date: 2017-05-04 17:55 + URL: http://hg.openjdk.java.net/jigsaw/jake/langtools/rev/5daed0e904ac Merge Changeset: 1faee09b8da1 Author:jlahoda Date: 2017-05-09 12:22 +0200 URL:

hg: jigsaw/jake/hotspot: 5 new changesets

2017-05-12 Thread alan . bateman
Changeset: 70548873832d Author:lana Date: 2017-05-04 17:54 + URL: http://hg.openjdk.java.net/jigsaw/jake/hotspot/rev/70548873832d Merge Changeset: d7da8c2b8b6c Author:roland Date: 2017-04-25 09:37 +0200 URL:

hg: jigsaw/jake/nashorn: 3 new changesets

2017-05-12 Thread alan . bateman
Changeset: 131e25008015 Author:ihse Date: 2017-05-09 12:54 +0200 URL: http://hg.openjdk.java.net/jigsaw/jake/nashorn/rev/131e25008015 8179889: Fix typographic errors in copyright headers Reviewed-by: erikj, dholmes !

hg: jigsaw/jake: 7 new changesets

2017-05-12 Thread alan . bateman
Changeset: 25a364291f63 Author:lana Date: 2017-05-04 17:54 + URL: http://hg.openjdk.java.net/jigsaw/jake/rev/25a364291f63 Merge Changeset: 7931344eeb84 Author:ihse Date: 2017-05-05 13:56 +0200 URL: http://hg.openjdk.java.net/jigsaw/jake/rev/7931344eeb84

Re: Some suggested patches and improvements

2017-05-12 Thread Alan Bateman
On 12/05/2017 01:43, David M. Lloyd wrote: I've proposed five patches to the jpms-spec-experts list [1..5] for discussion. The patches are as follows: 1. Layer primitive: addExports() - mirrors the existing Module.addExports() method for ModuleLayer.Controllers 2. Layer primitive: addUses()

Re: #AddExportsInManifest

2017-05-12 Thread Alan Bateman
On 11/05/2017 21:25, Paul Bakker wrote: I'm a little confused by "...deployments work if they are dependent on JDK internal APIs". What does internal JDK usage have to do with opening/exporting your own packages? I would think this solves the problem that some other code (e.g. a library)

Re: SecurityManager.checkPackageAccess for qualified exports

2017-05-12 Thread Alan Bateman
On 12/05/2017 08:16, Langer, Christoph wrote: Hi all, while playing with the security manager (using -Djava.security.manager) in Java 9 and testing platform modules that we have added specifically in our build, I came across the following thing: As we are using some stuff from jdk.internal,

Re: #AddExportsInManifest

2017-05-11 Thread Alan Bateman
On 11/05/2017 07:51, Paul Bakker wrote: Hi Alan, What is the reason only exports/opens to unnamed are possible? Also, are these implemented in the current jigsaw prototype? I'm having trouble getting it to work, but that might be entirely my own doing... The attributes are defined for the

Re: #AddExportsInManifest

2017-05-11 Thread Alan Bateman
On 11/05/2017 07:22, Paul Bakker wrote: Hi all, In #AddExportsInManifest two new manifest entries are proposed. I can only find the following email containing more details: http://mail.openjdk.java.net/pipermail/jpms-spec-observers/2016-September/000547.html

Re: Problems with non-exported split packages (for resources/files)

2017-05-10 Thread Alan Bateman
On 10/05/2017 15:32, Peter Levart wrote: Hi, Two modules can have packages with same name if they are not exported *and* each of the modules loads classes using distinct class loaders, right? That's right. If the modules are defined to different class loaders then they can even export the

Re: Problems with non-exported split packages (for resources/files)

2017-05-10 Thread Alan Bateman
On 10/05/2017 08:48, Alessio Stalla wrote: Case in point, the rapid application development framework Portofino [1] is split in several (non-Jigsaw) modules each with its message bundle fragment, which is named portofino-messages and placed in the empty package. By "the empty package" then I

Re: bidirectional dependencies in AOP-like languages?

2017-05-10 Thread Alan Bateman
On 09/05/2017 18:19, Stephan Herrmann wrote: : Let's assume a language using Instrumentation & ClassFileTransformer for weaving an aspect into its base. Lets assume the aspect statically declares a dependence on that base. Now the weaver needs to make the aspect accessible for base-to-aspect

Re: Revised proposal for #AutomaticModuleNames

2017-05-09 Thread Alan Bateman
Just a quick note to say that the initial support for the Automatic-Module-Name JAR file attribute is in the Jigsaw EA builds [1] for those that want to try it out. -Alan [1] http://jdk.java.net/jigsaw/

Re: Accessing module internals from bytecode rewriting agent

2017-05-09 Thread Alan Bateman
On 09/05/2017 01:45, Martin Buchholz wrote: On Tue, May 2, 2017 at 2:40 AM, Andrew Dinn wrote: Just wanted to post a heads-up that this fall-back behaviour has now been implemented in Byteman release 4.0.0-BETA5. Thanks - I can confirm 4.0.0-BETA5 works for me. Also Mandy

Re: Reminder to update JVMS

2017-05-08 Thread Alan Bateman
On 06/05/2017 18:13, Stephan Herrmann wrote: I just happened to search for the specification of the class file representation of modules. I was quite surprised to find nothing in JVMS. Then I found: "The changes to the class-file chapter in support of module declarations are not included in

Re: --ignore-signing-information do not suppress all errors

2017-05-08 Thread Alan Bateman
On 08/05/2017 00:06, Remi Forax wrote: Hi all, I wonder if it's an issue or if there is a rational for not suppressing this error when using --ignore-signing-information. I'm patching the compiler related modules of the jdk9 with the one from amber/langtools, so i know that i'm doing

hg: jigsaw/jake/langtools: Automatic-Module-Name

2017-05-05 Thread alan . bateman
Changeset: 822101a1a31d Author:alanb Date: 2017-05-05 21:06 +0100 URL: http://hg.openjdk.java.net/jigsaw/jake/langtools/rev/822101a1a31d Automatic-Module-Name ! src/jdk.compiler/share/classes/com/sun/tools/javac/file/Locations.java

hg: jigsaw/jake/nashorn: 2 new changesets

2017-05-04 Thread alan . bateman
Changeset: c78163ad1a4e Author:lana Date: 2017-05-04 16:38 + URL: http://hg.openjdk.java.net/jigsaw/jake/nashorn/rev/c78163ad1a4e Added tag jdk-9+168 for changeset 0f81cde5a1f7 ! .hgtags Changeset: 61cbf87f8b49 Author:alanb Date: 2017-05-04 19:06 +0100 URL:

hg: jigsaw/jake/corba: 2 new changesets

2017-05-04 Thread alan . bateman
Changeset: b2218d41edef Author:lana Date: 2017-05-04 16:38 + URL: http://hg.openjdk.java.net/jigsaw/jake/corba/rev/b2218d41edef Added tag jdk-9+168 for changeset 03a2cc9c8a1e ! .hgtags Changeset: c8f59dfe1269 Author:alanb Date: 2017-05-04 19:02 +0100 URL:

hg: jigsaw/jake/jdk: 2 new changesets

2017-05-04 Thread alan . bateman
Changeset: 8bfab0e73164 Author:lana Date: 2017-05-04 16:38 + URL: http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/8bfab0e73164 Added tag jdk-9+168 for changeset e78da9db6299 ! .hgtags Changeset: 052d759c36a8 Author:alanb Date: 2017-05-04 19:02 +0100 URL:

hg: jigsaw/jake/hotspot: 2 new changesets

2017-05-04 Thread alan . bateman
Changeset: f36e864e66a7 Author:lana Date: 2017-05-04 16:38 + URL: http://hg.openjdk.java.net/jigsaw/jake/hotspot/rev/f36e864e66a7 Added tag jdk-9+168 for changeset fbb9c8026495 ! .hgtags Changeset: 1d55ec6b9bc7 Author:alanb Date: 2017-05-04 19:06 +0100 URL:

hg: jigsaw/jake/jaxp: 2 new changesets

2017-05-04 Thread alan . bateman
Changeset: df63b2d22ac6 Author:lana Date: 2017-05-04 16:38 + URL: http://hg.openjdk.java.net/jigsaw/jake/jaxp/rev/df63b2d22ac6 Added tag jdk-9+168 for changeset 23a87f409371 ! .hgtags Changeset: a89495528083 Author:alanb Date: 2017-05-04 19:02 +0100 URL:

hg: jigsaw/jake/jaxws: 2 new changesets

2017-05-04 Thread alan . bateman
Changeset: e66ea56c8751 Author:lana Date: 2017-05-04 16:38 + URL: http://hg.openjdk.java.net/jigsaw/jake/jaxws/rev/e66ea56c8751 Added tag jdk-9+168 for changeset 2746716dcc5a ! .hgtags Changeset: 5a7209da3317 Author:alanb Date: 2017-05-04 19:02 +0100 URL:

hg: jigsaw/jake: 2 new changesets

2017-05-04 Thread alan . bateman
Changeset: 8e1d0bed44e5 Author:lana Date: 2017-05-04 16:38 + URL: http://hg.openjdk.java.net/jigsaw/jake/rev/8e1d0bed44e5 Added tag jdk-9+168 for changeset 143d4c87bc1e ! .hgtags Changeset: c6f2f8eaafb2 Author:alanb Date: 2017-05-04 19:01 +0100 URL:

hg: jigsaw/jake: 11 new changesets

2017-05-04 Thread alan . bateman
Changeset: e1cd0e7075ae Author:ksrini Date: 2017-04-25 07:54 -0700 URL: http://hg.openjdk.java.net/jigsaw/jake/rev/e1cd0e7075ae 8178725: provide way to link to external documentation Reviewed-by: dholmes, erikj, ihse, jjg ! make/Javadoc.gmk Changeset: 4a25d35d9159 Author:ihse

hg: jigsaw/jake/hotspot: 6 new changesets

2017-05-04 Thread alan . bateman
Changeset: f1cca489e9c6 Author:kbarrett Date: 2017-04-26 22:34 -0400 URL: http://hg.openjdk.java.net/jigsaw/jake/hotspot/rev/f1cca489e9c6 8179084: HotSpot VM fails to start when AggressiveHeap is set Summary: Don't set default ParallelGCThreads when processing AggressiveHeap

hg: jigsaw/jake/jdk: 34 new changesets

2017-05-04 Thread alan . bateman
Changeset: fa4bdd8f0eed Author:chegar Date: 2017-04-25 14:46 +0100 URL: http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/fa4bdd8f0eed 8158270: MulticastSendReceiveTests.java failed with "Expected message not received" Reviewed-by: alanb !

hg: jigsaw/jake/nashorn: 3 new changesets

2017-05-04 Thread alan . bateman
Changeset: a3022cc65b17 Author:jjg Date: 2017-04-26 10:56 -0700 URL: http://hg.openjdk.java.net/jigsaw/jake/nashorn/rev/a3022cc65b17 8179304: Fix HTML 5 errors in jdk.scripting.nashorn and jdk.dynalink module Reviewed-by: sundar, jlaskey, hannesw !

Re: 8178380: Module system implementation refresh (5/2017 update)

2017-05-04 Thread Alan Bateman
On 04/05/2017 03:08, Mandy Chung wrote: src/java.base/share/classes/jdk/internal/module/ModuleBootstrap.java 148 if (System.getProperty("jdk.module.minimumBoot") != null) { This property can be removed after read the value, if present. It doesn't need to because VM terminates

Re: Accessing module internals from bytecode rewriting agent

2017-05-02 Thread Alan Bateman
On 02/05/2017 19:00, Remi Forax wrote: Hi Kirk, --patch-module both at compile time and at runtime is what your are looking for. Right, and more details in the "Patching module content" section of JEP 261 [1]. -Alan [1] http://openjdk.java.net/jeps/261#Patching-module-content

Re: 8178380: Module system implementation refresh (5/2017 update)

2017-05-02 Thread Alan Bateman
On 02/05/2017 20:21, stanislav lukyanov wrote: Hi Alan, In the Launcher-Agent-Class, would it make sense to use 'premain' instead of 'agentmain' to align it with Premain-Class rather than with Agent-Class? (maybe even rename Launcher-Agent-Class to Launcher-Premain-Class?) AFAIU

Re: [9] Review request: 8177566: FX user module gets IllegalAccessException from sun.reflect.misc.Trampoline

2017-05-02 Thread Alan Bateman
On 02/05/2017 01:21, Kevin Rushforth wrote: This review is being cross-posted to both openjfx-dev and jigsaw-dev. Please review the proposed fix for: https://bugs.openjdk.java.net/browse/JDK-8177566 http://cr.openjdk.java.net/~kcr/8177566/webrev.00/complete-webrev/ Details of the fix as well

Re: 8178380: Module system implementation refresh (5/2017 update)

2017-05-02 Thread Alan Bateman
On 02/05/2017 03:47, Mandy Chung wrote: : src/share/vm/services/attachListener.cpp 355 // Dynamic loading agents is not default by default typo: s/not default/not enabled? I agree, the comment is confused and better to remove it. src/share/vm/services/diagnosticCommand.cpp 771

hg: jigsaw/jake/hotspot: Remove confusing comment

2017-05-02 Thread alan . bateman
Changeset: 1fc81a6c3d44 Author:alanb Date: 2017-05-02 08:50 +0100 URL: http://hg.openjdk.java.net/jigsaw/jake/hotspot/rev/1fc81a6c3d44 Remove confusing comment ! src/share/vm/services/attachListener.cpp

hg: jigsaw/jake/jdk: 2 new changesets

2017-05-02 Thread alan . bateman
Changeset: f8e726766d59 Author:alanb Date: 2017-05-02 07:52 +0100 URL: http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/f8e726766d59 ModuleFinder.of does not correcly handle JAR files in custom file systems ! src/java.base/share/classes/jdk/internal/module/ModulePath.java +

Re: Accessing module internals from bytecode rewriting agent

2017-05-02 Thread Alan Bateman
On 02/05/2017 07:50, Jeremy Manson wrote: : If we follow this path, before we migrate to Java 9, we would need to make sure all of our code builds and the tests pass with Java 9 and Java 8. We can't make all of the code build and the tests pass with Java 9 as-is, because many of them use

8178380: Module system implementation refresh (5/2017 update)

2017-05-01 Thread Alan Bateman
As I mentioned in another thread, we need to get the changes accumulated in jake to jdk9/dev. JDK-8178380 [1] has the summary of the changes that have accumulated since the last refresh. One note on the hotspot repo is that the changes to dynamically augment the platform modules run into

Re: Dependencies to a root modules when creating a dynamic module layer

2017-05-01 Thread Alan Bateman
On 01/05/2017 18:37, fo...@univ-mlv.fr wrote: : In both cases, the VM adds modules to the configuration like with --add-modules before the boot layer is created, so there are not dynamically loaded. That is the -Dcom.sun.management.jmxremote or -javaagent case. The other case is where a tool

Re: jake -> jdk9/dev

2017-05-01 Thread Alan Bateman
On 01/05/2017 12:48, Stephen Felts wrote: I think this statement is very misleading. As part of this "small changes", jdk.attach.allowAttachSelf will be set to false and everyone that has self-attaching agents will start failing. This is part of the revised proposal that Mark sent to the list

Re: Dependencies to a root modules when creating a dynamic module layer

2017-05-01 Thread Alan Bateman
On 01/05/2017 10:48, Remi Forax wrote: Hi all, i try to load a kind of dynamic plugin using a ModuleLayer, the plugin is wrapped in a module which is loaded dynamically. This module has a requires directive to "java.sql" which is part of the 'root' modules. The problem is that my application

Re: Java Platform Module System

2017-04-30 Thread Alan Bateman
On 30/04/2017 12:10, Stephan Herrmann wrote: : Java 9 could make "API leaks" either illegal or ineffective and thus rule out an entire category of ill-formed programs, which to-date must unfortunately be accepted by module-unaware compilers: (A) Java 9 has the opportunity to say that the

Re: jake -> jdk9/dev

2017-04-29 Thread Alan Bateman
On 29/04/2017 11:04, Stephen Felts wrote: I think that the Java community made it clear that this feature should not be included in JDK9, including going to the effort of writing a paper to that effect at

jake -> jdk9/dev

2017-04-29 Thread Alan Bateman
We have again accumulated quite a few changes in the jake forest and I'd like to bring to jdk9/dev next week. It's all small changes this time, JDK-8178380 [1] has the summary. -Alan [1] https://bugs.openjdk.java.net/browse/JDK-8178380

Re: SecurityManager environments

2017-04-28 Thread Alan Bateman
On 28/04/2017 19:33, Russell Gold wrote: : This only works for executable jars? Not libraries? That is correct. If the executable JAR has Class-Path attributes then whoever is creating the application needs to have a global understanding so that the Add-Exports or Add-Opens has the complete

hg: jigsaw/jake/jdk: Missing "_" from list not allowed in identifier

2017-04-28 Thread alan . bateman
Changeset: 67cc686edb03 Author:alanb Date: 2017-04-28 18:56 +0100 URL: http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/67cc686edb03 Missing "_" from list not allowed in identifier ! src/java.base/share/classes/jdk/internal/module/Checks.java !

hg: jigsaw/jake/hotspot: runtime/modules/JVM* tests failing

2017-04-28 Thread alan . bateman
Changeset: cb4db673f846 Author:alanb Date: 2017-04-28 16:36 +0100 URL: http://hg.openjdk.java.net/jigsaw/jake/hotspot/rev/cb4db673f846 runtime/modules/JVM* tests failing ! test/runtime/modules/JVMAddModuleExports.java ! test/runtime/modules/JVMAddModulePackage.java !

hg: jigsaw/jake/jdk: 3 new changesets

2017-04-28 Thread alan . bateman
Changeset: 9313f1d89ca3 Author:alanb Date: 2017-04-28 14:05 +0100 URL: http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/9313f1d89ca3 Java identifier validation incomplete ! src/java.base/share/classes/jdk/internal/module/Checks.java ! test/java/lang/module/ModuleDescriptorTest.java

hg: jigsaw/jake/jdk: 49 new changesets

2017-04-27 Thread alan . bateman
Changeset: 91b0fe2e552a Author:smarks Date: 2017-04-17 15:51 -0700 URL: http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/91b0fe2e552a 8177789: fix collections framework links to point to java.util package doc Reviewed-by: bchristi, martin !

hg: jigsaw/jake/jaxp: 8 new changesets

2017-04-27 Thread alan . bateman
Changeset: 2fdbfbde3bc0 Author:joehw Date: 2017-04-17 16:24 -0700 URL: http://hg.openjdk.java.net/jigsaw/jake/jaxp/rev/2fdbfbde3bc0 8162572: Update License Header for all JAXP sources Reviewed-by: lancea ! src/java.xml/share/classes/com/sun/org/apache/bcel/internal/Constants.java

hg: jigsaw/jake: 13 new changesets

2017-04-27 Thread alan . bateman
Changeset: d3c1b028c499 Author:shurailine Date: 2017-04-17 19:23 -0700 URL: http://hg.openjdk.java.net/jigsaw/jake/rev/d3c1b028c499 8173801: Modify makefiles to not build demos and samples bundles. Reviewed-by: ihse, prr, erikj ! common/autoconf/spec.gmk.in !

hg: jigsaw/jake/nashorn: 7 new changesets

2017-04-27 Thread alan . bateman
Changeset: 03e5f1316a2d Author:sundar Date: 2017-04-19 14:05 +0530 URL: http://hg.openjdk.java.net/jigsaw/jake/nashorn/rev/03e5f1316a2d 8178954: jjs uses wrong javadoc base URL Reviewed-by: hannesw ! src/jdk.scripting.nashorn.shell/share/classes/jdk/nashorn/tools/jjs/Main.java

hg: jigsaw/jake/hotspot: 8 new changesets

2017-04-27 Thread alan . bateman
Changeset: a92a6f4a454e Author:jlahoda Date: 2017-04-19 13:38 +0200 URL: http://hg.openjdk.java.net/jigsaw/jake/hotspot/rev/a92a6f4a454e 8178012: Finish removal of -Xmodule: Summary: Setting jtreg to use --patch-module instead of -Xmodule:. Reviewed-by: alanb ! test/TEST.ROOT

hg: jigsaw/jake/langtools: 19 new changesets

2017-04-27 Thread alan . bateman
Changeset: 5aa6f825b4ec Author:jjg Date: 2017-04-17 17:03 -0700 URL: http://hg.openjdk.java.net/jigsaw/jake/langtools/rev/5aa6f825b4ec 8162917: langtools/test/tools/javadoc/CompletionError.java is not runnable Reviewed-by: ksrini ! test/tools/javadoc/CompletionError.java

hg: jigsaw/jake/jaxws: 3 new changesets

2017-04-27 Thread alan . bateman
Changeset: 1c610f1b4097 Author:aefimov Date: 2017-04-24 18:21 +0300 URL: http://hg.openjdk.java.net/jigsaw/jake/jaxws/rev/1c610f1b4097 8176168: Performance drop due to SAXParser SymbolTable reset Reviewed-by: joehw, lancea !

hg: jigsaw/jake/corba: 2 new changesets

2017-04-27 Thread alan . bateman
Changeset: 03a2cc9c8a1e Author:lana Date: 2017-04-27 16:07 + URL: http://hg.openjdk.java.net/jigsaw/jake/corba/rev/03a2cc9c8a1e Added tag jdk-9+167 for changeset 43de67f51801 ! .hgtags Changeset: 480115f56220 Author:alanb Date: 2017-04-27 17:17 +0100 URL:

Re: RFR: 8177845: Need a mechanism to load Graal

2017-04-27 Thread Alan Bateman
On 27/04/2017 15:47, Doug Simon wrote: : - The jaotc launcher now needs to explicitly export JVMCI and jdk.internal.vm.compiler to jdk.aot[4]. Unfortunately there needs to be one --add-exports option per qualified export target as combining them with a comma (e.g.,

Re: Auto-modules vs. the unnamed module

2017-04-27 Thread Alan Bateman
On 27/04/2017 15:58, Ceki Gulcu wrote: Hello all, Please forgive my possibly silly question but can someone kindly explain the advantages of placing a non-modular artifact on the module path instead of the class path? In other words, why should the user prefer a non-modular artifact to

hg: jigsaw/jake/jdk: 5 new changesets

2017-04-27 Thread alan . bateman
Changeset: be341882bfba Author:alanb Date: 2017-04-27 11:20 +0100 URL: http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/be341882bfba Add more test cases to ExecJarWithAgent ! test/java/lang/instrument/executableJAR/ExecJarWithAgent.java Changeset: c01aff0ff6bf Author:alanb

Re: setAccessible() alternative with Jigsaw - feedback on Lookup

2017-04-27 Thread Alan Bateman
On 26/04/2017 15:04, Matej Novotny wrote: You can spin one module per package, by creating one ModuleLayer per package, not unlike j.l.r.Proxy does. Don't know a bit about it, but it sounds like a way worth exploring. Would you have a pointer towards some code showing how to deal with

hg: jigsaw/jake/jdk: Reduce ModuleTarget to one target platform value

2017-04-26 Thread alan . bateman
Changeset: a3eb50edd55f Author:alanb Date: 2017-04-26 21:09 +0100 URL: http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/a3eb50edd55f Reduce ModuleTarget to one target platform value ! src/java.base/share/classes/java/lang/module/Configuration.java !

hg: jigsaw/jake/langtools: Reduce ModuleTarget to one target platform value

2017-04-26 Thread alan . bateman
Changeset: 4d2852920d34 Author:alanb Date: 2017-04-26 21:09 +0100 URL: http://hg.openjdk.java.net/jigsaw/jake/langtools/rev/4d2852920d34 Reduce ModuleTarget to one target platform value ! src/jdk.jdeps/share/classes/com/sun/tools/classfile/ClassWriter.java !

Updates to CLI options

2017-04-26 Thread Alan Bateman
Just a quick note on some recent updates to the command line options. Since early builds, `--list-modules` has allowed a module name to be specified so that the option describes a module rather than list the observable modules. This was always a bit strange and has finally been separated into

Re: Alternatives for naming automatic modules, and a proposal (#AutomaticModuleNames)

2017-04-26 Thread Alan Bateman
On 26/04/2017 18:35, Stephen Colebourne wrote: : - an incomplete module defines as many dependencies as it can - an incomplete module also depends on the classpath - the current automatic module concept ceases to exist (an incomplete module is not an automatic module, as it doesn't get to read

Re: setAccessible() alternative with Jigsaw - feedback on Lookup

2017-04-26 Thread Alan Bateman
On 26/04/2017 16:31, fo...@univ-mlv.fr wrote: : 4. create a classloader ClassLoader classLoader = new ClassLoader(parentClassLoader()) { /* make defineClass more visible */}; 5. create your own layer [4] ModuleLayer layer = boot.defineModulesWithOneLoader(cf, classloader;

hg: jigsaw/jake: 8175819: OS name and arch in JMOD files should match the values as in the bundle names

2017-04-26 Thread alan . bateman
Changeset: f5ba193588e2 Author:alanb Date: 2017-04-26 14:10 +0100 URL: http://hg.openjdk.java.net/jigsaw/jake/rev/f5ba193588e2 8175819: OS name and arch in JMOD files should match the values as in the bundle names ! common/autoconf/generated-configure.sh !

hg: jigsaw/jake/jdk: 2 new changesets

2017-04-26 Thread alan . bateman
Changeset: 750ed72c847b Author:mchung Date: 2017-04-20 08:00 -0700 URL: http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/750ed72c847b 8175819: OS name and arch in JMOD files should match the values as in the bundle names Reviewed-by: erikj, ihse !

Re: Alternatives for naming automatic modules, and a proposal (#AutomaticModuleNames)

2017-04-26 Thread Alan Bateman
On 26/04/2017 12:55, Juergen Hoeller wrote: : You're saying that such transitive resolution of automatic modules happens implicitly now, i.e. "requires spring.context" implicitly makes spring.core visible to the application module when both spring.context and spring.core are automatic

<    1   2   3   4   5   6   7   8   9   10   >