hg: jigsaw/jake/jdk: 4 new changesets

2017-02-02 Thread alan . bateman
Changeset: 85331a665469 Author:alanb Date: 2017-02-02 16:28 + URL: http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/85331a665469 Correct values for ACC_TRANSITIVE/ACC_STATIC_PHASE ! src/java.base/share/classes/jdk/internal/module/ClassFileConstants.java Changeset: e26e4e89d174

Re: RFR: 8145337: [JVMCI] JVMCI initialization with SecurityManager installed fails: java.security.AccessControlException: access denied

2017-02-02 Thread Alan Bateman
On 02/02/2017 02:12, Mandy Chung wrote: On Feb 1, 2017, at 3:07 AM, Doug Simon wrote: I’ve reworked the webrev as requested to make jdk.vm.compiler a non-upgradeable platform module, this allowing it to be mentioned in default.policy:

hg: jigsaw/jake/jdk: AccessibleObject javadoc improvements

2017-02-01 Thread alan . bateman
Changeset: 18fb55eee74b Author:alanb Date: 2017-02-01 18:47 + URL: http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/18fb55eee74b AccessibleObject javadoc improvements Contributed-by: alex.buck...@oracle.com ! src/java.base/share/classes/java/lang/reflect/AccessibleObject.java

Re: -Xlog and the module system

2017-02-01 Thread Alan Bateman
On 01/02/2017 14:27, Nicolai Parlog wrote: Hi! When playing with `-Xlog:modules*` (down to trace) I hoped for a little more output that I could use to analyze a configuration. -Xlog:modules is VM oriented and mostly traces the primitives used to construct the module graph in the VM.

Re: The module implementation uses the wrong values for ACC_TRANSITIVE and ACC_STATIC_PHASE

2017-02-01 Thread Alan Bateman
On 30/01/2017 22:15, Remi Forax wrote: Hi all, chasing a bug on ASM, i've found that the module implementation in the JDK uses the wrong values for ACC_TRANSITIVE and ACC_STATIC_PHASE, in the spec [1], 0x0020 (ACC_TRANSITIVE) 0x0040 (ACC_STATIC_PHASE) but in the implementation [2],

Re: RFR 8173717: jlink --help fails with missing "plugin.opt.plugin-module-path" key in resource bundle

2017-02-01 Thread Alan Bateman
On 01/02/2017 05:06, Sundararajan Athijegannathan wrote: Please review http://cr.openjdk.java.net/~sundar/8173717/webrev.00/ for https://bugs.openjdk.java.net/browse/JDK-8173717 Looks good.

Re: java.desktop

2017-01-30 Thread Alan Bateman
On 30/01/2017 16:25, Hontvári Attila wrote: Regarding to the reduction of the java.desktop module size: Has Swing any circular dependency with other java.desktop parts? I know about only one, Desktop::setDefaultJMenuBar, which is only to be introduced in Java 9. If that dependency could be

hg: jigsaw/jake/jdk: 5 new changesets

2017-01-30 Thread alan . bateman
Changeset: 6dc3e3aa8f57 Author:alanb Date: 2017-01-30 12:00 + URL: http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/6dc3e3aa8f57 Module path can ignore non-modules in module directories ! src/java.base/share/classes/java/lang/module/ModuleFinder.java !

Re: Review Request: 8173381: osName/osArch/osVersion is missing in ModuleDescriptor created by SystemModules

2017-01-29 Thread Alan Bateman
On 28/01/2017 20:50, Mandy Chung wrote: : I agree that would be cleaner and made the change. That’s what I started with but that’d leave ModuleTarget attribute in the class file. For the secret option for testing then I assume it should be "retainModuleTarget" rather than

Re: Applications for --limit-modules?

2017-01-28 Thread Alan Bateman
On 28/01/2017 18:39, Nicolai Parlog wrote: Hi Alan, thanks for your reply. Yes testing is a good example, didn't have that idea. So testing and services, then? Yes, and for service providers then you might specify one or two to --limit-modules when converging on the set of service provide

Re: Review Request: 8173381: osName/osArch/osVersion is missing in ModuleDescriptor created by SystemModules

2017-01-28 Thread Alan Bateman
On 27/01/2017 06:21, Mandy Chung wrote: : Updated webrev: http://cr.openjdk.java.net/~mchung/jdk9/webrevs/8173381/webrev.01/ This mostly looks good. I think it would cleaner if the plugin used rewriter.targetPlatform("", "", "") rather than adding filtering to the extender. For the

hg: jigsaw/jake/langtools: 26 new changesets

2017-01-27 Thread alan . bateman
Changeset: 444b89786af3 Author:darcy Date: 2017-01-17 09:40 -0800 URL: http://hg.openjdk.java.net/jigsaw/jake/langtools/rev/444b89786af3 8172686: Use less aggressive deprecation of utility visitors Reviewed-by: jjg, smarks !

hg: jigsaw/jake/jaxp: 4 new changesets

2017-01-27 Thread alan . bateman
Changeset: 7f5f8b336432 Author:mullan Date: 2017-01-19 13:48 -0500 URL: http://hg.openjdk.java.net/jigsaw/jake/jaxp/rev/7f5f8b336432 8055206: Update SecurityManager::checkPackageAccess to restrict non-exported JDK packages by default Reviewed-by: mchung !

hg: jigsaw/jake/jdk: 70 new changesets

2017-01-27 Thread alan . bateman
Changeset: 051e7d9159a7 Author:naoto Date: 2017-01-17 11:34 -0800 URL: http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/051e7d9159a7 8171139: Simplify ResourceBundle.CacheKey and ClassLoader may not be needed Reviewed-by: dfuchs Contributed-by: peter.lev...@gmail.com !

hg: jigsaw/jake/hotspot: 6 new changesets

2017-01-27 Thread alan . bateman
Changeset: 2c3fafbc70b8 Author:rprotacio Date: 2016-07-21 15:49 -0400 URL: http://hg.openjdk.java.net/jigsaw/jake/hotspot/rev/2c3fafbc70b8 8159507: RuntimeVisibleAnnotation validation Reviewed-by: coleenp, hseigel, mschoene, acorn Contributed-by: rachel.prota...@oracle.com !

hg: jigsaw/jake/jaxws: 2 new changesets

2017-01-27 Thread alan . bateman
Changeset: 9b9918656c97 Author:lana Date: 2017-01-26 19:22 + URL: http://hg.openjdk.java.net/jigsaw/jake/jaxws/rev/9b9918656c97 Added tag jdk-9+154 for changeset 34af95c7dbff ! .hgtags Changeset: 0d2ba35ade5b Author:alanb Date: 2017-01-27 08:34 + URL:

hg: jigsaw/jake/corba: 4 new changesets

2017-01-27 Thread alan . bateman
Changeset: 64e3c222a4c6 Author:vinnie Date: 2016-10-06 17:33 +0100 URL: http://hg.openjdk.java.net/jigsaw/jake/corba/rev/64e3c222a4c6 8158997: JNDI Protocols Switch Reviewed-by: dfuchs ! src/java.corba/share/classes/com/sun/jndi/cosnaming/CNBindingEnumeration.java !

hg: jigsaw/jake: 9 new changesets

2017-01-27 Thread alan . bateman
Changeset: 33f8f04ab876 Author:ihse Date: 2017-01-17 14:14 +0100 URL: http://hg.openjdk.java.net/jigsaw/jake/rev/33f8f04ab876 8170863: Always pass MAKE_ARGS to MAKE in Main.gmk Reviewed-by: erikj ! make/Main.gmk Changeset: ec276ecde338 Author:chegar Date: 2017-01-18

hg: jigsaw/jake/nashorn: 2 new changesets

2017-01-27 Thread alan . bateman
Changeset: 336a75b38fd0 Author:lana Date: 2017-01-26 19:22 + URL: http://hg.openjdk.java.net/jigsaw/jake/nashorn/rev/336a75b38fd0 Added tag jdk-9+154 for changeset a84b49cfee63 ! .hgtags Changeset: 4d7d3dc2065c Author:alanb Date: 2017-01-27 08:34 + URL:

Re: RFR 8172864: Remove custom plugin module path

2017-01-27 Thread Alan Bateman
On 27/01/2017 06:45, Sundararajan Athijegannathan wrote: Please review http://cr.openjdk.java.net/~sundar/8172864/webrev.00/ for https://bugs.openjdk.java.net/browse/JDK-8172864 Looks okay to me but less changes than I assumed would be needed. -Alan

hg: jigsaw/jake/hotspot: Update failing runtime/modules tests

2017-01-26 Thread alan . bateman
Changeset: d270fa9dc2c4 Author:alanb Date: 2017-01-26 14:41 + URL: http://hg.openjdk.java.net/jigsaw/jake/hotspot/rev/d270fa9dc2c4 Update failing runtime/modules tests ! test/runtime/modules/IgnoreModulePropertiesTest.java ! test/runtime/modules/ModuleOptionsTest.java

hg: jigsaw/jake/jdk: 2 new changesets

2017-01-26 Thread alan . bateman
Changeset: 1592d65d0123 Author:alanb Date: 2017-01-26 13:03 + URL: http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/1592d65d0123 Change resolve to throw FindException for observability-related reasons Fix handling of constraints on the target platform to work with parent configs

Re: Review Request: 8173381: osName/osArch/osVersion is missing in ModuleDescriptor created by SystemModules

2017-01-26 Thread Alan Bateman
On 26/01/2017 02:15, Mandy Chung wrote: The ModuleTarget attribute is added to java.base and other JDK modules when JMOD file is created but it gets dropped when the system modules plugin reconstitutes the ModuleDescriptor for fast loading. The fix is straight-forward to add

Re: jlink / legal folder and LICENSE

2017-01-25 Thread Alan Bateman
On 25/01/2017 10:53, fo...@univ-mlv.fr wrote: : I mean legal/java.base/LICENSE in jdk9. The EA builds that Oracle publishes on jdk9.java.net have a LICENSE file that links to the BCL on oracle.com. AFAIK, this link has not changed, it's not really something that we have any control of here.

Re: jlink / legal folder and LICENSE

2017-01-25 Thread Alan Bateman
On 25/01/2017 10:41, fo...@univ-mlv.fr wrote: This one, the OpenJDK license (GLPv2 + classpath exception) http://openjdk.java.net/legal/gplv2+ce.html Do you mean legal/java.base/LICENSE? Also are you saying the LICENSE file is missing in the build or when you create a run-time image with

Re: ModuleReferenceImpl has no toString

2017-01-25 Thread Alan Bateman
On 24/01/2017 21:07, Remi Forax wrote: Hi all, This is a regression introduced in b149 i believe, jdk.internal.module.ModuleReferenceImpl has no toString() which makes the debugging of a configuration harder than it should. I believe the toString() can be added to ModuleReference given this

Re: jlink / legal folder and LICENSE

2017-01-25 Thread Alan Bateman
On 25/01/2017 09:03, Remi Forax wrote: Hi all, i've noticed that jlink now creates a folder legal that contains the Oracle copyright, the license of the third parties software used but the LICENSE of the openjdk is missing. Which LICENSE file are you saying is missing? There has been

hg: jigsaw/jake/jdk: More javadoc cleanup

2017-01-24 Thread alan . bateman
Changeset: ab671370be6a Author:alanb Date: 2017-01-24 14:52 + URL: http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/ab671370be6a More javadoc cleanup ! src/java.base/share/classes/java/lang/ClassLoader.java ! src/java.base/share/classes/java/lang/module/Configuration.java !

Re: javac bug when calling javac from the ToolProvider

2017-01-24 Thread Alan Bateman
On 24/01/2017 10:59, Remi Forax wrote: Hi all, when calling javac from the ToolProvider, i get a NPE with the jdkb152/b153. in getLocationForModule(Path), pathLocations can be null Location getLocationForModule(Path dir) { return pathLocations.get(dir); }

hg: jigsaw/jake/jdk: 3 new changesets

2017-01-23 Thread alan . bateman
Changeset: b057c9fbbf47 Author:alanb Date: 2017-01-23 17:59 + URL: http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/b057c9fbbf47 Improve javadoc for getResourceAsStream ! src/java.base/share/classes/java/lang/Class.java ! src/java.base/share/classes/java/lang/reflect/Module.java

hg: jigsaw/jake/jdk: 4 new changesets

2017-01-22 Thread alan . bateman
Changeset: dc2af8bfd11b Author:alanb Date: 2017-01-22 17:35 + URL: http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/dc2af8bfd11b ServiceLoader spec clarification ! src/java.base/share/classes/java/util/ServiceLoader.java Changeset: 11b3699836fb Author:alanb Date:

Re: java.desktop

2017-01-21 Thread Alan Bateman
On 21/01/2017 14:00, Michał Zegan wrote: Hi. Is java.desktop now divided in separate parts, or are there plans to do so? Because actually the whole point of your application having no unneeded dependencies is broken if you want java.beans, and suddenly get the whole desktop apis that are

Re: Loading resources from another module

2017-01-21 Thread Alan Bateman
On 21/01/2017 19:18, Sander Mak wrote: I have module A trying to read a resource in module B. The resource is in module B under 'pkg/resource.txt' and if I understood [1] correctly should be encapsulated by default. There are no opens/exports statements in module B's module-info. Module A

Re: Review Request: JDK-8173096 jmod files are not world-readable

2017-01-21 Thread Alan Bateman
On 21/01/2017 02:32, Mandy Chung wrote: Updated webrev to put the temporary file in the same containing directory of the target file: http://cr.openjdk.java.net/~mchung/jdk9/webrevs/8173096/webrev.01 I want to fix this regression in jdk-9+154. We can revisit the approach after this fix

Re: Review Request: JDK-8173096 jmod files are not world-readable

2017-01-20 Thread Alan Bateman
On 20/01/2017 20:37, Peter Levart wrote: I guess the JmodTask is creating a temp file because it wants the file to not be observed by other processes while it is being written to, right? At the end when the tempTarget is fully written, it is renamed to its intended name with:

hg: jigsaw/jake/langtools: 21 new changesets

2017-01-20 Thread alan . bateman
Changeset: 5ec5a14e1627 Author:jlahoda Date: 2017-01-09 16:44 +0100 URL: http://hg.openjdk.java.net/jigsaw/jake/langtools/rev/5ec5a14e1627 8172411: -XDnoModules must be removed Reviewed-by: jjg ! src/jdk.compiler/share/classes/com/sun/tools/javac/code/Symtab.java !

hg: jigsaw/jake/jdk: 52 new changesets

2017-01-20 Thread alan . bateman
Changeset: d93e93939378 Author:mli Date: 2017-01-09 14:14 -0800 URL: http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/d93e93939378 8172347: Refactoring src/java.rmi/share/classes/sun/rmi/registry/RegistryImpl.java to improve testability of rmiregistry Reviewed-by: rriggs, msheppar

hg: jigsaw/jake/nashorn: 6 new changesets

2017-01-20 Thread alan . bateman
Changeset: 6b43eb787db4 Author:sundar Date: 2017-01-10 18:50 +0530 URL: http://hg.openjdk.java.net/jigsaw/jake/nashorn/rev/6b43eb787db4 8172493: Nashorn FX example 3-4 using load for fx: scripts fails to run with latest jdk9 ea build Reviewed-by: hannesw, jlaskey !

hg: jigsaw/jake/corba: 2 new changesets

2017-01-20 Thread alan . bateman
Changeset: d66f97a610a6 Author:lana Date: 2017-01-19 22:31 + URL: http://hg.openjdk.java.net/jigsaw/jake/corba/rev/d66f97a610a6 Added tag jdk-9+153 for changeset 68a8e8658511 ! .hgtags Changeset: 15bf1182a36c Author:alanb Date: 2017-01-20 11:45 + URL:

hg: jigsaw/jake: 17 new changesets

2017-01-20 Thread alan . bateman
Changeset: 4650659a4f55 Author:erikj Date: 2017-01-10 11:23 +0100 URL: http://hg.openjdk.java.net/jigsaw/jake/rev/4650659a4f55 8172241: Cleanup mistakes in jib publish support change Reviewed-by: tbell ! common/autoconf/spec.gmk.in ! common/conf/jib-profiles.js ! make/Bundles.gmk

hg: jigsaw/jake/jaxws: 5 new changesets

2017-01-20 Thread alan . bateman
Changeset: a98174edd246 Author:aefimov Date: 2017-01-10 22:15 +0300 URL: http://hg.openjdk.java.net/jigsaw/jake/jaxws/rev/a98174edd246 8159058: SAXParseException when sending soap message Reviewed-by: lancea !

hg: jigsaw/jake/jaxp: 5 new changesets

2017-01-20 Thread alan . bateman
Changeset: 8c9a2a24752b Author:joehw Date: 2017-01-11 13:06 -0800 URL: http://hg.openjdk.java.net/jigsaw/jake/jaxp/rev/8c9a2a24752b 8171243: CatalogManager.catalogResolver throws FileSystemNotFoundException with jar Reviewed-by: rriggs, dfuchs, lancea, alanb !

hg: jigsaw/jake/hotspot: 2 new changesets

2017-01-20 Thread alan . bateman
Changeset: fc7e94cb7485 Author:lana Date: 2017-01-19 22:31 + URL: http://hg.openjdk.java.net/jigsaw/jake/hotspot/rev/fc7e94cb7485 Added tag jdk-9+153 for changeset 217ba81b9a4c ! .hgtags Changeset: 68e5712046cb Author:alanb Date: 2017-01-20 11:38 + URL:

hg: jigsaw/jake/jdk: More javadoc clean-up

2017-01-20 Thread alan . bateman
Changeset: 9cf519e0821d Author:alanb Date: 2017-01-20 11:30 + URL: http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/9cf519e0821d More javadoc clean-up ! src/java.base/share/classes/java/lang/module/Configuration.java !

hg: jigsaw/jake/jdk: Misc javadoc cleanup

2017-01-19 Thread alan . bateman
Changeset: 1acc7a2782b7 Author:alanb Date: 2017-01-19 14:48 + URL: http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/1acc7a2782b7 Misc javadoc cleanup ! src/java.base/share/classes/java/lang/module/Configuration.java ! src/java.base/share/classes/java/lang/reflect/Layer.java !

hg: jigsaw/jake/jdk: Javadoc clarification to ModuleDescriptor.read

2017-01-19 Thread alan . bateman
Changeset: 147cf9bc6d95 Author:alanb Date: 2017-01-19 13:19 + URL: http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/147cf9bc6d95 Javadoc clarification to ModuleDescriptor.read ! src/java.base/share/classes/java/lang/module/ModuleDescriptor.java !

Re: AW: [JDK-8153077] JNLP example with -XaddExports

2017-01-19 Thread Alan Bateman
On 19/01/2017 09:35, Reto Merz wrote: One more question: Is it possible to use --add-opens in JNLP ? We have try this: This seems not to work/legal, or we use the wrong syntax: Java Web Start Error: Unable to make field private final byte[] java.lang.String.value accessible: module

hg: jigsaw/jake/jdk: 3 new changesets

2017-01-19 Thread alan . bateman
Changeset: e009619d6703 Author:alanb Date: 2017-01-18 16:05 + URL: http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/e009619d6703 Patching an automatic module may add packages ! src/java.base/share/classes/jdk/internal/module/ModulePatcher.java Changeset: ccef30b77f12 Author:

hg: jigsaw/jake/langtools: Residual reference to resolveRequiresAndUses

2017-01-19 Thread alan . bateman
Changeset: 541d0529255a Author:alanb Date: 2017-01-19 08:39 + URL: http://hg.openjdk.java.net/jigsaw/jake/langtools/rev/541d0529255a Residual reference to resolveRequiresAndUses ! make/tools/crules/MutableFieldsAnalyzer.java

hg: jigsaw/jake/langtools: jshell tests fail as KullaTesting uses resolveRequires

2017-01-18 Thread alan . bateman
Changeset: d5141c15aa1d Author:alanb Date: 2017-01-18 19:52 + URL: http://hg.openjdk.java.net/jigsaw/jake/langtools/rev/d5141c15aa1d jshell tests fail as KullaTesting uses resolveRequires ! test/jdk/jshell/KullaTesting.java !

hg: jigsaw/jake/langtools: resolveRequires/resolveRequiresAndUses -> resolve/resolveAndBind

2017-01-18 Thread alan . bateman
Changeset: 6d8f7ff2ac37 Author:alanb Date: 2017-01-18 14:12 + URL: http://hg.openjdk.java.net/jigsaw/jake/langtools/rev/6d8f7ff2ac37 resolveRequires/resolveRequiresAndUses -> resolve/resolveAndBind ! src/jdk.compiler/share/classes/com/sun/tools/javac/file/JavacFileManager.java

hg: jigsaw/jake/nashorn: resolveRequires/resolveRequiresAndUses -> resolve/resolveAndBind

2017-01-18 Thread alan . bateman
Changeset: 38cf77ce5d45 Author:alanb Date: 2017-01-18 14:12 + URL: http://hg.openjdk.java.net/jigsaw/jake/nashorn/rev/38cf77ce5d45 resolveRequires/resolveRequiresAndUses -> resolve/resolveAndBind !

hg: jigsaw/jake/jaxp: resolveRequires/resolveRequiresAndUses -> resolve/resolveAndBind

2017-01-18 Thread alan . bateman
Changeset: 00f7f4435cdb Author:alanb Date: 2017-01-18 14:11 + URL: http://hg.openjdk.java.net/jigsaw/jake/jaxp/rev/00f7f4435cdb resolveRequires/resolveRequiresAndUses -> resolve/resolveAndBind !

Re: [JDK-8153077] JNLP example with -XaddExports

2017-01-18 Thread Alan Bateman
On 18/01/2017 13:35, Reto Merz wrote: Hello, Is there any documentation or a public available working example how to use -XaddExports for WebStart apps ? I have no acces to the example mentioned in JDK-8153077. We try this: I suspect this is what you want (and should be allowed because

Re: Fwd: resource location problem in JDK 9 from build 148 onward

2017-01-18 Thread Alan Bateman
On 18/01/2017 01:21, Rick Hillegas wrote: Thanks, David and Alan. The suggested workaround works for me. I will mouse your response into the commentary on https://issues.apache.org/jira/browse/DERBY-6856, where I have been collecting all of the issues I've encountered when building and

Re: Review request: JDK-8172870 test/tools/jmod/JmodTest.java fails on windows with AccessDeniedException

2017-01-17 Thread Alan Bateman
On 17/01/2017 21:23, Mandy Chung wrote: This test case attempts to verify that the temp file created by jmod is cleaned up and removed if jmod create command fails. It first cleans up any temp files matching the prefix and suffix created for this test case. The test fails because the fix

hg: jigsaw/jake/jdk: 2 new changesets

2017-01-17 Thread alan . bateman
Changeset: f92bf219c0ec Author:alanb Date: 2017-01-17 12:55 + URL: http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/f92bf219c0ec Further clean-up of automatic module support ! src/java.base/share/classes/java/lang/module/ModuleDescriptor.java !

Re: Compact profile modules

2017-01-17 Thread Alan Bateman
On 17/01/2017 10:07, Uwe Schindler wrote: : Are only the modules removed, and the javac options are still available? We are compiling Apache Lucene Core using the compact1 profile currently: So we append "-profile compact1" when invoking javac. We have not noticed any problems when

Re: Fwd: resource location problem in JDK 9 from build 148 onward

2017-01-17 Thread Alan Bateman
On 17/01/2017 00:55, Rick Hillegas wrote: : public class public class ResourceLocationProblem { public static void main(String... args) throws Exception { String resourceName = "/META-INF/MANIFEST.MF"; Class dummyClass = (new Object()).getClass(); Object is =

Re: Compact profile modules

2017-01-16 Thread Alan Bateman
On 17/01/2017 01:04, David Holmes wrote: I would assume however that we will clearly document how to go from a compact profile to using jlink to produce a comparable JRE? At a minimum, given the compact profiles were defined at the package-level, we should document which modules are needed

Re: RFR 8171380: Remove exports from jdk.jlink

2017-01-16 Thread Alan Bateman
On 16/01/2017 15:46, Chris Hegarty wrote: The Jlink Plugin API is not going to be supported in 9, so should not be exported [1], for use by third parties. Besides the removal of the export, most of the changes are adding @modules tags to existing tests.

hg: jigsaw/jake/nashorn: More ModuleDescriptor/Builder cleanup

2017-01-16 Thread alan . bateman
Changeset: bf5488cc3bf9 Author:alanb Date: 2017-01-16 15:56 + URL: http://hg.openjdk.java.net/jigsaw/jake/nashorn/rev/bf5488cc3bf9 More ModuleDescriptor/Builder cleanup ! src/jdk.scripting.nashorn/share/classes/jdk/nashorn/internal/runtime/ScriptLoader.java !

hg: jigsaw/jake/langtools: More ModuleDescriptor/Builder cleanup

2017-01-16 Thread alan . bateman
Changeset: a4793508705b Author:alanb Date: 2017-01-16 15:57 + URL: http://hg.openjdk.java.net/jigsaw/jake/langtools/rev/a4793508705b More ModuleDescriptor/Builder cleanup ! src/jdk.jdeps/share/classes/com/sun/tools/jdeps/JdepsConfiguration.java !

hg: jigsaw/jake/jdk: More ModuleDescriptor/Builder cleanup

2017-01-16 Thread alan . bateman
Changeset: a6ec366d2a13 Author:alanb Date: 2017-01-16 16:05 + URL: http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/a6ec366d2a13 More ModuleDescriptor/Builder cleanup ! src/java.base/share/classes/java/lang/module/Configuration.java !

hg: jigsaw/jake/hotspot: More ModuleDescriptor/Builder cleanup

2017-01-16 Thread alan . bateman
Changeset: 8e94614e5fd4 Author:alanb Date: 2017-01-16 15:57 + URL: http://hg.openjdk.java.net/jigsaw/jake/hotspot/rev/8e94614e5fd4 More ModuleDescriptor/Builder cleanup ! test/runtime/modules/AccessCheck/CheckRead.java ! test/runtime/modules/AccessCheck/DiffCL_CheckRead.java !

hg: jigsaw/jake/jaxp: More ModuleDescriptor/Builder cleanup

2017-01-16 Thread alan . bateman
Changeset: 84cfa748d9d0 Author:alanb Date: 2017-01-16 15:57 + URL: http://hg.openjdk.java.net/jigsaw/jake/jaxp/rev/84cfa748d9d0 More ModuleDescriptor/Builder cleanup ! src/java.xml/share/classes/com/sun/org/apache/xalan/internal/xsltc/trax/TemplatesImpl.java

Re: RFR 8172422: jarsigner needs to understand -?

2017-01-16 Thread Alan Bateman
On 16/01/2017 01:41, Weijun Wang wrote: Please review the code change at http://cr.openjdk.java.net/~weijun/8172529/webrev.02 The validator is updated to be a PKIXValidator of the Validator.VAR_CODE_SIGNING variant. In order to have the same output message and exit code as before, the

hg: jigsaw/jake/jdk: Clarify javadoc for cases where builder throws IllegalArgumentException

2017-01-13 Thread alan . bateman
Changeset: 5bbbdf80c043 Author:alanb Date: 2017-01-13 17:45 + URL: http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/5bbbdf80c043 Clarify javadoc for cases where builder throws IllegalArgumentException ! src/java.base/share/classes/java/lang/module/ModuleDescriptor.java

hg: jigsaw/jake/jdk: 2 new changesets

2017-01-13 Thread alan . bateman
Changeset: 0c3c4c0097c7 Author:alanb Date: 2017-01-13 15:21 + URL: http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/0c3c4c0097c7 Further clarifications to builder javadoc ! src/java.base/share/classes/java/lang/module/ModuleDescriptor.java !

Re: Review Request JDK-8160286: jmod hash is creating unlinkable modules.

2017-01-13 Thread Alan Bateman
On 13/01/2017 05:13, Mandy Chung wrote: Updated webrev: http://cr.openjdk.java.net/~mchung/jdk9/webrevs/8160286/webrev.01/ I did a further clean up and ModuleHashesBuilder now has one constructor. Also updated the comment to avoid using the term “base”. Due to the refactoring, I moved the

Re: #CompileTimeDependencies and module resolution

2017-01-13 Thread Alan Bateman
On 13/01/2017 12:48, Sander Mak wrote: : Alternatively, you can view optional dependency usage more like 'if the application already uses A, then Lib should also use A as well' in which case your suggested setup and the current implementation make total sense. This does make the example I

Re: #CompileTimeDependencies and module resolution

2017-01-13 Thread Alan Bateman
On 13/01/2017 11:08, Remi Forax wrote: Hi Sander, you're right, it's a bug, --add-modules should not be necessary. Rémi I don't think there is a bug here. Instead the example that Sander has chosen doesn't resolve a module that `requires B`. The "Notes" section in #CompileTimeDependences

hg: jigsaw/jake/jdk: 26 new changesets

2017-01-13 Thread alan . bateman
Changeset: 81b1a6a91b91 Author:xuelei Date: 2017-01-04 00:08 + URL: http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/81b1a6a91b91 8172217: Need debug log for the intermittent failure of AnonCipherWithWantClientAuth Reviewed-by: weijun !

hg: jigsaw/jake/corba: 2 new changesets

2017-01-13 Thread alan . bateman
Changeset: 68a8e8658511 Author:lana Date: 2017-01-12 23:41 + URL: http://hg.openjdk.java.net/jigsaw/jake/corba/rev/68a8e8658511 Added tag jdk-9+152 for changeset ff8cb43c07c0 ! .hgtags Changeset: f5774ba60ae9 Author:alanb Date: 2017-01-13 08:31 + URL:

hg: jigsaw/jake/langtools: 16 new changesets

2017-01-13 Thread alan . bateman
Changeset: 9d2379f8dd41 Author:dlsmith Date: 2017-01-03 16:27 -0700 URL: http://hg.openjdk.java.net/jigsaw/jake/langtools/rev/9d2379f8dd41 8144066: StackOverflowException when computing glb Reviewed-by: mcimadamore !

hg: jigsaw/jake/hotspot: 3 new changesets

2017-01-13 Thread alan . bateman
Changeset: 31f1d26c60df Author:erikj Date: 2017-01-09 11:55 +0100 URL: http://hg.openjdk.java.net/jigsaw/jake/hotspot/rev/31f1d26c60df 8172037: Change log message of SetupCopyFiles Reviewed-by: tbell ! make/CopyToExplodedJdk.gmk Changeset: 217ba81b9a4c Author:lana Date:

hg: jigsaw/jake: 7 new changesets

2017-01-13 Thread alan . bateman
Changeset: 6309db93b5df Author:erikj Date: 2017-01-04 16:12 +0100 URL: http://hg.openjdk.java.net/jigsaw/jake/rev/6309db93b5df 8171922: Hotspot code coverage doesn't seem to work Reviewed-by: tbell ! common/autoconf/flags.m4 ! common/autoconf/generated-configure.sh !

hg: jigsaw/jake/nashorn: 5 new changesets

2017-01-13 Thread alan . bateman
Changeset: 4ec3a2683655 Author:sundar Date: 2017-01-03 22:14 +0530 URL: http://hg.openjdk.java.net/jigsaw/jake/nashorn/rev/4ec3a2683655 8172183: Provide a javadoc description for jdk.dynalink module Reviewed-by: attila, jlaskey ! README - RELEASE_README !

hg: jigsaw/jake/jaxws: 2 new changesets

2017-01-13 Thread alan . bateman
Changeset: 8da2ea3bc3a9 Author:lana Date: 2017-01-12 23:41 + URL: http://hg.openjdk.java.net/jigsaw/jake/jaxws/rev/8da2ea3bc3a9 Added tag jdk-9+152 for changeset 6f8fb1cf7e5f ! .hgtags Changeset: 7cd4b35e4f3a Author:alanb Date: 2017-01-13 08:31 + URL:

hg: jigsaw/jake/jaxp: 2 new changesets

2017-01-13 Thread alan . bateman
Changeset: 56cedce06f2d Author:lana Date: 2017-01-12 23:41 + URL: http://hg.openjdk.java.net/jigsaw/jake/jaxp/rev/56cedce06f2d Added tag jdk-9+152 for changeset 7e3da313b174 ! .hgtags Changeset: ddb2cfe470a8 Author:alanb Date: 2017-01-13 08:31 + URL:

hg: jigsaw/jake/jdk: 2 new changesets

2017-01-12 Thread alan . bateman
Changeset: b25d0291eee9 Author:alanb Date: 2017-01-12 14:27 + URL: http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/b25d0291eee9 Automatic modules can skip packages that don't have class files ! src/java.base/share/classes/java/lang/module/ModuleDescriptor.java !

Re: Review Request JDK-8160286: jmod hash is creating unlinkable modules.

2017-01-12 Thread Alan Bateman
On 11/01/2017 23:47, Mandy Chung wrote: Webrev: http://cr.openjdk.java.net/~mchung/jdk9/webrevs/8160286/webrev.00/ jmod and jar -—hash-modules option to specify a pattern of modules to be hashed in the module M being created. It records the modules that depend on M directly and indirectly.

hg: jigsaw/jake/jdk: 3 new changesets

2017-01-11 Thread alan . bateman
Changeset: cfb72409024e Author:alanb Date: 2017-01-11 09:33 + URL: http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/cfb72409024e DEBUG_ADD_OPENS does not need to imply debugModuleAccessChecks=access ! src/java.base/share/classes/jdk/internal/module/ModuleBootstrap.java !

Re: Suggestion: allow accessible reflection on protected methods of exported types.

2017-01-10 Thread Alan Bateman
On 10/01/2017 17:16, Andrew Dinn wrote: : The version which uses Lookups only needs to tweak the exports for one module i.e. java.base. It modifies java.base to 'export open' package java.lang.invoke to the Byteman module. That then allows Byteman to call the private constructor for

hg: jigsaw/jake/jdk: 2 new changesets

2017-01-10 Thread alan . bateman
Changeset: 991bfbc90719 Author:alanb Date: 2017-01-09 12:33 + URL: http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/991bfbc90719 Improve checking in Builder API ! src/java.base/share/classes/java/lang/module/Configuration.java !

Re: RFR: 8171855: Move package name transformations during module bootstrap into native code

2017-01-06 Thread Alan Bateman
On 06/01/2017 13:18, Claes Redestad wrote: : Updated jdk webrev in-place: http://cr.openjdk.java.net/~redestad/8171855/jdk.04/ I looked through the latest webrev and it looks quite good. Part of me regrets introducing JNI code of course but this is startup motivated. In Module.c then I

Re: Using java.awt.Toolkit.getDefaultToolkit().getScreenSize() reflectively causes InaccessibleObjectException

2017-01-06 Thread Alan Bateman
On 06/01/2017 12:26, Rony G. Flatscher wrote: Alan, thank you for your pointer. The code shown in [1] currently needs to access Java 9 features (to test whether the module is exported), which might not be a possibility for Java libraries that have a baseline like Java 1.4 (the GA version of

hg: jigsaw/jake/jdk: 36 new changesets

2017-01-06 Thread alan . bateman
Changeset: 3ebc973c5dc1 Author:mli Date: 2016-12-20 17:34 -0800 URL: http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/3ebc973c5dc1 8029360: java/rmi/transport/dgcDeadLock/DGCDeadLock.java failing intermittently Reviewed-by: dfuchs ! test/ProblemList.txt !

hg: jigsaw/jake: 14 new changesets

2017-01-06 Thread alan . bateman
Changeset: acf8119d2b86 Author:erikj Date: 2016-12-21 13:30 +0100 URL: http://hg.openjdk.java.net/jigsaw/jake/rev/acf8119d2b86 8170741: Enable uploading of built artifacts through Jib Reviewed-by: ihse ! common/autoconf/generated-configure.sh ! common/autoconf/jdk-version.m4 !

hg: jigsaw/jake/hotspot: 57 new changesets

2017-01-06 Thread alan . bateman
Changeset: 950181a0bb03 Author:dlong Date: 2016-12-20 20:38 -0800 URL: http://hg.openjdk.java.net/jigsaw/jake/hotspot/rev/950181a0bb03 8169938: [AOT] SIGSEGV at ~BufferBlob::vtable chunks Summary: set "return_oop" on AOT scopes Reviewed-by: kvn, never !

hg: jigsaw/jake/jaxws: 2 new changesets

2017-01-06 Thread alan . bateman
Changeset: 6f8fb1cf7e5f Author:lana Date: 2017-01-05 17:51 + URL: http://hg.openjdk.java.net/jigsaw/jake/jaxws/rev/6f8fb1cf7e5f Added tag jdk-9+151 for changeset c48b4d4768b1 ! .hgtags Changeset: 275de5f15ce3 Author:alanb Date: 2017-01-06 08:42 + URL:

hg: jigsaw/jake/langtools: 9 new changesets

2017-01-06 Thread alan . bateman
Changeset: 51b3b07c0b4f Author:erikj Date: 2016-12-14 16:32 +0100 URL: http://hg.openjdk.java.net/jigsaw/jake/langtools/rev/51b3b07c0b4f 8170741: Enable uploading of built artifacts through Jib Reviewed-by: ihse ! test/Makefile Changeset: 605b0823d19b Author:rfield Date:

hg: jigsaw/jake/jaxp: 2 new changesets

2017-01-06 Thread alan . bateman
Changeset: 7e3da313b174 Author:lana Date: 2017-01-05 17:51 + URL: http://hg.openjdk.java.net/jigsaw/jake/jaxp/rev/7e3da313b174 Added tag jdk-9+151 for changeset 13c6906bfc86 ! .hgtags Changeset: 3d224fea4bff Author:alanb Date: 2017-01-06 08:41 + URL:

Re: Using java.awt.Toolkit.getDefaultToolkit().getScreenSize() reflectively causes InaccessibleObjectException

2017-01-06 Thread Alan Bateman
On 05/01/2017 20:07, Phil Race wrote: Sort of .. it depends whether you could use getDeclaredMethod instead. One question I have is, how would you update the code if you were given the instance "foo", and need to programmatically work out what is the correct super-type of Foo that exports the

Re: Proposed enhancement to Layer API

2017-01-05 Thread Alan Bateman
On 04/01/2017 15:15, Thomas Watson wrote: : In theory fragments can be dynamically attached to an already resolved host (module) which implies that we need to be able to dynamically add packages to the existing host module. With that in mind, if we wanted to support dynamic attachment of

Re: Valid characters in a module name

2017-01-05 Thread Alan Bateman
On 05/01/2017 08:22, Ess Kay wrote: No, that's not how it works at all ... Only container code will be creating or referencing such modules This may be true for JBoss & JEE modules. I see "Java EE modules" have been mentioned a few times in this thread. Aside from the word "module" then I'm

Re: Proposed enhancement to Layer API

2017-01-04 Thread Alan Bateman
On 04/01/2017 14:21, David M. Lloyd wrote: We need the ability to add content to a module after it is defined to support our existing deployment architecture. Is there a material problem with having this feature, other than transgressing your sense of "should"? Can you expand a bit on this?

Re: Suggestion: allow accessible reflection on protected methods of exported types.

2017-01-03 Thread Alan Bateman
On 03/01/2017 18:13, Jochen Theodorou wrote: You sound as if there are equal good alternative solutions to all these cases. For example changing the environment for a subprocess after its creation No, there is no clean solution. The only solution that does not require an opens is to do

Re: RFR: 8171855: Move package name transformations during module bootstrap into VM

2017-01-03 Thread Alan Bateman
On 03/01/2017 16:44, Claes Redestad wrote: : get_module_by_package_name is only used by the whitebox API and it seems the test using this was already using internal form. JVM_GetModuleByPackageName appears to be unused. Could this be cleaned up? This may be a leftover from when we were

Re: Suggestion: allow accessible reflection on protected methods of exported types.

2017-01-03 Thread Alan Bateman
On 29/12/2016 16:24, Rafael Winterhalter wrote: : I argue that this module system should not be responsible to assert the usage of such protected methods on exported types. Such methods are not really encapsulated as they are considered official API by subclasses. Right, they are intended to

<    5   6   7   8   9   10   11   12   13   14   >