Hi Karen,
On 18 Jun 2015, at 16:59, Karen Kinnear wrote:
> Code review for the hotspot component:
>
> Thank you for the cleanups to jvm.cpp to make them JVM_ENTRY and fix
> thread_state.
>
You are welcome.
> If you pass the testing and Lois ok's the hotspot code, then I am ok with
> checking
Hi Lois,
On 18 Jun 2015, at 19:55, Lois Foltan wrote:
>
> On 6/18/2015 10:59 AM, Karen Kinnear wrote:
>> Code review for the hotspot component:
>>
>> Thank you for the cleanups to jvm.cpp to make them JVM_ENTRY and fix
>> thread_state.
>>
>> If you pass the testing and Lois ok's the hotspot
On 18 Jun 2015, at 20:48, Mandy Chung wrote:
> http://cr.openjdk.java.net/~jlaskey/hs-rt-jimage/webrev-top
>modules.xml looks fine.
>
>test/lib/sun/hotspot/WhiteBox.java
>This adds the native entry points. Where are they implemented? It’s
> not obvious to me.
The native is
Hi Mandy,
I logged https://bugs.openjdk.java.net/browse/JDK-8129343
Thanks.
JF
On 19 Jun 2015, at 16:26, Mandy Chung wrote:
>
>> On Jun 19, 2015, at 6:27 AM, Alan Bateman wrote:
>>
>>
>>
>> On 18/06/2015 19:48, Mandy Chung wrote:
>>> :
>>>
>>> test/java/nio/Buffer/LimitDirectMemory.sh
>>>
Hi Paul,
On 19 Jun 2015, at 16:39, Paul Sandoz wrote:
>
> On Jun 18, 2015, at 2:08 AM, Jim Laskey (Oracle)
> wrote:
>
>> https://bugs.openjdk.java.net/browse/JDK-8080511
>>
>> This is an long overdue refresh of the jimage support in the JDK9-dev repo.
>> This includes native support for r
https://bugs.openjdk.java.net/browse/JDK-8129592
Thanks.
JF
On 23 Jun 2015, at 14:10, Jean-Francois Denise
wrote:
> Hi Paul,
>
> On 19 Jun 2015, at 16:39, Paul Sandoz wrote:
>
>>
>> On Jun 18, 2015, at 2:08 AM, Jim Laskey (Oracle)
>> wrote:
>>
>
Hi,
asking review for this bug fix.
http://cr.openjdk.java.net/~jfdenise/JDK-8130344/
Thanks.
JF
Thanks Alan,
I had read the spec from
https://docs.oracle.com/javase/8/docs/technotes/guides/jni/spec/functions.html#array_operations
And it was not clear.
On 10 Jul 2015, at 18:34, Alan Bateman wrote:
>
>
> On 10/07/2015 16:46, Jean-Francois Denise wrote:
>> Hi,
>> a
Thank you,
I am removing the null check and throw.
JF
On 13 Jul 2015, at 08:06, David Holmes wrote:
> On 11/07/2015 2:45 AM, Jean-Francois Denise wrote:
>> Thanks Alan,
>> I had read the spec from
>> https://docs.oracle.com/javase/8/docs/technotes/guides/jn
In the Java code, I understand that it is useless, an OOM will be thrown.
JF
On 13 Jul 2015, at 11:16, David Holmes wrote:
> On 13/07/2015 6:06 PM, Jean-Francois Denise wrote:
>> Thank you,
>> I am removing the null check and throw.
>
> Why are you removing them ??
>
&g
The updated fix: http://cr.openjdk.java.net/~jfdenise/JDK-8130344-2/
On 13 Jul 2015, at 12:09, Jean-Francois Denise
wrote:
> In the Java code, I understand that it is useless, an OOM will be thrown.
> JF
> On 13 Jul 2015, at 11:16, David Holmes wrote:
>
>> On 13/07/
Ok,
yes, I read too quickly your reply, I will keep the check and throw an OOME
On 13 Jul 2015, at 13:10, David Holmes wrote:
> On 13/07/2015 8:09 PM, Jean-Francois Denise wrote:
>> In the Java code, I understand that it is useless, an OOM will be thrown.
>
> No, an OOM _may_
Hi,
please review fix for: https://bugs.openjdk.java.net/browse/JDK-8131317
I took the opportunity of this fix to simplify ImageResourcesTree.java a bit.
http://cr.openjdk.java.net/~jfdenise/8131317/
Thanks.
JF
Hi,
asking for review to fix jimage recreate that is failing with NPE. Bug is
http://cr.openjdk.java.net/~jfdenise/JDK-8132335/
Thanks.
JF
I forget to add details on the fix. The fileName formatting was not correct,
the call to getRoot() was not right. I replaced it with getFileName() + removal
of .jimage extension.
JF
On 24 Jul 2015, at 17:29, Jean-Francois Denise
wrote:
> Hi,
> asking for review to fix jimage recreate t
or in jdk?
> It seems that IntelliJ also broken in some way so it cannot take classes from
> the jdk9 after this fix. probably they should update jrt-fs.jar?
>
>
> On 23.06.15 19:08, Jean-Francois Denise wrote:
>> Hi,
>> an updated webrev that takes into account reviews.
25 Jul 2015, at 09:16, Alan Bateman wrote:
> On 24/07/2015 17:19, Jean-Francois Denise wrote:
>> I forget to add details on the fix. The fileName formatting was not correct,
>> the call to getRoot() was not right. I replaced it with getFileName() +
>> removal of .ji
Hi,
asking for review to fix jvm crashing when replacing jimage file with recreated
one.
The name of the module metadata resource was wrongly associated to the name of
the recreated jimage file. The original name must be reused in the recreated
jimage.
This is what this fix is doing. In additio
Alan,
the image tool “recreate” option is tested. The upcoming linker tool makes for
a simpler test.
On 19 Aug 2015, at 10:37, Alan Bateman wrote:
> On 17/08/2015 14:21, Jean-Francois Denise wrote:
>> Hi Alan,
>> as JDK-8132527 shows, we also need to test that replacing th
Hi Ali,
I logged: https://bugs.openjdk.java.net/browse/JDK-8136645
Thanks for reporting.
JF
On 16 Sep 2015, at 17:55, Ali Ebrahimi wrote:
> Hi,
>
> The following patch tries to fix this:
>
> diff --git
> a/src/jdk.jlink/share/classes/jdk/tools/jlink/plugins/DefaultImageBuilder.java
> b/src/jdk
Changeset: 92f2350725c7
Author:jfdenise
Date: 2015-09-22 14:49 +0200
URL: http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/92f2350725c7
jlink plugins Map keyed with String. Target directory checks moved to
DefaultImageProvider, allows for customizable logic.
Reviewed-by: jlaskey
! s
Changeset: 092d5b11eca9
Author:jfdenise
Date: 2015-09-23 11:47 +0200
URL: http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/092d5b11eca9
8135071: jlink: NPE thrown if the custom image builder was not found
8135171: jlink: typo in ImagePluginProviderRepository
Contributed-by: andrei.ere
Changeset: ef9c2a7c82d3
Author:jfdenise
Date: 2015-09-23 17:06 +0200
URL: http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/ef9c2a7c82d3
jlink optim plugin, package accessibility check when resolving class. e.g.:
Class.forName calls are removed only if the loaded type is accessible fr
Changeset: cff16049f4a5
Author:jfdenise
Date: 2015-09-25 09:42 +0200
URL: http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/cff16049f4a5
Enable @file launcher support for jlink/jmod/jimage.
Reviewed-by: jlaskey, chegar
! make/launcher/Launcher-jdk.jlink.gmk
- src/jdk.jlink/share/class
Changeset: ed5d9f5bf890
Author:mkos
Date: 2015-09-18 13:46 +0200
URL: http://hg.openjdk.java.net/jigsaw/jake/jaxws/rev/ed5d9f5bf890
8131667: JAX-WS Plugability Layer: using java.util.ServiceLoader
Reviewed-by: alanb
+ src/java.xml.ws/share/classes/javax/xml/ws/package-info.java
- s
Changeset: 3ef63dbde965
Author:avstepan
Date: 2015-09-13 23:31 +0300
URL: http://hg.openjdk.java.net/jigsaw/jake/corba/rev/3ef63dbde965
8133650: replace some tags (obsolete in html5) in CORBA docs
Reviewed-by: lancea
! src/java.corba/share/classes/com/sun/corba/se/impl/ior/ByteBuf
Changeset: 751ada854e5a
Author:sundar
Date: 2015-09-14 16:13 +0530
URL: http://hg.openjdk.java.net/jigsaw/jake/nashorn/rev/751ada854e5a
8055917: jdk.nashorn.internal.codegen.CompilationPhase$N should be renamed to
proper classes
Reviewed-by: attila, hannesw
- samples/EvalWithArbit
Changeset: 9ae39768bcc2
Author:lana
Date: 2015-09-25 22:59 -0700
URL: http://hg.openjdk.java.net/jigsaw/jake/jaxp/rev/9ae39768bcc2
Added tag jdk9-b83 for changeset 497bc2654e11
! .hgtags
Changeset: 722eca4b78a2
Author:jfdenise
Date: 2015-09-28 12:15 +0200
URL: http:
Changeset: f98d9515afea
Author:weijun
Date: 2015-09-13 10:55 +0800
URL: http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/f98d9515afea
8136425: KeystoreImpl.m using wrong type for cert format
Reviewed-by: vinnie
! src/java.base/macosx/native/libosxsecurity/KeystoreImpl.m
Changeset: 1
Changeset: 382d23edebb6
Author:erikj
Date: 2015-09-15 18:00 +0200
URL: http://hg.openjdk.java.net/jigsaw/jake/rev/382d23edebb6
8136383: Improve make utilities containing and not-containing
Reviewed-by: ihse
! make/common/MakeBase.gmk
! test/make/TestMakeBase.gmk
Changeset: 0b0a6b9
Changeset: 8fa8045bbd4e
Author:mcimadamore
Date: 2015-09-14 11:26 +0100
URL: http://hg.openjdk.java.net/jigsaw/jake/langtools/rev/8fa8045bbd4e
8077306: Recursive implementation of List.map leads to stack overflow
Summary: Recusrive implementation of List.map uses too much stack; swi
Changeset: 7df0e3f7ad65
Author:adinn
Date: 2015-08-26 17:13 +0100
URL: http://hg.openjdk.java.net/jigsaw/jake/hotspot/rev/7df0e3f7ad65
8134322: AArch64: Fix several errors in C2 biased locking implementation
Summary: Several errors in C2 biased locking require fixing
Reviewed-by: kv
Changeset: 17d70d41a8c7
Author:jfdenise
Date: 2015-09-30 09:38 +0200
URL: http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/17d70d41a8c7
canonical order for modifiers, lost during merge
! src/java.base/share/classes/jdk/internal/jimage/ImageLocationBase.java
Changeset: 17662cef6fc0
Author:jfdenise
Date: 2015-10-05 09:35 +0200
URL: http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/17662cef6fc0
Permission to execute jlink programmatically.
Reviewed-by: jlaskey
! src/jdk.jlink/share/classes/jdk/tools/jlink/plugins/Jlink.java
+ src/jdk.jlink/
Hi,
asking for a review of the fix for
https://bugs.openjdk.java.net/browse/JDK-8136365.
webrev: http://cr.openjdk.java.net/~jfdenise/8136365/
When jimage recreate occurs, the META-INF content is filtered-out from the
Package<->Module map. This map that is iterated to create resources, so
META
Hi Andrei,
I will look at your contribution. Didn’t you add the same issue twice?
Thanks.
JF
On 6 Oct 2015, at 19:35, Andrei Eremeev wrote:
> Resending. I am covered by the OCA; so I can contribute to OpenJDK.
>
> Best regards,
> Andrei Eremeev
>
> Tuesday, October 6, 2015 12:40 AM +03:00 from
Changeset: 6533c9f9440d
Author:jfdenise
Date: 2015-10-08 14:32 +0200
URL: http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/6533c9f9440d
Default interface to get rid off code duplication
Reviewed-by: jlaskey
! src/jdk.jlink/share/classes/jdk/tools/jlink/TaskHelper.java
!
src/jdk.jlin
Changeset: 6e5080fdfaad
Author:hannesw
Date: 2015-09-19 16:04 +0200
URL: http://hg.openjdk.java.net/jigsaw/jake/nashorn/rev/6e5080fdfaad
8135190: Method code too large in Babel browser.js script
Reviewed-by: attila, sundar
!
src/jdk.scripting.nashorn/share/classes/jdk/nashorn/inte
Changeset: c8206f440046
Author:alundblad
Date: 2015-09-21 11:19 +0200
URL: http://hg.openjdk.java.net/jigsaw/jake/langtools/rev/c8206f440046
8135131: Enable thin server mode in Sjavac
Summary: State tracknig and incremental compilation disabled unless --state-dir
is provided.
Revie
Changeset: 1edfa4abd77a
Author:psandoz
Date: 2015-09-19 15:26 +0200
URL: http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/1edfa4abd77a
8136686: Collectors.counting can use Collectors.summingLong to reduce boxing
Reviewed-by: psandoz
Contributed-by: Tagir Valeev
! src/java.base/share
Changeset: c10ec627fad5
Author:joehw
Date: 2015-09-25 16:42 -0700
URL: http://hg.openjdk.java.net/jigsaw/jake/jaxp/rev/c10ec627fad5
8135283: DOM API update: Element Traversal Specification
Reviewed-by: mchung, lancea
!
src/java.xml/share/classes/com/sun/org/apache/xerces/internal/
Changeset: 6849581ba4ab
Author:ihse
Date: 2015-09-21 09:32 +0200
URL: http://hg.openjdk.java.net/jigsaw/jake/rev/6849581ba4ab
8136695: Automatic build comparison with COMPARE_BUILD
Reviewed-by: erikj
! common/autoconf/basics.m4
! common/autoconf/generated-configure.sh
! common/auto
Changeset: 333b58ed098f
Author:lana
Date: 2015-10-05 20:24 -0700
URL: http://hg.openjdk.java.net/jigsaw/jake/corba/rev/333b58ed098f
Added tag jdk9-b84 for changeset df70bb200356
! .hgtags
Changeset: 6345cf429d78
Author:jfdenise
Date: 2015-10-07 11:32 +0200
URL: http
Changeset: a589f73b79f4
Author:mcberg
Date: 2015-09-09 10:34 -0700
URL: http://hg.openjdk.java.net/jigsaw/jake/hotspot/rev/a589f73b79f4
8135028: support for vectorizing double precision sqrt
Reviewed-by: kvn, twisti
! src/cpu/x86/vm/assembler_x86.cpp
! src/cpu/x86/vm/assembler_x86.
Changeset: bdb954839363
Author:avstepan
Date: 2015-09-24 18:26 +0300
URL: http://hg.openjdk.java.net/jigsaw/jake/jaxws/rev/bdb954839363
8133651: replace some tags (obsolete in html5) in core-libs docs
Reviewed-by: martin
!
src/java.xml.bind/share/classes/com/sun/xml/internal/bind
Changeset: 67a090f8d062
Author:jfdenise
Date: 2015-10-09 18:01 +0200
URL: http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/67a090f8d062
Rework and simplification of plugins config. Simplified ordering.
Reviewed-by: jlaskey
! src/jdk.jlink/share/classes/jdk/tools/jimage/JImageTask.jav
Changeset: 7c5cfe773b7c
Author:jfdenise
Date: 2015-10-15 18:40 +0200
URL: http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/7c5cfe773b7c
Ability to hide/expose plugin provider. Ability to express functional state.
Some tiny fixes.
Reviewed-by: jlaskey
! src/jdk.jlink/share/classes/jd
+1, in the test, could you make sure that childCount is not zero?
On 5 Nov 2015, at 14:27, Jim Laskey (Oracle) wrote:
> +1
>
>> On Nov 5, 2015, at 5:45 AM, Sundararajan Athijegannathan
>> wrote:
>>
>> Please review http://cr.openjdk.java.net/~sundar/8141521/webrev.00/ for
>> https://bugs.op
Changeset: 1148a05d184a
Author:jfdenise
Date: 2015-11-10 10:28 +0100
URL: http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/1148a05d184a
Fix for 8135077, 8134944, 8139296
Reviewed-by: jlaskey
! src/jdk.jlink/share/classes/jdk/tools/jlink/JlinkTask.java
! src/jdk.jlink/share/classes/jd
Changeset: 1943b3022700
Author:jfdenise
Date: 2015-11-10 14:43 +0100
URL: http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/1943b3022700
Fix for 81422389. Close archives in all cases.
Reviewed-by: jlaskey
! src/jdk.jlink/share/classes/jdk/tools/jlink/internal/ImageFileCreator.java
Changeset: 1b50ccfd6f27
Author:jfdenise
Date: 2015-11-12 15:00 +0100
URL: http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/1b50ccfd6f27
Fix for 8142485. Jake doesn't build on Windows after recent change to libjimage
Reviewed-by: jlaskey
! src/java.base/share/native/libjimage/imageDec
Hi,
I removed a noisy call to System.out.
Webrev http://cr.openjdk.java.net/~jfdenise/8143126/
Thanks.
JF
Changeset: e1579b30cbec
Author:jfdenise
Date: 2015-11-17 15:41 +0100
URL: http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/e1579b30cbec
Fix for 8142485, Jake doesn't build on Windows after recent change to libjimage
Reviewed-by: mchung, jlaskey
!
src/java.base/share/classes/jdk/inte
Changeset: bb7babadf6ea
Author:jfdenise
Date: 2015-12-21 14:42 +0100
URL: http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/bb7babadf6ea
jlink API rework, hide compression, merge File and Resource, ModuleData per
Module.
- src/java.base/share/classes/jdk/internal/jimage/StringTable.j
Changeset: a4d427c2c81b
Author:jfdenise
Date: 2015-12-23 09:13 +0100
URL: http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/a4d427c2c81b
Fix for 8145264, jlink NPE when providing --class-optim-log-file option without
--class-optim option
! src/jdk.jlink/share/classes/jdk/tools/jlink/
Changeset: ddf5a0e7410a
Author:jfdenise
Date: 2016-01-20 11:25 +0100
URL: http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/ddf5a0e7410a
Fix description not displayed. Less restrictive pattern in unit test
! src/jdk.jlink/share/classes/jdk/tools/jlink/internal/TaskHelper.java
! test/j
56 matches
Mail list logo
