[GitHub] [kafka] predatorray commented on pull request #10525: KAFKA-7572: Producer should not send requests with negative partition id

predatorray commented on pull request #10525: URL: https://github.com/apache/kafka/pull/10525#issuecomment-877575923 Hi @showuon. It looks like nobody else shared thought about this exception for some time. I have changed to use the IllegalArgumentException instead of the InvalidPartitionE

[jira] [Updated] (KAFKA-10675) Error message from ConnectSchema.validateValue() should include the name of the schema.

[ https://issues.apache.org/jira/browse/KAFKA-10675?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Konstantine Karantasis updated KAFKA-10675: --- Fix Version/s: 2.7.2 2.6.3 > Error message from ConnectSc

[GitHub] [kafka] kkonstantine merged pull request #9541: KAFKA-10675: Add schema name to ConnectSchema.validateValue() error message

kkonstantine merged pull request #9541: URL: https://github.com/apache/kafka/pull/9541 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubs

[GitHub] [kafka] showuon commented on a change in pull request #10794: KAFKA-12677: return not_controller error in envelope response itself

showuon commented on a change in pull request #10794: URL: https://github.com/apache/kafka/pull/10794#discussion_r667293695 ## File path: core/src/test/scala/unit/kafka/network/RequestChannelTest.scala ## @@ -179,6 +184,108 @@ class RequestChannelTest { assertTrue(isValid

[GitHub] [kafka] showuon commented on a change in pull request #10794: KAFKA-12677: return not_controller error in envelope response itself

showuon commented on a change in pull request #10794: URL: https://github.com/apache/kafka/pull/10794#discussion_r667293513 ## File path: clients/src/main/java/org/apache/kafka/common/requests/ApiError.java ## @@ -36,10 +38,21 @@ private final String message; public

[GitHub] [kafka] showuon commented on a change in pull request #10794: KAFKA-12677: return not_controller error in envelope response itself

showuon commented on a change in pull request #10794: URL: https://github.com/apache/kafka/pull/10794#discussion_r667293072 ## File path: core/src/test/scala/unit/kafka/network/RequestChannelTest.scala ## @@ -179,6 +184,108 @@ class RequestChannelTest { assertTrue(isValid

[GitHub] [kafka] zhaohaidao commented on pull request #10969: KAFKA-10884: Limit the size of Fetch and FetchSnapshot response based on broker configuration

zhaohaidao commented on pull request #10969: URL: https://github.com/apache/kafka/pull/10969#issuecomment-877512351 > @zhaohaidao , thanks for the PR. Left some comments. Thanks. @showuon hi, Comments have been addressed. could you please continue to review if you have time, thanks.

[GitHub] [kafka] hachikuji commented on a change in pull request #10794: KAFKA-12677: return not_controller error in envelope response itself

hachikuji commented on a change in pull request #10794: URL: https://github.com/apache/kafka/pull/10794#discussion_r667245949 ## File path: core/src/test/scala/unit/kafka/network/RequestChannelTest.scala ## @@ -179,6 +184,108 @@ class RequestChannelTest { assertTrue(isVal

[GitHub] [kafka] hachikuji commented on a change in pull request #10794: KAFKA-12677: return not_controller error in envelope response itself

hachikuji commented on a change in pull request #10794: URL: https://github.com/apache/kafka/pull/10794#discussion_r667244195 ## File path: core/src/test/scala/unit/kafka/network/RequestChannelTest.scala ## @@ -179,6 +184,108 @@ class RequestChannelTest { assertTrue(isVal

[GitHub] [kafka] 0x1991babe opened a new pull request #11014: MINOR: Add default for EndOffset and Epoch in FetchSnapshotResponse.

0x1991babe opened a new pull request #11014: URL: https://github.com/apache/kafka/pull/11014 This is *extremely, extremely* minor. We are using default values for some serialization logic, and I noticed in doing a review for https://github.com/0x1991babe/kafka-protocol-rs/issues/1 t

[jira] [Commented] (KAFKA-13008) Stream will stop processing data for a long time while waiting for the partition lag

[ https://issues.apache.org/jira/browse/KAFKA-13008?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17378338#comment-17378338 ] John Roesler commented on KAFKA-13008: -- Woah, this is an excellent find, [~showuon]

[GitHub] [kafka] cmccabe commented on a change in pull request #10753: KAFKA-12803: Support reassigning partitions when in KRaft mode

cmccabe commented on a change in pull request #10753: URL: https://github.com/apache/kafka/pull/10753#discussion_r667240160 ## File path: metadata/src/main/java/org/apache/kafka/controller/ReplicationControlManager.java ## @@ -1204,6 +1317,298 @@ void generateLeaderAndIsrUpdat

[GitHub] [kafka] cmccabe commented on a change in pull request #10753: KAFKA-12803: Support reassigning partitions when in KRaft mode

cmccabe commented on a change in pull request #10753: URL: https://github.com/apache/kafka/pull/10753#discussion_r667238459 ## File path: metadata/src/main/java/org/apache/kafka/controller/ReplicationControlManager.java ## @@ -1204,6 +1317,298 @@ void generateLeaderAndIsrUpdat

[GitHub] [kafka] cmccabe commented on a change in pull request #10753: KAFKA-12803: Support reassigning partitions when in KRaft mode

cmccabe commented on a change in pull request #10753: URL: https://github.com/apache/kafka/pull/10753#discussion_r667232772 ## File path: metadata/src/main/java/org/apache/kafka/controller/RemovingAndAddingReplicas.java ## @@ -0,0 +1,214 @@ +/* + * Licensed to the Apache Softw

[GitHub] [kafka] cmccabe commented on a change in pull request #10753: KAFKA-12803: Support reassigning partitions when in KRaft mode

cmccabe commented on a change in pull request #10753: URL: https://github.com/apache/kafka/pull/10753#discussion_r665801100 ## File path: metadata/src/main/java/org/apache/kafka/controller/RemovingAndAddingReplicas.java ## @@ -0,0 +1,214 @@ +/* + * Licensed to the Apache Softw

[GitHub] [kafka] cmccabe commented on a change in pull request #10753: KAFKA-12803: Support reassigning partitions when in KRaft mode

cmccabe commented on a change in pull request #10753: URL: https://github.com/apache/kafka/pull/10753#discussion_r667232604 ## File path: metadata/src/main/java/org/apache/kafka/controller/RemovingAndAddingReplicas.java ## @@ -0,0 +1,214 @@ +/* + * Licensed to the Apache Softw

[jira] [Updated] (KAFKA-9705) Zookeeper mutation protocols should be redirected to Controller only

[ https://issues.apache.org/jira/browse/KAFKA-9705?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Konstantine Karantasis updated KAFKA-9705: -- Fix Version/s: (was: 3.0.0) > Zookeeper mutation protocols should be redire

[jira] [Updated] (KAFKA-10345) Add auto reloading for trust/key store paths

[ https://issues.apache.org/jira/browse/KAFKA-10345?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Konstantine Karantasis updated KAFKA-10345: --- Fix Version/s: (was: 3.0.0) > Add auto reloading for trust/key store pat

[GitHub] [kafka] vvcephei commented on a change in pull request #11003: KAFKA-12360: Document new time semantics

vvcephei commented on a change in pull request #11003: URL: https://github.com/apache/kafka/pull/11003#discussion_r667228608 ## File path: docs/streams/developer-guide/config-streams.html ## @@ -600,8 +613,54 @@ default.windowed.value.serde.innermax.task.idle.ms

[GitHub] [kafka] kkonstantine commented on a change in pull request #9541: KAFKA-10675: Add schema name to ConnectSchema.validateValue() error message

kkonstantine commented on a change in pull request #9541: URL: https://github.com/apache/kafka/pull/9541#discussion_r667225730 ## File path: connect/api/src/main/java/org/apache/kafka/connect/data/ConnectSchema.java ## @@ -221,13 +221,7 @@ public static void validateValue(Stri

[GitHub] [kafka] hachikuji opened a new pull request #11013: KAFKA-13056; Do not rely on broker for snapshots if controller is co-resident

hachikuji opened a new pull request #11013: URL: https://github.com/apache/kafka/pull/11013 When a node is serving as both broker and controller, we should only rely on the controller to write new snapshots. ### Committer Checklist (excluded from commit message) - [ ] Verify desig

[GitHub] [kafka] hachikuji commented on a change in pull request #11011: KAFKA-13051: Require Principal Serde and add default

hachikuji commented on a change in pull request #11011: URL: https://github.com/apache/kafka/pull/11011#discussion_r667225066 ## File path: core/src/main/scala/kafka/server/KafkaConfig.scala ## @@ -1975,6 +1975,8 @@ class KafkaConfig(val props: java.util.Map[_, _], doLog: Bool

[GitHub] [kafka] junrao commented on a change in pull request #10753: KAFKA-12803: Support reassigning partitions when in KRaft mode

junrao commented on a change in pull request #10753: URL: https://github.com/apache/kafka/pull/10753#discussion_r667223580 ## File path: metadata/src/main/java/org/apache/kafka/controller/ReplicationControlManager.java ## @@ -1204,6 +1317,298 @@ void generateLeaderAndIsrUpdate

[GitHub] [kafka] hachikuji commented on a change in pull request #11011: KAFKA-13051: Require Principal Serde and add default

hachikuji commented on a change in pull request #11011: URL: https://github.com/apache/kafka/pull/11011#discussion_r667216030 ## File path: core/src/main/scala/kafka/server/KafkaConfig.scala ## @@ -1971,5 +1974,7 @@ class KafkaConfig(val props: java.util.Map[_, _], doLog: Bool

[GitHub] [kafka] hachikuji commented on a change in pull request #11011: KAFKA-13051: Require Principal Serde and add default

hachikuji commented on a change in pull request #11011: URL: https://github.com/apache/kafka/pull/11011#discussion_r667216030 ## File path: core/src/main/scala/kafka/server/KafkaConfig.scala ## @@ -1971,5 +1974,7 @@ class KafkaConfig(val props: java.util.Map[_, _], doLog: Bool

[GitHub] [kafka] hachikuji commented on a change in pull request #11011: KAFKA-13051: Require Principal Serde and add default

hachikuji commented on a change in pull request #11011: URL: https://github.com/apache/kafka/pull/11011#discussion_r667216030 ## File path: core/src/main/scala/kafka/server/KafkaConfig.scala ## @@ -1971,5 +1974,7 @@ class KafkaConfig(val props: java.util.Map[_, _], doLog: Bool

[GitHub] [kafka] hachikuji edited a comment on pull request #11012: Add KRaft "broker" to several RPC's listeners

hachikuji edited a comment on pull request #11012: URL: https://github.com/apache/kafka/pull/11012#issuecomment-877459197 One more to fix is `UnregisterBroker`. We do not need this exposed on the broker. -- This is an automated message from the Apache Git Service. To respond to the messa

[GitHub] [kafka] hachikuji commented on pull request #11012: Add KRaft "broker" to several RPC's listeners

hachikuji commented on pull request #11012: URL: https://github.com/apache/kafka/pull/11012#issuecomment-877459197 One more to fix i s`UnregisterBroker`. We do not need this exposed on the broker. -- This is an automated message from the Apache Git Service. To respond to the message, ple

[GitHub] [kafka] hachikuji commented on a change in pull request #11012: Add KRaft "broker" to several RPC's listeners

hachikuji commented on a change in pull request #11012: URL: https://github.com/apache/kafka/pull/11012#discussion_r667212406 ## File path: clients/src/main/resources/common/message/CreatePartitionsRequest.json ## @@ -16,7 +16,7 @@ { "apiKey": 37, "type": "request", -

[jira] [Updated] (KAFKA-12493) The controller should handle the consistency between the controllerContext and the partition replicas assignment on zookeeper

[ https://issues.apache.org/jira/browse/KAFKA-12493?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Konstantine Karantasis updated KAFKA-12493: --- Fix Version/s: (was: 3.0.0) > The controller should handle the consisten

[jira] [Updated] (KAFKA-13051) Require Principal Serde to be defined for 3.0

[ https://issues.apache.org/jira/browse/KAFKA-13051?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Konstantine Karantasis updated KAFKA-13051: --- Priority: Blocker (was: Major) > Require Principal Serde to be defined for

[jira] [Commented] (KAFKA-12493) The controller should handle the consistency between the controllerContext and the partition replicas assignment on zookeeper

[ https://issues.apache.org/jira/browse/KAFKA-12493?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17378309#comment-17378309 ] Konstantine Karantasis commented on KAFKA-12493: Thanks for the update [

[jira] [Updated] (KAFKA-13056) Broker should not generate snapshots when controller is co-resident

[ https://issues.apache.org/jira/browse/KAFKA-13056?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Konstantine Karantasis updated KAFKA-13056: --- Fix Version/s: (was: 3.0.0) > Broker should not generate snapshots when

[jira] [Commented] (KAFKA-10345) Add auto reloading for trust/key store paths

[ https://issues.apache.org/jira/browse/KAFKA-10345?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17378306#comment-17378306 ] Konstantine Karantasis commented on KAFKA-10345: Sorry. Wrong mentions.

[jira] [Updated] (KAFKA-12878) Support --bootstrap-server kafka-streams-application-reset

[ https://issues.apache.org/jira/browse/KAFKA-12878?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Konstantine Karantasis updated KAFKA-12878: --- Fix Version/s: (was: 3.0.0) 3.1.0 > Support --bootstr

[jira] [Commented] (KAFKA-12878) Support --bootstrap-server kafka-streams-application-reset

[ https://issues.apache.org/jira/browse/KAFKA-12878?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17378299#comment-17378299 ] Konstantine Karantasis commented on KAFKA-12878: I wasn't able to find a

[GitHub] [kafka] cmccabe commented on a change in pull request #10753: KAFKA-12803: Support reassigning partitions when in KRaft mode

cmccabe commented on a change in pull request #10753: URL: https://github.com/apache/kafka/pull/10753#discussion_r667204243 ## File path: metadata/src/main/java/org/apache/kafka/controller/ReplicationControlManager.java ## @@ -1204,6 +1317,298 @@ void generateLeaderAndIsrUpdat

[jira] [Commented] (KAFKA-6840) support windowing in ktable API

[ https://issues.apache.org/jira/browse/KAFKA-6840?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17378297#comment-17378297 ] Konstantine Karantasis commented on KAFKA-6840: --- [KIP-300|https://cwiki.apa

[jira] [Updated] (KAFKA-6840) support windowing in ktable API

[ https://issues.apache.org/jira/browse/KAFKA-6840?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Konstantine Karantasis updated KAFKA-6840: -- Fix Version/s: (was: 3.0.0) > support windowing in ktable API > ---

[jira] [Resolved] (KAFKA-10046) Deprecated PartitionGrouper config is ignored

[ https://issues.apache.org/jira/browse/KAFKA-10046?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Konstantine Karantasis resolved KAFKA-10046. Resolution: Fixed > Deprecated PartitionGrouper config is ignored > --

[jira] [Commented] (KAFKA-10046) Deprecated PartitionGrouper config is ignored

[ https://issues.apache.org/jira/browse/KAFKA-10046?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17378294#comment-17378294 ] Konstantine Karantasis commented on KAFKA-10046: [~ableegoldman] the two

[jira] [Resolved] (KAFKA-12419) Remove Deprecated APIs of Kafka Streams in 3.0

[ https://issues.apache.org/jira/browse/KAFKA-12419?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Konstantine Karantasis resolved KAFKA-12419. Resolution: Fixed > Remove Deprecated APIs of Kafka Streams in 3.0 > -

[jira] [Commented] (KAFKA-12419) Remove Deprecated APIs of Kafka Streams in 3.0

[ https://issues.apache.org/jira/browse/KAFKA-12419?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17378293#comment-17378293 ] Konstantine Karantasis commented on KAFKA-12419: All the subtasks of thi

[jira] [Resolved] (KAFKA-12499) Adjust transaction timeout according to commit interval on Streams EOS

[ https://issues.apache.org/jira/browse/KAFKA-12499?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Konstantine Karantasis resolved KAFKA-12499. Resolution: Fixed > Adjust transaction timeout according to commit interva

[jira] [Updated] (KAFKA-9990) Supporting transactions in tiered storage

[ https://issues.apache.org/jira/browse/KAFKA-9990?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Konstantine Karantasis updated KAFKA-9990: -- Fix Version/s: (was: 3.0.0) 3.1.0 > Supporting transacti

[jira] [Commented] (KAFKA-9579) RLM fetch implementation by adding respective purgatory

[ https://issues.apache.org/jira/browse/KAFKA-9579?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17378282#comment-17378282 ] Konstantine Karantasis commented on KAFKA-9579: --- Feature freeze for AK 3.0

[jira] [Updated] (KAFKA-12802) Add a file based cache for consumed remote log metadata for each partition to avoid consuming again incase of broker restarts.

[ https://issues.apache.org/jira/browse/KAFKA-12802?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Konstantine Karantasis updated KAFKA-12802: --- Fix Version/s: (was: 3.0.0) 3.1.0 > Add a file based

[jira] [Commented] (KAFKA-12641) Clear RemoteLogLeaderEpochState entry when it become empty.

[ https://issues.apache.org/jira/browse/KAFKA-12641?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17378286#comment-17378286 ] Konstantine Karantasis commented on KAFKA-12641: Feature freeze for AK 3

[jira] [Updated] (KAFKA-12641) Clear RemoteLogLeaderEpochState entry when it become empty.

[ https://issues.apache.org/jira/browse/KAFKA-12641?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Konstantine Karantasis updated KAFKA-12641: --- Fix Version/s: (was: 3.0.0) 3.1.0 > Clear RemoteLogLe

[jira] [Commented] (KAFKA-12802) Add a file based cache for consumed remote log metadata for each partition to avoid consuming again incase of broker restarts.

[ https://issues.apache.org/jira/browse/KAFKA-12802?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17378287#comment-17378287 ] Konstantine Karantasis commented on KAFKA-12802: Feature freeze for AK 3

[jira] [Commented] (KAFKA-9990) Supporting transactions in tiered storage

[ https://issues.apache.org/jira/browse/KAFKA-9990?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17378284#comment-17378284 ] Konstantine Karantasis commented on KAFKA-9990: --- Feature freeze for AK 3.0

[jira] [Updated] (KAFKA-9579) RLM fetch implementation by adding respective purgatory

[ https://issues.apache.org/jira/browse/KAFKA-9579?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Konstantine Karantasis updated KAFKA-9579: -- Fix Version/s: (was: 3.0.0) 3.1.0 > RLM fetch implementa

[jira] [Updated] (KAFKA-9578) Kafka Tiered Storage - System Tests

[ https://issues.apache.org/jira/browse/KAFKA-9578?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Konstantine Karantasis updated KAFKA-9578: -- Fix Version/s: (was: 3.0.0) 3.1.0 > Kafka Tiered Storage

[jira] [Commented] (KAFKA-9578) Kafka Tiered Storage - System Tests

[ https://issues.apache.org/jira/browse/KAFKA-9578?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17378280#comment-17378280 ] Konstantine Karantasis commented on KAFKA-9578: --- Feature freeze for AK 3.0

[jira] [Commented] (KAFKA-9550) RemoteLogManager implementation

[ https://issues.apache.org/jira/browse/KAFKA-9550?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17378278#comment-17378278 ] Konstantine Karantasis commented on KAFKA-9550: --- Feature freeze for AK 3.0

[jira] [Commented] (KAFKA-9555) Topic-based implementation for the RemoteLogMetadataManager

[ https://issues.apache.org/jira/browse/KAFKA-9555?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17378277#comment-17378277 ] Konstantine Karantasis commented on KAFKA-9555: --- Feature freeze for AK 3.0

[jira] [Updated] (KAFKA-9555) Topic-based implementation for the RemoteLogMetadataManager

[ https://issues.apache.org/jira/browse/KAFKA-9555?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Konstantine Karantasis updated KAFKA-9555: -- Fix Version/s: (was: 3.0.0) 3.1.0 > Topic-based implemen

[jira] [Updated] (KAFKA-9550) RemoteLogManager implementation

[ https://issues.apache.org/jira/browse/KAFKA-9550?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Konstantine Karantasis updated KAFKA-9550: -- Fix Version/s: (was: 3.0.0) 3.1.0 > RemoteLogManager imp

[jira] [Commented] (KAFKA-7739) Kafka Tiered Storage

[ https://issues.apache.org/jira/browse/KAFKA-7739?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17378276#comment-17378276 ] Konstantine Karantasis commented on KAFKA-7739: --- Setting the target version

[jira] [Updated] (KAFKA-7739) Kafka Tiered Storage

[ https://issues.apache.org/jira/browse/KAFKA-7739?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Konstantine Karantasis updated KAFKA-7739: -- Fix Version/s: (was: 3.0.0) 3.1.0 > Kafka Tiered Storage

[GitHub] [kafka] rondagostino commented on pull request #10991: MINOR: system test fix for 3 co-located KRaft controllers

rondagostino commented on pull request #10991: URL: https://github.com/apache/kafka/pull/10991#issuecomment-877430917 TL;DR: my preference is to skip the regex check rather than adding a new message and carefully/appropriately grepping for it. > I think you do need to special case th

[GitHub] [kafka] hachikuji commented on pull request #11012: Add KRaft "broker" to several RPC's listeners

hachikuji commented on pull request #11012: URL: https://github.com/apache/kafka/pull/11012#issuecomment-877418762 While we're at it, I think we should be able to remove "broker" from the listeners for `AllocateProducerIds`. -- This is an automated message from the Apache Git Service. To

[jira] [Resolved] (KAFKA-13053) Bump frame version for KRaft records

[ https://issues.apache.org/jira/browse/KAFKA-13053?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason Gustafson resolved KAFKA-13053. - Fix Version/s: 3.0.0 Resolution: Fixed > Bump frame version for KRaft records > -

[GitHub] [kafka] hachikuji commented on a change in pull request #11011: KAFKA-13051: Require Principal Serde and add default

hachikuji commented on a change in pull request #11011: URL: https://github.com/apache/kafka/pull/11011#discussion_r667174963 ## File path: docs/upgrade.html ## @@ -21,6 +21,7 @@ Notable changes in 3.0.0 +Custom principal builder implementations specified through pri

[GitHub] [kafka] hachikuji commented on a change in pull request #10794: KAFKA-12677: return not_controller error in envelope response itself

hachikuji commented on a change in pull request #10794: URL: https://github.com/apache/kafka/pull/10794#discussion_r667171204 ## File path: core/src/test/scala/integration/kafka/server/RaftClusterTest.scala ## @@ -29,7 +29,7 @@ import java.util import java.util.Collections im

[GitHub] [kafka] mumrah opened a new pull request #11012: Add KRaft "broker" to several RPC's listeners

mumrah opened a new pull request #11012: URL: https://github.com/apache/kafka/pull/11012 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsu

[jira] [Assigned] (KAFKA-13057) Many broker RPCs are not enable in KRaft mode

[ https://issues.apache.org/jira/browse/KAFKA-13057?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Arthur reassigned KAFKA-13057: Assignee: David Arthur > Many broker RPCs are not enable in KRaft mode >

[GitHub] [kafka] dajac merged pull request #10998: MINOR: fix quoted boolean in FetchRequest.json

dajac merged pull request #10998: URL: https://github.com/apache/kafka/pull/10998 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...

[GitHub] [kafka] dajac commented on pull request #10998: MINOR: fix quoted boolean in FetchRequest.json

dajac commented on pull request #10998: URL: https://github.com/apache/kafka/pull/10998#issuecomment-877411273 Indeed, failures are not related. I am going to merge it. @0x1991babe Thanks for the patch! -- This is an automated message from the Apache Git Service. To respond to the messag

[jira] [Created] (KAFKA-13057) Many broker RPCs are not enable in KRaft mode

David Arthur created KAFKA-13057: Summary: Many broker RPCs are not enable in KRaft mode Key: KAFKA-13057 URL: https://issues.apache.org/jira/browse/KAFKA-13057 Project: Kafka Issue Type: Bug

[jira] [Created] (KAFKA-13056) Broker should not generate snapshots when controller is co-resident

Jason Gustafson created KAFKA-13056: --- Summary: Broker should not generate snapshots when controller is co-resident Key: KAFKA-13056 URL: https://issues.apache.org/jira/browse/KAFKA-13056 Project: Ka

[GitHub] [kafka] hachikuji commented on a change in pull request #11011: KAFKA-13051: Require Principal Serde and add default

hachikuji commented on a change in pull request #11011: URL: https://github.com/apache/kafka/pull/11011#discussion_r667164215 ## File path: docs/upgrade.html ## @@ -21,6 +21,7 @@ Notable changes in 3.0.0 +A Principal Serde defenition is now required. A default has bee

[GitHub] [kafka] hachikuji commented on a change in pull request #11011: KAFKA-13051: Require Principal Serde and add default

hachikuji commented on a change in pull request #11011: URL: https://github.com/apache/kafka/pull/11011#discussion_r667164215 ## File path: docs/upgrade.html ## @@ -21,6 +21,7 @@ Notable changes in 3.0.0 +A Principal Serde defenition is now required. A default has bee

[jira] [Commented] (KAFKA-8295) Optimize count() using RocksDB merge operator

[ https://issues.apache.org/jira/browse/KAFKA-8295?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17378253#comment-17378253 ] Sagar Rao commented on KAFKA-8295: -- hey sorry to bug you on this again.. but wondering i

[GitHub] [kafka] cmccabe merged pull request #11010: KAFKA-13053; Bump kraft frame version for incompatible changes from 2.8

cmccabe merged pull request #11010: URL: https://github.com/apache/kafka/pull/11010 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr.

[GitHub] [kafka] vamossagar12 commented on pull request #10877: KAFKA-12925: adding presfixScan operation for missed implementations

vamossagar12 commented on pull request #10877: URL: https://github.com/apache/kafka/pull/10877#issuecomment-877398722 Thanks @ableegoldman i have fixed the merge conflict. Plz review whenever you get the chance... -- This is an automated message from the Apache Git Service. To respond t

[GitHub] [kafka] cmccabe merged pull request #10990: MINOR: the broker should use metadata.log.max.record.bytes.between.snapshots

cmccabe merged pull request #10990: URL: https://github.com/apache/kafka/pull/10990 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr.

[GitHub] [kafka] skaundinya15 commented on pull request #11000: KAFKA-13045: Adding a test for batched offsetFetch requests with one group repeating

skaundinya15 commented on pull request #11000: URL: https://github.com/apache/kafka/pull/11000#issuecomment-877386499 Thank you for the review @rajinisivaram, I applied the changes you suggested to both this test as well as a very similar test in `AuthorizerIntegrationTest.scala`. Please t

[GitHub] [kafka] mumrah commented on pull request #11005: MINOR: Print the cached broker epoch

mumrah commented on pull request #11005: URL: https://github.com/apache/kafka/pull/11005#issuecomment-877381458 Merged to trunk and 3.0 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specif

[GitHub] [kafka] dielhennr opened a new pull request #11011: KAFKA-13051: Require Principal Serde and add default

dielhennr opened a new pull request #11011: URL: https://github.com/apache/kafka/pull/11011 Adding a default PrincipalBuilderClassProp and requiring that any custom config setting implements KafkaPrincipalSerde. -- This is an automated message from the Apache Git Service. To respond

[GitHub] [kafka] mumrah merged pull request #11005: MINOR: Print the cached broker epoch

mumrah merged pull request #11005: URL: https://github.com/apache/kafka/pull/11005 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr..

[GitHub] [kafka] zhaohaidao commented on a change in pull request #10969: KAFKA-10884: Limit the size of Fetch and FetchSnapshot response based on broker configuration

zhaohaidao commented on a change in pull request #10969: URL: https://github.com/apache/kafka/pull/10969#discussion_r667115287 ## File path: core/src/test/scala/unit/kafka/server/KafkaConfigTest.scala ## @@ -1054,7 +1054,8 @@ class KafkaConfigTest { private def assertValidQu

[GitHub] [kafka] rajinisivaram commented on a change in pull request #11002: KAFKA-13026: Idempotent producer (KAFKA-10619) follow-up testings

rajinisivaram commented on a change in pull request #11002: URL: https://github.com/apache/kafka/pull/11002#discussion_r667103591 ## File path: clients/src/test/java/org/apache/kafka/clients/producer/KafkaProducerTest.java ## @@ -172,6 +173,115 @@ public void testOverwriteAck

[jira] [Commented] (KAFKA-7025) Android client support

[ https://issues.apache.org/jira/browse/KAFKA-7025?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17378205#comment-17378205 ] Nikolai Lubiagov commented on KAFKA-7025: - Oh... so long time ago it was. Will ch

[GitHub] [kafka] hachikuji commented on a change in pull request #11010: KAFKA-13053; Bump kraft frame version for incompatible changes from 2.8

hachikuji commented on a change in pull request #11010: URL: https://github.com/apache/kafka/pull/11010#discussion_r667105114 ## File path: metadata/src/test/java/org/apache/kafka/controller/QuorumControllerTest.java ## @@ -17,50 +17,34 @@ package org.apache.kafka.controlle

[GitHub] [kafka] cmccabe commented on a change in pull request #11010: KAFKA-13053; Bump kraft frame version for incompatible changes from 2.8

cmccabe commented on a change in pull request #11010: URL: https://github.com/apache/kafka/pull/11010#discussion_r667102835 ## File path: metadata/src/test/java/org/apache/kafka/controller/QuorumControllerTest.java ## @@ -17,50 +17,34 @@ package org.apache.kafka.controller;

[GitHub] [kafka] junrao commented on a change in pull request #10579: KAFKA-9555 Added default RLMM implementation based on internal topic storage.

junrao commented on a change in pull request #10579: URL: https://github.com/apache/kafka/pull/10579#discussion_r667102624 ## File path: storage/src/main/java/org/apache/kafka/server/log/remote/metadata/storage/TopicBasedRemoteLogMetadataManager.java ## @@ -0,0 +1,432 @@ +/* +

[jira] [Commented] (KAFKA-13051) Require Principal Serde to be defined for 3.0

[ https://issues.apache.org/jira/browse/KAFKA-13051?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17378193#comment-17378193 ] Ryan Dielhenn commented on KAFKA-13051: --- [~kkonstantine] Yes it is. > Require Pri

[GitHub] [kafka] hachikuji opened a new pull request #11010: KAFKA-13053; Bump kraft frame version for incompatible changes from 2.8

hachikuji opened a new pull request #11010: URL: https://github.com/apache/kafka/pull/11010 This patch bumps the default frame version for kraft records from 0 to 1. At the same time, we reset all records versions back to 0 and we enable flexible version support for `UnregisterBrokerRecord

[GitHub] [kafka] xvrl commented on a change in pull request #11008: Kafka-10588 Rename kafka-console-consumer CLI command line arguments for KIP-629

xvrl commented on a change in pull request #11008: URL: https://github.com/apache/kafka/pull/11008#discussion_r667078995 ## File path: core/src/main/scala/kafka/tools/ConsoleConsumer.scala ## @@ -392,25 +401,25 @@ object ConsoleConsumer extends Logging { } } - privat

[GitHub] [kafka] xvrl commented on a change in pull request #11008: Kafka-10588 Rename kafka-console-consumer CLI command line arguments for KIP-629

xvrl commented on a change in pull request #11008: URL: https://github.com/apache/kafka/pull/11008#discussion_r667075504 ## File path: core/src/main/scala/kafka/tools/ConsoleConsumer.scala ## @@ -191,9 +191,15 @@ object ConsoleConsumer extends Logging { .withRequiredArg

[GitHub] [kafka] cmccabe commented on a change in pull request #10794: KAFKA-12677: return not_controller error in envelope response itself

cmccabe commented on a change in pull request #10794: URL: https://github.com/apache/kafka/pull/10794#discussion_r667072949 ## File path: core/src/test/scala/integration/kafka/server/RaftClusterTest.scala ## @@ -29,7 +29,7 @@ import java.util import java.util.Collections impo

[GitHub] [kafka] cmccabe commented on a change in pull request #10990: MINOR: the broker should use metadata.log.max.record.bytes.between.snapshots

cmccabe commented on a change in pull request #10990: URL: https://github.com/apache/kafka/pull/10990#discussion_r667066884 ## File path: core/src/test/scala/unit/kafka/server/metadata/BrokerMetadataSnapshotterTest.scala ## @@ -0,0 +1,105 @@ +/** + * Licensed to the Apache Sof

[GitHub] [kafka] cmccabe commented on a change in pull request #10990: MINOR: the broker should use metadata.log.max.record.bytes.between.snapshots

cmccabe commented on a change in pull request #10990: URL: https://github.com/apache/kafka/pull/10990#discussion_r667066884 ## File path: core/src/test/scala/unit/kafka/server/metadata/BrokerMetadataSnapshotterTest.scala ## @@ -0,0 +1,105 @@ +/** + * Licensed to the Apache Sof

[GitHub] [kafka] cmccabe commented on a change in pull request #10990: MINOR: the broker should use metadata.log.max.record.bytes.between.snapshots

cmccabe commented on a change in pull request #10990: URL: https://github.com/apache/kafka/pull/10990#discussion_r667062463 ## File path: core/src/test/scala/unit/kafka/server/metadata/BrokerMetadataListenerTest.scala ## @@ -77,5 +80,124 @@ class BrokerMetadataListenerTest {

[GitHub] [kafka] cmccabe commented on a change in pull request #10990: MINOR: the broker should use metadata.log.max.record.bytes.between.snapshots

cmccabe commented on a change in pull request #10990: URL: https://github.com/apache/kafka/pull/10990#discussion_r667060078 ## File path: core/src/test/scala/unit/kafka/server/metadata/BrokerMetadataListenerTest.scala ## @@ -77,5 +80,124 @@ class BrokerMetadataListenerTest {

[GitHub] [kafka] cmccabe commented on a change in pull request #10990: MINOR: the broker should use metadata.log.max.record.bytes.between.snapshots

cmccabe commented on a change in pull request #10990: URL: https://github.com/apache/kafka/pull/10990#discussion_r667059387 ## File path: core/src/test/scala/unit/kafka/server/metadata/BrokerMetadataListenerTest.scala ## @@ -18,28 +18,31 @@ package kafka.server.metadata im

[GitHub] [kafka] zhaohaidao commented on a change in pull request #10969: KAFKA-10884: Limit the size of Fetch and FetchSnapshot response based on broker configuration

zhaohaidao commented on a change in pull request #10969: URL: https://github.com/apache/kafka/pull/10969#discussion_r667059331 ## File path: raft/src/test/java/org/apache/kafka/raft/KafkaRaftClientSnapshotTest.java ## @@ -48,6 +48,9 @@ import static org.junit.jupiter.api.Asse

[jira] [Updated] (KAFKA-13055) Security without JAAS file

[ https://issues.apache.org/jira/browse/KAFKA-13055?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alexey Kashavkin updated KAFKA-13055: - Affects Version/s: 2.8.0 > Security without JAAS file > -- > >

[jira] [Created] (KAFKA-13055) Security without JAAS file

Alexey Kashavkin created KAFKA-13055: Summary: Security without JAAS file Key: KAFKA-13055 URL: https://issues.apache.org/jira/browse/KAFKA-13055 Project: Kafka Issue Type: Bug

  1   2   >