[GitHub] [kafka] dengziming commented on pull request #11918: MINOR: Small improvements for KAFKA-13587

2022-03-18 Thread GitBox
dengziming commented on pull request #11918: URL: https://github.com/apache/kafka/pull/11918#issuecomment-1072916007 cc @jsancio -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [kafka] dengziming opened a new pull request #11918: MINOR: Small improvements for KAFKA-13587

2022-03-18 Thread GitBox
dengziming opened a new pull request #11918: URL: https://github.com/apache/kafka/pull/11918 *More detailed description of your change* 1. Fix a bug: comparing values of types Byte and LeaderRecoveryState using `==` will always yield false 2. Show LeaderRecoveryState in MetadataShell

[jira] [Commented] (KAFKA-13404) Kafka sink connectors do not commit offset correctly if messages are produced in transaction

2022-03-18 Thread Yu-Jhe Li (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13404?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17509132#comment-17509132 ] Yu-Jhe Li commented on KAFKA-13404: --- [~ChrisEgerton] yes, the case is similar to KAFKA-6607 in Kafka

[jira] [Updated] (KAFKA-13404) Kafka sink connectors do not commit offset correctly if messages are produced in transaction

2022-03-18 Thread Yu-Jhe Li (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13404?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yu-Jhe Li updated KAFKA-13404: -- Description: The Kafka sink connectors don't commit offset to the latest log-end offset if the

[jira] [Updated] (KAFKA-13404) Kafka sink connectors do not commit offset correctly if messages are produced in transaction

2022-03-18 Thread Yu-Jhe Li (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13404?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yu-Jhe Li updated KAFKA-13404: -- Description: The Kafka sink connectors don't commit offset to the latest log-end offset if the

[GitHub] [kafka] mjsax commented on a change in pull request #11829: [RFC][2/N][emit final] add processor metadata to be committed with offset

2022-03-18 Thread GitBox
mjsax commented on a change in pull request #11829: URL: https://github.com/apache/kafka/pull/11829#discussion_r830404830 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamTask.java ## @@ -1092,13 +1102,55 @@ public boolean

[jira] [Commented] (KAFKA-7509) Kafka Connect logs unnecessary warnings about unused configurations

2022-03-18 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-7509?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17509095#comment-17509095 ] Matthias J. Sax commented on KAFKA-7509: {quote} # Breaking backwards compatibility for a lot of

[GitHub] [kafka] jeff303 commented on pull request #11792: Replace EasyMock/PowerMock with Mockito in DistributedHerderTest

2022-03-18 Thread GitBox
jeff303 commented on pull request #11792: URL: https://github.com/apache/kafka/pull/11792#issuecomment-1072841151 Made a bit more progress on this. Converting `testRebalance` took me a very long time (due to the different paradigm that Mockito uses versus Powermock). The lack of a

[GitHub] [kafka] jsancio merged pull request #11893: KAFKA-13682; KRaft Controller auto preferred leader election

2022-03-18 Thread GitBox
jsancio merged pull request #11893: URL: https://github.com/apache/kafka/pull/11893 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Commented] (KAFKA-13601) Add option to support sync offset commit in Kafka Connect Sink

2022-03-18 Thread Chris Egerton (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13601?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17509066#comment-17509066 ] Chris Egerton commented on KAFKA-13601: --- Thanks for the clarification! Doesn't that mean that this

[jira] [Updated] (KAFKA-13755) Broker heartbeat event should have deadline

2022-03-18 Thread David Arthur (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13755?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Arthur updated KAFKA-13755: - Description: When we schedule the event for processing the broker heartbeat request in

[jira] [Updated] (KAFKA-13755) Broker heartbeat event should have deadline

2022-03-18 Thread David Arthur (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13755?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Arthur updated KAFKA-13755: - Component/s: controller kraft > Broker heartbeat event should have deadline >

[jira] [Updated] (KAFKA-13755) Broker heartbeat event should have deadline

2022-03-18 Thread David Arthur (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13755?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Arthur updated KAFKA-13755: - Component/s: (was: kraft) > Broker heartbeat event should have deadline >

[jira] [Updated] (KAFKA-13755) Broker heartbeat event should have deadline

2022-03-18 Thread David Arthur (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13755?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Arthur updated KAFKA-13755: - Labels: kip-500 (was: ) > Broker heartbeat event should have deadline >

[jira] [Created] (KAFKA-13755) Broker heartbeat event should have deadline

2022-03-18 Thread David Arthur (Jira)
David Arthur created KAFKA-13755: Summary: Broker heartbeat event should have deadline Key: KAFKA-13755 URL: https://issues.apache.org/jira/browse/KAFKA-13755 Project: Kafka Issue Type: Bug

[jira] [Updated] (KAFKA-13741) Cluster IDs should not have leading dash

2022-03-18 Thread David Arthur (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13741?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Arthur updated KAFKA-13741: - Affects Version/s: 3.0.0 3.1.0 > Cluster IDs should not have leading

[jira] [Updated] (KAFKA-13741) Cluster IDs should not have leading dash

2022-03-18 Thread David Arthur (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13741?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Arthur updated KAFKA-13741: - Fix Version/s: 3.2.0 > Cluster IDs should not have leading dash >

[GitHub] [kafka] jsancio commented on pull request #11893: KAFKA-13682; KRaft Controller auto preferred leader election

2022-03-18 Thread GitBox
jsancio commented on pull request #11893: URL: https://github.com/apache/kafka/pull/11893#issuecomment-1072727911 > Could we schedule the immediate event for some time in the near future (> 0, but << leaderImbalanceCheckIntervalNs) to avoid this unfair behavior? I agree. The

[GitHub] [kafka] lihaosky opened a new pull request #11917: [6/N][emit final] time-ordered session store

2022-03-18 Thread GitBox
lihaosky opened a new pull request #11917: URL: https://github.com/apache/kafka/pull/11917 ### Description Time ordered session store implementation. I introduced `AbstractRocksDBTimeOrderedSegmentedBytesStore ` to make it generic for `RocksDBTimeOrderedSessionSegmentedBytesStore` and

[GitHub] [kafka] jsancio commented on a change in pull request #11893: KAFKA-13682; KRaft Controller auto preferred leader election

2022-03-18 Thread GitBox
jsancio commented on a change in pull request #11893: URL: https://github.com/apache/kafka/pull/11893#discussion_r830266611 ## File path: metadata/src/main/java/org/apache/kafka/controller/PartitionChangeBuilder.java ## @@ -104,53 +117,94 @@ public PartitionChangeBuilder

[GitHub] [kafka] jsancio merged pull request #11733: KAFKA-13587; Implement leader recovery for KIP-704

2022-03-18 Thread GitBox
jsancio merged pull request #11733: URL: https://github.com/apache/kafka/pull/11733 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [kafka] mumrah commented on a change in pull request #11893: KAFKA-13682; KRaft Controller auto preferred leader election

2022-03-18 Thread GitBox
mumrah commented on a change in pull request #11893: URL: https://github.com/apache/kafka/pull/11893#discussion_r830091363 ## File path: metadata/src/main/java/org/apache/kafka/controller/PartitionChangeBuilder.java ## @@ -51,32 +50,46 @@ public static boolean

[GitHub] [kafka] jolshan commented on pull request #11912: KAFKA-13752: Uuid compare using equals in java

2022-03-18 Thread GitBox
jolshan commented on pull request #11912: URL: https://github.com/apache/kafka/pull/11912#issuecomment-1072551230 > Overall, I think that the impact of the bug is small because we usually rely on Uuid.ZERO_UUID by default so comparing the references also works. Yeah, I think that

[jira] [Commented] (KAFKA-13422) Even if the correct username and password are configured, when ClientBroker or KafkaClient tries to establish a SASL connection to ServerBroker, an exception is thrown

2022-03-18 Thread RivenSun (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13422?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17508870#comment-17508870 ] RivenSun commented on KAFKA-13422: -- [~dajac]  Most people, including myself, learn how to enable

[jira] [Comment Edited] (KAFKA-13751) On the broker side, OAUTHBEARER is not compatible with other SASL mechanisms

2022-03-18 Thread RivenSun (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13751?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17508856#comment-17508856 ] RivenSun edited comment on KAFKA-13751 at 3/18/22, 3:09 PM: Hi [~dajac]

[GitHub] [kafka] jsancio commented on a change in pull request #11893: KAFKA-13682; KRaft Controller auto preferred leader election

2022-03-18 Thread GitBox
jsancio commented on a change in pull request #11893: URL: https://github.com/apache/kafka/pull/11893#discussion_r829411491 ## File path: metadata/src/main/java/org/apache/kafka/controller/PartitionChangeBuilder.java ## @@ -104,53 +117,73 @@ public PartitionChangeBuilder

[GitHub] [kafka] mumrah commented on a change in pull request #11893: KAFKA-13682; KRaft Controller auto preferred leader election

2022-03-18 Thread GitBox
mumrah commented on a change in pull request #11893: URL: https://github.com/apache/kafka/pull/11893#discussion_r830085260 ## File path: metadata/src/main/java/org/apache/kafka/controller/ReplicationControlManager.java ## @@ -341,22 +359,25 @@ public void

[GitHub] [kafka] dengziming commented on pull request #11913: MINOR: Remove scala KafkaException

2022-03-18 Thread GitBox
dengziming commented on pull request #11913: URL: https://github.com/apache/kafka/pull/11913#issuecomment-1070870414 We can safely remove this class since we have removed kafka.security.auth.Authorizer in #10450 , ping @ijuma to have a look -- This is an automated message from the

[GitHub] [kafka] dengziming commented on a change in pull request #11471: MINOR: Replace EasyMock with Mockito in connect:file

2022-03-18 Thread GitBox
dengziming commented on a change in pull request #11471: URL: https://github.com/apache/kafka/pull/11471#discussion_r829040670 ## File path: connect/file/src/test/java/org/apache/kafka/connect/file/FileStreamSourceTaskTest.java ## @@ -73,7 +75,6 @@ public void teardown() {

[GitHub] [kafka] dengziming commented on pull request #11910: KAFKA-13743: Prevent topics with conflicting metrics names from being created in KRaft mode

2022-03-18 Thread GitBox
dengziming commented on pull request #11910: URL: https://github.com/apache/kafka/pull/11910#issuecomment-1072029922 cc @cmccabe -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[jira] [Commented] (KAFKA-13751) On the broker side, OAUTHBEARER is not compatible with other SASL mechanisms

2022-03-18 Thread RivenSun (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13751?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17508856#comment-17508856 ] RivenSun commented on KAFKA-13751: -- Hi [~dajac] Thanks for your reply. 1. When using JaasConfigFile,

[GitHub] [kafka] fxbing commented on pull request #11912: KAFKA-13752: Uuid compare using equals in java

2022-03-18 Thread GitBox
fxbing commented on pull request #11912: URL: https://github.com/apache/kafka/pull/11912#issuecomment-1071008981 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [kafka] dajac commented on a change in pull request #11912: KAFKA-13752: Uuid compare using equals in java

2022-03-18 Thread GitBox
dajac commented on a change in pull request #11912: URL: https://github.com/apache/kafka/pull/11912#discussion_r829771763 ## File path: clients/src/test/java/org/apache/kafka/common/requests/MetadataRequestTest.java ## @@ -20,6 +20,7 @@ import

[GitHub] [kafka] junrao commented on a change in pull request #11893: KAFKA-13682; KRaft Controller auto preferred leader election

2022-03-18 Thread GitBox
junrao commented on a change in pull request #11893: URL: https://github.com/apache/kafka/pull/11893#discussion_r829355001 ## File path: metadata/src/main/java/org/apache/kafka/controller/PartitionChangeBuilder.java ## @@ -104,53 +117,73 @@ public PartitionChangeBuilder

[GitHub] [kafka] jolshan commented on pull request #11912: KAFKA-13752: Uuid compare using equals in java

2022-03-18 Thread GitBox
jolshan commented on pull request #11912: URL: https://github.com/apache/kafka/pull/11912#issuecomment-1071812161 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [kafka] wsun-confluent commented on a change in pull request #11874: Fix typos in configuration docs

2022-03-18 Thread GitBox
wsun-confluent commented on a change in pull request #11874: URL: https://github.com/apache/kafka/pull/11874#discussion_r829578541 ## File path: clients/src/main/java/org/apache/kafka/clients/producer/ProducerConfig.java ## @@ -216,8 +216,10 @@ private static final

[GitHub] [kafka] dengziming commented on pull request #11912: KAFKA-13752: Uuid compare using equals in java

2022-03-18 Thread GitBox
dengziming commented on pull request #11912: URL: https://github.com/apache/kafka/pull/11912#issuecomment-1070947835 Thank you for this PR, can you also add a test case in `MetadataRequestTest.testTopicIdAndNullTopicNameRequests`? -- This is an automated message from the Apache Git

[GitHub] [kafka] dajac commented on pull request #11904: MINOR: Fix `ConsumerConfig.ISOLATION_LEVEL_DOC`

2022-03-18 Thread GitBox
dajac commented on pull request #11904: URL: https://github.com/apache/kafka/pull/11904#issuecomment-1071105004 @guizmaii Good catch! Why did you target 3.1 branch? We should fix it in trunk and I can back port it to older branches. -- This is an automated message from the Apache Git

[GitHub] [kafka] dajac commented on pull request #11909: KAFKA-13750: Client Compatability KafkaTest uses invalid idempotency configs

2022-03-18 Thread GitBox
dajac commented on pull request #11909: URL: https://github.com/apache/kafka/pull/11909#issuecomment-1071077188 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [kafka] dongjinleekr commented on pull request #7898: KAFKA-9366: Change log4j dependency into log4j2

2022-03-18 Thread GitBox
dongjinleekr commented on pull request #7898: URL: https://github.com/apache/kafka/pull/7898#issuecomment-1072452078 @showuon Here is the update, rebasing onto the latest trunk. :bow: -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [kafka] dongjinleekr commented on a change in pull request #7898: KAFKA-9366: Change log4j dependency into log4j2

2022-03-18 Thread GitBox
dongjinleekr commented on a change in pull request #7898: URL: https://github.com/apache/kafka/pull/7898#discussion_r829746139 ## File path: streams/src/test/java/org/apache/kafka/streams/StreamsConfigTest.java ## @@ -1024,55 +1033,61 @@ public void

[GitHub] [kafka] dajac commented on pull request #11912: KAFKA-13752: Uuid compare using equals in java

2022-03-18 Thread GitBox
dajac commented on pull request #11912: URL: https://github.com/apache/kafka/pull/11912#issuecomment-1072129252 @fxbing Could you update the description of the PR as well? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [kafka] dajac merged pull request #11173: KAFKA-13509: Support max timestamp in GetOffsetShell

2022-03-18 Thread GitBox
dajac merged pull request #11173: URL: https://github.com/apache/kafka/pull/11173 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [kafka] dajac commented on pull request #11173: KAFKA-13509: Support max timestamp in GetOffsetShell

2022-03-18 Thread GitBox
dajac commented on pull request #11173: URL: https://github.com/apache/kafka/pull/11173#issuecomment-1071074769 The build looks good [here](https://ci-builds.apache.org/blue/organizations/jenkins/Kafka%2Fkafka-pr/detail/PR-11173/18/pipeline). I am not sure why github still shows it in

[GitHub] [kafka] dengziming commented on pull request #11173: KAFKA-13509: Support max timestamp in GetOffsetShell

2022-03-18 Thread GitBox
dengziming commented on pull request #11173: URL: https://github.com/apache/kafka/pull/11173#issuecomment-1070856842 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [kafka] guizmaii closed pull request #11904: MINOR: Fix `ConsumerConfig.ISOLATION_LEVEL_DOC`

2022-03-18 Thread GitBox
guizmaii closed pull request #11904: URL: https://github.com/apache/kafka/pull/11904 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [kafka] jolshan commented on a change in pull request #11909: KAFKA-13750: Client Compatability KafkaTest uses invalid idempotency configs

2022-03-18 Thread GitBox
jolshan commented on a change in pull request #11909: URL: https://github.com/apache/kafka/pull/11909#discussion_r829541377 ## File path: tools/src/main/java/org/apache/kafka/tools/ClientCompatibilityTest.java ## @@ -172,6 +174,13 @@ public static void main(String[] args)

[GitHub] [kafka] dajac merged pull request #11903: KAFKA-13497: Add trace logging to RegexRouter

2022-03-18 Thread GitBox
dajac merged pull request #11903: URL: https://github.com/apache/kafka/pull/11903 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [kafka] showuon merged pull request #11905: MINOR: Fix incorrect log for out-of-order KTable

2022-03-18 Thread GitBox
showuon merged pull request #11905: URL: https://github.com/apache/kafka/pull/11905 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [kafka] dajac merged pull request #11909: KAFKA-13750: Client Compatability KafkaTest uses invalid idempotency configs

2022-03-18 Thread GitBox
dajac merged pull request #11909: URL: https://github.com/apache/kafka/pull/11909 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [kafka] jolshan removed a comment on pull request #11912: KAFKA-13752: Uuid compare using equals in java

2022-03-18 Thread GitBox
jolshan removed a comment on pull request #11912: URL: https://github.com/apache/kafka/pull/11912#issuecomment-1071812161 I was thinking adding the test from the ticket and verifying it _**doesn't**_ return an error. -- This is an automated message from the Apache Git Service. To

[GitHub] [kafka] mimaison merged pull request #11471: MINOR: Replace EasyMock with Mockito in connect:file

2022-03-18 Thread GitBox
mimaison merged pull request #11471: URL: https://github.com/apache/kafka/pull/11471 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [kafka] guizmaii commented on pull request #11904: MINOR: Fix `ConsumerConfig.ISOLATION_LEVEL_DOC`

2022-03-18 Thread GitBox
guizmaii commented on pull request #11904: URL: https://github.com/apache/kafka/pull/11904#issuecomment-1071947794 @dajac I opened a PR on trunk here: https://github.com/apache/kafka/pull/11915 -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [kafka] dajac commented on pull request #11906: MINOR: Doc updates for Kafka 3.0.1

2022-03-18 Thread GitBox
dajac commented on pull request #11906: URL: https://github.com/apache/kafka/pull/11906#issuecomment-1071088775 @mimaison Thanks. Do we need to update the doc in the 3.0 branch as well? Otherwise, we will miss the update that you did if we would ever release 3.0.2. -- This is an

[GitHub] [kafka] dajac commented on pull request #11915: MINOR: Fix `ConsumerConfig.ISOLATION_LEVEL_DOC`

2022-03-18 Thread GitBox
dajac commented on pull request #11915: URL: https://github.com/apache/kafka/pull/11915#issuecomment-1072142112 Merged to trunk, 3.1 and 3.0. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [kafka] jolshan commented on pull request #11909: KAFKA-13750: Client Compatability KafkaTest uses invalid idempotency configs

2022-03-18 Thread GitBox
jolshan commented on pull request #11909: URL: https://github.com/apache/kafka/pull/11909#issuecomment-1070978591 Here is a link to a successful run:

[GitHub] [kafka] dengziming commented on a change in pull request #11173: KAFKA-13509: Support max timestamp in GetOffsetShell

2022-03-18 Thread GitBox
dengziming commented on a change in pull request #11173: URL: https://github.com/apache/kafka/pull/11173#discussion_r829057799 ## File path: core/src/main/scala/kafka/tools/GetOffsetShell.scala ## @@ -103,59 +104,77 @@ object GetOffsetShell { throw new

[GitHub] [kafka] dajac merged pull request #11915: MINOR: Fix `ConsumerConfig.ISOLATION_LEVEL_DOC`

2022-03-18 Thread GitBox
dajac merged pull request #11915: URL: https://github.com/apache/kafka/pull/11915 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [kafka] jsancio commented on pull request #11733: KAFKA-13587; Implement leader recovery for KIP-704

2022-03-18 Thread GitBox
jsancio commented on pull request #11733: URL: https://github.com/apache/kafka/pull/11733#issuecomment-1071229122 > The PR looks good overall. I think there is one problem with the fetch validation. We are expecting that followers will detect the RECOVERED state through a `LeaderAndIsr`

[GitHub] [kafka] dajac commented on a change in pull request #11903: KAFKA-13497: Add trace logging to RegexRouter

2022-03-18 Thread GitBox
dajac commented on a change in pull request #11903: URL: https://github.com/apache/kafka/pull/11903#discussion_r82930 ## File path: connect/transforms/src/main/java/org/apache/kafka/connect/transforms/RegexRouter.java ## @@ -57,7 +61,10 @@ public R apply(R record) {

[GitHub] [kafka] showuon commented on pull request #11905: MINOR: Fix incorrect log for out-of-order KTable

2022-03-18 Thread GitBox
showuon commented on pull request #11905: URL: https://github.com/apache/kafka/pull/11905#issuecomment-1071946079 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [kafka] fxbing commented on a change in pull request #11912: KAFKA-13752: Uuid compare using equals in java

2022-03-18 Thread GitBox
fxbing commented on a change in pull request #11912: URL: https://github.com/apache/kafka/pull/11912#discussion_r829903239 ## File path: clients/src/test/java/org/apache/kafka/common/requests/MetadataRequestTest.java ## @@ -20,6 +20,7 @@ import

[GitHub] [kafka] C0urante commented on a change in pull request #11903: KAFKA-13497: Add trace logging to RegexRouter

2022-03-18 Thread GitBox
C0urante commented on a change in pull request #11903: URL: https://github.com/apache/kafka/pull/11903#discussion_r829392255 ## File path: connect/transforms/src/main/java/org/apache/kafka/connect/transforms/RegexRouter.java ## @@ -57,7 +61,10 @@ public R apply(R record) {

[GitHub] [kafka] tchiotludo commented on pull request #11905: MINOR: Fix incorrect log for out-of-order KTable

2022-03-18 Thread GitBox
tchiotludo commented on pull request #11905: URL: https://github.com/apache/kafka/pull/11905#issuecomment-1071509762 @showuon must be done I think ;) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[jira] [Commented] (KAFKA-13422) Even if the correct username and password are configured, when ClientBroker or KafkaClient tries to establish a SASL connection to ServerBroker, an exception is thrown

2022-03-18 Thread David Jacot (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13422?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17508813#comment-17508813 ] David Jacot commented on KAFKA-13422: - > But for ClientBroker, it also needs to play the role of

[jira] [Commented] (KAFKA-13751) On the broker side, OAUTHBEARER is not compatible with other SASL mechanisms

2022-03-18 Thread David Jacot (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13751?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17508806#comment-17508806 ] David Jacot commented on KAFKA-13751: - [~RivenSun] I am not sure to fully understand your point

[GitHub] [kafka] dongjinleekr commented on pull request #7898: KAFKA-9366: Change log4j dependency into log4j2

2022-03-18 Thread GitBox
dongjinleekr commented on pull request #7898: URL: https://github.com/apache/kafka/pull/7898#issuecomment-1072452078 @showuon Here is the update, rebasing onto the latest trunk. :bow: -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [kafka] dongjinleekr commented on a change in pull request #7898: KAFKA-9366: Change log4j dependency into log4j2

2022-03-18 Thread GitBox
dongjinleekr commented on a change in pull request #7898: URL: https://github.com/apache/kafka/pull/7898#discussion_r830011584 ## File path: streams/src/test/java/org/apache/kafka/streams/state/internals/RocksDBTimestampedStoreTest.java ## @@ -53,161 +53,166 @@ RocksDBStore

[jira] [Commented] (KAFKA-13422) Even if the correct username and password are configured, when ClientBroker or KafkaClient tries to establish a SASL connection to ServerBroker, an exception is thrown

2022-03-18 Thread RivenSun (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13422?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17508777#comment-17508777 ] RivenSun commented on KAFKA-13422: -- For general kafkaClient, we really only need to configure one

[jira] [Commented] (KAFKA-13422) Even if the correct username and password are configured, when ClientBroker or KafkaClient tries to establish a SASL connection to ServerBroker, an exception is thrown

2022-03-18 Thread RivenSun (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13422?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17508769#comment-17508769 ] RivenSun commented on KAFKA-13422: -- Only when Broker wants to use `sasl.jaas.config configuration, will

[GitHub] [kafka] dajac commented on a change in pull request #11912: KAFKA-13752: Uuid compare using equals in java

2022-03-18 Thread GitBox
dajac commented on a change in pull request #11912: URL: https://github.com/apache/kafka/pull/11912#discussion_r829973928 ## File path: clients/src/main/java/org/apache/kafka/common/requests/MetadataResponse.java ## @@ -151,7 +151,7 @@ public Cluster buildCluster() {

[jira] [Commented] (KAFKA-13422) Even if the correct username and password are configured, when ClientBroker or KafkaClient tries to establish a SASL connection to ServerBroker, an exception is thrown

2022-03-18 Thread RivenSun (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13422?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17508759#comment-17508759 ] RivenSun commented on KAFKA-13422: -- As I mentioned above, the more important role of `sasl.jaas.config`

[jira] [Commented] (KAFKA-13422) Even if the correct username and password are configured, when ClientBroker or KafkaClient tries to establish a SASL connection to ServerBroker, an exception is thrown

2022-03-18 Thread David Jacot (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13422?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17508755#comment-17508755 ] David Jacot commented on KAFKA-13422: - > But it makes sense to configure multiple loginModule in

[jira] [Comment Edited] (KAFKA-13422) Even if the correct username and password are configured, when ClientBroker or KafkaClient tries to establish a SASL connection to ServerBroker, an exception is t

2022-03-18 Thread RivenSun (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13422?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17508747#comment-17508747 ] RivenSun edited comment on KAFKA-13422 at 3/18/22, 12:32 PM: - Hi [~dajac] 

[jira] [Comment Edited] (KAFKA-13422) Even if the correct username and password are configured, when ClientBroker or KafkaClient tries to establish a SASL connection to ServerBroker, an exception is t

2022-03-18 Thread RivenSun (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13422?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17508747#comment-17508747 ] RivenSun edited comment on KAFKA-13422 at 3/18/22, 12:26 PM: - Hi [~dajac] 

[jira] [Comment Edited] (KAFKA-13422) Even if the correct username and password are configured, when ClientBroker or KafkaClient tries to establish a SASL connection to ServerBroker, an exception is t

2022-03-18 Thread RivenSun (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13422?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17508747#comment-17508747 ] RivenSun edited comment on KAFKA-13422 at 3/18/22, 12:25 PM: - Hi [~dajac] 

[jira] [Commented] (KAFKA-13422) Even if the correct username and password are configured, when ClientBroker or KafkaClient tries to establish a SASL connection to ServerBroker, an exception is thrown

2022-03-18 Thread RivenSun (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13422?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17508747#comment-17508747 ] RivenSun commented on KAFKA-13422: -- Hi [~dajac]  Thank you for your reply and for understanding what I

[GitHub] [kafka] fxbing commented on a change in pull request #11912: KAFKA-13752: Uuid compare using equals in java

2022-03-18 Thread GitBox
fxbing commented on a change in pull request #11912: URL: https://github.com/apache/kafka/pull/11912#discussion_r829904200 ## File path: clients/src/main/java/org/apache/kafka/common/requests/MetadataResponse.java ## @@ -151,7 +151,7 @@ public Cluster buildCluster() {

[GitHub] [kafka] fxbing commented on a change in pull request #11912: KAFKA-13752: Uuid compare using equals in java

2022-03-18 Thread GitBox
fxbing commented on a change in pull request #11912: URL: https://github.com/apache/kafka/pull/11912#discussion_r829904200 ## File path: clients/src/main/java/org/apache/kafka/common/requests/MetadataResponse.java ## @@ -151,7 +151,7 @@ public Cluster buildCluster() {

[GitHub] [kafka] fxbing commented on a change in pull request #11912: KAFKA-13752: Uuid compare using equals in java

2022-03-18 Thread GitBox
fxbing commented on a change in pull request #11912: URL: https://github.com/apache/kafka/pull/11912#discussion_r829903239 ## File path: clients/src/test/java/org/apache/kafka/common/requests/MetadataRequestTest.java ## @@ -20,6 +20,7 @@ import

[jira] [Commented] (KAFKA-13422) Even if the correct username and password are configured, when ClientBroker or KafkaClient tries to establish a SASL connection to ServerBroker, an exception is thrown

2022-03-18 Thread David Jacot (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13422?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17508722#comment-17508722 ] David Jacot commented on KAFKA-13422: - [~RivenSun] Thanks for reporting this and for the analysis.

[jira] [Resolved] (KAFKA-13497) Debug Log RegexRouter transform

2022-03-18 Thread David Jacot (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13497?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Jacot resolved KAFKA-13497. - Fix Version/s: 3.2.0 Reviewer: David Jacot Resolution: Fixed > Debug Log

[GitHub] [kafka] dajac merged pull request #11903: KAFKA-13497: Add trace logging to RegexRouter

2022-03-18 Thread GitBox
dajac merged pull request #11903: URL: https://github.com/apache/kafka/pull/11903 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [kafka] dajac commented on a change in pull request #11903: KAFKA-13497: Add trace logging to RegexRouter

2022-03-18 Thread GitBox
dajac commented on a change in pull request #11903: URL: https://github.com/apache/kafka/pull/11903#discussion_r829826219 ## File path: connect/transforms/src/main/java/org/apache/kafka/connect/transforms/RegexRouter.java ## @@ -57,7 +61,10 @@ public R apply(R record) {

[GitHub] [kafka] fxbing commented on pull request #11912: KAFKA-13752: Uuid compare using equals in java

2022-03-18 Thread GitBox
fxbing commented on pull request #11912: URL: https://github.com/apache/kafka/pull/11912#issuecomment-1072178459 > @fxbing Could you update the description of the PR as well? done. PTAL -- This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [kafka] fxbing commented on pull request #11912: KAFKA-13752: Uuid compare using equals in java

2022-03-18 Thread GitBox
fxbing commented on pull request #11912: URL: https://github.com/apache/kafka/pull/11912#issuecomment-1072177203 > @fxbing Thanks for the PR. Good catch! Overall, I think that the impact of the bug is small because we usually rely on `Uuid.ZERO_UUID` by default so comparing the references

[GitHub] [kafka] dajac commented on pull request #11915: MINOR: Fix `ConsumerConfig.ISOLATION_LEVEL_DOC`

2022-03-18 Thread GitBox
dajac commented on pull request #11915: URL: https://github.com/apache/kafka/pull/11915#issuecomment-1072142112 Merged to trunk, 3.1 and 3.0. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [kafka] dajac merged pull request #11915: MINOR: Fix `ConsumerConfig.ISOLATION_LEVEL_DOC`

2022-03-18 Thread GitBox
dajac merged pull request #11915: URL: https://github.com/apache/kafka/pull/11915 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [kafka] dongjinleekr commented on a change in pull request #7898: KAFKA-9366: Change log4j dependency into log4j2

2022-03-18 Thread GitBox
dongjinleekr commented on a change in pull request #7898: URL: https://github.com/apache/kafka/pull/7898#discussion_r829777640 ## File path: streams/src/test/java/org/apache/kafka/streams/kstream/internals/KStreamSlidingWindowAggregateTest.java ## @@ -715,19 +713,13 @@ public

[GitHub] [kafka] dajac commented on pull request #11912: KAFKA-13752: Uuid compare using equals in java

2022-03-18 Thread GitBox
dajac commented on pull request #11912: URL: https://github.com/apache/kafka/pull/11912#issuecomment-1072129252 @fxbing Could you update the description of the PR as well? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [kafka] dajac commented on a change in pull request #11912: KAFKA-13752: Uuid compare using equals in java

2022-03-18 Thread GitBox
dajac commented on a change in pull request #11912: URL: https://github.com/apache/kafka/pull/11912#discussion_r829771763 ## File path: clients/src/test/java/org/apache/kafka/common/requests/MetadataRequestTest.java ## @@ -20,6 +20,7 @@ import

[GitHub] [kafka] dongjinleekr commented on a change in pull request #7898: KAFKA-9366: Change log4j dependency into log4j2

2022-03-18 Thread GitBox
dongjinleekr commented on a change in pull request #7898: URL: https://github.com/apache/kafka/pull/7898#discussion_r829774103 ## File path: streams/src/test/java/org/apache/kafka/streams/kstream/internals/KStreamSlidingWindowAggregateTest.java ## @@ -715,19 +713,13 @@ public

[jira] [Commented] (KAFKA-13584) Fix `kafka.network.SocketServerTest.testUnmuteChannelWithBufferedReceives` flaky test

2022-03-18 Thread David Jacot (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13584?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17508636#comment-17508636 ] David Jacot commented on KAFKA-13584: - This commit

[jira] [Resolved] (KAFKA-13584) Fix `kafka.network.SocketServerTest.testUnmuteChannelWithBufferedReceives` flaky test

2022-03-18 Thread David Jacot (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13584?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Jacot resolved KAFKA-13584. - Resolution: Fixed Fixed by

[jira] [Commented] (KAFKA-13287) Upgrade RocksDB to 6.22.1.1

2022-03-18 Thread RivenSun (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13287?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17508638#comment-17508638 ] RivenSun commented on KAFKA-13287: -- Hi [~cadonna]  I have created KAFKA-13422 a long time ago which

[GitHub] [kafka] dongjinleekr commented on a change in pull request #7898: KAFKA-9366: Change log4j dependency into log4j2

2022-03-18 Thread GitBox
dongjinleekr commented on a change in pull request #7898: URL: https://github.com/apache/kafka/pull/7898#discussion_r829748108 ## File path: streams/src/test/java/org/apache/kafka/streams/StreamsConfigTest.java ## @@ -1024,55 +1033,61 @@ public void

[GitHub] [kafka] chromy96 opened a new pull request #11916: Allow unencrypted private keys when using PEM files

2022-03-18 Thread GitBox
chromy96 opened a new pull request #11916: URL: https://github.com/apache/kafka/pull/11916 When using PEM files, keyPassword has to be specified, while when setting private key and certificate chain as strings keyPassword is allowed to be null. This PR fixes this. Issue is described in

[GitHub] [kafka] dongjinleekr commented on a change in pull request #7898: KAFKA-9366: Change log4j dependency into log4j2

2022-03-18 Thread GitBox
dongjinleekr commented on a change in pull request #7898: URL: https://github.com/apache/kafka/pull/7898#discussion_r829746139 ## File path: streams/src/test/java/org/apache/kafka/streams/StreamsConfigTest.java ## @@ -1024,55 +1033,61 @@ public void