[GitHub] [kafka] dengziming commented on pull request #12024: MINOR: Move some integration tests to unit tests

dengziming commented on PR #12024: URL: https://github.com/apache/kafka/pull/12024#issuecomment-1098734652 @showuon Thank you for your suggestions and comments, here I just moved some tests and didn't change their logic, nor did I remove or add tests here, and I resolved your comments, you

[GitHub] [kafka] dengziming commented on a diff in pull request #12024: MINOR: Move some integration tests to unit tests

dengziming commented on code in PR #12024: URL: https://github.com/apache/kafka/pull/12024#discussion_r850103215 ## core/src/test/scala/unit/kafka/admin/TopicCommandTest.scala: ## @@ -159,6 +167,74 @@ class TopicCommandTest { assertEquals(expectedAssignment,

[GitHub] [kafka] dengziming commented on a diff in pull request #12024: MINOR: Move some integration tests to unit tests

dengziming commented on code in PR #12024: URL: https://github.com/apache/kafka/pull/12024#discussion_r850102307 ## core/src/test/scala/unit/kafka/admin/ConfigCommandTest.scala: ## @@ -391,7 +298,7 @@ class ConfigCommandTest extends QuorumTestHarness with Logging { def

[GitHub] [kafka] dengziming commented on a diff in pull request #12024: MINOR: Move some integration tests to unit tests

dengziming commented on code in PR #12024: URL: https://github.com/apache/kafka/pull/12024#discussion_r850102090 ## core/src/test/scala/unit/kafka/admin/ConfigCommandTest.scala: ## @@ -19,123 +19,30 @@ package kafka.admin import java.util import java.util.Properties import

[GitHub] [kafka] artemlivshits commented on a diff in pull request #12006: KAFKA-13794: Follow up to fix comparator

artemlivshits commented on code in PR #12006: URL: https://github.com/apache/kafka/pull/12006#discussion_r850094266 ## clients/src/main/java/org/apache/kafka/clients/producer/internals/TransactionManager.java: ## @@ -187,7 +187,7 @@ private void

[GitHub] [kafka] ijuma commented on a diff in pull request #12006: KAFKA-13794: Follow up to fix comparator

ijuma commented on code in PR #12006: URL: https://github.com/apache/kafka/pull/12006#discussion_r850086685 ## clients/src/main/java/org/apache/kafka/clients/producer/internals/TransactionManager.java: ## @@ -187,7 +187,7 @@ private static class TopicPartitionEntry {

[GitHub] [kafka] ijuma commented on a diff in pull request #12006: KAFKA-13794: Follow up to fix comparator

ijuma commented on code in PR #12006: URL: https://github.com/apache/kafka/pull/12006#discussion_r850086332 ## clients/src/main/java/org/apache/kafka/clients/producer/internals/TransactionManager.java: ## @@ -187,7 +187,7 @@ private void startSequencesAtBeginning(TopicPartition

[GitHub] [kafka] artemlivshits commented on a diff in pull request #12006: KAFKA-13794: Follow up to fix comparator

artemlivshits commented on code in PR #12006: URL: https://github.com/apache/kafka/pull/12006#discussion_r850080492 ## clients/src/main/java/org/apache/kafka/clients/producer/internals/TransactionManager.java: ## @@ -187,7 +187,7 @@ private static class TopicPartitionEntry {

[GitHub] [kafka] artemlivshits commented on a diff in pull request #12006: KAFKA-13794: Follow up to fix comparator

artemlivshits commented on code in PR #12006: URL: https://github.com/apache/kafka/pull/12006#discussion_r850078629 ## clients/src/main/java/org/apache/kafka/clients/producer/internals/TransactionManager.java: ## @@ -187,7 +187,7 @@ private void

[GitHub] [kafka] showuon commented on a diff in pull request #12024: MINOR: Move some integration tests to unit tests

showuon commented on code in PR #12024: URL: https://github.com/apache/kafka/pull/12024#discussion_r850045692 ## core/src/test/scala/unit/kafka/admin/TopicCommandTest.scala: ## @@ -159,6 +167,74 @@ class TopicCommandTest { assertEquals(expectedAssignment, actualAssignment)

[jira] [Updated] (KAFKA-13827) Data Loss on moving to KRAFT mode from v3.1

[ https://issues.apache.org/jira/browse/KAFKA-13827?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sharad Garg updated KAFKA-13827: Description: * Topics created in v2.8/v3.1 that have data are empty (data is deleted) in KRAFT

[jira] [Assigned] (KAFKA-13788) Creation of invalid dynamic config prevents further creation of valid configs

[ https://issues.apache.org/jira/browse/KAFKA-13788?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] dengziming reassigned KAFKA-13788: -- Assignee: dengziming > Creation of invalid dynamic config prevents further creation of valid

[GitHub] [kafka] ijuma commented on a diff in pull request #12006: KAFKA-13794: Follow up to fix comparator

ijuma commented on code in PR #12006: URL: https://github.com/apache/kafka/pull/12006#discussion_r850033183 ## clients/src/main/java/org/apache/kafka/clients/producer/internals/TransactionManager.java: ## @@ -187,7 +187,7 @@ private static class TopicPartitionEntry {

[GitHub] [kafka] ijuma commented on a diff in pull request #12006: KAFKA-13794: Follow up to fix comparator

ijuma commented on code in PR #12006: URL: https://github.com/apache/kafka/pull/12006#discussion_r850032346 ## clients/src/main/java/org/apache/kafka/clients/producer/internals/TransactionManager.java: ## @@ -187,7 +187,7 @@ private void startSequencesAtBeginning(TopicPartition

[GitHub] [kafka] ijuma commented on a diff in pull request #12006: KAFKA-13794: Follow up to fix comparator

ijuma commented on code in PR #12006: URL: https://github.com/apache/kafka/pull/12006#discussion_r850033183 ## clients/src/main/java/org/apache/kafka/clients/producer/internals/TransactionManager.java: ## @@ -187,7 +187,7 @@ private static class TopicPartitionEntry {

[GitHub] [kafka] ijuma commented on a diff in pull request #12006: KAFKA-13794: Follow up to fix comparator

ijuma commented on code in PR #12006: URL: https://github.com/apache/kafka/pull/12006#discussion_r850032346 ## clients/src/main/java/org/apache/kafka/clients/producer/internals/TransactionManager.java: ## @@ -187,7 +187,7 @@ private void startSequencesAtBeginning(TopicPartition

[GitHub] [kafka] ijuma commented on a diff in pull request #12006: KAFKA-13794: Follow up to fix comparator

ijuma commented on code in PR #12006: URL: https://github.com/apache/kafka/pull/12006#discussion_r850032346 ## clients/src/main/java/org/apache/kafka/clients/producer/internals/TransactionManager.java: ## @@ -187,7 +187,7 @@ private void startSequencesAtBeginning(TopicPartition

[jira] [Resolved] (KAFKA-13743) kraft controller should prevent topics with conflicting metrics names from being created

[ https://issues.apache.org/jira/browse/KAFKA-13743?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] dengziming resolved KAFKA-13743. Reviewer: Colin McCabe Resolution: Fixed > kraft controller should prevent topics with

[jira] [Updated] (KAFKA-13743) kraft controller should prevent topics with conflicting metrics names from being created

[ https://issues.apache.org/jira/browse/KAFKA-13743?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] dengziming updated KAFKA-13743: --- Fix Version/s: 3.3.0 > kraft controller should prevent topics with conflicting metrics names from

[GitHub] [kafka] showuon commented on a diff in pull request #12006: KAFKA-13794: Follow up to fix comparator

showuon commented on code in PR #12006: URL: https://github.com/apache/kafka/pull/12006#discussion_r850029605 ## clients/src/main/java/org/apache/kafka/clients/producer/internals/TransactionManager.java: ## @@ -187,7 +187,7 @@ private static class TopicPartitionEntry {

[jira] [Comment Edited] (KAFKA-12495) Unbalanced connectors/tasks distribution will happen in Connect's incremental cooperative assignor

[ https://issues.apache.org/jira/browse/KAFKA-12495?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17521996#comment-17521996 ] Chris Egerton edited comment on KAFKA-12495 at 4/14/22 2:14 AM:

[GitHub] [kafka] mumrah commented on pull request #12036: KAFKA-13823 Feature flag changes from KIP-778

mumrah commented on PR #12036: URL: https://github.com/apache/kafka/pull/12036#issuecomment-1098624399 @cmccabe Fixed a few integration tests and producer ID block thing in latest commit. -- This is an automated message from the Apache Git Service. To respond to the message, please log

[jira] [Commented] (KAFKA-12495) Unbalanced connectors/tasks distribution will happen in Connect's incremental cooperative assignor

[ https://issues.apache.org/jira/browse/KAFKA-12495?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17521996#comment-17521996 ] Chris Egerton commented on KAFKA-12495: --- {quote}Allowing for consecutive revocations that happen

[GitHub] [kafka] bozhao12 opened a new pull request, #12047: MINOR:Metric clear when ReplicaManager shutdown

bozhao12 opened a new pull request, #12047: URL: https://github.com/apache/kafka/pull/12047 ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation - [ ] Verify test coverage and CI build status - [ ] Verify documentation (including upgrade

[GitHub] [kafka] ijuma commented on a diff in pull request #12006: KAFKA-13794: Follow up to fix comparator

ijuma commented on code in PR #12006: URL: https://github.com/apache/kafka/pull/12006#discussion_r850003757 ## clients/src/main/java/org/apache/kafka/clients/producer/internals/TransactionManager.java: ## @@ -187,7 +187,7 @@ private static class TopicPartitionEntry {

[jira] [Commented] (KAFKA-13808) Mirrormaker2 stop sync data when modify topic partition in "Running a dedicated MirrorMaker cluster" mode

[ https://issues.apache.org/jira/browse/KAFKA-13808?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17521986#comment-17521986 ] Chris Egerton commented on KAFKA-13808: --- This is a duplicate of

[jira] [Resolved] (KAFKA-13808) Mirrormaker2 stop sync data when modify topic partition in "Running a dedicated MirrorMaker cluster" mode

[ https://issues.apache.org/jira/browse/KAFKA-13808?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chris Egerton resolved KAFKA-13808. --- Resolution: Duplicate > Mirrormaker2 stop sync data when modify topic partition in

[jira] [Commented] (KAFKA-12909) Allow users to opt-into spurious left/outer stream-stream join improvement

[ https://issues.apache.org/jira/browse/KAFKA-12909?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17521985#comment-17521985 ] Matthias J. Sax commented on KAFKA-12909: - This ticket is about left/outer join in particular

[GitHub] [kafka] C0urante commented on pull request #11775: KAFKA-10000: Add all public-facing config properties related to exactly-once source support (KIP-618)

C0urante commented on PR #11775: URL: https://github.com/apache/kafka/pull/11775#issuecomment-1098593611 Sorry @showuon, should be good to go now. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [kafka] mjsax commented on a diff in pull request #12037: KAFKA-13785: [7/N][Emit final] emit final for sliding window

mjsax commented on code in PR #12037: URL: https://github.com/apache/kafka/pull/12037#discussion_r849980473 ## streams/src/main/java/org/apache/kafka/streams/kstream/internals/SlidingWindowedKStreamImpl.java: ## @@ -224,12 +227,20 @@ private StoreBuilder> materialize(final

[GitHub] [kafka] mjsax commented on a diff in pull request #12037: KAFKA-13785: [7/N][Emit final] emit final for sliding window

mjsax commented on code in PR #12037: URL: https://github.com/apache/kafka/pull/12037#discussion_r849980304 ## streams/src/main/java/org/apache/kafka/streams/kstream/internals/KStreamSlidingWindowAggregate.java: ## @@ -467,6 +516,72 @@ private boolean

[GitHub] [kafka] mjsax commented on a diff in pull request #12037: KAFKA-13785: [7/N][Emit final] emit final for sliding window

mjsax commented on code in PR #12037: URL: https://github.com/apache/kafka/pull/12037#discussion_r849979665 ## streams/src/main/java/org/apache/kafka/streams/kstream/internals/KStreamSlidingWindowAggregate.java: ## @@ -467,6 +516,72 @@ private boolean

[GitHub] [kafka] mjsax commented on a diff in pull request #12037: KAFKA-13785: [7/N][Emit final] emit final for sliding window

mjsax commented on code in PR #12037: URL: https://github.com/apache/kafka/pull/12037#discussion_r849979498 ## streams/src/main/java/org/apache/kafka/streams/kstream/internals/KStreamSlidingWindowAggregate.java: ## @@ -81,23 +100,54 @@ private class

[GitHub] [kafka] mjsax commented on a diff in pull request #12037: KAFKA-13785: [7/N][Emit final] emit final for sliding window

mjsax commented on code in PR #12037: URL: https://github.com/apache/kafka/pull/12037#discussion_r849978267 ## streams/src/main/java/org/apache/kafka/streams/kstream/internals/KStreamSlidingWindowAggregate.java: ## @@ -50,17 +59,27 @@ private final SlidingWindows windows;

[GitHub] [kafka] mjsax commented on a diff in pull request #12037: KAFKA-13785: [7/N][Emit final] emit final for sliding window

mjsax commented on code in PR #12037: URL: https://github.com/apache/kafka/pull/12037#discussion_r849978267 ## streams/src/main/java/org/apache/kafka/streams/kstream/internals/KStreamSlidingWindowAggregate.java: ## @@ -50,17 +59,27 @@ private final SlidingWindows windows;

[GitHub] [kafka] mjsax commented on a diff in pull request #12037: KAFKA-13785: [7/N][Emit final] emit final for sliding window

mjsax commented on code in PR #12037: URL: https://github.com/apache/kafka/pull/12037#discussion_r849975933 ## streams/src/main/java/org/apache/kafka/streams/kstream/internals/KStreamWindowAggregate.java: ## @@ -48,15 +51,25 @@ private final Windows windows; private

[GitHub] [kafka] mjsax commented on a diff in pull request #11945: KAFKA-13769: Explicitly route FK join results to correct partitions

mjsax commented on code in PR #11945: URL: https://github.com/apache/kafka/pull/11945#discussion_r849942073 ## streams/src/main/java/org/apache/kafka/streams/kstream/internals/foreignkeyjoin/SubscriptionResponseWrapper.java: ## @@ -21,22 +21,30 @@ import java.util.Arrays;

[jira] (KAFKA-13725) KIP-768 OAuth code mixes public and internal classes in same package

[ https://issues.apache.org/jira/browse/KAFKA-13725 ] Kirk True deleted comment on KAFKA-13725: --- was (Author: kirktrue): Pull request is not auto-linking. Here it is: [https://github.com/apache/kafka/pull/12039] > KIP-768 OAuth code mixes

[GitHub] [kafka] kirktrue commented on pull request #11886: KAFKA-13730: OAuth access token validation fails if it does not conta…

kirktrue commented on PR #11886: URL: https://github.com/apache/kafka/pull/11886#issuecomment-1098539351 Automated test failures appear to be unrelated to this change, FYI. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [kafka] kirktrue commented on pull request #11886: KAFKA-13730: OAuth access token validation fails if it does not conta…

kirktrue commented on PR #11886: URL: https://github.com/apache/kafka/pull/11886#issuecomment-1098536232 @fonaid & @dajac - it looks pretty clear to me. While OAuth may not require a `sub` claim, Kafka does need a unique identifier to act as the principal. We get it from `sub` by

[GitHub] [kafka] kirktrue commented on pull request #12039: KAFKA-13725: KIP-768 OAuth code mixes public and internal classes in same package

kirktrue commented on PR #12039: URL: https://github.com/apache/kafka/pull/12039#issuecomment-1098500796 @dajac - can you review or suggest who might? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[jira] [Updated] (KAFKA-13725) KIP-768 OAuth code mixes public and internal classes in same package

[ https://issues.apache.org/jira/browse/KAFKA-13725?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True updated KAFKA-13725: -- Fix Version/s: (was: 3.2.0) > KIP-768 OAuth code mixes public and internal classes in same

[jira] [Comment Edited] (KAFKA-13725) KIP-768 OAuth code mixes public and internal classes in same package

[ https://issues.apache.org/jira/browse/KAFKA-13725?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17521957#comment-17521957 ] Kirk True edited comment on KAFKA-13725 at 4/13/22 9:23 PM: Pull request is

[jira] [Commented] (KAFKA-13725) KIP-768 OAuth code mixes public and internal classes in same package

[ https://issues.apache.org/jira/browse/KAFKA-13725?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17521957#comment-17521957 ] Kirk True commented on KAFKA-13725: --- Patch is not auto-linking. Here it is:

[jira] [Updated] (KAFKA-13725) KIP-768 OAuth code mixes public and internal classes in same package

[ https://issues.apache.org/jira/browse/KAFKA-13725?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True updated KAFKA-13725: -- Component/s: clients security Fix Version/s: 3.2.0 3.1.2

[jira] [Updated] (KAFKA-13725) KIP-768 OAuth code mixes public and internal classes in same package

[ https://issues.apache.org/jira/browse/KAFKA-13725?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True updated KAFKA-13725: -- Description: The {{org.apache.kafka.common.security.oauthbearer.secured}} package from KIP-768

[jira] [Updated] (KAFKA-13725) KIP-768 OAuth code mixes public and internal classes in same package

[ https://issues.apache.org/jira/browse/KAFKA-13725?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True updated KAFKA-13725: -- Description: The {{org.apache.kafka.common.security.oauthbearer.secured}} package from KIP-768

[GitHub] [kafka] mumrah commented on a diff in pull request #12036: KAFKA-13823 Feature flag changes from KIP-778

mumrah commented on code in PR #12036: URL: https://github.com/apache/kafka/pull/12036#discussion_r849858837 ## clients/src/main/resources/common/message/UpdateFeaturesRequest.json: ## @@ -29,8 +29,12 @@ "about": "The name of the finalized feature to be updated."},

[GitHub] [kafka] cmccabe commented on a diff in pull request #12036: KAFKA-13823 Feature flag changes from KIP-778

cmccabe commented on code in PR #12036: URL: https://github.com/apache/kafka/pull/12036#discussion_r849853060 ## clients/src/main/java/org/apache/kafka/clients/admin/UpdateFeaturesOptions.java: ## @@ -26,4 +26,14 @@ */ @InterfaceStability.Evolving public class

[GitHub] [kafka] mumrah commented on a diff in pull request #12036: KAFKA-13823 Feature flag changes from KIP-778

mumrah commented on code in PR #12036: URL: https://github.com/apache/kafka/pull/12036#discussion_r849836506 ## core/src/main/scala/kafka/server/ControllerServer.scala: ## @@ -37,8 +37,8 @@ import org.apache.kafka.common.security.scram.internals.ScramMechanism import

[GitHub] [kafka] mumrah commented on a diff in pull request #12033: KAFKA-13807: Fix incrementalAlterConfig and refactor some things

mumrah commented on code in PR #12033: URL: https://github.com/apache/kafka/pull/12033#discussion_r849822171 ## metadata/src/main/java/org/apache/kafka/metadata/ControllerRequestContext.java: ## @@ -0,0 +1,60 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

[GitHub] [kafka] cmccabe commented on pull request #12036: KAFKA-13823 Feature flag changes from KIP-778

cmccabe commented on PR #12036: URL: https://github.com/apache/kafka/pull/12036#issuecomment-1098409271 I think you forgot to include the `QuorumFeatures` file. Do we have a test for sending a v0 `UpdateFeaturesRequest`, with and without `AllowDowngrade` set to true? Doesn't

[GitHub] [kafka] dajac commented on a diff in pull request #12029: KAFKA-13815: Avoid reinitialization for a replica that is being deleted

dajac commented on code in PR #12029: URL: https://github.com/apache/kafka/pull/12029#discussion_r849824338 ## core/src/test/scala/unit/kafka/server/ReplicaManagerTest.scala: ## @@ -2615,7 +2615,10 @@ class ReplicaManagerTest { @Test def

[GitHub] [kafka] cmccabe commented on a diff in pull request #12036: KAFKA-13823 Feature flag changes from KIP-778

cmccabe commented on code in PR #12036: URL: https://github.com/apache/kafka/pull/12036#discussion_r849823317 ## clients/src/main/resources/common/message/UpdateFeaturesRequest.json: ## @@ -29,8 +29,12 @@ "about": "The name of the finalized feature to be updated."},

[GitHub] [kafka] cmccabe closed pull request #11910: KAFKA-13743: Prevent topics with conflicting metrics names from being created in KRaft mode

cmccabe closed pull request #11910: KAFKA-13743: Prevent topics with conflicting metrics names from being created in KRaft mode URL: https://github.com/apache/kafka/pull/11910 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [kafka] cmccabe commented on pull request #11910: KAFKA-13743: Prevent topics with conflicting metrics names from being created in KRaft mode

cmccabe commented on PR #11910: URL: https://github.com/apache/kafka/pull/11910#issuecomment-1098381962 LGTM. I made a small fixup for compatibility and pushed. Thanks, @dengziming . -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[jira] [Commented] (KAFKA-8318) Session Window Aggregations generate an extra tombstone

[ https://issues.apache.org/jira/browse/KAFKA-8318?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17521866#comment-17521866 ] Matthias J. Sax commented on KAFKA-8318: It seem [~ipasynkov] does no work on this any longer.

[GitHub] [kafka] junrao commented on a diff in pull request #12029: KAFKA-13815: Avoid reinitialization for a replica that is being deleted

junrao commented on code in PR #12029: URL: https://github.com/apache/kafka/pull/12029#discussion_r849765867 ## core/src/test/scala/unit/kafka/server/ReplicaManagerTest.scala: ## @@ -2615,7 +2615,10 @@ class ReplicaManagerTest { @Test def

[jira] [Commented] (KAFKA-12495) Unbalanced connectors/tasks distribution will happen in Connect's incremental cooperative assignor

[ https://issues.apache.org/jira/browse/KAFKA-12495?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17521853#comment-17521853 ] Konstantine Karantasis commented on KAFKA-12495: Thanks for documenting the issue in

[GitHub] [kafka] kkonstantine commented on pull request #10367: KAFKA-12495: allow consecutive revoke in incremental cooperative assignor in connector

kkonstantine commented on PR #10367: URL: https://github.com/apache/kafka/pull/10367#issuecomment-1098324150 Thanks for working on this fix @showuon. Apologies for taking me so long to return here. My main concern is related to the proposed change to apply consecutive rebalances

[jira] [Resolved] (KAFKA-13651) Add audit logging to StandardAuthorizer

[ https://issues.apache.org/jira/browse/KAFKA-13651?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Colin McCabe resolved KAFKA-13651. -- Resolution: Fixed > Add audit logging to StandardAuthorizer >

[jira] [Updated] (KAFKA-13651) Add audit logging to StandardAuthorizer

[ https://issues.apache.org/jira/browse/KAFKA-13651?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Colin McCabe updated KAFKA-13651: - Summary: Add audit logging to StandardAuthorizer (was: StandardAuthorizer should implement all

[GitHub] [kafka] cmccabe merged pull request #12031: KAFKA-13651; Add audit logging to `StandardAuthorizer`

cmccabe merged PR #12031: URL: https://github.com/apache/kafka/pull/12031 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [kafka] cmccabe commented on a diff in pull request #12036: KAFKA-13823 Feature flag changes from KIP-778

cmccabe commented on code in PR #12036: URL: https://github.com/apache/kafka/pull/12036#discussion_r849729793 ## clients/src/main/java/org/apache/kafka/clients/admin/UpdateFeaturesOptions.java: ## @@ -26,4 +26,14 @@ */ @InterfaceStability.Evolving public class

[jira] [Commented] (KAFKA-10733) Enforce exception thrown for KafkaProducer txn APIs

[ https://issues.apache.org/jira/browse/KAFKA-10733?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17521834#comment-17521834 ] Gilles Philippart commented on KAFKA-10733: --- Sorry to chase this again, but can we get a

[GitHub] [kafka] vvcephei commented on a diff in pull request #11993: KAFKA-13654: Extend KStream process with new Processor API

vvcephei commented on code in PR #11993: URL: https://github.com/apache/kafka/pull/11993#discussion_r849705530 ## streams/test-utils/src/main/java/org/apache/kafka/streams/processor/api/MockProcessorContext.java: ## @@ -336,6 +344,14 @@ public void setRecordMetadata(final

[GitHub] [kafka] vvcephei commented on a diff in pull request #11993: KAFKA-13654: Extend KStream process with new Processor API

vvcephei commented on code in PR #11993: URL: https://github.com/apache/kafka/pull/11993#discussion_r849702954 ## streams/src/main/java/org/apache/kafka/streams/kstream/internals/graph/ProcessorParameters.java: ## @@ -37,30 +43,67 @@ @SuppressWarnings("deprecation") // Old

[GitHub] [kafka] vvcephei commented on a diff in pull request #11993: KAFKA-13654: Extend KStream process with new Processor API

vvcephei commented on code in PR #11993: URL: https://github.com/apache/kafka/pull/11993#discussion_r849699686 ## streams/src/main/java/org/apache/kafka/streams/kstream/internals/KStreamImpl.java: ## @@ -1501,9 +1508,60 @@ public void process(final

[GitHub] [kafka] junrao commented on a diff in pull request #12005: KAFKA-13803: Refactor Leader API Access

junrao commented on code in PR #12005: URL: https://github.com/apache/kafka/pull/12005#discussion_r849673799 ## core/src/main/scala/kafka/server/RemoteLeaderEndPoint.scala: ## @@ -0,0 +1,165 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + *

[jira] [Assigned] (KAFKA-10888) Sticky partition leads to uneven product msg, resulting in abnormal delays in some partitions

[ https://issues.apache.org/jira/browse/KAFKA-10888?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Artem Livshits reassigned KAFKA-10888: -- Assignee: Artem Livshits (was: Luke Chen) > Sticky partition leads to uneven

[GitHub] [kafka] jsancio merged pull request #12040: MINOR: Verify stopReplica if broker epoch not stale

jsancio merged PR #12040: URL: https://github.com/apache/kafka/pull/12040 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [kafka] mumrah commented on a diff in pull request #12036: KAFKA-13823 Feature flag changes from KIP-778

mumrah commented on code in PR #12036: URL: https://github.com/apache/kafka/pull/12036#discussion_r849653835 ## core/src/main/scala/kafka/server/ControllerServer.scala: ## @@ -37,8 +37,8 @@ import org.apache.kafka.common.security.scram.internals.ScramMechanism import

[GitHub] [kafka] mimaison opened a new pull request, #12046: KAFKA-10360: Allow disabling JMX Reporter (KIP-830)

mimaison opened a new pull request, #12046: URL: https://github.com/apache/kafka/pull/12046 This implements KIP-830: https://cwiki.apache.org/confluence/display/KAFKA/KIP-830%3A+Allow+disabling+JMX+Reporter It adds a new configuration jmx.reporter.enable that can be set to false to

[jira] [Commented] (KAFKA-12319) Flaky test ConnectionQuotasTest.testListenerConnectionRateLimitWhenActualRateAboveLimit()

[ https://issues.apache.org/jira/browse/KAFKA-12319?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17521740#comment-17521740 ] Divij Vaidya commented on KAFKA-12319: -- Hey [~jolshan] [~mjsax] and [~josep.prat] . I have fixed

[jira] [Assigned] (KAFKA-12319) Flaky test ConnectionQuotasTest.testListenerConnectionRateLimitWhenActualRateAboveLimit()

[ https://issues.apache.org/jira/browse/KAFKA-12319?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Divij Vaidya reassigned KAFKA-12319: Assignee: Divij Vaidya > Flaky test >

[GitHub] [kafka] divijvaidya closed pull request #12034: (draft) Kafka-12319: Improve rate calculation for first sample window

divijvaidya closed pull request #12034: (draft) Kafka-12319: Improve rate calculation for first sample window URL: https://github.com/apache/kafka/pull/12034 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [kafka] divijvaidya commented on pull request #12034: (draft) Kafka-12319: Improve rate calculation for first sample window

divijvaidya commented on PR #12034: URL: https://github.com/apache/kafka/pull/12034#issuecomment-1098162261 Discarding this since I found a bug in current approach. A new PR has been started at https://github.com/apache/kafka/pull/12045 -- This is an automated message from the Apache Git

[GitHub] [kafka] divijvaidya opened a new pull request, #12045: KAFKA-12319: Change calculation of window size used to calculate `Rate`

divijvaidya opened a new pull request, #12045: URL: https://github.com/apache/kafka/pull/12045 ## Why does the test fail? `ConnectionQuotasTest.testListenerConnectionRateLimitWhenActualRateAboveLimit()` sends 600 connection creation requests at a rate of 40/s with a

[GitHub] [kafka] mumrah commented on a diff in pull request #12036: KAFKA-13823 Feature flag changes from KIP-778

mumrah commented on code in PR #12036: URL: https://github.com/apache/kafka/pull/12036#discussion_r849579452 ## clients/src/main/java/org/apache/kafka/clients/admin/UpdateFeaturesOptions.java: ## @@ -26,4 +26,14 @@ */ @InterfaceStability.Evolving public class

[GitHub] [kafka] ableegoldman commented on pull request #12044: KAFKA-12738: implement exponential backoff for tasks

ableegoldman commented on PR #12044: URL: https://github.com/apache/kafka/pull/12044#issuecomment-1098086886 cc @wcarlson5 Note to reviewers -- I'm still working on the unit/integration tests so stay tune, but I would appreciate starting the review process for the non-testing code

[GitHub] [kafka] ableegoldman opened a new pull request, #12044: KAFKA-12738: implement exponential backoff for tasks

ableegoldman opened a new pull request, #12044: URL: https://github.com/apache/kafka/pull/12044 This PR further improves the error handling for named topologies by extending it to include exponential backoff for individual task errors, instead of a constant-time 5s backoff. The next

[jira] [Comment Edited] (KAFKA-13272) KStream offset stuck after brokers outage

[ https://issues.apache.org/jira/browse/KAFKA-13272?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17521653#comment-17521653 ] Levani Kokhreidze edited comment on KAFKA-13272 at 4/13/22 12:30 PM: -

[jira] [Commented] (KAFKA-13272) KStream offset stuck after brokers outage

[ https://issues.apache.org/jira/browse/KAFKA-13272?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17521653#comment-17521653 ] Levani Kokhreidze commented on KAFKA-13272: --- Thanks [~nicktelford]  I was not aware that such

[jira] [Resolved] (KAFKA-13542) Utilize the new Consumer#enforceRebalance(reason) API in Streams

[ https://issues.apache.org/jira/browse/KAFKA-13542?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Jacot resolved KAFKA-13542. - Fix Version/s: 3.2.0 (was: 3.3.0) Resolution: Fixed > Utilize the

[jira] [Resolved] (KAFKA-13828) Ensure reasons sent by the consumer are small

[ https://issues.apache.org/jira/browse/KAFKA-13828?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Jacot resolved KAFKA-13828. - Fix Version/s: 3.2.0 Resolution: Fixed > Ensure reasons sent by the consumer are small >

[GitHub] [kafka] dajac merged pull request #12018: KAFKA-13542: add rebalance reason in Kafka Streams

dajac merged PR #12018: URL: https://github.com/apache/kafka/pull/12018 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [kafka] dajac merged pull request #12043: KAFKA-13828; Ensure reasons sent by the consumer are small

dajac merged PR #12043: URL: https://github.com/apache/kafka/pull/12043 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [kafka] cadonna commented on pull request #12018: KAFKA-13542: add rebalance reason in Kafka Streams

cadonna commented on PR #12018: URL: https://github.com/apache/kafka/pull/12018#issuecomment-1097951697 @dajac Yes, please go ahead! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [kafka] dajac commented on pull request #12043: KAFKA-13828; Ensure reasons sent by the consumer are small

dajac commented on PR #12043: URL: https://github.com/apache/kafka/pull/12043#issuecomment-1097950797 The last CI run had two failed tests: ``` Build / JDK 17 and Scala 2.13 / [1] Type=Raft, Name=testElectionResultOutput, Security=PLAINTEXT – kafka.admin.LeaderElectionCommandTest

[GitHub] [kafka] dajac commented on pull request #12018: KAFKA-13542: add rebalance reason in Kafka Streams

dajac commented on PR #12018: URL: https://github.com/apache/kafka/pull/12018#issuecomment-1097950114 @cadonna Are you OK with cherry-picking it to 3.2? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [kafka] dajac commented on pull request #12018: KAFKA-13542: add rebalance reason in Kafka Streams

dajac commented on PR #12018: URL: https://github.com/apache/kafka/pull/12018#issuecomment-1097949484 The last run had two failed tests: ``` Build / JDK 17 and Scala 2.13 / testDynamicListenerConnectionCreationRateQuota() – kafka.network.DynamicConnectionQuotaTest 42s Build /

[GitHub] [kafka] mimaison merged pull request #11914: MINOR: Correct Connect docs on connector/task states

mimaison merged PR #11914: URL: https://github.com/apache/kafka/pull/11914 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [kafka] dengziming commented on a diff in pull request #12036: KAFKA-13823 Feature flag changes from KIP-778

dengziming commented on code in PR #12036: URL: https://github.com/apache/kafka/pull/12036#discussion_r849326802 ## core/src/main/scala/kafka/server/BrokerServer.scala: ## @@ -332,10 +335,16 @@ class BrokerServer( setPort(if (ep.port == 0)

[GitHub] [kafka] showuon commented on pull request #12042: KAFKA-13810 Document behavior of KafkaProducer.flush() w.r.t callbacks

showuon commented on PR #12042: URL: https://github.com/apache/kafka/pull/12042#issuecomment-1097845533 @karstenspang , thanks for the PR. Don't worry about the failed tests. You only change the javadoc, which won't affect the tests. I'll merge it tomorrow if there are no other comments

[jira] [Commented] (KAFKA-10360) Disabling JmxReporter registration

[ https://issues.apache.org/jira/browse/KAFKA-10360?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17521595#comment-17521595 ] Mickael Maison commented on KAFKA-10360: I opened KIP-830 to address this:

[GitHub] [kafka] karstenspang commented on pull request #12042: KAFKA-13810 Document behavior of KafkaProducer.flush() w.r.t callbacks

karstenspang commented on PR #12042: URL: https://github.com/apache/kafka/pull/12042#issuecomment-1097808260 I looked over the test results. All tests pass using JDK 11, but one test fail using JDK 8, and another using JDK 17. Both are due to requests timing out. I suspect these are

[GitHub] [kafka] karuturi commented on pull request #11955: KAFKA-12380 Executor in Connect's Worker is not shut down when the worker is

karuturi commented on PR #11955: URL: https://github.com/apache/kafka/pull/11955#issuecomment-1097731420 @showuon Can we merge this please? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[jira] [Updated] (KAFKA-10405) Flaky Test org.apache.kafka.streams.integration.PurgeRepartitionTopicIntegrationTest.shouldRestoreState

[ https://issues.apache.org/jira/browse/KAFKA-10405?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bruno Cadonna updated KAFKA-10405: -- Fix Version/s: 3.2.0 > Flaky Test >

[GitHub] [kafka] dajac commented on pull request #12043: KAFKA-13828; Ensure reasons sent by the consumer are small

dajac commented on PR #12043: URL: https://github.com/apache/kafka/pull/12043#issuecomment-1097683099 cc @cadonna I think that we should get this on in 3.2. The patch is trivial. Do you mind reviewing it? -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [kafka] dajac opened a new pull request, #12043: KAFKA-13828; Ensure reasons sent by the consumer are small

dajac opened a new pull request, #12043: URL: https://github.com/apache/kafka/pull/12043 This PR reworks the reasons used in the ConsumerCoordinator to ensure that they remain reasonably short. The patch is trivial. ### Committer Checklist (excluded from commit message) - [ ]

  1   2   >