[GitHub] [kafka] eyys opened a new pull request, #12083: A function is optimized to maintain a starting index for each node

2022-04-21 Thread GitBox
eyys opened a new pull request, #12083: URL: https://github.com/apache/kafka/pull/12083 https://issues.apache.org/jira/browse/KAFKA-13834 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[jira] [Commented] (KAFKA-13845) Add support for reading KRaft snapshots in kafka-dump-log

2022-04-21 Thread dengziming (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13845?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17526187#comment-17526187 ] dengziming commented on KAFKA-13845: One difference we should note is that metadata snapshot

[GitHub] [kafka] RivenSun2 commented on pull request #12010: KAFKA-13793: Add validators for configs that lack validators

2022-04-21 Thread GitBox
RivenSun2 commented on PR #12010: URL: https://github.com/apache/kafka/pull/12010#issuecomment-1105974761 Hi @C0urante @clolov if you have time, please help to review it again. Thanks a lot. -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [kafka] RivenSun2 commented on a diff in pull request #12010: KAFKA-13793: Add validators for configs that lack validators

2022-04-21 Thread GitBox
RivenSun2 commented on code in PR #12010: URL: https://github.com/apache/kafka/pull/12010#discussion_r855742356 ## core/src/main/scala/kafka/admin/BrokerApiVersionsCommand.scala: ## @@ -231,6 +232,7 @@ object BrokerApiVersionsCommand {

[GitHub] [kafka] dengziming commented on pull request #11951: KAFKA-13836: Improve KRaft broker heartbeat logic

2022-04-21 Thread GitBox
dengziming commented on PR #11951: URL: https://github.com/apache/kafka/pull/11951#issuecomment-1105959964 > I don't think we need to add the custom logic to look for the broker's own registration record. That should be covered by the check done on the controller side, right? Yes,

[GitHub] [kafka] clolov commented on a diff in pull request #12010: KAFKA-13793: Add validators for configs that lack validators

2022-04-21 Thread GitBox
clolov commented on code in PR #12010: URL: https://github.com/apache/kafka/pull/12010#discussion_r855728894 ## core/src/main/scala/kafka/admin/BrokerApiVersionsCommand.scala: ## @@ -231,6 +232,7 @@ object BrokerApiVersionsCommand {

[GitHub] [kafka] clolov commented on a diff in pull request #12010: KAFKA-13793: Add validators for configs that lack validators

2022-04-21 Thread GitBox
clolov commented on code in PR #12010: URL: https://github.com/apache/kafka/pull/12010#discussion_r855727263 ## clients/src/main/java/org/apache/kafka/clients/producer/ProducerConfig.java: ## @@ -542,8 +544,16 @@ static Map appendSerializerToConfig(Map configs, Map

[GitHub] [kafka] RivenSun2 commented on a diff in pull request #12010: KAFKA-13793: Add validators for configs that lack validators

2022-04-21 Thread GitBox
RivenSun2 commented on code in PR #12010: URL: https://github.com/apache/kafka/pull/12010#discussion_r855725442 ## core/src/main/scala/kafka/server/KafkaConfig.scala: ## @@ -1139,7 +1139,7 @@ object KafkaConfig { .define(MetadataMaxRetentionMillisProp, LONG,

[GitHub] [kafka] RivenSun2 commented on a diff in pull request #12010: KAFKA-13793: Add validators for configs that lack validators

2022-04-21 Thread GitBox
RivenSun2 commented on code in PR #12010: URL: https://github.com/apache/kafka/pull/12010#discussion_r855724304 ## core/src/main/scala/kafka/admin/BrokerApiVersionsCommand.scala: ## @@ -231,6 +232,7 @@ object BrokerApiVersionsCommand {

[GitHub] [kafka] RivenSun2 commented on a diff in pull request #12010: KAFKA-13793: Add validators for configs that lack validators

2022-04-21 Thread GitBox
RivenSun2 commented on code in PR #12010: URL: https://github.com/apache/kafka/pull/12010#discussion_r855722647 ## clients/src/main/java/org/apache/kafka/clients/producer/ProducerConfig.java: ## @@ -542,8 +544,16 @@ static Map appendSerializerToConfig(Map configs, Map

[GitHub] [kafka] clolov commented on a diff in pull request #12010: KAFKA-13793: Add validators for configs that lack validators

2022-04-21 Thread GitBox
clolov commented on code in PR #12010: URL: https://github.com/apache/kafka/pull/12010#discussion_r855722125 ## core/src/main/scala/kafka/admin/BrokerApiVersionsCommand.scala: ## @@ -231,6 +232,7 @@ object BrokerApiVersionsCommand {

[GitHub] [kafka] RivenSun2 commented on a diff in pull request #12010: KAFKA-13793: Add validators for configs that lack validators

2022-04-21 Thread GitBox
RivenSun2 commented on code in PR #12010: URL: https://github.com/apache/kafka/pull/12010#discussion_r855721945 ## clients/src/main/java/org/apache/kafka/clients/consumer/ConsumerConfig.java: ## @@ -604,8 +609,16 @@ protected static Map appendDeserializerToConfig(Map

[GitHub] [kafka] RivenSun2 commented on a diff in pull request #12010: KAFKA-13793: Add validators for configs that lack validators

2022-04-21 Thread GitBox
RivenSun2 commented on code in PR #12010: URL: https://github.com/apache/kafka/pull/12010#discussion_r855721078 ## clients/src/main/java/org/apache/kafka/clients/producer/ProducerConfig.java: ## @@ -542,8 +544,16 @@ static Map appendSerializerToConfig(Map configs, Map

[GitHub] [kafka] clolov commented on a diff in pull request #12010: KAFKA-13793: Add validators for configs that lack validators

2022-04-21 Thread GitBox
clolov commented on code in PR #12010: URL: https://github.com/apache/kafka/pull/12010#discussion_r855718929 ## core/src/main/scala/kafka/server/KafkaConfig.scala: ## @@ -1139,7 +1139,7 @@ object KafkaConfig { .define(MetadataMaxRetentionMillisProp, LONG,

[GitHub] [kafka] clolov commented on a diff in pull request #12010: KAFKA-13793: Add validators for configs that lack validators

2022-04-21 Thread GitBox
clolov commented on code in PR #12010: URL: https://github.com/apache/kafka/pull/12010#discussion_r855717387 ## clients/src/main/java/org/apache/kafka/clients/producer/ProducerConfig.java: ## @@ -542,8 +544,16 @@ static Map appendSerializerToConfig(Map configs, Map

[GitHub] [kafka] clolov commented on a diff in pull request #12010: KAFKA-13793: Add validators for configs that lack validators

2022-04-21 Thread GitBox
clolov commented on code in PR #12010: URL: https://github.com/apache/kafka/pull/12010#discussion_r855715892 ## clients/src/main/java/org/apache/kafka/clients/producer/ProducerConfig.java: ## @@ -542,8 +544,16 @@ static Map appendSerializerToConfig(Map configs, Map

[jira] [Created] (KAFKA-13847) Connectivity to kafka broker

2022-04-21 Thread nick (Jira)
nick created KAFKA-13847: Summary: Connectivity to kafka broker Key: KAFKA-13847 URL: https://issues.apache.org/jira/browse/KAFKA-13847 Project: Kafka Issue Type: Bug Reporter: nick My

[GitHub] [kafka] C0urante commented on a diff in pull request #12010: KAFKA-13793: Add validators for configs that lack validators

2022-04-21 Thread GitBox
C0urante commented on code in PR #12010: URL: https://github.com/apache/kafka/pull/12010#discussion_r855702727 ## clients/src/main/java/org/apache/kafka/clients/consumer/ConsumerConfig.java: ## @@ -604,8 +609,16 @@ protected static Map appendDeserializerToConfig(Map newConfigs

[GitHub] [kafka] RivenSun2 commented on pull request #12010: KAFKA-13793: Add validators for configs that lack validators

2022-04-21 Thread GitBox
RivenSun2 commented on PR #12010: URL: https://github.com/apache/kafka/pull/12010#issuecomment-1105912505 Hi @showuon @guozhangwang Could you help to review this PR? Thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [kafka] RivenSun2 commented on pull request #12077: MINOR: Avoid using strings directly for the auto.offset.reset configuration of ConsumerConfig

2022-04-21 Thread GitBox
RivenSun2 commented on PR #12077: URL: https://github.com/apache/kafka/pull/12077#issuecomment-1105912218 Hi @showuon @guozhangwang Could you help to review this PR? Thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [kafka] hachikuji commented on a diff in pull request #12071: MINOR: Rename `ZkVersion` to `PartitionEpoch`

2022-04-21 Thread GitBox
hachikuji commented on code in PR #12071: URL: https://github.com/apache/kafka/pull/12071#discussion_r855689378 ## core/src/test/scala/unit/kafka/zk/KafkaZkClientTest.scala: ## @@ -922,10 +922,10 @@ class KafkaZkClientTest extends QuorumTestHarness { private def

[GitHub] [kafka] hachikuji opened a new pull request, #12082: MINOR: Create case class to encapsulate fetch parameters and simplify handling

2022-04-21 Thread GitBox
hachikuji opened a new pull request, #12082: URL: https://github.com/apache/kafka/pull/12082 This patch adds a new case class `FetchParams` which encapsulates the parameters of the fetch request. It then uses this class in `DelayedFetch` directly instead of `FetchMetadata`. The intent is

[GitHub] [kafka] cmccabe merged pull request #12075: KAFKA-13841: Fix a case where we were unable to place on fenced brokers in KRaft mode

2022-04-21 Thread GitBox
cmccabe merged PR #12075: URL: https://github.com/apache/kafka/pull/12075 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [kafka] cmccabe commented on pull request #12075: KAFKA-13841: Fix a case where we were unable to place on fenced brokers in KRaft mode

2022-04-21 Thread GitBox
cmccabe commented on PR #12075: URL: https://github.com/apache/kafka/pull/12075#issuecomment-1105800086 > I sort of wonder if there might be other cases lurking where BrokerHeartbeatManager view of the brokers gets out of sync of the broker registrations in ClusterControlManager?

[jira] [Created] (KAFKA-13846) Add an overloaded metricOrElseCreate function in Metrics

2022-04-21 Thread Guozhang Wang (Jira)
Guozhang Wang created KAFKA-13846: - Summary: Add an overloaded metricOrElseCreate function in Metrics Key: KAFKA-13846 URL: https://issues.apache.org/jira/browse/KAFKA-13846 Project: Kafka

[jira] [Comment Edited] (KAFKA-12909) Allow users to opt-into spurious left/outer stream-stream join improvement

2022-04-21 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12909?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17522502#comment-17522502 ] Matthias J. Sax edited comment on KAFKA-12909 at 4/21/22 9:13 PM: --

[jira] [Commented] (KAFKA-12909) Allow users to opt-into spurious left/outer stream-stream join improvement

2022-04-21 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12909?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17526086#comment-17526086 ] Matthias J. Sax commented on KAFKA-12909: - Ah sorry. That was my bad... Fixed. > Allow users to

[GitHub] [kafka] cmccabe commented on pull request #11951: KAFKA-13836: Improve KRaft broker heartbeat logic

2022-04-21 Thread GitBox
cmccabe commented on PR #11951: URL: https://github.com/apache/kafka/pull/11951#issuecomment-1105765317 Thanks for the PR, @dengziming . I don't think we need to add the custom logic to look for the broker's own registration record. That should be covered by the check done on the

[GitHub] [kafka] cmccabe commented on pull request #12075: KAFKA-13841: Fix a case where we were unable to place on fenced brokers in KRaft mode

2022-04-21 Thread GitBox
cmccabe commented on PR #12075: URL: https://github.com/apache/kafka/pull/12075#issuecomment-1105753323 @dengziming : I think the most common scenario where this might happen is after the cluster first starts up, and we have some existing broker registrations. In that case, currently those

[jira] [Updated] (KAFKA-13838) Improve the poll method of ConsumerNetworkClient

2022-04-21 Thread Guozhang Wang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13838?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guozhang Wang updated KAFKA-13838: -- Labels: new-consumer-threading-should-fix (was: ) > Improve the poll method of

[jira] [Commented] (KAFKA-13838) Improve the poll method of ConsumerNetworkClient

2022-04-21 Thread Guozhang Wang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13838?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17526071#comment-17526071 ] Guozhang Wang commented on KAFKA-13838: --- Also bringing to [~kirktrue]'s radar. > Improve the poll

[jira] [Updated] (KAFKA-13845) Add support for reading KRaft snapshots in kafka-dump-log

2022-04-21 Thread Jose Armando Garcia Sancio (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13845?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jose Armando Garcia Sancio updated KAFKA-13845: --- Parent: KAFKA-10310 Issue Type: Sub-task (was: Improvement)

[jira] [Updated] (KAFKA-13845) Add support for reading KRaft snapshots in kafka-dump-log

2022-04-21 Thread David Arthur (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13845?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Arthur updated KAFKA-13845: - Labels: kip-500 (was: ) > Add support for reading KRaft snapshots in kafka-dump-log >

[jira] [Updated] (KAFKA-13845) Add support for reading KRaft snapshots in kafka-dump-log

2022-04-21 Thread David Arthur (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13845?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Arthur updated KAFKA-13845: - Priority: Minor (was: Major) > Add support for reading KRaft snapshots in kafka-dump-log >

[jira] [Created] (KAFKA-13845) Add support for reading KRaft snapshots in kafka-dump-log

2022-04-21 Thread David Arthur (Jira)
David Arthur created KAFKA-13845: Summary: Add support for reading KRaft snapshots in kafka-dump-log Key: KAFKA-13845 URL: https://issues.apache.org/jira/browse/KAFKA-13845 Project: Kafka

[GitHub] [kafka] guozhangwang merged pull request #11881: MINOR: revert back to 60s session timeout for static membership test

2022-04-21 Thread GitBox
guozhangwang merged PR #11881: URL: https://github.com/apache/kafka/pull/11881 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [kafka] guozhangwang commented on pull request #11881: MINOR: revert back to 60s session timeout for static membership test

2022-04-21 Thread GitBox
guozhangwang commented on PR #11881: URL: https://github.com/apache/kafka/pull/11881#issuecomment-1105634442 @showuon thanks for the PR. LGTM. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [kafka] dajac commented on pull request #12071: MINOR: Rename `ZkVersion` to `PartitionEpoch`

2022-04-21 Thread GitBox
dajac commented on PR #12071: URL: https://github.com/apache/kafka/pull/12071#issuecomment-1105624346 Thanks @hachikuji. I have addressed your comments. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[jira] [Comment Edited] (KAFKA-13840) KafkaConsumer is unable to recover connection to group coordinator after commitOffsetsAsync exception

2022-04-21 Thread Kyle R Stehbens (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13840?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17525919#comment-17525919 ] Kyle R Stehbens edited comment on KAFKA-13840 at 4/21/22 6:07 PM: --

[jira] [Commented] (KAFKA-13840) KafkaConsumer is unable to recover connection to group coordinator after commitOffsetsAsync exception

2022-04-21 Thread Kyle R Stehbens (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13840?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17525919#comment-17525919 ] Kyle R Stehbens commented on KAFKA-13840: - These are some of the (redacted) logs from when the

[GitHub] [kafka] dajac commented on a diff in pull request #12071: MINOR: Rename `ZkVersion` to `PartitionEpoch`

2022-04-21 Thread GitBox
dajac commented on code in PR #12071: URL: https://github.com/apache/kafka/pull/12071#discussion_r855453938 ## core/src/main/scala/kafka/cluster/Partition.scala: ## @@ -251,8 +251,9 @@ class Partition(val topicPartition: TopicPartition, // lock to prevent the follower

[jira] [Created] (KAFKA-13844) Pull Partition's volatile fields into a consolidate `PartitionState`

2022-04-21 Thread David Jacot (Jira)
David Jacot created KAFKA-13844: --- Summary: Pull Partition's volatile fields into a consolidate `PartitionState` Key: KAFKA-13844 URL: https://issues.apache.org/jira/browse/KAFKA-13844 Project: Kafka

[GitHub] [kafka] hachikuji commented on a diff in pull request #12071: MINOR: Rename `ZkVersion` to `PartitionEpoch`

2022-04-21 Thread GitBox
hachikuji commented on code in PR #12071: URL: https://github.com/apache/kafka/pull/12071#discussion_r855451915 ## clients/src/main/resources/common/message/LeaderAndIsrRequest.json: ## @@ -78,8 +78,8 @@ "about": "The leader epoch." }, { "name": "Isr", "type":

[GitHub] [kafka] hachikuji commented on a diff in pull request #12071: MINOR: Rename `ZkVersion` to `PartitionEpoch`

2022-04-21 Thread GitBox
hachikuji commented on code in PR #12071: URL: https://github.com/apache/kafka/pull/12071#discussion_r855451915 ## clients/src/main/resources/common/message/LeaderAndIsrRequest.json: ## @@ -78,8 +78,8 @@ "about": "The leader epoch." }, { "name": "Isr", "type":

[GitHub] [kafka] hachikuji commented on a diff in pull request #12071: MINOR: Rename `ZkVersion` to `PartitionEpoch`

2022-04-21 Thread GitBox
hachikuji commented on code in PR #12071: URL: https://github.com/apache/kafka/pull/12071#discussion_r855450737 ## core/src/main/scala/kafka/cluster/Partition.scala: ## @@ -251,8 +251,9 @@ class Partition(val topicPartition: TopicPartition, // lock to prevent the follower

[GitHub] [kafka] dajac commented on a diff in pull request #12071: MINOR: Rename `ZkVersion` to `PartitionEpoch`

2022-04-21 Thread GitBox
dajac commented on code in PR #12071: URL: https://github.com/apache/kafka/pull/12071#discussion_r855444201 ## clients/src/main/resources/common/message/LeaderAndIsrRequest.json: ## @@ -78,8 +78,8 @@ "about": "The leader epoch." }, { "name": "Isr", "type":

[GitHub] [kafka] dajac commented on a diff in pull request #12071: MINOR: Rename `ZkVersion` to `PartitionEpoch`

2022-04-21 Thread GitBox
dajac commented on code in PR #12071: URL: https://github.com/apache/kafka/pull/12071#discussion_r855443278 ## core/src/main/scala/kafka/cluster/Partition.scala: ## @@ -251,8 +251,9 @@ class Partition(val topicPartition: TopicPartition, // lock to prevent the follower

[GitHub] [kafka] dajac commented on a diff in pull request #12071: MINOR: Rename `ZkVersion` to `PartitionEpoch`

2022-04-21 Thread GitBox
dajac commented on code in PR #12071: URL: https://github.com/apache/kafka/pull/12071#discussion_r855440057 ## clients/src/main/resources/common/message/LeaderAndIsrRequest.json: ## @@ -78,8 +78,8 @@ "about": "The leader epoch." }, { "name": "Isr", "type":

[GitHub] [kafka] ijuma commented on pull request #12006: KAFKA-13794: Follow up to fix comparator

2022-04-21 Thread GitBox
ijuma commented on PR #12006: URL: https://github.com/apache/kafka/pull/12006#issuecomment-1105486088 @tombentley I had a chat with @hachikuji about this and it seems that the behavior we want is slightly differently. I'll see if I can submit a PR today for discussion. -- This is an

[GitHub] [kafka] hachikuji commented on a diff in pull request #12071: MINOR: Rename `ZkVersion` to `PartitionEpoch`

2022-04-21 Thread GitBox
hachikuji commented on code in PR #12071: URL: https://github.com/apache/kafka/pull/12071#discussion_r855395294 ## clients/src/main/resources/common/message/LeaderAndIsrRequest.json: ## @@ -78,8 +78,8 @@ "about": "The leader epoch." }, { "name": "Isr", "type":

[GitHub] [kafka] hachikuji commented on a diff in pull request #12071: MINOR: Rename `ZkVersion` to `PartitionEpoch`

2022-04-21 Thread GitBox
hachikuji commented on code in PR #12071: URL: https://github.com/apache/kafka/pull/12071#discussion_r855411055 ## core/src/main/scala/kafka/cluster/Partition.scala: ## @@ -251,8 +251,9 @@ class Partition(val topicPartition: TopicPartition, // lock to prevent the follower

[GitHub] [kafka] dhruvp-8 commented on pull request #7898: KAFKA-9366: Change log4j dependency into log4j2

2022-04-21 Thread GitBox
dhruvp-8 commented on PR #7898: URL: https://github.com/apache/kafka/pull/7898#issuecomment-1105464108 @dongjinleekr Thanks for working on this PR. Is there a timeline on when will this be merged? As per this doc https://cwiki.apache.org/confluence/display/KAFKA/Release+Plan+3.2.0 is it

[GitHub] [kafka] hachikuji commented on pull request #12071: MINOR: Rename `ZkVersion` to `PartitionEpoch`

2022-04-21 Thread GitBox
hachikuji commented on PR #12071: URL: https://github.com/apache/kafka/pull/12071#issuecomment-1105463549 cc @jsancio -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[jira] [Comment Edited] (KAFKA-13840) KafkaConsumer is unable to recover connection to group coordinator after commitOffsetsAsync exception

2022-04-21 Thread Kyle R Stehbens (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13840?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17525842#comment-17525842 ] Kyle R Stehbens edited comment on KAFKA-13840 at 4/21/22 4:48 PM: --

[jira] [Comment Edited] (KAFKA-13840) KafkaConsumer is unable to recover connection to group coordinator after commitOffsetsAsync exception

2022-04-21 Thread Kyle R Stehbens (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13840?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17525842#comment-17525842 ] Kyle R Stehbens edited comment on KAFKA-13840 at 4/21/22 4:43 PM: --

[jira] [Comment Edited] (KAFKA-13840) KafkaConsumer is unable to recover connection to group coordinator after commitOffsetsAsync exception

2022-04-21 Thread Kyle R Stehbens (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13840?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17525842#comment-17525842 ] Kyle R Stehbens edited comment on KAFKA-13840 at 4/21/22 4:42 PM: --

[jira] [Commented] (KAFKA-13840) KafkaConsumer is unable to recover connection to group coordinator after commitOffsetsAsync exception

2022-04-21 Thread Kyle R Stehbens (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13840?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17525842#comment-17525842 ] Kyle R Stehbens commented on KAFKA-13840: - Thanks [~showuon] ! In the particular case I was

[GitHub] [kafka] fonaid commented on pull request #11886: KAFKA-13730: OAuth access token validation fails if it does not conta…

2022-04-21 Thread GitBox
fonaid commented on PR #11886: URL: https://github.com/apache/kafka/pull/11886#issuecomment-1105434164 Thank you @kirktrue for the feedback! Can you (or @dajac) please elaborate on the next steps to get this merged? -- This is an automated message from the Apache Git Service. To respond

[GitHub] [kafka] jsancio merged pull request #12073: MINOR; Fix partition change record noop check

2022-04-21 Thread GitBox
jsancio merged PR #12073: URL: https://github.com/apache/kafka/pull/12073 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [kafka] mimaison merged pull request #12003: MINOR: Improve Gradle Caching and Fix Deprecations

2022-04-21 Thread GitBox
mimaison merged PR #12003: URL: https://github.com/apache/kafka/pull/12003 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [kafka] mimaison commented on a diff in pull request #12003: MINOR: Improve Gradle Caching and Fix Deprecations

2022-04-21 Thread GitBox
mimaison commented on code in PR #12003: URL: https://github.com/apache/kafka/pull/12003#discussion_r855287675 ## build.gradle: ## @@ -1216,12 +1237,16 @@ project(':clients') { testRuntimeOnly libs.jacksonJDK8Datatypes testImplementation libs.jose4j

[GitHub] [kafka] mimaison commented on pull request #11929: MINOR: s390x Stage

2022-04-21 Thread GitBox
mimaison commented on PR #11929: URL: https://github.com/apache/kafka/pull/11929#issuecomment-1105274677 @Nayana-ibm There is no ETA. We need the community to agree on how to manage hardware platforms. See the discussion thread:

[jira] [Commented] (KAFKA-12909) Allow users to opt-into spurious left/outer stream-stream join improvement

2022-04-21 Thread Patrik Kleindl (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12909?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17525714#comment-17525714 ] Patrik Kleindl commented on KAFKA-12909: Your example actually seems wrong to me, if a

[GitHub] [kafka] Nayana-ibm commented on pull request #11929: MINOR: s390x Stage

2022-04-21 Thread GitBox
Nayana-ibm commented on PR #11929: URL: https://github.com/apache/kafka/pull/11929#issuecomment-1105193822 @mimaison Any update on this? ETA? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [kafka] showuon commented on pull request #12066: KAFKA-13834: fix drain batch starving issue

2022-04-21 Thread GitBox
showuon commented on PR #12066: URL: https://github.com/apache/kafka/pull/12066#issuecomment-1105085773 @ruanliang-hualun , thanks for your contribution! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [kafka] showuon merged pull request #12066: KAFKA-13834: fix drain batch starving issue

2022-04-21 Thread GitBox
showuon merged PR #12066: URL: https://github.com/apache/kafka/pull/12066 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [kafka] showuon commented on pull request #12066: KAFKA-13834: fix drain batch starving issue

2022-04-21 Thread GitBox
showuon commented on PR #12066: URL: https://github.com/apache/kafka/pull/12066#issuecomment-1105081896 Failed tests are unrelated. ``` Build / JDK 8 and Scala 2.12 / kafka.server.KRaftClusterTest.testSetLog4jConfigurations() Build / JDK 8 and Scala 2.12 /

[GitHub] [kafka] dajac opened a new pull request, #12081: MINOR: Refactor `kafka.cluster.Replica`

2022-04-21 Thread GitBox
dajac opened a new pull request, #12081: URL: https://github.com/apache/kafka/pull/12081 This patch refactors `kafka.cluster.Replica`, it usages and tests. ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation - [ ] Verify test coverage

[GitHub] [kafka] ruanliang-hualun commented on a diff in pull request #12066: KAFKA-13834: fix drain batch starving issue

2022-04-21 Thread GitBox
ruanliang-hualun commented on code in PR #12066: URL: https://github.com/apache/kafka/pull/12066#discussion_r855049810 ## clients/src/test/java/org/apache/kafka/clients/producer/internals/RecordAccumulatorTest.java: ## @@ -153,7 +153,7 @@ private void

[GitHub] [kafka] FireBurn commented on pull request #11596: MINOR: bump version in kraft readme

2022-04-21 Thread GitBox
FireBurn commented on PR #11596: URL: https://github.com/apache/kafka/pull/11596#issuecomment-1105040711 Does this need bumping for 3.2? Or is Kaft considered stable now? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [kafka] vamossagar12 commented on a diff in pull request #11211: KAFKA-12960: Enforcing strict retention time for WindowStore and Sess…

2022-04-21 Thread GitBox
vamossagar12 commented on code in PR #11211: URL: https://github.com/apache/kafka/pull/11211#discussion_r855009539 ## streams/src/test/java/org/apache/kafka/streams/state/internals/RocksDBWindowStoreTest.java: ## @@ -181,15 +189,16 @@ public void testRolling() { ),

[GitHub] [kafka] vamossagar12 commented on a diff in pull request #11211: KAFKA-12960: Enforcing strict retention time for WindowStore and Sess…

2022-04-21 Thread GitBox
vamossagar12 commented on code in PR #11211: URL: https://github.com/apache/kafka/pull/11211#discussion_r855009539 ## streams/src/test/java/org/apache/kafka/streams/state/internals/RocksDBWindowStoreTest.java: ## @@ -181,15 +189,16 @@ public void testRolling() { ),

[GitHub] [kafka] dengziming commented on pull request #12076: MINOR: Fix SubscriptionInfoData name in exception message

2022-04-21 Thread GitBox
dengziming commented on PR #12076: URL: https://github.com/apache/kafka/pull/12076#issuecomment-1104992452 Build / JDK 17 and Scala 2.13 / org.apache.kafka.streams.integration.EosV2UpgradeIntegrationTest.shouldUpgradeFromEosAlphaToEosV2[true] It's a new flaky test yet it seems not

[GitHub] [kafka] dengziming commented on a diff in pull request #12075: KAFKA-13841: Fix a case where we were unable to place on fenced brokers in KRaft mode

2022-04-21 Thread GitBox
dengziming commented on code in PR #12075: URL: https://github.com/apache/kafka/pull/12075#discussion_r854990032 ## metadata/src/main/java/org/apache/kafka/controller/ClusterControlManager.java: ## @@ -334,11 +334,7 @@ public ControllerResult registerBroker(

[jira] [Updated] (KAFKA-13843) States tracked in TransactionManager should not be changed when receiving success response on an expired batch

2022-04-21 Thread xuexiaoyue (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13843?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] xuexiaoyue updated KAFKA-13843: --- Description: When a batch's delivery timeout has expired but later the client receives success

[GitHub] [kafka] ddrid opened a new pull request, #12080: Fix incorrect transactionManager state when receiving success response on an expired batch

2022-04-21 Thread GitBox
ddrid opened a new pull request, #12080: URL: https://github.com/apache/kafka/pull/12080 When a batch's delivery timeout has expired but later the client receives success response from the server. Sender will call `transactionManager.handleCompletedBatch` without checking if it was

[jira] [Created] (KAFKA-13843) States tracked in TransactionManager should not be changed when receiving success response on an expired batch

2022-04-21 Thread xuexiaoyue (Jira)
xuexiaoyue created KAFKA-13843: -- Summary: States tracked in TransactionManager should not be changed when receiving success response on an expired batch Key: KAFKA-13843 URL:

[GitHub] [kafka] RivenSun2 commented on pull request #12079: MINOR: Consistent with the trunk branch of apache

2022-04-21 Thread GitBox
RivenSun2 commented on PR #12079: URL: https://github.com/apache/kafka/pull/12079#issuecomment-1104884051 Hi @showuon , my `trunk` branch should be permanently polluted. Fortunately, I found out that my `master` branch is exactly the same as the `apach:trunk` branch. Neither ahead nor

[GitHub] [kafka] RivenSun2 closed pull request #12079: MINOR: Consistent with the trunk branch of apache

2022-04-21 Thread GitBox
RivenSun2 closed pull request #12079: MINOR: Consistent with the trunk branch of apache URL: https://github.com/apache/kafka/pull/12079 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [kafka] RivenSun2 commented on pull request #12079: MINOR: Consistent with the trunk branch of apache

2022-04-21 Thread GitBox
RivenSun2 commented on PR #12079: URL: https://github.com/apache/kafka/pull/12079#issuecomment-1104871356 Maybe this still doesn't solve the problem. I shouldn't have used my trunk branch to commit code when creating my first PR. Even if the subsequent PRs are changed from the branch

[GitHub] [kafka] RivenSun2 opened a new pull request, #12079: MINOR: Consistent with the trunk branch of apache

2022-04-21 Thread GitBox
RivenSun2 opened a new pull request, #12079: URL: https://github.com/apache/kafka/pull/12079 Consistent with the trunk branch of apache. @showuon Hi luke, in fact every time I create a PR, I duplicate a new branch from my latest trunk branch to make code changes. Every time

[GitHub] [kafka] showuon commented on a diff in pull request #12066: KAFKA-13834: fix drain batch starving issue

2022-04-21 Thread GitBox
showuon commented on code in PR #12066: URL: https://github.com/apache/kafka/pull/12066#discussion_r854913440 ## clients/src/test/java/org/apache/kafka/clients/producer/internals/RecordAccumulatorTest.java: ## @@ -153,7 +153,7 @@ private void verifyTopicPartitionInBatches(Map>

[GitHub] [kafka] ruanliang-hualun commented on a diff in pull request #12066: KAFKA-13834: fix drain batch starving issue

2022-04-21 Thread GitBox
ruanliang-hualun commented on code in PR #12066: URL: https://github.com/apache/kafka/pull/12066#discussion_r854905237 ## clients/src/test/java/org/apache/kafka/clients/producer/internals/RecordAccumulatorTest.java: ## @@ -153,7 +153,7 @@ private void

[jira] [Commented] (KAFKA-13840) KafkaConsumer is unable to recover connection to group coordinator after commitOffsetsAsync exception

2022-04-21 Thread Luke Chen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13840?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17525500#comment-17525500 ] Luke Chen commented on KAFKA-13840: --- [~kyle.stehbens] , sorry, another question, are you using

[GitHub] [kafka] showuon commented on pull request #11845: MINOR: update the reassign-partition script results and argument

2022-04-21 Thread GitBox
showuon commented on PR #11845: URL: https://github.com/apache/kafka/pull/11845#issuecomment-1104841234 @hachikuji @cmccabe , please take a look. Thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [kafka] showuon commented on pull request #11881: MINOR: revert back to 60s session timeout for static membership test

2022-04-21 Thread GitBox
showuon commented on PR #11881: URL: https://github.com/apache/kafka/pull/11881#issuecomment-1104840513 @vvcephei @guozhangwang , call for review. Thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [kafka] showuon commented on pull request #12028: KAFKA-13804: output the reason why broker exit unexpectedly during startup

2022-04-21 Thread GitBox
showuon commented on PR #12028: URL: https://github.com/apache/kafka/pull/12028#issuecomment-1104839652 @mimaison , call for review. Thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[jira] [Commented] (KAFKA-9981) Running a dedicated mm2 cluster with more than one nodes,When the configuration is updated the task is not aware and will lose the update operation.

2022-04-21 Thread YANGLiiN (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9981?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17525490#comment-17525490 ] YANGLiiN commented on KAFKA-9981: - the root cause is the connect doesn't process the mm2 add the

[jira] [Commented] (KAFKA-13808) Mirrormaker2 stop sync data when modify topic partition in "Running a dedicated MirrorMaker cluster" mode

2022-04-21 Thread YANGLiiN (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13808?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17525489#comment-17525489 ] YANGLiiN commented on KAFKA-13808: -- yeah,same as the https://issues.apache.org/jira/browse/KAFKA-9981

[jira] [Comment Edited] (KAFKA-13840) KafkaConsumer is unable to recover connection to group coordinator after commitOffsetsAsync exception

2022-04-21 Thread Luke Chen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13840?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17525482#comment-17525482 ] Luke Chen edited comment on KAFKA-13840 at 4/21/22 7:37 AM: But I'm

[jira] [Commented] (KAFKA-13840) KafkaConsumer is unable to recover connection to group coordinator after commitOffsetsAsync exception

2022-04-21 Thread Luke Chen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13840?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17525482#comment-17525482 ] Luke Chen commented on KAFKA-13840: --- But I'm wondering why the heartbeat thread doesn't help clear the

[jira] [Assigned] (KAFKA-13840) KafkaConsumer is unable to recover connection to group coordinator after commitOffsetsAsync exception

2022-04-21 Thread Luke Chen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13840?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Luke Chen reassigned KAFKA-13840: - Assignee: Luke Chen > KafkaConsumer is unable to recover connection to group coordinator after

[jira] [Commented] (KAFKA-13840) KafkaConsumer is unable to recover connection to group coordinator after commitOffsetsAsync exception

2022-04-21 Thread Luke Chen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13840?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17525475#comment-17525475 ] Luke Chen commented on KAFKA-13840: --- [~kyle.stehbens] , thanks for reporting this issue. Yes, this is

[GitHub] [kafka] showuon commented on a diff in pull request #12066: KAFKA-13834: fix drain batch starving issue

2022-04-21 Thread GitBox
showuon commented on code in PR #12066: URL: https://github.com/apache/kafka/pull/12066#discussion_r854850350 ## clients/src/test/java/org/apache/kafka/clients/producer/internals/RecordAccumulatorTest.java: ## @@ -98,6 +98,66 @@ public void teardown() {

[GitHub] [kafka] ruanliang-hualun commented on a diff in pull request #12066: KAFKA-13834: fix drain batch starving issue

2022-04-21 Thread GitBox
ruanliang-hualun commented on code in PR #12066: URL: https://github.com/apache/kafka/pull/12066#discussion_r854853851 ## clients/src/test/java/org/apache/kafka/clients/producer/internals/RecordAccumulatorTest.java: ## @@ -98,6 +99,54 @@ public void teardown() {

[GitHub] [kafka] showuon commented on a diff in pull request #12066: KAFKA-13834: fix drain batch starving issue

2022-04-21 Thread GitBox
showuon commented on code in PR #12066: URL: https://github.com/apache/kafka/pull/12066#discussion_r854851467 ## clients/src/test/java/org/apache/kafka/clients/producer/internals/RecordAccumulatorTest.java: ## @@ -98,6 +99,54 @@ public void teardown() {

[GitHub] [kafka] ruanliang-hualun commented on a diff in pull request #12066: KAFKA-13834: fix drain batch starving issue

2022-04-21 Thread GitBox
ruanliang-hualun commented on code in PR #12066: URL: https://github.com/apache/kafka/pull/12066#discussion_r854849210 ## clients/src/test/java/org/apache/kafka/clients/producer/internals/RecordAccumulatorTest.java: ## @@ -98,6 +98,66 @@ public void teardown() {

[GitHub] [kafka] bozhao12 commented on pull request #11942: KAFKA-13767: Fetch from consumers should return immediately when preferred read replica is defined by the leader

2022-04-21 Thread GitBox
bozhao12 commented on PR #11942: URL: https://github.com/apache/kafka/pull/11942#issuecomment-1104791101 @dajac @ijuma Currently,Because the consumer supports pulling data from the leader replica, and also supports pulling data from the follower replica. I think the method scalaDoc of

[GitHub] [kafka] showuon commented on a diff in pull request #12066: KAFKA-13834: fix drain batch starving issue

2022-04-21 Thread GitBox
showuon commented on code in PR #12066: URL: https://github.com/apache/kafka/pull/12066#discussion_r854844189 ## clients/src/test/java/org/apache/kafka/clients/producer/internals/RecordAccumulatorTest.java: ## @@ -98,6 +98,66 @@ public void teardown() {

[GitHub] [kafka] bozhao12 opened a new pull request, #12078: Minor:Fix method scalaDoc in DelayedFetch.scala

2022-04-21 Thread GitBox
bozhao12 opened a new pull request, #12078: URL: https://github.com/apache/kafka/pull/12078 Currently, the consumer supports pulling data from the leader replica, and also supports pulling data from the follower replica. Therefore, whether it is fetching data from a leader or a

  1   2   >