dengziming commented on PR #12110:
URL: https://github.com/apache/kafka/pull/12110#issuecomment-1129542846
@showuon These 2 tests can be fixed by `ensureConsistentKRaftMetadata`, I
fixed them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please
dengziming commented on code in PR #12110:
URL: https://github.com/apache/kafka/pull/12110#discussion_r875447627
##
core/src/test/scala/integration/kafka/api/AdminClientWithPoliciesIntegrationTest.scala:
##
@@ -141,12 +141,13 @@ class AdminClientWithPoliciesIntegrationTest
dengziming commented on code in PR #12110:
URL: https://github.com/apache/kafka/pull/12110#discussion_r875447854
##
core/src/test/scala/integration/kafka/api/PlaintextAdminIntegrationTest.scala:
##
@@ -154,26 +159,30 @@ class PlaintextAdminIntegrationTest extends
dengziming commented on code in PR #12110:
URL: https://github.com/apache/kafka/pull/12110#discussion_r875447452
##
core/src/main/scala/kafka/server/ConfigAdminManager.scala:
##
@@ -505,7 +505,7 @@ object ConfigAdminManager {
}
case OpType.SUBTRACT => {
dengziming created KAFKA-13910:
--
Summary: Test metadata refresh for Kraft admin client
Key: KAFKA-13910
URL: https://issues.apache.org/jira/browse/KAFKA-13910
Project: Kafka
Issue Type: Test
showuon commented on PR #12110:
URL: https://github.com/apache/kafka/pull/12110#issuecomment-1129520244
Also, the 2 failed tests are introduced by this PR.
```
Build / JDK 17 and Scala 2.13 /
kafka.api.PlaintextAdminIntegrationTest.testDescribeTopicsWithIds(String).quorum=kraft
showuon commented on code in PR #12110:
URL: https://github.com/apache/kafka/pull/12110#discussion_r875418603
##
core/src/test/scala/integration/kafka/api/PlaintextAdminIntegrationTest.scala:
##
@@ -154,26 +159,30 @@ class PlaintextAdminIntegrationTest extends
dengziming commented on PR #12170:
URL: https://github.com/apache/kafka/pull/12170#issuecomment-1129511258
Yes, there is no perfect solution for this currently, I think we should
first fix KAFKA-13718 and decide whether we should always print
`segment.bytes`, and then we can merge this PR.
dengziming commented on code in PR #12175:
URL: https://github.com/apache/kafka/pull/12175#discussion_r875406021
##
core/src/main/scala/kafka/tools/ConsoleConsumer.scala:
##
@@ -248,6 +248,10 @@ object ConsoleConsumer extends Logging {
.withRequiredArg
[
https://issues.apache.org/jira/browse/KAFKA-13864?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17538542#comment-17538542
]
lqjacklee commented on KAFKA-13864:
---
[~frosiere] sorry late to reply , I have just resolved the VPN
lqjack commented on code in PR #12125:
URL: https://github.com/apache/kafka/pull/12125#discussion_r875402198
##
clients/src/main/java/org/apache/kafka/clients/consumer/KafkaConsumer.java:
##
@@ -663,12 +663,38 @@ public KafkaConsumer(Properties properties,
public
lqjack commented on code in PR #12125:
URL: https://github.com/apache/kafka/pull/12125#discussion_r875399898
##
clients/src/main/java/org/apache/kafka/clients/consumer/KafkaConsumer.java:
##
@@ -663,12 +663,38 @@ public KafkaConsumer(Properties properties,
public
sfc-gh-japatel commented on PR #9375:
URL: https://github.com/apache/kafka/pull/9375#issuecomment-1129475840
Hello, I am trying to repro this issue in a connect environment, any
guidance on what could be the message to hit this in 2.3.1 and eventually an
infinite loop?
--
This is an
dengziming commented on code in PR #12109:
URL: https://github.com/apache/kafka/pull/12109#discussion_r875363131
##
core/src/main/scala/kafka/server/ZkAdminManager.scala:
##
@@ -158,7 +158,7 @@ class ZkAdminManager(val config: KafkaConfig,
val nullConfigs =
dengziming commented on code in PR #12109:
URL: https://github.com/apache/kafka/pull/12109#discussion_r875363131
##
core/src/main/scala/kafka/server/ZkAdminManager.scala:
##
@@ -158,7 +158,7 @@ class ZkAdminManager(val config: KafkaConfig,
val nullConfigs =
dengziming commented on code in PR #12109:
URL: https://github.com/apache/kafka/pull/12109#discussion_r875363131
##
core/src/main/scala/kafka/server/ZkAdminManager.scala:
##
@@ -158,7 +158,7 @@ class ZkAdminManager(val config: KafkaConfig,
val nullConfigs =
dengziming commented on code in PR #12109:
URL: https://github.com/apache/kafka/pull/12109#discussion_r875363131
##
core/src/main/scala/kafka/server/ZkAdminManager.scala:
##
@@ -158,7 +158,7 @@ class ZkAdminManager(val config: KafkaConfig,
val nullConfigs =
akhileshchg commented on code in PR #12109:
URL: https://github.com/apache/kafka/pull/12109#discussion_r875352883
##
core/src/main/scala/kafka/server/ZkAdminManager.scala:
##
@@ -158,7 +158,7 @@ class ZkAdminManager(val config: KafkaConfig,
val nullConfigs =
hachikuji commented on code in PR #12109:
URL: https://github.com/apache/kafka/pull/12109#discussion_r875349048
##
core/src/main/scala/kafka/server/ZkAdminManager.scala:
##
@@ -158,7 +158,7 @@ class ZkAdminManager(val config: KafkaConfig,
val nullConfigs =
hachikuji commented on code in PR #12109:
URL: https://github.com/apache/kafka/pull/12109#discussion_r875348413
##
core/src/main/scala/kafka/server/ZkAdminManager.scala:
##
@@ -158,7 +158,7 @@ class ZkAdminManager(val config: KafkaConfig,
val nullConfigs =
hachikuji merged PR #12158:
URL: https://github.com/apache/kafka/pull/12158
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
soarez commented on PR #12174:
URL: https://github.com/apache/kafka/pull/12174#issuecomment-1129337359
Thanks for the review @cmccabe and @hachikuji.
I now realize my initial proposal is silly. A controlled shutdown requires
gracefully moving leadership away from the broker, so we
soarez commented on code in PR #12174:
URL: https://github.com/apache/kafka/pull/12174#discussion_r875274700
##
core/src/main/scala/kafka/server/BrokerLifecycleManager.scala:
##
@@ -431,8 +431,18 @@ class BrokerLifecycleManager(val config: KafkaConfig,
}
override
hachikuji commented on code in PR #12150:
URL: https://github.com/apache/kafka/pull/12150#discussion_r875267802
##
core/src/main/scala/kafka/cluster/Partition.scala:
##
@@ -1133,16 +1129,94 @@ class Partition(val topicPartition: TopicPartition,
info.copy(leaderHwChange =
hachikuji commented on code in PR #12150:
URL: https://github.com/apache/kafka/pull/12150#discussion_r875267802
##
core/src/main/scala/kafka/cluster/Partition.scala:
##
@@ -1133,16 +1129,94 @@ class Partition(val topicPartition: TopicPartition,
info.copy(leaderHwChange =
hachikuji commented on code in PR #12150:
URL: https://github.com/apache/kafka/pull/12150#discussion_r875267802
##
core/src/main/scala/kafka/cluster/Partition.scala:
##
@@ -1133,16 +1129,94 @@ class Partition(val topicPartition: TopicPartition,
info.copy(leaderHwChange =
hachikuji commented on code in PR #12138:
URL: https://github.com/apache/kafka/pull/12138#discussion_r875265491
##
core/src/main/scala/kafka/cluster/Partition.scala:
##
@@ -673,7 +675,8 @@ class Partition(val topicPartition: TopicPartition,
updateAssignmentAndIsr(
hachikuji commented on code in PR #12150:
URL: https://github.com/apache/kafka/pull/12150#discussion_r875249781
##
core/src/test/scala/unit/kafka/cluster/PartitionTest.scala:
##
@@ -439,18 +545,33 @@ class PartitionTest extends AbstractPartitionTest {
val leaderEpoch = 5
mumrah commented on code in PR #12050:
URL: https://github.com/apache/kafka/pull/12050#discussion_r875213585
##
metadata/src/main/java/org/apache/kafka/controller/QuorumFeatures.java:
##
@@ -17,32 +17,94 @@
package org.apache.kafka.controller;
+import
bvarghese1 commented on code in PR #12161:
URL: https://github.com/apache/kafka/pull/12161#discussion_r875206101
##
streams/src/main/java/org/apache/kafka/streams/KafkaStreams.java:
##
@@ -1662,6 +1663,51 @@ public T store(final StoreQueryParameters
storeQueryParameters) {
mumrah commented on code in PR #12050:
URL: https://github.com/apache/kafka/pull/12050#discussion_r875200677
##
metadata/src/main/java/org/apache/kafka/controller/BootstrapMetadata.java:
##
@@ -0,0 +1,206 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or
mumrah commented on code in PR #12050:
URL: https://github.com/apache/kafka/pull/12050#discussion_r875195765
##
core/src/main/scala/kafka/tools/StorageTool.scala:
##
@@ -231,6 +252,10 @@ object StorageTool extends Logging {
val metaPropertiesPath = Paths.get(directory,
hachikuji commented on code in PR #12110:
URL: https://github.com/apache/kafka/pull/12110#discussion_r875178010
##
core/src/main/scala/kafka/server/ConfigAdminManager.scala:
##
@@ -505,7 +505,7 @@ object ConfigAdminManager {
}
case OpType.SUBTRACT => {
hachikuji commented on code in PR #12174:
URL: https://github.com/apache/kafka/pull/12174#discussion_r875182105
##
core/src/main/scala/kafka/server/BrokerLifecycleManager.scala:
##
@@ -431,8 +431,18 @@ class BrokerLifecycleManager(val config: KafkaConfig,
}
override
hachikuji commented on code in PR #12174:
URL: https://github.com/apache/kafka/pull/12174#discussion_r875182105
##
core/src/main/scala/kafka/server/BrokerLifecycleManager.scala:
##
@@ -431,8 +431,18 @@ class BrokerLifecycleManager(val config: KafkaConfig,
}
override
hachikuji commented on code in PR #12110:
URL: https://github.com/apache/kafka/pull/12110#discussion_r875178010
##
core/src/main/scala/kafka/server/ConfigAdminManager.scala:
##
@@ -505,7 +505,7 @@ object ConfigAdminManager {
}
case OpType.SUBTRACT => {
dajac commented on code in PR #12121:
URL: https://github.com/apache/kafka/pull/12121#discussion_r875156714
##
clients/src/main/java/org/apache/kafka/common/metrics/Metrics.java:
##
@@ -524,6 +524,58 @@ public void addMetric(MetricName metricName,
MetricValueProvider
hachikuji commented on PR #12171:
URL: https://github.com/apache/kafka/pull/12171#issuecomment-1129201353
@dengziming Ah, sorry about that. Let me review
https://github.com/apache/kafka/pull/12110. I'll close this if there's nothing
left after we get that in.
--
This is an automated
hachikuji commented on PR #12165:
URL: https://github.com/apache/kafka/pull/12165#issuecomment-1129198214
Thanks @dengziming and @showuon!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
cmccabe commented on code in PR #12050:
URL: https://github.com/apache/kafka/pull/12050#discussion_r875109535
##
core/src/main/scala/kafka/tools/StorageTool.scala:
##
@@ -231,6 +252,10 @@ object StorageTool extends Logging {
val metaPropertiesPath = Paths.get(directory,
cmccabe commented on code in PR #12050:
URL: https://github.com/apache/kafka/pull/12050#discussion_r875109074
##
metadata/src/main/java/org/apache/kafka/controller/BootstrapMetadata.java:
##
@@ -0,0 +1,206 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or
dajac commented on PR #12175:
URL: https://github.com/apache/kafka/pull/12175#issuecomment-1129156639
@zigarn Thanks for the PR. Adding a new command line argument requires a
KIP. The process is described here:
https://cwiki.apache.org/confluence/display/KAFKA/Kafka+Improvement+Proposals.
mumrah commented on code in PR #12050:
URL: https://github.com/apache/kafka/pull/12050#discussion_r875105840
##
metadata/src/main/java/org/apache/kafka/image/MetadataDelta.java:
##
@@ -253,6 +263,14 @@ public void replay(RemoveTopicRecord record) {
public void
cmccabe commented on PR #12174:
URL: https://github.com/apache/kafka/pull/12174#issuecomment-1129148270
Sorry, but this is not correct. We can't proceed with the controlled
shutdown if the controller is not available.
It looks like the timeout needs to be adjusted in the test since
jnh5y commented on code in PR #12161:
URL: https://github.com/apache/kafka/pull/12161#discussion_r875093015
##
streams/src/test/java/org/apache/kafka/streams/integration/PauseResumeIntegrationTest.java:
##
@@ -0,0 +1,440 @@
+/*
+ * Licensed to the Apache Software Foundation
mumrah commented on code in PR #12050:
URL: https://github.com/apache/kafka/pull/12050#discussion_r875087231
##
server-common/src/main/java/org/apache/kafka/server/common/MetadataVersion.java:
##
@@ -233,6 +250,19 @@ public String version() {
return ibpVersion;
}
cmccabe commented on code in PR #12050:
URL: https://github.com/apache/kafka/pull/12050#discussion_r875083085
##
metadata/src/main/java/org/apache/kafka/controller/util/SnapshotFileReader.java:
##
@@ -15,7 +15,7 @@
* limitations under the License.
*/
-package
cmccabe commented on code in PR #12050:
URL: https://github.com/apache/kafka/pull/12050#discussion_r875080655
##
metadata/src/main/java/org/apache/kafka/controller/BootstrapMetadata.java:
##
@@ -0,0 +1,198 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or
cmccabe commented on code in PR #12050:
URL: https://github.com/apache/kafka/pull/12050#discussion_r875080655
##
metadata/src/main/java/org/apache/kafka/controller/BootstrapMetadata.java:
##
@@ -0,0 +1,198 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or
vamossagar12 commented on PR #11211:
URL: https://github.com/apache/kafka/pull/11211#issuecomment-1129126264
@guozhangwang / @lihaosky , with all the changes happening around
https://issues.apache.org/jira/browse/KAFKA-13785, there's an interesting side
effect on this PR.
Problem is
cmccabe commented on code in PR #12050:
URL: https://github.com/apache/kafka/pull/12050#discussion_r875075852
##
metadata/src/main/java/org/apache/kafka/image/MetadataDelta.java:
##
@@ -253,6 +263,14 @@ public void replay(RemoveTopicRecord record) {
public void
cmccabe commented on code in PR #12050:
URL: https://github.com/apache/kafka/pull/12050#discussion_r875070799
##
metadata/src/main/java/org/apache/kafka/controller/QuorumFeatures.java:
##
@@ -17,32 +17,94 @@
package org.apache.kafka.controller;
+import
vamossagar12 commented on PR #12121:
URL: https://github.com/apache/kafka/pull/12121#issuecomment-1129115177
@guozhangwang , could you plz review this whenever you get the chance?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
[
https://issues.apache.org/jira/browse/KAFKA-9118?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17538335#comment-17538335
]
Viktor Somogyi-Vass edited comment on KAFKA-9118 at 5/17/22 5:06 PM:
-
[
https://issues.apache.org/jira/browse/KAFKA-9118?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Viktor Somogyi-Vass reassigned KAFKA-9118:
--
Assignee: David Arthur (was: Viktor Somogyi-Vass)
> LogDirFailureHandler
[
https://issues.apache.org/jira/browse/KAFKA-9118?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17538335#comment-17538335
]
Viktor Somogyi-Vass commented on KAFKA-9118:
[~cmccabe] thanks for the comment, reassigned it
cmccabe commented on code in PR #12050:
URL: https://github.com/apache/kafka/pull/12050#discussion_r875064356
##
server-common/src/main/java/org/apache/kafka/server/common/MetadataVersion.java:
##
@@ -233,6 +250,19 @@ public String version() {
return ibpVersion;
}
zigarn opened a new pull request, #12175:
URL: https://github.com/apache/kafka/pull/12175
`kafka-console-producer.sh` & `kafka-console-consumer.sh` scripts have a
`--property` that can be set multiple times. This PR allows to set those
properties through a config file with `--config`
[
https://issues.apache.org/jira/browse/KAFKA-13907?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Lim Qing Wei reassigned KAFKA-13907:
Assignee: Igor Soarez (was: Lim Qing Wei)
> Fix hanging
C0urante commented on PR #11780:
URL: https://github.com/apache/kafka/pull/11780#issuecomment-1129035132
Thanks @mimaison. I've addressed your comments and this is ready for another
round
--
This is an automated message from the Apache Git Service.
To respond to the message, please log
cadonna commented on PR #12173:
URL: https://github.com/apache/kafka/pull/12173#issuecomment-1129027072
@dajac Let me start a system test run for the streams upgrade tests on this
PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
Moovlin commented on PR #12167:
URL: https://github.com/apache/kafka/pull/12167#issuecomment-1129000522
@showuon happy to try and help. For my sake since this is the first code
contribution I've made, could you help me out by answering some questions?
1. When you say add some test for
soarez opened a new pull request, #12174:
URL: https://github.com/apache/kafka/pull/12174
When a controlled shutdown is requested the broker tries to communicate the
state change to the controller via a heartbeat request. [1]
In this test, the controller is not available so the
dajac commented on code in PR #12173:
URL: https://github.com/apache/kafka/pull/12173#discussion_r874915936
##
tests/kafkatest/tests/streams/streams_application_upgrade_test.py:
##
@@ -21,11 +21,12 @@
from kafkatest.services.kafka import KafkaService
from
Moovlin commented on PR #12170:
URL: https://github.com/apache/kafka/pull/12170#issuecomment-1128964761
@dengziming I went ahead and updated the PR to remove the segment.bytes
property from the sample output. I was going back and forth on if it should be
removed since what the user will
mumrah commented on code in PR #12050:
URL: https://github.com/apache/kafka/pull/12050#discussion_r874905164
##
clients/src/main/java/org/apache/kafka/clients/NodeApiVersions.java:
##
@@ -91,19 +95,11 @@ public static NodeApiVersions create(short apiKey, short
minVersion,
[
https://issues.apache.org/jira/browse/KAFKA-13907?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Lim Qing Wei reassigned KAFKA-13907:
Assignee: Lim Qing Wei
> Fix hanging
C0urante commented on code in PR #11780:
URL: https://github.com/apache/kafka/pull/11780#discussion_r874800848
##
connect/runtime/src/main/java/org/apache/kafka/connect/runtime/Worker.java:
##
@@ -1000,6 +1090,266 @@ WorkerMetricsGroup workerMetricsGroup() {
return
cadonna commented on code in PR #12173:
URL: https://github.com/apache/kafka/pull/12173#discussion_r874797346
##
tests/kafkatest/tests/streams/streams_application_upgrade_test.py:
##
@@ -21,11 +21,12 @@
from kafkatest.services.kafka import KafkaService
from
C0urante commented on code in PR #11780:
URL: https://github.com/apache/kafka/pull/11780#discussion_r874762106
##
connect/runtime/src/main/java/org/apache/kafka/connect/runtime/Worker.java:
##
@@ -576,88 +672,42 @@ public boolean startTask(
C0urante commented on code in PR #11780:
URL: https://github.com/apache/kafka/pull/11780#discussion_r874759802
##
connect/runtime/src/main/java/org/apache/kafka/connect/runtime/WorkerConnector.java:
##
@@ -271,8 +278,10 @@ void doShutdown() {
state = State.FAILED;
C0urante commented on code in PR #11780:
URL: https://github.com/apache/kafka/pull/11780#discussion_r874754965
##
connect/runtime/src/test/java/org/apache/kafka/connect/storage/OffsetStorageWriterTest.java:
##
@@ -229,4 +229,4 @@ private void expectStore(Map key, byte[]
C0urante commented on code in PR #11780:
URL: https://github.com/apache/kafka/pull/11780#discussion_r874752916
##
connect/runtime/src/main/java/org/apache/kafka/connect/runtime/Worker.java:
##
@@ -1000,6 +1090,266 @@ WorkerMetricsGroup workerMetricsGroup() {
return
mimaison commented on PR #11780:
URL: https://github.com/apache/kafka/pull/11780#issuecomment-1128749123
@rhauch @kkonstantine This is a pretty important feature, can you take a
look? The first few PRs were relatively simple but in the remaining PRs things
are getting a bit more involved
mimaison commented on code in PR #11780:
URL: https://github.com/apache/kafka/pull/11780#discussion_r874678140
##
connect/runtime/src/main/java/org/apache/kafka/connect/runtime/WorkerConnector.java:
##
@@ -271,8 +278,10 @@ void doShutdown() {
state = State.FAILED;
dajac opened a new pull request, #12173:
URL: https://github.com/apache/kafka/pull/12173
We forgot to add them in the 3.1 branch.
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [
cadonna commented on PR #12137:
URL: https://github.com/apache/kafka/pull/12137#issuecomment-1128674513
I will think about it! Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
cadonna commented on PR #12152:
URL: https://github.com/apache/kafka/pull/12152#issuecomment-1128659599
The issue is that some doc changes are specific to the next release and
should only exist in apache/kafka until the release is released. During the
release those changes are then copied
milindmantri commented on PR #12152:
URL: https://github.com/apache/kafka/pull/12152#issuecomment-1128646978
@cadonna, thanks for the review!
I'm thinking if it is required to duplicate changes in both places, is it
possible to automate this? What would it take to maintain
milindmantri commented on PR #12152:
URL: https://github.com/apache/kafka/pull/12152#issuecomment-1128629108
> Thanks for the PR, @milindmantri !
>
> LGTM!
>
> Could you open a PR with the same change against
https://github.com/apache/kafka-site in
cadonna commented on code in PR #12169:
URL: https://github.com/apache/kafka/pull/12169#discussion_r874582761
##
streams/src/main/java/org/apache/kafka/streams/StreamsConfig.java:
##
@@ -452,7 +452,9 @@ public class StreamsConfig extends AbstractConfig {
/** {@code
cadonna merged PR #12152:
URL: https://github.com/apache/kafka/pull/12152
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
dajac commented on code in PR #12150:
URL: https://github.com/apache/kafka/pull/12150#discussion_r874534340
##
core/src/main/scala/kafka/cluster/Partition.scala:
##
@@ -1133,16 +1129,94 @@ class Partition(val topicPartition: TopicPartition,
info.copy(leaderHwChange = if
dengziming commented on code in PR #12171:
URL: https://github.com/apache/kafka/pull/12171#discussion_r874414621
##
core/src/test/scala/integration/kafka/api/PlaintextAdminIntegrationTest.scala:
##
@@ -1380,19 +1426,18 @@ class PlaintextAdminIntegrationTest extends
[
https://issues.apache.org/jira/browse/KAFKA-13908?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Luke Chen updated KAFKA-13908:
--
Description:
Before [#11969|https://github.com/apache/kafka/pull/11969], We will throw an
[
https://issues.apache.org/jira/browse/KAFKA-13908?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Luke Chen updated KAFKA-13908:
--
Labels: newbie (was: )
> RuntimeException will be thrown in BrokerServer.startup, not the cause of
Florian Blumenstein created KAFKA-13909:
---
Summary: Restart Kafka in KRaft mode with ACLs ends in a
RuntimeException
Key: KAFKA-13909
URL: https://issues.apache.org/jira/browse/KAFKA-13909
[
https://issues.apache.org/jira/browse/KAFKA-13907?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17538030#comment-17538030
]
Luke Chen commented on KAFKA-13907:
---
This test is temporarily disabled right now. Remember to
[
https://issues.apache.org/jira/browse/KAFKA-13908?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Luke Chen updated KAFKA-13908:
--
Description:
Before [#11969|https://github.com/apache/kafka/pull/11969], We will throw an
showuon commented on code in PR #12165:
URL: https://github.com/apache/kafka/pull/12165#discussion_r874535508
##
core/src/test/scala/unit/kafka/server/ServerShutdownTest.scala:
##
@@ -195,8 +195,9 @@ class ServerShutdownTest extends KafkaServerTestHarness {
// identify
Luke Chen created KAFKA-13908:
-
Summary: RuntimeException will be thrown in BrokerServer.startup,
not the cause of exception
Key: KAFKA-13908
URL: https://issues.apache.org/jira/browse/KAFKA-13908
[
https://issues.apache.org/jira/browse/KAFKA-13905?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Luke Chen resolved KAFKA-13905.
---
Fix Version/s: 3.3.0
Resolution: Fixed
> Fix failing
>
showuon merged PR #12165:
URL: https://github.com/apache/kafka/pull/12165
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
showuon commented on PR #12165:
URL: https://github.com/apache/kafka/pull/12165#issuecomment-1128576829
Since we have 2 build completed and passed all tests, which means the failed
tests should be fixed in this PR. And the build stuck issue also happened in
`trunk` branch build. So I'm
dajac commented on PR #12138:
URL: https://github.com/apache/kafka/pull/12138#issuecomment-1128565440
@hachikuji Thanks for your comments. I updated the PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
dajac commented on code in PR #12138:
URL: https://github.com/apache/kafka/pull/12138#discussion_r874516358
##
core/src/main/scala/kafka/cluster/Partition.scala:
##
@@ -578,7 +579,8 @@ class Partition(val topicPartition: TopicPartition,
// Updating the assignment and ISR
dengziming commented on PR #12165:
URL: https://github.com/apache/kafka/pull/12165#issuecomment-1128549838
@showuon I didn't find the cause, I can see it has already succeeded here:
https://ci-builds.apache.org/job/Kafka/job/kafka-pr/job/PR-12165/ , but the
time is only 2ms, this is weird.
dajac commented on code in PR #12138:
URL: https://github.com/apache/kafka/pull/12138#discussion_r874491071
##
core/src/main/scala/kafka/cluster/Partition.scala:
##
@@ -578,7 +579,8 @@ class Partition(val topicPartition: TopicPartition,
// Updating the assignment and ISR
dajac commented on code in PR #12138:
URL: https://github.com/apache/kafka/pull/12138#discussion_r874478979
##
core/src/main/scala/kafka/cluster/Partition.scala:
##
@@ -673,7 +675,8 @@ class Partition(val topicPartition: TopicPartition,
updateAssignmentAndIsr(
VedaGao opened a new pull request, #12172:
URL: https://github.com/apache/kafka/pull/12172
*More detailed description of your change,
if necessary. The PR title and PR message become
the squashed commit message, so use a separate
comment to ping reviewers.*
*Summary of
1 - 100 of 102 matches
Mail list logo
