[GitHub] [kafka] showuon commented on pull request #9243: Add ConsumerGroupCommand to delete static members

showuon commented on PR #9243: URL: https://github.com/apache/kafka/pull/9243#issuecomment-1366441194 @sndp2693 , here it is: https://lists.apache.org/thread/w4jt3dw5zr4tsq6k10no0l3plfrm6b7q You might need to subscribe to the dev mailing list. Please check

[GitHub] [kafka] sndp2693 commented on pull request #9243: Add ConsumerGroupCommand to delete static members

sndp2693 commented on PR #9243: URL: https://github.com/apache/kafka/pull/9243#issuecomment-1366438973 @dajac I am not seeing any response on the [mail] thread. Am I missing anything here/Or looking at a wrong place altogether? -- This is an automated message from the Apache Git

[GitHub] [kafka] ijuma commented on a diff in pull request #13049: KAFKA-14478: Move LogConfig/CleanerConfig and related to storage module

ijuma commented on code in PR #13049: URL: https://github.com/apache/kafka/pull/13049#discussion_r1058055018 ## storage/src/main/java/org/apache/kafka/server/log/internals/ThrottledReplicaListValidator.java: ## @@ -0,0 +1,51 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] [kafka] showuon commented on a diff in pull request #13037: MINOR: make sure all partition info is propagated

showuon commented on code in PR #13037: URL: https://github.com/apache/kafka/pull/13037#discussion_r1058010957 ## core/src/test/scala/unit/kafka/utils/TestUtils.scala: ## @@ -441,6 +441,17 @@ object TestUtils extends Logging { replicaAssignment.size } +def

[jira] [Updated] (KAFKA-14478) Move LogConfig/CleanerConfig to storage module

[ https://issues.apache.org/jira/browse/KAFKA-14478?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ismael Juma updated KAFKA-14478: Fix Version/s: 3.5.0 > Move LogConfig/CleanerConfig to storage module >

[GitHub] [kafka] ijuma opened a new pull request, #13049: KAFKA-14478: Move LogConfig and related to storage module

ijuma opened a new pull request, #13049: URL: https://github.com/apache/kafka/pull/13049 Will add details soon. ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation - [ ] Verify test coverage and CI build status - [ ] Verify

[GitHub] [kafka] ijuma merged pull request #13038: KAFKA-14543: Move LogOffsetMetadata to storage module

ijuma merged PR #13038: URL: https://github.com/apache/kafka/pull/13038 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [kafka] ijuma commented on pull request #13038: KAFKA-14543: Move LogOffsetMetadata to storage module

ijuma commented on PR #13038: URL: https://github.com/apache/kafka/pull/13038#issuecomment-1366296665 JDK 17 build passed and JDK 11 build had unrelated failures. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[jira] [Commented] (KAFKA-14548) Stable streams applications stall due to infrequent restoreConsumer polls

[ https://issues.apache.org/jira/browse/KAFKA-14548?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17652327#comment-17652327 ] Matthias J. Sax commented on KAFKA-14548: - Thanks! > Stable streams applications stall due to

[GitHub] [kafka] mjsax commented on pull request #12936: KAFKA-13881: Add Streams package infos

mjsax commented on PR #12936: URL: https://github.com/apache/kafka/pull/12936#issuecomment-1366261412 Thanks for the PR, @gharris1727. Merged to `trunk` and cherry-picked to `3.4` branch. -- This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [kafka] mjsax merged pull request #12936: KAFKA-13881: Add Streams package infos

mjsax merged PR #12936: URL: https://github.com/apache/kafka/pull/12936 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [kafka] jolshan commented on a diff in pull request #13037: MINOR: make sure all partition info is propagated

jolshan commented on code in PR #13037: URL: https://github.com/apache/kafka/pull/13037#discussion_r1057950277 ## core/src/test/scala/unit/kafka/utils/TestUtils.scala: ## @@ -441,6 +441,17 @@ object TestUtils extends Logging { replicaAssignment.size } +def

[GitHub] [kafka] jolshan commented on a diff in pull request #13037: MINOR: make sure all partition info is propagated

jolshan commented on code in PR #13037: URL: https://github.com/apache/kafka/pull/13037#discussion_r1057950277 ## core/src/test/scala/unit/kafka/utils/TestUtils.scala: ## @@ -441,6 +441,17 @@ object TestUtils extends Logging { replicaAssignment.size } +def

[GitHub] [kafka] jolshan commented on pull request #12901: KAFKA-14367; Add `TnxOffsetCommit` to the new `GroupCoordinator` interface

jolshan commented on PR #12901: URL: https://github.com/apache/kafka/pull/12901#issuecomment-1366222768 also minor nit in the title `TnxOffsetCommit` -> `TxnOffsetCommit` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [kafka] ijuma commented on a diff in pull request #13038: KAFKA-14543: Move LogOffsetMetadata to storage module

ijuma commented on code in PR #13038: URL: https://github.com/apache/kafka/pull/13038#discussion_r1057937533 ## storage/src/main/java/org/apache/kafka/server/log/internals/LogOffsetMetadata.java: ## @@ -0,0 +1,103 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[GitHub] [kafka] ijuma merged pull request #13047: MINOR: Remove unused config variables

ijuma merged PR #13047: URL: https://github.com/apache/kafka/pull/13047 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [kafka] ijuma commented on pull request #13047: MINOR: Remove unused config variables

ijuma commented on PR #13047: URL: https://github.com/apache/kafka/pull/13047#issuecomment-1366206115 JDK 8 and 11 builds passed, 17 had one unrelated failure. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [kafka] philipnee commented on pull request #12590: KAFKA-7109: Close fetch sessions on close of consumer

philipnee commented on PR #12590: URL: https://github.com/apache/kafka/pull/12590#issuecomment-1366193465 Thanks @divijvaidya - I don't have more questions regarding this PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[jira] [Commented] (KAFKA-14548) Stable streams applications stall due to infrequent restoreConsumer polls

[ https://issues.apache.org/jira/browse/KAFKA-14548?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17652313#comment-17652313 ] Greg Harris commented on KAFKA-14548: - I've linked all of the tickets that I know about, including:

[GitHub] [kafka] mjsax commented on a diff in pull request #12941: KAFKA-13709: Add docs for exactly-once support in Connect

mjsax commented on code in PR #12941: URL: https://github.com/apache/kafka/pull/12941#discussion_r1057922653 ## docs/connect.html: ## @@ -593,6 +701,109 @@ Resuming from Previous Off Of course, you might need to read many keys for each of the input streams. The

[GitHub] [kafka] mjsax commented on a diff in pull request #12941: KAFKA-13709: Add docs for exactly-once support in Connect

mjsax commented on code in PR #12941: URL: https://github.com/apache/kafka/pull/12941#discussion_r1057922653 ## docs/connect.html: ## @@ -593,6 +701,109 @@ Resuming from Previous Off Of course, you might need to read many keys for each of the input streams. The

[GitHub] [kafka] mjsax commented on a diff in pull request #12941: KAFKA-13709: Add docs for exactly-once support in Connect

mjsax commented on code in PR #12941: URL: https://github.com/apache/kafka/pull/12941#discussion_r1057922386 ## docs/connect.html: ## @@ -369,6 +369,114 @@ Error Reportin # Tolerate all errors. errors.tolerance=all +Exactly-once support + +Kafka Connect is capable

[GitHub] [kafka] mjsax commented on a diff in pull request #12941: KAFKA-13709: Add docs for exactly-once support in Connect

mjsax commented on code in PR #12941: URL: https://github.com/apache/kafka/pull/12941#discussion_r1057921805 ## docs/connect.html: ## @@ -369,6 +369,114 @@ Error Reportin # Tolerate all errors. errors.tolerance=all +Exactly-once support + +Kafka Connect is capable

[GitHub] [kafka] gharris1727 commented on pull request #11818: KAFKA-12558: Do not prematurely mutate partiton state and provide con…

gharris1727 commented on PR #11818: URL: https://github.com/apache/kafka/pull/11818#issuecomment-1366187758 @C0urante could you take a look at this, please? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [kafka] gharris1727 commented on a diff in pull request #11818: KAFKA-12558: Do not prematurely mutate partiton state and provide con…

gharris1727 commented on code in PR #11818: URL: https://github.com/apache/kafka/pull/11818#discussion_r1057917207 ## connect/mirror/src/test/java/org/apache/kafka/connect/mirror/integration/MirrorConnectorsIntegrationBaseTest.java: ## @@ -305,8 +305,10 @@ public void

[jira] [Commented] (KAFKA-14555) Segfault in RocksDB DumpDataBlocks

[ https://issues.apache.org/jira/browse/KAFKA-14555?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17652307#comment-17652307 ] Greg Harris commented on KAFKA-14555: - There's one ancient upstream issue referencing a segfault on

[jira] [Updated] (KAFKA-14555) Segfault in RocksDB DumpDataBlocks

[ https://issues.apache.org/jira/browse/KAFKA-14555?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Greg Harris updated KAFKA-14555: Attachment: hs_err_pid88913.log > Segfault in RocksDB DumpDataBlocks >

[jira] [Created] (KAFKA-14555) Segfault in RocksDB DumpDataBlocks

Greg Harris created KAFKA-14555: --- Summary: Segfault in RocksDB DumpDataBlocks Key: KAFKA-14555 URL: https://issues.apache.org/jira/browse/KAFKA-14555 Project: Kafka Issue Type: Bug

[jira] [Updated] (KAFKA-14457) Inconsistent in quorum controller fenced broker metric

[ https://issues.apache.org/jira/browse/KAFKA-14457?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] José Armando García Sancio updated KAFKA-14457: --- Fix Version/s: 3.3.2 > Inconsistent in quorum controller fenced

[GitHub] [kafka] kirktrue commented on a diff in pull request #12813: KAFKA-14317: ProduceRequest timeouts are logged as network exceptions

kirktrue commented on code in PR #12813: URL: https://github.com/apache/kafka/pull/12813#discussion_r1057895364 ## clients/src/main/java/org/apache/kafka/clients/NetworkClient.java: ## @@ -1284,6 +1292,11 @@ public ClientResponse disconnected(long timeMs,

[GitHub] [kafka] kirktrue commented on a diff in pull request #12813: KAFKA-14317: ProduceRequest timeouts are logged as network exceptions

kirktrue commented on code in PR #12813: URL: https://github.com/apache/kafka/pull/12813#discussion_r1057895052 ## clients/src/main/java/org/apache/kafka/clients/NetworkClient.java: ## @@ -346,8 +346,16 @@ private void cancelInFlightRequests(String nodeId, long now, Collection

[GitHub] [kafka] ijuma commented on a diff in pull request #12590: KAFKA-7109: Close fetch sessions on close of consumer

ijuma commented on code in PR #12590: URL: https://github.com/apache/kafka/pull/12590#discussion_r1057874866 ## clients/src/test/java/org/apache/kafka/clients/consumer/KafkaConsumerTest.java: ## @@ -150,6 +150,10 @@ import static org.junit.jupiter.api.Assertions.assertTrue;

[GitHub] [kafka] ijuma commented on a diff in pull request #12590: KAFKA-7109: Close fetch sessions on close of consumer

ijuma commented on code in PR #12590: URL: https://github.com/apache/kafka/pull/12590#discussion_r1057874866 ## clients/src/test/java/org/apache/kafka/clients/consumer/KafkaConsumerTest.java: ## @@ -150,6 +150,10 @@ import static org.junit.jupiter.api.Assertions.assertTrue;

[GitHub] [kafka] ijuma commented on a diff in pull request #13037: MINOR: make sure all partition info is propagated

ijuma commented on code in PR #13037: URL: https://github.com/apache/kafka/pull/13037#discussion_r1057867126 ## core/src/test/scala/unit/kafka/utils/TestUtils.scala: ## @@ -441,6 +441,17 @@ object TestUtils extends Logging { replicaAssignment.size } +def

[GitHub] [kafka] ijuma commented on a diff in pull request #13037: MINOR: make sure all partition info is propagated

ijuma commented on code in PR #13037: URL: https://github.com/apache/kafka/pull/13037#discussion_r1057867040 ## core/src/test/scala/unit/kafka/utils/TestUtils.scala: ## @@ -451,12 +462,11 @@ object TestUtils extends Logging { topicConfig ) } catch { -

[GitHub] [kafka] ijuma commented on a diff in pull request #13048: KAFKA-14554: Move ClassLoaderAwareRemoteStorageManagerTest to storage module

ijuma commented on code in PR #13048: URL: https://github.com/apache/kafka/pull/13048#discussion_r1057865955 ## storage/src/test/java/org/apache/kafka/server/log/remote/storage/ClassLoaderAwareRemoteStorageManagerTest.java: ## @@ -0,0 +1,46 @@ +/* + * Licensed to the Apache

[GitHub] [kafka] divijvaidya commented on pull request #12590: KAFKA-7109: Close fetch sessions on close of consumer

divijvaidya commented on PR #12590: URL: https://github.com/apache/kafka/pull/12590#issuecomment-1366109237 @dajac @philipnee please review again (and restart the tests) when you get a chance! Thank you. Unrelated test failures. UnitTest are successful in my local environment.

[jira] [Commented] (KAFKA-14548) Stable streams applications stall due to infrequent restoreConsumer polls

[ https://issues.apache.org/jira/browse/KAFKA-14548?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17652292#comment-17652292 ] Matthias J. Sax commented on KAFKA-14548: - Thanks! – I have of course an interest to get this

[GitHub] [kafka] mjsax commented on a diff in pull request #12936: KAFKA-13881: Add Streams package infos

mjsax commented on code in PR #12936: URL: https://github.com/apache/kafka/pull/12936#discussion_r1057839578 ## streams/test-utils/src/main/java/org/apache/kafka/streams/test/package-info.java: ## @@ -0,0 +1,20 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

[GitHub] [kafka] mjsax commented on a diff in pull request #12936: KAFKA-13881: Add Streams package infos

mjsax commented on code in PR #12936: URL: https://github.com/apache/kafka/pull/12936#discussion_r1057839203 ## streams/src/main/java/org/apache/kafka/streams/query/package-info.java: ## @@ -0,0 +1,20 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more

[GitHub] [kafka] mjsax commented on a diff in pull request #12936: KAFKA-13881: Add Streams package infos

mjsax commented on code in PR #12936: URL: https://github.com/apache/kafka/pull/12936#discussion_r1057837718 ## streams/src/main/java/org/apache/kafka/streams/processor/package-info.java: ## @@ -0,0 +1,20 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or

[GitHub] [kafka] mjsax commented on a diff in pull request #12936: KAFKA-13881: Add Streams package infos

mjsax commented on code in PR #12936: URL: https://github.com/apache/kafka/pull/12936#discussion_r1057837718 ## streams/src/main/java/org/apache/kafka/streams/processor/package-info.java: ## @@ -0,0 +1,20 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or

[GitHub] [kafka] mjsax commented on a diff in pull request #12936: KAFKA-13881: Add Streams package infos

mjsax commented on code in PR #12936: URL: https://github.com/apache/kafka/pull/12936#discussion_r1057837322 ## streams/src/main/java/org/apache/kafka/streams/processor/api/package-info.java: ## @@ -0,0 +1,20 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

[GitHub] [kafka] mjsax commented on a diff in pull request #12936: KAFKA-13881: Add Streams package infos

mjsax commented on code in PR #12936: URL: https://github.com/apache/kafka/pull/12936#discussion_r1057835843 ## streams/src/main/java/org/apache/kafka/streams/kstream/package-info.java: ## @@ -0,0 +1,20 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or

[GitHub] [kafka] mjsax commented on a diff in pull request #12936: KAFKA-13881: Add Streams package infos

mjsax commented on code in PR #12936: URL: https://github.com/apache/kafka/pull/12936#discussion_r1057835843 ## streams/src/main/java/org/apache/kafka/streams/kstream/package-info.java: ## @@ -0,0 +1,20 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or

[GitHub] [kafka] mjsax commented on pull request #13022: MINOR: fix expected version in streams upgrade test

mjsax commented on PR #13022: URL: https://github.com/apache/kafka/pull/13022#issuecomment-1366085263 Merged to `trunk` and cherry-picked to `3.4` branch. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [kafka] mjsax merged pull request #13022: MINOR: fix expected version in streams upgrade test

mjsax merged PR #13022: URL: https://github.com/apache/kafka/pull/13022 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Resolved] (KAFKA-14548) Stable streams applications stall due to infrequent restoreConsumer polls

[ https://issues.apache.org/jira/browse/KAFKA-14548?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Greg Harris resolved KAFKA-14548. - Resolution: Duplicate > Stable streams applications stall due to infrequent restoreConsumer

[jira] [Commented] (KAFKA-14548) Stable streams applications stall due to infrequent restoreConsumer polls

[ https://issues.apache.org/jira/browse/KAFKA-14548?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17652289#comment-17652289 ] Greg Harris commented on KAFKA-14548: - [~mjsax] Thanks for your patience on this issue. I will no

[jira] [Commented] (KAFKA-14453) Flaky test suite MirrorConnectorsWithCustomForwardingAdminIntegrationTest

[ https://issues.apache.org/jira/browse/KAFKA-14453?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17652290#comment-17652290 ] Matthias J. Sax commented on KAFKA-14453: - [~ChrisEgerton] – Jenkins seems to be in very bad

[GitHub] [kafka] philipnee commented on a diff in pull request #12590: KAFKA-7109: Close fetch sessions on close of consumer

philipnee commented on code in PR #12590: URL: https://github.com/apache/kafka/pull/12590#discussion_r1057826298 ## clients/src/main/java/org/apache/kafka/clients/consumer/KafkaConsumer.java: ## @@ -2403,17 +2404,46 @@ private ClusterResourceListeners

[GitHub] [kafka] philipnee commented on a diff in pull request #12590: KAFKA-7109: Close fetch sessions on close of consumer

philipnee commented on code in PR #12590: URL: https://github.com/apache/kafka/pull/12590#discussion_r1057824516 ## clients/src/test/java/org/apache/kafka/clients/consumer/KafkaConsumerTest.java: ## @@ -150,6 +150,10 @@ import static

[GitHub] [kafka] rondagostino commented on pull request #13047: MINOR: Remove unused config variables

rondagostino commented on PR #13047: URL: https://github.com/apache/kafka/pull/13047#issuecomment-1366076460 `ControllerMessageQueueSize` removals LGTM as well -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [kafka] philipnee commented on a diff in pull request #12590: KAFKA-7109: Close fetch sessions on close of consumer

philipnee commented on code in PR #12590: URL: https://github.com/apache/kafka/pull/12590#discussion_r1057821557 ## clients/src/main/java/org/apache/kafka/clients/consumer/KafkaConsumer.java: ## @@ -2403,17 +2404,40 @@ private ClusterResourceListeners

[GitHub] [kafka] jolshan commented on a diff in pull request #12870: KAFKA-14367; Add `OffsetFetch` to the new `GroupCoordinator` interface

jolshan commented on code in PR #12870: URL: https://github.com/apache/kafka/pull/12870#discussion_r1057811006 ## core/src/test/scala/unit/kafka/server/OffsetFetchRequestTest.scala: ## @@ -150,42 +149,6 @@ class OffsetFetchRequestTest extends BaseRequestTest { } } -

[GitHub] [kafka] jolshan commented on a diff in pull request #12886: KAFKA-14367; Add `OffsetCommit` to the new `GroupCoordinator` interface

jolshan commented on code in PR #12886: URL: https://github.com/apache/kafka/pull/12886#discussion_r1057809723 ## core/src/main/scala/kafka/coordinator/group/GroupCoordinatorAdapter.scala: ## @@ -234,4 +240,78 @@ class GroupCoordinatorAdapter( }

[GitHub] [kafka] ijuma commented on pull request #13047: MINOR: Remove unused config variables

ijuma commented on PR #13047: URL: https://github.com/apache/kafka/pull/13047#issuecomment-1366049605 Yes, that's right. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[jira] [Assigned] (KAFKA-14554) Move ClassLoaderAwareRemoteStorageManagerTest to storage module

[ https://issues.apache.org/jira/browse/KAFKA-14554?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Federico Valeri reassigned KAFKA-14554: --- Assignee: Federico Valeri > Move ClassLoaderAwareRemoteStorageManagerTest to

[jira] [Created] (KAFKA-14554) Move ClassLoaderAwareRemoteStorageManagerTest to storage module

Federico Valeri created KAFKA-14554: --- Summary: Move ClassLoaderAwareRemoteStorageManagerTest to storage module Key: KAFKA-14554 URL: https://issues.apache.org/jira/browse/KAFKA-14554 Project: Kafka

[GitHub] [kafka] divijvaidya commented on a diff in pull request #12590: KAFKA-7109: Close fetch sessions on close of consumer

divijvaidya commented on code in PR #12590: URL: https://github.com/apache/kafka/pull/12590#discussion_r1057774816 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/Fetcher.java: ## @@ -1933,11 +1943,79 @@ private Map topicPartitionTags(TopicPartition tp) {

[GitHub] [kafka] ijuma opened a new pull request, #13047: MINOR: Remove unused config variables

ijuma opened a new pull request, #13047: URL: https://github.com/apache/kafka/pull/13047 Also move a couple that were in the wrong section. ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation - [ ] Verify test coverage and CI build

[GitHub] [kafka] ijuma commented on a diff in pull request #12590: KAFKA-7109: Close fetch sessions on close of consumer

ijuma commented on code in PR #12590: URL: https://github.com/apache/kafka/pull/12590#discussion_r1057751426 ## clients/src/test/java/org/apache/kafka/clients/consumer/KafkaConsumerTest.java: ## @@ -150,6 +150,10 @@ import static org.junit.jupiter.api.Assertions.assertTrue;

[GitHub] [kafka] divijvaidya commented on a diff in pull request #12590: KAFKA-7109: Close fetch sessions on close of consumer

divijvaidya commented on code in PR #12590: URL: https://github.com/apache/kafka/pull/12590#discussion_r1057741251 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/Fetcher.java: ## @@ -1933,11 +1941,79 @@ private Map topicPartitionTags(TopicPartition tp) {

[GitHub] [kafka] divijvaidya commented on a diff in pull request #12590: KAFKA-7109: Close fetch sessions on close of consumer

divijvaidya commented on code in PR #12590: URL: https://github.com/apache/kafka/pull/12590#discussion_r1057740583 ## clients/src/test/java/org/apache/kafka/clients/consumer/KafkaConsumerTest.java: ## @@ -150,6 +150,10 @@ import static

[GitHub] [kafka] divijvaidya commented on a diff in pull request #12590: KAFKA-7109: Close fetch sessions on close of consumer

divijvaidya commented on code in PR #12590: URL: https://github.com/apache/kafka/pull/12590#discussion_r1057740152 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/Fetcher.java: ## @@ -446,6 +429,33 @@ private RequestFuture

[GitHub] [kafka] ijuma commented on a diff in pull request #13038: KAFKA-14543: Move LogOffsetMetadata to storage module

ijuma commented on code in PR #13038: URL: https://github.com/apache/kafka/pull/13038#discussion_r1057735369 ## storage/src/main/java/org/apache/kafka/server/log/internals/LogOffsetMetadata.java: ## @@ -0,0 +1,103 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[GitHub] [kafka] divijvaidya commented on a diff in pull request #12590: KAFKA-7109: Close fetch sessions on close of consumer

divijvaidya commented on code in PR #12590: URL: https://github.com/apache/kafka/pull/12590#discussion_r1057733282 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/Fetcher.java: ## @@ -1933,11 +1943,79 @@ private Map topicPartitionTags(TopicPartition tp) {

[GitHub] [kafka] divijvaidya commented on a diff in pull request #12590: KAFKA-7109: Close fetch sessions on close of consumer

divijvaidya commented on code in PR #12590: URL: https://github.com/apache/kafka/pull/12590#discussion_r1057720228 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/Fetcher.java: ## @@ -1933,11 +1943,79 @@ private Map topicPartitionTags(TopicPartition tp) {

[GitHub] [kafka] divijvaidya commented on a diff in pull request #12590: KAFKA-7109: Close fetch sessions on close of consumer

divijvaidya commented on code in PR #12590: URL: https://github.com/apache/kafka/pull/12590#discussion_r1057719157 ## clients/src/test/java/org/apache/kafka/clients/consumer/KafkaConsumerTest.java: ## @@ -1600,9 +1605,8 @@ public void testCloseInterrupt() throws Exception {

[GitHub] [kafka] divijvaidya commented on a diff in pull request #12590: KAFKA-7109: Close fetch sessions on close of consumer

divijvaidya commented on code in PR #12590: URL: https://github.com/apache/kafka/pull/12590#discussion_r1057718865 ## clients/src/test/java/org/apache/kafka/clients/consumer/KafkaConsumerTest.java: ## @@ -1571,7 +1575,8 @@ public void testGracefulClose() throws Exception {

[GitHub] [kafka] emilnkrastev commented on pull request #11818: KAFKA-12558: Do not prematurely mutate partiton state and provide con…

emilnkrastev commented on PR #11818: URL: https://github.com/apache/kafka/pull/11818#issuecomment-1365885531 @gharris1727 The PR has been updated by adding additional unit test for testing partition state mutation and changing the update logic. The MirrorConnectorsIntegrationSSLTest

[jira] [Updated] (KAFKA-14553) RecordAccumulator hangs in infinite NOP loop

[ https://issues.apache.org/jira/browse/KAFKA-14553?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Viczai Gábor updated KAFKA-14553: - Description: *Summary:* There is an infinite loop in RecordAccumulator, if stickyBatchSize is

[GitHub] [kafka] divijvaidya commented on a diff in pull request #12590: KAFKA-7109: Close fetch sessions on close of consumer

divijvaidya commented on code in PR #12590: URL: https://github.com/apache/kafka/pull/12590#discussion_r1057641795 ## clients/src/test/java/org/apache/kafka/clients/consumer/internals/FetcherTest.java: ## @@ -5171,27 +5222,27 @@ private void buildFetcher(MetricConfig

[GitHub] [kafka] yashmayya commented on a diff in pull request #12984: KAFKA-14455: Kafka Connect create and update REST APIs should surface failures while writing to the config topic

yashmayya commented on code in PR #12984: URL: https://github.com/apache/kafka/pull/12984#discussion_r1050765139 ## connect/runtime/src/main/java/org/apache/kafka/connect/storage/KafkaConfigBackingStore.java: ## @@ -712,8 +733,16 @@ KafkaBasedLog

[GitHub] [kafka] divijvaidya commented on a diff in pull request #12590: KAFKA-7109: Close fetch sessions on close of consumer

divijvaidya commented on code in PR #12590: URL: https://github.com/apache/kafka/pull/12590#discussion_r1057619747 ## clients/src/test/java/org/apache/kafka/clients/consumer/KafkaConsumerTest.java: ## @@ -1539,30 +1543,30 @@ public void testOffsetOfPausedPartitions() {

[GitHub] [kafka] mimaison commented on pull request #13038: KAFKA-14543: Move LogOffsetMetadata to storage module

mimaison commented on PR #13038: URL: https://github.com/apache/kafka/pull/13038#issuecomment-1365826416 I've rebased and either addressed or replied to the comments. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [kafka] mimaison commented on a diff in pull request #13038: KAFKA-14543: Move LogOffsetMetadata to storage module

mimaison commented on code in PR #13038: URL: https://github.com/apache/kafka/pull/13038#discussion_r1057616357 ## core/src/main/scala/kafka/log/UnifiedLog.scala: ## @@ -939,14 +938,14 @@ class UnifiedLog(@volatile var logStartOffset: Long, maybeDuplicate match {

[GitHub] [kafka] divijvaidya commented on a diff in pull request #12590: KAFKA-7109: Close fetch sessions on close of consumer

divijvaidya commented on code in PR #12590: URL: https://github.com/apache/kafka/pull/12590#discussion_r1057615287 ## clients/src/test/java/org/apache/kafka/clients/consumer/KafkaConsumerTest.java: ## @@ -150,6 +150,10 @@ import static

[GitHub] [kafka] divijvaidya commented on a diff in pull request #12590: KAFKA-7109: Close fetch sessions on close of consumer

divijvaidya commented on code in PR #12590: URL: https://github.com/apache/kafka/pull/12590#discussion_r1057614431 ## clients/src/main/java/org/apache/kafka/common/requests/FetchMetadata.java: ## @@ -114,9 +114,21 @@ public boolean equals(Object o) { } /** - *

[GitHub] [kafka] divijvaidya commented on a diff in pull request #12590: KAFKA-7109: Close fetch sessions on close of consumer

divijvaidya commented on code in PR #12590: URL: https://github.com/apache/kafka/pull/12590#discussion_r1057603547 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/Fetcher.java: ## @@ -1933,11 +1943,79 @@ private Map topicPartitionTags(TopicPartition tp) {

[GitHub] [kafka] divijvaidya commented on a diff in pull request #12590: KAFKA-7109: Close fetch sessions on close of consumer

divijvaidya commented on code in PR #12590: URL: https://github.com/apache/kafka/pull/12590#discussion_r1057601069 ## clients/src/main/java/org/apache/kafka/clients/consumer/KafkaConsumer.java: ## @@ -2403,17 +2404,46 @@ private ClusterResourceListeners

[GitHub] [kafka] divijvaidya commented on a diff in pull request #12590: KAFKA-7109: Close fetch sessions on close of consumer

divijvaidya commented on code in PR #12590: URL: https://github.com/apache/kafka/pull/12590#discussion_r1057599467 ## clients/src/main/java/org/apache/kafka/clients/consumer/KafkaConsumer.java: ## @@ -2403,17 +2404,46 @@ private ClusterResourceListeners