Re: [PR] KAFKA-16356 RemoteLogMetadataSerde: Serializer via class-name dispatch removed and replaced with if-elseif-else conditions [kafka]

2024-04-14 Thread via GitHub
gharris1727 commented on PR #15620: URL: https://github.com/apache/kafka/pull/15620#issuecomment-2055290090 Hi @linu-shibu @showuon this still uses raw types, and so is still type-unsafe. Fixing that was my motivation for creating the ticket, sorry for not emphasizing it more. I

[jira] [Commented] (KAFKA-15265) Remote copy/fetch quotas for tiered storage.

2024-04-14 Thread Abhijeet Kumar (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17837065#comment-17837065 ] Abhijeet Kumar commented on KAFKA-15265: Hi [~h...@pinterest.com]. I have broken down the task

Re: [PR] MINOR: skip 'zinc' phase from gradle dependency-check plugin [kafka]

2024-04-14 Thread via GitHub
github-actions[bot] commented on PR #15054: URL: https://github.com/apache/kafka/pull/15054#issuecomment-2054899945 This PR is being marked as stale since it has not had any activity in 90 days. If you would like to keep this PR alive, please ask a committer for review. If the PR has

[jira] [Commented] (KAFKA-16467) Add README to docs folder

2024-04-14 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16467?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17837047#comment-17837047 ] ASF GitHub Bot commented on KAFKA-16467: showuon commented on code in PR #596: URL:

[PR] JMH Benchmarks for testing the performance of the Server Side Rebalances: KIP_848 [kafka]

2024-04-14 Thread via GitHub
rreddy-22 opened a new pull request, #15717: URL: https://github.com/apache/kafka/pull/15717 This PR is for the four benchmarks that are being used to test the performance and efficiency of the consumer group rebalance process. - Client Assignors - Server Assignors - Target

Re: [PR] MINOR : Replaced the while loop with TestUtils.waitForCondition [kafka]

2024-04-14 Thread via GitHub
showuon commented on PR #15678: URL: https://github.com/apache/kafka/pull/15678#issuecomment-2054458671 @chiacyu , thanks for the update. LGTM! Comments: 1. Please resolve merge conflict 2. In L163, we did: ``` if (readyToAssert.getCount() > 0) { readyToAssert.countDown();

[jira] [Commented] (KAFKA-15265) Remote copy/fetch quotas for tiered storage.

2024-04-14 Thread Henry Cai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17837025#comment-17837025 ] Henry Cai commented on KAFKA-15265: --- [~abhijeetkumar] Is the PR getting ready to be reviewed? >

[jira] [Assigned] (KAFKA-14507) Add ConsumerGroupPrepareAssignment API

2024-04-14 Thread Phuc Hong Tran (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14507?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Phuc Hong Tran reassigned KAFKA-14507: -- Assignee: (was: Phuc Hong Tran) > Add ConsumerGroupPrepareAssignment API >

[jira] [Assigned] (KAFKA-14508) Add ConsumerGroupInstallAssignment API

2024-04-14 Thread Phuc Hong Tran (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14508?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Phuc Hong Tran reassigned KAFKA-14508: -- Assignee: (was: Phuc Hong Tran) > Add ConsumerGroupInstallAssignment API >

[jira] [Updated] (KAFKA-16516) Fix the controller node provider for broker to control channel

2024-04-14 Thread Jira
[ https://issues.apache.org/jira/browse/KAFKA-16516?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] José Armando García Sancio updated KAFKA-16516: --- Description: The broker to controller channel gets the set of

[jira] [Updated] (KAFKA-16515) Fix the ZK Metadata cache use of voter static configuration

2024-04-14 Thread Jira
[ https://issues.apache.org/jira/browse/KAFKA-16515?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] José Armando García Sancio updated KAFKA-16515: --- Description: Looks like because of ZK migration to KRaft the ZK

Re: [PR] MINOR: Various cleanups in trogdor [kafka]

2024-04-14 Thread via GitHub
mimaison commented on PR #15708: URL: https://github.com/apache/kafka/pull/15708#issuecomment-2054155906 Thanks for the review! No need to rebase, you can just log into Jenkins with your Apache credentials and rekick the build. I went to

Re: [PR] KAFKA-16481: Fixing flaky test kafka.server.ReplicaManagerTest#testRemoteLogReaderMetrics [kafka]

2024-04-14 Thread via GitHub
vamossagar12 commented on PR #15677: URL: https://github.com/apache/kafka/pull/15677#issuecomment-2054135665 @showuon , btw I am noticing that this test is failing with a different error. I am looking at the test history

[jira] [Resolved] (KAFKA-15729) KRaft support in GetOffsetShellTest

2024-04-14 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15729?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai resolved KAFKA-15729. Fix Version/s: 3.8.0 Resolution: Fixed > KRaft support in GetOffsetShellTest >

Re: [PR] KAFKA-15729: Add KRaft support in GetOffsetShellTest [kafka]

2024-04-14 Thread via GitHub
chia7712 commented on PR #15489: URL: https://github.com/apache/kafka/pull/15489#issuecomment-2054058198 failed tests pass on my local. will merge it. ``` ./gradlew cleanTest :streams:test --tests SlidingWindowedKStreamIntegrationTest.shouldRestoreAfterJoinRestart --tests

Re: [PR] KAFKA-15729: Add KRaft support in GetOffsetShellTest [kafka]

2024-04-14 Thread via GitHub
chia7712 commented on PR #15489: URL: https://github.com/apache/kafka/pull/15489#issuecomment-2054058383 @Owen-CH-Leung thanks for your contribution and effort! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] KAFKA-15729: Add KRaft support in GetOffsetShellTest [kafka]

2024-04-14 Thread via GitHub
chia7712 merged PR #15489: URL: https://github.com/apache/kafka/pull/15489 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Commented] (KAFKA-15224) Automate version change to snapshot

2024-04-14 Thread Walter Hernandez (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15224?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17836954#comment-17836954 ] Walter Hernandez commented on KAFKA-15224: -- It looks like some great headway was made, but the

[jira] [Commented] (KAFKA-15201) When git fails, script goes into a loop

2024-04-14 Thread Walter Hernandez (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17836953#comment-17836953 ] Walter Hernandez commented on KAFKA-15201: -- This PR was merged, and others developing on Forks

[jira] [Assigned] (KAFKA-15201) When git fails, script goes into a loop

2024-04-14 Thread Walter Hernandez (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15201?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Walter Hernandez reassigned KAFKA-15201: Assignee: Owen C.H. Leung > When git fails, script goes into a loop >

[jira] [Resolved] (KAFKA-4560) Min / Max Partitions Fetch Records params

2024-04-14 Thread Walter Hernandez (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-4560?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Walter Hernandez resolved KAFKA-4560. - Resolution: Abandoned > Min / Max Partitions Fetch Records params >

[jira] (KAFKA-15736) KRaft support in PlaintextConsumerTest

2024-04-14 Thread Walter Hernandez (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15736 ] Walter Hernandez deleted comment on KAFKA-15736: -- was (Author: JIRAUSER305029): https://github.com/apache/kafka/pull/14295 > KRaft support in PlaintextConsumerTest >

[jira] [Assigned] (KAFKA-16262) Add IQv2 to Kafka Streams documentation

2024-04-14 Thread Walter Hernandez (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16262?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Walter Hernandez reassigned KAFKA-16262: Assignee: Walter Hernandez > Add IQv2 to Kafka Streams documentation >

Re: [PR] KAFKA-16484: Support to define per broker/controller property by ClusterConfigProperty [kafka]

2024-04-14 Thread via GitHub
chia7712 commented on code in PR #15715: URL: https://github.com/apache/kafka/pull/15715#discussion_r1564660916 ## core/src/test/java/kafka/test/junit/ClusterTestExtensions.java: ## @@ -190,10 +192,10 @@ private void processClusterTest(ExtensionContext context, ClusterTest

Re: [PR] KAFKA-16484: Support to define per broker/controller property by ClusterConfigProperty [kafka]

2024-04-14 Thread via GitHub
brandboat commented on code in PR #15715: URL: https://github.com/apache/kafka/pull/15715#discussion_r1564660683 ## core/src/test/java/kafka/test/junit/ClusterTestExtensions.java: ## @@ -190,10 +192,10 @@ private void processClusterTest(ExtensionContext context, ClusterTest

[jira] [Assigned] (KAFKA-2499) kafka-producer-perf-test should use something more realistic than empty byte arrays

2024-04-14 Thread Walter Hernandez (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-2499?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Walter Hernandez reassigned KAFKA-2499: --- Assignee: (was: Walter Hernandez) > kafka-producer-perf-test should use

[jira] [Assigned] (KAFKA-15748) KRaft support in MetricsDuringTopicCreationDeletionTest

2024-04-14 Thread Walter Hernandez (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15748?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Walter Hernandez reassigned KAFKA-15748: Assignee: (was: Walter Hernandez) > KRaft support in

[jira] [Resolved] (KAFKA-15748) KRaft support in MetricsDuringTopicCreationDeletionTest

2024-04-14 Thread Walter Hernandez (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15748?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Walter Hernandez resolved KAFKA-15748. -- Resolution: Fixed Changes can be found here:

[jira] [Commented] (KAFKA-15736) KRaft support in PlaintextConsumerTest

2024-04-14 Thread Walter Hernandez (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15736?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17836950#comment-17836950 ] Walter Hernandez commented on KAFKA-15736: -- https://github.com/apache/kafka/pull/14295 > KRaft

[jira] [Commented] (KAFKA-15748) KRaft support in MetricsDuringTopicCreationDeletionTest

2024-04-14 Thread Walter Hernandez (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15748?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17836949#comment-17836949 ] Walter Hernandez commented on KAFKA-15748: -- I will verify that the merged PR commented above

[jira] [Assigned] (KAFKA-15748) KRaft support in MetricsDuringTopicCreationDeletionTest

2024-04-14 Thread Walter Hernandez (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15748?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Walter Hernandez reassigned KAFKA-15748: Assignee: Walter Hernandez > KRaft support in

Re: [PR] KAFKA-16484: Support to define per broker/controller property by ClusterConfigProperty [kafka]

2024-04-14 Thread via GitHub
brandboat commented on code in PR #15715: URL: https://github.com/apache/kafka/pull/15715#discussion_r1564654806 ## core/src/test/java/kafka/test/junit/ClusterTestExtensions.java: ## @@ -190,10 +192,10 @@ private void processClusterTest(ExtensionContext context, ClusterTest

Re: [PR] MINOR: Cleanup in MetadataShell [kafka]

2024-04-14 Thread via GitHub
wernerdv closed pull request #15672: MINOR: Cleanup in MetadataShell URL: https://github.com/apache/kafka/pull/15672 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[jira] [Resolved] (KAFKA-2499) kafka-producer-perf-test should use something more realistic than empty byte arrays

2024-04-14 Thread Walter Hernandez (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-2499?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Walter Hernandez resolved KAFKA-2499. - Resolution: Invalid > kafka-producer-perf-test should use something more realistic than

[jira] [Commented] (KAFKA-2499) kafka-producer-perf-test should use something more realistic than empty byte arrays

2024-04-14 Thread Walter Hernandez (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-2499?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17836947#comment-17836947 ] Walter Hernandez commented on KAFKA-2499: - After researching, KAFKA-6921 removed all Scala

Re: [PR] MINOR: Add test for PartitionMetadataFile [kafka]

2024-04-14 Thread via GitHub
KevinZTW commented on PR #15714: URL: https://github.com/apache/kafka/pull/15714#issuecomment-2053970919 >@KevinZTW thanks for enhancing the test coverage. Could you also add unit tests for other methods? thanks @chia7712 no problem! I have added test cases to cover other methods,

Re: [PR] MINOR: Add test for PartitionMetadataFile [kafka]

2024-04-14 Thread via GitHub
KevinZTW commented on code in PR #15714: URL: https://github.com/apache/kafka/pull/15714#discussion_r1564569432 ## storage/src/test/java/org/apache/kafka/storage/internals/checkpoint/PartitionMetadataFileTest.java: ## @@ -0,0 +1,98 @@ +/* + * Licensed to the Apache Software

Re: [PR] MINOR: Add test for PartitionMetadataFile [kafka]

2024-04-14 Thread via GitHub
KevinZTW commented on code in PR #15714: URL: https://github.com/apache/kafka/pull/15714#discussion_r1564564066 ## storage/src/test/java/org/apache/kafka/storage/internals/checkpoint/PartitionMetadataFileTest.java: ## @@ -0,0 +1,59 @@ +/* + * Licensed to the Apache Software

Re: [PR] KAFKA-16490: Upgrade gradle from 8.6 to 8.7 [kafka]

2024-04-14 Thread via GitHub
chia7712 commented on PR #15716: URL: https://github.com/apache/kafka/pull/15716#issuecomment-2053949996 @chiacyu Could you update wrapper link also? https://raw.githubusercontent.com/gradle/gradle/v8.7.0/gradle/wrapper/gradle-wrapper.jar -- This is an automated message from the Apache

Re: [PR] MINOR: Various cleanups in shell [kafka]

2024-04-14 Thread via GitHub
chia7712 merged PR #15712: URL: https://github.com/apache/kafka/pull/15712 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] MINOR: Various cleanups in shell [kafka]

2024-04-14 Thread via GitHub
chia7712 commented on PR #15712: URL: https://github.com/apache/kafka/pull/15712#issuecomment-2053949370 ``` ./gradlew cleanTest :streams:test --tests EOSUncleanShutdownIntegrationTest.shouldWorkWithUncleanShutdownWipeOutStateStore :storage:test --tests

Re: [PR] MINOR: Various cleanups in trogdor [kafka]

2024-04-14 Thread via GitHub
chia7712 commented on PR #15708: URL: https://github.com/apache/kafka/pull/15708#issuecomment-2053947267 Could you rebase code to trigger QA for `JDK 17 and Scala 2.13`? the build is not completed -- This is an automated message from the Apache Git Service. To respond to the message,

[jira] [Assigned] (KAFKA-16547) add test for DescribeConfigsOptions#includeDocumentation

2024-04-14 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16547?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai reassigned KAFKA-16547: -- Assignee: Yu-Lin Chen (was: Yu-Lin Chen) > add test for

[jira] [Assigned] (KAFKA-16547) add test for DescribeConfigsOptions#includeDocumentation

2024-04-14 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16547?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai reassigned KAFKA-16547: -- Assignee: Yu-Lin Chen (was: Chia-Ping Tsai) > add test for

[jira] [Commented] (KAFKA-16547) add test for DescribeConfigsOptions#includeDocumentation

2024-04-14 Thread Yu-Lin Chen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16547?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17836895#comment-17836895 ] Yu-Lin Chen commented on KAFKA-16547: - Hi [~chia7712], I would like to fix it. Could you assign this