kamalcph commented on code in PR #15885:
URL: https://github.com/apache/kafka/pull/15885#discussion_r1597563897
##
storage/src/main/java/org/apache/kafka/server/log/remote/metadata/storage/ConsumerTask.java:
##
@@ -153,6 +173,7 @@ public void run() {
private void processC
m1a2st commented on PR #15779:
URL: https://github.com/apache/kafka/pull/15779#issuecomment-2106119689
@chia7712 , Thanks for your review, I have been modify all test for testing
different groupProtocol type. Please review again
--
This is an automated message from the Apache Git Service.
kagarwal06 closed pull request #14969: Kafka-15444: Native docker image for
Apache Kafka(KIP-974)
URL: https://github.com/apache/kafka/pull/14969
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
kagarwal06 opened a new pull request, #15927:
URL: https://github.com/apache/kafka/pull/15927
*More detailed description of your change,
if necessary. The PR title and PR message become
the squashed commit message, so use a separate
comment to ping reviewers.*
*Summary of test
github-actions[bot] commented on PR #14720:
URL: https://github.com/apache/kafka/pull/14720#issuecomment-2106105337
This PR is being marked as stale since it has not had any activity in 90
days. If you would like to keep this PR alive, please ask a committer for
review. If the PR has merge
chickenchickenlove commented on PR #15926:
URL: https://github.com/apache/kafka/pull/15926#issuecomment-2106104706
Hey, @mumrah !
I create PR to improve log desrcription when
zookeeper.metadata.migration.enable is false.
When you have free time, could you take a look? 🙇‍♂️
--
Th
chickenchickenlove closed pull request #15926: improve log description of
QuorumController
URL: https://github.com/apache/kafka/pull/15926
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specifi
FrankYang0529 commented on code in PR #15868:
URL: https://github.com/apache/kafka/pull/15868#discussion_r1597538208
##
connect/runtime/src/test/java/org/apache/kafka/connect/integration/SessionedProtocolIntegrationTest.java:
##
@@ -115,11 +112,11 @@ public void ensureInternalEn
[
https://issues.apache.org/jira/browse/KAFKA-16671?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17845660#comment-17845660
]
PoAn Yang commented on KAFKA-16671:
---
Hi [~chia7712], may I assign this issue to myself
[
https://issues.apache.org/jira/browse/KAFKA-15648?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17845658#comment-17845658
]
sanghyeok An edited comment on KAFKA-15648 at 5/12/24 2:00 AM:
---
[
https://issues.apache.org/jira/browse/KAFKA-15648?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17845658#comment-17845658
]
sanghyeok An commented on KAFKA-15648:
--
Hey, [~davidarthur] !Â
How did you test it
gaurav-narula commented on PR #15885:
URL: https://github.com/apache/kafka/pull/15885#issuecomment-2106081608
Thanks for the feedback @kamalcph @satishd!
I've modified the tests so that we propagate a `Consumer`
down to `ConsumerTask` and use it only for tests.
This allows us t
showuon commented on code in PR #15917:
URL: https://github.com/apache/kafka/pull/15917#discussion_r1597526821
##
storage/src/test/java/org/apache/kafka/server/log/remote/metadata/storage/TopicBasedRemoteLogMetadataManagerTest.java:
##
@@ -171,111 +146,121 @@ private void
waitU
[
https://issues.apache.org/jira/browse/KAFKA-16619?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17845652#comment-17845652
]
sanghyeok An commented on KAFKA-16619:
--
Aye! thanks a lot!Â
> Unnecessary controll
chickenchickenlove commented on PR #15926:
URL: https://github.com/apache/kafka/pull/15926#issuecomment-2106072426
Hey, @mumrah !
I made PR for https://issues.apache.org/jira/browse/KAFKA-16619!
Could you please take a look, when you have free time? Thanks!
--
This is an automated
Chia-Ping Tsai created KAFKA-16705:
--
Summary: the flag "started" of RaftClusterInstance is false even
though the cluster is started
Key: KAFKA-16705
URL: https://issues.apache.org/jira/browse/KAFKA-16705
chia7712 commented on PR #15922:
URL: https://github.com/apache/kafka/pull/15922#issuecomment-2105955268
nice fix. BTW, could you add null check as the producer can be null
https://github.com/apache/kafka/blob/trunk/log4j-appender/src/main/java/org/apache/kafka/log4jappender/KafkaLog4
chia7712 commented on PR #15923:
URL: https://github.com/apache/kafka/pull/15923#issuecomment-2105954017
https://github.com/apache/kafka/blob/643db430a707479c9e87eec1ad67e1d4f43c9268/core/src/main/scala/kafka/network/SocketServer.scala#L728
As ` serverChannel.configureBlocking(false)`
chia7712 commented on code in PR #15916:
URL: https://github.com/apache/kafka/pull/15916#discussion_r1597475237
##
core/src/test/java/kafka/test/annotation/Type.java:
##
@@ -22,44 +22,53 @@
import kafka.test.junit.ZkClusterInvocationContext;
import org.junit.jupiter.api.extens
[
https://issues.apache.org/jira/browse/KAFKA-9401?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Gaurav Narula updated KAFKA-9401:
-
Fix Version/s: (was: 3.7.1)
> High lock contention for kafka.server.FetchManager.newContext
>
gaurav-narula closed pull request #15925: KAFKA-9401 Reduce contention for
Fetch requests
URL: https://github.com/apache/kafka/pull/15925
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
gaurav-narula commented on PR #15925:
URL: https://github.com/apache/kafka/pull/15925#issuecomment-2105946195
Thanks for the feedback! My bad, I wasn't aware about the specifics of the
backporting policy. Closing this and updating the JIRA.
--
This is an automated message from the Apache
chia7712 commented on code in PR #15924:
URL: https://github.com/apache/kafka/pull/15924#discussion_r1597473046
##
clients/src/main/java/org/apache/kafka/common/requests/DescribeAclsResponse.java:
##
@@ -137,15 +138,15 @@ public static List
aclBindings(List resources)
chia7712 commented on PR #15924:
URL: https://github.com/apache/kafka/pull/15924#issuecomment-2105945126
https://github.com/apache/kafka/blob/643db430a707479c9e87eec1ad67e1d4f43c9268/core/src/main/scala/kafka/server/AclApis.scala#L72
@chiacyu we don't need to collect all items to a ne
ijuma commented on PR #15925:
URL: https://github.com/apache/kafka/pull/15925#issuecomment-2105944275
We don't usually cherry pick changes like this to older branches. It's not a
regression and it hasn't been released yet (hence the risk is higher).
--
This is an automated message from th
gaurav-narula commented on PR #15925:
URL: https://github.com/apache/kafka/pull/15925#issuecomment-2105943872
CC: @chia7712 @soarez
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific c
gaurav-narula opened a new pull request, #15925:
URL: https://github.com/apache/kafka/pull/15925
Cherry picks #15836 to 3.7.
Note:
There were merge conflicts in the following files which were resolved
```
both modified: core/src/main/scala/kafka/server/FetchSession.sca
chia7712 commented on PR #15779:
URL: https://github.com/apache/kafka/pull/15779#issuecomment-2105943653
@m1a2st Could you please make sure "all" available consumer groups are
included in this test? For example: `produceConsumeAndShutdown` creates
consumer only for `classic`.
--
Thi
FrankYang0529 commented on code in PR #15821:
URL: https://github.com/apache/kafka/pull/15821#discussion_r1597470470
##
tools/src/test/java/org/apache/kafka/tools/consumer/group/ConsumerGroupCommandTestUtils.java:
##
@@ -92,6 +94,7 @@ static void generator(ClusterGenerator clust
chia7712 commented on code in PR #15863:
URL: https://github.com/apache/kafka/pull/15863#discussion_r1597469917
##
core/src/main/scala/kafka/log/LogCleaner.scala:
##
@@ -101,6 +101,7 @@ class LogCleaner(initialConfig: CleanerConfig,
time: Time = Time.SYSTEM) ex
FrankYang0529 commented on PR #15897:
URL: https://github.com/apache/kafka/pull/15897#issuecomment-2105938682
> @FrankYang0529 Could you please rebase code to trigger QA again?
Yes, rebased it. Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the me
johnnychhsu commented on PR #15861:
URL: https://github.com/apache/kafka/pull/15861#issuecomment-2105935810
@chia7712 thanks for the quick review!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
[
https://issues.apache.org/jira/browse/KAFKA-16679?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chia-Ping Tsai resolved KAFKA-16679.
Fix Version/s: 3.8.0
Resolution: Fixed
> Merge unit test down to the class of integ
chia7712 merged PR #15884:
URL: https://github.com/apache/kafka/pull/15884
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache
chia7712 commented on code in PR #15861:
URL: https://github.com/apache/kafka/pull/15861#discussion_r1597465635
##
core/src/test/java/kafka/test/junit/RaftClusterInvocationContext.java:
##
@@ -79,7 +79,7 @@ public RaftClusterInvocationContext(String baseDisplayName,
ClusterConf
chia7712 commented on code in PR #15861:
URL: https://github.com/apache/kafka/pull/15861#discussion_r1597465561
##
tools/src/test/java/org/apache/kafka/tools/consumer/group/ConsumerGroupCommandTestUtils.java:
##
@@ -55,19 +56,22 @@ static void generator(ClusterGenerator clusterG
chia7712 commented on code in PR #15861:
URL: https://github.com/apache/kafka/pull/15861#discussion_r1597465579
##
tools/src/test/java/org/apache/kafka/tools/consumer/group/ConsumerGroupCommandTestUtils.java:
##
@@ -55,19 +56,22 @@ static void generator(ClusterGenerator clusterG
chia7712 commented on code in PR #15861:
URL: https://github.com/apache/kafka/pull/15861#discussion_r1597465415
##
core/src/test/java/kafka/test/junit/ClusterTestExtensions.java:
##
@@ -151,19 +151,19 @@ private void processClusterTest(ExtensionContext context,
ClusterTest anno
chia7712 commented on code in PR #15861:
URL: https://github.com/apache/kafka/pull/15861#discussion_r1597465331
##
core/src/test/java/kafka/test/ClusterConfigTest.java:
##
@@ -44,14 +45,16 @@ private static Map fields(ClusterConfig
config) {
@Test
public void testCopy
chia7712 commented on code in PR #15861:
URL: https://github.com/apache/kafka/pull/15861#discussion_r1597465290
##
core/src/test/java/kafka/test/ClusterConfig.java:
##
@@ -153,13 +150,17 @@ public Map>
perBrokerOverrideProperties() {
return perBrokerOverrideProperties;
chia7712 commented on PR #15897:
URL: https://github.com/apache/kafka/pull/15897#issuecomment-2105932005
@FrankYang0529 Could you please rebase code to trigger QA again?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
[
https://issues.apache.org/jira/browse/KAFKA-9401?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17845625#comment-17845625
]
Chia-Ping Tsai commented on KAFKA-9401:
---
The PR is pushed to trunk
> High lock con
chia7712 commented on PR #15836:
URL: https://github.com/apache/kafka/pull/15836#issuecomment-2105931546
@gaurav-narula Please file PR for branch 3.7 if you feel this one needs to
be backport :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please
chia7712 merged PR #15836:
URL: https://github.com/apache/kafka/pull/15836
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache
[
https://issues.apache.org/jira/browse/KAFKA-16619?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17845621#comment-17845621
]
David Arthur edited comment on KAFKA-16619 at 5/11/24 2:45 PM:
---
[
https://issues.apache.org/jira/browse/KAFKA-16619?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17845621#comment-17845621
]
David Arthur commented on KAFKA-16619:
--
Please do! Feel free to tag me for a review
[
https://issues.apache.org/jira/browse/KAFKA-16619?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17845618#comment-17845618
]
sanghyeok An commented on KAFKA-16619:
--
Hey, [~davidarthur] !
May i try to take th
[
https://issues.apache.org/jira/browse/KAFKA-16670?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17845614#comment-17845614
]
sanghyeok An commented on KAFKA-16670:
--
Hey, [~lianetm] ,
I found root cause, but
chiacyu opened a new pull request, #15924:
URL: https://github.com/apache/kafka/pull/15924
This pr reduced the occurrence of collection copy when generating
DescribeAclsResource.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHu
[
https://issues.apache.org/jira/browse/KAFKA-16669?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chia Chuan Yu updated KAFKA-16669:
--
Summary: Remove extra collection copy when generating DescribeAclsResource
(was: Remove extra
gaurav-narula commented on PR #15836:
URL: https://github.com/apache/kafka/pull/15836#issuecomment-2105736540
Thanks for the review! I'm fairly convinced these failures are unrelated.
The report on Github enterprise suggests the failed tests are flakey. Please
refer the following links for
johnnychhsu commented on PR #15861:
URL: https://github.com/apache/kafka/pull/15861#issuecomment-2105669617
test with `./gradlew clean tools:test --tests DeleteConsumerGroupsTest
--tests DeleteOffsetsConsumerGroupCommandIntegrationTest` and `./gradlew clean
core:test --tests ClusterTestExte
johnnychhsu commented on code in PR #15861:
URL: https://github.com/apache/kafka/pull/15861#discussion_r1597412007
##
core/src/test/java/kafka/test/ClusterConfig.java:
##
@@ -83,6 +83,7 @@ private ClusterConfig(Type type, int brokers, int
controllers, int disksPerBroke
chiacyu commented on code in PR #15863:
URL: https://github.com/apache/kafka/pull/15863#discussion_r1597401032
##
core/src/main/scala/kafka/log/LogCleaner.scala:
##
@@ -101,6 +101,7 @@ class LogCleaner(initialConfig: CleanerConfig,
time: Time = Time.SYSTEM) ext
54 matches
Mail list logo
