[jira] [Commented] (KAFKA-17515) Fix flaky RestoreIntegrationTest.shouldInvokeUserDefinedGlobalStateRestoreListener

2024-09-12 Thread Yu-Lin Chen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17515?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17881477#comment-17881477 ] Yu-Lin Chen commented on KAFKA-17515: - Assigned it to myself, will submit a PR ASAP.

Re: [PR] KAFKA-17513: Move LogSegmentsTest to storage module [kafka]

2024-09-12 Thread via GitHub
xijiu commented on PR #17173: URL: https://github.com/apache/kafka/pull/17173#issuecomment-2348156972 @chia7712 I have fixed the code, PTAL -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the s

[jira] [Assigned] (KAFKA-17515) Fix flaky RestoreIntegrationTest.shouldInvokeUserDefinedGlobalStateRestoreListener

2024-09-12 Thread Yu-Lin Chen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17515?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yu-Lin Chen reassigned KAFKA-17515: --- Assignee: Yu-Lin Chen (was: Chia-Ping Tsai) > Fix flaky > RestoreIntegrationTest.shouldIn

Re: [PR] KAFKA-15859: Make RemoteListOffsets call an async operation [kafka]

2024-09-12 Thread via GitHub
kamalcph commented on PR #16602: URL: https://github.com/apache/kafka/pull/16602#issuecomment-2348151556 Gentle ping for review. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comme

[jira] [Created] (KAFKA-17544) Add a log message for KafkaShareConsumer early access

2024-09-12 Thread Andrew Schofield (Jira)
Andrew Schofield created KAFKA-17544: Summary: Add a log message for KafkaShareConsumer early access Key: KAFKA-17544 URL: https://issues.apache.org/jira/browse/KAFKA-17544 Project: Kafka

[jira] [Commented] (KAFKA-17516) Client metrics configuration resources default configs not shown by kafka-configs.sh

2024-09-12 Thread Andrew Schofield (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17516?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17881472#comment-17881472 ] Andrew Schofield commented on KAFKA-17516: -- Looking at [https://cwiki.apache.o

[jira] [Commented] (KAFKA-16339) Remove Deprecated "transformer" methods and classes

2024-09-12 Thread Jira
[ https://issues.apache.org/jira/browse/KAFKA-16339?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17881464#comment-17881464 ] João Pedro Fonseca commented on KAFKA-16339: Hi, [~mjsax], [~vrushankpatel]!

Re: [PR] KAFKA-17285: Consider using `Utils.closeQuietly` to replace `CoreUtils.swallow` when handling Closeable objects [kafka]

2024-09-12 Thread via GitHub
chia7712 commented on code in PR #16843: URL: https://github.com/apache/kafka/pull/16843#discussion_r1758133515 ## core/src/main/scala/kafka/server/ControllerServer.scala: ## @@ -512,13 +500,11 @@ class ControllerServer( CoreUtils.swallow(controllerApis.close(), this)

Re: [PR] KAFKA-16813: Add global timeout for "@Test" and "@TestTemplate" (For Github Action) [kafka]

2024-09-12 Thread via GitHub
chia7712 commented on code in PR #16957: URL: https://github.com/apache/kafka/pull/16957#discussion_r1758132188 ## core/src/test/java/kafka/test/annotation/ClusterTest.java: ## @@ -34,6 +35,7 @@ @Target({METHOD}) @Retention(RUNTIME) @TestTemplate +@Timeout(30) Review Comment

Re: [PR] KAFKA-17513: Move LogSegmentsTest to storage module [kafka]

2024-09-12 Thread via GitHub
chia7712 commented on code in PR #17173: URL: https://github.com/apache/kafka/pull/17173#discussion_r1758125382 ## storage/src/test/java/org/apache/kafka/storage/internals/log/LogSegmentsTest.java: ## @@ -0,0 +1,289 @@ +/* + * Licensed to the Apache Software Foundation (ASF) und

Re: [PR] New transform: ExtractFields [kafka]

2024-09-12 Thread via GitHub
github-actions[bot] commented on PR #2880: URL: https://github.com/apache/kafka/pull/2880#issuecomment-2347969739 This PR is being marked as stale since it has not had any activity in 90 days. If you would like to keep this PR alive, please leave a comment asking for a review. If the PR

Re: [PR] KAFKA-4808 : Send of null key to a compacted topic should throw non-retriable error back to user [kafka]

2024-09-12 Thread via GitHub
github-actions[bot] commented on PR #2875: URL: https://github.com/apache/kafka/pull/2875#issuecomment-2347969719 This PR is being marked as stale since it has not had any activity in 90 days. If you would like to keep this PR alive, please leave a comment asking for a review. If the PR

Re: [PR] KAFKA-5050 add ldap authentication support on PlainSaslServer [kafka]

2024-09-12 Thread via GitHub
github-actions[bot] commented on PR #2833: URL: https://github.com/apache/kafka/pull/2833#issuecomment-2347969704 This PR is being marked as stale since it has not had any activity in 90 days. If you would like to keep this PR alive, please leave a comment asking for a review. If the PR

Re: [PR] KAFKA-4858: Broker should ignore long topic names [kafka]

2024-09-12 Thread via GitHub
github-actions[bot] commented on PR #2673: URL: https://github.com/apache/kafka/pull/2673#issuecomment-2347969650 This PR is being marked as stale since it has not had any activity in 90 days. If you would like to keep this PR alive, please leave a comment asking for a review. If the PR

Re: [PR] the kafka-server-stop.sh can not find the pids. [kafka]

2024-09-12 Thread via GitHub
github-actions[bot] commented on PR #2790: URL: https://github.com/apache/kafka/pull/2790#issuecomment-2347969689 This PR is being marked as stale since it has not had any activity in 90 days. If you would like to keep this PR alive, please leave a comment asking for a review. If the PR

Re: [PR] KAFKA-2961: Add overload for subscribing to a single partition [kafka]

2024-09-12 Thread via GitHub
github-actions[bot] commented on PR #2785: URL: https://github.com/apache/kafka/pull/2785#issuecomment-2347969673 This PR is being marked as stale since it has not had any activity in 90 days. If you would like to keep this PR alive, please leave a comment asking for a review. If the PR

Re: [PR] KAFKA-17528: Remove whitelist/blacklist from JMXReporter [kafka]

2024-09-12 Thread via GitHub
chia7712 commented on code in PR #17179: URL: https://github.com/apache/kafka/pull/17179#discussion_r1758122744 ## clients/src/main/java/org/apache/kafka/common/metrics/JmxReporter.java: ## @@ -55,10 +55,10 @@ public class JmxReporter implements MetricsReporter { public sta

Re: [PR] MINOR Add a thread dump on build timeout [kafka]

2024-09-12 Thread via GitHub
chia7712 commented on code in PR #17181: URL: https://github.com/apache/kafka/pull/17181#discussion_r1758115374 ## .github/workflows/build.yml: ## @@ -141,3 +144,11 @@ jobs: with: name: build-scan-test-${{ matrix.java }} path: ~/.gradle/build-scan-

Re: [PR] KAFKA-17508: Adding some guard for fallback deletion logic [kafka]

2024-09-12 Thread via GitHub
showuon commented on PR #17154: URL: https://github.com/apache/kafka/pull/17154#issuecomment-2347949359 Retriggering CI: https://ci-builds.apache.org/job/Kafka/job/kafka-pr/job/PR-17154/6/ -- This is an automated message from the Apache Git Service. To respond to the message, please log o

Re: [PR] KAFKA-17066: new consumer updateFetchPositions all in background thread [kafka]

2024-09-12 Thread via GitHub
chia7712 commented on code in PR #16885: URL: https://github.com/apache/kafka/pull/16885#discussion_r1758093606 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/OffsetsRequestManager.java: ## @@ -218,18 +490,17 @@ public CompletableFuture resetPositionsIfNeed

Re: [PR] MINOR Add a thread dump on build timeout [kafka]

2024-09-12 Thread via GitHub
chia7712 commented on code in PR #17181: URL: https://github.com/apache/kafka/pull/17181#discussion_r1758072782 ## .github/scripts/thread-dump.sh: ## @@ -0,0 +1,29 @@ +#!/bin/bash +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreem

Re: [PR] MINOR Add a thread dump on build timeout [kafka]

2024-09-12 Thread via GitHub
mumrah commented on code in PR #17181: URL: https://github.com/apache/kafka/pull/17181#discussion_r1758066637 ## .github/scripts/thread-dump.sh: ## @@ -0,0 +1,29 @@ +#!/bin/bash +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreemen

Re: [PR] MINOR Add a thread dump on build timeout [kafka]

2024-09-12 Thread via GitHub
mumrah commented on code in PR #17181: URL: https://github.com/apache/kafka/pull/17181#discussion_r1758033092 ## .github/workflows/build.yml: ## @@ -110,9 +110,12 @@ jobs: # --continue: Keep running even if a test fails # -PcommitId Prevent the Git SHA

Re: [PR] MINOR Add a thread dump on build timeout [kafka]

2024-09-12 Thread via GitHub
chia7712 commented on code in PR #17181: URL: https://github.com/apache/kafka/pull/17181#discussion_r1758044662 ## .github/scripts/thread-dump.sh: ## @@ -0,0 +1,29 @@ +#!/bin/bash +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreem

[jira] [Commented] (KAFKA-17531) Remove deprecates methods JoinWindows#of and #grace

2024-09-12 Thread Chia-Chuan Yu (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17531?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17881443#comment-17881443 ] Chia-Chuan Yu commented on KAFKA-17531: --- Hi, [~mjsax]  Can I have this one please

Re: [PR] MINOR Add a thread dump on build timeout [kafka]

2024-09-12 Thread via GitHub
mumrah commented on code in PR #17181: URL: https://github.com/apache/kafka/pull/17181#discussion_r1758023169 ## .github/scripts/thread-dump.sh: ## @@ -0,0 +1,29 @@ +#!/bin/bash +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreemen

[jira] [Assigned] (KAFKA-17519) Define and validate correctness of Consumer.close() and its timeout when thread is interrupted

2024-09-12 Thread PoAn Yang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17519?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] PoAn Yang reassigned KAFKA-17519: - Assignee: PoAn Yang > Define and validate correctness of Consumer.close() and its timeout when

Re: [PR] KAFKA-17508: Adding some guard for fallback deletion logic [kafka]

2024-09-12 Thread via GitHub
FrankYang0529 commented on PR #17154: URL: https://github.com/apache/kafka/pull/17154#issuecomment-2347828486 Hi @showuon, build fail in jdk 8 and scala 2.12 is fixed. Also, all failed cases in latest CI can pass on my laptop. Could you take a look? Thank you. -- This is an automated mess

[jira] [Commented] (KAFKA-17536) Ensure clear error message when "new" consumer used with incompatible cluster

2024-09-12 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17536?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17881439#comment-17881439 ] Chia-Ping Tsai commented on KAFKA-17536: +1 to this jira. The general error mess

[jira] [Commented] (KAFKA-17543) Enforce that broker.id.generation.enable is disabled when migrating to KRaft

2024-09-12 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17543?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17881438#comment-17881438 ] Chia-Ping Tsai commented on KAFKA-17543: Is this related to KAFKA-17077? I had s

Re: [PR] MINOR Add a thread dump on build timeout [kafka]

2024-09-12 Thread via GitHub
chia7712 commented on code in PR #17181: URL: https://github.com/apache/kafka/pull/17181#discussion_r1757888591 ## .github/workflows/build.yml: ## @@ -110,9 +110,12 @@ jobs: # --continue: Keep running even if a test fails # -PcommitId Prevent the Git S

Re: [PR] KAFKA-17154: New consumer subscribe may join group without a call to consumer.poll [kafka]

2024-09-12 Thread via GitHub
TaiJuWu commented on code in PR #17165: URL: https://github.com/apache/kafka/pull/17165#discussion_r1757861442 ## clients/src/test/java/org/apache/kafka/clients/consumer/KafkaConsumerTest.java: ## @@ -3443,6 +3443,33 @@ public void testPreventMultiThread(GroupProtocol groupProt

Re: [PR] MINOR: test NoJoiningGroupWithoutPoll [kafka]

2024-09-12 Thread via GitHub
TaiJuWu closed pull request #17175: MINOR: test NoJoiningGroupWithoutPoll URL: https://github.com/apache/kafka/pull/17175 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To uns

Re: [PR] KAFKA-17154: New consumer subscribe may join group without a call to consumer.poll [kafka]

2024-09-12 Thread via GitHub
TaiJuWu commented on PR #17165: URL: https://github.com/apache/kafka/pull/17165#issuecomment-2347750081 > > I opened a PR for this behavior. Could you take a look? Thanks a lot! > > #17175 > > Hi @TaiJuWu, thanks for the PR. I also have a similar test case `testPollSendRequestForRe

Re: [PR] KAFKA-17527: Fix NPE for null RecordContext [kafka]

2024-09-12 Thread via GitHub
mjsax commented on code in PR #17169: URL: https://github.com/apache/kafka/pull/17169#discussion_r1757814889 ## streams/src/main/java/org/apache/kafka/streams/processor/internals/RecordCollectorImpl.java: ## @@ -252,40 +254,55 @@ public void send(final String topic, fi

Re: [PR] KAFKA-17527: Fix NPE for null RecordContext [kafka]

2024-09-12 Thread via GitHub
mjsax commented on code in PR #17169: URL: https://github.com/apache/kafka/pull/17169#discussion_r1757807427 ## streams/src/main/java/org/apache/kafka/streams/processor/internals/RecordCollectorImpl.java: ## @@ -252,40 +254,55 @@ public void send(final String topic, fi

Re: [PR] KAFKA-15344: Streams task should cache consumer nextOffsets [kafka]

2024-09-12 Thread via GitHub
mjsax commented on code in PR #17091: URL: https://github.com/apache/kafka/pull/17091#discussion_r1757785099 ## streams/src/main/java/org/apache/kafka/streams/processor/internals/AbstractPartitionGroup.java: ## @@ -56,6 +57,8 @@ abstract class AbstractPartitionGroup { abs

Re: [PR] KAFKA-15344: Streams task should cache consumer nextOffsets [kafka]

2024-09-12 Thread via GitHub
mjsax commented on code in PR #17091: URL: https://github.com/apache/kafka/pull/17091#discussion_r1757779041 ## clients/src/main/java/org/apache/kafka/clients/consumer/ConsumerRecords.java: ## @@ -90,6 +91,15 @@ public int count() { return count; } +public Ma

Re: [PR] KAFKA-15344: Streams task should cache consumer nextOffsets [kafka]

2024-09-12 Thread via GitHub
mjsax commented on code in PR #17091: URL: https://github.com/apache/kafka/pull/17091#discussion_r1757772573 ## streams/src/main/java/org/apache/kafka/streams/processor/internals/SynchronizedPartitionGroup.java: ## @@ -70,6 +71,11 @@ synchronized Long headRecordOffset(final Topi

Re: [PR] KAFKA-15344: Streams task should cache consumer nextOffsets [kafka]

2024-09-12 Thread via GitHub
mjsax commented on code in PR #17091: URL: https://github.com/apache/kafka/pull/17091#discussion_r1757772573 ## streams/src/main/java/org/apache/kafka/streams/processor/internals/SynchronizedPartitionGroup.java: ## @@ -70,6 +71,11 @@ synchronized Long headRecordOffset(final Topi

Re: [PR] KAFKA-15344: Streams task should cache consumer nextOffsets [kafka]

2024-09-12 Thread via GitHub
mjsax commented on code in PR #17091: URL: https://github.com/apache/kafka/pull/17091#discussion_r1757763338 ## streams/src/main/java/org/apache/kafka/streams/processor/internals/RecordQueue.java: ## @@ -181,6 +182,11 @@ public Long headRecordOffset() { return headRecor

Re: [PR] KAFKA-15344: Streams task should cache consumer nextOffsets [kafka]

2024-09-12 Thread via GitHub
mjsax commented on code in PR #17091: URL: https://github.com/apache/kafka/pull/17091#discussion_r1757750409 ## streams/src/main/java/org/apache/kafka/streams/processor/internals/TaskManager.java: ## @@ -1820,6 +1820,7 @@ void addRecordsToTasks(final ConsumerRecords records) {

[jira] [Assigned] (KAFKA-17542) Use actions/labeler for automatic PR labeling

2024-09-12 Thread TaiJuWu (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17542?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] TaiJuWu reassigned KAFKA-17542: --- Assignee: TaiJuWu > Use actions/labeler for automatic PR labeling > ---

Re: [PR] MINOR: improve RecordCollectorImpl [kafka]

2024-09-12 Thread via GitHub
mjsax commented on code in PR #17185: URL: https://github.com/apache/kafka/pull/17185#discussion_r1757741092 ## streams/src/main/java/org/apache/kafka/streams/processor/internals/RecordCollectorImpl.java: ## @@ -529,7 +528,7 @@ private void checkForException() { final K

Re: [PR] MINOR: improve RecordCollectorImpl [kafka]

2024-09-12 Thread via GitHub
mjsax commented on code in PR #17185: URL: https://github.com/apache/kafka/pull/17185#discussion_r1757740151 ## streams/src/main/java/org/apache/kafka/streams/processor/internals/RecordCollectorImpl.java: ## @@ -81,7 +81,7 @@ public class RecordCollectorImpl implements RecordCol

[PR] MINOR: improve RecordCollectorImpl [kafka]

2024-09-12 Thread via GitHub
mjsax opened a new pull request, #17185: URL: https://github.com/apache/kafka/pull/17185 Found this while working on https://github.com/apache/kafka/pull/17169, but did not want to piggy-back this change to the other PR but isolate as it's unrelated cleanup. -- This is an automated messa

Re: [PR] KAFKA-16985: Ensure consumer sends leave request on close even if interrupted [kafka]

2024-09-12 Thread via GitHub
kirktrue commented on PR #16686: URL: https://github.com/apache/kafka/pull/16686#issuecomment-2347433996 Added the parameterized test `testCloseWithInterrupt()`. It validates two cases for when `close()` is called after an interrupt: 1. `close(1000)` does invoke the `ConsumerRebalance

Re: [PR] KAFKA-17527: Fix NPE for null RecordContext [kafka]

2024-09-12 Thread via GitHub
mjsax commented on code in PR #17169: URL: https://github.com/apache/kafka/pull/17169#discussion_r1757696994 ## streams/src/main/java/org/apache/kafka/streams/processor/internals/RecordCollectorImpl.java: ## @@ -298,19 +315,19 @@ private void handleException(final ProductionEx

[jira] [Assigned] (KAFKA-17518) AsyncKafkaConsumer cannot reliably leave group when closed with small timeout

2024-09-12 Thread TengYao Chi (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17518?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] TengYao Chi reassigned KAFKA-17518: --- Assignee: TengYao Chi > AsyncKafkaConsumer cannot reliably leave group when closed with sma

[jira] [Commented] (KAFKA-17542) Use actions/labeler for automatic PR labeling

2024-09-12 Thread David Arthur (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17542?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17881424#comment-17881424 ] David Arthur commented on KAFKA-17542: -- [~taijuwu] go for it!  > Use actions/label

[jira] [Created] (KAFKA-17543) Enforce that broker.id.generation.enable is disabled when migrating to KRaft

2024-09-12 Thread Colin McCabe (Jira)
Colin McCabe created KAFKA-17543: Summary: Enforce that broker.id.generation.enable is disabled when migrating to KRaft Key: KAFKA-17543 URL: https://issues.apache.org/jira/browse/KAFKA-17543 Project:

Re: [PR] KAFKA-17527: Fix NPE for null RecordContext [kafka]

2024-09-12 Thread via GitHub
mjsax commented on code in PR #17169: URL: https://github.com/apache/kafka/pull/17169#discussion_r1757696994 ## streams/src/main/java/org/apache/kafka/streams/processor/internals/RecordCollectorImpl.java: ## @@ -298,19 +315,19 @@ private void handleException(final ProductionEx

Re: [PR] KAFKA-17527: Fix NPE for null RecordContext [kafka]

2024-09-12 Thread via GitHub
mjsax commented on code in PR #17169: URL: https://github.com/apache/kafka/pull/17169#discussion_r1757686961 ## streams/src/main/java/org/apache/kafka/streams/errors/ErrorHandlerContext.java: ## @@ -42,6 +42,8 @@ public interface ErrorHandlerContext { * {@link org.apache.

Re: [PR] KAFKA-12827 Remove Deprecated method KafkaStreams#setUncaughtExceptionHandler [kafka]

2024-09-12 Thread via GitHub
mjsax commented on code in PR #16988: URL: https://github.com/apache/kafka/pull/16988#discussion_r1757680374 ## streams/src/test/java/org/apache/kafka/streams/integration/QueryableStateIntegrationTest.java: ## @@ -1085,77 +1086,72 @@ public void shouldAllowToQueryAfterThreadDied

Re: [PR] KAFKA-12827 Remove Deprecated method KafkaStreams#setUncaughtExceptionHandler [kafka]

2024-09-12 Thread via GitHub
mjsax commented on code in PR #16988: URL: https://github.com/apache/kafka/pull/16988#discussion_r1757679681 ## streams/src/test/java/org/apache/kafka/streams/integration/QueryableStateIntegrationTest.java: ## @@ -1085,77 +1086,72 @@ public void shouldAllowToQueryAfterThreadDied

Re: [PR] KAFKA-12827 Remove Deprecated method KafkaStreams#setUncaughtExceptionHandler [kafka]

2024-09-12 Thread via GitHub
mjsax commented on code in PR #16988: URL: https://github.com/apache/kafka/pull/16988#discussion_r1757678783 ## streams/src/test/java/org/apache/kafka/streams/integration/QueryableStateIntegrationTest.java: ## @@ -1085,77 +1086,72 @@ public void shouldAllowToQueryAfterThreadDied

Re: [PR] KAFKA-16379: Coordinator event queue, processing, flush, purgatory time histograms [kafka]

2024-09-12 Thread via GitHub
dimitarndimitrov commented on code in PR #16949: URL: https://github.com/apache/kafka/pull/16949#discussion_r1757664858 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/metrics/HdrHistogram.java: ## @@ -0,0 +1,145 @@ +/* + * Licensed to the Apache Software F

[jira] [Commented] (KAFKA-17519) Define and validate correctness of Consumer.close() and its timeout when thread is interrupted

2024-09-12 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17519?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17881422#comment-17881422 ] Kirk True commented on KAFKA-17519: --- [~yangpoan]—it's yours if you want it. Thanks! >

[jira] [Updated] (KAFKA-17535) Flaky testCloseNoWait in KafkaConsumerTest for Classic Consumer

2024-09-12 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17535?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True updated KAFKA-17535: -- Component/s: clients > Flaky testCloseNoWait in KafkaConsumerTest for Classic Consumer >

[jira] [Commented] (KAFKA-17518) AsyncKafkaConsumer cannot reliably leave group when closed with small timeout

2024-09-12 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17518?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17881421#comment-17881421 ] Kirk True commented on KAFKA-17518: --- [~frankvicky]—yes, you're free to take it. Thanks

Re: [PR] MINOR: Fix a race and add JMH bench for HdrHistogram [kafka]

2024-09-12 Thread via GitHub
dimitarndimitrov commented on code in PR #17184: URL: https://github.com/apache/kafka/pull/17184#discussion_r1757632083 ## jmh-benchmarks/src/main/java/org/apache/kafka/jmh/metrics/HistogramBenchmark.java: ## @@ -0,0 +1,122 @@ +/* + * Licensed to the Apache Software Foundation (

Re: [PR] MINOR: Fix a race and add JMH bench for HdrHistogram [kafka]

2024-09-12 Thread via GitHub
dimitarndimitrov commented on PR #17184: URL: https://github.com/apache/kafka/pull/17184#issuecomment-2347304340 > because on my development machine I wasn't able to see consistent reproducibility without more sophisticated testing tools like jcstress or Byteman/BMUnit. After a bunch

Re: [PR] KAFKA-17509: Introduce a delayed action queue to complete purgatory actions outside purgatory. [kafka]

2024-09-12 Thread via GitHub
mumrah commented on code in PR #17177: URL: https://github.com/apache/kafka/pull/17177#discussion_r1757547468 ## core/src/main/java/kafka/server/share/DelayedShareFetch.java: ## @@ -126,6 +139,16 @@ public void onComplete() { } // Releas

Re: [PR] KAFKA-17509: Introduce a delayed action queue to complete purgatory actions outside purgatory. [kafka]

2024-09-12 Thread via GitHub
mumrah commented on code in PR #17177: URL: https://github.com/apache/kafka/pull/17177#discussion_r1757556564 ## core/src/main/java/kafka/server/share/DelayedShareFetch.java: ## @@ -126,6 +139,16 @@ public void onComplete() { } // Releas

[jira] [Commented] (KAFKA-17542) Use actions/labeler for automatic PR labeling

2024-09-12 Thread TaiJuWu (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17542?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17881416#comment-17881416 ] TaiJuWu commented on KAFKA-17542: - Hi [~davidarthur] , if you are not working for this,

Re: [PR] KAFKA-17502: Modified commitSync() and close() handling in clients [kafka]

2024-09-12 Thread via GitHub
ShivsundarR closed pull request #17136: KAFKA-17502: Modified commitSync() and close() handling in clients URL: https://github.com/apache/kafka/pull/17136 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to g

[PR] KAFKA-17502: Modified commitSync() and close() handling in clients [kafka]

2024-09-12 Thread via GitHub
ShivsundarR opened a new pull request, #17136: URL: https://github.com/apache/kafka/pull/17136 *What* Currently the code in `ShareConsumeRequestManager` works on the basis that there can only be one `commitSync()`/`close()` at a time. But there is a chance these calls timeout on the appl

Re: [PR] KAFKA-10551: Add topic id support to produce request and response [kafka]

2024-09-12 Thread via GitHub
junrao commented on code in PR #15968: URL: https://github.com/apache/kafka/pull/15968#discussion_r1757542203 ## core/src/main/scala/kafka/server/ReplicaManager.scala: ## @@ -846,17 +852,16 @@ class ReplicaManager(val config: KafkaConfig, s"Unable to verify the

Re: [PR] KAFKA-16379: Coordinator event queue, processing, flush, purgatory time histograms [kafka]

2024-09-12 Thread via GitHub
dimitarndimitrov commented on code in PR #16949: URL: https://github.com/apache/kafka/pull/16949#discussion_r1757532021 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/metrics/HdrHistogram.java: ## @@ -0,0 +1,145 @@ +/* + * Licensed to the Apache Software F

[PR] MINOR: Fix a race and add JMH bench for HdrHistogram [kafka]

2024-09-12 Thread via GitHub
dimitarndimitrov opened a new pull request, #17184: URL: https://github.com/apache/kafka/pull/17184 ### About Addresses the race described [here](https://github.com/apache/kafka/pull/16949#discussion_r1750273695) and adds a JMH benchmark comparing `HdrHistogram` with Yammer's histogram.

Re: [PR] KAFKA-16985: Ensure consumer sends leave request on close even if interrupted [kafka]

2024-09-12 Thread via GitHub
lianetm commented on PR #16686: URL: https://github.com/apache/kafka/pull/16686#issuecomment-2347060544 Hey @kirktrue, thanks for the updates! only comment left above, and: should we add some unit tests for this change? (I guess similar to the existing [testPollThrowsInterruptExceptionIfInt

Re: [PR] KAFKA-17524: Add timeout to StreamThreadTest [kafka]

2024-09-12 Thread via GitHub
mumrah merged PR #17180: URL: https://github.com/apache/kafka/pull/17180 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.o

Re: [PR] KAFKA-17524: Add timeout to StreamThreadTest [kafka]

2024-09-12 Thread via GitHub
mumrah commented on PR #17180: URL: https://github.com/apache/kafka/pull/17180#issuecomment-2347058928 Well, no timeouts in this build. I pulled it locally and verified it works as expected. Let's just merge this and watch the builds. -- This is an automated message from the Apache Git Se

Re: [PR] KAFKA-16985: Ensure consumer sends leave request on close even if interrupted [kafka]

2024-09-12 Thread via GitHub
lianetm commented on code in PR #16686: URL: https://github.com/apache/kafka/pull/16686#discussion_r1757418153 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/AsyncKafkaConsumer.java: ## @@ -1258,9 +1259,11 @@ private void close(Duration timeout, boolean sw

Re: [PR] KAFKA-16985: Ensure consumer sends leave request on close even if interrupted [kafka]

2024-09-12 Thread via GitHub
lianetm commented on code in PR #16686: URL: https://github.com/apache/kafka/pull/16686#discussion_r1757418153 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/AsyncKafkaConsumer.java: ## @@ -1258,9 +1259,11 @@ private void close(Duration timeout, boolean sw

Re: [PR] KAFKA-16985: Ensure consumer sends leave request on close even if interrupted [kafka]

2024-09-12 Thread via GitHub
lianetm commented on code in PR #16686: URL: https://github.com/apache/kafka/pull/16686#discussion_r1757418153 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/AsyncKafkaConsumer.java: ## @@ -1258,9 +1259,11 @@ private void close(Duration timeout, boolean sw

Re: [PR] KAFKA-17509: Introduce a delayed action queue to complete purgatory actions outside purgatory. [kafka]

2024-09-12 Thread via GitHub
adixitconfluent commented on PR #17177: URL: https://github.com/apache/kafka/pull/17177#issuecomment-2347013536 I've checked the 3 test failures. They are unrelated to the PR. I ran all of them locally and they all passed. -- This is an automated message from the Apache Git Service. To re

Re: [PR] KAFKA-16963 followup: Ducktape test for KIP-853 [kafka]

2024-09-12 Thread via GitHub
jsancio commented on code in PR #17146: URL: https://github.com/apache/kafka/pull/17146#discussion_r1757400655 ## tests/kafkatest/tests/core/quorum_reconfiguration_test.py: ## @@ -46,54 +50,67 @@ def setUp(self): self.num_producers = 1 self.num_consumers = 1

[jira] [Commented] (KAFKA-16143) New JMX metrics for AsyncKafkaConsumer

2024-09-12 Thread Lianet Magrans (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16143?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17881394#comment-17881394 ] Lianet Magrans commented on KAFKA-16143: Thanks [~yangpoan] , I assigned it to y

[jira] [Assigned] (KAFKA-16143) New JMX metrics for AsyncKafkaConsumer

2024-09-12 Thread Lianet Magrans (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16143?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lianet Magrans reassigned KAFKA-16143: -- Assignee: PoAn Yang (was: Brenden DeLuna) > New JMX metrics for AsyncKafkaConsumer >

[jira] [Created] (KAFKA-17542) Use actions/labeler for automatic PR labeling

2024-09-12 Thread David Arthur (Jira)
David Arthur created KAFKA-17542: Summary: Use actions/labeler for automatic PR labeling Key: KAFKA-17542 URL: https://issues.apache.org/jira/browse/KAFKA-17542 Project: Kafka Issue Type: Tas

Re: [PR] MINOR: Update TopologyTest [kafka]

2024-09-12 Thread via GitHub
mjsax commented on PR #17006: URL: https://github.com/apache/kafka/pull/17006#issuecomment-2346985487 @caioguedes -- Just discovered this PR. It does show merge conflicts. Can you rebase it (even if I am wondering if https://github.com/apache/kafka/pull/17126 did not resolve this already?

[jira] [Updated] (KAFKA-16143) New JMX metrics for AsyncKafkaConsumer

2024-09-12 Thread Lianet Magrans (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16143?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lianet Magrans updated KAFKA-16143: --- Labels: consumer-threading-refactor kip-848-client-support metrics needs-kip (was: kip-848-

[jira] [Created] (KAFKA-17541) Improve handling of delivery count

2024-09-12 Thread Andrew Schofield (Jira)
Andrew Schofield created KAFKA-17541: Summary: Improve handling of delivery count Key: KAFKA-17541 URL: https://issues.apache.org/jira/browse/KAFKA-17541 Project: Kafka Issue Type: Sub-ta

[jira] [Created] (KAFKA-17540) Create floating tag on trunk for CI

2024-09-12 Thread David Arthur (Jira)
David Arthur created KAFKA-17540: Summary: Create floating tag on trunk for CI Key: KAFKA-17540 URL: https://issues.apache.org/jira/browse/KAFKA-17540 Project: Kafka Issue Type: Task

[jira] [Updated] (KAFKA-17540) Create floating tag on trunk for CI cache

2024-09-12 Thread David Arthur (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17540?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Arthur updated KAFKA-17540: - Summary: Create floating tag on trunk for CI cache (was: Create floating tag on trunk for CI)

Re: [PR] MINOR: Need to split the controller bootstrap servers on ',' in list comprehenson [kafka]

2024-09-12 Thread via GitHub
bbejeck commented on PR #17183: URL: https://github.com/apache/kafka/pull/17183#issuecomment-2346977089 \cc @ahuang98 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To un

[jira] [Assigned] (KAFKA-17510) Refactor code between SharePartitionManager and DelayedShareFetch for share partition initialization

2024-09-12 Thread Andrew Schofield (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17510?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Schofield reassigned KAFKA-17510: Assignee: Apoorv Mittal > Refactor code between SharePartitionManager and Delayed

[jira] [Created] (KAFKA-17539) Implement registerMetricsForSubscription

2024-09-12 Thread Andrew Schofield (Jira)
Andrew Schofield created KAFKA-17539: Summary: Implement registerMetricsForSubscription Key: KAFKA-17539 URL: https://issues.apache.org/jira/browse/KAFKA-17539 Project: Kafka Issue Type:

[PR] MINOR: Need to split the controller bootstrap servers on ',' in list comprehenson [kafka]

2024-09-12 Thread via GitHub
bbejeck opened a new pull request, #17183: URL: https://github.com/apache/kafka/pull/17183 In `kafka.py` line 876, we create a delimited string from a list comprehension, but the input is a string itself, so each character gets appended vs. the bootstrap server string of `host:port`. This

[jira] [Closed] (KAFKA-8666) Improve Documentation on usage of Materialized config object

2024-09-12 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-8666?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias J. Sax closed KAFKA-8666. -- > Improve Documentation on usage of Materialized config object > --

[jira] [Commented] (KAFKA-8666) Improve Documentation on usage of Materialized config object

2024-09-12 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-8666?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17881388#comment-17881388 ] Matthias J. Sax commented on KAFKA-8666: Sure. We use "Resolved" and "Closed" int

Re: [PR] Refactored share module classes and minor fix [kafka]

2024-09-12 Thread via GitHub
mumrah merged PR #17178: URL: https://github.com/apache/kafka/pull/17178 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.o

[jira] [Resolved] (KAFKA-17427) Fix leaking *_DOC variables in StreamsConfig

2024-09-12 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17427?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias J. Sax resolved KAFKA-17427. - Fix Version/s: 4.0.0 Resolution: Fixed > Fix leaking *_DOC variables in StreamsCo

[jira] [Updated] (KAFKA-17538) Make deprecated *_DOC variable private/package-private

2024-09-12 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17538?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias J. Sax updated KAFKA-17538: Summary: Make deprecated *_DOC variable private/package-private (was: Make deprecated *_D

[jira] [Created] (KAFKA-17538) Make deprecated *_DOC variable private/package-privste

2024-09-12 Thread Matthias J. Sax (Jira)
Matthias J. Sax created KAFKA-17538: --- Summary: Make deprecated *_DOC variable private/package-privste Key: KAFKA-17538 URL: https://issues.apache.org/jira/browse/KAFKA-17538 Project: Kafka

Re: [PR] KAFKA-17427: Deprecate leaking *_DOC variables in StreamsConfig [kafka]

2024-09-12 Thread via GitHub
mjsax commented on PR #17171: URL: https://github.com/apache/kafka/pull/17171#issuecomment-2346853980 Thanks for the KIP and PR. Merged to `trunk`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

Re: [PR] KAFKA-17427: Deprecate leaking *_DOC variables in StreamsConfig [kafka]

2024-09-12 Thread via GitHub
mjsax merged PR #17171: URL: https://github.com/apache/kafka/pull/17171 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.or

[jira] [Updated] (KAFKA-17427) Fix leaking *_DOC variables in StreamsConfig

2024-09-12 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17427?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias J. Sax updated KAFKA-17427: Description: StreamsConfigs has two variables per config, one for the config name and one

[jira] [Updated] (KAFKA-17427) Fix leaking *_DOC variables in StreamsConfig

2024-09-12 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17427?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias J. Sax updated KAFKA-17427: Labels: kip (was: needs-kip) > Fix leaking *_DOC variables in StreamsConfig > ---

  1   2   >