[jira] [Updated] (KAFKA-17859) Bug

2024-10-22 Thread thanhnd1996 (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17859?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] thanhnd1996 updated KAFKA-17859: Attachment: (was: Alert-ERROR-Elasticsearch.png) > Bug > --- > > Key: KAFKA-17

[jira] [Updated] (KAFKA-17859) Bug

2024-10-22 Thread thanhnd1996 (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17859?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] thanhnd1996 updated KAFKA-17859: Attachment: (was: failed-producer-init-from-service.png) > Bug > --- > > Key:

[jira] [Created] (KAFKA-17859) Bug

2024-10-22 Thread thanhnd1996 (Jira)
thanhnd1996 created KAFKA-17859: --- Summary: Bug Key: KAFKA-17859 URL: https://issues.apache.org/jira/browse/KAFKA-17859 Project: Kafka Issue Type: Bug Components: controller Affect

Re: [PR] MINOR: Fix the valid values generated doc of the RLM thread pools [kafka]

2024-10-22 Thread via GitHub
fvaleri commented on code in PR #17575: URL: https://github.com/apache/kafka/pull/17575#discussion_r1811944283 ## storage/src/main/java/org/apache/kafka/server/log/remote/storage/RemoteLogManagerConfig.java: ## @@ -104,7 +104,7 @@ public final class RemoteLogManagerConfig {

Re: [PR] MINOR: Fix the valid values generated doc of the RLM thread pools [kafka]

2024-10-22 Thread via GitHub
showuon commented on code in PR #17575: URL: https://github.com/apache/kafka/pull/17575#discussion_r1811933891 ## storage/src/main/java/org/apache/kafka/server/log/remote/storage/RemoteLogManagerConfig.java: ## @@ -104,7 +104,7 @@ public final class RemoteLogManagerConfig {

Re: [PR] MINOR: Fix the valid values generated doc of the RLM thread pools [kafka]

2024-10-22 Thread via GitHub
satishd commented on code in PR #17575: URL: https://github.com/apache/kafka/pull/17575#discussion_r1811927922 ## storage/src/main/java/org/apache/kafka/server/log/remote/storage/RemoteLogManagerConfig.java: ## @@ -104,7 +104,7 @@ public final class RemoteLogManagerConfig {

[PR] KAFKA-16966:Allow offset commit fetch to reuse previous request if partitions are a subset [kafka]

2024-10-22 Thread via GitHub
TaiJuWu opened a new pull request, #17584: URL: https://github.com/apache/kafka/pull/17584 jira: https://issues.apache.org/jira/browse/KAFKA-16966 ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation - [ ] Verify test coverage and CI buil

Re: [PR] MINOR: Fix the valid values generated doc of the RLM thread pools [kafka]

2024-10-22 Thread via GitHub
fvaleri commented on code in PR #17575: URL: https://github.com/apache/kafka/pull/17575#discussion_r1811918428 ## storage/src/main/java/org/apache/kafka/server/log/remote/storage/RemoteLogManagerConfig.java: ## @@ -104,7 +104,7 @@ public final class RemoteLogManagerConfig {

Re: [PR] KAFKA-17848: Fixing NPE in delayed share fetch [kafka]

2024-10-22 Thread via GitHub
adixitconfluent commented on code in PR #17583: URL: https://github.com/apache/kafka/pull/17583#discussion_r1811860775 ## core/src/main/java/kafka/server/share/DelayedShareFetch.java: ## @@ -79,16 +79,16 @@ public void onExpiration() { */ @Override public void on

Re: [PR] KAFKA-9366: Upgrade log4j to log4j2 [kafka]

2024-10-22 Thread via GitHub
frankvicky commented on PR #17373: URL: https://github.com/apache/kafka/pull/17373#issuecomment-2430832465 > > About zk stuff, I'm think about removing the zk configurations might be better handled as a follow-up PR. WDYT? > > Sounds good to me. But if we decided to remove them later,

[jira] [Created] (KAFKA-17858) Remove ZK-related configuration from the log4j configuration.

2024-10-22 Thread TengYao Chi (Jira)
TengYao Chi created KAFKA-17858: --- Summary: Remove ZK-related configuration from the log4j configuration. Key: KAFKA-17858 URL: https://issues.apache.org/jira/browse/KAFKA-17858 Project: Kafka

Re: [PR] KAFKA-9366: Upgrade log4j to log4j2 [kafka]

2024-10-22 Thread via GitHub
showuon commented on code in PR #17373: URL: https://github.com/apache/kafka/pull/17373#discussion_r1811789962 ## config/connect-log4j2.properties: ## @@ -0,0 +1,39 @@ +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements. See t

Re: [PR] KAFKA-9366: Upgrade log4j to log4j2 [kafka]

2024-10-22 Thread via GitHub
frankvicky commented on code in PR #17373: URL: https://github.com/apache/kafka/pull/17373#discussion_r1811787630 ## build.gradle: ## @@ -167,8 +167,10 @@ allprojects { // ZooKeeper (potentially older and containing CVEs) libs.nettyHandler, libs.

Re: [PR] KAFKA-9366: Upgrade log4j to log4j2 [kafka]

2024-10-22 Thread via GitHub
showuon commented on PR #17373: URL: https://github.com/apache/kafka/pull/17373#issuecomment-2430811748 > About zk stuff, I'm think about removing the zk configurations might be better handled as a follow-up PR. WDYT? Sounds good to me. But if we decided to remove them later, please o

Re: [PR] KAFKA-9366: Upgrade log4j to log4j2 [kafka]

2024-10-22 Thread via GitHub
showuon commented on code in PR #17373: URL: https://github.com/apache/kafka/pull/17373#discussion_r1811786044 ## build.gradle: ## @@ -167,8 +167,10 @@ allprojects { // ZooKeeper (potentially older and containing CVEs) libs.nettyHandler, libs.net

Re: [PR] KAFKA-15995: Initial API + make Producer/Consumer plugins Monitorable [kafka]

2024-10-22 Thread via GitHub
showuon commented on code in PR #17511: URL: https://github.com/apache/kafka/pull/17511#discussion_r1811781412 ## clients/src/main/java/org/apache/kafka/common/internals/Plugin.java: ## @@ -0,0 +1,78 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more +

Re: [PR] KAFKA-17787: Removed --zookeeper option and logic from ConfigCommand [kafka]

2024-10-22 Thread via GitHub
ChengyanOo commented on PR #17507: URL: https://github.com/apache/kafka/pull/17507#issuecomment-2430802741 > There's a spotless failure: https://github.com/apache/kafka/actions/runs/11431595728/job/31800811677?pr=17507, can you fix it? Sorry I was sick for the past couple of days, I'

Re: [PR] KAFKA-15995: Initial API + make Producer/Consumer plugins Monitorable [kafka]

2024-10-22 Thread via GitHub
showuon commented on code in PR #17511: URL: https://github.com/apache/kafka/pull/17511#discussion_r1811774020 ## clients/src/test/java/org/apache/kafka/common/internals/PluginTest.java: ## @@ -0,0 +1,124 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or m

Re: [PR] MINOR: Fix the valid values generated doc of the RLM thread pools [kafka]

2024-10-22 Thread via GitHub
showuon commented on code in PR #17575: URL: https://github.com/apache/kafka/pull/17575#discussion_r1811764255 ## storage/src/main/java/org/apache/kafka/server/log/remote/storage/RemoteLogManagerConfig.java: ## @@ -104,7 +104,7 @@ public final class RemoteLogManagerConfig {

Re: [PR] MINOR: Fix the valid values generated doc of the RLM thread pools [kafka]

2024-10-22 Thread via GitHub
showuon commented on code in PR #17575: URL: https://github.com/apache/kafka/pull/17575#discussion_r1811764255 ## storage/src/main/java/org/apache/kafka/server/log/remote/storage/RemoteLogManagerConfig.java: ## @@ -104,7 +104,7 @@ public final class RemoteLogManagerConfig {

Re: [PR] KAFKA-17847: Avoid the extra bytes copy when compressing telemetry payload [kafka]

2024-10-22 Thread via GitHub
clarkwtc commented on code in PR #17578: URL: https://github.com/apache/kafka/pull/17578#discussion_r1811683401 ## clients/src/main/java/org/apache/kafka/common/telemetry/internals/ClientTelemetryReporter.java: ## @@ -707,7 +708,8 @@ private Optional> createPushRequest(ClientTe

Re: [PR] KAFKA-17846: ClientTelemetryReporter does not log trace-level message [kafka]

2024-10-22 Thread via GitHub
clarkwtc commented on code in PR #17570: URL: https://github.com/apache/kafka/pull/17570#discussion_r1811669532 ## clients/src/main/java/org/apache/kafka/common/telemetry/internals/ClientTelemetryReporter.java: ## @@ -337,33 +336,33 @@ public long timeToNextUpdate(long requestTi

[jira] [Comment Edited] (KAFKA-17804) optimize ReplicaManager.completeDelayedOperationsWhenNotPartitionLeader

2024-10-22 Thread kangning.li (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17804?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17892027#comment-17892027 ] kangning.li edited comment on KAFKA-17804 at 10/23/24 2:04 AM: ---

[jira] [Comment Edited] (KAFKA-17804) optimize ReplicaManager.completeDelayedOperationsWhenNotPartitionLeader

2024-10-22 Thread kangning.li (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17804?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17892027#comment-17892027 ] kangning.li edited comment on KAFKA-17804 at 10/23/24 2:04 AM: ---

[jira] [Comment Edited] (KAFKA-17804) optimize ReplicaManager.completeDelayedOperationsWhenNotPartitionLeader

2024-10-22 Thread kangning.li (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17804?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17892027#comment-17892027 ] kangning.li edited comment on KAFKA-17804 at 10/23/24 2:02 AM: ---

[jira] [Comment Edited] (KAFKA-17804) optimize ReplicaManager.completeDelayedOperationsWhenNotPartitionLeader

2024-10-22 Thread kangning.li (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17804?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17892027#comment-17892027 ] kangning.li edited comment on KAFKA-17804 at 10/23/24 2:01 AM: ---

[jira] [Comment Edited] (KAFKA-17804) optimize ReplicaManager.completeDelayedOperationsWhenNotPartitionLeader

2024-10-22 Thread kangning.li (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17804?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17892027#comment-17892027 ] kangning.li edited comment on KAFKA-17804 at 10/23/24 2:01 AM: ---

[jira] [Commented] (KAFKA-17804) optimize ReplicaManager.completeDelayedOperationsWhenNotPartitionLeader

2024-10-22 Thread kangning.li (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17804?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17892027#comment-17892027 ] kangning.li commented on KAFKA-17804: - Hi [~junrao] , I have some thoughts on this i

[jira] [Commented] (KAFKA-15284) Implement GroupProtocolResolver to dynamically determine consumer group protocol

2024-10-22 Thread PoAn Yang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15284?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17892018#comment-17892018 ] PoAn Yang commented on KAFKA-15284: --- Hi [~kirktrue], I saw you reopen this issue. Is a

[jira] [Commented] (KAFKA-17857) Move AbstractResetIntegrationTest and subclasses to tools

2024-10-22 Thread Kuan Po Tseng (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17857?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17892017#comment-17892017 ] Kuan Po Tseng commented on KAFKA-17857: --- gentle ping [~gharris1727] , can I take o

Re: [PR] MINOR: Use JDK 11 in Vagrant after dropping JDK 8 [kafka]

2024-10-22 Thread via GitHub
jolshan commented on PR #17576: URL: https://github.com/apache/kafka/pull/17576#issuecomment-2430540041 I wasn't sure if there would be any incompatibilities if we drop older java versions with some of the older versions of Kafka used in the tests. But I suppose if we do see issues, maybe w

Re: [PR] KAFKA-16437 - Upgrade to Jakarta and Jetty 12 (KIP-1032) [kafka]

2024-10-22 Thread via GitHub
cshannon commented on code in PR #16754: URL: https://github.com/apache/kafka/pull/16754#discussion_r1811569693 ## build.gradle: ## @@ -318,6 +318,18 @@ subprojects { options.compilerArgs << "-Werror" options.release = minJavaVersion addParametersForTests(name, op

Re: [PR] KAFKA-17248 - KIP 1076 implementation [kafka]

2024-10-22 Thread via GitHub
apoorvmittal10 commented on code in PR #17021: URL: https://github.com/apache/kafka/pull/17021#discussion_r1811538931 ## build.gradle: ## @@ -2638,6 +2638,7 @@ project(':streams') { testImplementation libs.mockitoCore testImplementation libs.mockitoJunitJupiter // supp

Re: [PR] KAFKA-17848: Fixing NPE in delayed share fetch [kafka]

2024-10-22 Thread via GitHub
apoorvmittal10 commented on PR #17583: URL: https://github.com/apache/kafka/pull/17583#issuecomment-2430488262 @junrao For my understanding, what can trigger `onComplete` without invoking `tryComplete`? Is it the number of requests that can be in purgatory? I was doing 10 share consumers pa

Re: [PR] KAFKA-17774: Adding capability to handle max fetch records in Share Fetch (KIP-932) [kafka]

2024-10-22 Thread via GitHub
apoorvmittal10 commented on code in PR #17322: URL: https://github.com/apache/kafka/pull/17322#discussion_r1811547391 ## core/src/main/java/kafka/server/share/SharePartition.java: ## @@ -1138,6 +1185,7 @@ private void acquireSubsetBatchRecords( } finally {

Re: [PR] KAFKA-17774: Adding capability to handle max fetch records in Share Fetch (KIP-932) [kafka]

2024-10-22 Thread via GitHub
apoorvmittal10 commented on code in PR #17322: URL: https://github.com/apache/kafka/pull/17322#discussion_r1811547391 ## core/src/main/java/kafka/server/share/SharePartition.java: ## @@ -1138,6 +1185,7 @@ private void acquireSubsetBatchRecords( } finally {

Re: [PR] KAFKA-17793: Improve kcontroller robustness against long delays [kafka]

2024-10-22 Thread via GitHub
cmccabe commented on code in PR #17502: URL: https://github.com/apache/kafka/pull/17502#discussion_r1811535659 ## metadata/src/main/java/org/apache/kafka/controller/PeriodicTaskControlManager.java: ## @@ -0,0 +1,229 @@ +/* + * Licensed to the Apache Software Foundation (ASF) und

Re: [PR] KAFKA-17793: Improve kcontroller robustness against long delays [kafka]

2024-10-22 Thread via GitHub
cmccabe commented on code in PR #17502: URL: https://github.com/apache/kafka/pull/17502#discussion_r1811535659 ## metadata/src/main/java/org/apache/kafka/controller/PeriodicTaskControlManager.java: ## @@ -0,0 +1,229 @@ +/* + * Licensed to the Apache Software Foundation (ASF) und

Re: [PR] KAFKA-17793: Improve kcontroller robustness against long delays [kafka]

2024-10-22 Thread via GitHub
cmccabe commented on code in PR #17502: URL: https://github.com/apache/kafka/pull/17502#discussion_r1811528276 ## metadata/src/main/java/org/apache/kafka/controller/QuorumController.java: ## @@ -1159,255 +1176,12 @@ void renounce() { newWrongControllerExcept

Re: [PR] KAFKA-17793: Improve kcontroller robustness against long delays [kafka]

2024-10-22 Thread via GitHub
cmccabe commented on code in PR #17502: URL: https://github.com/apache/kafka/pull/17502#discussion_r1811528002 ## metadata/src/main/java/org/apache/kafka/controller/QuorumController.java: ## @@ -1855,6 +1633,97 @@ private QuorumController( this.raftClient.register(metaL

Re: [PR] KAFKA-17793: Improve kcontroller robustness against long delays [kafka]

2024-10-22 Thread via GitHub
cmccabe commented on code in PR #17502: URL: https://github.com/apache/kafka/pull/17502#discussion_r1811524670 ## metadata/src/main/java/org/apache/kafka/controller/ReplicationControlManager.java: ## @@ -1597,18 +1597,34 @@ public ControllerResult unregisterBroker(int brokerId)

Re: [PR] KAFKA-17793: Improve kcontroller robustness against long delays [kafka]

2024-10-22 Thread via GitHub
cmccabe commented on code in PR #17502: URL: https://github.com/apache/kafka/pull/17502#discussion_r1811523833 ## metadata/src/main/java/org/apache/kafka/controller/QuorumController.java: ## @@ -1855,6 +1633,97 @@ private QuorumController( this.raftClient.register(metaL

Re: [PR] KAFKA-17233: MirrorCheckpointConnector should use batched listConsumerGroupOffsets [kafka]

2024-10-22 Thread via GitHub
fonsdant commented on PR #17038: URL: https://github.com/apache/kafka/pull/17038#issuecomment-2430443231 Thanks, @mimaison! 😄 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment

Re: [PR] KAFKA-17793: Improve kcontroller robustness against long delays [kafka]

2024-10-22 Thread via GitHub
cmccabe commented on code in PR #17502: URL: https://github.com/apache/kafka/pull/17502#discussion_r1811521396 ## metadata/src/main/java/org/apache/kafka/controller/BrokerHeartbeatManager.java: ## @@ -82,23 +80,16 @@ static class BrokerHeartbeatState { */ priv

[PR] KAFKA-17848: Fixing NPE in delayed share fetch [kafka]

2024-10-22 Thread via GitHub
apoorvmittal10 opened a new pull request, #17583: URL: https://github.com/apache/kafka/pull/17583 The test shows that with 16 topic partitions reading 1 million messages with 10 Share Consumers, the share fetch stucks. Though the code should execute `tryComplete` but in some scenario

[jira] [Assigned] (KAFKA-17848) Resolve reliability issue on the broker post moving delayed share fetch purgatory to ReplicaManager

2024-10-22 Thread Apoorv Mittal (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17848?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Apoorv Mittal reassigned KAFKA-17848: - Assignee: Apoorv Mittal (was: Abhinav Dixit) > Resolve reliability issue on the broker

Re: [PR] KAFKA-17793: Improve kcontroller robustness against long delays [kafka]

2024-10-22 Thread via GitHub
mumrah commented on code in PR #17502: URL: https://github.com/apache/kafka/pull/17502#discussion_r1811413417 ## metadata/src/main/java/org/apache/kafka/controller/PeriodicTaskControlManager.java: ## @@ -0,0 +1,229 @@ +/* + * Licensed to the Apache Software Foundation (ASF) unde

Re: [PR] KAFKA-17774: Adding capability to handle max fetch records in Share Fetch (KIP-932) [kafka]

2024-10-22 Thread via GitHub
apoorvmittal10 commented on PR #17322: URL: https://github.com/apache/kafka/pull/17322#issuecomment-2430251355 @chia7712 I have addressed the comments. Thanks for the review. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

Re: [PR] KAFKA-17774: Adding capability to handle max fetch records in Share Fetch (KIP-932) [kafka]

2024-10-22 Thread via GitHub
apoorvmittal10 commented on code in PR #17322: URL: https://github.com/apache/kafka/pull/17322#discussion_r1811377602 ## core/src/main/java/kafka/server/share/SharePartition.java: ## @@ -1658,6 +1706,26 @@ private long findLastOffsetAcknowledged() { return lastOffsetAck

Re: [PR] KAFKA-17774: Adding capability to handle max fetch records in Share Fetch (KIP-932) [kafka]

2024-10-22 Thread via GitHub
chia7712 commented on code in PR #17322: URL: https://github.com/apache/kafka/pull/17322#discussion_r1811465882 ## core/src/main/java/kafka/server/share/SharePartition.java: ## @@ -1138,6 +1185,7 @@ private void acquireSubsetBatchRecords( } finally { lock.w

[jira] [Updated] (KAFKA-17854) add tests for `ReadOnlyWindowStoreStub#fetch(null, null ...)`

2024-10-22 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17854?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias J. Sax updated KAFKA-17854: Component/s: streams unit tests > add tests for `ReadOnlyWindowStoreStub#

[jira] [Updated] (KAFKA-17857) Move AbstractResetIntegrationTest and subclasses to tools

2024-10-22 Thread Greg Harris (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17857?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Greg Harris updated KAFKA-17857: Labels: newbie (was: ) > Move AbstractResetIntegrationTest and subclasses to tools >

Re: [PR] KAFKA-16437 - Upgrade to Jakarta and Jetty 12 (KIP-1032) [kafka]

2024-10-22 Thread via GitHub
gharris1727 commented on code in PR #16754: URL: https://github.com/apache/kafka/pull/16754#discussion_r1811421382 ## build.gradle: ## @@ -318,6 +318,18 @@ subprojects { options.compilerArgs << "-Werror" options.release = minJavaVersion addParametersForTests(name,

Re: [PR] KAFKA-17568 Rewrite TestPurgatoryPerformance by JMH [kafka]

2024-10-22 Thread via GitHub
m1a2st commented on PR #17246: URL: https://github.com/apache/kafka/pull/17246#issuecomment-2430284241 my local mashine can run the test ![image](https://github.com/user-attachments/assets/1976751f-5f1e-4f2b-9d42-3a73d3d89f89) -- This is an automated message from the Apache Git Ser

[jira] [Created] (KAFKA-17857) Move AbstractResetIntegrationTest and subclasses to tools

2024-10-22 Thread Greg Harris (Jira)
Greg Harris created KAFKA-17857: --- Summary: Move AbstractResetIntegrationTest and subclasses to tools Key: KAFKA-17857 URL: https://issues.apache.org/jira/browse/KAFKA-17857 Project: Kafka Issue

Re: [PR] KAFKA-17774: Adding capability to handle max fetch records in Share Fetch (KIP-932) [kafka]

2024-10-22 Thread via GitHub
apoorvmittal10 commented on code in PR #17322: URL: https://github.com/apache/kafka/pull/17322#discussion_r1811378934 ## share/src/main/java/org/apache/kafka/server/share/fetch/ShareAcquiredRecords.java: ## @@ -0,0 +1,72 @@ +/* + * Licensed to the Apache Software Foundation (ASF

Re: [PR] KAFKA-17774: Adding capability to handle max fetch records in Share Fetch (KIP-932) [kafka]

2024-10-22 Thread via GitHub
apoorvmittal10 commented on code in PR #17322: URL: https://github.com/apache/kafka/pull/17322#discussion_r1811354547 ## core/src/main/java/kafka/server/share/SharePartition.java: ## @@ -1138,6 +1185,7 @@ private void acquireSubsetBatchRecords( } finally {

[PR] KAFKA-16964: Integration tests for adding and removing voters [kafka]

2024-10-22 Thread via GitHub
kevin-wu24 opened a new pull request, #17582: URL: https://github.com/apache/kafka/pull/17582 This PR continues on the work of https://github.com/apache/kafka/pull/16991 From discussion, the changes regarding feature levels in the previous PR is considered out of scope for this change

[jira] [Resolved] (KAFKA-17114) DefaultStateUpdater::handleRuntimeException should update isRunning before calling `addToExceptionsAndFailedTasksThenClearUpdatingAndPausedTasks`

2024-10-22 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17114?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias J. Sax resolved KAFKA-17114. - Resolution: Cannot Reproduce We did push some fixed for related tickets. Closing this fo

[jira] [Reopened] (KAFKA-9323) Refactor Streams' upgrade system tests

2024-10-22 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9323?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias J. Sax reopened KAFKA-9323: > Refactor Streams' upgrade system tests > --- > >

[jira] [Resolved] (KAFKA-9323) Refactor Streams' upgrade system tests

2024-10-22 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9323?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias J. Sax resolved KAFKA-9323. Resolution: Fixed > Refactor Streams' upgrade system tests > -

[PR] [MIINOR] Refactor integration tests to remove Zookeeper, add group protocol parameter [kafka]

2024-10-22 Thread via GitHub
kirktrue opened a new pull request, #17581: URL: https://github.com/apache/kafka/pull/17581 Removing "zk" in the list of quorum values to test in a handful of core integration tests. This does not remove all occurrences. ### Committer Checklist (excluded from commit message) - [ ]

[jira] [Resolved] (KAFKA-17402) Test failure: DefaultStateUpdaterTest.shouldGetTasksFromRestoredActiveTasks expected: <2> but was: <3>

2024-10-22 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17402?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias J. Sax resolved KAFKA-17402. - Resolution: Cannot Reproduce We did put out some fixes for related tickets. Closing this

Re: [PR] KAFKA-17002: Integrated partition leader epoch for Persister APIs (KIP-932) [kafka]

2024-10-22 Thread via GitHub
apoorvmittal10 commented on PR #16842: URL: https://github.com/apache/kafka/pull/16842#issuecomment-2430141614 @junrao Sorry, I was in middle of my changes when last reviewed. But thanks for the feedback. I have completed the changes now, can you please re-review. Sorry for the trouble. -

Re: [PR] KAFKA-17002: Integrated partition leader epoch for Persister APIs (KIP-932) [kafka]

2024-10-22 Thread via GitHub
apoorvmittal10 commented on code in PR #16842: URL: https://github.com/apache/kafka/pull/16842#discussion_r1811306002 ## core/src/main/java/kafka/server/share/SharePartitionManager.java: ## @@ -603,22 +612,43 @@ private void maybeCompleteInitializationWithException(

Re: [PR] KAFKA-17002: Integrated partition leader epoch for Persister APIs (KIP-932) [kafka]

2024-10-22 Thread via GitHub
apoorvmittal10 commented on code in PR #16842: URL: https://github.com/apache/kafka/pull/16842#discussion_r1811300432 ## core/src/main/java/kafka/server/share/SharePartitionManager.java: ## @@ -603,22 +612,43 @@ private void maybeCompleteInitializationWithException(

Re: [PR] KAFKA-17002: Integrated partition leader epoch for Persister APIs (KIP-932) [kafka]

2024-10-22 Thread via GitHub
apoorvmittal10 commented on code in PR #16842: URL: https://github.com/apache/kafka/pull/16842#discussion_r1811299985 ## core/src/main/java/kafka/server/share/SharePartitionManager.java: ## @@ -594,7 +602,8 @@ private SharePartition getOrCreateSharePartition(SharePartitionKey s

Re: [PR] KAFKA-17002: Integrated partition leader epoch for Persister APIs (KIP-932) [kafka]

2024-10-22 Thread via GitHub
apoorvmittal10 commented on code in PR #16842: URL: https://github.com/apache/kafka/pull/16842#discussion_r1811299548 ## core/src/main/java/kafka/server/share/SharePartition.java: ## @@ -228,6 +240,11 @@ public static RecordState forId(byte id) { */ private int stateE

Re: [PR] KAFKA-17774: Adding capability to handle max fetch records in Share Fetch (KIP-932) [kafka]

2024-10-22 Thread via GitHub
chia7712 commented on code in PR #17322: URL: https://github.com/apache/kafka/pull/17322#discussion_r1811288562 ## core/src/main/java/kafka/server/share/SharePartition.java: ## @@ -1658,6 +1706,26 @@ private long findLastOffsetAcknowledged() { return lastOffsetAcknowled

Re: [PR] KAFKA-17002: Integrated partition leader epoch for Persister APIs (KIP-932) [kafka]

2024-10-22 Thread via GitHub
apoorvmittal10 commented on code in PR #16842: URL: https://github.com/apache/kafka/pull/16842#discussion_r1811298975 ## core/src/main/java/kafka/server/share/SharePartition.java: ## @@ -1497,17 +1535,29 @@ private long findLastOffsetAcknowledged() { } // Visible for

Re: [PR] KAFKA-17852: Add help message to the --ignore-formatted flag of StorageTool [kafka]

2024-10-22 Thread via GitHub
chia7712 merged PR #17577: URL: https://github.com/apache/kafka/pull/17577 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache

[jira] [Created] (KAFKA-17856) Move ConfigCommandTest and ConfigCommandIntegrationTest to tool module

2024-10-22 Thread Chia-Ping Tsai (Jira)
Chia-Ping Tsai created KAFKA-17856: -- Summary: Move ConfigCommandTest and ConfigCommandIntegrationTest to tool module Key: KAFKA-17856 URL: https://issues.apache.org/jira/browse/KAFKA-17856 Project: K

[jira] [Commented] (KAFKA-17499) Memory leak when using ReadOnlyKeyValueStore `all()` method

2024-10-22 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17499?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17891978#comment-17891978 ] Matthias J. Sax commented on KAFKA-17499: - It was never confirmed as a bug (and

Re: [PR] KAFKA-17774: Adding capability to handle max fetch records in Share Fetch (KIP-932) [kafka]

2024-10-22 Thread via GitHub
junrao commented on code in PR #17322: URL: https://github.com/apache/kafka/pull/17322#discussion_r1811257578 ## core/src/main/java/kafka/server/share/SharePartition.java: ## @@ -1658,6 +1706,26 @@ private long findLastOffsetAcknowledged() { return lastOffsetAcknowledge

Re: [PR] KAFKA-17526: make ConfigCommandIntegrationTest.java test use correct arguments in testing alias [kafka]

2024-10-22 Thread via GitHub
chia7712 merged PR #17201: URL: https://github.com/apache/kafka/pull/17201 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache

[jira] [Resolved] (KAFKA-17526) make ConfigCommandIntegrationTest.java test use correct arguments in testing alias

2024-10-22 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17526?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai resolved KAFKA-17526. Fix Version/s: 4.0.0 Resolution: Fixed > make ConfigCommandIntegrationTest.java tes

Re: [PR] KAFKA-17774: Adding capability to handle max fetch records in Share Fetch (KIP-932) [kafka]

2024-10-22 Thread via GitHub
chia7712 commented on code in PR #17322: URL: https://github.com/apache/kafka/pull/17322#discussion_r1811253140 ## core/src/main/java/kafka/server/share/SharePartition.java: ## @@ -1138,6 +1185,7 @@ private void acquireSubsetBatchRecords( } finally { lock.w

Re: [PR] KAFKA-16564: Apply `Xlint` to java code in core module [kafka]

2024-10-22 Thread via GitHub
m1a2st commented on code in PR #16965: URL: https://github.com/apache/kafka/pull/16965#discussion_r1811237660 ## clients/src/test/java/org/apache/kafka/common/security/ssl/CommonNameLoggingTrustManagerFactoryWrapperTest.java: ## @@ -122,7 +122,7 @@ void testNeverExpiringX509Cert

Re: [PR] KAFKA-17774: Adding capability to handle max fetch records in Share Fetch (KIP-932) [kafka]

2024-10-22 Thread via GitHub
chia7712 commented on code in PR #17322: URL: https://github.com/apache/kafka/pull/17322#discussion_r1811236968 ## core/src/main/java/kafka/server/share/SharePartition.java: ## @@ -1658,6 +1706,26 @@ private long findLastOffsetAcknowledged() { return lastOffsetAcknowled

[jira] [Commented] (KAFKA-15494) Remove deprecated calls in build.gradle for preparing future upgrades

2024-10-22 Thread Said BOUDJELDA (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15494?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17891973#comment-17891973 ] Said BOUDJELDA commented on KAFKA-15494: [~gharris1727] in progress > Remove d

Re: [PR] KAFKA-16564: Apply `Xlint` to java code in core module [kafka]

2024-10-22 Thread via GitHub
m1a2st commented on code in PR #16965: URL: https://github.com/apache/kafka/pull/16965#discussion_r1811235709 ## build.gradle: ## @@ -113,11 +113,22 @@ ext { commitId = determineCommitId() - addParametersForTests = { name, options -> + configureJavaCompiler = { name, op

[jira] [Updated] (KAFKA-17686) AsyncKafkaConsumer.offsetsForTimes() fails with NullPointerException

2024-10-22 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17686?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True updated KAFKA-17686: -- Reviewer: Chia-Ping Tsai > AsyncKafkaConsumer.offsetsForTimes() fails with NullPointerException >

[jira] [Resolved] (KAFKA-17813) Create server connection id class encapsulating functionality for generation

2024-10-22 Thread Jun Rao (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17813?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jun Rao resolved KAFKA-17813. - Fix Version/s: 4.0.0 Resolution: Fixed merged the PR to trunk > Create server connection id clas

Re: [PR] KAFKA-17813: Moving broker endpoint class and common server connection id [kafka]

2024-10-22 Thread via GitHub
junrao merged PR #17519: URL: https://github.com/apache/kafka/pull/17519 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.o

Re: [PR] KAFKA-17568 Rewrite TestPurgatoryPerformance by JMH [kafka]

2024-10-22 Thread via GitHub
m1a2st commented on PR #17246: URL: https://github.com/apache/kafka/pull/17246#issuecomment-2430007461 Thanks for your suggestion, I will be change it to plain Java -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the U

[jira] [Assigned] (KAFKA-17855) Improve documentation for transactions in the light of KIP-1050

2024-10-22 Thread Andrew Schofield (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17855?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Schofield reassigned KAFKA-17855: Assignee: Andrew Schofield > Improve documentation for transactions in the light

Re: [PR] KAFKA-17671: Create better documentation for transactions [kafka]

2024-10-22 Thread via GitHub
AndrewJSchofield commented on PR #17454: URL: https://github.com/apache/kafka/pull/17454#issuecomment-2429996766 https://issues.apache.org/jira/browse/KAFKA-17855 is the continuation of this work which depends upon KIP-1050. -- This is an automated message from the Apache Git Service. To

[jira] [Created] (KAFKA-17855) Improve documentation for transactions in the light of KIP-1050

2024-10-22 Thread Andrew Schofield (Jira)
Andrew Schofield created KAFKA-17855: Summary: Improve documentation for transactions in the light of KIP-1050 Key: KAFKA-17855 URL: https://issues.apache.org/jira/browse/KAFKA-17855 Project: Kafk

Re: [PR] KAFKA-17686: AsyncKafkaConsumer.offsetsForTimes() fails with NullPointerException [kafka]

2024-10-22 Thread via GitHub
chia7712 merged PR #17353: URL: https://github.com/apache/kafka/pull/17353 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache

Re: [PR] MINOR: Use JDK 11 in Vagrant after dropping JDK 8 [kafka]

2024-10-22 Thread via GitHub
chia7712 commented on PR #17576: URL: https://github.com/apache/kafka/pull/17576#issuecomment-2429991154 We are planning to drop JDK 11 for server modules (https://issues.apache.org/jira/browse/KAFKA-16096), and the base image for E2E has already been updated to use JDK 17 (#17520). Therefo

Re: [PR] [WIP] Update GroupRebalanceConfig to not require session.timeout.ms [kafka]

2024-10-22 Thread via GitHub
kirktrue closed pull request #17529: [WIP] Update GroupRebalanceConfig to not require session.timeout.ms URL: https://github.com/apache/kafka/pull/17529 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

Re: [PR] KAFKA-16564: Apply `Xlint` to java code in core module [kafka]

2024-10-22 Thread via GitHub
chia7712 commented on code in PR #16965: URL: https://github.com/apache/kafka/pull/16965#discussion_r1811204610 ## build.gradle: ## @@ -113,11 +113,22 @@ ext { commitId = determineCommitId() - addParametersForTests = { name, options -> + configureJavaCompiler = { name,

Re: [PR] KAFKA-17686: AsyncKafkaConsumer.offsetsForTimes() fails with NullPointerException [kafka]

2024-10-22 Thread via GitHub
kirktrue commented on PR #17353: URL: https://github.com/apache/kafka/pull/17353#issuecomment-2429980842 @chia7712 / @lianetm—tests are passing and comments have been addressed. Can you provide another pass of reviews? Thanks! -- This is an automated message from the Apache Git Service. T

Re: [PR] KAFKA-17439: Make polling for new records an explicit action/event in the new consumer [kafka]

2024-10-22 Thread via GitHub
kirktrue commented on PR #17035: URL: https://github.com/apache/kafka/pull/17035#issuecomment-2429977853 @lianetm—tests are passing and all comments have been addressed. Can you make another review pass? Thanks! -- This is an automated message from the Apache Git Service. To respond to th

[jira] [Assigned] (KAFKA-17854) add tests for `ReadOnlyWindowStoreStub#fetch(null, null ...)`

2024-10-22 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17854?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai reassigned KAFKA-17854: -- Assignee: Jhen Yung Hsu (was: Chia-Ping Tsai) > add tests for `ReadOnlyWindowStoreSt

Re: [PR] MINOR: Fix strange if statements [kafka]

2024-10-22 Thread via GitHub
chia7712 commented on PR #17574: URL: https://github.com/apache/kafka/pull/17574#issuecomment-2429951900 close as duplicate to #17540 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] MINOR: Fix other tools' formatting in documentation [kafka]

2024-10-22 Thread via GitHub
chia7712 merged PR #17572: URL: https://github.com/apache/kafka/pull/17572 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache

Re: [PR] MINOR: Fix duplicate condition in ReadOnlyWindowStoreStub [kafka]

2024-10-22 Thread via GitHub
chia7712 merged PR #17540: URL: https://github.com/apache/kafka/pull/17540 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache

Re: [PR] MINOR: Fix strange if statements [kafka]

2024-10-22 Thread via GitHub
chia7712 commented on PR #17574: URL: https://github.com/apache/kafka/pull/17574#issuecomment-2429952854 @vlade1k thanks for your contribution. Please feel free to ping me on your next PR -- This is an automated message from the Apache Git Service. To respond to the message, please log on

Re: [PR] MINOR: Fix strange if statements [kafka]

2024-10-22 Thread via GitHub
chia7712 closed pull request #17574: MINOR: Fix strange if statements URL: https://github.com/apache/kafka/pull/17574 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubsc

  1   2   >