[GitHub] [kafka] Hangleton commented on a diff in pull request #13240: KAFKA-14690: Add topic IDs to OffsetCommit API and propagate for request version >= 9

Hangleton commented on code in PR #13240: URL: https://github.com/apache/kafka/pull/13240#discussion_r1124559198 ## clients/src/main/java/org/apache/kafka/common/requests/OffsetCommitResponse.java: ## @@ -167,8 +213,24 @@ public Builder addPartitions( } publ

[GitHub] [kafka] Hangleton commented on a diff in pull request #13240: KAFKA-14690: Add topic IDs to OffsetCommit API and propagate for request version >= 9

Hangleton commented on code in PR #13240: URL: https://github.com/apache/kafka/pull/13240#discussion_r1124559198 ## clients/src/main/java/org/apache/kafka/common/requests/OffsetCommitResponse.java: ## @@ -167,8 +213,24 @@ public Builder addPartitions( } publ

[GitHub] [kafka] Hangleton commented on a diff in pull request #13240: KAFKA-14690: Add topic IDs to OffsetCommit API and propagate for request version >= 9

Hangleton commented on code in PR #13240: URL: https://github.com/apache/kafka/pull/13240#discussion_r1122830477 ## clients/src/main/java/org/apache/kafka/common/requests/OffsetCommitResponse.java: ## @@ -119,43 +128,53 @@ public boolean shouldClientThrottle(short version) {

[GitHub] [kafka] Hangleton commented on a diff in pull request #13240: KAFKA-14690: Add topic IDs to OffsetCommit API and propagate for request version >= 9

Hangleton commented on code in PR #13240: URL: https://github.com/apache/kafka/pull/13240#discussion_r1122271424 ## clients/src/main/java/org/apache/kafka/common/requests/OffsetCommitResponse.java: ## @@ -119,43 +128,53 @@ public boolean shouldClientThrottle(short version) {

[GitHub] [kafka] Hangleton commented on a diff in pull request #13240: KAFKA-14690: Add topic IDs to OffsetCommit API and propagate for request version >= 9

Hangleton commented on code in PR #13240: URL: https://github.com/apache/kafka/pull/13240#discussion_r1122265994 ## core/src/test/scala/unit/kafka/server/OffsetCommitRequestTest.scala: ## @@ -0,0 +1,78 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one or mor

[GitHub] [kafka] Hangleton commented on a diff in pull request #13240: KAFKA-14690: Add topic IDs to OffsetCommit API and propagate for request version >= 9

Hangleton commented on code in PR #13240: URL: https://github.com/apache/kafka/pull/13240#discussion_r1122188628 ## clients/src/main/java/org/apache/kafka/common/requests/OffsetCommitResponse.java: ## @@ -166,20 +187,27 @@ public Builder addPartitions( return this;

[GitHub] [kafka] Hangleton commented on a diff in pull request #13240: KAFKA-14690: Add topic IDs to OffsetCommit API and propagate for request version >= 9

Hangleton commented on code in PR #13240: URL: https://github.com/apache/kafka/pull/13240#discussion_r1122175488 ## clients/src/main/java/org/apache/kafka/common/requests/OffsetCommitResponse.java: ## @@ -119,43 +130,62 @@ public boolean shouldClientThrottle(short version) {

[GitHub] [kafka] Hangleton commented on a diff in pull request #13240: KAFKA-14690: Add topic IDs to OffsetCommit API and propagate for request version >= 9

Hangleton commented on code in PR #13240: URL: https://github.com/apache/kafka/pull/13240#discussion_r1122096890 ## clients/src/main/java/org/apache/kafka/common/requests/OffsetCommitResponse.java: ## @@ -149,13 +161,15 @@ public Builder addPartition( return this;

[GitHub] [kafka] Hangleton commented on a diff in pull request #13240: KAFKA-14690: Add topic IDs to OffsetCommit API and propagate for request version >= 9

Hangleton commented on code in PR #13240: URL: https://github.com/apache/kafka/pull/13240#discussion_r1121724366 ## clients/src/main/java/org/apache/kafka/common/requests/OffsetCommitResponse.java: ## @@ -50,14 +52,21 @@ public class OffsetCommitResponse extends AbstractRespons

[GitHub] [kafka] Hangleton commented on a diff in pull request #13240: KAFKA-14690: Add topic IDs to OffsetCommit API and propagate for request version >= 9

Hangleton commented on code in PR #13240: URL: https://github.com/apache/kafka/pull/13240#discussion_r1119798298 ## clients/src/main/resources/common/message/OffsetCommitRequest.json: ## @@ -47,8 +49,10 @@ "about": "The time period in ms to retain the offset." }, { "

[GitHub] [kafka] Hangleton commented on a diff in pull request #13240: KAFKA-14690: Add topic IDs to OffsetCommit API and propagate for request version >= 9

Hangleton commented on code in PR #13240: URL: https://github.com/apache/kafka/pull/13240#discussion_r1116205901 ## clients/src/test/java/org/apache/kafka/clients/consumer/internals/ConsumerCoordinatorTest.java: ## @@ -2604,11 +2650,95 @@ public void testCommitOffsetUnknownMembe

[GitHub] [kafka] Hangleton commented on a diff in pull request #13240: KAFKA-14690: Add topic IDs to OffsetCommit API and propagate for request version >= 9

Hangleton commented on code in PR #13240: URL: https://github.com/apache/kafka/pull/13240#discussion_r1116204122 ## clients/src/test/java/org/apache/kafka/clients/consumer/internals/ConsumerCoordinatorTest.java: ## @@ -1369,7 +1387,7 @@ public void testJoinPrepareWithDisableAuto

[GitHub] [kafka] Hangleton commented on a diff in pull request #13240: KAFKA-14690: Add topic IDs to OffsetCommit API and propagate for request version >= 9

Hangleton commented on code in PR #13240: URL: https://github.com/apache/kafka/pull/13240#discussion_r1116203414 ## core/src/test/scala/unit/kafka/server/KafkaApisTest.scala: ## @@ -1351,8 +1351,11 @@ class KafkaApisTest { @Test def testHandleOffsetCommitRequestTopicsAnd

[GitHub] [kafka] Hangleton commented on a diff in pull request #13240: KAFKA-14690: Add topic IDs to OffsetCommit API and propagate for request version >= 9

Hangleton commented on code in PR #13240: URL: https://github.com/apache/kafka/pull/13240#discussion_r1116202452 ## core/src/main/scala/kafka/server/KafkaApis.scala: ## @@ -425,35 +425,73 @@ class KafkaApis(val requestChannel: RequestChannel, requestHelper.sendMaybeThrott

[GitHub] [kafka] Hangleton commented on a diff in pull request #13240: KAFKA-14690: Add topic IDs to OffsetCommit API and propagate for request version >= 9

Hangleton commented on code in PR #13240: URL: https://github.com/apache/kafka/pull/13240#discussion_r1116200049 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/ConsumerCoordinator.java: ## @@ -1374,7 +1379,8 @@ public void handle(OffsetCommitResponse commit

[GitHub] [kafka] Hangleton commented on a diff in pull request #13240: KAFKA-14690: Add topic IDs to OffsetCommit API and propagate for request version >= 9

Hangleton commented on code in PR #13240: URL: https://github.com/apache/kafka/pull/13240#discussion_r1116198012 ## clients/src/main/java/org/apache/kafka/common/requests/OffsetCommitResponse.java: ## @@ -151,11 +154,12 @@ public Builder addPartition( public Builder

[GitHub] [kafka] Hangleton commented on a diff in pull request #13240: KAFKA-14690: Add topic IDs to OffsetCommit API and propagate for request version >= 9

Hangleton commented on code in PR #13240: URL: https://github.com/apache/kafka/pull/13240#discussion_r1116196039 ## clients/src/main/java/org/apache/kafka/common/requests/OffsetCommitRequest.java: ## @@ -78,11 +111,18 @@ public OffsetCommitRequestData data() { return da

[GitHub] [kafka] Hangleton commented on a diff in pull request #13240: KAFKA-14690: Add topic IDs to OffsetCommit API and propagate for request version >= 9

Hangleton commented on code in PR #13240: URL: https://github.com/apache/kafka/pull/13240#discussion_r1106229439 ## core/src/main/scala/kafka/server/KafkaApis.scala: ## @@ -425,35 +425,72 @@ class KafkaApis(val requestChannel: RequestChannel, requestHelper.sendMaybeThrott

[GitHub] [kafka] Hangleton commented on a diff in pull request #13240: KAFKA-14690: Add topic IDs to OffsetCommit API and propagate for request version >= 9

Hangleton commented on code in PR #13240: URL: https://github.com/apache/kafka/pull/13240#discussion_r1106229439 ## core/src/main/scala/kafka/server/KafkaApis.scala: ## @@ -425,35 +425,72 @@ class KafkaApis(val requestChannel: RequestChannel, requestHelper.sendMaybeThrott

[GitHub] [kafka] Hangleton commented on a diff in pull request #13240: KAFKA-14690: Add topic IDs to OffsetCommit API and propagate for request version >= 9

Hangleton commented on code in PR #13240: URL: https://github.com/apache/kafka/pull/13240#discussion_r1105987099 ## core/src/main/scala/kafka/server/KafkaApis.scala: ## @@ -425,35 +425,72 @@ class KafkaApis(val requestChannel: RequestChannel, requestHelper.sendMaybeThrott

[GitHub] [kafka] Hangleton commented on a diff in pull request #13240: KAFKA-14690: Add topic IDs to OffsetCommit API and propagate for request version >= 9

Hangleton commented on code in PR #13240: URL: https://github.com/apache/kafka/pull/13240#discussion_r1105985661 ## core/src/main/scala/kafka/server/KafkaApis.scala: ## @@ -425,35 +425,72 @@ class KafkaApis(val requestChannel: RequestChannel, requestHelper.sendMaybeThrott

[GitHub] [kafka] Hangleton commented on a diff in pull request #13240: KAFKA-14690: Add topic IDs to OffsetCommit API and propagate for request version >= 9

Hangleton commented on code in PR #13240: URL: https://github.com/apache/kafka/pull/13240#discussion_r1104740902 ## clients/src/main/java/org/apache/kafka/common/requests/OffsetCommitRequest.java: ## @@ -78,11 +89,18 @@ public OffsetCommitRequestData data() { return dat

[GitHub] [kafka] Hangleton commented on a diff in pull request #13240: KAFKA-14690: Add topic IDs to OffsetCommit API and propagate for request version >= 9

Hangleton commented on code in PR #13240: URL: https://github.com/apache/kafka/pull/13240#discussion_r1104760648 ## clients/src/main/java/org/apache/kafka/common/requests/OffsetCommitRequest.java: ## @@ -78,11 +89,18 @@ public OffsetCommitRequestData data() { return dat

[GitHub] [kafka] Hangleton commented on a diff in pull request #13240: KAFKA-14690: Add topic IDs to OffsetCommit API and propagate for request version >= 9

Hangleton commented on code in PR #13240: URL: https://github.com/apache/kafka/pull/13240#discussion_r1104738082 ## clients/src/main/java/org/apache/kafka/common/requests/OffsetCommitRequest.java: ## @@ -59,6 +62,14 @@ public OffsetCommitRequest build(short version) {