[GitHub] [kafka] mumrah commented on a change in pull request #9100: Add AlterISR RPC and use it for ISR modifications

mumrah commented on a change in pull request #9100: URL: https://github.com/apache/kafka/pull/9100#discussion_r494520245 ## File path: core/src/main/scala/kafka/controller/KafkaController.scala ## @@ -1764,6 +1769,145 @@ class KafkaController(val config: KafkaConfig, }

[GitHub] [kafka] mumrah commented on a change in pull request #9100: Add AlterISR RPC and use it for ISR modifications

mumrah commented on a change in pull request #9100: URL: https://github.com/apache/kafka/pull/9100#discussion_r494523773 ## File path: core/src/main/scala/kafka/cluster/Partition.scala ## @@ -1246,6 +1351,51 @@ class Partition(val topicPartition: TopicPartition, } }

[GitHub] [kafka] mumrah commented on a change in pull request #9100: Add AlterISR RPC and use it for ISR modifications

mumrah commented on a change in pull request #9100: URL: https://github.com/apache/kafka/pull/9100#discussion_r490594335 ## File path: core/src/main/scala/kafka/cluster/Partition.scala ## @@ -618,9 +682,9 @@ class Partition(val topicPartition: TopicPartition, // since

[GitHub] [kafka] mumrah commented on a change in pull request #9100: Add AlterISR RPC and use it for ISR modifications

mumrah commented on a change in pull request #9100: URL: https://github.com/apache/kafka/pull/9100#discussion_r490562630 ## File path: core/src/main/scala/kafka/cluster/Partition.scala ## @@ -920,7 +986,7 @@ class Partition(val topicPartition: TopicPartition, * is

[GitHub] [kafka] mumrah commented on a change in pull request #9100: Add AlterISR RPC and use it for ISR modifications

mumrah commented on a change in pull request #9100: URL: https://github.com/apache/kafka/pull/9100#discussion_r490561028 ## File path: core/src/main/scala/kafka/cluster/Partition.scala ## @@ -920,7 +986,7 @@ class Partition(val topicPartition: TopicPartition, * is

[GitHub] [kafka] mumrah commented on a change in pull request #9100: Add AlterISR RPC and use it for ISR modifications

mumrah commented on a change in pull request #9100: URL: https://github.com/apache/kafka/pull/9100#discussion_r490542749 ## File path: core/src/main/scala/kafka/cluster/Partition.scala ## @@ -200,9 +241,11 @@ class Partition(val topicPartition: TopicPartition, // defined

[GitHub] [kafka] mumrah commented on a change in pull request #9100: Add AlterISR RPC and use it for ISR modifications

mumrah commented on a change in pull request #9100: URL: https://github.com/apache/kafka/pull/9100#discussion_r489756083 ## File path: core/src/main/scala/kafka/server/ReplicaManager.scala ## @@ -1317,7 +1326,9 @@ class ReplicaManager(val config: KafkaConfig,

[GitHub] [kafka] mumrah commented on a change in pull request #9100: Add AlterISR RPC and use it for ISR modifications

mumrah commented on a change in pull request #9100: URL: https://github.com/apache/kafka/pull/9100#discussion_r489753946 ## File path: core/src/main/scala/kafka/server/KafkaApis.scala ## @@ -3045,6 +3045,24 @@ class KafkaApis(val requestChannel: RequestChannel, } } +

[GitHub] [kafka] mumrah commented on a change in pull request #9100: Add AlterISR RPC and use it for ISR modifications

mumrah commented on a change in pull request #9100: URL: https://github.com/apache/kafka/pull/9100#discussion_r489747101 ## File path: core/src/main/scala/kafka/server/AlterIsrManager.scala ## @@ -0,0 +1,173 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under

[GitHub] [kafka] mumrah commented on a change in pull request #9100: Add AlterISR RPC and use it for ISR modifications

mumrah commented on a change in pull request #9100: URL: https://github.com/apache/kafka/pull/9100#discussion_r489745539 ## File path: core/src/main/scala/kafka/server/AlterIsrManager.scala ## @@ -0,0 +1,173 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under

[GitHub] [kafka] mumrah commented on a change in pull request #9100: Add AlterISR RPC and use it for ISR modifications

mumrah commented on a change in pull request #9100: URL: https://github.com/apache/kafka/pull/9100#discussion_r489744561 ## File path: core/src/main/scala/kafka/server/AlterIsrManager.scala ## @@ -0,0 +1,173 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under

[GitHub] [kafka] mumrah commented on a change in pull request #9100: Add AlterISR RPC and use it for ISR modifications

mumrah commented on a change in pull request #9100: URL: https://github.com/apache/kafka/pull/9100#discussion_r489740479 ## File path: core/src/main/scala/kafka/server/AlterIsrManager.scala ## @@ -0,0 +1,173 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under

[GitHub] [kafka] mumrah commented on a change in pull request #9100: Add AlterISR RPC and use it for ISR modifications

mumrah commented on a change in pull request #9100: URL: https://github.com/apache/kafka/pull/9100#discussion_r489730265 ## File path: core/src/main/scala/kafka/server/AlterIsrManager.scala ## @@ -0,0 +1,173 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under

[GitHub] [kafka] mumrah commented on a change in pull request #9100: Add AlterISR RPC and use it for ISR modifications

mumrah commented on a change in pull request #9100: URL: https://github.com/apache/kafka/pull/9100#discussion_r489721316 ## File path: core/src/main/scala/kafka/cluster/Partition.scala ## @@ -617,9 +665,9 @@ class Partition(val topicPartition: TopicPartition, // since

[GitHub] [kafka] mumrah commented on a change in pull request #9100: Add AlterISR RPC and use it for ISR modifications

mumrah commented on a change in pull request #9100: URL: https://github.com/apache/kafka/pull/9100#discussion_r489720971 ## File path: config/log4j.properties ## @@ -76,8 +76,8 @@ log4j.additivity.kafka.request.logger=false log4j.logger.kafka.network.RequestChannel$=WARN,

[GitHub] [kafka] mumrah commented on a change in pull request #9100: Add AlterISR RPC and use it for ISR modifications

mumrah commented on a change in pull request #9100: URL: https://github.com/apache/kafka/pull/9100#discussion_r489703810 ## File path: core/src/main/scala/kafka/cluster/Partition.scala ## @@ -1210,6 +1317,37 @@ class Partition(val topicPartition: TopicPartition, } }

[GitHub] [kafka] mumrah commented on a change in pull request #9100: Add AlterISR RPC and use it for ISR modifications

mumrah commented on a change in pull request #9100: URL: https://github.com/apache/kafka/pull/9100#discussion_r486535868 ## File path: core/src/main/scala/kafka/cluster/Partition.scala ## @@ -1210,19 +1243,66 @@ class Partition(val topicPartition: TopicPartition, } }

[GitHub] [kafka] mumrah commented on a change in pull request #9100: Add AlterISR RPC and use it for ISR modifications

mumrah commented on a change in pull request #9100: URL: https://github.com/apache/kafka/pull/9100#discussion_r486535166 ## File path: core/src/main/scala/kafka/cluster/Partition.scala ## @@ -1210,19 +1243,66 @@ class Partition(val topicPartition: TopicPartition, } }

[GitHub] [kafka] mumrah commented on a change in pull request #9100: Add AlterISR RPC and use it for ISR modifications

mumrah commented on a change in pull request #9100: URL: https://github.com/apache/kafka/pull/9100#discussion_r486535166 ## File path: core/src/main/scala/kafka/cluster/Partition.scala ## @@ -1210,19 +1243,66 @@ class Partition(val topicPartition: TopicPartition, } }

[GitHub] [kafka] mumrah commented on a change in pull request #9100: Add AlterISR RPC and use it for ISR modifications

mumrah commented on a change in pull request #9100: URL: https://github.com/apache/kafka/pull/9100#discussion_r486535166 ## File path: core/src/main/scala/kafka/cluster/Partition.scala ## @@ -1210,19 +1243,66 @@ class Partition(val topicPartition: TopicPartition, } }

[GitHub] [kafka] mumrah commented on a change in pull request #9100: Add AlterISR RPC and use it for ISR modifications

mumrah commented on a change in pull request #9100: URL: https://github.com/apache/kafka/pull/9100#discussion_r486521810 ## File path: core/src/main/scala/kafka/cluster/Partition.scala ## @@ -255,6 +265,15 @@ class Partition(val topicPartition: TopicPartition, def

[GitHub] [kafka] mumrah commented on a change in pull request #9100: Add AlterISR RPC and use it for ISR modifications

mumrah commented on a change in pull request #9100: URL: https://github.com/apache/kafka/pull/9100#discussion_r486521810 ## File path: core/src/main/scala/kafka/cluster/Partition.scala ## @@ -255,6 +265,15 @@ class Partition(val topicPartition: TopicPartition, def

[GitHub] [kafka] mumrah commented on a change in pull request #9100: Add AlterISR RPC and use it for ISR modifications

mumrah commented on a change in pull request #9100: URL: https://github.com/apache/kafka/pull/9100#discussion_r478069145 ## File path: core/src/main/scala/kafka/server/AlterIsrManager.scala ## @@ -0,0 +1,145 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under

[GitHub] [kafka] mumrah commented on a change in pull request #9100: Add AlterISR RPC and use it for ISR modifications

mumrah commented on a change in pull request #9100: URL: https://github.com/apache/kafka/pull/9100#discussion_r478067221 ## File path: core/src/main/scala/kafka/server/AlterIsrManager.scala ## @@ -0,0 +1,145 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under

[GitHub] [kafka] mumrah commented on a change in pull request #9100: Add AlterISR RPC and use it for ISR modifications

mumrah commented on a change in pull request #9100: URL: https://github.com/apache/kafka/pull/9100#discussion_r475626573 ## File path: config/log4j.properties ## @@ -61,8 +61,8 @@ log4j.appender.authorizerAppender.layout.ConversionPattern=[%d] %p %m (%c)%n

[GitHub] [kafka] mumrah commented on a change in pull request #9100: Add AlterISR RPC and use it for ISR modifications

mumrah commented on a change in pull request #9100: URL: https://github.com/apache/kafka/pull/9100#discussion_r475632719 ## File path: core/src/main/scala/kafka/cluster/Partition.scala ## @@ -1257,4 +1364,4 @@ class Partition(val topicPartition: TopicPartition, }

[GitHub] [kafka] mumrah commented on a change in pull request #9100: Add AlterISR RPC and use it for ISR modifications

mumrah commented on a change in pull request #9100: URL: https://github.com/apache/kafka/pull/9100#discussion_r475625111 ## File path: clients/src/main/java/org/apache/kafka/common/protocol/Errors.java ## @@ -325,7 +326,8 @@ UNSTABLE_OFFSET_COMMIT(88, "There are unstable

[GitHub] [kafka] mumrah commented on a change in pull request #9100: Add AlterISR RPC and use it for ISR modifications

mumrah commented on a change in pull request #9100: URL: https://github.com/apache/kafka/pull/9100#discussion_r475630695 ## File path: core/src/main/scala/kafka/cluster/Partition.scala ## @@ -806,8 +840,9 @@ class Partition(val topicPartition: TopicPartition, // avoid

[GitHub] [kafka] mumrah commented on a change in pull request #9100: Add AlterISR RPC and use it for ISR modifications

mumrah commented on a change in pull request #9100: URL: https://github.com/apache/kafka/pull/9100#discussion_r475629593 ## File path: core/src/main/scala/kafka/cluster/Partition.scala ## @@ -635,7 +666,7 @@ class Partition(val topicPartition: TopicPartition, //

[GitHub] [kafka] mumrah commented on a change in pull request #9100: Add AlterISR RPC and use it for ISR modifications

mumrah commented on a change in pull request #9100: URL: https://github.com/apache/kafka/pull/9100#discussion_r475627290 ## File path: core/src/main/scala/kafka/cluster/Partition.scala ## @@ -141,7 +142,8 @@ object Partition extends KafkaMetricsGroup { stateStore =

[GitHub] [kafka] mumrah commented on a change in pull request #9100: Add AlterISR RPC and use it for ISR modifications

mumrah commented on a change in pull request #9100: URL: https://github.com/apache/kafka/pull/9100#discussion_r474959176 ## File path: core/src/main/scala/kafka/server/AlterIsrChannelManager.scala ## @@ -0,0 +1,132 @@ +package kafka.server + +import java.util +import

[GitHub] [kafka] mumrah commented on a change in pull request #9100: Add AlterISR RPC and use it for ISR modifications

mumrah commented on a change in pull request #9100: URL: https://github.com/apache/kafka/pull/9100#discussion_r474934833 ## File path: core/src/main/scala/kafka/server/AlterIsrChannelManager.scala ## @@ -0,0 +1,132 @@ +package kafka.server + +import java.util +import

[GitHub] [kafka] mumrah commented on a change in pull request #9100: Add AlterISR RPC and use it for ISR modifications

mumrah commented on a change in pull request #9100: URL: https://github.com/apache/kafka/pull/9100#discussion_r474934833 ## File path: core/src/main/scala/kafka/server/AlterIsrChannelManager.scala ## @@ -0,0 +1,132 @@ +package kafka.server + +import java.util +import

[GitHub] [kafka] mumrah commented on a change in pull request #9100: Add AlterISR RPC and use it for ISR modifications

mumrah commented on a change in pull request #9100: URL: https://github.com/apache/kafka/pull/9100#discussion_r474930329 ## File path: core/src/main/scala/kafka/server/AlterIsrChannelManager.scala ## @@ -0,0 +1,132 @@ +package kafka.server + +import java.util +import

[GitHub] [kafka] mumrah commented on a change in pull request #9100: Add AlterISR RPC and use it for ISR modifications

mumrah commented on a change in pull request #9100: URL: https://github.com/apache/kafka/pull/9100#discussion_r474106591 ## File path: core/src/main/scala/kafka/server/AlterIsrChannelManager.scala ## @@ -0,0 +1,132 @@ +package kafka.server + +import java.util +import

[GitHub] [kafka] mumrah commented on a change in pull request #9100: Add AlterISR RPC and use it for ISR modifications

mumrah commented on a change in pull request #9100: URL: https://github.com/apache/kafka/pull/9100#discussion_r474106591 ## File path: core/src/main/scala/kafka/server/AlterIsrChannelManager.scala ## @@ -0,0 +1,132 @@ +package kafka.server + +import java.util +import

[GitHub] [kafka] mumrah commented on a change in pull request #9100: Add AlterISR RPC and use it for ISR modifications

mumrah commented on a change in pull request #9100: URL: https://github.com/apache/kafka/pull/9100#discussion_r474070847 ## File path: core/src/main/scala/kafka/server/AlterIsrChannelManager.scala ## @@ -0,0 +1,132 @@ +package kafka.server + +import java.util +import

[GitHub] [kafka] mumrah commented on a change in pull request #9100: Add AlterISR RPC and use it for ISR modifications

mumrah commented on a change in pull request #9100: URL: https://github.com/apache/kafka/pull/9100#discussion_r474070847 ## File path: core/src/main/scala/kafka/server/AlterIsrChannelManager.scala ## @@ -0,0 +1,132 @@ +package kafka.server + +import java.util +import

[GitHub] [kafka] mumrah commented on a change in pull request #9100: Add AlterISR RPC and use it for ISR modifications

mumrah commented on a change in pull request #9100: URL: https://github.com/apache/kafka/pull/9100#discussion_r474070847 ## File path: core/src/main/scala/kafka/server/AlterIsrChannelManager.scala ## @@ -0,0 +1,132 @@ +package kafka.server + +import java.util +import

[GitHub] [kafka] mumrah commented on a change in pull request #9100: Add AlterISR RPC and use it for ISR modifications

mumrah commented on a change in pull request #9100: URL: https://github.com/apache/kafka/pull/9100#discussion_r470678123 ## File path: core/src/main/scala/kafka/cluster/Partition.scala ## @@ -255,6 +255,10 @@ class Partition(val topicPartition: TopicPartition, def

[GitHub] [kafka] mumrah commented on a change in pull request #9100: Add AlterISR RPC and use it for ISR modifications

mumrah commented on a change in pull request #9100: URL: https://github.com/apache/kafka/pull/9100#discussion_r470675300 ## File path: core/src/main/scala/kafka/server/AlterIsrChannelManager.scala ## @@ -0,0 +1,132 @@ +package kafka.server + +import java.util +import

[GitHub] [kafka] mumrah commented on a change in pull request #9100: Add AlterISR RPC and use it for ISR modifications

mumrah commented on a change in pull request #9100: URL: https://github.com/apache/kafka/pull/9100#discussion_r470673412 ## File path: core/src/main/scala/kafka/server/AlterIsrChannelManager.scala ## @@ -0,0 +1,132 @@ +package kafka.server + +import java.util +import

[GitHub] [kafka] mumrah commented on a change in pull request #9100: Add AlterISR RPC and use it for ISR modifications

mumrah commented on a change in pull request #9100: URL: https://github.com/apache/kafka/pull/9100#discussion_r470063833 ## File path: core/src/main/scala/kafka/cluster/Partition.scala ## @@ -485,13 +490,11 @@ class Partition(val topicPartition: TopicPartition, def

[GitHub] [kafka] mumrah commented on a change in pull request #9100: Add AlterISR RPC and use it for ISR modifications

mumrah commented on a change in pull request #9100: URL: https://github.com/apache/kafka/pull/9100#discussion_r470053173 ## File path: core/src/main/scala/kafka/cluster/Partition.scala ## @@ -569,8 +575,8 @@ class Partition(val topicPartition: TopicPartition, val

[GitHub] [kafka] mumrah commented on a change in pull request #9100: Add AlterISR RPC and use it for ISR modifications

mumrah commented on a change in pull request #9100: URL: https://github.com/apache/kafka/pull/9100#discussion_r469467881 ## File path: core/src/main/scala/kafka/cluster/Partition.scala ## @@ -1210,28 +1218,20 @@ class Partition(val topicPartition: TopicPartition, } }

[GitHub] [kafka] mumrah commented on a change in pull request #9100: Add AlterISR RPC and use it for ISR modifications

mumrah commented on a change in pull request #9100: URL: https://github.com/apache/kafka/pull/9100#discussion_r469460462 ## File path: core/src/main/scala/kafka/server/AlterIsrChannelManager.scala ## @@ -0,0 +1,132 @@ +package kafka.server + +import java.util +import

[GitHub] [kafka] mumrah commented on a change in pull request #9100: Add AlterISR RPC and use it for ISR modifications

mumrah commented on a change in pull request #9100: URL: https://github.com/apache/kafka/pull/9100#discussion_r465750632 ## File path: core/src/main/scala/kafka/server/AlterIsrChannelManager.scala ## @@ -0,0 +1,132 @@ +package kafka.server + +import java.util +import

[GitHub] [kafka] mumrah commented on a change in pull request #9100: Add AlterISR RPC and use it for ISR modifications

mumrah commented on a change in pull request #9100: URL: https://github.com/apache/kafka/pull/9100#discussion_r465750445 ## File path: core/src/main/scala/kafka/server/AlterIsrChannelManager.scala ## @@ -0,0 +1,132 @@ +package kafka.server + +import java.util +import

[GitHub] [kafka] mumrah commented on a change in pull request #9100: Add AlterISR RPC and use it for ISR modifications

mumrah commented on a change in pull request #9100: URL: https://github.com/apache/kafka/pull/9100#discussion_r465749546 ## File path: core/src/main/scala/kafka/server/AlterIsrChannelManager.scala ## @@ -0,0 +1,132 @@ +package kafka.server + +import java.util +import

[GitHub] [kafka] mumrah commented on a change in pull request #9100: Add AlterISR RPC and use it for ISR modifications

mumrah commented on a change in pull request #9100: URL: https://github.com/apache/kafka/pull/9100#discussion_r465749546 ## File path: core/src/main/scala/kafka/server/AlterIsrChannelManager.scala ## @@ -0,0 +1,132 @@ +package kafka.server + +import java.util +import

[GitHub] [kafka] mumrah commented on a change in pull request #9100: Add AlterISR RPC and use it for ISR modifications

mumrah commented on a change in pull request #9100: URL: https://github.com/apache/kafka/pull/9100#discussion_r465748120 ## File path: core/src/main/scala/kafka/controller/KafkaController.scala ## @@ -1771,6 +1776,141 @@ class KafkaController(val config: KafkaConfig, }

[GitHub] [kafka] mumrah commented on a change in pull request #9100: Add AlterISR RPC and use it for ISR modifications

mumrah commented on a change in pull request #9100: URL: https://github.com/apache/kafka/pull/9100#discussion_r465748504 ## File path: core/src/main/scala/kafka/server/AlterIsrChannelManager.scala ## @@ -0,0 +1,121 @@ +package kafka.server Review comment: Yea, maybe

[GitHub] [kafka] mumrah commented on a change in pull request #9100: Add AlterISR RPC and use it for ISR modifications

mumrah commented on a change in pull request #9100: URL: https://github.com/apache/kafka/pull/9100#discussion_r465746162 ## File path: core/src/main/scala/kafka/controller/KafkaController.scala ## @@ -1771,6 +1776,141 @@ class KafkaController(val config: KafkaConfig, }

[GitHub] [kafka] mumrah commented on a change in pull request #9100: Add AlterISR RPC and use it for ISR modifications

mumrah commented on a change in pull request #9100: URL: https://github.com/apache/kafka/pull/9100#discussion_r465743922 ## File path: core/src/main/scala/kafka/controller/KafkaController.scala ## @@ -1771,6 +1775,127 @@ class KafkaController(val config: KafkaConfig, }

[GitHub] [kafka] mumrah commented on a change in pull request #9100: Add AlterISR RPC and use it for ISR modifications

mumrah commented on a change in pull request #9100: URL: https://github.com/apache/kafka/pull/9100#discussion_r465029352 ## File path: core/src/main/scala/kafka/controller/KafkaController.scala ## @@ -1771,6 +1775,127 @@ class KafkaController(val config: KafkaConfig, }

[GitHub] [kafka] mumrah commented on a change in pull request #9100: Add AlterISR RPC and use it for ISR modifications

mumrah commented on a change in pull request #9100: URL: https://github.com/apache/kafka/pull/9100#discussion_r464717171 ## File path: core/src/main/scala/kafka/controller/KafkaController.scala ## @@ -1771,6 +1775,127 @@ class KafkaController(val config: KafkaConfig, }

[GitHub] [kafka] mumrah commented on a change in pull request #9100: Add AlterISR RPC and use it for ISR modifications

mumrah commented on a change in pull request #9100: URL: https://github.com/apache/kafka/pull/9100#discussion_r464716040 ## File path: core/src/main/scala/kafka/server/AlterIsrChannelManager.scala ## @@ -0,0 +1,121 @@ +package kafka.server + +import java.util +import