Re: [PR] KAFKA-15468 [1/2]: Prevent transaction coordinator reloads on already loaded leaders [kafka]

2024-01-23 Thread via GitHub
jolshan merged PR #15139: URL: https://github.com/apache/kafka/pull/15139 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.

Re: [PR] KAFKA-15468 [1/2]: Prevent transaction coordinator reloads on already loaded leaders [kafka]

2024-01-16 Thread via GitHub
jolshan commented on code in PR #15139: URL: https://github.com/apache/kafka/pull/15139#discussion_r1453752473 ## checkstyle/suppressions.xml: ## @@ -315,7 +315,7 @@ + files="(PartitionRegistration|PartitionChangeBuilder|TopicDelta).java"/> Review Comm

Re: [PR] KAFKA-15468 [1/2]: Prevent transaction coordinator reloads on already loaded leaders [kafka]

2024-01-12 Thread via GitHub
jsancio commented on code in PR #15139: URL: https://github.com/apache/kafka/pull/15139#discussion_r1451075038 ## checkstyle/suppressions.xml: ## @@ -315,7 +315,7 @@ + files="(PartitionRegistration|PartitionChangeBuilder|TopicDelta).java"/> Review Comm

Re: [PR] KAFKA-15468 [1/2]: Prevent transaction coordinator reloads on already loaded leaders [kafka]

2024-01-12 Thread via GitHub
jolshan commented on code in PR #15139: URL: https://github.com/apache/kafka/pull/15139#discussion_r1451051792 ## checkstyle/suppressions.xml: ## @@ -315,7 +315,7 @@ + files="(PartitionRegistration|PartitionChangeBuilder|TopicDelta).java"/> Review Comm

Re: [PR] KAFKA-15468 [1/2]: Prevent transaction coordinator reloads on already loaded leaders [kafka]

2024-01-12 Thread via GitHub
jsancio commented on code in PR #15139: URL: https://github.com/apache/kafka/pull/15139#discussion_r1451037707 ## checkstyle/suppressions.xml: ## @@ -315,7 +315,7 @@ + files="(PartitionRegistration|PartitionChangeBuilder|TopicDelta).java"/> Review Comm

Re: [PR] KAFKA-15468 [1/2]: Prevent transaction coordinator reloads on already loaded leaders [kafka]

2024-01-09 Thread via GitHub
jolshan commented on code in PR #15139: URL: https://github.com/apache/kafka/pull/15139#discussion_r1446756748 ## metadata/src/main/java/org/apache/kafka/image/LocalReplicaChanges.java: ## @@ -27,21 +27,24 @@ public final class LocalReplicaChanges { private final Set del

Re: [PR] KAFKA-15468 [1/2]: Prevent transaction coordinator reloads on already loaded leaders [kafka]

2024-01-09 Thread via GitHub
jolshan commented on code in PR #15139: URL: https://github.com/apache/kafka/pull/15139#discussion_r1446743080 ## metadata/src/main/java/org/apache/kafka/image/LocalReplicaChanges.java: ## @@ -27,21 +27,24 @@ public final class LocalReplicaChanges { private final Set del

Re: [PR] KAFKA-15468 [1/2]: Prevent transaction coordinator reloads on already loaded leaders [kafka]

2024-01-09 Thread via GitHub
jolshan commented on code in PR #15139: URL: https://github.com/apache/kafka/pull/15139#discussion_r1446742642 ## metadata/src/main/java/org/apache/kafka/image/LocalReplicaChanges.java: ## @@ -27,21 +27,24 @@ public final class LocalReplicaChanges { private final Set del

Re: [PR] KAFKA-15468 [1/2]: Prevent transaction coordinator reloads on already loaded leaders [kafka]

2024-01-09 Thread via GitHub
artemlivshits commented on code in PR #15139: URL: https://github.com/apache/kafka/pull/15139#discussion_r1446724899 ## metadata/src/main/java/org/apache/kafka/image/LocalReplicaChanges.java: ## @@ -27,21 +27,24 @@ public final class LocalReplicaChanges { private final S

Re: [PR] KAFKA-15468 [1/2]: Prevent transaction coordinator reloads on already loaded leaders [kafka]

2024-01-09 Thread via GitHub
jolshan commented on code in PR #15139: URL: https://github.com/apache/kafka/pull/15139#discussion_r1446488616 ## metadata/src/main/java/org/apache/kafka/image/LocalReplicaChanges.java: ## @@ -27,21 +27,24 @@ public final class LocalReplicaChanges { private final Set del

Re: [PR] KAFKA-15468 [1/2]: Prevent transaction coordinator reloads on already loaded leaders [kafka]

2024-01-08 Thread via GitHub
artemlivshits commented on code in PR #15139: URL: https://github.com/apache/kafka/pull/15139#discussion_r1445523263 ## metadata/src/main/java/org/apache/kafka/image/LocalReplicaChanges.java: ## @@ -27,21 +27,24 @@ public final class LocalReplicaChanges { private final S

Re: [PR] KAFKA-15468 [1/2]: Prevent transaction coordinator reloads on already loaded leaders [kafka]

2024-01-08 Thread via GitHub
jolshan commented on code in PR #15139: URL: https://github.com/apache/kafka/pull/15139#discussion_r1445497051 ## metadata/src/main/java/org/apache/kafka/image/LocalReplicaChanges.java: ## @@ -27,21 +27,24 @@ public final class LocalReplicaChanges { private final Set del

Re: [PR] KAFKA-15468 [1/2]: Prevent transaction coordinator reloads on already loaded leaders [kafka]

2024-01-08 Thread via GitHub
jolshan commented on code in PR #15139: URL: https://github.com/apache/kafka/pull/15139#discussion_r1445493478 ## metadata/src/main/java/org/apache/kafka/image/LocalReplicaChanges.java: ## @@ -27,21 +27,24 @@ public final class LocalReplicaChanges { private final Set del

Re: [PR] KAFKA-15468 [1/2]: Prevent transaction coordinator reloads on already loaded leaders [kafka]

2024-01-05 Thread via GitHub
jolshan commented on code in PR #15139: URL: https://github.com/apache/kafka/pull/15139#discussion_r1443569935 ## metadata/src/main/java/org/apache/kafka/image/LocalReplicaChanges.java: ## @@ -27,21 +27,24 @@ public final class LocalReplicaChanges { private final Set del

Re: [PR] KAFKA-15468 [1/2]: Prevent transaction coordinator reloads on already loaded leaders [kafka]

2024-01-05 Thread via GitHub
jolshan commented on code in PR #15139: URL: https://github.com/apache/kafka/pull/15139#discussion_r1443569042 ## metadata/src/main/java/org/apache/kafka/image/LocalReplicaChanges.java: ## @@ -27,21 +27,24 @@ public final class LocalReplicaChanges { private final Set del

Re: [PR] KAFKA-15468 [1/2]: Prevent transaction coordinator reloads on already loaded leaders [kafka]

2024-01-05 Thread via GitHub
artemlivshits commented on code in PR #15139: URL: https://github.com/apache/kafka/pull/15139#discussion_r1443564382 ## metadata/src/main/java/org/apache/kafka/image/LocalReplicaChanges.java: ## @@ -27,21 +27,24 @@ public final class LocalReplicaChanges { private final S

[PR] KAFKA-15468 [1/2]: Prevent transaction coordinator reloads on already loaded leaders [kafka]

2024-01-05 Thread via GitHub
jolshan opened a new pull request, #15139: URL: https://github.com/apache/kafka/pull/15139 This originally was https://github.com/apache/kafka/pull/14489 which covered 2 aspects -- reloading on partition epoch changes where leader epoch did not change and reloading when leader epoch changed