Re: [PR] KAFKA-15592: Allow member to not sending a heartbeat when a group ID is configured [kafka]

2023-12-19 Thread via GitHub
philipnee closed pull request #14390: KAFKA-15592: Allow member to not sending a heartbeat when a group ID is configured URL: https://github.com/apache/kafka/pull/14390 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

Re: [PR] KAFKA-15592: Allow member to not sending a heartbeat when a group ID is configured [kafka]

2023-10-16 Thread via GitHub
lianetm commented on code in PR #14390: URL: https://github.com/apache/kafka/pull/14390#discussion_r1361391346 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/CommitRequestManager.java: ## @@ -231,25 +246,23 @@ public NetworkClientDelegate.UnsentRequest toU

Re: [PR] KAFKA-15592: Allow member to not sending a heartbeat when a group ID is configured [kafka]

2023-10-16 Thread via GitHub
philipnee commented on code in PR #14390: URL: https://github.com/apache/kafka/pull/14390#discussion_r1361278043 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/MembershipManagerImpl.java: ## @@ -142,9 +142,26 @@ public void transitionToFailed() { t

Re: [PR] KAFKA-15592: Allow member to not sending a heartbeat when a group ID is configured [kafka]

2023-10-16 Thread via GitHub
philipnee commented on code in PR #14390: URL: https://github.com/apache/kafka/pull/14390#discussion_r1361276961 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/CommitRequestManager.java: ## @@ -209,15 +218,21 @@ public NetworkClientDelegate.UnsentRequest t

Re: [PR] KAFKA-15592: Allow member to not sending a heartbeat when a group ID is configured [kafka]

2023-10-16 Thread via GitHub
philipnee commented on code in PR #14390: URL: https://github.com/apache/kafka/pull/14390#discussion_r1361164387 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/MembershipManagerImpl.java: ## @@ -142,9 +142,26 @@ public void transitionToFailed() { t

Re: [PR] KAFKA-15592: Allow member to not sending a heartbeat when a group ID is configured [kafka]

2023-10-16 Thread via GitHub
philipnee commented on code in PR #14390: URL: https://github.com/apache/kafka/pull/14390#discussion_r1361155881 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/MembershipManagerImpl.java: ## @@ -142,9 +142,26 @@ public void transitionToFailed() { t

Re: [PR] KAFKA-15592: Allow member to not sending a heartbeat when a group ID is configured [kafka]

2023-10-16 Thread via GitHub
philipnee commented on code in PR #14390: URL: https://github.com/apache/kafka/pull/14390#discussion_r1361155030 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/CommitRequestManager.java: ## @@ -231,25 +246,23 @@ public NetworkClientDelegate.UnsentRequest t

Re: [PR] KAFKA-15592: Allow member to not sending a heartbeat when a group ID is configured [kafka]

2023-10-13 Thread via GitHub
lianetm commented on code in PR #14390: URL: https://github.com/apache/kafka/pull/14390#discussion_r1358432414 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/CommitRequestManager.java: ## @@ -231,25 +246,23 @@ public NetworkClientDelegate.UnsentRequest toU

Re: [PR] KAFKA-15592: Allow member to not sending a heartbeat when a group ID is configured [kafka]

2023-10-13 Thread via GitHub
lianetm commented on code in PR #14390: URL: https://github.com/apache/kafka/pull/14390#discussion_r1358337681 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/MembershipManagerImpl.java: ## @@ -142,9 +142,26 @@ public void transitionToFailed() { tra

Re: [PR] KAFKA-15592: Allow member to not sending a heartbeat when a group ID is configured [kafka]

2023-10-13 Thread via GitHub
lianetm commented on code in PR #14390: URL: https://github.com/apache/kafka/pull/14390#discussion_r1358313112 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/CommitRequestManager.java: ## @@ -209,15 +218,21 @@ public NetworkClientDelegate.UnsentRequest toU

Re: [PR] KAFKA-15592: Allow member to not sending a heartbeat when a group ID is configured [kafka]

2023-10-13 Thread via GitHub
lianetm commented on code in PR #14390: URL: https://github.com/apache/kafka/pull/14390#discussion_r1358311725 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/CommitRequestManager.java: ## @@ -173,19 +179,22 @@ CompletableFuture sendAutoCommit(final Map off

Re: [PR] KAFKA-15592: Allow member to not sending a heartbeat when a group ID is configured [kafka]

2023-10-13 Thread via GitHub
lianetm commented on code in PR #14390: URL: https://github.com/apache/kafka/pull/14390#discussion_r1358318907 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/CommitRequestManager.java: ## @@ -231,25 +246,23 @@ public NetworkClientDelegate.UnsentRequest toU