[PR] KAFKA-15653: Pass requestLocal as argument to callback so we use the correct one for the thread [kafka]

jolshan opened a new pull request, #14712: URL: https://github.com/apache/kafka/pull/14712 With the new callback mechanism we were accidentally passing context with the wrong request local. Now include a RequestLocal as an explicit argument to the callback. Also make the arguments pa

Re: [PR] KAFKA-15653: Pass requestLocal as argument to callback so we use the correct one for the thread [kafka]

jolshan merged PR #14629: URL: https://github.com/apache/kafka/pull/14629 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.

Re: [PR] KAFKA-15653: Pass requestLocal as argument to callback so we use the correct one for the thread [kafka]

jolshan commented on PR #14629: URL: https://github.com/apache/kafka/pull/14629#issuecomment-1800331351 Thanks @divijvaidya. I was taking a look at Gradle enterprise as well. But the link is helpful -- This is an automated message from the Apache Git Service. To respond to the message, pl

Re: [PR] KAFKA-15653: Pass requestLocal as argument to callback so we use the correct one for the thread [kafka]

divijvaidya commented on PR #14629: URL: https://github.com/apache/kafka/pull/14629#issuecomment-1800218167 Hey @jolshan - You might already know this but sharing in case you don't. A tool I use to quickly find whether a test is flaky is https://ge.apache.org/scans/tests?search.rootProjectN

Re: [PR] KAFKA-15653: Pass requestLocal as argument to callback so we use the correct one for the thread [kafka]

junrao commented on PR #14629: URL: https://github.com/apache/kafka/pull/14629#issuecomment-1800110570 @jolshan : Thanks for the analysis. If the test failures are unrelated, feel free to merge the PR. It would be useful to file jiras to track new transient test failures. -- This is an a

Re: [PR] KAFKA-15653: Pass requestLocal as argument to callback so we use the correct one for the thread [kafka]

jolshan commented on PR #14629: URL: https://github.com/apache/kafka/pull/14629#issuecomment-1799582958 I took a look at the most recent 19 failures. The majority of them are failing on trunk in the last few (5 or so) runs. I will take a look at the remaining ones I didn't see failing on

Re: [PR] KAFKA-15653: Pass requestLocal as argument to callback so we use the correct one for the thread [kafka]

jolshan commented on PR #14629: URL: https://github.com/apache/kafka/pull/14629#issuecomment-1796388941 This one only had 4 failures from usual suspects. I will run one more time https://ci-builds.apache.org/job/Kafka/job/kafka-pr/job/PR-14629/17/ -- This is an automated message from th

Re: [PR] KAFKA-15653: Pass requestLocal as argument to callback so we use the correct one for the thread [kafka]

artemlivshits commented on code in PR #14629: URL: https://github.com/apache/kafka/pull/14629#discussion_r1383785302 ## core/src/main/scala/kafka/server/ReplicaManager.scala: ## @@ -864,6 +778,111 @@ class ReplicaManager(val config: KafkaConfig, } } + /* + * Note: T

Re: [PR] KAFKA-15653: Pass requestLocal as argument to callback so we use the correct one for the thread [kafka]

jolshan commented on PR #14629: URL: https://github.com/apache/kafka/pull/14629#issuecomment-1795753522 Given that I made minimal changes and the previous tests only had 10-15 or so regular flakes, I don't think so. But I will investigate. -- This is an automated message from the Apac

Re: [PR] KAFKA-15653: Pass requestLocal as argument to callback so we use the correct one for the thread [kafka]

junrao commented on PR #14629: URL: https://github.com/apache/kafka/pull/14629#issuecomment-1795726859 @jolshan : Are the 39 test failures related to the PR? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abov

Re: [PR] KAFKA-15653: Pass requestLocal as argument to callback so we use the correct one for the thread [kafka]

jolshan commented on code in PR #14629: URL: https://github.com/apache/kafka/pull/14629#discussion_r1382262985 ## core/src/main/scala/kafka/server/KafkaRequestHandler.scala: ## @@ -50,28 +50,32 @@ object KafkaRequestHandler { } /** - * Wrap callback to schedule it on a

Re: [PR] KAFKA-15653: Pass requestLocal as argument to callback so we use the correct one for the thread [kafka]

junrao commented on code in PR #14629: URL: https://github.com/apache/kafka/pull/14629#discussion_r1382212898 ## core/src/main/scala/kafka/server/KafkaRequestHandler.scala: ## @@ -50,28 +50,32 @@ object KafkaRequestHandler { } /** - * Wrap callback to schedule it on a

Re: [PR] KAFKA-15653: Pass requestLocal as argument to callback so we use the correct one for the thread [kafka]

jolshan commented on code in PR #14629: URL: https://github.com/apache/kafka/pull/14629#discussion_r1382176455 ## core/src/main/scala/kafka/server/KafkaRequestHandler.scala: ## @@ -50,28 +50,36 @@ object KafkaRequestHandler { } /** - * Wrap callback to schedule it on a

Re: [PR] KAFKA-15653: Pass requestLocal as argument to callback so we use the correct one for the thread [kafka]

junrao commented on code in PR #14629: URL: https://github.com/apache/kafka/pull/14629#discussion_r1382035051 ## core/src/main/scala/kafka/server/ReplicaManager.scala: ## @@ -864,6 +778,111 @@ class ReplicaManager(val config: KafkaConfig, } } + /* + * Note: This met

Re: [PR] KAFKA-15653: Pass requestLocal as argument to callback so we use the correct one for the thread [kafka]

jolshan commented on PR #14629: URL: https://github.com/apache/kafka/pull/14629#issuecomment-1792854022 > Just to be clear. The txn verification for consumer offset is in trunk and still needs to be fixed, right? Yes. We will need to fix for 3.7. Here is the JIRA: https://issues.apac

Re: [PR] KAFKA-15653: Pass requestLocal as argument to callback so we use the correct one for the thread [kafka]

jolshan commented on code in PR #14629: URL: https://github.com/apache/kafka/pull/14629#discussion_r138262 ## core/src/main/scala/kafka/server/KafkaRequestHandler.scala: ## @@ -50,28 +50,36 @@ object KafkaRequestHandler { } /** - * Wrap callback to schedule it on a

Re: [PR] KAFKA-15653: Pass requestLocal as argument to callback so we use the correct one for the thread [kafka]

junrao commented on code in PR #14629: URL: https://github.com/apache/kafka/pull/14629#discussion_r1381976028 ## core/src/main/scala/kafka/server/KafkaRequestHandler.scala: ## @@ -50,28 +50,36 @@ object KafkaRequestHandler { } /** - * Wrap callback to schedule it on a

Re: [PR] KAFKA-15653: Pass requestLocal as argument to callback so we use the correct one for the thread [kafka]

jolshan commented on code in PR #14629: URL: https://github.com/apache/kafka/pull/14629#discussion_r1381971423 ## core/src/main/scala/kafka/server/ReplicaManager.scala: ## @@ -864,6 +778,111 @@ class ReplicaManager(val config: KafkaConfig, } } + /* + * Note: This me

Re: [PR] KAFKA-15653: Pass requestLocal as argument to callback so we use the correct one for the thread [kafka]

jolshan commented on code in PR #14629: URL: https://github.com/apache/kafka/pull/14629#discussion_r1381971423 ## core/src/main/scala/kafka/server/ReplicaManager.scala: ## @@ -864,6 +778,111 @@ class ReplicaManager(val config: KafkaConfig, } } + /* + * Note: This me

Re: [PR] KAFKA-15653: Pass requestLocal as argument to callback so we use the correct one for the thread [kafka]

junrao commented on code in PR #14629: URL: https://github.com/apache/kafka/pull/14629#discussion_r1381953916 ## core/src/main/scala/kafka/server/ReplicaManager.scala: ## @@ -864,6 +778,111 @@ class ReplicaManager(val config: KafkaConfig, } } + /* + * Note: This met

Re: [PR] KAFKA-15653: Pass requestLocal as argument to callback so we use the correct one for the thread [kafka]

junrao commented on code in PR #14629: URL: https://github.com/apache/kafka/pull/14629#discussion_r1381953916 ## core/src/main/scala/kafka/server/ReplicaManager.scala: ## @@ -864,6 +778,111 @@ class ReplicaManager(val config: KafkaConfig, } } + /* + * Note: This met

Re: [PR] KAFKA-15653: Pass requestLocal as argument to callback so we use the correct one for the thread [kafka]

junrao commented on code in PR #14629: URL: https://github.com/apache/kafka/pull/14629#discussion_r1381953916 ## core/src/main/scala/kafka/server/ReplicaManager.scala: ## @@ -864,6 +778,111 @@ class ReplicaManager(val config: KafkaConfig, } } + /* + * Note: This met

Re: [PR] KAFKA-15653: Pass requestLocal as argument to callback so we use the correct one for the thread [kafka]

junrao commented on code in PR #14629: URL: https://github.com/apache/kafka/pull/14629#discussion_r1381953916 ## core/src/main/scala/kafka/server/ReplicaManager.scala: ## @@ -864,6 +778,111 @@ class ReplicaManager(val config: KafkaConfig, } } + /* + * Note: This met

Re: [PR] KAFKA-15653: Pass requestLocal as argument to callback so we use the correct one for the thread [kafka]

jolshan commented on PR #14629: URL: https://github.com/apache/kafka/pull/14629#issuecomment-1792695126 It seems the offset validation is a tricky question requiring more thought, so I will file a jira for it. Given that the offset verification is not in 3.6, I think it makes sense to merge

Re: [PR] KAFKA-15653: Pass requestLocal as argument to callback so we use the correct one for the thread [kafka]

dajac commented on code in PR #14629: URL: https://github.com/apache/kafka/pull/14629#discussion_r1381380645 ## core/src/main/scala/kafka/server/ReplicaManager.scala: ## @@ -864,6 +778,111 @@ class ReplicaManager(val config: KafkaConfig, } } + /* + * Note: This meth

Re: [PR] KAFKA-15653: Pass requestLocal as argument to callback so we use the correct one for the thread [kafka]

dajac commented on code in PR #14629: URL: https://github.com/apache/kafka/pull/14629#discussion_r1381378455 ## core/src/main/scala/kafka/server/ReplicaManager.scala: ## @@ -864,6 +778,111 @@ class ReplicaManager(val config: KafkaConfig, } } + /* + * Note: This meth

Re: [PR] KAFKA-15653: Pass requestLocal as argument to callback so we use the correct one for the thread [kafka]

jolshan commented on code in PR #14629: URL: https://github.com/apache/kafka/pull/14629#discussion_r1380898562 ## core/src/main/scala/kafka/server/ReplicaManager.scala: ## @@ -864,6 +778,111 @@ class ReplicaManager(val config: KafkaConfig, } } + /* + * Note: This me

Re: [PR] KAFKA-15653: Pass requestLocal as argument to callback so we use the correct one for the thread [kafka]

jolshan commented on code in PR #14629: URL: https://github.com/apache/kafka/pull/14629#discussion_r1380899701 ## core/src/main/scala/kafka/server/ReplicaManager.scala: ## @@ -864,6 +778,111 @@ class ReplicaManager(val config: KafkaConfig, } } + /* + * Note: This me

Re: [PR] KAFKA-15653: Pass requestLocal as argument to callback so we use the correct one for the thread [kafka]

jolshan commented on code in PR #14629: URL: https://github.com/apache/kafka/pull/14629#discussion_r1380898562 ## core/src/main/scala/kafka/server/ReplicaManager.scala: ## @@ -864,6 +778,111 @@ class ReplicaManager(val config: KafkaConfig, } } + /* + * Note: This me

Re: [PR] KAFKA-15653: Pass requestLocal as argument to callback so we use the correct one for the thread [kafka]

jolshan commented on code in PR #14629: URL: https://github.com/apache/kafka/pull/14629#discussion_r1380898562 ## core/src/main/scala/kafka/server/ReplicaManager.scala: ## @@ -864,6 +778,111 @@ class ReplicaManager(val config: KafkaConfig, } } + /* + * Note: This me

Re: [PR] KAFKA-15653: Pass requestLocal as argument to callback so we use the correct one for the thread [kafka]

junrao commented on code in PR #14629: URL: https://github.com/apache/kafka/pull/14629#discussion_r1380888754 ## core/src/main/scala/kafka/server/ReplicaManager.scala: ## @@ -864,6 +778,111 @@ class ReplicaManager(val config: KafkaConfig, } } + /* + * Note: This met

Re: [PR] KAFKA-15653: Pass requestLocal as argument to callback so we use the correct one for the thread [kafka]

jolshan commented on code in PR #14629: URL: https://github.com/apache/kafka/pull/14629#discussion_r1380469707 ## core/src/main/scala/kafka/server/ReplicaManager.scala: ## @@ -864,6 +778,111 @@ class ReplicaManager(val config: KafkaConfig, } } + /* + * Note: This me

Re: [PR] KAFKA-15653: Pass requestLocal as argument to callback so we use the correct one for the thread [kafka]

artemlivshits commented on code in PR #14629: URL: https://github.com/apache/kafka/pull/14629#discussion_r1380813788 ## core/src/main/scala/kafka/server/ReplicaManager.scala: ## @@ -864,6 +778,111 @@ class ReplicaManager(val config: KafkaConfig, } } + /* + * Note: T

Re: [PR] KAFKA-15653: Pass requestLocal as argument to callback so we use the correct one for the thread [kafka]

jolshan commented on code in PR #14629: URL: https://github.com/apache/kafka/pull/14629#discussion_r1380469707 ## core/src/main/scala/kafka/server/ReplicaManager.scala: ## @@ -864,6 +778,111 @@ class ReplicaManager(val config: KafkaConfig, } } + /* + * Note: This me

Re: [PR] KAFKA-15653: Pass requestLocal as argument to callback so we use the correct one for the thread [kafka]

jolshan commented on code in PR #14629: URL: https://github.com/apache/kafka/pull/14629#discussion_r1380752726 ## core/src/main/scala/kafka/server/ReplicaManager.scala: ## @@ -864,6 +778,111 @@ class ReplicaManager(val config: KafkaConfig, } } + /* + * Note: This me

Re: [PR] KAFKA-15653: Pass requestLocal as argument to callback so we use the correct one for the thread [kafka]

jolshan commented on code in PR #14629: URL: https://github.com/apache/kafka/pull/14629#discussion_r1380752726 ## core/src/main/scala/kafka/server/ReplicaManager.scala: ## @@ -864,6 +778,111 @@ class ReplicaManager(val config: KafkaConfig, } } + /* + * Note: This me

Re: [PR] KAFKA-15653: Pass requestLocal as argument to callback so we use the correct one for the thread [kafka]

junrao commented on code in PR #14629: URL: https://github.com/apache/kafka/pull/14629#discussion_r1380724965 ## core/src/main/scala/kafka/server/ReplicaManager.scala: ## @@ -864,6 +778,111 @@ class ReplicaManager(val config: KafkaConfig, } } + /* + * Note: This met

Re: [PR] KAFKA-15653: Pass requestLocal as argument to callback so we use the correct one for the thread [kafka]

hachikuji commented on code in PR #14629: URL: https://github.com/apache/kafka/pull/14629#discussion_r1380634456 ## core/src/main/scala/kafka/server/ReplicaManager.scala: ## @@ -864,6 +778,111 @@ class ReplicaManager(val config: KafkaConfig, } } + /* + * Note: This

Re: [PR] KAFKA-15653: Pass requestLocal as argument to callback so we use the correct one for the thread [kafka]

jolshan commented on code in PR #14629: URL: https://github.com/apache/kafka/pull/14629#discussion_r1380469707 ## core/src/main/scala/kafka/server/ReplicaManager.scala: ## @@ -864,6 +778,111 @@ class ReplicaManager(val config: KafkaConfig, } } + /* + * Note: This me

Re: [PR] KAFKA-15653: Pass requestLocal as argument to callback so we use the correct one for the thread [kafka]

dajac commented on code in PR #14629: URL: https://github.com/apache/kafka/pull/14629#discussion_r1379784888 ## core/src/main/scala/kafka/server/ReplicaManager.scala: ## @@ -864,6 +778,111 @@ class ReplicaManager(val config: KafkaConfig, } } + /* + * Note: This meth

Re: [PR] KAFKA-15653: Pass requestLocal as argument to callback so we use the correct one for the thread [kafka]

jolshan commented on code in PR #14629: URL: https://github.com/apache/kafka/pull/14629#discussion_r1379416743 ## core/src/main/scala/kafka/server/ReplicaManager.scala: ## @@ -864,6 +778,111 @@ class ReplicaManager(val config: KafkaConfig, } } + /* + * Note: This me

Re: [PR] KAFKA-15653: Pass requestLocal as argument to callback so we use the correct one for the thread [kafka]

hachikuji commented on code in PR #14629: URL: https://github.com/apache/kafka/pull/14629#discussion_r1379404877 ## core/src/main/scala/kafka/server/ReplicaManager.scala: ## @@ -864,6 +778,111 @@ class ReplicaManager(val config: KafkaConfig, } } + /* + * Note: This

Re: [PR] KAFKA-15653: Pass requestLocal as argument to callback so we use the correct one for the thread [kafka]

jolshan commented on code in PR #14629: URL: https://github.com/apache/kafka/pull/14629#discussion_r1379066906 ## core/src/main/scala/kafka/server/ReplicaManager.scala: ## @@ -864,6 +778,111 @@ class ReplicaManager(val config: KafkaConfig, } } + /* + * Note: This me

Re: [PR] KAFKA-15653: Pass requestLocal as argument to callback so we use the correct one for the thread [kafka]

junrao commented on code in PR #14629: URL: https://github.com/apache/kafka/pull/14629#discussion_r1379034752 ## core/src/main/scala/kafka/server/ReplicaManager.scala: ## @@ -864,6 +778,111 @@ class ReplicaManager(val config: KafkaConfig, } } + /* + * Note: This met

Re: [PR] KAFKA-15653: Pass requestLocal as argument to callback so we use the correct one for the thread [kafka]

jolshan commented on code in PR #14629: URL: https://github.com/apache/kafka/pull/14629#discussion_r1378272592 ## core/src/main/scala/kafka/server/ReplicaManager.scala: ## @@ -864,6 +781,111 @@ class ReplicaManager(val config: KafkaConfig, } } + /* + * Note: This me

Re: [PR] KAFKA-15653: Pass requestLocal as argument to callback so we use the correct one for the thread [kafka]

jolshan commented on code in PR #14629: URL: https://github.com/apache/kafka/pull/14629#discussion_r1378267516 ## core/src/main/scala/kafka/server/ReplicaManager.scala: ## @@ -864,6 +781,111 @@ class ReplicaManager(val config: KafkaConfig, } } + /* + * Note: This me

Re: [PR] KAFKA-15653: Pass requestLocal as argument to callback so we use the correct one for the thread [kafka]

jolshan commented on code in PR #14629: URL: https://github.com/apache/kafka/pull/14629#discussion_r1378225151 ## core/src/main/scala/kafka/server/KafkaRequestHandler.scala: ## @@ -50,28 +50,36 @@ object KafkaRequestHandler { } /** - * Wrap callback to schedule it on a

Re: [PR] KAFKA-15653: Pass requestLocal as argument to callback so we use the correct one for the thread [kafka]

hachikuji commented on code in PR #14629: URL: https://github.com/apache/kafka/pull/14629#discussion_r1378179666 ## core/src/main/scala/kafka/server/KafkaRequestHandler.scala: ## @@ -50,28 +50,36 @@ object KafkaRequestHandler { } /** - * Wrap callback to schedule it on

Re: [PR] KAFKA-15653: Pass requestLocal as argument to callback so we use the correct one for the thread [kafka]

jolshan commented on code in PR #14629: URL: https://github.com/apache/kafka/pull/14629#discussion_r1376866891 ## core/src/main/scala/kafka/server/KafkaRequestHandler.scala: ## @@ -55,23 +55,23 @@ object KafkaRequestHandler { * @param fun Callback function to execute * @

Re: [PR] KAFKA-15653: Pass requestLocal as argument to callback so we use the correct one for the thread [kafka]

jolshan commented on code in PR #14629: URL: https://github.com/apache/kafka/pull/14629#discussion_r1376866596 ## core/src/main/scala/kafka/server/KafkaRequestHandler.scala: ## @@ -53,25 +53,27 @@ object KafkaRequestHandler { * Wrap callback to schedule it on a request threa

Re: [PR] KAFKA-15653: Pass requestLocal as argument to callback so we use the correct one for the thread [kafka]

jolshan commented on code in PR #14629: URL: https://github.com/apache/kafka/pull/14629#discussion_r1376821250 ## core/src/main/scala/kafka/server/ReplicaManager.scala: ## @@ -864,6 +778,111 @@ class ReplicaManager(val config: KafkaConfig, } } + /* + * Note: This me

Re: [PR] KAFKA-15653: Pass requestLocal as argument to callback so we use the correct one for the thread [kafka]

artemlivshits commented on code in PR #14629: URL: https://github.com/apache/kafka/pull/14629#discussion_r1376817191 ## core/src/main/scala/kafka/server/ReplicaManager.scala: ## @@ -864,6 +778,111 @@ class ReplicaManager(val config: KafkaConfig, } } + /* + * Note: T

Re: [PR] KAFKA-15653: Pass requestLocal as argument to callback so we use the correct one for the thread [kafka]

jolshan commented on code in PR #14629: URL: https://github.com/apache/kafka/pull/14629#discussion_r1376679750 ## core/src/main/scala/kafka/server/ReplicaManager.scala: ## @@ -864,6 +778,111 @@ class ReplicaManager(val config: KafkaConfig, } } + /* + * Note: This me

Re: [PR] KAFKA-15653: Pass requestLocal as argument to callback so we use the correct one for the thread [kafka]

jolshan commented on code in PR #14629: URL: https://github.com/apache/kafka/pull/14629#discussion_r1376678541 ## core/src/main/scala/kafka/server/KafkaRequestHandler.scala: ## @@ -53,25 +53,27 @@ object KafkaRequestHandler { * Wrap callback to schedule it on a request threa

Re: [PR] KAFKA-15653: Pass requestLocal as argument to callback so we use the correct one for the thread [kafka]

junrao commented on code in PR #14629: URL: https://github.com/apache/kafka/pull/14629#discussion_r1376674826 ## core/src/main/scala/kafka/server/ReplicaManager.scala: ## @@ -864,6 +778,111 @@ class ReplicaManager(val config: KafkaConfig, } } + /* + * Note: This met

Re: [PR] KAFKA-15653: Pass requestLocal as argument to callback so we use the correct one for the thread [kafka]

junrao commented on code in PR #14629: URL: https://github.com/apache/kafka/pull/14629#discussion_r1376671529 ## core/src/main/scala/kafka/server/ReplicaManager.scala: ## @@ -864,6 +778,111 @@ class ReplicaManager(val config: KafkaConfig, } } + /* + * Note: This met

Re: [PR] KAFKA-15653: Pass requestLocal as argument to callback so we use the correct one for the thread [kafka]

jolshan commented on code in PR #14629: URL: https://github.com/apache/kafka/pull/14629#discussion_r1376670972 ## core/src/main/scala/kafka/server/ReplicaManager.scala: ## @@ -864,6 +778,111 @@ class ReplicaManager(val config: KafkaConfig, } } + /* + * Note: This me

Re: [PR] KAFKA-15653: Pass requestLocal as argument to callback so we use the correct one for the thread [kafka]

jolshan commented on code in PR #14629: URL: https://github.com/apache/kafka/pull/14629#discussion_r1376662251 ## core/src/main/scala/kafka/server/ReplicaManager.scala: ## @@ -864,6 +778,111 @@ class ReplicaManager(val config: KafkaConfig, } } + /* + * Note: This me

Re: [PR] KAFKA-15653: Pass requestLocal as argument to callback so we use the correct one for the thread [kafka]

junrao commented on code in PR #14629: URL: https://github.com/apache/kafka/pull/14629#discussion_r1376661650 ## core/src/main/scala/kafka/server/KafkaRequestHandler.scala: ## @@ -53,25 +53,27 @@ object KafkaRequestHandler { * Wrap callback to schedule it on a request thread

Re: [PR] KAFKA-15653: Pass requestLocal as argument to callback so we use the correct one for the thread [kafka]

jolshan commented on code in PR #14629: URL: https://github.com/apache/kafka/pull/14629#discussion_r1376659689 ## core/src/main/scala/kafka/server/KafkaRequestHandler.scala: ## @@ -53,25 +53,27 @@ object KafkaRequestHandler { * Wrap callback to schedule it on a request threa

Re: [PR] KAFKA-15653: Pass requestLocal as argument to callback so we use the correct one for the thread [kafka]

junrao commented on code in PR #14629: URL: https://github.com/apache/kafka/pull/14629#discussion_r1376657322 ## core/src/main/scala/kafka/server/KafkaRequestHandler.scala: ## @@ -53,25 +53,27 @@ object KafkaRequestHandler { * Wrap callback to schedule it on a request thread

Re: [PR] KAFKA-15653: Pass requestLocal as argument to callback so we use the correct one for the thread [kafka]

divijvaidya commented on code in PR #14629: URL: https://github.com/apache/kafka/pull/14629#discussion_r1376654240 ## core/src/main/scala/kafka/server/ReplicaManager.scala: ## @@ -864,6 +778,111 @@ class ReplicaManager(val config: KafkaConfig, } } + /* + * Note: Thi

Re: [PR] KAFKA-15653: Pass requestLocal as argument to callback so we use the correct one for the thread [kafka]

junrao commented on code in PR #14629: URL: https://github.com/apache/kafka/pull/14629#discussion_r1376651533 ## core/src/main/scala/kafka/server/ReplicaManager.scala: ## @@ -864,6 +778,111 @@ class ReplicaManager(val config: KafkaConfig, } } + /* + * Note: This met

Re: [PR] KAFKA-15653: Pass requestLocal as argument to callback so we use the correct one for the thread [kafka]

artemlivshits commented on code in PR #14629: URL: https://github.com/apache/kafka/pull/14629#discussion_r1376507019 ## core/src/main/scala/kafka/server/ReplicaManager.scala: ## @@ -864,6 +778,111 @@ class ReplicaManager(val config: KafkaConfig, } } + /* + * Note: T

Re: [PR] KAFKA-15653: Pass requestLocal as argument to callback so we use the correct one for the thread [kafka]

artemlivshits commented on code in PR #14629: URL: https://github.com/apache/kafka/pull/14629#discussion_r1376502780 ## core/src/main/scala/kafka/server/ReplicaManager.scala: ## @@ -864,6 +778,111 @@ class ReplicaManager(val config: KafkaConfig, } } + /* + * Note: T

Re: [PR] KAFKA-15653: Pass requestLocal as argument to callback so we use the correct one for the thread [kafka]

jolshan commented on code in PR #14629: URL: https://github.com/apache/kafka/pull/14629#discussion_r1376481605 ## core/src/main/scala/kafka/server/ReplicaManager.scala: ## @@ -864,6 +778,111 @@ class ReplicaManager(val config: KafkaConfig, } } + /* + * Note: This me

Re: [PR] KAFKA-15653: Pass requestLocal as argument to callback so we use the correct one for the thread [kafka]

ijuma commented on code in PR #14629: URL: https://github.com/apache/kafka/pull/14629#discussion_r1375357830 ## core/src/main/scala/kafka/server/ReplicaManager.scala: ## @@ -864,6 +778,111 @@ class ReplicaManager(val config: KafkaConfig, } } + /* + * Note: This meth

Re: [PR] KAFKA-15653: Pass requestLocal as argument to callback so we use the correct one for the thread [kafka]

artemlivshits commented on code in PR #14629: URL: https://github.com/apache/kafka/pull/14629#discussion_r1375355538 ## core/src/main/scala/kafka/server/ReplicaManager.scala: ## @@ -864,6 +778,111 @@ class ReplicaManager(val config: KafkaConfig, } } + /* + * Note: T

Re: [PR] KAFKA-15653: Pass requestLocal as argument to callback so we use the correct one for the thread [kafka]

ijuma commented on code in PR #14629: URL: https://github.com/apache/kafka/pull/14629#discussion_r1375332013 ## core/src/main/scala/kafka/server/ReplicaManager.scala: ## @@ -864,6 +778,111 @@ class ReplicaManager(val config: KafkaConfig, } } + /* + * Note: This meth

Re: [PR] KAFKA-15653: Pass requestLocal as argument to callback so we use the correct one for the thread [kafka]

artemlivshits commented on code in PR #14629: URL: https://github.com/apache/kafka/pull/14629#discussion_r1375329122 ## core/src/main/scala/kafka/server/ReplicaManager.scala: ## @@ -864,6 +778,111 @@ class ReplicaManager(val config: KafkaConfig, } } + /* + * Note: T

Re: [PR] KAFKA-15653: Pass requestLocal as argument to callback so we use the correct one for the thread [kafka]

ijuma commented on code in PR #14629: URL: https://github.com/apache/kafka/pull/14629#discussion_r1375263740 ## core/src/main/scala/kafka/server/ReplicaManager.scala: ## @@ -864,6 +778,111 @@ class ReplicaManager(val config: KafkaConfig, } } + /* + * Note: This meth

Re: [PR] KAFKA-15653: Pass requestLocal as argument to callback so we use the correct one for the thread [kafka]

ijuma commented on code in PR #14629: URL: https://github.com/apache/kafka/pull/14629#discussion_r1375262871 ## core/src/main/scala/kafka/server/KafkaRequestHandler.scala: ## @@ -55,23 +55,23 @@ object KafkaRequestHandler { * @param fun Callback function to execute * @re

Re: [PR] KAFKA-15653: Pass requestLocal as argument to callback so we use the correct one for the thread [kafka]

artemlivshits commented on code in PR #14629: URL: https://github.com/apache/kafka/pull/14629#discussion_r1375078778 ## core/src/main/scala/kafka/server/KafkaRequestHandler.scala: ## @@ -53,25 +53,27 @@ object KafkaRequestHandler { * Wrap callback to schedule it on a request

Re: [PR] KAFKA-15653: Pass requestLocal as argument to callback so we use the correct one for the thread [kafka]

jolshan commented on code in PR #14629: URL: https://github.com/apache/kafka/pull/14629#discussion_r1375061797 ## core/src/main/scala/kafka/server/KafkaRequestHandler.scala: ## @@ -53,25 +53,27 @@ object KafkaRequestHandler { * Wrap callback to schedule it on a request threa

Re: [PR] KAFKA-15653: Pass requestLocal as argument to callback so we use the correct one for the thread [kafka]

jolshan commented on code in PR #14629: URL: https://github.com/apache/kafka/pull/14629#discussion_r1375060752 ## core/src/main/scala/kafka/server/KafkaRequestHandler.scala: ## @@ -53,25 +53,27 @@ object KafkaRequestHandler { * Wrap callback to schedule it on a request threa

Re: [PR] KAFKA-15653: Pass requestLocal as argument to callback so we use the correct one for the thread [kafka]

junrao commented on code in PR #14629: URL: https://github.com/apache/kafka/pull/14629#discussion_r1375057023 ## core/src/main/scala/kafka/server/KafkaRequestHandler.scala: ## @@ -53,25 +53,27 @@ object KafkaRequestHandler { * Wrap callback to schedule it on a request thread

Re: [PR] KAFKA-15653: Pass requestLocal as argument to callback so we use the correct one for the thread [kafka]

jolshan commented on PR #14629: URL: https://github.com/apache/kafka/pull/14629#issuecomment-1783521458 Following up with build failure here: https://github.com/apache/kafka/pull/14545#issuecomment-1783515553 -- This is an automated message from the Apache Git Service. To respond to the m

Re: [PR] KAFKA-15653: Pass requestLocal as argument to callback so we use the correct one for the thread [kafka]

jolshan commented on code in PR #14629: URL: https://github.com/apache/kafka/pull/14629#discussion_r1375044842 ## core/src/main/scala/kafka/server/KafkaRequestHandler.scala: ## @@ -53,25 +53,27 @@ object KafkaRequestHandler { * Wrap callback to schedule it on a request threa

Re: [PR] KAFKA-15653: Pass requestLocal as argument to callback so we use the correct one for the thread [kafka]

junrao commented on code in PR #14629: URL: https://github.com/apache/kafka/pull/14629#discussion_r1375025398 ## core/src/main/scala/kafka/server/KafkaRequestHandler.scala: ## @@ -53,25 +53,27 @@ object KafkaRequestHandler { * Wrap callback to schedule it on a request thread

Re: [PR] KAFKA-15653: Pass requestLocal as argument to callback so we use the correct one for the thread [kafka]

artemlivshits commented on code in PR #14629: URL: https://github.com/apache/kafka/pull/14629#discussion_r1375016328 ## core/src/main/scala/kafka/server/KafkaRequestHandler.scala: ## @@ -53,25 +53,27 @@ object KafkaRequestHandler { * Wrap callback to schedule it on a request

Re: [PR] KAFKA-15653: Pass requestLocal as argument to callback so we use the correct one for the thread [kafka]

jolshan commented on code in PR #14629: URL: https://github.com/apache/kafka/pull/14629#discussion_r1374844889 ## core/src/main/scala/kafka/server/KafkaRequestHandler.scala: ## @@ -53,25 +53,27 @@ object KafkaRequestHandler { * Wrap callback to schedule it on a request threa

Re: [PR] KAFKA-15653: Pass requestLocal as argument to callback so we use the correct one for the thread [kafka]

junrao commented on code in PR #14629: URL: https://github.com/apache/kafka/pull/14629#discussion_r1374839084 ## core/src/main/scala/kafka/server/KafkaRequestHandler.scala: ## @@ -53,25 +53,27 @@ object KafkaRequestHandler { * Wrap callback to schedule it on a request thread

Re: [PR] KAFKA-15653: Pass requestLocal as argument to callback so we use the correct one for the thread [kafka]

jolshan commented on code in PR #14629: URL: https://github.com/apache/kafka/pull/14629#discussion_r1373793336 ## core/src/main/scala/kafka/server/ReplicaManager.scala: ## @@ -864,6 +778,111 @@ class ReplicaManager(val config: KafkaConfig, } } + /* + * Note: This me

Re: [PR] KAFKA-15653: Pass requestLocal as argument to callback so we use the correct one for the thread [kafka]

divijvaidya commented on code in PR #14629: URL: https://github.com/apache/kafka/pull/14629#discussion_r1373548000 ## core/src/main/scala/kafka/server/ReplicaManager.scala: ## @@ -864,6 +778,111 @@ class ReplicaManager(val config: KafkaConfig, } } + /* + * Note: Thi

Re: [PR] KAFKA-15653: Pass requestLocal as argument to callback so we use the correct one for the thread [kafka]

jolshan commented on code in PR #14629: URL: https://github.com/apache/kafka/pull/14629#discussion_r1373532105 ## core/src/main/scala/kafka/server/ReplicaManager.scala: ## @@ -864,6 +778,111 @@ class ReplicaManager(val config: KafkaConfig, } } + /* + * Note: This me

Re: [PR] KAFKA-15653: Pass requestLocal as argument to callback so we use the correct one for the thread [kafka]

divijvaidya commented on code in PR #14629: URL: https://github.com/apache/kafka/pull/14629#discussion_r1373526592 ## core/src/main/scala/kafka/server/ReplicaManager.scala: ## @@ -864,6 +778,111 @@ class ReplicaManager(val config: KafkaConfig, } } + /* + * Note: Thi

Re: [PR] KAFKA-15653: Pass requestLocal as argument to callback so we use the correct one for the thread [kafka]

jolshan commented on code in PR #14629: URL: https://github.com/apache/kafka/pull/14629#discussion_r1373475149 ## core/src/main/scala/kafka/server/ReplicaManager.scala: ## @@ -864,6 +778,111 @@ class ReplicaManager(val config: KafkaConfig, } } + /* + * Note: This me

Re: [PR] KAFKA-15653: Pass requestLocal as argument to callback so we use the correct one for the thread [kafka]

divijvaidya commented on code in PR #14629: URL: https://github.com/apache/kafka/pull/14629#discussion_r1372844362 ## core/src/main/scala/kafka/server/ReplicaManager.scala: ## @@ -864,6 +778,111 @@ class ReplicaManager(val config: KafkaConfig, } } + /* + * Note: Thi

Re: [PR] KAFKA-15653: Pass requestLocal as argument to callback so we use the correct one for the thread [kafka]

divijvaidya commented on code in PR #14629: URL: https://github.com/apache/kafka/pull/14629#discussion_r1372844362 ## core/src/main/scala/kafka/server/ReplicaManager.scala: ## @@ -864,6 +778,111 @@ class ReplicaManager(val config: KafkaConfig, } } + /* + * Note: Thi

Re: [PR] KAFKA-15653: Pass requestLocal as argument to callback so we use the correct one for the thread [kafka]

junrao commented on code in PR #14629: URL: https://github.com/apache/kafka/pull/14629#discussion_r1372414818 ## core/src/main/scala/kafka/server/KafkaRequestHandler.scala: ## @@ -55,23 +55,23 @@ object KafkaRequestHandler { * @param fun Callback function to execute * @r

Re: [PR] KAFKA-15653: Pass requestLocal as argument to callback so we use the correct one for the thread [kafka]

junrao commented on code in PR #14629: URL: https://github.com/apache/kafka/pull/14629#discussion_r1372414239 ## core/src/main/scala/kafka/server/KafkaRequestHandler.scala: ## @@ -55,23 +55,23 @@ object KafkaRequestHandler { * @param fun Callback function to execute * @r

Re: [PR] KAFKA-15653: Pass requestLocal as argument to callback so we use the correct one for the thread [kafka]

artemlivshits commented on code in PR #14629: URL: https://github.com/apache/kafka/pull/14629#discussion_r1372379141 ## core/src/main/scala/kafka/server/KafkaRequestHandler.scala: ## @@ -55,23 +55,23 @@ object KafkaRequestHandler { * @param fun Callback function to execute

Re: [PR] KAFKA-15653: Pass requestLocal as argument to callback so we use the correct one for the thread [kafka]

jolshan commented on code in PR #14629: URL: https://github.com/apache/kafka/pull/14629#discussion_r1372377851 ## core/src/main/scala/kafka/server/KafkaRequestHandler.scala: ## @@ -55,23 +55,23 @@ object KafkaRequestHandler { * @param fun Callback function to execute * @

Re: [PR] KAFKA-15653: Pass requestLocal as argument to callback so we use the correct one for the thread [kafka]

junrao commented on code in PR #14629: URL: https://github.com/apache/kafka/pull/14629#discussion_r1372376795 ## core/src/main/scala/kafka/server/ReplicaManager.scala: ## @@ -864,6 +778,111 @@ class ReplicaManager(val config: KafkaConfig, } } + /* + * Note: This met

Re: [PR] KAFKA-15653: Pass requestLocal as argument to callback so we use the correct one for the thread [kafka]

junrao commented on code in PR #14629: URL: https://github.com/apache/kafka/pull/14629#discussion_r1372366141 ## core/src/main/scala/kafka/server/KafkaRequestHandler.scala: ## @@ -55,23 +55,23 @@ object KafkaRequestHandler { * @param fun Callback function to execute * @r

Re: [PR] KAFKA-15653: Pass requestLocal as argument to callback so we use the correct one for the thread [kafka]

jolshan commented on code in PR #14629: URL: https://github.com/apache/kafka/pull/14629#discussion_r1372329928 ## core/src/main/scala/kafka/server/KafkaRequestHandler.scala: ## @@ -55,23 +55,23 @@ object KafkaRequestHandler { * @param fun Callback function to execute * @

Re: [PR] KAFKA-15653: Pass requestLocal as argument to callback so we use the correct one for the thread [kafka]

junrao commented on code in PR #14629: URL: https://github.com/apache/kafka/pull/14629#discussion_r1372322049 ## core/src/main/scala/kafka/server/KafkaRequestHandler.scala: ## @@ -55,23 +55,23 @@ object KafkaRequestHandler { * @param fun Callback function to execute * @r

Re: [PR] KAFKA-15653: Pass requestLocal as argument to callback so we use the correct one for the thread [kafka]

junrao commented on code in PR #14629: URL: https://github.com/apache/kafka/pull/14629#discussion_r1372308747 ## core/src/main/scala/kafka/server/ReplicaManager.scala: ## @@ -846,7 +759,8 @@ class ReplicaManager(val config: KafkaConfig, producerId = batchInfo.producer

Re: [PR] KAFKA-15653: Pass requestLocal as argument to callback so we use the correct one for the thread [kafka]

artemlivshits commented on code in PR #14629: URL: https://github.com/apache/kafka/pull/14629#discussion_r1372270435 ## core/src/main/scala/kafka/server/ReplicaManager.scala: ## @@ -846,7 +759,8 @@ class ReplicaManager(val config: KafkaConfig, producerId = batchInfo.p

Re: [PR] KAFKA-15653: Pass requestLocal as argument to callback so we use the correct one for the thread [kafka]

jolshan commented on code in PR #14629: URL: https://github.com/apache/kafka/pull/14629#discussion_r1372169588 ## core/src/main/scala/kafka/server/KafkaRequestHandler.scala: ## @@ -55,23 +55,23 @@ object KafkaRequestHandler { * @param fun Callback function to execute * @

  1   2   >