chia7712 merged PR #15861:
URL: https://github.com/apache/kafka/pull/15861
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
chia7712 commented on PR #15861:
URL: https://github.com/apache/kafka/pull/15861#issuecomment-2114763118
```
./gradlew cleanTest :connect:runtime:test --tests
org.apache.kafka.connect.integration.ExactlyOnceSourceIntegrationTest.testSeparateOffsetsTopic
--tests
johnnychhsu commented on code in PR #15861:
URL: https://github.com/apache/kafka/pull/15861#discussion_r1601756235
##
core/src/test/java/kafka/test/ClusterTestExtensionsTest.java:
##
@@ -84,37 +85,47 @@ public void testClusterTest(ClusterInstance
clusterInstance) {
public
chia7712 commented on code in PR #15861:
URL: https://github.com/apache/kafka/pull/15861#discussion_r1601754643
##
core/src/test/java/kafka/test/ClusterTestExtensionsTest.java:
##
@@ -66,8 +67,8 @@ static void generate1(ClusterGenerator clusterGenerator) {
johnnychhsu commented on code in PR #15861:
URL: https://github.com/apache/kafka/pull/15861#discussion_r1601753901
##
core/src/test/java/kafka/test/ClusterTestExtensionsTest.java:
##
@@ -84,37 +85,47 @@ public void testClusterTest(ClusterInstance
clusterInstance) {
public
johnnychhsu commented on code in PR #15861:
URL: https://github.com/apache/kafka/pull/15861#discussion_r1601750727
##
core/src/test/java/kafka/test/ClusterTestExtensionsTest.java:
##
@@ -66,8 +67,8 @@ static void generate1(ClusterGenerator clusterGenerator) {
johnnychhsu commented on code in PR #15861:
URL: https://github.com/apache/kafka/pull/15861#discussion_r1601745613
##
core/src/test/java/kafka/test/ClusterConfig.java:
##
@@ -153,13 +153,13 @@ public Map>
perServerOverrideProperties() {
return perServerProperties;
chia7712 commented on code in PR #15861:
URL: https://github.com/apache/kafka/pull/15861#discussion_r1600109623
##
core/src/test/java/kafka/test/ClusterConfig.java:
##
@@ -153,13 +153,13 @@ public Map>
perServerOverrideProperties() {
return perServerProperties;
}
chia7712 commented on PR #15861:
URL: https://github.com/apache/kafka/pull/15861#issuecomment-2106748277
@johnnychhsu Please fix the conflicts.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
johnnychhsu commented on PR #15861:
URL: https://github.com/apache/kafka/pull/15861#issuecomment-2105935810
@chia7712 thanks for the quick review!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
chia7712 commented on code in PR #15861:
URL: https://github.com/apache/kafka/pull/15861#discussion_r1597465635
##
core/src/test/java/kafka/test/junit/RaftClusterInvocationContext.java:
##
@@ -79,7 +79,7 @@ public RaftClusterInvocationContext(String baseDisplayName,
chia7712 commented on code in PR #15861:
URL: https://github.com/apache/kafka/pull/15861#discussion_r1597465561
##
tools/src/test/java/org/apache/kafka/tools/consumer/group/ConsumerGroupCommandTestUtils.java:
##
@@ -55,19 +56,22 @@ static void generator(ClusterGenerator
chia7712 commented on code in PR #15861:
URL: https://github.com/apache/kafka/pull/15861#discussion_r1597465579
##
tools/src/test/java/org/apache/kafka/tools/consumer/group/ConsumerGroupCommandTestUtils.java:
##
@@ -55,19 +56,22 @@ static void generator(ClusterGenerator
chia7712 commented on code in PR #15861:
URL: https://github.com/apache/kafka/pull/15861#discussion_r1597465415
##
core/src/test/java/kafka/test/junit/ClusterTestExtensions.java:
##
@@ -151,19 +151,19 @@ private void processClusterTest(ExtensionContext context,
ClusterTest
chia7712 commented on code in PR #15861:
URL: https://github.com/apache/kafka/pull/15861#discussion_r1597465331
##
core/src/test/java/kafka/test/ClusterConfigTest.java:
##
@@ -44,14 +45,16 @@ private static Map fields(ClusterConfig
config) {
@Test
public void
chia7712 commented on code in PR #15861:
URL: https://github.com/apache/kafka/pull/15861#discussion_r1597465290
##
core/src/test/java/kafka/test/ClusterConfig.java:
##
@@ -153,13 +150,17 @@ public Map>
perBrokerOverrideProperties() {
return
johnnychhsu commented on PR #15861:
URL: https://github.com/apache/kafka/pull/15861#issuecomment-2105669617
test with `./gradlew clean tools:test --tests DeleteConsumerGroupsTest
--tests DeleteOffsetsConsumerGroupCommandIntegrationTest` and `./gradlew clean
core:test --tests
johnnychhsu commented on code in PR #15861:
URL: https://github.com/apache/kafka/pull/15861#discussion_r1597412007
##
core/src/test/java/kafka/test/ClusterConfig.java:
##
@@ -83,6 +83,7 @@ private ClusterConfig(Type type, int brokers, int
controllers, int disksPerBroke
chia7712 commented on code in PR #15861:
URL: https://github.com/apache/kafka/pull/15861#discussion_r1594882664
##
tools/src/test/java/org/apache/kafka/tools/consumer/group/ConsumerGroupCommandTestUtils.java:
##
@@ -74,16 +75,18 @@ static void generator(ClusterGenerator
johnnychhsu commented on PR #15861:
URL: https://github.com/apache/kafka/pull/15861#issuecomment-2100511022
run `./gradlew clean core:test --tests ClusterTestExtensionsTest --tests
ClusterConfigTest` and passed
--
This is an automated message from the Apache Git Service.
To respond to
johnnychhsu commented on code in PR #15861:
URL: https://github.com/apache/kafka/pull/15861#discussion_r1593920627
##
core/src/test/java/kafka/test/ClusterConfig.java:
##
@@ -153,15 +148,19 @@ public Map>
perBrokerOverrideProperties() {
return
johnnychhsu commented on code in PR #15861:
URL: https://github.com/apache/kafka/pull/15861#discussion_r1593917049
##
core/src/test/java/kafka/test/ClusterConfig.java:
##
@@ -53,14 +52,15 @@ public class ClusterConfig {
private final Map adminClientProperties;
private
chia7712 commented on code in PR #15861:
URL: https://github.com/apache/kafka/pull/15861#discussion_r1593356187
##
core/src/test/java/kafka/test/ClusterConfig.java:
##
@@ -53,14 +52,15 @@ public class ClusterConfig {
private final Map adminClientProperties;
private
chia7712 commented on code in PR #15861:
URL: https://github.com/apache/kafka/pull/15861#discussion_r1593355835
##
core/src/test/java/kafka/test/ClusterConfig.java:
##
@@ -153,15 +148,19 @@ public Map>
perBrokerOverrideProperties() {
return
johnnychhsu commented on PR #15861:
URL: https://github.com/apache/kafka/pull/15861#issuecomment-2098850247
@chia7712
> As https://github.com/apache/kafka/pull/15766 gets merged now, could you
please fix the build error?
sure, let me rebase the latest trunk and fix that since
johnnychhsu commented on code in PR #15861:
URL: https://github.com/apache/kafka/pull/15861#discussion_r1592759299
##
core/src/test/java/kafka/test/ClusterConfig.java:
##
@@ -153,15 +148,19 @@ public Map>
perBrokerOverrideProperties() {
return
26 matches
Mail list logo
