[jira] [Commented] (KAFKA-9009) Flaky Test kafka.integration.MetricsDuringTopicCreationDeletionTest.testMetricsDuringTopicCreateDelete

2021-05-06 Thread Luke Chen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9009?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17340044#comment-17340044 ] Luke Chen commented on KAFKA-9009: -- failed again. https://ci-builds.apache.org/job/Kafk

[GitHub] [kafka] tombentley commented on a change in pull request #10610: MINOR: replace deprecated Class.newInstance() to new one

2021-05-06 Thread GitBox
tombentley commented on a change in pull request #10610: URL: https://github.com/apache/kafka/pull/10610#discussion_r627177896 ## File path: connect/runtime/src/main/java/org/apache/kafka/connect/runtime/isolation/DelegatingClassLoader.java ## @@ -236,13 +237,13 @@ private voi

[GitHub] [kafka] showuon commented on pull request #10610: MINOR: replace deprecated Class.newInstance() to new one

2021-05-06 Thread GitBox
showuon commented on pull request #10610: URL: https://github.com/apache/kafka/pull/10610#issuecomment-833353747 @tombentley , thanks for the comments. Make sense! I've updated. Thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [kafka] tombentley merged pull request #10630: MINOR: Stop logging raw record contents above TRACE level in WorkerSourceTask

2021-05-06 Thread GitBox
tombentley merged pull request #10630: URL: https://github.com/apache/kafka/pull/10630 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, ple

[GitHub] [kafka] tombentley commented on pull request #10630: MINOR: Stop logging raw record contents above TRACE level in WorkerSourceTask

2021-05-06 Thread GitBox
tombentley commented on pull request #10630: URL: https://github.com/apache/kafka/pull/10630#issuecomment-833358254 Thanks @C0urante! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [kafka] cadonna commented on pull request #10568: KAFKA-8897: Upgrade RocksDB to 6.19.3

2021-05-06 Thread GitBox
cadonna commented on pull request #10568: URL: https://github.com/apache/kafka/pull/10568#issuecomment-833358757 I checked the last 10 PRs that where opened for the AK repo and 7 of them have `pure virtual method called` in the ARM build around the tests that showed the last leak I fixed.

[GitHub] [kafka] cadonna commented on a change in pull request #10568: KAFKA-8897: Upgrade RocksDB to 6.19.3

2021-05-06 Thread GitBox
cadonna commented on a change in pull request #10568: URL: https://github.com/apache/kafka/pull/10568#discussion_r627221015 ## File path: streams/src/main/java/org/apache/kafka/streams/state/internals/RocksDBGenericOptionsToDbOptionsColumnFamilyOptionsAdapter.java ## @@ -1381,

[GitHub] [kafka] cadonna commented on a change in pull request #10568: KAFKA-8897: Upgrade RocksDB to 6.19.3

2021-05-06 Thread GitBox
cadonna commented on a change in pull request #10568: URL: https://github.com/apache/kafka/pull/10568#discussion_r627228005 ## File path: streams/src/main/java/org/apache/kafka/streams/state/internals/RocksDBGenericOptionsToDbOptionsColumnFamilyOptionsAdapter.java ## @@ -1381,

[jira] [Commented] (KAFKA-9009) Flaky Test kafka.integration.MetricsDuringTopicCreationDeletionTest.testMetricsDuringTopicCreateDelete

2021-05-06 Thread Bruno Cadonna (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9009?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17340118#comment-17340118 ] Bruno Cadonna commented on KAFKA-9009: -- Failed again: [https://ci-builds.apache.org

[jira] [Commented] (KAFKA-10323) NullPointerException during rebalance

2021-05-06 Thread Duong Pham (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10323?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17340127#comment-17340127 ] Duong Pham commented on KAFKA-10323: [~kkonstantine] [~kkarantasis]  do you think th

[GitHub] [kafka] cadonna commented on pull request #10631: MINOR: Stop using hamcrest in system tests

2021-05-06 Thread GitBox
cadonna commented on pull request #10631: URL: https://github.com/apache/kafka/pull/10631#issuecomment-833402450 The failing tests in the builds are test unrelated and known as flaky. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [kafka] cadonna merged pull request #10631: MINOR: Stop using hamcrest in system tests

2021-05-06 Thread GitBox
cadonna merged pull request #10631: URL: https://github.com/apache/kafka/pull/10631 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please

[jira] [Resolved] (KAFKA-10767) Add Unit Test cases for missing methods in ThreadCacheTest

2021-05-06 Thread Bruno Cadonna (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10767?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bruno Cadonna resolved KAFKA-10767. --- Resolution: Fixed > Add Unit Test cases for missing methods in ThreadCacheTest > ---

[jira] [Updated] (KAFKA-10767) Add Unit Test cases for missing methods in ThreadCacheTest

2021-05-06 Thread Bruno Cadonna (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10767?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bruno Cadonna updated KAFKA-10767: -- Fix Version/s: 3.0.0 > Add Unit Test cases for missing methods in ThreadCacheTest > --

[GitHub] [kafka] cadonna commented on pull request #10568: KAFKA-8897: Upgrade RocksDB to 6.19.3

2021-05-06 Thread GitBox
cadonna commented on pull request #10568: URL: https://github.com/apache/kafka/pull/10568#issuecomment-833425461 The ARM build passed. Now, I rebased the PR and I will run Streams system tests on it. -- This is an automated message from the Apache Git Service. To respond to the messag

[jira] [Commented] (KAFKA-10273) Connect Converters should produce actionable error messages

2021-05-06 Thread Duong Pham (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10273?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17340139#comment-17340139 ] Duong Pham commented on KAFKA-10273: Hi [~rhauch], Has this issue been resolved? Ca

[GitHub] [kafka] cadonna commented on pull request #10568: KAFKA-8897: Upgrade RocksDB to 6.19.3

2021-05-06 Thread GitBox
cadonna commented on pull request #10568: URL: https://github.com/apache/kafka/pull/10568#issuecomment-833427130 The system tests job: https://jenkins.confluent.io/job/system-test-kafka-branch-builder/4494/ -- This is an automated message from the Apache Git Service. To respond to the me

[GitHub] [kafka] satishd commented on pull request #10638: MINOR Added `server-common` module to have server side common classes.

2021-05-06 Thread GitBox
satishd commented on pull request #10638: URL: https://github.com/apache/kafka/pull/10638#issuecomment-833446234 @junrao As discussed earlier, serde related classes are moved to the new `server-common` module. We can add more server specific classes from other modules like `clients` in

[jira] [Updated] (KAFKA-12757) Move server related common classes into a separate `server-common` module.

2021-05-06 Thread Satish Duggana (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12757?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Satish Duggana updated KAFKA-12757: --- Issue Type: Task (was: Improvement) > Move server related common classes into a separate `s

[jira] [Created] (KAFKA-12757) Move server related common classes into a separate `server-common` module.

2021-05-06 Thread Satish Duggana (Jira)
Satish Duggana created KAFKA-12757: -- Summary: Move server related common classes into a separate `server-common` module. Key: KAFKA-12757 URL: https://issues.apache.org/jira/browse/KAFKA-12757 Projec

[jira] [Updated] (KAFKA-12757) Move server related common classes into a separate `server-common` module.

2021-05-06 Thread Satish Duggana (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12757?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Satish Duggana updated KAFKA-12757: --- Issue Type: New Feature (was: Task) > Move server related common classes into a separate `s

[jira] [Updated] (KAFKA-12757) Move server related common classes into a separate `server-common` module.

2021-05-06 Thread Satish Duggana (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12757?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Satish Duggana updated KAFKA-12757: --- Issue Type: Improvement (was: New Feature) > Move server related common classes into a sepa

[jira] [Updated] (KAFKA-12758) Create a new `server-common` module and move ApiMessageAndVersion, RecordSerde, AbstractApiMessageSerde, and BytesApiMessageSerde to that module.

2021-05-06 Thread Satish Duggana (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12758?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Satish Duggana updated KAFKA-12758: --- Description: Create a new `server-common` module and move ApiMessageAndVersion, RecordSerde,

[jira] [Created] (KAFKA-12758) Create a new `server-common` module and move ApiMessageAndVersion, RecordSerde, AbstractApiMessageSerde, and BytesApiMessageSerde to that module.

2021-05-06 Thread Satish Duggana (Jira)
Satish Duggana created KAFKA-12758: -- Summary: Create a new `server-common` module and move ApiMessageAndVersion, RecordSerde, AbstractApiMessageSerde, and BytesApiMessageSerde to that module. Key: KAFKA-12758 UR

[jira] [Commented] (KAFKA-12758) Create a new `server-common` module and move ApiMessageAndVersion, RecordSerde, AbstractApiMessageSerde, and BytesApiMessageSerde to that module.

2021-05-06 Thread Satish Duggana (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12758?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17340155#comment-17340155 ] Satish Duggana commented on KAFKA-12758: https://github.com/apache/kafka/pull/10

[GitHub] [kafka] cadonna edited a comment on pull request #10568: KAFKA-8897: Upgrade RocksDB to 6.19.3

2021-05-06 Thread GitBox
cadonna edited a comment on pull request #10568: URL: https://github.com/apache/kafka/pull/10568#issuecomment-833427130 The system tests job: https://jenkins.confluent.io/job/system-test-kafka-branch-builder/4495/ -- This is an automated message from the Apache Git Service. To respond to

[GitHub] [kafka] jeqo commented on pull request #10296: KAFKA-12451: Remove deprecation annotation on long-based read operations in WindowStore

2021-05-06 Thread GitBox
jeqo commented on pull request #10296: URL: https://github.com/apache/kafka/pull/10296#issuecomment-833471133 cc @guozhangwang this PR is ready to review as well, to complete the PRs related to KIP-667. Cheers! -- This is an automated message from the Apache Git Service. To respond to th

[GitHub] [kafka] cadonna opened a new pull request #10639: MINOR: Fix formatting in RelationalSmokeTest

2021-05-06 Thread GitBox
cadonna opened a new pull request #10639: URL: https://github.com/apache/kafka/pull/10639 ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation - [ ] Verify test coverage and CI build status - [ ] Verify documentation (including upgrade n

[GitHub] [kafka] cadonna commented on pull request #10639: MINOR: Fix formatting in RelationalSmokeTest

2021-05-06 Thread GitBox
cadonna commented on pull request #10639: URL: https://github.com/apache/kafka/pull/10639#issuecomment-833497400 @lct45 Could you please take a quick look and approve? It is just some formatting fixes. -- This is an automated message from the Apache Git Service. To respond to the messag

[GitHub] [kafka] spena opened a new pull request #10640: KAFKA-10847: Set StreamsConfig on InternalTopologyDriver before writing topology

2021-05-06 Thread GitBox
spena opened a new pull request #10640: URL: https://github.com/apache/kafka/pull/10640 While running some tests, I noticed the KSTREAMS-OUTERSHARED store, used in left/outer joins, was still added in the list of state stores when the `StreamsConfig.InternalConfig.ENABLE_KSTREAMS_OUTER_JOI

[GitHub] [kafka] cadonna edited a comment on pull request #10568: KAFKA-8897: Upgrade RocksDB to 6.19.3

2021-05-06 Thread GitBox
cadonna edited a comment on pull request #10568: URL: https://github.com/apache/kafka/pull/10568#issuecomment-833427130 The system tests job: https://jenkins.confluent.io/job/system-test-kafka-branch-builder/4497/ -- This is an automated message from the Apache Git Service. To respond to

[GitHub] [kafka] cadonna edited a comment on pull request #10568: KAFKA-8897: Upgrade RocksDB to 6.19.3

2021-05-06 Thread GitBox
cadonna edited a comment on pull request #10568: URL: https://github.com/apache/kafka/pull/10568#issuecomment-833427130 The system tests job: https://jenkins.confluent.io/job/system-test-kafka-branch-builder/4500/ -- This is an automated message from the Apache Git Service. To respond to

[jira] [Commented] (KAFKA-10323) NullPointerException during rebalance

2021-05-06 Thread Luke Chen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10323?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17340211#comment-17340211 ] Luke Chen commented on KAFKA-10323: --- Does this issue keep happening? After 2nd thought

[GitHub] [kafka] ijuma commented on pull request #10638: KAFKA-12758 Added `server-common` module to have server side common classes.

2021-05-06 Thread GitBox
ijuma commented on pull request #10638: URL: https://github.com/apache/kafka/pull/10638#issuecomment-833529211 cc @cmccabe -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [kafka] dongjinleekr opened a new pull request #10641: KAFKA-12752: CVE-2021-28168 upgrade jersey to 2.34 or 3.02

2021-05-06 Thread GitBox
dongjinleekr opened a new pull request #10641: URL: https://github.com/apache/kafka/pull/10641 [CVE-2021-28168](https://nvd.nist.gov/vuln/detail/CVE-2021-28168) in Jersey was fixed in [2.34](https://github.com/eclipse-ee4j/jersey/security/advisories/GHSA-c43q-5hpj-4crv). ### Committ

[jira] [Assigned] (KAFKA-12752) CVE-2021-28168 upgrade jersey to 2.34 or 3.02

2021-05-06 Thread Dongjin Lee (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12752?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dongjin Lee reassigned KAFKA-12752: --- Assignee: Dongjin Lee > CVE-2021-28168 upgrade jersey to 2.34 or 3.02 > ---

[jira] [Commented] (KAFKA-10323) NullPointerException during rebalance

2021-05-06 Thread Luke Chen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10323?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17340229#comment-17340229 ] Luke Chen commented on KAFKA-10323: --- So, if ti's Kafka V2.5.0, from the stack trace, i

[jira] [Commented] (KAFKA-12752) CVE-2021-28168 upgrade jersey to 2.34 or 3.02

2021-05-06 Thread Dongjin Lee (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12752?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17340231#comment-17340231 ] Dongjin Lee commented on KAFKA-12752: - https://github.com/apache/kafka/pull/10641 >

[GitHub] [kafka] dongjinleekr opened a new pull request #10642: KAFKA-12756: Update Zookeeper to 3.6.3 or higher

2021-05-06 Thread GitBox
dongjinleekr opened a new pull request #10642: URL: https://github.com/apache/kafka/pull/10642 [CVE-2021-21409](https://nvd.nist.gov/vuln/detail/CVE-2021-21409) in Zookeeper was fixed in [3.6.3](https://zookeeper.apache.org/doc/r3.6.3/releasenotes.html). ### Committer Checklist (exc

[jira] [Assigned] (KAFKA-12756) Update Zookeeper to 3.6.3 or higher

2021-05-06 Thread Dongjin Lee (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12756?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dongjin Lee reassigned KAFKA-12756: --- Assignee: Dongjin Lee > Update Zookeeper to 3.6.3 or higher > -

[jira] [Commented] (KAFKA-12756) Update Zookeeper to 3.6.3 or higher

2021-05-06 Thread Dongjin Lee (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12756?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17340233#comment-17340233 ] Dongjin Lee commented on KAFKA-12756: - https://github.com/apache/kafka/pull/10642 >

[GitHub] [kafka] ijuma commented on pull request #10642: KAFKA-12756: Update Zookeeper to 3.6.3 or higher

2021-05-06 Thread GitBox
ijuma commented on pull request #10642: URL: https://github.com/apache/kafka/pull/10642#issuecomment-833556259 This is a major version bump and it requires some analysis on the impact. There is no 3.5.x release with this fix? -- This is an automated message from the Apache Git Service. T

[GitHub] [kafka] ijuma commented on pull request #10642: KAFKA-12756: Update Zookeeper to 3.6.3 or higher

2021-05-06 Thread GitBox
ijuma commented on pull request #10642: URL: https://github.com/apache/kafka/pull/10642#issuecomment-833556749 Also, we override the netty version, so I am not sure the ZK version needs to be bumped at all. -- This is an automated message from the Apache Git Service. To respond to the me

[GitHub] [kafka] dongjinleekr commented on pull request #10642: KAFKA-12756: Update Zookeeper to 3.6.3 or higher

2021-05-06 Thread GitBox
dongjinleekr commented on pull request #10642: URL: https://github.com/apache/kafka/pull/10642#issuecomment-833561404 > This is a major version bump and it requires some analysis on the impact. Agree. > There is no 3.5.x release with this fix? Yes, this issue was fixed i

[jira] [Commented] (KAFKA-12734) LazyTimeIndex & LazyOffsetIndex may cause niobufferoverflow when skip activeSegment sanityCheck

2021-05-06 Thread Wenbing Shen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12734?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17340247#comment-17340247 ] Wenbing Shen commented on KAFKA-12734: -- [~ecastilla] LazyIndex was introduced from

[GitHub] [kafka] omkreddy merged pull request #10636: MINOR: Bump Jersey deps to 2.34 due to CVE-2021-28168

2021-05-06 Thread GitBox
omkreddy merged pull request #10636: URL: https://github.com/apache/kafka/pull/10636 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, pleas

[jira] [Updated] (KAFKA-12734) LazyTimeIndex & LazyOffsetIndex may cause niobufferoverflow when skip activeSegment sanityCheck

2021-05-06 Thread Wenbing Shen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12734?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Wenbing Shen updated KAFKA-12734: - Affects Version/s: (was: 2.8.0) 2.3.0 > LazyTimeIndex & LazyOffsetInd

[GitHub] [kafka] omkreddy commented on pull request #10641: KAFKA-12752: CVE-2021-28168 upgrade jersey to 2.34 or 3.02

2021-05-06 Thread GitBox
omkreddy commented on pull request #10641: URL: https://github.com/apache/kafka/pull/10641#issuecomment-833585875 hanks for the PR. This is fixed via https://github.com/apache/kafka/pull/10636 -- This is an automated message from the Apache Git Service. To respond to the message, please

[jira] [Resolved] (KAFKA-12752) CVE-2021-28168 upgrade jersey to 2.34 or 3.02

2021-05-06 Thread Manikumar (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12752?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Manikumar resolved KAFKA-12752. --- Fix Version/s: 2.8.1 2.7.2 3.0.0 Reviewer: Manikumar

[GitHub] [kafka] jolshan commented on a change in pull request #9944: KAFKA-10580: Add topic ID support to Fetch request

2021-05-06 Thread GitBox
jolshan commented on a change in pull request #9944: URL: https://github.com/apache/kafka/pull/9944#discussion_r627514050 ## File path: core/src/main/scala/kafka/server/FetchSession.scala ## @@ -425,16 +438,27 @@ class IncrementalFetchContext(private val time: Time, va

[GitHub] [kafka] jolshan commented on a change in pull request #9944: KAFKA-10580: Add topic ID support to Fetch request

2021-05-06 Thread GitBox
jolshan commented on a change in pull request #9944: URL: https://github.com/apache/kafka/pull/9944#discussion_r627516643 ## File path: clients/src/main/java/org/apache/kafka/common/requests/FetchResponse.java ## @@ -80,14 +89,26 @@ public Errors error() { return Erro

[GitHub] [kafka] jolshan commented on a change in pull request #9944: KAFKA-10580: Add topic ID support to Fetch request

2021-05-06 Thread GitBox
jolshan commented on a change in pull request #9944: URL: https://github.com/apache/kafka/pull/9944#discussion_r627518693 ## File path: clients/src/main/java/org/apache/kafka/common/requests/FetchRequest.java ## @@ -319,12 +355,25 @@ public int maxBytes() { return dat

[jira] [Commented] (KAFKA-12657) Flaky Tests BlockingConnectorTest.testWorkerRestartWithBlockInConnectorStop

2021-05-06 Thread Bruno Cadonna (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12657?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17340257#comment-17340257 ] Bruno Cadonna commented on KAFKA-12657: --- https://ci-builds.apache.org/job/Kafka/jo

[GitHub] [kafka] jolshan commented on a change in pull request #9944: KAFKA-10580: Add topic ID support to Fetch request

2021-05-06 Thread GitBox
jolshan commented on a change in pull request #9944: URL: https://github.com/apache/kafka/pull/9944#discussion_r627519381 ## File path: clients/src/main/java/org/apache/kafka/common/requests/FetchRequest.java ## @@ -281,10 +296,16 @@ public String toString() { public Fe

[GitHub] [kafka] cadonna commented on pull request #10639: MINOR: Fix formatting in RelationalSmokeTest

2021-05-06 Thread GitBox
cadonna commented on pull request #10639: URL: https://github.com/apache/kafka/pull/10639#issuecomment-833609806 @lct45 Thank you for fixing this issue in the first place. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and u

[jira] [Commented] (KAFKA-9009) Flaky Test kafka.integration.MetricsDuringTopicCreationDeletionTest.testMetricsDuringTopicCreateDelete

2021-05-06 Thread Bruno Cadonna (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9009?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17340259#comment-17340259 ] Bruno Cadonna commented on KAFKA-9009: -- https://ci-builds.apache.org/job/Kafka/job/k

[GitHub] [kafka] cadonna commented on pull request #10639: MINOR: Fix formatting in RelationalSmokeTest

2021-05-06 Thread GitBox
cadonna commented on pull request #10639: URL: https://github.com/apache/kafka/pull/10639#issuecomment-833610135 Failures are unrelated and known as flaky. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [kafka] cadonna merged pull request #10639: MINOR: Fix formatting in RelationalSmokeTest

2021-05-06 Thread GitBox
cadonna merged pull request #10639: URL: https://github.com/apache/kafka/pull/10639 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please

[GitHub] [kafka] jolshan commented on a change in pull request #9944: KAFKA-10580: Add topic ID support to Fetch request

2021-05-06 Thread GitBox
jolshan commented on a change in pull request #9944: URL: https://github.com/apache/kafka/pull/9944#discussion_r627522339 ## File path: clients/src/main/java/org/apache/kafka/clients/FetchSessionHandler.java ## @@ -212,10 +273,19 @@ public FetchRequestData build() {

[GitHub] [kafka] mjsax commented on a change in pull request #10640: KAFKA-10847: Set StreamsConfig on InternalTopologyDriver before writing topology

2021-05-06 Thread GitBox
mjsax commented on a change in pull request #10640: URL: https://github.com/apache/kafka/pull/10640#discussion_r627522997 ## File path: streams/src/main/java/org/apache/kafka/streams/kstream/internals/InternalStreamsBuilder.java ## @@ -290,6 +290,10 @@ public void buildAndOpti

[GitHub] [kafka] jolshan commented on a change in pull request #9944: KAFKA-10580: Add topic ID support to Fetch request

2021-05-06 Thread GitBox
jolshan commented on a change in pull request #9944: URL: https://github.com/apache/kafka/pull/9944#discussion_r627523117 ## File path: clients/src/main/java/org/apache/kafka/clients/FetchSessionHandler.java ## @@ -73,6 +77,22 @@ public FetchSessionHandler(LogContext logContex

[GitHub] [kafka] jolshan commented on a change in pull request #9944: KAFKA-10580: Add topic ID support to Fetch request

2021-05-06 Thread GitBox
jolshan commented on a change in pull request #9944: URL: https://github.com/apache/kafka/pull/9944#discussion_r627523900 ## File path: clients/src/main/java/org/apache/kafka/clients/FetchSessionHandler.java ## @@ -125,10 +167,22 @@ public FetchSessionHandler(LogContext logCon

[GitHub] [kafka] guozhangwang commented on pull request #10568: KAFKA-8897: Upgrade RocksDB to 6.19.3

2021-05-06 Thread GitBox
guozhangwang commented on pull request #10568: URL: https://github.com/apache/kafka/pull/10568#issuecomment-833674556 @cadonna I've retriggered https://jenkins.confluent.io/job/system-test-kafka-branch-builder/4501 -- This is an automated message from the Apache Git Service. To respond t

[GitHub] [kafka] spena commented on a change in pull request #10640: KAFKA-10847: Set StreamsConfig on InternalTopologyDriver before writing topology

2021-05-06 Thread GitBox
spena commented on a change in pull request #10640: URL: https://github.com/apache/kafka/pull/10640#discussion_r627598006 ## File path: streams/src/main/java/org/apache/kafka/streams/kstream/internals/InternalStreamsBuilder.java ## @@ -290,6 +290,10 @@ public void buildAndOpti

[GitHub] [kafka] spena commented on a change in pull request #10640: KAFKA-10847: Set StreamsConfig on InternalTopologyDriver before writing topology

2021-05-06 Thread GitBox
spena commented on a change in pull request #10640: URL: https://github.com/apache/kafka/pull/10640#discussion_r627599049 ## File path: streams/src/main/java/org/apache/kafka/streams/kstream/internals/graph/GraphNode.java ## @@ -119,6 +120,11 @@ public Integer buildPriority()

[GitHub] [kafka] mumrah commented on pull request #10561: KAFKA-12686 AlterIsr and LeaderAndIsr race condition

2021-05-06 Thread GitBox
mumrah commented on pull request #10561: URL: https://github.com/apache/kafka/pull/10561#issuecomment-833686321 @chia7712 I added a few integration tests to exercise that particular case. This PR also includes a new test that exercises the partition code path that was affected by the race

[GitHub] [kafka] mumrah commented on a change in pull request #10561: KAFKA-12686 AlterIsr and LeaderAndIsr race condition

2021-05-06 Thread GitBox
mumrah commented on a change in pull request #10561: URL: https://github.com/apache/kafka/pull/10561#discussion_r627607791 ## File path: core/src/main/scala/kafka/cluster/Partition.scala ## @@ -1341,13 +1335,15 @@ class Partition(val topicPartition: TopicPartition, isrStat

[GitHub] [kafka] mjsax commented on a change in pull request #10640: KAFKA-10847: Set StreamsConfig on InternalTopologyDriver before writing topology

2021-05-06 Thread GitBox
mjsax commented on a change in pull request #10640: URL: https://github.com/apache/kafka/pull/10640#discussion_r627611652 ## File path: streams/src/main/java/org/apache/kafka/streams/kstream/internals/graph/GraphNode.java ## @@ -119,6 +120,11 @@ public Integer buildPriority()

[GitHub] [kafka] mjsax commented on a change in pull request #10640: KAFKA-10847: Set StreamsConfig on InternalTopologyDriver before writing topology

2021-05-06 Thread GitBox
mjsax commented on a change in pull request #10640: URL: https://github.com/apache/kafka/pull/10640#discussion_r627613086 ## File path: streams/src/main/java/org/apache/kafka/streams/kstream/internals/graph/StreamStreamJoinNode.java ## @@ -98,12 +108,19 @@ public void writeToT

[GitHub] [kafka] junrao commented on a change in pull request #10638: KAFKA-12758 Added `server-common` module to have server side common classes.

2021-05-06 Thread GitBox
junrao commented on a change in pull request #10638: URL: https://github.com/apache/kafka/pull/10638#discussion_r627548721 ## File path: build.gradle ## @@ -1585,6 +1644,7 @@ project(':shell') { implementation libs.jacksonJDK8Datatypes implementation libs.jline i

[GitHub] [kafka] spena commented on a change in pull request #10640: KAFKA-10847: Set StreamsConfig on InternalTopologyDriver before writing topology

2021-05-06 Thread GitBox
spena commented on a change in pull request #10640: URL: https://github.com/apache/kafka/pull/10640#discussion_r627658008 ## File path: streams/src/main/java/org/apache/kafka/streams/kstream/internals/graph/StreamStreamJoinNode.java ## @@ -98,12 +108,19 @@ public void writeToT

[GitHub] [kafka] jsancio commented on a change in pull request #10431: KAFKA-12543: Change RawSnapshotReader ownership model

2021-05-06 Thread GitBox
jsancio commented on a change in pull request #10431: URL: https://github.com/apache/kafka/pull/10431#discussion_r627658137 ## File path: core/src/main/scala/kafka/raft/KafkaMetadataLog.scala ## @@ -242,85 +246,125 @@ final class KafkaMetadataLog private ( } override de

[GitHub] [kafka] jsancio commented on a change in pull request #10431: KAFKA-12543: Change RawSnapshotReader ownership model

2021-05-06 Thread GitBox
jsancio commented on a change in pull request #10431: URL: https://github.com/apache/kafka/pull/10431#discussion_r627660146 ## File path: core/src/main/scala/kafka/raft/KafkaMetadataLog.scala ## @@ -242,85 +246,125 @@ final class KafkaMetadataLog private ( } override de

[GitHub] [kafka] guozhangwang merged pull request #10296: KAFKA-12451: Remove deprecation annotation on long-based read operations in WindowStore

2021-05-06 Thread GitBox
guozhangwang merged pull request #10296: URL: https://github.com/apache/kafka/pull/10296 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, p

[GitHub] [kafka] jsancio commented on a change in pull request #10431: KAFKA-12543: Change RawSnapshotReader ownership model

2021-05-06 Thread GitBox
jsancio commented on a change in pull request #10431: URL: https://github.com/apache/kafka/pull/10431#discussion_r627672049 ## File path: core/src/main/scala/kafka/raft/KafkaMetadataLog.scala ## @@ -242,85 +246,125 @@ final class KafkaMetadataLog private ( } override de

[GitHub] [kafka] mjsax commented on a change in pull request #10640: KAFKA-10847: Set StreamsConfig on InternalTopologyDriver before writing topology

2021-05-06 Thread GitBox
mjsax commented on a change in pull request #10640: URL: https://github.com/apache/kafka/pull/10640#discussion_r627687839 ## File path: streams/src/main/java/org/apache/kafka/streams/kstream/internals/graph/StreamStreamJoinNode.java ## @@ -98,12 +108,19 @@ public void writeToT

[GitHub] [kafka] mjsax commented on a change in pull request #10640: KAFKA-10847: Set StreamsConfig on InternalTopologyDriver before writing topology

2021-05-06 Thread GitBox
mjsax commented on a change in pull request #10640: URL: https://github.com/apache/kafka/pull/10640#discussion_r627687839 ## File path: streams/src/main/java/org/apache/kafka/streams/kstream/internals/graph/StreamStreamJoinNode.java ## @@ -98,12 +108,19 @@ public void writeToT

[GitHub] [kafka] cadonna commented on pull request #10568: KAFKA-8897: Upgrade RocksDB to 6.19.3

2021-05-06 Thread GitBox
cadonna commented on pull request #10568: URL: https://github.com/apache/kafka/pull/10568#issuecomment-833790689 The test failures in the build are unrelated and known to be flaky. The system test failures are unrelated since only Streams-broker compatibility tests failed. @guozhangwa

[jira] [Assigned] (KAFKA-12647) Implement loading snapshot in the broker

2021-05-06 Thread Jose Armando Garcia Sancio (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12647?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jose Armando Garcia Sancio reassigned KAFKA-12647: -- Assignee: Jose Armando Garcia Sancio > Implement loading snap

[GitHub] [kafka] jolshan commented on a change in pull request #9944: KAFKA-10580: Add topic ID support to Fetch request

2021-05-06 Thread GitBox
jolshan commented on a change in pull request #9944: URL: https://github.com/apache/kafka/pull/9944#discussion_r627723205 ## File path: core/src/main/scala/kafka/server/FetchSession.scala ## @@ -237,14 +239,16 @@ class FetchSession(val id: Int, type TL = util.ArrayList[Topic

[GitHub] [kafka] jolshan commented on a change in pull request #9944: KAFKA-10580: Add topic ID support to Fetch request

2021-05-06 Thread GitBox
jolshan commented on a change in pull request #9944: URL: https://github.com/apache/kafka/pull/9944#discussion_r627724561 ## File path: core/src/main/scala/kafka/server/FetchSession.scala ## @@ -314,22 +321,24 @@ class SessionErrorContext(val error: Errors, override def fore

[jira] [Resolved] (KAFKA-12252) Distributed herder tick thread loops rapidly when worker loses leadership

2021-05-06 Thread Randall Hauch (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12252?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Randall Hauch resolved KAFKA-12252. --- Fix Version/s: 2.8.1 3.0.0 Resolution: Fixed I'm still working on

[jira] [Comment Edited] (KAFKA-12671) Out of order processing with a transactional producer can lead to a stuck LastStableOffset

2021-05-06 Thread Travis Bischel (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12671?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17339995#comment-17339995 ] Travis Bischel edited comment on KAFKA-12671 at 5/6/21, 9:01 PM: -

[GitHub] [kafka] jolshan commented on a change in pull request #9944: KAFKA-10580: Add topic ID support to Fetch request

2021-05-06 Thread GitBox
jolshan commented on a change in pull request #9944: URL: https://github.com/apache/kafka/pull/9944#discussion_r627767360 ## File path: core/src/main/scala/kafka/server/FetchSession.scala ## @@ -425,16 +438,27 @@ class IncrementalFetchContext(private val time: Time, va

[GitHub] [kafka] spena commented on a change in pull request #10640: KAFKA-10847: Set StreamsConfig on InternalTopologyDriver before writing topology

2021-05-06 Thread GitBox
spena commented on a change in pull request #10640: URL: https://github.com/apache/kafka/pull/10640#discussion_r627775616 ## File path: streams/src/main/java/org/apache/kafka/streams/kstream/internals/graph/StreamStreamJoinNode.java ## @@ -98,12 +108,19 @@ public void writeToT

[GitHub] [kafka] jolshan commented on a change in pull request #9944: KAFKA-10580: Add topic ID support to Fetch request

2021-05-06 Thread GitBox
jolshan commented on a change in pull request #9944: URL: https://github.com/apache/kafka/pull/9944#discussion_r627776011 ## File path: core/src/main/scala/kafka/server/ReplicaAlterLogDirsThread.scala ## @@ -276,7 +284,12 @@ class ReplicaAlterLogDirsThread(name: String, }

[GitHub] [kafka] guozhangwang opened a new pull request #10643: KAFKA-12747: Fix flakiness in shouldReturnUUIDsWithStringPrefix

2021-05-06 Thread GitBox
guozhangwang opened a new pull request #10643: URL: https://github.com/apache/kafka/pull/10643 Consecutive UUID generation could result in same prefix. ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation - [ ] Verify test coverage and C

[GitHub] [kafka] guozhangwang commented on pull request #10643: KAFKA-12747: Fix flakiness in shouldReturnUUIDsWithStringPrefix

2021-05-06 Thread GitBox
guozhangwang commented on pull request #10643: URL: https://github.com/apache/kafka/pull/10643#issuecomment-833914614 cc @ableegoldman for reviews. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t

[GitHub] [kafka] guozhangwang merged pull request #10568: KAFKA-8897: Upgrade RocksDB to 6.19.3

2021-05-06 Thread GitBox
guozhangwang merged pull request #10568: URL: https://github.com/apache/kafka/pull/10568 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, p

[GitHub] [kafka] guozhangwang commented on pull request #10568: KAFKA-8897: Upgrade RocksDB to 6.19.3

2021-05-06 Thread GitBox
guozhangwang commented on pull request #10568: URL: https://github.com/apache/kafka/pull/10568#issuecomment-833915222 Merged to trunk. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specifi

[GitHub] [kafka] scott-hendricks commented on pull request #10621: MINOR: Fix a couple Trogdor issues.

2021-05-06 Thread GitBox
scott-hendricks commented on pull request #10621: URL: https://github.com/apache/kafka/pull/10621#issuecomment-833929678 > LGTM once the patch is fixed to not have this build error: Thanks I actually had this changed already on my local system but forgot to push the patch up. -- T

[jira] [Created] (KAFKA-12759) Kafka consumers with static group membership won't consume from newly subscribed topics

2021-05-06 Thread Andrey Polyakov (Jira)
Andrey Polyakov created KAFKA-12759: --- Summary: Kafka consumers with static group membership won't consume from newly subscribed topics Key: KAFKA-12759 URL: https://issues.apache.org/jira/browse/KAFKA-12759

[GitHub] [kafka] jolshan commented on a change in pull request #9944: KAFKA-10580: Add topic ID support to Fetch request

2021-05-06 Thread GitBox
jolshan commented on a change in pull request #9944: URL: https://github.com/apache/kafka/pull/9944#discussion_r627840199 ## File path: clients/src/main/java/org/apache/kafka/clients/FetchSessionHandler.java ## @@ -73,6 +77,22 @@ public FetchSessionHandler(LogContext logContex

[GitHub] [kafka] mjsax commented on a change in pull request #10460: KAFKA-10357: Use validate and setup during internal topics creation

2021-05-06 Thread GitBox
mjsax commented on a change in pull request #10460: URL: https://github.com/apache/kafka/pull/10460#discussion_r627843926 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/InternalTopicManager.java ## @@ -649,19 +434,38 @@ private void processCre

[GitHub] [kafka] mjsax commented on a change in pull request #10460: KAFKA-10357: Use validate and setup during internal topics creation

2021-05-06 Thread GitBox
mjsax commented on a change in pull request #10460: URL: https://github.com/apache/kafka/pull/10460#discussion_r627845207 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/InternalTopicManager.java ## @@ -649,19 +434,38 @@ private void processCre

[GitHub] [kafka] mjsax commented on a change in pull request #10460: KAFKA-10357: Use validate and setup during internal topics creation

2021-05-06 Thread GitBox
mjsax commented on a change in pull request #10460: URL: https://github.com/apache/kafka/pull/10460#discussion_r627845711 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/InternalTopicManager.java ## @@ -649,19 +434,38 @@ private void processCre

[GitHub] [kafka] mjsax merged pull request #10640: KAFKA-10847: Set StreamsConfig on InternalTopologyDriver before writing topology

2021-05-06 Thread GitBox
mjsax merged pull request #10640: URL: https://github.com/apache/kafka/pull/10640 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please c

[GitHub] [kafka] cmccabe merged pull request #10621: MINOR: Fix a couple Trogdor issues.

2021-05-06 Thread GitBox
cmccabe merged pull request #10621: URL: https://github.com/apache/kafka/pull/10621 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please

[GitHub] [kafka] kowshik commented on pull request #10637: MINOR: remove storage/src/generated from tracked files

2021-05-06 Thread GitBox
kowshik commented on pull request #10637: URL: https://github.com/apache/kafka/pull/10637#issuecomment-833982538 @chia7712 Thanks for the PR. LGTM. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t

[jira] [Commented] (KAFKA-5381) ERROR Uncaught exception in scheduled task 'delete-expired-consumer-offsets' (kafka.utils.KafkaScheduler)

2021-05-06 Thread Jira
[ https://issues.apache.org/jira/browse/KAFKA-5381?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17340494#comment-17340494 ] Salvador Germán Aguallo commented on KAFKA-5381: [~mjuarez] did you ever

  1   2   >