[jira] [Created] (KAFKA-12978) Kafka Health is returning returning DOWN: org.apache.kafka.common.errors.TimeoutException: Aborted due to timeout.

Shaun Wackerly created KAFKA-12978: -- Summary: Kafka Health is returning returning DOWN: org.apache.kafka.common.errors.TimeoutException: Aborted due to timeout. Key: KAFKA-12978 URL:

[jira] [Commented] (KAFKA-12980) Allow consumers to return from poll when position advances due to aborted transactions

[ https://issues.apache.org/jira/browse/KAFKA-12980?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17367563#comment-17367563 ] Chris Egerton commented on KAFKA-12980: --- [~guozhang] would you also like to weigh in? > Allow

[GitHub] [kafka] hachikuji commented on a change in pull request #10913: KAFKA-12631; Implement `resign` API in `KafkaRaftClient`

hachikuji commented on a change in pull request #10913: URL: https://github.com/apache/kafka/pull/10913#discussion_r656452042 ## File path: raft/src/main/java/org/apache/kafka/raft/KafkaRaftClient.java ## @@ -1914,8 +1917,7 @@ private long pollLeader(long currentTimeMs) {

[GitHub] [kafka] hachikuji commented on a change in pull request #10913: KAFKA-12631; Implement `resign` API in `KafkaRaftClient`

hachikuji commented on a change in pull request #10913: URL: https://github.com/apache/kafka/pull/10913#discussion_r656446168 ## File path: raft/src/main/java/org/apache/kafka/raft/KafkaRaftClient.java ## @@ -143,6 +144,7 @@ public static final int MAX_BATCH_SIZE_BYTES =

[GitHub] [kafka] jsancio commented on a change in pull request #10812: KAFKA-12863: Configure controller snapshot generation

jsancio commented on a change in pull request #10812: URL: https://github.com/apache/kafka/pull/10812#discussion_r656483156 ## File path: core/src/main/scala/kafka/server/KafkaConfig.scala ## @@ -1049,6 +1052,7 @@ object KafkaConfig {

[GitHub] [kafka] ryannedolan commented on pull request #10629: BlockingConnectorTest improvements to verify Connectors and Tasks are successfully deleted

ryannedolan commented on pull request #10629: URL: https://github.com/apache/kafka/pull/10629#issuecomment-866147667 @C0urante do you mind reviewing? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[jira] [Updated] (KAFKA-12980) Allow consumers to return from poll when position advances due to aborted transactions

[ https://issues.apache.org/jira/browse/KAFKA-12980?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chris Egerton updated KAFKA-12980: -- Summary: Allow consumers to return from poll when position advances due to aborted

[jira] [Created] (KAFKA-12980) Allow consumers to return from poll when position advances

Chris Egerton created KAFKA-12980: - Summary: Allow consumers to return from poll when position advances Key: KAFKA-12980 URL: https://issues.apache.org/jira/browse/KAFKA-12980 Project: Kafka

[GitHub] [kafka] hachikuji merged pull request #10883: KAFKA-12949: TestRaftServer's scala.MatchError: null on test-kraft-server-start.sh

hachikuji merged pull request #10883: URL: https://github.com/apache/kafka/pull/10883 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service,

[GitHub] [kafka] jolshan commented on a change in pull request #10892: [WIP] New Admin API for deleteTopics

jolshan commented on a change in pull request #10892: URL: https://github.com/apache/kafka/pull/10892#discussion_r656473894 ## File path: clients/src/main/java/org/apache/kafka/clients/admin/TopicCollection.java ## @@ -0,0 +1,91 @@ +/* + * Licensed to the Apache Software

[GitHub] [kafka] hachikuji commented on a change in pull request #10913: KAFKA-12631; Implement `resign` API in `KafkaRaftClient`

hachikuji commented on a change in pull request #10913: URL: https://github.com/apache/kafka/pull/10913#discussion_r656402618 ## File path: raft/src/main/java/org/apache/kafka/raft/KafkaRaftClient.java ## @@ -1914,8 +1917,7 @@ private long pollLeader(long currentTimeMs) {

[GitHub] [kafka] jsancio commented on a change in pull request #10913: KAFKA-12631; Implement `resign` API in `KafkaRaftClient`

jsancio commented on a change in pull request #10913: URL: https://github.com/apache/kafka/pull/10913#discussion_r656397806 ## File path: raft/src/main/java/org/apache/kafka/raft/KafkaRaftClient.java ## @@ -143,6 +144,7 @@ public static final int MAX_BATCH_SIZE_BYTES = 8

[jira] [Commented] (KAFKA-12980) Allow consumers to return from poll when position advances due to aborted transactions

[ https://issues.apache.org/jira/browse/KAFKA-12980?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17367556#comment-17367556 ] Chris Egerton commented on KAFKA-12980: --- CC [~hachikuji]--thoughts on this? > Allow consumers to

[GitHub] [kafka] hachikuji commented on a change in pull request #10892: [WIP] New Admin API for deleteTopics

hachikuji commented on a change in pull request #10892: URL: https://github.com/apache/kafka/pull/10892#discussion_r656431145 ## File path: clients/src/main/java/org/apache/kafka/clients/admin/TopicCollection.java ## @@ -0,0 +1,91 @@ +/* + * Licensed to the Apache Software

[GitHub] [kafka] jolshan commented on a change in pull request #10892: [WIP] New Admin API for deleteTopics

jolshan commented on a change in pull request #10892: URL: https://github.com/apache/kafka/pull/10892#discussion_r656478396 ## File path: clients/src/main/java/org/apache/kafka/clients/admin/TopicCollection.java ## @@ -0,0 +1,91 @@ +/* + * Licensed to the Apache Software

[jira] [Created] (KAFKA-12981) Ensure LogSegment.maxTimestampSoFar and LogSegment.offsetOfMaxTimestampSoFar are read/updated in sync

Tom Scott created KAFKA-12981: - Summary: Ensure LogSegment.maxTimestampSoFar and LogSegment.offsetOfMaxTimestampSoFar are read/updated in sync Key: KAFKA-12981 URL: https://issues.apache.org/jira/browse/KAFKA-12981

[GitHub] [kafka] thomaskwscott commented on a change in pull request #10760: KAFKA-12541 Extend ListOffset to fetch offset with max timestamp

thomaskwscott commented on a change in pull request #10760: URL: https://github.com/apache/kafka/pull/10760#discussion_r656527325 ## File path: core/src/main/scala/kafka/log/Log.scala ## @@ -1316,6 +1316,16 @@ class Log(@volatile private var _dir: File, val

[jira] [Created] (KAFKA-12979) Implement --find-hanging API in transaction tool

Jason Gustafson created KAFKA-12979: --- Summary: Implement --find-hanging API in transaction tool Key: KAFKA-12979 URL: https://issues.apache.org/jira/browse/KAFKA-12979 Project: Kafka Issue

[jira] [Resolved] (KAFKA-12888) Add transaction tool

[ https://issues.apache.org/jira/browse/KAFKA-12888?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason Gustafson resolved KAFKA-12888. - Resolution: Fixed > Add transaction tool > > >

[GitHub] [kafka] jolshan commented on a change in pull request #10892: [WIP] New Admin API for deleteTopics

jolshan commented on a change in pull request #10892: URL: https://github.com/apache/kafka/pull/10892#discussion_r656474094 ## File path: clients/src/main/java/org/apache/kafka/clients/admin/Admin.java ## @@ -233,41 +232,41 @@ default DeleteTopicsResult

[GitHub] [kafka] hachikuji merged pull request #10814: KAFKA-12888; Add transaction tool from KIP-664

hachikuji merged pull request #10814: URL: https://github.com/apache/kafka/pull/10814 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service,

[GitHub] [kafka] hachikuji commented on a change in pull request #10913: KAFKA-12631; Implement `resign` API in `KafkaRaftClient`

hachikuji commented on a change in pull request #10913: URL: https://github.com/apache/kafka/pull/10913#discussion_r656424358 ## File path: raft/src/test/java/org/apache/kafka/raft/KafkaRaftClientTest.java ## @@ -359,6 +360,150 @@ public void

[GitHub] [kafka] hachikuji commented on a change in pull request #10913: KAFKA-12631; Implement `resign` API in `KafkaRaftClient`

hachikuji commented on a change in pull request #10913: URL: https://github.com/apache/kafka/pull/10913#discussion_r656448517 ## File path: raft/src/main/java/org/apache/kafka/raft/KafkaRaftClient.java ## @@ -2250,7 +2252,34 @@ private Long append(int epoch, List records,

[GitHub] [kafka] jolshan commented on a change in pull request #10892: [WIP] New Admin API for deleteTopics

jolshan commented on a change in pull request #10892: URL: https://github.com/apache/kafka/pull/10892#discussion_r656472986 ## File path: clients/src/main/java/org/apache/kafka/clients/admin/Admin.java ## @@ -233,41 +232,41 @@ default DeleteTopicsResult

[GitHub] [kafka] jolshan commented on a change in pull request #10892: [WIP] New Admin API for deleteTopics

jolshan commented on a change in pull request #10892: URL: https://github.com/apache/kafka/pull/10892#discussion_r656472684 ## File path: clients/src/main/java/org/apache/kafka/clients/admin/Admin.java ## @@ -233,41 +232,41 @@ default DeleteTopicsResult

[jira] [Comment Edited] (KAFKA-12980) Allow consumers to return from poll when position advances due to aborted transactions

[ https://issues.apache.org/jira/browse/KAFKA-12980?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17367706#comment-17367706 ] Jason Gustafson edited comment on KAFKA-12980 at 6/22/21, 10:14 PM:

[GitHub] [kafka] rondagostino opened a new pull request #10918: KAFKA-12756: Update ZooKeeper to v3.6.3

rondagostino opened a new pull request #10918: URL: https://github.com/apache/kafka/pull/10918 Updates ZooKeeper to v3.6.3. Adds some additional exercising of ZooKeeper in the upgrade system tests. Also adds 2.8.0 to the system test docker image. The dependency on

[jira] [Commented] (KAFKA-12790) Fix SslTransportLayerTest.testUnsupportedTlsVersion with JDK 16

[ https://issues.apache.org/jira/browse/KAFKA-12790?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17367715#comment-17367715 ] Ismael Juma commented on KAFKA-12790: - Thanks for clarifying why some tests started failing in

[GitHub] [kafka] kpatelatwork commented on a change in pull request #10822: KAFKA-4793: Connect API to restart connector and tasks (KIP-745)

kpatelatwork commented on a change in pull request #10822: URL: https://github.com/apache/kafka/pull/10822#discussion_r656653569 ## File path: connect/runtime/src/main/java/org/apache/kafka/connect/runtime/RestartPlan.java ## @@ -0,0 +1,154 @@ +/* + * Licensed to the Apache

[GitHub] [kafka] hachikuji commented on a change in pull request #10913: KAFKA-12631; Implement `resign` API in `KafkaRaftClient`

hachikuji commented on a change in pull request #10913: URL: https://github.com/apache/kafka/pull/10913#discussion_r656583963 ## File path: raft/src/test/java/org/apache/kafka/raft/KafkaRaftClientTest.java ## @@ -359,6 +360,150 @@ public void

[jira] [Comment Edited] (KAFKA-12790) Fix SslTransportLayerTest.testUnsupportedTlsVersion with JDK 16

[ https://issues.apache.org/jira/browse/KAFKA-12790?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17367686#comment-17367686 ] Uwe Eisele edited comment on KAFKA-12790 at 6/22/21, 9:19 PM: -- It looks

[jira] [Commented] (KAFKA-12790) Fix SslTransportLayerTest.testUnsupportedTlsVersion with JDK 16

[ https://issues.apache.org/jira/browse/KAFKA-12790?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17367686#comment-17367686 ] Uwe Eisele commented on KAFKA-12790: It looks like that the test also no longer runs on JDK 11.

[jira] [Commented] (KAFKA-12786) Getting SslTransportLayerTest error

[ https://issues.apache.org/jira/browse/KAFKA-12786?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17367690#comment-17367690 ] Uwe Eisele commented on KAFKA-12786: As of JDK 11.0.11, TLSv1.1 is disabled by default (see

[GitHub] [kafka] kpatelatwork commented on a change in pull request #10822: KAFKA-4793: Connect API to restart connector and tasks (KIP-745)

kpatelatwork commented on a change in pull request #10822: URL: https://github.com/apache/kafka/pull/10822#discussion_r656654293 ## File path: connect/runtime/src/main/java/org/apache/kafka/connect/runtime/RestartPlan.java ## @@ -0,0 +1,154 @@ +/* + * Licensed to the Apache

[GitHub] [kafka] skaundinya15 commented on a change in pull request #10743: KIP-699: Update FindCoordinator to resolve multiple Coordinators at a time

skaundinya15 commented on a change in pull request #10743: URL: https://github.com/apache/kafka/pull/10743#discussion_r656577521 ## File path: clients/src/main/java/org/apache/kafka/clients/admin/internals/DeleteConsumerGroupsHandler.java ## @@ -0,0 +1,135 @@ +/* + * Licensed

[jira] [Commented] (KAFKA-12982) Notify listeners of raft client shutdowns

[ https://issues.apache.org/jira/browse/KAFKA-12982?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17367713#comment-17367713 ] Jason Gustafson commented on KAFKA-12982: - The `shutdown` API is mainly about graceful leaving

[jira] [Assigned] (KAFKA-12786) Getting SslTransportLayerTest error

[ https://issues.apache.org/jira/browse/KAFKA-12786?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ismael Juma reassigned KAFKA-12786: --- Assignee: Ismael Juma > Getting SslTransportLayerTest error >

[GitHub] [kafka] kowshik commented on a change in pull request #10896: KAFKA-12964: Collect and rename snapshot files prior to async deletion.

kowshik commented on a change in pull request #10896: URL: https://github.com/apache/kafka/pull/10896#discussion_r656397814 ## File path: core/src/test/scala/unit/kafka/log/LogLoaderTest.scala ## @@ -1535,4 +1534,122 @@ class LogLoaderTest {

[jira] [Commented] (KAFKA-12960) WindowStore and SessionStore do not enforce strict retention time

[ https://issues.apache.org/jira/browse/KAFKA-12960?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17367795#comment-17367795 ] A. Sophie Blee-Goldman commented on KAFKA-12960: +1 on pushing this responsibility to

[GitHub] [kafka] kowshik commented on a change in pull request #10896: KAFKA-12964: Collect and rename snapshot files prior to async deletion.

kowshik commented on a change in pull request #10896: URL: https://github.com/apache/kafka/pull/10896#discussion_r656397814 ## File path: core/src/test/scala/unit/kafka/log/LogLoaderTest.scala ## @@ -1535,4 +1534,122 @@ class LogLoaderTest {

[GitHub] [kafka] hachikuji commented on a change in pull request #10913: KAFKA-12631; Implement `resign` API in `KafkaRaftClient`

hachikuji commented on a change in pull request #10913: URL: https://github.com/apache/kafka/pull/10913#discussion_r656593011 ## File path: raft/src/test/java/org/apache/kafka/raft/KafkaRaftClientTest.java ## @@ -359,6 +360,150 @@ public void

[GitHub] [kafka] mjsax opened a new pull request #10917: KAFKA-10847: improve throughput of stream-stream join with spurious left/outer join fix

mjsax opened a new pull request #10917: URL: https://github.com/apache/kafka/pull/10917 The fix to avoid spurious left/outer stream-stream join results, showed very low throughput for RocksDB, due to excessive creation of iterators. Instead of trying to emit left/outer stream-stream

[GitHub] [kafka] jsancio commented on a change in pull request #10913: KAFKA-12631; Implement `resign` API in `KafkaRaftClient`

jsancio commented on a change in pull request #10913: URL: https://github.com/apache/kafka/pull/10913#discussion_r656616690 ## File path: raft/src/main/java/org/apache/kafka/raft/KafkaRaftClient.java ## @@ -143,6 +144,7 @@ public static final int MAX_BATCH_SIZE_BYTES = 8

[GitHub] [kafka] kpatelatwork commented on a change in pull request #10822: KAFKA-4793: Connect API to restart connector and tasks (KIP-745)

kpatelatwork commented on a change in pull request #10822: URL: https://github.com/apache/kafka/pull/10822#discussion_r656633775 ## File path: connect/runtime/src/test/java/org/apache/kafka/connect/util/clusters/EmbeddedConnectCluster.java ## @@ -559,6 +560,31 @@ public

[GitHub] [kafka] kpatelatwork commented on a change in pull request #10822: KAFKA-4793: Connect API to restart connector and tasks (KIP-745)

kpatelatwork commented on a change in pull request #10822: URL: https://github.com/apache/kafka/pull/10822#discussion_r656652231 ## File path: connect/runtime/src/main/java/org/apache/kafka/connect/runtime/RestartPlan.java ## @@ -0,0 +1,154 @@ +/* + * Licensed to the Apache

[GitHub] [kafka] hachikuji commented on a change in pull request #10892: [WIP] New Admin API for deleteTopics

hachikuji commented on a change in pull request #10892: URL: https://github.com/apache/kafka/pull/10892#discussion_r656584668 ## File path: clients/src/main/java/org/apache/kafka/clients/admin/TopicCollection.java ## @@ -0,0 +1,91 @@ +/* + * Licensed to the Apache Software

[GitHub] [kafka] jolshan commented on a change in pull request #10892: [WIP] New Admin API for deleteTopics

jolshan commented on a change in pull request #10892: URL: https://github.com/apache/kafka/pull/10892#discussion_r656588520 ## File path: clients/src/main/java/org/apache/kafka/clients/admin/TopicCollection.java ## @@ -0,0 +1,91 @@ +/* + * Licensed to the Apache Software

[GitHub] [kafka] hachikuji commented on a change in pull request #10913: KAFKA-12631; Implement `resign` API in `KafkaRaftClient`

hachikuji commented on a change in pull request #10913: URL: https://github.com/apache/kafka/pull/10913#discussion_r656588602 ## File path: raft/src/test/java/org/apache/kafka/raft/KafkaRaftClientTest.java ## @@ -359,6 +360,150 @@ public void

[jira] [Commented] (KAFKA-12790) Fix SslTransportLayerTest.testUnsupportedTlsVersion with JDK 16

[ https://issues.apache.org/jira/browse/KAFKA-12790?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17367691#comment-17367691 ] Uwe Eisele commented on KAFKA-12790: There is also already a ticket for JDK 11 (KAFKA-12786). > Fix

[GitHub] [kafka] ccding commented on pull request #10763: KAFKA-12520: Ensure log loading does not truncate producer state unless required

ccding commented on pull request #10763: URL: https://github.com/apache/kafka/pull/10763#issuecomment-866388636 added two tests: they should cover all the cases around file renaming during compaction -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [kafka] ableegoldman commented on a change in pull request #10840: KAFKA-12849: KIP-744 TaskMetadata ThreadMetadata StreamsMetadata as API

ableegoldman commented on a change in pull request #10840: URL: https://github.com/apache/kafka/pull/10840#discussion_r656694680 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/TaskMetadataImpl.java ## @@ -0,0 +1,105 @@ +/* + * Licensed to the

[GitHub] [kafka] jsancio commented on a change in pull request #10887: MINOR: Refactor the MetadataCache interface

jsancio commented on a change in pull request #10887: URL: https://github.com/apache/kafka/pull/10887#discussion_r656432494 ## File path: core/src/main/scala/kafka/server/BrokerServer.scala ## @@ -359,10 +359,14 @@ class BrokerServer( // Start other services that we've

[GitHub] [kafka] hachikuji commented on a change in pull request #10913: KAFKA-12631; Implement `resign` API in `KafkaRaftClient`

hachikuji commented on a change in pull request #10913: URL: https://github.com/apache/kafka/pull/10913#discussion_r656620738 ## File path: raft/src/main/java/org/apache/kafka/raft/KafkaRaftClient.java ## @@ -143,6 +144,7 @@ public static final int MAX_BATCH_SIZE_BYTES =

[GitHub] [kafka] ijuma commented on a change in pull request #10918: KAFKA-12756: Update ZooKeeper to v3.6.3

ijuma commented on a change in pull request #10918: URL: https://github.com/apache/kafka/pull/10918#discussion_r656620095 ## File path: docs/upgrade.html ## @@ -21,6 +21,13 @@ Notable changes in 3.0.0 +ZooKeeper has been upgraded to 3.6.3, and that version has a hard

[GitHub] [kafka] ijuma commented on a change in pull request #10918: KAFKA-12756: Update ZooKeeper to v3.6.3

ijuma commented on a change in pull request #10918: URL: https://github.com/apache/kafka/pull/10918#discussion_r656620373 ## File path: gradle/dependencies.gradle ## @@ -61,6 +61,7 @@ versions += [ bcpkix: "1.66", checkstyle: "8.36.2", commonsCli: "1.4", +

[jira] [Assigned] (KAFKA-12984) Cooperative sticky assignor can get stuck with invalid SubscriptionState input metadata

[ https://issues.apache.org/jira/browse/KAFKA-12984?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] A. Sophie Blee-Goldman reassigned KAFKA-12984: -- Assignee: A. Sophie Blee-Goldman > Cooperative sticky assignor can

[jira] [Assigned] (KAFKA-12983) onJoinPrepare is not always invoked before joining the group

[ https://issues.apache.org/jira/browse/KAFKA-12983?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] A. Sophie Blee-Goldman reassigned KAFKA-12983: -- Assignee: A. Sophie Blee-Goldman > onJoinPrepare is not always

[jira] [Comment Edited] (KAFKA-12790) Fix SslTransportLayerTest.testUnsupportedTlsVersion with JDK 16

[ https://issues.apache.org/jira/browse/KAFKA-12790?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17367686#comment-17367686 ] Uwe Eisele edited comment on KAFKA-12790 at 6/22/21, 9:23 PM: -- It looks

[jira] [Commented] (KAFKA-12980) Allow consumers to return from poll when position advances due to aborted transactions

[ https://issues.apache.org/jira/browse/KAFKA-12980?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17367706#comment-17367706 ] Jason Gustafson commented on KAFKA-12980: - The suggestion seems reasonable to me. This would

[GitHub] [kafka] ableegoldman merged pull request #10862: KAFKA-12928: Add a check whether the Task's statestore is actually a directory

ableegoldman merged pull request #10862: URL: https://github.com/apache/kafka/pull/10862 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service,

[jira] [Commented] (KAFKA-12896) Group rebalance loop caused by repeated group leader JoinGroups

[ https://issues.apache.org/jira/browse/KAFKA-12896?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17367805#comment-17367805 ] A. Sophie Blee-Goldman commented on KAFKA-12896: I believe this is caused by

[jira] [Created] (KAFKA-12982) Notify listeners of raft client shutdowns

Jose Armando Garcia Sancio created KAFKA-12982: -- Summary: Notify listeners of raft client shutdowns Key: KAFKA-12982 URL: https://issues.apache.org/jira/browse/KAFKA-12982 Project: Kafka

[GitHub] [kafka] kpatelatwork commented on a change in pull request #10822: KAFKA-4793: Connect API to restart connector and tasks (KIP-745)

kpatelatwork commented on a change in pull request #10822: URL: https://github.com/apache/kafka/pull/10822#discussion_r656633158 ## File path: connect/runtime/src/test/java/org/apache/kafka/connect/util/clusters/EmbeddedConnectCluster.java ## @@ -428,6 +429,40 @@ public void

[jira] [Created] (KAFKA-12983) onJoinPrepare is not always invoked before joining the group

A. Sophie Blee-Goldman created KAFKA-12983: -- Summary: onJoinPrepare is not always invoked before joining the group Key: KAFKA-12983 URL: https://issues.apache.org/jira/browse/KAFKA-12983

[jira] [Created] (KAFKA-12984) Cooperative sticky assignor can get stuck with invalid SubscriptionState input metadata

A. Sophie Blee-Goldman created KAFKA-12984: -- Summary: Cooperative sticky assignor can get stuck with invalid SubscriptionState input metadata Key: KAFKA-12984 URL:

[GitHub] [kafka] vitojeng commented on pull request #10825: KAFKA-5876: Add `streams()` method to StateStoreProvider

vitojeng commented on pull request #10825: URL: https://github.com/apache/kafka/pull/10825#issuecomment-866504180 > Just one high-level comment: if all we need this for is the state, then maybe we should just add a method for that instead of exposing the `KafkaStreams` object directly.

[GitHub] [kafka] ccding commented on a change in pull request #10579: KAFKA-9555 Added default RLMM implementation based on internal topic storage.

ccding commented on a change in pull request #10579: URL: https://github.com/apache/kafka/pull/10579#discussion_r656735781 ## File path: storage/src/main/java/org/apache/kafka/server/log/remote/metadata/storage/ConsumerManager.java ## @@ -0,0 +1,139 @@ +/* + * Licensed to the

[GitHub] [kafka] kkonstantine commented on pull request #10677: KAFKA-12380 Executor in Connect's Worker is not shut down when the worker is

kkonstantine commented on pull request #10677: URL: https://github.com/apache/kafka/pull/10677#issuecomment-866550637 Closing in favor of https://github.com/apache/kafka/pull/10774 (duplicate) -- This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [kafka] kkonstantine closed pull request #10677: KAFKA-12380 Executor in Connect's Worker is not shut down when the worker is

kkonstantine closed pull request #10677: URL: https://github.com/apache/kafka/pull/10677 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service,

[GitHub] [kafka] skaundinya15 commented on a change in pull request #10743: KIP-699: Update FindCoordinator to resolve multiple Coordinators at a time

skaundinya15 commented on a change in pull request #10743: URL: https://github.com/apache/kafka/pull/10743#discussion_r655921765 ## File path: clients/src/main/java/org/apache/kafka/common/requests/FindCoordinatorResponse.java ## @@ -95,4 +96,21 @@ public static

[GitHub] [kafka] kkonstantine commented on a change in pull request #10841: KAFKA-12482 Remove deprecated rest.host.name and rest.port configs

kkonstantine commented on a change in pull request #10841: URL: https://github.com/apache/kafka/pull/10841#discussion_r655880156 ## File path: connect/runtime/src/main/java/org/apache/kafka/connect/runtime/WorkerConfig.java ## @@ -497,6 +476,37 @@ static void

[GitHub] [kafka] skaundinya15 commented on a change in pull request #10743: KIP-699: Update FindCoordinator to resolve multiple Coordinators at a time

skaundinya15 commented on a change in pull request #10743: URL: https://github.com/apache/kafka/pull/10743#discussion_r655921459 ## File path: clients/src/main/java/org/apache/kafka/common/requests/FindCoordinatorRequest.java ## @@ -70,7 +75,7 @@ public AbstractResponse

[GitHub] [kafka] kkonstantine commented on a change in pull request #10822: KAFKA-4793: Connect API to restart connector and tasks (KIP-745)

kkonstantine commented on a change in pull request #10822: URL: https://github.com/apache/kafka/pull/10822#discussion_r653815012 ## File path: connect/runtime/src/main/java/org/apache/kafka/connect/runtime/AbstractHerder.java ## @@ -210,6 +211,15 @@ public void

[GitHub] [kafka] dengziming commented on a change in pull request #10913: KAFKA-12631; Implement `resign` API in `KafkaRaftClient`

dengziming commented on a change in pull request #10913: URL: https://github.com/apache/kafka/pull/10913#discussion_r655833840 ## File path: raft/src/test/java/org/apache/kafka/raft/KafkaRaftClientTest.java ## @@ -359,6 +360,150 @@ public void

[GitHub] [kafka] C0urante commented on pull request #10907: KAFKA-10000: Exactly-once support for source connectors

C0urante commented on pull request #10907: URL: https://github.com/apache/kafka/pull/10907#issuecomment-865396213 There was a small misunderstanding of the rebalance logic for distributed workers. It turns out that they already preemptively stop reconfigured tasks before (re)joining the

[GitHub] [kafka] rondagostino edited a comment on pull request #10908: MINOR: fix round_trip_fault_test.py - don't assign replicas to nonexi…

rondagostino edited a comment on pull request #10908: URL: https://github.com/apache/kafka/pull/10908#issuecomment-865055596 Sorry to come to this party a bit late. It is likely that the code had a mistake and broker.id=0 should have been broker.id=1. But even with the mistake, I wonder

[GitHub] [kafka] jolshan commented on a change in pull request #9944: KAFKA-10580: Add topic ID support to Fetch request

jolshan commented on a change in pull request #9944: URL: https://github.com/apache/kafka/pull/9944#discussion_r655642933 ## File path: core/src/test/scala/unit/kafka/server/FetchRequestTest.scala ## @@ -116,61 +122,85 @@ class FetchRequestTest extends BaseRequestTest {

[GitHub] [kafka] kkonstantine commented on a change in pull request #10822: KAFKA-4793: Connect API to restart connector and tasks (KIP-745)

kkonstantine commented on a change in pull request #10822: URL: https://github.com/apache/kafka/pull/10822#discussion_r653815012 ## File path: connect/runtime/src/main/java/org/apache/kafka/connect/runtime/AbstractHerder.java ## @@ -210,6 +211,15 @@ public void

[GitHub] [kafka] dongjinleekr commented on a change in pull request #10827: [WIP] KAFKA-12899: Support --bootstrap-server in ReplicaVerificationTool

dongjinleekr commented on a change in pull request #10827: URL: https://github.com/apache/kafka/pull/10827#discussion_r655162053 ## File path: core/src/test/scala/kafka/tools/ReplicaVerificationToolTest.scala ## @@ -17,14 +17,40 @@ package kafka.tools +import

[GitHub] [kafka] dajac commented on a change in pull request #10743: KIP-699: Update FindCoordinator to resolve multiple Coordinators at a time

dajac commented on a change in pull request #10743: URL: https://github.com/apache/kafka/pull/10743#discussion_r655911095 ## File path: clients/src/main/java/org/apache/kafka/clients/admin/DeleteConsumerGroupsResult.java ## @@ -29,9 +32,9 @@ */ @InterfaceStability.Evolving

[GitHub] [kafka] cadonna commented on a change in pull request #10740: Kafka 8613 kip 633 drop default grace period streams

cadonna commented on a change in pull request #10740: URL: https://github.com/apache/kafka/pull/10740#discussion_r655626428 ## File path: streams/src/main/java/org/apache/kafka/streams/kstream/TimeWindows.java ## @@ -85,14 +87,11 @@ private TimeWindows(final long sizeMs,

[GitHub] [kafka] dongjinleekr commented on pull request #10678: TRIVIAL: Fix type inconsistencies, unthrown exceptions, etc

dongjinleekr commented on pull request #10678: URL: https://github.com/apache/kafka/pull/10678#issuecomment-864781801 Rebased onto the latest trunk. cc/ @ijuma @cadonna -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [kafka] kowshik commented on a change in pull request #10896: KAFKA-12964: Collect and rename snapshot files prior to async deletion.

kowshik commented on a change in pull request #10896: URL: https://github.com/apache/kafka/pull/10896#discussion_r655768001 ## File path: core/src/main/scala/kafka/log/ProducerStateManager.scala ## @@ -828,15 +834,50 @@ class ProducerStateManager(val topicPartition:

[GitHub] [kafka] mattwong949 commented on pull request #10914: [KAKFA-8522] Streamline tombstone and transaction marker removal

mattwong949 commented on pull request #10914: URL: https://github.com/apache/kafka/pull/10914#issuecomment-865452418 @junrao @hachikuji Could you help take a review pass? I know Jun has reviewed before, but since we've rebased several times I think it would be helpful to look over again

[GitHub] [kafka] kowshik commented on pull request #10280: KAFKA-12554: Refactor Log layer

kowshik commented on pull request #10280: URL: https://github.com/apache/kafka/pull/10280#issuecomment-865332690 @junrao @dhruvilshah3 I ran a perf test against a Broker build with and without this PR. The test involved the following: 1. Created a test topic with 1 partition and

[GitHub] [kafka] rhauch commented on a change in pull request #10822: KAFKA-4793: Connect API to restart connector and tasks (KIP-745)

rhauch commented on a change in pull request #10822: URL: https://github.com/apache/kafka/pull/10822#discussion_r655658286 ## File path: connect/runtime/src/main/java/org/apache/kafka/connect/runtime/distributed/DistributedHerder.java ## @@ -1063,6 +1076,112 @@ public int

[GitHub] [kafka] hachikuji commented on a change in pull request #10814: KAFKA-12888; Add transaction tool from KIP-664

hachikuji commented on a change in pull request #10814: URL: https://github.com/apache/kafka/pull/10814#discussion_r655631267 ## File path: tools/src/main/java/org/apache/kafka/tools/TransactionsCommand.java ## @@ -0,0 +1,623 @@ +/* + * Licensed to the Apache Software

[GitHub] [kafka] niket-goel commented on a change in pull request #10899: KAFKA-12952 Adding Delimeters to Metadata Snapshot File

niket-goel commented on a change in pull request #10899: URL: https://github.com/apache/kafka/pull/10899#discussion_r655511645 ## File path: clients/src/main/java/org/apache/kafka/common/record/MemoryRecords.java ## @@ -664,4 +666,55 @@ private static void

[GitHub] [kafka] junrao commented on a change in pull request #9944: KAFKA-10580: Add topic ID support to Fetch request

junrao commented on a change in pull request #9944: URL: https://github.com/apache/kafka/pull/9944#discussion_r655561404 ## File path: core/src/main/scala/kafka/server/FetchSession.scala ## @@ -471,16 +504,19 @@ class IncrementalFetchContext(private val time: Time, if

[GitHub] [kafka] hachikuji commented on a change in pull request #10900: KAFKA-12967; KRaft broker should forward DescribeQuorum to controller

hachikuji commented on a change in pull request #10900: URL: https://github.com/apache/kafka/pull/10900#discussion_r66345 ## File path: core/src/test/java/kafka/test/annotation/Type.java ## @@ -28,7 +28,7 @@ * The type of cluster config being requested. Used by {@link

[GitHub] [kafka] jsancio commented on a change in pull request #10812: KAFKA-12863: Configure controller snapshot generation

jsancio commented on a change in pull request #10812: URL: https://github.com/apache/kafka/pull/10812#discussion_r655732329 ## File path: core/src/main/scala/kafka/server/KafkaConfig.scala ## @@ -74,6 +74,7 @@ object Defaults { val InitialBrokerRegistrationTimeoutMs = 6

[GitHub] [kafka] gardnervickers commented on a change in pull request #10896: KAFKA-12964: Collect and rename snapshot files prior to async deletion.

gardnervickers commented on a change in pull request #10896: URL: https://github.com/apache/kafka/pull/10896#discussion_r655545444 ## File path: core/src/main/scala/kafka/log/ProducerStateManager.scala ## @@ -828,12 +834,41 @@ class ProducerStateManager(val topicPartition:

[GitHub] [kafka] tombentley commented on a change in pull request #10827: [WIP] KAFKA-12899: Support --bootstrap-server in ReplicaVerificationTool

tombentley commented on a change in pull request #10827: URL: https://github.com/apache/kafka/pull/10827#discussion_r655154960 ## File path: core/src/main/scala/kafka/tools/ReplicaVerificationTool.scala ## @@ -73,53 +74,61 @@ object ReplicaVerificationTool extends Logging {

[GitHub] [kafka] dongjinleekr commented on pull request #10862: KAFKA-12928: Add a check whether the Task's statestore is actually a directory

dongjinleekr commented on pull request #10862: URL: https://github.com/apache/kafka/pull/10862#issuecomment-864785044 Rebased onto the latest trunk cc/ @ableegoldman -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [kafka] dajac commented on a change in pull request #10743: KIP-699: Update FindCoordinator to resolve multiple Coordinators at a time

dajac commented on a change in pull request #10743: URL: https://github.com/apache/kafka/pull/10743#discussion_r655911095 ## File path: clients/src/main/java/org/apache/kafka/clients/admin/DeleteConsumerGroupsResult.java ## @@ -29,9 +32,9 @@ */ @InterfaceStability.Evolving

[GitHub] [kafka] kpatelatwork commented on a change in pull request #10822: KAFKA-4793: Connect API to restart connector and tasks (KIP-745)

kpatelatwork commented on a change in pull request #10822: URL: https://github.com/apache/kafka/pull/10822#discussion_r655408049 ## File path: connect/runtime/src/main/java/org/apache/kafka/connect/runtime/distributed/DistributedHerder.java ## @@ -1063,6 +1076,112 @@ public

[GitHub] [kafka] cmccabe commented on a change in pull request #10899: KAFKA-12952 Adding Delimiters to Metadata Snapshot

cmccabe commented on a change in pull request #10899: URL: https://github.com/apache/kafka/pull/10899#discussion_r655616706 ## File path: clients/src/main/java/org/apache/kafka/common/record/MemoryRecords.java ## @@ -664,4 +666,55 @@ private static void

[GitHub] [kafka] chia7712 commented on pull request #10908: MINOR: fix round_trip_fault_test.py - don't assign replicas to nonexi…

chia7712 commented on pull request #10908: URL: https://github.com/apache/kafka/pull/10908#issuecomment-865056585 > there is a behavior difference between the ZK-based KRaft controllers. Do we explicitly acknowledge and accept this difference? that is a good point. -- This is an

[GitHub] [kafka] jolshan commented on pull request #9769: KAFKA-10774; Support Describe topic using topic IDs

jolshan commented on pull request #9769: URL: https://github.com/apache/kafka/pull/9769#issuecomment-865491775 Hi @dengziming thanks for the update. There are a few more minor changes to the KIP. One is that after some discussion with people more familiar with clients, it makes sense

[GitHub] [kafka] izzyacademy commented on a change in pull request #10740: Kafka 8613 kip 633 drop default grace period streams

izzyacademy commented on a change in pull request #10740: URL: https://github.com/apache/kafka/pull/10740#discussion_r655661049 ## File path: streams/src/main/java/org/apache/kafka/streams/kstream/SessionWindows.java ## @@ -84,17 +86,14 @@ private SessionWindows(final long

  1   2   >