[jira] [Resolved] (KAFKA-10453) Backport of PR-7781

2020-08-31 Thread Niketh Sabbineni (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10453?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Niketh Sabbineni resolved KAFKA-10453. -- Resolution: Workaround > Backport of PR-7781 > --- > >

[jira] [Assigned] (KAFKA-10072) Kafkaconsumer is configured with different clientid parameters to obtain different results

2020-08-31 Thread Ankit Kumar (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10072?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ankit Kumar reassigned KAFKA-10072: --- Assignee: Ankit Kumar > Kafkaconsumer is configured with different clientid parameters to

[jira] [Commented] (KAFKA-10134) High CPU issue during rebalance in Kafka consumer after upgrading to 2.5

2020-08-31 Thread Guozhang Wang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10134?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17188116#comment-17188116 ] Guozhang Wang commented on KAFKA-10134: --- Hello [~zhowei] that broker-side change is not mandatory,

[jira] [Commented] (KAFKA-10366) TimeWindowedDeserializer doesn't allow users to set a custom window size

2020-08-31 Thread Sophie Blee-Goldman (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10366?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17188115#comment-17188115 ] Sophie Blee-Goldman commented on KAFKA-10366: - Yeah thanks for tracking that down [~mjsax].

[GitHub] [kafka] mumrah commented on pull request #9226: KAFKA-10444: Jenkinsfile testing

2020-08-31 Thread GitBox
mumrah commented on pull request #9226: URL: https://github.com/apache/kafka/pull/9226#issuecomment-684175203 Example failed build with a compile error: https://ci-builds.apache.org/job/Kafka/job/kafka-pr/view/change-requests/job/PR-9226/67 One with a rat failure:

[jira] [Updated] (KAFKA-10450) console-producer throws Uncaught error in kafka producer I/O thread:  (org.apache.kafka.clients.producer.internals.Sender) java.lang.IllegalStateException: There are no

2020-08-31 Thread Jigar Naik (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10450?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jigar Naik updated KAFKA-10450: --- Priority: Minor (was: Critical) > console-producer throws Uncaught error in kafka producer I/O

[jira] [Commented] (KAFKA-10450) console-producer throws Uncaught error in kafka producer I/O thread:  (org.apache.kafka.clients.producer.internals.Sender) java.lang.IllegalStateException: There are n

2020-08-31 Thread Jigar Naik (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10450?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17188085#comment-17188085 ] Jigar Naik commented on KAFKA-10450: Yes, same version for both. And also from kafka console

[jira] [Updated] (KAFKA-10450) console-producer throws Uncaught error in kafka producer I/O thread:  (org.apache.kafka.clients.producer.internals.Sender) java.lang.IllegalStateException: There are no

2020-08-31 Thread Jigar Naik (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10450?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jigar Naik updated KAFKA-10450: --- Priority: Critical (was: Blocker) > console-producer throws Uncaught error in kafka producer I/O

[jira] [Commented] (KAFKA-10450) console-producer throws Uncaught error in kafka producer I/O thread:  (org.apache.kafka.clients.producer.internals.Sender) java.lang.IllegalStateException: There are n

2020-08-31 Thread huxihx (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10450?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17188082#comment-17188082 ] huxihx commented on KAFKA-10450: Same version for both clients and brokers? > console-producer throws

[jira] [Commented] (KAFKA-10134) High CPU issue during rebalance in Kafka consumer after upgrading to 2.5

2020-08-31 Thread Jerry Wei (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10134?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17188058#comment-17188058 ] Jerry Wei commented on KAFKA-10134: --- [~guozhang] one more question about PR #8834, whether or not

[GitHub] [kafka] ableegoldman commented on a change in pull request #9138: KAFKA-9929: Support backward iterator on WindowStore

2020-08-31 Thread GitBox
ableegoldman commented on a change in pull request #9138: URL: https://github.com/apache/kafka/pull/9138#discussion_r480482350 ## File path: streams/src/main/java/org/apache/kafka/streams/state/internals/SegmentIterator.java ## @@ -67,14 +70,22 @@ public Bytes peekNextKey() {

[GitHub] [kafka] ableegoldman commented on a change in pull request #9138: KAFKA-9929: Support backward iterator on WindowStore

2020-08-31 Thread GitBox
ableegoldman commented on a change in pull request #9138: URL: https://github.com/apache/kafka/pull/9138#discussion_r480481060 ## File path: streams/src/main/java/org/apache/kafka/streams/state/internals/CachingWindowStore.java ## @@ -338,25 +452,36 @@ public synchronized

[GitHub] [kafka] ableegoldman commented on a change in pull request #9138: KAFKA-9929: Support backward iterator on WindowStore

2020-08-31 Thread GitBox
ableegoldman commented on a change in pull request #9138: URL: https://github.com/apache/kafka/pull/9138#discussion_r480479677 ## File path: streams/src/main/java/org/apache/kafka/streams/state/internals/CachingWindowStore.java ## @@ -271,27 +345,68 @@ public synchronized

[GitHub] [kafka] guozhangwang commented on a change in pull request #9232: KAFKA-9924: Add remaining property-based RocksDB metrics as described in KIP-607

2020-08-31 Thread GitBox
guozhangwang commented on a change in pull request #9232: URL: https://github.com/apache/kafka/pull/9232#discussion_r480477639 ## File path: streams/src/main/java/org/apache/kafka/streams/state/internals/metrics/RocksDBMetricsRecorder.java ## @@ -150,14 +176,55 @@ private

[GitHub] [kafka] guozhangwang commented on a change in pull request #9138: KAFKA-9929: Support backward iterator on WindowStore

2020-08-31 Thread GitBox
guozhangwang commented on a change in pull request #9138: URL: https://github.com/apache/kafka/pull/9138#discussion_r480469688 ## File path: streams/src/main/java/org/apache/kafka/streams/state/ReadOnlyWindowStore.java ## @@ -136,34 +174,64 @@ * * This iterator

[jira] [Assigned] (KAFKA-2200) kafkaProducer.send() should not call callback.onCompletion()

2020-08-31 Thread Aakash Gupta (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-2200?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aakash Gupta reassigned KAFKA-2200: --- Assignee: Aakash Gupta > kafkaProducer.send() should not call callback.onCompletion() >

[jira] [Comment Edited] (KAFKA-2200) kafkaProducer.send() should not call callback.onCompletion()

2020-08-31 Thread Aakash Gupta (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-2200?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17188042#comment-17188042 ] Aakash Gupta edited comment on KAFKA-2200 at 8/31/20, 11:20 PM: Hi

[jira] [Commented] (KAFKA-2200) kafkaProducer.send() should not call callback.onCompletion()

2020-08-31 Thread Aakash Gupta (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-2200?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17188042#comment-17188042 ] Aakash Gupta commented on KAFKA-2200: - Hi [~becket_qin] I am willing to take this ticket.  As of

[GitHub] [kafka] mumrah commented on a change in pull request #9226: KAFKA-10444: Jenkinsfile testing

2020-08-31 Thread GitBox
mumrah commented on a change in pull request #9226: URL: https://github.com/apache/kafka/pull/9226#discussion_r480452574 ## File path: Jenkinsfile ## @@ -0,0 +1,200 @@ +/* + * + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license

[GitHub] [kafka] vvcephei commented on pull request #9039: KAFKA-5636: SlidingWindows (KIP-450)

2020-08-31 Thread GitBox
vvcephei commented on pull request #9039: URL: https://github.com/apache/kafka/pull/9039#issuecomment-684074223 Since Jenkins PR builds are still not functioning, I've merged in trunk and verified this pull request locally before merging it.

[GitHub] [kafka] vvcephei merged pull request #9039: KAFKA-5636: SlidingWindows (KIP-450)

2020-08-31 Thread GitBox
vvcephei merged pull request #9039: URL: https://github.com/apache/kafka/pull/9039 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [kafka] guozhangwang commented on a change in pull request #8834: KAFKA-10134: Enable heartbeat during PrepareRebalance and Depend On State For Poll Timeout

2020-08-31 Thread GitBox
guozhangwang commented on a change in pull request #8834: URL: https://github.com/apache/kafka/pull/8834#discussion_r480429496 ## File path: clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractCoordinator.java ## @@ -528,7 +528,6 @@ public void

[GitHub] [kafka] vvcephei commented on a change in pull request #9039: KAFKA-5636: SlidingWindows (KIP-450)

2020-08-31 Thread GitBox
vvcephei commented on a change in pull request #9039: URL: https://github.com/apache/kafka/pull/9039#discussion_r480429410 ## File path: streams/src/main/java/org/apache/kafka/streams/kstream/internals/KStreamSlidingWindowAggregate.java ## @@ -0,0 +1,391 @@ +/* + * Licensed

[GitHub] [kafka] guozhangwang commented on a change in pull request #8834: KAFKA-10134: Enable heartbeat during PrepareRebalance and Depend On State For Poll Timeout

2020-08-31 Thread GitBox
guozhangwang commented on a change in pull request #8834: URL: https://github.com/apache/kafka/pull/8834#discussion_r480425820 ## File path: clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractCoordinator.java ## @@ -497,40 +501,18 @@ private

[jira] [Commented] (KAFKA-10453) Backport of PR-7781

2020-08-31 Thread Niketh Sabbineni (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10453?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17188031#comment-17188031 ] Niketh Sabbineni commented on KAFKA-10453: -- Thank you! Let me test that out then. Thanks for

[GitHub] [kafka] guozhangwang commented on a change in pull request #8834: KAFKA-10134: Enable heartbeat during PrepareRebalance and Depend On State For Poll Timeout

2020-08-31 Thread GitBox
guozhangwang commented on a change in pull request #8834: URL: https://github.com/apache/kafka/pull/8834#discussion_r476954744 ## File path: clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractCoordinator.java ## @@ -917,17 +938,14 @@ private

[jira] [Commented] (KAFKA-10453) Backport of PR-7781

2020-08-31 Thread Ismael Juma (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10453?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17188029#comment-17188029 ] Ismael Juma commented on KAFKA-10453: - Yes, it is. > Backport of PR-7781 > --- > >

[jira] [Comment Edited] (KAFKA-10453) Backport of PR-7781

2020-08-31 Thread Niketh Sabbineni (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10453?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17188028#comment-17188028 ] Niketh Sabbineni edited comment on KAFKA-10453 at 8/31/20, 10:07 PM: -

[jira] [Commented] (KAFKA-10453) Backport of PR-7781

2020-08-31 Thread Niketh Sabbineni (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10453?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17188028#comment-17188028 ] Niketh Sabbineni commented on KAFKA-10453: -- [~ijuma] Thanks for your reply. Do you happen to

[jira] [Commented] (KAFKA-10453) Backport of PR-7781

2020-08-31 Thread Ismael Juma (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10453?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17188024#comment-17188024 ] Ismael Juma commented on KAFKA-10453: - Kafka clients have no ZK dependency, so you can upgrade them

[GitHub] [kafka] tinawenqiao commented on pull request #9235: KAFKA-10449: Add some important parameter desc in connect-distributed.properties

2020-08-31 Thread GitBox
tinawenqiao commented on pull request #9235: URL: https://github.com/apache/kafka/pull/9235#issuecomment-684064832 In WokerConfig.java we found that REST_HOST_NAME_CONFIG(rest.host.name) and REST_PORT_CONFIG(rest.port) were deprecated. And some new configuration parameters are introduced

[GitHub] [kafka] tinawenqiao opened a new pull request #9235: KAFKA-10449: Add some important parameter description in connect-distributed.prope…

2020-08-31 Thread GitBox
tinawenqiao opened a new pull request #9235: URL: https://github.com/apache/kafka/pull/9235 …rties. *More detailed description of your change, if necessary. The PR title and PR message become the squashed commit message, so use a separate comment to ping reviewers.*

[jira] [Commented] (KAFKA-10453) Backport of PR-7781

2020-08-31 Thread Niketh Sabbineni (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10453?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17188021#comment-17188021 ] Niketh Sabbineni commented on KAFKA-10453: -- IMO |[https://github.com/apache/kafka/pull/7781] is

[jira] [Commented] (KAFKA-10453) Backport of PR-7781

2020-08-31 Thread Niketh Sabbineni (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10453?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17188020#comment-17188020 ] Niketh Sabbineni commented on KAFKA-10453: -- We are running on an older version of ZK. We need

[jira] [Commented] (KAFKA-10453) Backport of PR-7781

2020-08-31 Thread Ismael Juma (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10453?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17188017#comment-17188017 ] Ismael Juma commented on KAFKA-10453: - Can you help us understand why would it be much more involved

[jira] [Created] (KAFKA-10453) Backport of PR-7781

2020-08-31 Thread Niketh Sabbineni (Jira)
Niketh Sabbineni created KAFKA-10453: Summary: Backport of PR-7781 Key: KAFKA-10453 URL: https://issues.apache.org/jira/browse/KAFKA-10453 Project: Kafka Issue Type: Wish

[GitHub] [kafka] rondagostino commented on a change in pull request #9032: KAFKA-10259: KIP-554 Broker-side SCRAM Config API

2020-08-31 Thread GitBox
rondagostino commented on a change in pull request #9032: URL: https://github.com/apache/kafka/pull/9032#discussion_r480407445 ## File path: core/src/test/scala/integration/kafka/api/EndToEndAuthorizationTest.scala ## @@ -545,6 +558,16 @@ abstract class

[GitHub] [kafka] lbradstreet commented on a change in pull request #9226: KAFKA-10444: Jenkinsfile testing

2020-08-31 Thread GitBox
lbradstreet commented on a change in pull request #9226: URL: https://github.com/apache/kafka/pull/9226#discussion_r480404009 ## File path: Jenkinsfile ## @@ -0,0 +1,200 @@ +/* + * + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license

[GitHub] [kafka] vvcephei commented on pull request #9234: MINOR: Record all poll invocations

2020-08-31 Thread GitBox
vvcephei commented on pull request #9234: URL: https://github.com/apache/kafka/pull/9234#issuecomment-684038074 Hey @guozhangwang and @cadonna , I was just looking into key metrics for monitoring, and it seems like this metric is misplaced. Unlike the `pollRecordsSensor`, it seems like

[GitHub] [kafka] vvcephei opened a new pull request #9234: MINOR: Record all poll invocations

2020-08-31 Thread GitBox
vvcephei opened a new pull request #9234: URL: https://github.com/apache/kafka/pull/9234 Record the `pollSensor` after every invocation to poll, rather than just when we get records back so that we can accurately gauge how often we're invoking Consumer#poll. ### Committer Checklist

[GitHub] [kafka] mumrah commented on a change in pull request #9226: KAFKA-10444: Jenkinsfile testing

2020-08-31 Thread GitBox
mumrah commented on a change in pull request #9226: URL: https://github.com/apache/kafka/pull/9226#discussion_r480393840 ## File path: Jenkinsfile ## @@ -0,0 +1,200 @@ +/* + * + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license

[jira] [Updated] (KAFKA-10452) Only expire preferred read replica if a leader is alive for the topic

2020-08-31 Thread Jeff Kim (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10452?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jeff Kim updated KAFKA-10452: - Description: Fetch from follower functionality periodically expires and refreshes preferred read

[GitHub] [kafka] lbradstreet commented on a change in pull request #9226: KAFKA-10444: Jenkinsfile testing

2020-08-31 Thread GitBox
lbradstreet commented on a change in pull request #9226: URL: https://github.com/apache/kafka/pull/9226#discussion_r480392178 ## File path: Jenkinsfile ## @@ -0,0 +1,200 @@ +/* + * + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license

[GitHub] [kafka] mumrah commented on a change in pull request #9226: KAFKA-10444: Jenkinsfile testing

2020-08-31 Thread GitBox
mumrah commented on a change in pull request #9226: URL: https://github.com/apache/kafka/pull/9226#discussion_r480391239 ## File path: Jenkinsfile ## @@ -0,0 +1,200 @@ +/* + * + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license

[GitHub] [kafka] mumrah commented on a change in pull request #9226: KAFKA-10444: Jenkinsfile testing

2020-08-31 Thread GitBox
mumrah commented on a change in pull request #9226: URL: https://github.com/apache/kafka/pull/9226#discussion_r480388916 ## File path: Jenkinsfile ## @@ -0,0 +1,200 @@ +/* + * + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license

[GitHub] [kafka] ijuma commented on a change in pull request #9226: KAFKA-10444: Jenkinsfile testing

2020-08-31 Thread GitBox
ijuma commented on a change in pull request #9226: URL: https://github.com/apache/kafka/pull/9226#discussion_r480364696 ## File path: Jenkinsfile ## @@ -0,0 +1,200 @@ +/* + * + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license

[jira] [Created] (KAFKA-10452) Only expire preferred read replica if a leader is alive for the topic

2020-08-31 Thread Jeff Kim (Jira)
Jeff Kim created KAFKA-10452: Summary: Only expire preferred read replica if a leader is alive for the topic Key: KAFKA-10452 URL: https://issues.apache.org/jira/browse/KAFKA-10452 Project: Kafka

[jira] [Commented] (KAFKA-10429) Group Coordinator unavailability leads to missing events

2020-08-31 Thread John Roesler (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10429?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17187992#comment-17187992 ] John Roesler commented on KAFKA-10429: -- Hi Navinder, My first thought is that version 1.1.1 is

[GitHub] [kafka] rondagostino commented on a change in pull request #9032: KAFKA-10259: KIP-554 Broker-side SCRAM Config API

2020-08-31 Thread GitBox
rondagostino commented on a change in pull request #9032: URL: https://github.com/apache/kafka/pull/9032#discussion_r480370634 ## File path: core/src/test/scala/integration/kafka/api/EndToEndAuthorizationTest.scala ## @@ -545,6 +558,16 @@ abstract class

[GitHub] [kafka] rondagostino commented on a change in pull request #9032: KAFKA-10259: KIP-554 Broker-side SCRAM Config API

2020-08-31 Thread GitBox
rondagostino commented on a change in pull request #9032: URL: https://github.com/apache/kafka/pull/9032#discussion_r480370463 ## File path: core/src/test/scala/integration/kafka/api/SaslClientsWithInvalidCredentialsTest.scala ## @@ -248,4 +250,25 @@ class

[jira] [Updated] (KAFKA-10417) suppress() with cogroup() throws ClassCastException

2020-08-31 Thread John Roesler (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10417?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] John Roesler updated KAFKA-10417: - Fix Version/s: 2.6.1 > suppress() with cogroup() throws ClassCastException >

[jira] [Commented] (KAFKA-10434) Remove deprecated methods on WindowStore

2020-08-31 Thread John Roesler (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10434?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17187962#comment-17187962 ] John Roesler commented on KAFKA-10434: -- Marked as a 3.0 blocker so we will be sure to consider

[jira] [Updated] (KAFKA-10434) Remove deprecated methods on WindowStore

2020-08-31 Thread John Roesler (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10434?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] John Roesler updated KAFKA-10434: - Priority: Blocker (was: Major) > Remove deprecated methods on WindowStore >

[jira] [Assigned] (KAFKA-10445) Align IQ SessionStore API with Instant-based methods as ReadOnlyWindowStore

2020-08-31 Thread John Roesler (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10445?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] John Roesler reassigned KAFKA-10445: Assignee: Jorge Esteban Quilcate Otoya > Align IQ SessionStore API with Instant-based

[jira] [Updated] (KAFKA-10434) Remove deprecated methods on WindowStore

2020-08-31 Thread John Roesler (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10434?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] John Roesler updated KAFKA-10434: - Fix Version/s: 3.0.0 > Remove deprecated methods on WindowStore >

[jira] [Resolved] (KAFKA-10384) Separate converters from generated messages

2020-08-31 Thread Colin McCabe (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10384?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Colin McCabe resolved KAFKA-10384. -- Fix Version/s: 2.7.0 Resolution: Fixed > Separate converters from generated messages >

[GitHub] [kafka] rondagostino commented on a change in pull request #9032: KAFKA-10259: KIP-554 Broker-side SCRAM Config API

2020-08-31 Thread GitBox
rondagostino commented on a change in pull request #9032: URL: https://github.com/apache/kafka/pull/9032#discussion_r480329570 ## File path: core/src/test/scala/integration/kafka/api/SaslScramSslEndToEndAuthorizationTest.scala ## @@ -42,7 +42,18 @@ class

[GitHub] [kafka] rondagostino commented on a change in pull request #9032: KAFKA-10259: KIP-554 Broker-side SCRAM Config API

2020-08-31 Thread GitBox
rondagostino commented on a change in pull request #9032: URL: https://github.com/apache/kafka/pull/9032#discussion_r480324560 ## File path: core/src/test/scala/integration/kafka/server/DynamicBrokerReconfigurationTest.scala ## @@ -1047,8 +1047,8 @@ class

[jira] [Assigned] (KAFKA-9649) Remove/Warn on use of TimeWindowedSerde with no specified window size

2020-08-31 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9649?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias J. Sax reassigned KAFKA-9649: -- Assignee: Leah Thomas > Remove/Warn on use of TimeWindowedSerde with no specified

[jira] [Updated] (KAFKA-9649) Remove/Warn on use of TimeWindowedSerde with no specified window size

2020-08-31 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9649?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias J. Sax updated KAFKA-9649: --- Labels: kip (was: ) > Remove/Warn on use of TimeWindowedSerde with no specified window size

[GitHub] [kafka] rondagostino commented on a change in pull request #9032: KAFKA-10259: KIP-554 Broker-side SCRAM Config API

2020-08-31 Thread GitBox
rondagostino commented on a change in pull request #9032: URL: https://github.com/apache/kafka/pull/9032#discussion_r480301973 ## File path: core/src/test/scala/unit/kafka/admin/UserScramCredentialsCommandTest.scala ## @@ -0,0 +1,135 @@ +/** + * Licensed to the Apache

[GitHub] [kafka] rondagostino commented on a change in pull request #9032: KAFKA-10259: KIP-554 Broker-side SCRAM Config API

2020-08-31 Thread GitBox
rondagostino commented on a change in pull request #9032: URL: https://github.com/apache/kafka/pull/9032#discussion_r480282139 ## File path: core/src/test/scala/unit/kafka/utils/JaasTestUtils.scala ## @@ -169,6 +169,18 @@ object JaasTestUtils { jaasFile } + //

[GitHub] [kafka] ableegoldman commented on pull request #9039: KAFKA-5636: SlidingWindows (KIP-450)

2020-08-31 Thread GitBox
ableegoldman commented on pull request #9039: URL: https://github.com/apache/kafka/pull/9039#issuecomment-683917229 Retest this please This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [kafka] ableegoldman commented on pull request #9039: KAFKA-5636: SlidingWindows (KIP-450)

2020-08-31 Thread GitBox
ableegoldman commented on pull request #9039: URL: https://github.com/apache/kafka/pull/9039#issuecomment-683916587 test this please This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [kafka] rondagostino commented on a change in pull request #9032: KAFKA-10259: KIP-554 Broker-side SCRAM Config API

2020-08-31 Thread GitBox
rondagostino commented on a change in pull request #9032: URL: https://github.com/apache/kafka/pull/9032#discussion_r480272048 ## File path: tests/kafkatest/services/kafka/kafka.py ## @@ -575,10 +577,21 @@ def set_unclean_leader_election(self, topic, value=True, node=None):

[jira] [Created] (KAFKA-10451) system tests send large command over ssh instead of using remote file for security config

2020-08-31 Thread Ron Dagostino (Jira)
Ron Dagostino created KAFKA-10451: - Summary: system tests send large command over ssh instead of using remote file for security config Key: KAFKA-10451 URL: https://issues.apache.org/jira/browse/KAFKA-10451

[GitHub] [kafka] asdaraujo commented on pull request #8730: KAFKA-10048: Possible data gap for a consumer after a failover when u…

2020-08-31 Thread GitBox
asdaraujo commented on pull request #8730: URL: https://github.com/apache/kafka/pull/8730#issuecomment-683909598 @mimaison Thanks for the feedback. I've refactored the tests. Could you please give it another review. This is

[GitHub] [kafka] asdaraujo commented on a change in pull request #8730: KAFKA-10048: Possible data gap for a consumer after a failover when u…

2020-08-31 Thread GitBox
asdaraujo commented on a change in pull request #8730: URL: https://github.com/apache/kafka/pull/8730#discussion_r480267347 ## File path: connect/mirror/src/test/java/org/apache/kafka/connect/mirror/MirrorConnectorsIntegrationTest.java ## @@ -190,24 +211,19 @@ public void

[GitHub] [kafka] asdaraujo commented on a change in pull request #8730: KAFKA-10048: Possible data gap for a consumer after a failover when u…

2020-08-31 Thread GitBox
asdaraujo commented on a change in pull request #8730: URL: https://github.com/apache/kafka/pull/8730#discussion_r480267122 ## File path: connect/mirror/src/test/java/org/apache/kafka/connect/mirror/MirrorConnectorsIntegrationTest.java ## @@ -128,10 +136,23 @@ public void

[GitHub] [kafka] asdaraujo commented on a change in pull request #8730: KAFKA-10048: Possible data gap for a consumer after a failover when u…

2020-08-31 Thread GitBox
asdaraujo commented on a change in pull request #8730: URL: https://github.com/apache/kafka/pull/8730#discussion_r480266459 ## File path: connect/mirror/src/test/java/org/apache/kafka/connect/mirror/MirrorConnectorsIntegrationTest.java ## @@ -128,10 +136,23 @@ public void

[GitHub] [kafka] asdaraujo commented on a change in pull request #8730: KAFKA-10048: Possible data gap for a consumer after a failover when u…

2020-08-31 Thread GitBox
asdaraujo commented on a change in pull request #8730: URL: https://github.com/apache/kafka/pull/8730#discussion_r480265451 ## File path: connect/mirror/src/test/java/org/apache/kafka/connect/mirror/MirrorConnectorsIntegrationTest.java ## @@ -367,14 +406,37 @@ public void

[jira] [Updated] (KAFKA-10450) console-producer throws Uncaught error in kafka producer I/O thread:  (org.apache.kafka.clients.producer.internals.Sender) java.lang.IllegalStateException: There are no

2020-08-31 Thread Jigar Naik (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10450?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jigar Naik updated KAFKA-10450: --- Priority: Blocker (was: Critical) > console-producer throws Uncaught error in kafka producer I/O

[jira] [Updated] (KAFKA-10450) console-producer throws Uncaught error in kafka producer I/O thread:  (org.apache.kafka.clients.producer.internals.Sender) java.lang.IllegalStateException: There are no

2020-08-31 Thread Jigar Naik (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10450?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jigar Naik updated KAFKA-10450: --- Priority: Critical (was: Blocker) > console-producer throws Uncaught error in kafka producer I/O

[jira] [Updated] (KAFKA-10450) console-producer throws Uncaught error in kafka producer I/O thread:  (org.apache.kafka.clients.producer.internals.Sender) java.lang.IllegalStateException: There are no

2020-08-31 Thread Jigar Naik (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10450?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jigar Naik updated KAFKA-10450: --- Priority: Blocker (was: Major) > console-producer throws Uncaught error in kafka producer I/O

[jira] [Created] (KAFKA-10450) console-producer throws Uncaught error in kafka producer I/O thread:  (org.apache.kafka.clients.producer.internals.Sender) java.lang.IllegalStateException: There are no

2020-08-31 Thread Jigar Naik (Jira)
Jigar Naik created KAFKA-10450: -- Summary: console-producer throws Uncaught error in kafka producer I/O thread:  (org.apache.kafka.clients.producer.internals.Sender) java.lang.IllegalStateException: There are no in-flight requests for node -1

[jira] [Updated] (KAFKA-10448) Preserve Source Partition in Kafka Streams from context

2020-08-31 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10448?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias J. Sax updated KAFKA-10448: Labels: needs-kip (was: ) > Preserve Source Partition in Kafka Streams from context >

[GitHub] [kafka] chia7712 commented on pull request #8657: KAFKA-8334 Make sure the thread which tries to complete delayed reque…

2020-08-31 Thread GitBox
chia7712 commented on pull request #8657: URL: https://github.com/apache/kafka/pull/8657#issuecomment-683863356 > It seems that the average across multiple runs doesn't change much? yep. I didn't observe obvious regression caused by this patch. > Also, 1 failure in the latest

[jira] [Updated] (KAFKA-10448) Preserve Source Partition in Kafka Streams from context

2020-08-31 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10448?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias J. Sax updated KAFKA-10448: Priority: Minor (was: Critical) > Preserve Source Partition in Kafka Streams from

[GitHub] [kafka] junrao commented on pull request #8657: KAFKA-8334 Make sure the thread which tries to complete delayed reque…

2020-08-31 Thread GitBox
junrao commented on pull request #8657: URL: https://github.com/apache/kafka/pull/8657#issuecomment-683859366 @chia7712 : Thanks for the performance results. It seems that the average across multiple runs doesn't change much? Also, 1 failure in the latest system test run.

[GitHub] [kafka] lct45 commented on a change in pull request #9157: Update for KIP-450 to handle early records

2020-08-31 Thread GitBox
lct45 commented on a change in pull request #9157: URL: https://github.com/apache/kafka/pull/9157#discussion_r480194412 ## File path: streams/src/main/java/org/apache/kafka/streams/kstream/internals/KStreamSlidingWindowAggregate.java ## @@ -0,0 +1,386 @@ +/* + * Licensed to

[GitHub] [kafka] jeqo commented on pull request #9138: KAFKA-9929: Support backward iterator on WindowStore

2020-08-31 Thread GitBox
jeqo commented on pull request #9138: URL: https://github.com/apache/kafka/pull/9138#issuecomment-683830757 @ableegoldman key ordering is added to `InMemoryWindowStore` now This is an automated message from the Apache Git

[jira] [Comment Edited] (KAFKA-9649) Remove/Warn on use of TimeWindowedSerde with no specified window size

2020-08-31 Thread Jira
[ https://issues.apache.org/jira/browse/KAFKA-9649?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17187747#comment-17187747 ] Sören Henning edited comment on KAFKA-9649 at 8/31/20, 1:49 PM: Hi, sorry

[jira] [Commented] (KAFKA-9649) Remove/Warn on use of TimeWindowedSerde with no specified window size

2020-08-31 Thread Jira
[ https://issues.apache.org/jira/browse/KAFKA-9649?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17187747#comment-17187747 ] Sören Henning commented on KAFKA-9649: -- Hi, sorry for the late response, vacation came up... :) In

[GitHub] [kafka] rondagostino closed pull request #9233: Testing

2020-08-31 Thread GitBox
rondagostino closed pull request #9233: URL: https://github.com/apache/kafka/pull/9233 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [kafka] rondagostino opened a new pull request #9233: Testing

2020-08-31 Thread GitBox
rondagostino opened a new pull request #9233: URL: https://github.com/apache/kafka/pull/9233 *More detailed description of your change, if necessary. The PR title and PR message become the squashed commit message, so use a separate comment to ping reviewers.* *Summary of

[GitHub] [kafka] cadonna commented on pull request #9232: KAFKA-9924: Add remaining property-based RocksDB metrics as described in KIP-607

2020-08-31 Thread GitBox
cadonna commented on pull request #9232: URL: https://github.com/apache/kafka/pull/9232#issuecomment-683729711 Call for review: @guozhangwang @vvcephei This is an automated message from the Apache Git Service. To respond to

[GitHub] [kafka] cadonna opened a new pull request #9232: KAFKA-9924: Add remaining property-based RocksDB metrics as described in KIP-607

2020-08-31 Thread GitBox
cadonna opened a new pull request #9232: URL: https://github.com/apache/kafka/pull/9232 This commit adds the remaining property-based RocksDB metrics as described in KIP-607, except for num-entries-active-mem-table, which was added in PR #9177. ### Committer Checklist (excluded

[GitHub] [kafka] ijuma commented on a change in pull request #9231: KAFKA-10447: Migrate tools module to JUnit 5 and mockito

2020-08-31 Thread GitBox
ijuma commented on a change in pull request #9231: URL: https://github.com/apache/kafka/pull/9231#discussion_r480023644 ## File path: tools/src/test/java/org/apache/kafka/trogdor/coordinator/CoordinatorTest.java ## @@ -62,17 +62,18 @@ import java.util.List; import

[GitHub] [kafka] cadonna commented on pull request #9191: KAFKA-10355: Throw error when source topic was deleted

2020-08-31 Thread GitBox
cadonna commented on pull request #9191: URL: https://github.com/apache/kafka/pull/9191#issuecomment-683673488 This is the implementation for KIP-662. This is an automated message from the Apache Git Service. To respond to

[GitHub] [kafka] cadonna commented on pull request #9177: KAFKA-9924: Add RocksDB metric num-entries-active-mem-table

2020-08-31 Thread GitBox
cadonna commented on pull request #9177: URL: https://github.com/apache/kafka/pull/9177#issuecomment-683631452 @vvcephei Thank you very much for taking care of the conflicts and merging the PR! This is an automated message

[GitHub] [kafka] chia7712 commented on pull request #8657: KAFKA-8334 Make sure the thread which tries to complete delayed reque…

2020-08-31 Thread GitBox
chia7712 commented on pull request #8657: URL: https://github.com/apache/kafka/pull/8657#issuecomment-683602732 @junrao the result of ```benchmark_test.py``` is attached (see description) The main regression ({"records_per_sec": 3653635.3672, "mb_per_sec": 348.4378} ->

[jira] [Commented] (KAFKA-10134) High CPU issue during rebalance in Kafka consumer after upgrading to 2.5

2020-08-31 Thread Jerry Wei (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10134?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17187480#comment-17187480 ] Jerry Wei commented on KAFKA-10134: --- [~guozhang] I've tested against PR #8834, it works fine for our