[GitHub] [kafka] vvcephei commented on a change in pull request #8541: KAFKA-6145: KIP-441: Add TaskAssignor class config

vvcephei commented on a change in pull request #8541: URL: https://github.com/apache/kafka/pull/8541#discussion_r414654696 ## File path: streams/src/test/java/org/apache/kafka/streams/integration/EosIntegrationTest.java ## @@ -111,8 +115,9 @@ private final String

[GitHub] [kafka] vvcephei commented on a change in pull request #8541: KAFKA-6145: KIP-441: Add TaskAssignor class config

vvcephei commented on a change in pull request #8541: URL: https://github.com/apache/kafka/pull/8541#discussion_r414655837 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/assignment/AssignorConfiguration.java ## @@ -41,8 +42,8 @@ import

[GitHub] [kafka] hachikuji commented on pull request #8509: KAFKA-9839: Broker should accept control requests with newer broker epoch

hachikuji commented on pull request #8509: URL: https://github.com/apache/kafka/pull/8509#issuecomment-619100794 retest this please This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [kafka] hachikuji commented on pull request #8509: KAFKA-9839: Broker should accept control requests with newer broker epoch

hachikuji commented on pull request #8509: URL: https://github.com/apache/kafka/pull/8509#issuecomment-619100923 ok to test This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [kafka] junrao commented on pull request #8543: [KAFKA-9826] Handle an unaligned first dirty offset during log cleani…

junrao commented on pull request #8543: URL: https://github.com/apache/kafka/pull/8543#issuecomment-619129858 @steverod : There seems to be compilation errors in JDK 8 test? This is an automated message from the Apache Git

[GitHub] [kafka] ijuma commented on pull request #8545: MINOR: smoke test for jmh benchmark functionality

ijuma commented on pull request #8545: URL: https://github.com/apache/kafka/pull/8545#issuecomment-619055845 ok to test This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [kafka] chia7712 commented on pull request #8543: [KAFKA-9826] Handle an unaligned first dirty offset during log cleani…

chia7712 commented on pull request #8543: URL: https://github.com/apache/kafka/pull/8543#issuecomment-619070458 is this duplicate to #8542? This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [kafka] junrao commented on a change in pull request #8103: KAFKA-7061: KIP-280 Enhanced log compaction

junrao commented on a change in pull request #8103: URL: https://github.com/apache/kafka/pull/8103#discussion_r414175405 ## File path: core/src/main/scala/kafka/log/OffsetMap.scala ## @@ -20,28 +20,80 @@ package kafka.log import java.util.Arrays import

[GitHub] [kafka] vvcephei commented on a change in pull request #8541: KAFKA-6145: KIP-441: Add TaskAssignor class config

vvcephei commented on a change in pull request #8541: URL: https://github.com/apache/kafka/pull/8541#discussion_r414651483 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamsPartitionAssignor.java ## @@ -713,23 +713,18 @@ private boolean

[GitHub] [kafka] vvcephei commented on a change in pull request #8541: KAFKA-6145: KIP-441: Add TaskAssignor class config

vvcephei commented on a change in pull request #8541: URL: https://github.com/apache/kafka/pull/8541#discussion_r414662116 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/assignment/AssignorConfiguration.java ## @@ -41,8 +42,8 @@ import

[GitHub] [kafka] mjsax commented on a change in pull request #8532: HOTFIX: Fix broker bounce system tests

mjsax commented on a change in pull request #8532: URL: https://github.com/apache/kafka/pull/8532#discussion_r414679179 ## File path: tests/kafkatest/tests/streams/streams_broker_bounce_test.py ## @@ -164,7 +164,7 @@ def setup_system(self, start_processor=True, num_threads=3):

[GitHub] [kafka] vvcephei commented on a change in pull request #8541: KAFKA-6145: KIP-441: Add TaskAssignor class config

vvcephei commented on a change in pull request #8541: URL: https://github.com/apache/kafka/pull/8541#discussion_r414653962 ## File path: build.gradle ## @@ -236,8 +236,10 @@ subprojects { def logStreams = new HashMap() beforeTest { TestDescriptor td -> def tid

[GitHub] [kafka] cadonna commented on pull request #8529: KAFKA-9901:Fix streams_broker_bounce_test error

cadonna commented on pull request #8529: URL: https://github.com/apache/kafka/pull/8529#issuecomment-619080823 In order to avoid duplicate work, I just want to let you know that I also have a PR that fixes this issue the same way https://github.com/apache/kafka/pull/8532. I have already

[GitHub] [kafka] vvcephei commented on a change in pull request #8504: KAFKA-9298: reuse mapped stream error in joins

vvcephei commented on a change in pull request #8504: URL: https://github.com/apache/kafka/pull/8504#discussion_r414731001 ## File path: streams/src/main/java/org/apache/kafka/streams/kstream/internals/KStreamImpl.java ## @@ -989,16 +994,18 @@ private void to(final

[GitHub] [kafka] cadonna commented on pull request #8529: KAFKA-9901:Fix streams_broker_bounce_test error

cadonna commented on pull request #8529: URL: https://github.com/apache/kafka/pull/8529#issuecomment-619140731 @jiameixie My PR was merged. This is an automated message from the Apache Git Service. To respond to the

[GitHub] [kafka] junrao commented on a change in pull request #8524: KAFKA-9866: Avoid election for topics where preferred leader is not in ISR

junrao commented on a change in pull request #8524: URL: https://github.com/apache/kafka/pull/8524#discussion_r414740034 ## File path: core/src/main/scala/kafka/controller/KafkaController.scala ## @@ -1068,12 +1068,23 @@ class KafkaController(val config: KafkaConfig,

[GitHub] [kafka] ableegoldman commented on pull request #8541: KAFKA-6145: KIP-441: Add TaskAssignor class config

ableegoldman commented on pull request #8541: URL: https://github.com/apache/kafka/pull/8541#issuecomment-619148319 > 29 system tests failed Expected, but still upsetting  This is an automated message from the

[GitHub] [kafka] junrao commented on pull request #8543: [KAFKA-9826] Handle an unaligned first dirty offset during log cleani…

junrao commented on pull request #8543: URL: https://github.com/apache/kafka/pull/8543#issuecomment-619128544 @chia7712 : It's the same patch, but for a different branch. This is an automated message from the Apache Git

[GitHub] [kafka] mjsax commented on a change in pull request #8483: KAFKA-9865: Expose output topic names from TopologyTestDriver

mjsax commented on a change in pull request #8483: URL: https://github.com/apache/kafka/pull/8483#discussion_r414732356 ## File path: streams/test-utils/src/main/java/org/apache/kafka/streams/TopologyTestDriver.java ## @@ -855,6 +856,20 @@ public void

[GitHub] [kafka] abbccdda commented on a change in pull request #8532: HOTFIX: Fix broker bounce system tests

abbccdda commented on a change in pull request #8532: URL: https://github.com/apache/kafka/pull/8532#discussion_r414636938 ## File path: tests/kafkatest/tests/streams/streams_broker_bounce_test.py ## @@ -164,7 +164,7 @@ def setup_system(self, start_processor=True,

[GitHub] [kafka] junrao commented on pull request #8542: [KAFKA-9826] Handle an unaligned first dirty offset during log cleani…

junrao commented on pull request #8542: URL: https://github.com/apache/kafka/pull/8542#issuecomment-619127117 ok to test This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [kafka] hachikuji commented on pull request #8525: KAFKA-9885; Evict last members of a group when the maximum allowed is reached

hachikuji commented on pull request #8525: URL: https://github.com/apache/kafka/pull/8525#issuecomment-619142257 ok to test This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [kafka] zhaohaidao commented on a change in pull request #8550: KAFKA-9850 Move KStream#repartition operator validation during Topolo…

zhaohaidao commented on a change in pull request #8550: URL: https://github.com/apache/kafka/pull/8550#discussion_r415334757 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/InternalTopologyBuilder.java ## @@ -633,6 +634,45 @@ public final void

[GitHub] [kafka] big-andy-coates commented on pull request #8483: KAFKA-9865: Expose output topic names from TopologyTestDriver

big-andy-coates commented on pull request #8483: URL: https://github.com/apache/kafka/pull/8483#issuecomment-619531323 @mjsax updated. This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [kafka] zhaohaidao commented on a change in pull request #8550: KAFKA-9850 Move KStream#repartition operator validation during Topolo…

zhaohaidao commented on a change in pull request #8550: URL: https://github.com/apache/kafka/pull/8550#discussion_r415335411 ## File path: streams/src/main/java/org/apache/kafka/streams/kstream/internals/InternalStreamsBuilder.java ## @@ -312,6 +312,7 @@ public void

[GitHub] [kafka] hachikuji commented on a change in pull request #8525: KAFKA-9885; Evict last members of a group when the maximum allowed is reached

hachikuji commented on a change in pull request #8525: URL: https://github.com/apache/kafka/pull/8525#discussion_r414737521 ## File path: core/src/main/scala/kafka/coordinator/group/GroupCoordinator.scala ## @@ -124,6 +124,35 @@ class GroupCoordinator(val brokerId: Int,

[GitHub] [kafka] ableegoldman commented on a change in pull request #8540: KAFKA-9127: don't create StreamThreads for global-only topology

ableegoldman commented on a change in pull request #8540: URL: https://github.com/apache/kafka/pull/8540#discussion_r414822406 ## File path: streams/src/main/java/org/apache/kafka/streams/KafkaStreams.java ## @@ -701,18 +703,33 @@ private KafkaStreams(final

[GitHub] [kafka] steverod commented on pull request #8543: [KAFKA-9826] Handle an unaligned first dirty offset during log cleani…

steverod commented on pull request #8543: URL: https://github.com/apache/kafka/pull/8543#issuecomment-619214390 > is this duplicate to #8542? Yes, this is aimed at 2.4 rather than 2.5. Took a best guess for propagation.

[GitHub] [kafka] vvcephei commented on a change in pull request #8504: KAFKA-9298: reuse mapped stream error in joins

vvcephei commented on a change in pull request #8504: URL: https://github.com/apache/kafka/pull/8504#discussion_r414731001 ## File path: streams/src/main/java/org/apache/kafka/streams/kstream/internals/KStreamImpl.java ## @@ -989,16 +994,18 @@ private void to(final

[GitHub] [kafka] vvcephei commented on pull request #8254: KIP-557: Add Emit On Change Support

vvcephei commented on pull request #8254: URL: https://github.com/apache/kafka/pull/8254#issuecomment-619195143 FYI, a recent change is that only committers can kick off the tests. It's mighty inconvenient, but better for security.

[GitHub] [kafka] vvcephei commented on pull request #8254: KIP-557: Add Emit On Change Support

vvcephei commented on pull request #8254: URL: https://github.com/apache/kafka/pull/8254#issuecomment-619194786 retest this please This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [kafka] ConcurrencyPractitioner commented on pull request #8254: KIP-557: Add Emit On Change Support

ConcurrencyPractitioner commented on pull request #8254: URL: https://github.com/apache/kafka/pull/8254#issuecomment-619213065 @vvcephei Can you retrigger tests? This is an automated message from the Apache Git Service. To

[GitHub] [kafka] ConcurrencyPractitioner commented on pull request #8254: KIP-557: Add Emit On Change Support

ConcurrencyPractitioner commented on pull request #8254: URL: https://github.com/apache/kafka/pull/8254#issuecomment-619212877 @vvcephei Oh yeah, I was aware of that. Just recently though, I was added to the jenkins whitelist (my handle is listed in .asf.yaml). Supposedly, I will be able

[GitHub] [kafka] vvcephei commented on pull request #8541: KAFKA-6145: KIP-441: Add TaskAssignor class config

vvcephei commented on pull request #8541: URL: https://github.com/apache/kafka/pull/8541#issuecomment-619162446 > > 29 system tests failed > > Expected, but still upsetting scream_cat I should have said "130 system tests passed"

[GitHub] [kafka] ableegoldman commented on a change in pull request #8540: KAFKA-9127: don't create StreamThreads for global-only topology

ableegoldman commented on a change in pull request #8540: URL: https://github.com/apache/kafka/pull/8540#discussion_r414819765 ## File path: streams/src/test/java/org/apache/kafka/streams/KafkaStreamsTest.java ## @@ -883,6 +887,50 @@ public void

[GitHub] [kafka] ableegoldman commented on a change in pull request #8540: KAFKA-9127: don't create StreamThreads for global-only topology

ableegoldman commented on a change in pull request #8540: URL: https://github.com/apache/kafka/pull/8540#discussion_r414825387 ## File path: streams/src/test/java/org/apache/kafka/streams/KafkaStreamsTest.java ## @@ -883,6 +887,50 @@ public void

[GitHub] [kafka] ableegoldman commented on a change in pull request #8540: KAFKA-9127: don't create StreamThreads for global-only topology

ableegoldman commented on a change in pull request #8540: URL: https://github.com/apache/kafka/pull/8540#discussion_r414832679 ## File path: streams/src/test/java/org/apache/kafka/streams/KafkaStreamsTest.java ## @@ -327,15 +331,15 @@ private void prepareStreamThread(final

[GitHub] [kafka] d8tltanc commented on a change in pull request #8527: Remove dependencies on deprecated --zookeeper command flags in junit tests

d8tltanc commented on a change in pull request #8527: URL: https://github.com/apache/kafka/pull/8527#discussion_r414844095 ## File path: core/src/test/scala/integration/kafka/server/DynamicBrokerReconfigurationTest.scala ## @@ -1408,13 +1408,23 @@ class

[GitHub] [kafka] guozhangwang commented on pull request #8535: KAFKA-9903

guozhangwang commented on pull request #8535: URL: https://github.com/apache/kafka/pull/8535#issuecomment-619168284 test this please This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [kafka] vvcephei commented on pull request #8254: KIP-557: Add Emit On Change Support

vvcephei commented on pull request #8254: URL: https://github.com/apache/kafka/pull/8254#issuecomment-619194659 test this please This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [kafka] ableegoldman commented on a change in pull request #8540: KAFKA-9127: don't create StreamThreads for global-only topology

ableegoldman commented on a change in pull request #8540: URL: https://github.com/apache/kafka/pull/8540#discussion_r414823010 ## File path: streams/src/test/java/org/apache/kafka/streams/KafkaStreamsTest.java ## @@ -327,15 +331,15 @@ private void prepareStreamThread(final

[GitHub] [kafka] ableegoldman commented on a change in pull request #8540: KAFKA-9127: don't create StreamThreads for global-only topology

ableegoldman commented on a change in pull request #8540: URL: https://github.com/apache/kafka/pull/8540#discussion_r414822929 ## File path: streams/src/main/java/org/apache/kafka/streams/KafkaStreams.java ## @@ -701,18 +703,33 @@ private KafkaStreams(final

[GitHub] [kafka] junrao commented on pull request #8542: [KAFKA-9826] Handle an unaligned first dirty offset during log cleani…

junrao commented on pull request #8542: URL: https://github.com/apache/kafka/pull/8542#issuecomment-619216927 retest this please This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [kafka] lbradstreet commented on a change in pull request #8517: MINOR: use monotonic clock for replica fetcher DelayedItem

lbradstreet commented on a change in pull request #8517: URL: https://github.com/apache/kafka/pull/8517#discussion_r413086046 ## File path: core/src/main/scala/kafka/utils/DelayedItem.scala ## @@ -21,24 +21,19 @@ import java.util.concurrent._ import

[GitHub] [kafka] belugabehr opened a new pull request #8531: KAFAKA-9904: Use ThreadLocalConcurrent to Replace Random

belugabehr opened a new pull request #8531: URL: https://github.com/apache/kafka/pull/8531 ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation - [ ] Verify test coverage and CI build status - [ ] Verify documentation (including

[GitHub] [kafka] cadonna opened a new pull request #8532: HOTFIX: Fix broker bounce system tests

cadonna opened a new pull request #8532: URL: https://github.com/apache/kafka/pull/8532 ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation - [ ] Verify test coverage and CI build status - [ ] Verify documentation (including upgrade

[GitHub] [kafka] cadonna commented on issue #8532: HOTFIX: Fix broker bounce system tests

cadonna commented on issue #8532: URL: https://github.com/apache/kafka/pull/8532#issuecomment-617883911 Streams system tests run: https://jenkins.confluent.io/job/system-test-kafka-branch-builder/3914 This is an automated

[GitHub] [kafka] leonardge opened a new pull request #8533: Fixed bug in log validator tests.

leonardge opened a new pull request #8533: URL: https://github.com/apache/kafka/pull/8533 *More detailed description of your change, if necessary. The PR title and PR message become the squashed commit message, so use a separate comment to ping reviewers.* *Summary of

[GitHub] [kafka] ijuma commented on a change in pull request #8517: MINOR: use monotonic clock for replica fetcher DelayedItem

ijuma commented on a change in pull request #8517: URL: https://github.com/apache/kafka/pull/8517#discussion_r413077069 ## File path: core/src/main/scala/kafka/utils/DelayedItem.scala ## @@ -21,24 +21,19 @@ import java.util.concurrent._ import

[GitHub] [kafka] lbradstreet commented on a change in pull request #8517: MINOR: use monotonic clock for replica fetcher DelayedItem

lbradstreet commented on a change in pull request #8517: URL: https://github.com/apache/kafka/pull/8517#discussion_r413085641 ## File path: core/src/main/scala/kafka/utils/DelayedItem.scala ## @@ -21,24 +21,19 @@ import java.util.concurrent._ import

[GitHub] [kafka] hachikuji commented on a change in pull request #8509: KAFKA-9839: Broker should accept control requests with newer broker epoch

hachikuji commented on a change in pull request #8509: URL: https://github.com/apache/kafka/pull/8509#discussion_r413091037 ## File path: core/src/main/scala/kafka/server/KafkaApis.scala ## @@ -3084,12 +3084,7 @@ class KafkaApis(val requestChannel: RequestChannel, //

[GitHub] [kafka] dajac commented on issue #8454: KAFKA-9844; Maximum number of members within a group is not always enforced due to a race condition in join group

dajac commented on issue #8454: URL: https://github.com/apache/kafka/pull/8454#issuecomment-617907578 @hachikuji Could we get this one merged? This is an automated message from the Apache Git Service. To respond to the

[GitHub] [kafka] cadonna commented on a change in pull request #8532: HOTFIX: Fix broker bounce system tests

cadonna commented on a change in pull request #8532: URL: https://github.com/apache/kafka/pull/8532#discussion_r413110487 ## File path: tests/kafkatest/tests/streams/streams_broker_bounce_test.py ## @@ -164,7 +164,7 @@ def setup_system(self, start_processor=True,

[GitHub] [kafka] cadonna commented on issue #8532: HOTFIX: Fix broker bounce system tests

cadonna commented on issue #8532: URL: https://github.com/apache/kafka/pull/8532#issuecomment-617869532 Call for review: @mjsax @abbccdda This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [kafka] cadonna commented on a change in pull request #8532: HOTFIX: Fix broker bounce system tests

cadonna commented on a change in pull request #8532: URL: https://github.com/apache/kafka/pull/8532#discussion_r413116285 ## File path: tests/kafkatest/tests/streams/streams_broker_bounce_test.py ## @@ -164,7 +164,7 @@ def setup_system(self, start_processor=True,

[GitHub] [kafka] vvcephei commented on issue #8520: Add explicit grace period to tumbling window example

vvcephei commented on issue #8520: URL: https://github.com/apache/kafka/pull/8520#issuecomment-617376010 Gah, I forgot to add the reviewers to the merge commit. This is an automated message from the Apache Git Service. To

[GitHub] [kafka] vvcephei commented on a change in pull request #8497: KAFKA-6145: KIP-441 Build state constrained assignment from balanced one

vvcephei commented on a change in pull request #8497: URL: https://github.com/apache/kafka/pull/8497#discussion_r412422082 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/assignment/TaskMovement.java ## @@ -16,128 +16,103 @@ */ package

[GitHub] [kafka] vvcephei commented on issue #8254: KIP-557: Add Emit On Change Support

vvcephei commented on issue #8254: URL: https://github.com/apache/kafka/pull/8254#issuecomment-617392150 I also took a look at the foreign-key join test, which is actually telling us something awesome: your feature allows us to drop _unnecessary_ tombstones that we'd otherwise send under

[GitHub] [kafka] vvcephei commented on issue #8254: KIP-557: Add Emit On Change Support

vvcephei commented on issue #8254: URL: https://github.com/apache/kafka/pull/8254#issuecomment-617423139 Ok, last one. The TransformValuesTest is just another case where the test input data is now considered idempotent, which is fine: ```diff ---

[GitHub] [kafka] vvcephei commented on issue #8497: KAFKA-6145: KIP-441 Build state constrained assignment from balanced one

vvcephei commented on issue #8497: URL: https://github.com/apache/kafka/pull/8497#issuecomment-617439325 Unrelated java 11 failures: kafka.api.ConsumerBounceTest.testRollingBrokerRestartsWithSmallerMaxGroupSizeConfigDisruptsBigGroup

[GitHub] [kafka] vvcephei commented on issue #8497: KAFKA-6145: KIP-441 Build state constrained assignment from balanced one

vvcephei commented on issue #8497: URL: https://github.com/apache/kafka/pull/8497#issuecomment-617364180 test this please This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [kafka] vvcephei commented on issue #8497: KAFKA-6145: KIP-441 Build state constrained assignment from balanced one

vvcephei commented on issue #8497: URL: https://github.com/apache/kafka/pull/8497#issuecomment-617364803 test this please This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [kafka] vvcephei commented on issue #8254: KIP-557: Add Emit On Change Support

vvcephei commented on issue #8254: URL: https://github.com/apache/kafka/pull/8254#issuecomment-617423885 I hope I didn't step on your toes, @ConcurrencyPractitioner , but I just wanted to make sure that you're unblocked to finish up this PR. Figuring out what's exactly wrong with those

[GitHub] [kafka] surabhidixit opened a new pull request #8526: KAFKA-6867: corrected the typos in upgrade.html

surabhidixit opened a new pull request #8526: URL: https://github.com/apache/kafka/pull/8526 *More detailed description of your change, if necessary. The PR title and PR message become the squashed commit message, so use a separate comment to ping reviewers.* *Summary of

[GitHub] [kafka] vvcephei commented on issue #8254: KIP-557: Add Emit On Change Support

vvcephei commented on issue #8254: URL: https://github.com/apache/kafka/pull/8254#issuecomment-617418517 The source topic restart integration test was actually just failing because the tests were polluting each others' topics. This is one way to fix it: ```diff diff --git

[GitHub] [kafka] vvcephei commented on a change in pull request #8497: KAFKA-6145: KIP-441 Build state constrained assignment from balanced one

vvcephei commented on a change in pull request #8497: URL: https://github.com/apache/kafka/pull/8497#discussion_r412423011 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/assignment/ValidClientsByTaskLoadQueue.java ## @@ -0,0 +1,110 @@ +/* + *

[GitHub] [kafka] vvcephei commented on a change in pull request #8497: KAFKA-6145: KIP-441 Build state constrained assignment from balanced one

vvcephei commented on a change in pull request #8497: URL: https://github.com/apache/kafka/pull/8497#discussion_r412419973 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/assignment/TaskMovement.java ## @@ -16,128 +16,94 @@ */ package

[GitHub] [kafka] vvcephei commented on issue #8254: KIP-557: Add Emit On Change Support

vvcephei commented on issue #8254: URL: https://github.com/apache/kafka/pull/8254#issuecomment-617372772 Hey @ConcurrencyPractitioner , sorry it took so long. It's just again because the test happened to expect idempotent updates to flow through regularly, but not for anything important.

[GitHub] [kafka] abbccdda commented on a change in pull request #8486: KAFKA-9840: Skip End Offset validation when the leader epoch is not reliable

abbccdda commented on a change in pull request #8486: URL: https://github.com/apache/kafka/pull/8486#discussion_r413442881 ## File path: clients/src/main/java/org/apache/kafka/clients/consumer/internals/Fetcher.java ## @@ -498,6 +498,104 @@ public void

[GitHub] [kafka] jiameixie commented on issue #8529: KAFKA-9901:Fix streams_broker_bounce_test error

jiameixie commented on issue #8529: URL: https://github.com/apache/kafka/pull/8529#issuecomment-618169833 @guozhangwang @ijuma @junrao PTAL, thanks This is an automated message from the Apache Git Service. To respond to the

[GitHub] [kafka] junrao commented on a change in pull request #8524: KAFKA-9866: Avoid election for topics where preferred leader is not in ISR

junrao commented on a change in pull request #8524: URL: https://github.com/apache/kafka/pull/8524#discussion_r413436495 ## File path: core/src/main/scala/kafka/controller/KafkaController.scala ## @@ -1068,7 +1068,9 @@ class KafkaController(val config: KafkaConfig,

[GitHub] [kafka] hachikuji commented on issue #8509: KAFKA-9839: Broker should accept control requests with newer broker epoch

hachikuji commented on issue #8509: URL: https://github.com/apache/kafka/pull/8509#issuecomment-618070328 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [kafka] hachikuji commented on issue #8509: KAFKA-9839: Broker should accept control requests with newer broker epoch

hachikuji commented on issue #8509: URL: https://github.com/apache/kafka/pull/8509#issuecomment-618070266 ok to test This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [kafka] guozhangwang commented on a change in pull request #8326: KAFKA-8639: Replace AddPartitionsToTxn with Automated Protocol

guozhangwang commented on a change in pull request #8326: URL: https://github.com/apache/kafka/pull/8326#discussion_r413374355 ## File path: clients/src/main/java/org/apache/kafka/common/requests/AddPartitionsToTxnRequest.java ## @@ -17,157 +17,109 @@ package

[GitHub] [kafka] abbccdda commented on a change in pull request #8326: KAFKA-8639: Replace AddPartitionsToTxn with Automated Protocol

abbccdda commented on a change in pull request #8326: URL: https://github.com/apache/kafka/pull/8326#discussion_r413471840 ## File path: clients/src/main/java/org/apache/kafka/common/requests/AddPartitionsToTxnRequest.java ## @@ -17,157 +17,109 @@ package

[GitHub] [kafka] hachikuji commented on issue #8509: KAFKA-9839: Broker should accept control requests with newer broker epoch

hachikuji commented on issue #8509: URL: https://github.com/apache/kafka/pull/8509#issuecomment-618147106 retest this please This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [kafka] ableegoldman commented on a change in pull request #8248: KAFKA-9501: convert between active and standby without closing stores

ableegoldman commented on a change in pull request #8248: URL: https://github.com/apache/kafka/pull/8248#discussion_r391363596 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/ActiveTaskCreator.java ## @@ -132,47 +130,74 @@ private static

[GitHub] [kafka] chia7712 commented on issue #5935: KAFKA-7665: Replace BaseConsumerRecord with ConsumerRecord in MM

chia7712 commented on issue #5935: URL: https://github.com/apache/kafka/pull/5935#issuecomment-618162318 @huxihx Are you still working on this? I'd like to complete both of KIP and this PR :) This is an automated message

[GitHub] [kafka] mjsax commented on a change in pull request #8504: KAFKA-9298: reuse mapped stream error in joins

mjsax commented on a change in pull request #8504: URL: https://github.com/apache/kafka/pull/8504#discussion_r413380852 ## File path: streams/src/main/java/org/apache/kafka/streams/kstream/internals/KStreamImpl.java ## @@ -989,16 +994,18 @@ private void to(final

[GitHub] [kafka] C0urante commented on a change in pull request #8069: KAFKA-9374: Make connector interactions asynchronous

C0urante commented on a change in pull request #8069: URL: https://github.com/apache/kafka/pull/8069#discussion_r413499718 ## File path: connect/runtime/src/main/java/org/apache/kafka/connect/runtime/Worker.java ## @@ -263,17 +267,20 @@ public boolean startConnector(

[GitHub] [kafka] jiameixie commented on issue #8446: KAFKA-9804:Extract consumer configs out of PerfConfig

jiameixie commented on issue #8446: URL: https://github.com/apache/kafka/pull/8446#issuecomment-618169937 @guozhangwang @ijuma @junrao PTAL, thanks This is an automated message from the Apache Git Service. To respond to the

[GitHub] [kafka] mjsax commented on issue #8504: KAFKA-9298: reuse mapped stream error in joins

mjsax commented on issue #8504: URL: https://github.com/apache/kafka/pull/8504#issuecomment-618073161 > Ideally, the fix should be to generate a repartition topic name each time to avoid such issues. But IMHO that ship has already sailed because by introducing a new name generation will

[GitHub] [kafka] guozhangwang commented on issue #8534: KAFKA-9512: Backport Flaky Test LagFetchIntegrationTest.shouldFetchLagsDuringRestoration

guozhangwang commented on issue #8534: URL: https://github.com/apache/kafka/pull/8534#issuecomment-618104185 Thanks @vinothchandar !! This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [kafka] guozhangwang commented on a change in pull request #8486: KAFKA-9840: Skip End Offset validation when the leader epoch is not reliable

guozhangwang commented on a change in pull request #8486: URL: https://github.com/apache/kafka/pull/8486#discussion_r413417021 ## File path: clients/src/main/java/org/apache/kafka/clients/consumer/internals/Fetcher.java ## @@ -498,6 +498,104 @@ public void

[GitHub] [kafka] jiameixie commented on issue #8489: KAFKA-9857:Failed to build image ducker-ak-openjdk-8 on arm

jiameixie commented on issue #8489: URL: https://github.com/apache/kafka/pull/8489#issuecomment-618132157 @guozhangwang @ijuma @junrao PTAL, thanks This is an automated message from the Apache Git Service. To respond to the

[GitHub] [kafka] abbccdda commented on a change in pull request #8326: KAFKA-8639: Replace AddPartitionsToTxn with Automated Protocol

abbccdda commented on a change in pull request #8326: URL: https://github.com/apache/kafka/pull/8326#discussion_r413473580 ## File path: core/src/test/scala/unit/kafka/server/AddPartitionsToTxnRequestServerTest.scala ## @@ -27,9 +27,9 @@ import org.junit.{Before, Test}

[GitHub] [kafka] vinothchandar commented on a change in pull request #8462: KAFKA-9846: Filter active tasks for running state in KafkaStreams#allLocalStorePartitionLags()

vinothchandar commented on a change in pull request #8462: URL: https://github.com/apache/kafka/pull/8462#discussion_r412690139 ## File path: streams/src/test/java/org/apache/kafka/streams/integration/LagFetchIntegrationTest.java ## @@ -295,9 +295,10 @@ public void

[GitHub] [kafka] dajac commented on a change in pull request #8311: KAFKA-9434: automated protocol for alterReplicaLogDirs

dajac commented on a change in pull request #8311: URL: https://github.com/apache/kafka/pull/8311#discussion_r412287554 ## File path: clients/src/main/java/org/apache/kafka/clients/admin/KafkaAdminClient.java ## @@ -2207,21 +2212,33 @@ public AlterReplicaLogDirsResult

[GitHub] [kafka] dajac commented on a change in pull request #8509: KAFKA-9839: Broker should accept control requests with newer broker epoch

dajac commented on a change in pull request #8509: URL: https://github.com/apache/kafka/pull/8509#discussion_r412807377 ## File path: core/src/test/scala/unit/kafka/server/KafkaApisTest.scala ## @@ -1553,6 +1552,179 @@ class KafkaApisTest {

[GitHub] [kafka] iceChen8123 commented on issue #233: KAFKA-2419; Garbage collect unused sensors

iceChen8123 commented on issue #233: URL: https://github.com/apache/kafka/pull/233#issuecomment-617512892 Execuse me. Is this bug fix now? I just see a ExpireSensorTask in Metrics, but nowhere can use. Then I see beyond 800,000 sensors existed in my application, and it is in Old

[GitHub] [kafka] tombentley commented on a change in pull request #8417: KAFKA-8955: Add an AbstractResponse#errorCounts(Stream) and tidy

tombentley commented on a change in pull request #8417: URL: https://github.com/apache/kafka/pull/8417#discussion_r412754269 ## File path: clients/src/main/java/org/apache/kafka/common/requests/AbstractResponse.java ## @@ -57,6 +59,10 @@ public ByteBuffer serialize(ApiKeys

[GitHub] [kafka] zshuo commented on issue #8224: KAFKA-9704: Fix the issue z/OS won't let us resize file when mmap.

zshuo commented on issue #8224: URL: https://github.com/apache/kafka/pull/8224#issuecomment-618311862 ok to test This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [kafka] cmccabe commented on a change in pull request #8527: Remove dependencies on deprecated --zookeeper command flags in junit tests

cmccabe commented on a change in pull request #8527: URL: https://github.com/apache/kafka/pull/8527#discussion_r413720950 ## File path: core/src/test/scala/unit/kafka/admin/TopicCommandWithAdminClientTest.scala ## @@ -293,13 +293,6 @@ class TopicCommandWithAdminClientTest

[GitHub] [kafka] mimaison commented on issue #8224: KAFKA-9704: Fix the issue z/OS won't let us resize file when mmap.

mimaison commented on issue #8224: URL: https://github.com/apache/kafka/pull/8224#issuecomment-618329701 ok to test This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [kafka] cmccabe commented on issue #8527: Remove dependencies on deprecated --zookeeper command flags in junit tests

cmccabe commented on issue #8527: URL: https://github.com/apache/kafka/pull/8527#issuecomment-618337731 ok to test This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [kafka] C0urante commented on issue #8069: KAFKA-9374: Make connector interactions asynchronous

C0urante commented on issue #8069: URL: https://github.com/apache/kafka/pull/8069#issuecomment-618097440 @ncliang I've made some updates to the PR and rebased on the latest trunk; would you be willing to do another pass?

[GitHub] [kafka] abbccdda commented on a change in pull request #8486: KAFKA-9840: Skip End Offset validation when the leader epoch is not reliable

abbccdda commented on a change in pull request #8486: URL: https://github.com/apache/kafka/pull/8486#discussion_r413468323 ## File path: clients/src/main/java/org/apache/kafka/clients/consumer/internals/OffsetsForLeaderEpochClient.java ## @@ -85,10 +85,6 @@ protected

[GitHub] [kafka] ijuma commented on issue #8533: KAFKA-9589: Fixed bug in V2 log validator tests

ijuma commented on issue #8533: URL: https://github.com/apache/kafka/pull/8533#issuecomment-618192475 ok to test This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [kafka] mimaison commented on a change in pull request #8238: KAFKA-9130: KIP-518 Allow listing consumer groups per state

mimaison commented on a change in pull request #8238: URL: https://github.com/apache/kafka/pull/8238#discussion_r413717848 ## File path: core/src/test/scala/unit/kafka/server/KafkaApisTest.scala ## @@ -1553,6 +1554,50 @@ class KafkaApisTest {

[GitHub] [kafka] cmccabe commented on a change in pull request #8527: Remove dependencies on deprecated --zookeeper command flags in junit tests

cmccabe commented on a change in pull request #8527: URL: https://github.com/apache/kafka/pull/8527#discussion_r413719892 ## File path: core/src/test/scala/unit/kafka/admin/ReassignPartitionsCommandArgsTest.scala ## @@ -255,7 +225,7 @@ class ReassignPartitionsCommandArgsTest

<    1   2   3   4   5   6   7   8   9   10   >