ijuma commented on issue #8537:
URL: https://github.com/apache/kafka/pull/8537#issuecomment-618412385
Thanks, I addressed the comment and I merged to trunk.
This is an automated message from the Apache Git Service.
To
bbejeck commented on a change in pull request #8504:
URL: https://github.com/apache/kafka/pull/8504#discussion_r413860696
##
File path:
streams/src/main/java/org/apache/kafka/streams/kstream/internals/KStreamImpl.java
##
@@ -989,16 +994,18 @@ private void to(final
bbejeck commented on issue #8504:
URL: https://github.com/apache/kafka/pull/8504#issuecomment-618447861
>Why that? Because such a topology would hit the bug, it could never be
deployed, and thus nobody can actually run such a topology? In fact, shouldn't
be "burn" and index even if a name
efeg commented on a change in pull request #8579:
URL: https://github.com/apache/kafka/pull/8579#discussion_r417460683
##
File path: core/src/main/scala/kafka/server/AbstractFetcherThread.scala
##
@@ -382,6 +382,11 @@ abstract class AbstractFetcherThread(name: String,
feyman2016 commented on pull request #8020:
URL: https://github.com/apache/kafka/pull/8020#issuecomment-621224680
@abbccdda, I haven't pushed my local change after we have updated the
KIP-571, will still update in this PR.
vvcephei commented on pull request #8580:
URL: https://github.com/apache/kafka/pull/8580#issuecomment-621244415
Thanks for the review @mjsax !
This is an automated message from the Apache Git Service.
To respond to the
vvcephei commented on pull request #8580:
URL: https://github.com/apache/kafka/pull/8580#issuecomment-621244278
The failure was the known-problematic GlobalKTableEOSIntegrationTest
This is an automated message from the
steverod commented on pull request #8543:
URL: https://github.com/apache/kafka/pull/8543#issuecomment-621336009
retest this please
This is an automated message from the Apache Git Service.
To respond to the message, please
kkonstantine commented on pull request #8204:
URL: https://github.com/apache/kafka/pull/8204#issuecomment-621296841
retest this please
This is an automated message from the Apache Git Service.
To respond to the message,
kkonstantine commented on a change in pull request #8204:
URL: https://github.com/apache/kafka/pull/8204#discussion_r417416928
##
File path:
clients/src/test/java/org/apache/kafka/common/config/provider/MockFileConfigProvider.java
##
@@ -19,11 +19,46 @@
import
abbccdda commented on pull request #8550:
URL: https://github.com/apache/kafka/pull/8550#issuecomment-621320858
@mjsax @vvcephei I think this change makes sense, could you two also take a
look?
This is an automated message
ijuma commented on pull request #8582:
URL: https://github.com/apache/kafka/pull/8582#issuecomment-621232463
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
tombentley commented on pull request #8204:
URL: https://github.com/apache/kafka/pull/8204#issuecomment-622044216
Thanks!
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
vvcephei commented on pull request #8590:
URL: https://github.com/apache/kafka/pull/8590#issuecomment-621969666
test this please
This is an automated message from the Apache Git Service.
To respond to the message, please log
kkonstantine commented on pull request #8204:
URL: https://github.com/apache/kafka/pull/8204#issuecomment-621994371
Build results:
jdk8 2 unrelated failures:
`org.apache.kafka.connect.mirror.MirrorConnectorsIntegrationTest.testReplication`
guozhangwang commented on a change in pull request #8496:
URL: https://github.com/apache/kafka/pull/8496#discussion_r418214162
##
File path:
streams/src/test/java/org/apache/kafka/streams/integration/EosBetaUpgradeIntegrationTest.java
##
@@ -1064,14 +1071,16 @@ private void
mjsax commented on a change in pull request #8496:
URL: https://github.com/apache/kafka/pull/8496#discussion_r418209285
##
File path:
streams/src/test/java/org/apache/kafka/streams/integration/EosBetaUpgradeIntegrationTest.java
##
@@ -1064,14 +1071,16 @@ private void
vvcephei commented on pull request #8590:
URL: https://github.com/apache/kafka/pull/8590#issuecomment-621969755
test this please
This is an automated message from the Apache Git Service.
To respond to the message, please log
guozhangwang opened a new pull request #8593:
URL: https://github.com/apache/kafka/pull/8593
1. Added a `recordInternal` function to let all other public functions
trigger, so that `shouldRecord` would only be checked once.
2. In Streams, pass along the current wall-clock time
guozhangwang commented on a change in pull request #8496:
URL: https://github.com/apache/kafka/pull/8496#discussion_r418201398
##
File path: streams/src/main/java/org/apache/kafka/streams/StreamsConfig.java
##
@@ -838,6 +838,7 @@
static {
final Map
guozhangwang commented on pull request #8593:
URL: https://github.com/apache/kafka/pull/8593#issuecomment-622003689
@vvcephei @cadonna for reviews.
This is an automated message from the Apache Git Service.
To respond to the
ableegoldman commented on a change in pull request #8590:
URL: https://github.com/apache/kafka/pull/8590#discussion_r418212743
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/assignment/HighAvailabilityTaskAssignor.java
##
@@ -34,7 +33,6 @@
guozhangwang commented on a change in pull request #8578:
URL: https://github.com/apache/kafka/pull/8578#discussion_r417558605
##
File path:
streams/src/test/java/org/apache/kafka/streams/integration/OptimizedKTableIntegrationTest.java
##
@@ -215,13 +216,13 @@ public void
guozhangwang commented on pull request #8578:
URL: https://github.com/apache/kafka/pull/8578#issuecomment-621416171
LGTM! Please feel free to merge after rebasing.
This is an automated message from the Apache Git Service.
To
junrao commented on pull request #8542:
URL: https://github.com/apache/kafka/pull/8542#issuecomment-621375628
retest this please
This is an automated message from the Apache Git Service.
To respond to the message, please log
junrao commented on pull request #8542:
URL: https://github.com/apache/kafka/pull/8542#issuecomment-621375785
ok to test
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
junrao commented on pull request #8542:
URL: https://github.com/apache/kafka/pull/8542#issuecomment-621375962
test this please
This is an automated message from the Apache Git Service.
To respond to the message, please log
gharris1727 commented on pull request #8442:
URL: https://github.com/apache/kafka/pull/8442#issuecomment-621420069
@kkonstantine I've implemented your feedback and this is ready for another
pass.
This is an automated
vvcephei commented on pull request #8254:
URL: https://github.com/apache/kafka/pull/8254#issuecomment-621380003
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
guozhangwang commented on a change in pull request #8578:
URL: https://github.com/apache/kafka/pull/8578#discussion_r417558079
##
File path:
streams/src/test/java/org/apache/kafka/streams/integration/utils/IntegrationTestUtils.java
##
@@ -145,12 +162,12 @@ public static void
vvcephei commented on a change in pull request #8578:
URL: https://github.com/apache/kafka/pull/8578#discussion_r417558528
##
File path:
streams/src/test/java/org/apache/kafka/streams/integration/utils/IntegrationTestUtils.java
##
@@ -145,12 +162,12 @@ public static void
harshitshah4 commented on pull request #8512:
URL: https://github.com/apache/kafka/pull/8512#issuecomment-621341461
Hey , I feel that its been few days since I opened this pull request , I
have found more similar methods in KafkaConsumer that may require similar
improvement , Since this
steverod commented on pull request #8542:
URL: https://github.com/apache/kafka/pull/8542#issuecomment-621340580
@junrao my local runs with `-PscalaVersion=2.12` compile and run fine. I'm
not able to access the check report so I can't see what's going on there.
junrao commented on pull request #8543:
URL: https://github.com/apache/kafka/pull/8543#issuecomment-621374929
The failed test `BranchedMultiLevelRepartitionConnectedTopologyTest` seems
unrelated to the PR.
This is an
hachikuji opened a new pull request #8585:
URL: https://github.com/apache/kafka/pull/8585
This was a minor regression in the fetch protocol. We should allow the
"debug consumer" to read from follower regardless of the protocol version.
### Committer Checklist (excluded from commit
ableegoldman commented on a change in pull request #8588:
URL: https://github.com/apache/kafka/pull/8588#discussion_r418270317
##
File path:
streams/src/test/java/org/apache/kafka/streams/processor/internals/assignment/TaskAssignorConvergenceTest.java
##
@@ -358,6 +369,57 @@
mjsax commented on pull request #8589:
URL: https://github.com/apache/kafka/pull/8589#issuecomment-622095405
Retest this please.
Call for review @abbccdda
This is an automated message from the Apache Git Service.
To
vvcephei commented on a change in pull request #8588:
URL: https://github.com/apache/kafka/pull/8588#discussion_r418304275
##
File path:
streams/src/test/java/org/apache/kafka/streams/processor/internals/assignment/TaskAssignorConvergenceTest.java
##
@@ -358,6 +369,57 @@
vvcephei commented on pull request #8588:
URL: https://github.com/apache/kafka/pull/8588#issuecomment-622137407
Thanks @ableegoldman !
Regarding the client-capacity-vs-thread-capacity dilemma, I think I'm
remembering that conversation a little differently. I thought:
* in the
ableegoldman edited a comment on pull request #8588:
URL: https://github.com/apache/kafka/pull/8588#issuecomment-622086284
Not sure I'm on the same page w.r.t interpreting "balance" at the client
level. Here's the proposal we discussed a while back:
- In the "under-capacity" case,
ableegoldman commented on a change in pull request #8588:
URL: https://github.com/apache/kafka/pull/8588#discussion_r418267732
##
File path:
streams/src/test/java/org/apache/kafka/streams/processor/internals/assignment/TaskAssignorConvergenceTest.java
##
@@ -358,6 +369,57 @@
ableegoldman commented on a change in pull request #8590:
URL: https://github.com/apache/kafka/pull/8590#discussion_r418271295
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/assignment/HighAvailabilityTaskAssignor.java
##
@@ -34,7 +33,6 @@
gharris1727 commented on pull request #8594:
URL: https://github.com/apache/kafka/pull/8594#issuecomment-622136830
cc @kkonstantine for review.
This is an automated message from the Apache Git Service.
To respond to the
gharris1727 opened a new pull request #8594:
URL: https://github.com/apache/kafka/pull/8594
This is a backport of #8442 for the 2.0 and 2.1 branches.
In these versions, producer.close(Duration) does not exist, and
producer.close(long, TimeUnit) is not deprecated. The tests are
mimaison commented on a change in pull request #8238:
URL: https://github.com/apache/kafka/pull/8238#discussion_r418314384
##
File path: core/src/main/scala/kafka/admin/ConsumerGroupCommand.scala
##
@@ -84,6 +87,15 @@ object ConsumerGroupCommand extends Logging {
}
}
vvcephei commented on pull request #8595:
URL: https://github.com/apache/kafka/pull/8595#issuecomment-622145483
Oh, also note that I used `git revert` on the original commit and then
searched the codebase for the strings `ProcessorContext<` and
`ProcessorContext[` to find any other usages
ableegoldman edited a comment on pull request #8588:
URL: https://github.com/apache/kafka/pull/8588#issuecomment-622086284
Not sure I'm on the same page w.r.t interpreting "balance" at the client
level. Here's the proposal we discussed a while back:
- In the "under-capacity" case,
ableegoldman commented on a change in pull request #8588:
URL: https://github.com/apache/kafka/pull/8588#discussion_r418346499
##
File path:
streams/src/test/java/org/apache/kafka/streams/processor/internals/assignment/TaskAssignorConvergenceTest.java
##
@@ -358,6 +369,57 @@
ableegoldman commented on pull request #8588:
URL: https://github.com/apache/kafka/pull/8588#issuecomment-622086284
Not sure I'm on the same page w.r.t interpreting "balance" at the client
level. Here's the proposal we discussed a while back:
- In the "under-capacity" case, there
cadonna commented on a change in pull request #8590:
URL: https://github.com/apache/kafka/pull/8590#discussion_r418269289
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/assignment/HighAvailabilityTaskAssignor.java
##
@@ -34,7 +33,6 @@
import
mimaison commented on pull request #8238:
URL: https://github.com/apache/kafka/pull/8238#issuecomment-622140465
Thanks @dajac for the great feedback! I believe I've addressed all your
comments now.
@cmccabe @rajinisivaram As you voted on the KIP, could you take a look?
vvcephei commented on pull request #8595:
URL: https://github.com/apache/kafka/pull/8595#issuecomment-622144173
Hey @mjsax @cadonna @apurvam ,
Due to https://github.com/confluentinc/kafka-streams-examples/pull/330, it
seems wise just to pull this change while we consider
ableegoldman commented on pull request #8588:
URL: https://github.com/apache/kafka/pull/8588#issuecomment-622154885
Oh man, I just read my original comment again and I totally swapped the
descriptions of the two cases. Hopefully you knew what I meant but I went back
and fixed it just in
ableegoldman edited a comment on pull request #8588:
URL: https://github.com/apache/kafka/pull/8588#issuecomment-622154885
Oh man, I just read my original comment again and I totally swapped the
descriptions of the two cases. Hopefully you knew what I meant but I went back
and fixed it
vvcephei commented on pull request #8590:
URL: https://github.com/apache/kafka/pull/8590#issuecomment-622106711
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
vvcephei commented on pull request #8590:
URL: https://github.com/apache/kafka/pull/8590#issuecomment-622106914
retest this please
This is an automated message from the Apache Git Service.
To respond to the message, please
vvcephei opened a new pull request #8595:
URL: https://github.com/apache/kafka/pull/8595
This reverts commit 29e08fd2c2d3349ba5cbd8fe5a9d35a0cea02b85.
There turned out to be more than expected problems with adding the parameter
list.
### Committer Checklist (excluded from commit
ableegoldman edited a comment on pull request #8588:
URL: https://github.com/apache/kafka/pull/8588#issuecomment-622154885
Oh man, I just read my original comment again and I totally swapped the
descriptions of the two cases. Hopefully you knew what I meant but I went back
and fixed it
vvcephei commented on pull request #8590:
URL: https://github.com/apache/kafka/pull/8590#issuecomment-622215057
java 14 passed, and the other two failed with the same
`org.apache.kafka.streams.integration.GlobalKTableEOSIntegrationTest.shouldKStreamGlobalKTableLeftJoin[exactly_once_beta]`
vvcephei commented on pull request #8590:
URL: https://github.com/apache/kafka/pull/8590#issuecomment-622215354
Thanks for the PR, @cadonna !
This is an automated message from the Apache Git Service.
To respond to the
vvcephei commented on pull request #8597:
URL: https://github.com/apache/kafka/pull/8597#issuecomment-60559
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
vvcephei edited a comment on pull request #8595:
URL: https://github.com/apache/kafka/pull/8595#issuecomment-61495
11:
*
org.apache.kafka.streams.integration.GlobalKTableIntegrationTest.shouldKStreamGlobalKTableLeftJoin
14:
*
cmccabe opened a new pull request #8598:
URL: https://github.com/apache/kafka/pull/8598
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
cmccabe commented on pull request #8527:
URL: https://github.com/apache/kafka/pull/8527#issuecomment-622266298
ok to test
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
kkonstantine commented on pull request #8594:
URL: https://github.com/apache/kafka/pull/8594#issuecomment-622269313
Backporting https://github.com/apache/kafka/pull/8442 up to `2.2` seems
actually sufficient for this issue (not CVE/data loss related). Therefore, I'll
go ahead and close
ableegoldman opened a new pull request #8596:
URL: https://github.com/apache/kafka/pull/8596
This patch fixes KAFKA-9821 for Streams by persisting the required rebalance
in the assignment. If a member fails and restarts it will receive its last
assignment and notify the thread to trigger
ableegoldman commented on pull request #8596:
URL: https://github.com/apache/kafka/pull/8596#issuecomment-622206057
@guozhangwang @vvcephei @cadonna
This is an automated message from the Apache Git Service.
To respond to
vvcephei commented on pull request #8597:
URL: https://github.com/apache/kafka/pull/8597#issuecomment-622214650
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
vvcephei edited a comment on pull request #8588:
URL: https://github.com/apache/kafka/pull/8588#issuecomment-622137407
Thanks @ableegoldman !
Regarding the client-capacity-vs-thread-capacity dilemma, I think I'm
remembering that conversation a little differently. I thought:
* in
vvcephei commented on a change in pull request #8588:
URL: https://github.com/apache/kafka/pull/8588#discussion_r418390934
##
File path:
streams/src/test/java/org/apache/kafka/streams/processor/internals/assignment/TaskAssignorConvergenceTest.java
##
@@ -358,6 +369,57 @@
cmccabe commented on pull request #5620:
URL: https://github.com/apache/kafka/pull/5620#issuecomment-622268511
Sorry, I'm really overloaded right now, but I do think this is important.
Can I check back in a week? Mention me on the PR then?
ableegoldman edited a comment on pull request #8596:
URL: https://github.com/apache/kafka/pull/8596#issuecomment-622218685
Kicked off the version probing system test since I'm mucking around in the
rebalance triggering code and log messages, and I've broken it that way before
:
ableegoldman commented on pull request #8596:
URL: https://github.com/apache/kafka/pull/8596#issuecomment-622218685
Kicked off the version probing since test since I'm mucking around in the
rebalance triggering code and log messages, and I've broken it that way before
:
vvcephei commented on pull request #8595:
URL: https://github.com/apache/kafka/pull/8595#issuecomment-61495
11:
*
org.apache.kafka.streams.integration.GlobalKTableIntegrationTest.shouldKStreamGlobalKTableLeftJoin
14:
*
apurvam commented on pull request #8595:
URL: https://github.com/apache/kafka/pull/8595#issuecomment-622239713
I'd favor a quick revert.
This is an automated message from the Apache Git Service.
To respond to the message,
ijuma commented on a change in pull request #8586:
URL: https://github.com/apache/kafka/pull/8586#discussion_r418414804
##
File path: core/src/test/scala/unit/kafka/server/SimpleFetchTest.scala
##
@@ -1,206 +0,0 @@
-/**
- * Licensed to the Apache Software Foundation (ASF)
ijuma commented on pull request #8591:
URL: https://github.com/apache/kafka/pull/8591#issuecomment-622246550
ok to test
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
ijuma commented on pull request #8591:
URL: https://github.com/apache/kafka/pull/8591#issuecomment-622252761
retest this please
This is an automated message from the Apache Git Service.
To respond to the message, please log
ableegoldman opened a new pull request #8597:
URL: https://github.com/apache/kafka/pull/8597
Removes this config and its usage from the balanced assignor (effectively
setting it to 1)
This is an automated message from
ableegoldman commented on pull request #8597:
URL: https://github.com/apache/kafka/pull/8597#issuecomment-622213096
@vvcephei @cadonna
This is an automated message from the Apache Git Service.
To respond to the message,
abbccdda commented on a change in pull request #8574:
URL: https://github.com/apache/kafka/pull/8574#discussion_r417578557
##
File path:
streams/src/main/java/org/apache/kafka/streams/kstream/internals/KTableImpl.java
##
@@ -972,13 +974,26 @@ boolean sendingOldValueEnabled()
junrao commented on pull request #8542:
URL: https://github.com/apache/kafka/pull/8542#issuecomment-621494137
The tests passed. Merging to 2.5.
This is an automated message from the Apache Git Service.
To respond to the
hachikuji opened a new pull request #8586:
URL: https://github.com/apache/kafka/pull/8586
Fetches which hit purgatory are currently counted twice in fetch request
rate metrics. This patch moves the metric update into `fetchMessages` so that
they are only counted once.
###
kkonstantine commented on pull request #8442:
URL: https://github.com/apache/kafka/pull/8442#issuecomment-621468250
retest this please
This is an automated message from the Apache Git Service.
To respond to the message,
hachikuji edited a comment on pull request #8586:
URL: https://github.com/apache/kafka/pull/8586#issuecomment-621490434
The failure in the test case is a problem with the isolation of metrics
between test cases. I will submit a fix shortly.
kkonstantine commented on pull request #8204:
URL: https://github.com/apache/kafka/pull/8204#issuecomment-621474718
Failed builds:
[jdk8](https://builds.apache.org/job/kafka-pr-jdk8-scala2.12/2023/)
[jdk11](https://builds.apache.org/job/kafka-pr-jdk11-scala2.13/6045/)
hachikuji commented on pull request #8586:
URL: https://github.com/apache/kafka/pull/8586#issuecomment-621490434
The failure in the test case is a problem of metric isolation. I will submit
a fix shortly.
This is an
hachikuji edited a comment on pull request #8586:
URL: https://github.com/apache/kafka/pull/8586#issuecomment-621490434
The failure in the test case is a problem of test isolation for metrics. I
will submit a fix shortly.
hachikuji edited a comment on pull request #8586:
URL: https://github.com/apache/kafka/pull/8586#issuecomment-621490434
The failure in the test case is a problem in the isolation of metrics
between test cases. I will submit a fix shortly.
ijuma commented on a change in pull request #8567:
URL: https://github.com/apache/kafka/pull/8567#discussion_r417670946
##
File path: core/src/main/scala/kafka/server/KafkaApis.scala
##
@@ -3012,17 +3010,24 @@ class KafkaApis(val requestChannel: RequestChannel,
private def
ijuma commented on a change in pull request #8567:
URL: https://github.com/apache/kafka/pull/8567#discussion_r417674818
##
File path: core/src/test/scala/integration/kafka/api/BaseQuotaTest.scala
##
@@ -235,14 +240,29 @@ abstract class QuotaTestClients(topic: String,
ijuma commented on pull request #8582:
URL: https://github.com/apache/kafka/pull/8582#issuecomment-621476308
More flaky Streams test failures (1 job passed):
*
org.apache.kafka.streams.integration.GlobalKTableEOSIntegrationTest.shouldKStreamGlobalKTableLeftJoin[exactly_once_beta]
cmccabe commented on pull request #6189:
URL: https://github.com/apache/kafka/pull/6189#issuecomment-621514480
This was superseded by #8083
This is an automated message from the Apache Git Service.
To respond to the message,
junrao commented on a change in pull request #8567:
URL: https://github.com/apache/kafka/pull/8567#discussion_r417665485
##
File path: core/src/test/scala/integration/kafka/api/BaseQuotaTest.scala
##
@@ -235,14 +240,29 @@ abstract class QuotaTestClients(topic: String,
vvcephei commented on pull request #8574:
URL: https://github.com/apache/kafka/pull/8574#issuecomment-621467955
Thanks, all! I'll go ahead and merge this.
This is an automated message from the Apache Git Service.
To respond
kkonstantine commented on pull request #8204:
URL: https://github.com/apache/kafka/pull/8204#issuecomment-621473750
@tombentley there are a couple test cases that need adjustment after the
recent fix on the race condition.
sebwills commented on pull request #8481:
URL: https://github.com/apache/kafka/pull/8481#issuecomment-621475637
> ```shell
> ```shell
> JAVA_MAJOR_VERSION=$($JAVA -version 2>&1 | sed -E -n 's/.* version
"([0-9]*).*$/\1/p')
> ```
>
>
> There is another similar code in
vvcephei commented on pull request #8574:
URL: https://github.com/apache/kafka/pull/8574#issuecomment-621496689
cherry-picked to 2.5
This is an automated message from the Apache Git Service.
To respond to the message, please
vvcephei commented on pull request #8574:
URL: https://github.com/apache/kafka/pull/8574#issuecomment-621501336
cherry-picked to 2.4
This is an automated message from the Apache Git Service.
To respond to the message, please
chia7712 opened a new pull request #8599:
URL: https://github.com/apache/kafka/pull/8599
this is a bug of scala 2.12
(https://github.com/scala/bug/issues/10418#issuecomment-524582693).
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
501 - 600 of 51425 matches
Mail list logo
