[GitHub] [kafka] mjsax commented on pull request #8520: Add explicit grace period to tumbling window example

2020-05-01 Thread GitBox
mjsax commented on pull request #8520: URL: https://github.com/apache/kafka/pull/8520#issuecomment-622651340 Don't worry about it. Not a big deal. This is an automated message from the Apache Git Service. To respond to the

[GitHub] [kafka] vvcephei commented on a change in pull request #8248: KAFKA-9501: convert between active and standby without closing stores

2020-05-01 Thread GitBox
vvcephei commented on a change in pull request #8248: URL: https://github.com/apache/kafka/pull/8248#discussion_r418850721 ## File path: checkstyle/suppressions.xml ## @@ -156,7 +156,7 @@

[GitHub] [kafka] ableegoldman commented on a change in pull request #8248: KAFKA-9501: convert between active and standby without closing stores

2020-05-01 Thread GitBox
ableegoldman commented on a change in pull request #8248: URL: https://github.com/apache/kafka/pull/8248#discussion_r418850068 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/ProcessorStateManager.java ## @@ -505,4 +550,35 @@ private

[GitHub] [kafka] ijuma commented on pull request #8533: KAFKA-9589: Fixed bug in V2 log validator tests

2020-05-01 Thread GitBox
ijuma commented on pull request #8533: URL: https://github.com/apache/kafka/pull/8533#issuecomment-622662404 retest this please This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [kafka] ableegoldman commented on a change in pull request #8248: KAFKA-9501: convert between active and standby without closing stores

2020-05-01 Thread GitBox
ableegoldman commented on a change in pull request #8248: URL: https://github.com/apache/kafka/pull/8248#discussion_r418885536 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/ProcessorStateManager.java ## @@ -505,4 +550,35 @@ private

[GitHub] [kafka] ableegoldman commented on a change in pull request #8248: KAFKA-9501: convert between active and standby without closing stores

2020-05-01 Thread GitBox
ableegoldman commented on a change in pull request #8248: URL: https://github.com/apache/kafka/pull/8248#discussion_r418780890 ## File path: checkstyle/suppressions.xml ## @@ -156,7 +156,7 @@

[GitHub] [kafka] mjsax commented on a change in pull request #8248: KAFKA-9501: convert between active and standby without closing stores

2020-05-01 Thread GitBox
mjsax commented on a change in pull request #8248: URL: https://github.com/apache/kafka/pull/8248#discussion_r418782542 ## File path: checkstyle/suppressions.xml ## @@ -156,7 +156,7 @@

[GitHub] [kafka] hachikuji opened a new pull request #8602: KAFKA-9947; Ensure proper shutdown of components in `TransactionsBounceTest`

2020-05-01 Thread GitBox
hachikuji opened a new pull request #8602: URL: https://github.com/apache/kafka/pull/8602 This test case should ensure that clients and the bounce scheduler get shutdown properly. ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation -

[GitHub] [kafka] mjsax commented on pull request #8589: KAFKA-9146: KIP-571 Add option to force delete active members in StreamsResetter

2020-05-01 Thread GitBox
mjsax commented on pull request #8589: URL: https://github.com/apache/kafka/pull/8589#issuecomment-622630109 Retest this please This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [kafka] mjsax commented on pull request #8550: KAFKA-9850 Move KStream#repartition operator validation during Topolo…

2020-05-01 Thread GitBox
mjsax commented on pull request #8550: URL: https://github.com/apache/kafka/pull/8550#issuecomment-622630031 Retest this please. This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [kafka] ableegoldman commented on pull request #8596: KAFKA-9821: persist followup rebalance in assignment and consolidate rebalance triggering mechanisms

2020-05-01 Thread GitBox
ableegoldman commented on pull request #8596: URL: https://github.com/apache/kafka/pull/8596#issuecomment-622628637 Also cc @mjsax for some feedback on making the rebalancing comprehensible in system test logs This is an

[GitHub] [kafka] ableegoldman commented on a change in pull request #8596: KAFKA-9821: persist followup rebalance in assignment and consolidate rebalance triggering mechanisms

2020-05-01 Thread GitBox
ableegoldman commented on a change in pull request #8596: URL: https://github.com/apache/kafka/pull/8596#discussion_r418788022 ## File path: streams/src/main/java/org/apache/kafka/streams/StreamsConfig.java ## @@ -877,7 +877,7 @@ public static final String

[GitHub] [kafka] ableegoldman commented on a change in pull request #8596: KAFKA-9821: persist followup rebalance in assignment and consolidate rebalance triggering mechanisms

2020-05-01 Thread GitBox
ableegoldman commented on a change in pull request #8596: URL: https://github.com/apache/kafka/pull/8596#discussion_r418792433 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamsPartitionAssignor.java ## @@ -907,6 +905,17 @@ private void

[GitHub] [kafka] mjsax commented on a change in pull request #8483: KAFKA-9865: Expose output topic names from TopologyTestDriver

2020-05-01 Thread GitBox
mjsax commented on a change in pull request #8483: URL: https://github.com/apache/kafka/pull/8483#discussion_r418809026 ## File path: streams/test-utils/src/test/java/org/apache/kafka/streams/TopologyTestDriverTest.java ## @@ -450,6 +452,24 @@ public void

[GitHub] [kafka] mjsax commented on pull request #8483: KAFKA-9865: Expose output topic names from TopologyTestDriver

2020-05-01 Thread GitBox
mjsax commented on pull request #8483: URL: https://github.com/apache/kafka/pull/8483#issuecomment-622648248 Retest this please This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [kafka] zhaohaidao commented on a change in pull request #8550: KAFKA-9850 Move KStream#repartition operator validation during Topolo…

2020-05-01 Thread GitBox
zhaohaidao commented on a change in pull request #8550: URL: https://github.com/apache/kafka/pull/8550#discussion_r418820500 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/InternalTopologyBuilder.java ## @@ -633,6 +634,43 @@ public final void

[GitHub] [kafka] ableegoldman commented on a change in pull request #8248: KAFKA-9501: convert between active and standby without closing stores

2020-05-01 Thread GitBox
ableegoldman commented on a change in pull request #8248: URL: https://github.com/apache/kafka/pull/8248#discussion_r418831978 ## File path: checkstyle/suppressions.xml ## @@ -156,7 +156,7 @@

[GitHub] [kafka] feyman2016 commented on pull request #8589: KAFKA-9146: KIP-571 Add option to force delete active members in StreamsResetter

2020-05-01 Thread GitBox
feyman2016 commented on pull request #8589: URL: https://github.com/apache/kafka/pull/8589#issuecomment-622661261 @mjsax I see, thanks :) This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [kafka] ableegoldman commented on a change in pull request #8248: KAFKA-9501: convert between active and standby without closing stores

2020-05-01 Thread GitBox
ableegoldman commented on a change in pull request #8248: URL: https://github.com/apache/kafka/pull/8248#discussion_r418858652 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/ProcessorStateManager.java ## @@ -505,4 +550,35 @@ private

[GitHub] [kafka] ableegoldman commented on pull request #8596: KAFKA-9821: persist followup rebalance in assignment and consolidate rebalance triggering mechanisms

2020-05-01 Thread GitBox
ableegoldman commented on pull request #8596: URL: https://github.com/apache/kafka/pull/8596#issuecomment-622661309 System test run passed (as did all three builds, wow!) This is an automated message from the Apache Git

[GitHub] [kafka] mjsax commented on pull request #8020: KAFKA-9146 [WIP]: Add option to force delete active members in StreamsResetter

2020-05-01 Thread GitBox
mjsax commented on pull request #8020: URL: https://github.com/apache/kafka/pull/8020#issuecomment-622615014 @feyman2016 closing this PR in favor of #8589 -- I assume it's a replacement. This is an automated message from the

[GitHub] [kafka] zhaohaidao commented on a change in pull request #8550: KAFKA-9850 Move KStream#repartition operator validation during Topolo…

2020-05-01 Thread GitBox
zhaohaidao commented on a change in pull request #8550: URL: https://github.com/apache/kafka/pull/8550#discussion_r418814943 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/InternalTopologyBuilder.java ## @@ -633,6 +634,43 @@ public final void

[GitHub] [kafka] zhaohaidao commented on a change in pull request #8550: KAFKA-9850 Move KStream#repartition operator validation during Topolo…

2020-05-01 Thread GitBox
zhaohaidao commented on a change in pull request #8550: URL: https://github.com/apache/kafka/pull/8550#discussion_r418815217 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/InternalTopologyBuilder.java ## @@ -633,6 +634,43 @@ public final void

[GitHub] [kafka] zhaohaidao commented on a change in pull request #8550: KAFKA-9850 Move KStream#repartition operator validation during Topolo…

2020-05-01 Thread GitBox
zhaohaidao commented on a change in pull request #8550: URL: https://github.com/apache/kafka/pull/8550#discussion_r418815490 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/InternalTopologyBuilder.java ## @@ -633,6 +634,43 @@ public final void

[GitHub] [kafka] mjsax commented on a change in pull request #8504: KAFKA-9298: reuse mapped stream error in joins

2020-05-01 Thread GitBox
mjsax commented on a change in pull request #8504: URL: https://github.com/apache/kafka/pull/8504#discussion_r418818822 ## File path: streams/src/main/java/org/apache/kafka/streams/kstream/internals/KStreamImpl.java ## @@ -989,16 +994,18 @@ private void to(final

[GitHub] [kafka] ableegoldman commented on a change in pull request #8248: KAFKA-9501: convert between active and standby without closing stores

2020-05-01 Thread GitBox
ableegoldman commented on a change in pull request #8248: URL: https://github.com/apache/kafka/pull/8248#discussion_r418833053 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/ActiveTaskCreator.java ## @@ -235,9 +264,16 @@ void

[GitHub] [kafka] mjsax commented on pull request #8496: KAFKA-9748: Add Streams eos-beta integration test

2020-05-01 Thread GitBox
mjsax commented on pull request #8496: URL: https://github.com/apache/kafka/pull/8496#issuecomment-622654288 @guozhangwang The failing test run has truncate logs. So it's hard to know what the root cause it. The high level "pattern" seems to be similar to what we have observed before: we

[GitHub] [kafka] ableegoldman commented on a change in pull request #8248: KAFKA-9501: convert between active and standby without closing stores

2020-05-01 Thread GitBox
ableegoldman commented on a change in pull request #8248: URL: https://github.com/apache/kafka/pull/8248#discussion_r418842202 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/TaskManager.java ## @@ -155,9 +155,6 @@ void handleCorruption(final

[GitHub] [kafka] ijuma commented on a change in pull request #8586: KAFKA-9939; Fix overcounting delayed fetches in request rate metrics

2020-05-01 Thread GitBox
ijuma commented on a change in pull request #8586: URL: https://github.com/apache/kafka/pull/8586#discussion_r418679953 ## File path: core/src/test/scala/unit/kafka/server/SimpleFetchTest.scala ## @@ -1,206 +0,0 @@ -/** - * Licensed to the Apache Software Foundation (ASF)

[GitHub] [kafka] hachikuji commented on pull request #8591: KAFKA-6342: Move workaround for JSON parsing of non-escaped strings

2020-05-01 Thread GitBox
hachikuji commented on pull request #8591: URL: https://github.com/apache/kafka/pull/8591#issuecomment-622565563 retest this please This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [kafka] ableegoldman commented on a change in pull request #8248: KAFKA-9501: convert between active and standby without closing stores

2020-05-01 Thread GitBox
ableegoldman commented on a change in pull request #8248: URL: https://github.com/apache/kafka/pull/8248#discussion_r418780240 ## File path: checkstyle/suppressions.xml ## @@ -156,7 +156,7 @@

[GitHub] [kafka] hachikuji commented on a change in pull request #8591: KAFKA-6342: Move workaround for JSON parsing of non-escaped strings

2020-05-01 Thread GitBox
hachikuji commented on a change in pull request #8591: URL: https://github.com/apache/kafka/pull/8591#discussion_r418741006 ## File path: core/src/test/scala/unit/kafka/security/authorizer/AclEntryTest.scala ## @@ -23,27 +23,28 @@ import

[GitHub] [kafka] mjsax commented on pull request #8496: KAFKA-9748: Add Streams eos-beta integration test

2020-05-01 Thread GitBox
mjsax commented on pull request #8496: URL: https://github.com/apache/kafka/pull/8496#issuecomment-622579708 Rebase this PR -- failed before, because the `ProcessorContext` "generics" commit was reverted. This is an

[GitHub] [kafka] ijuma commented on a change in pull request #8591: KAFKA-6342: Move workaround for JSON parsing of non-escaped strings

2020-05-01 Thread GitBox
ijuma commented on a change in pull request #8591: URL: https://github.com/apache/kafka/pull/8591#discussion_r418766141 ## File path: core/src/main/scala/kafka/utils/Json.scala ## @@ -35,16 +35,7 @@ object Json { */ def parseFull(input: String): Option[JsonValue] =

[GitHub] [kafka] mjsax opened a new pull request #8600: KAFKA-9928: Fix flaky GlobalKTableEOSIntegrationTest

2020-05-01 Thread GitBox
mjsax opened a new pull request #8600: URL: https://github.com/apache/kafka/pull/8600 Most changes thus improve the error message output in case a test fails. Potential fix: remove producer config `retries=1` Call for review @guozhangwang

[GitHub] [kafka] guozhangwang commented on a change in pull request #8565: KAFKA-9798: Send one round synchronously before starting the async producer

2020-05-01 Thread GitBox
guozhangwang commented on a change in pull request #8565: URL: https://github.com/apache/kafka/pull/8565#discussion_r418768692 ## File path: streams/src/test/java/org/apache/kafka/streams/integration/QueryableStateIntegrationTest.java ## @@ -1262,6 +1266,7 @@ public void

[GitHub] [kafka] ableegoldman edited a comment on pull request #8596: KAFKA-9821: persist followup rebalance in assignment and consolidate rebalance triggering mechanisms

2020-05-01 Thread GitBox
ableegoldman edited a comment on pull request #8596: URL: https://github.com/apache/kafka/pull/8596#issuecomment-622218685 Kicked off the version probing system test since I'm mucking around in the rebalance triggering code and log messages, and I've broken it that way before  :

[GitHub] [kafka] ConcurrencyPractitioner edited a comment on pull request #7884: [KAFKA-8522] Streamline tombstone and transaction marker removal

2020-05-01 Thread GitBox
ConcurrencyPractitioner edited a comment on pull request #7884: URL: https://github.com/apache/kafka/pull/7884#issuecomment-622490343 @hachikuji Do you have time to review? Just give me a heads-up if there are some comments left unaddressed.

[GitHub] [kafka] ConcurrencyPractitioner commented on pull request #7884: [KAFKA-8522] Streamline tombstone and transaction marker removal

2020-05-01 Thread GitBox
ConcurrencyPractitioner commented on pull request #7884: URL: https://github.com/apache/kafka/pull/7884#issuecomment-622490343 @hachikuji Do you have time to review? Just give me a heads-up if there are some comments left addressed.

[GitHub] [kafka] mjsax edited a comment on pull request #8540: KAFKA-9127: don't create StreamThreads for global-only topology

2020-05-01 Thread GitBox
mjsax edited a comment on pull request #8540: URL: https://github.com/apache/kafka/pull/8540#issuecomment-622513778 @vvcephei Cherry-picking to 2.4 did not work? There might still be a 2.4.2 release? Or should we not back-port it to 2.4 because in 2.4 one can in fact run an empty

[GitHub] [kafka] hachikuji commented on a change in pull request #4204: KAFKA-5238: BrokerTopicMetrics can be recreated after topic is deleted

2020-05-01 Thread GitBox
hachikuji commented on a change in pull request #4204: URL: https://github.com/apache/kafka/pull/4204#discussion_r418702601 ## File path: core/src/main/scala/kafka/server/ReplicaManager.scala ## @@ -1035,11 +1035,13 @@ class ReplicaManager(val config: KafkaConfig, val

[GitHub] [kafka] mjsax commented on a change in pull request #8600: KAFKA-9928: Fix flaky GlobalKTableEOSIntegrationTest

2020-05-01 Thread GitBox
mjsax commented on a change in pull request #8600: URL: https://github.com/apache/kafka/pull/8600#discussion_r418737835 ## File path: streams/src/test/java/org/apache/kafka/streams/integration/GlobalKTableEOSIntegrationTest.java ## @@ -304,59 +382,64 @@ private void

[GitHub] [kafka] hachikuji commented on a change in pull request #8570: Change type to optional in config entry

2020-05-01 Thread GitBox
hachikuji commented on a change in pull request #8570: URL: https://github.com/apache/kafka/pull/8570#discussion_r418756784 ## File path: clients/src/main/java/org/apache/kafka/clients/admin/ConfigEntry.java ## @@ -99,7 +100,7 @@ public String name() { /** * Return

[GitHub] [kafka] vvcephei commented on a change in pull request #8248: KAFKA-9501: convert between active and standby without closing stores

2020-05-01 Thread GitBox
vvcephei commented on a change in pull request #8248: URL: https://github.com/apache/kafka/pull/8248#discussion_r414837565 ## File path: checkstyle/suppressions.xml ## @@ -156,7 +156,7 @@

[GitHub] [kafka] vvcephei commented on a change in pull request #8248: KAFKA-9501: convert between active and standby without closing stores

2020-05-01 Thread GitBox
vvcephei commented on a change in pull request #8248: URL: https://github.com/apache/kafka/pull/8248#discussion_r418767753 ## File path: streams/src/test/java/org/apache/kafka/streams/integration/StandbyTaskCreationIntegrationTest.java ## @@ -148,6 +161,82 @@ public void

[GitHub] [kafka] vvcephei commented on a change in pull request #8588: [WIP] KAFKA-6145: KIP-441: Validate balanced assignment

2020-05-01 Thread GitBox
vvcephei commented on a change in pull request #8588: URL: https://github.com/apache/kafka/pull/8588#discussion_r418768140 ## File path: streams/src/test/java/org/apache/kafka/streams/processor/internals/assignment/TaskAssignorConvergenceTest.java ## @@ -358,6 +369,57 @@

[GitHub] [kafka] mjsax commented on a change in pull request #8565: KAFKA-9798: Send one round synchronously before starting the async producer

2020-05-01 Thread GitBox
mjsax commented on a change in pull request #8565: URL: https://github.com/apache/kafka/pull/8565#discussion_r418679194 ## File path: streams/src/test/java/org/apache/kafka/streams/integration/QueryableStateIntegrationTest.java ## @@ -631,7 +631,11 @@ public void

[GitHub] [kafka] hachikuji commented on a change in pull request #8551: KAFKA-9918 SslEngineFactory is NOT closed when channel is closing

2020-05-01 Thread GitBox
hachikuji commented on a change in pull request #8551: URL: https://github.com/apache/kafka/pull/8551#discussion_r418759371 ## File path: clients/src/main/java/org/apache/kafka/common/security/ssl/SslFactory.java ## @@ -230,6 +231,11 @@ public SslEngineFactory

[GitHub] [kafka] hachikuji commented on pull request #8586: KAFKA-9939; Fix overcounting delayed fetches in request rate metrics

2020-05-01 Thread GitBox
hachikuji commented on pull request #8586: URL: https://github.com/apache/kafka/pull/8586#issuecomment-622593285 The 32 test failures on jdk11 were due to threads being left behind after a failure in `TransactionsBounceTest`. I will submit a separate fix for this. The other failure seems

[GitHub] [kafka] guozhangwang commented on pull request #8565: KAFKA-9798: Send one round synchronously before starting the async producer

2020-05-01 Thread GitBox
guozhangwang commented on pull request #8565: URL: https://github.com/apache/kafka/pull/8565#issuecomment-622602829 @mjsax thanks for the review! Addressed your comments. This is an automated message from the Apache Git

[GitHub] [kafka] ijuma commented on a change in pull request #4204: KAFKA-5238: BrokerTopicMetrics can be recreated after topic is deleted

2020-05-01 Thread GitBox
ijuma commented on a change in pull request #4204: URL: https://github.com/apache/kafka/pull/4204#discussion_r418680839 ## File path: core/src/main/scala/kafka/server/ReplicaManager.scala ## @@ -1035,11 +1035,13 @@ class ReplicaManager(val config: KafkaConfig, val

[GitHub] [kafka] mjsax commented on a change in pull request #8540: KAFKA-9127: don't create StreamThreads for global-only topology

2020-05-01 Thread GitBox
mjsax commented on a change in pull request #8540: URL: https://github.com/apache/kafka/pull/8540#discussion_r418681001 ## File path: streams/src/test/java/org/apache/kafka/streams/KafkaStreamsTest.java ## @@ -327,15 +331,15 @@ private void prepareStreamThread(final

[GitHub] [kafka] hachikuji commented on a change in pull request #4204: KAFKA-5238: BrokerTopicMetrics can be recreated after topic is deleted

2020-05-01 Thread GitBox
hachikuji commented on a change in pull request #4204: URL: https://github.com/apache/kafka/pull/4204#discussion_r418702601 ## File path: core/src/main/scala/kafka/server/ReplicaManager.scala ## @@ -1035,11 +1035,13 @@ class ReplicaManager(val config: KafkaConfig, val

[GitHub] [kafka] hachikuji commented on a change in pull request #8586: KAFKA-9939; Fix overcounting delayed fetches in request rate metrics

2020-05-01 Thread GitBox
hachikuji commented on a change in pull request #8586: URL: https://github.com/apache/kafka/pull/8586#discussion_r418718645 ## File path: core/src/test/scala/unit/kafka/server/SimpleFetchTest.scala ## @@ -1,206 +0,0 @@ -/** - * Licensed to the Apache Software Foundation (ASF)

[GitHub] [kafka] ijuma commented on a change in pull request #8591: KAFKA-6342: Move workaround for JSON parsing of non-escaped strings

2020-05-01 Thread GitBox
ijuma commented on a change in pull request #8591: URL: https://github.com/apache/kafka/pull/8591#discussion_r418778603 ## File path: core/src/main/scala/kafka/utils/Json.scala ## @@ -35,16 +35,7 @@ object Json { */ def parseFull(input: String): Option[JsonValue] =

[GitHub] [kafka] cmccabe opened a new pull request #8601: Remove unit

2020-05-01 Thread GitBox
cmccabe opened a new pull request #8601: URL: https://github.com/apache/kafka/pull/8601 duplicate of https://github.com/apache/kafka/pull/8527 to get jenkins run This is an automated message from the Apache Git Service. To

[GitHub] [kafka] mjsax commented on a change in pull request #8565: KAFKA-9798: Send one round synchronously before starting the async producer

2020-05-01 Thread GitBox
mjsax commented on a change in pull request #8565: URL: https://github.com/apache/kafka/pull/8565#discussion_r418678556 ## File path: streams/src/test/java/org/apache/kafka/streams/integration/QueryableStateIntegrationTest.java ## @@ -1262,6 +1266,7 @@ public void run() {

[GitHub] [kafka] mjsax commented on pull request #8496: KAFKA-9748: Add Streams eos-beta integration test

2020-05-01 Thread GitBox
mjsax commented on pull request #8496: URL: https://github.com/apache/kafka/pull/8496#issuecomment-622557984 Java 8 passed. Java 11: `org.apache.kafka.streams.integration.GlobalKTableIntegrationTest.shouldKStreamGlobalKTableLeftJoin` Java 14: ```

[GitHub] [kafka] vvcephei commented on a change in pull request #8593: MINOR: Improve Sensor recording efficiency

2020-05-01 Thread GitBox
vvcephei commented on a change in pull request #8593: URL: https://github.com/apache/kafka/pull/8593#discussion_r418735906 ## File path: streams/src/test/java/org/apache/kafka/test/MockSourceNode.java ## @@ -48,7 +48,7 @@ public void process(final K key, final V value) {

[GitHub] [kafka] hachikuji commented on pull request #8577: use appropriate fn for readability. (maybe)

2020-05-01 Thread GitBox
hachikuji commented on pull request #8577: URL: https://github.com/apache/kafka/pull/8577#issuecomment-622580718 retest this please This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [kafka] kkonstantine commented on pull request #6472: KAFKA-8125: Skip doing assignment when topic existed

2020-05-02 Thread GitBox
kkonstantine commented on pull request #6472: URL: https://github.com/apache/kafka/pull/6472#issuecomment-622968291 [KAFKA-8125](https://issues.apache.org/jira/browse/KAFKA-8125) has been resolved as duplicate. Closing as superseded by https://github.com/apache/kafka/pull/7298

[GitHub] [kafka] feyman2016 edited a comment on pull request #8589: KAFKA-9146: KIP-571 Add option to force delete active members in StreamsResetter

2020-05-02 Thread GitBox
feyman2016 edited a comment on pull request #8589: URL: https://github.com/apache/kafka/pull/8589#issuecomment-622661261 @mjsax I see, thanks! And call for review :) This is an automated message from the Apache Git

[GitHub] [kafka] kkonstantine commented on pull request #6092: KAFKA-7778: Add KTable.suppress to Scala API

2020-05-02 Thread GitBox
kkonstantine commented on pull request #6092: URL: https://github.com/apache/kafka/pull/6092#issuecomment-622982073 Closing in favor of https://github.com/apache/kafka/pull/6314 This is an automated message from the Apache

[GitHub] [kafka] mjsax opened a new pull request #8603: MINOR: Fix ProcessorContext JavaDocs

2020-05-02 Thread GitBox
mjsax opened a new pull request #8603: URL: https://github.com/apache/kafka/pull/8603 We changed how "stream time" is computed in `2.3` release. This should be cherry-picked to older branches. This is an automated message

[GitHub] [kafka] mjsax commented on pull request #8603: MINOR: Fix ProcessorContext JavaDocs

2020-05-02 Thread GitBox
mjsax commented on pull request #8603: URL: https://github.com/apache/kafka/pull/8603#issuecomment-623011501 Call for review @vvcephei This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [kafka] ijuma commented on a change in pull request #8585: KAFKA-9938; Debug consumer should be able to fetch from followers

2020-05-03 Thread GitBox
ijuma commented on a change in pull request #8585: URL: https://github.com/apache/kafka/pull/8585#discussion_r419159734 ## File path: core/src/main/scala/kafka/server/ReplicaManager.scala ## @@ -949,8 +949,11 @@ class ReplicaManager(val config: KafkaConfig, else

[GitHub] [kafka] ijuma commented on a change in pull request #8585: KAFKA-9938; Debug consumer should be able to fetch from followers

2020-05-03 Thread GitBox
ijuma commented on a change in pull request #8585: URL: https://github.com/apache/kafka/pull/8585#discussion_r419159612 ## File path: core/src/main/scala/kafka/server/ReplicaManager.scala ## @@ -949,8 +949,11 @@ class ReplicaManager(val config: KafkaConfig, else

[GitHub] [kafka] ijuma opened a new pull request #8607: KAFKA-9731: Disable immediate fetch response for hw propagation if replica selector is not defined

2020-05-03 Thread GitBox
ijuma opened a new pull request #8607: URL: https://github.com/apache/kafka/pull/8607 In the case described in the JIRA, there was a 50%+ increase in the total fetch request rate in 2.4.0 due to this change. I included a few additional clean-ups: * Simplify

[GitHub] [kafka] chia7712 commented on a change in pull request #8605: Minor: remove KafkaProducer#propsToMap as it is duplicate to Abstract…

2020-05-03 Thread GitBox
chia7712 commented on a change in pull request #8605: URL: https://github.com/apache/kafka/pull/8605#discussion_r419180021 ## File path: clients/src/main/java/org/apache/kafka/clients/producer/KafkaProducer.java ## @@ -284,7 +283,8 @@ public KafkaProducer(final Map configs) {

[GitHub] [kafka] ijuma commented on a change in pull request #8605: Minor: remove KafkaProducer#propsToMap as it is duplicate to Abstract…

2020-05-03 Thread GitBox
ijuma commented on a change in pull request #8605: URL: https://github.com/apache/kafka/pull/8605#discussion_r419158524 ## File path: clients/src/main/java/org/apache/kafka/clients/producer/KafkaProducer.java ## @@ -284,7 +283,8 @@ public KafkaProducer(final Map configs) {

[GitHub] [kafka] gwenshap commented on pull request #8456: MINOR: Annotate KafkaAdminClientTest.testAlterClientQuotas() with @Test

2020-05-03 Thread GitBox
gwenshap commented on pull request #8456: URL: https://github.com/apache/kafka/pull/8456#issuecomment-623181092 The results of the failed test are long gone, but this is literally just a test annotation, and 2/3 test runs passed. I'll just go ahead and merge this.

[GitHub] [kafka] ijuma commented on a change in pull request #8602: KAFKA-9947; Ensure proper shutdown of components in `TransactionsBounceTest`

2020-05-03 Thread GitBox
ijuma commented on a change in pull request #8602: URL: https://github.com/apache/kafka/pull/8602#discussion_r419160617 ## File path: core/src/test/scala/integration/kafka/api/TransactionsBounceTest.scala ## @@ -130,13 +129,10 @@ class TransactionsBounceTest extends

[GitHub] [kafka] gwenshap opened a new pull request #8606: KAFKA-9731: No need to propagate HWM to followers when using default …

2020-05-03 Thread GitBox
gwenshap opened a new pull request #8606: URL: https://github.com/apache/kafka/pull/8606 Attempted fix to the unnecessary fetch request responses detected by @vahidhashemian in KAFKA-9731. I did not add tests (under the assumption that the correctness of HWM propagation is already

[GitHub] [kafka] ijuma commented on a change in pull request #8579: KAFKA-9930: Prevent ReplicaFetcherThread from throwing UnknownTopicOrPartitionException upon topic creation and deletion.

2020-05-02 Thread GitBox
ijuma commented on a change in pull request #8579: URL: https://github.com/apache/kafka/pull/8579#discussion_r419038136 ## File path: core/src/main/scala/kafka/server/AbstractFetcherThread.scala ## @@ -382,6 +382,11 @@ abstract class AbstractFetcherThread(name: String,

[GitHub] [kafka] ijuma commented on pull request #8607: KAFKA-9731: Disable immediate fetch response for hw propagation if replica selector is not defined

2020-05-03 Thread GitBox
ijuma commented on pull request #8607: URL: https://github.com/apache/kafka/pull/8607#issuecomment-623240751 1 job passed, 1 failed due to a spotBugs issue with Scala 2.12 and one failed with an unrelated flaky test failure: >

[GitHub] [kafka] mjsax commented on pull request #8603: MINOR: Fix ProcessorContext JavaDocs

2020-05-03 Thread GitBox
mjsax commented on pull request #8603: URL: https://github.com/apache/kafka/pull/8603#issuecomment-623240662 Java 8 and 14 passed. Java 11: `org.apache.kafka.connect.mirror.MirrorConnectorsIntegrationTest.testReplication`

[GitHub] [kafka] C0urante commented on pull request #8608: KAFKA-9950: Construct new ConfigDef for MirrorTaskConfig before defining new properties

2020-05-03 Thread GitBox
C0urante commented on pull request #8608: URL: https://github.com/apache/kafka/pull/8608#issuecomment-623257536 @ryannedolan based on your experience MM2, would you be willing to take a look at this? This is an automated

[GitHub] [kafka] ijuma commented on a change in pull request #8605: Minor: remove KafkaProducer#propsToMap as it is duplicate to Abstract…

2020-05-03 Thread GitBox
ijuma commented on a change in pull request #8605: URL: https://github.com/apache/kafka/pull/8605#discussion_r419185106 ## File path: clients/src/main/java/org/apache/kafka/clients/producer/KafkaProducer.java ## @@ -284,7 +283,8 @@ public KafkaProducer(final Map configs) {

[GitHub] [kafka] mjsax commented on pull request #8600: KAFKA-9928: Fix flaky GlobalKTableEOSIntegrationTest

2020-05-03 Thread GitBox
mjsax commented on pull request #8600: URL: https://github.com/apache/kafka/pull/8600#issuecomment-623238235 Retest this please. This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [kafka] mjsax commented on pull request #8600: KAFKA-9928: Fix flaky GlobalKTableEOSIntegrationTest

2020-05-03 Thread GitBox
mjsax commented on pull request #8600: URL: https://github.com/apache/kafka/pull/8600#issuecomment-623237799 Java 8 passed. Java 11: `org.apache.kafka.streams.integration.GlobalKTableIntegrationTest.shouldKStreamGlobalKTableLeftJoin` (note it's not the EOS test) Java 14: ```

[GitHub] [kafka] C0urante opened a new pull request #8608: KAFKA-9950: Construct new ConfigDef for MirrorTaskConfig before defining new properties

2020-05-03 Thread GitBox
C0urante opened a new pull request #8608: URL: https://github.com/apache/kafka/pull/8608 [Jira](https://issues.apache.org/jira/browse/KAFKA-9950) MM2 is currently sharing the same `ConfigDef` object for all its connectors and tasks, which would be fine _if_ that object were used

[GitHub] [kafka] lbradstreet commented on pull request #8609: KAFKA-9946; StopReplicaRequest deletePartition changes may cause premature topic deletion handling in controller

2020-05-04 Thread GitBox
lbradstreet commented on pull request #8609: URL: https://github.com/apache/kafka/pull/8609#issuecomment-623488567 I haven't reviewed the PR, but I can confirm that I no longer see the premature deletion behaviour that lead me to report KAFKA-9946.

[GitHub] [kafka] dajac commented on pull request #8311: KAFKA-9434: automated protocol for alterReplicaLogDirs

2020-05-04 Thread GitBox
dajac commented on pull request #8311: URL: https://github.com/apache/kafka/pull/8311#issuecomment-623538567 @tombentley Did you consider adding a loop in at the end of the `handleResponse` that would complete any non-completed future related to the current `brokerId` with an exception?

[GitHub] [kafka] wj1918 opened a new pull request #8612: KAFKA-8120 Getting NegativeArraySizeException when using Kafka Connect

2020-05-04 Thread GitBox
wj1918 opened a new pull request #8612: URL: https://github.com/apache/kafka/pull/8612 1. Trigger buffer expansion when buffer does not extract a line 2. Limit buffer size to Integer.MAX_VALUE 3. Using single loop inside FileStreamSourceTask.poll 4. Close the stream before throw

[GitHub] [kafka] cadonna opened a new pull request #8613: KAFKA-6145: Set HighAvailabilityTaskAssignor as default in streams_upgrade_test.py

2020-05-04 Thread GitBox
cadonna opened a new pull request #8613: URL: https://github.com/apache/kafka/pull/8613 This PR sets HighAvailabilityTaskAssignor as default task assignor in streams_upgrade_test.py. The verification of the test needed to be modified to because the HighAvailabilityTaskAssignor

[GitHub] [kafka] cadonna commented on pull request #8613: KAFKA-6145: Set HighAvailabilityTaskAssignor as default in streams_upgrade_test.py

2020-05-04 Thread GitBox
cadonna commented on pull request #8613: URL: https://github.com/apache/kafka/pull/8613#issuecomment-623520934 Call for review: @vvcephei @ableegoldman This is an automated message from the Apache Git Service. To respond to

[GitHub] [kafka] nizhikov edited a comment on pull request #8592: KAFKA-3184: Add Checkpoint for In-memory State Store

2020-05-04 Thread GitBox
nizhikov edited a comment on pull request #8592: URL: https://github.com/apache/kafka/pull/8592#issuecomment-623398837 failure unrelated This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [kafka] nizhikov commented on pull request #8592: KAFKA-3184: Add Checkpoint for In-memory State Store

2020-05-04 Thread GitBox
nizhikov commented on pull request #8592: URL: https://github.com/apache/kafka/pull/8592#issuecomment-623398837 retest this This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [kafka] bbejeck commented on pull request #8504: KAFKA-9298: reuse mapped stream error in joins

2020-05-04 Thread GitBox
bbejeck commented on pull request #8504: URL: https://github.com/apache/kafka/pull/8504#issuecomment-623500291 >Is she? I guess it's clearly document that the name is use for repartition topics, too, but it might still be an unexpected "side effect"? But I see the point that it's not too

[GitHub] [kafka] cadonna commented on a change in pull request #8613: KAFKA-6145: Set HighAvailabilityTaskAssignor as default in streams_upgrade_test.py

2020-05-04 Thread GitBox
cadonna commented on a change in pull request #8613: URL: https://github.com/apache/kafka/pull/8613#discussion_r419496703 ## File path: tests/kafkatest/tests/streams/streams_upgrade_test.py ## @@ -532,20 +532,22 @@ def do_rolling_bounce(self, processor, counter,

[GitHub] [kafka] cadonna commented on pull request #8613: KAFKA-6145: Set HighAvailabilityTaskAssignor as default in streams_upgrade_test.py

2020-05-04 Thread GitBox
cadonna commented on pull request #8613: URL: https://github.com/apache/kafka/pull/8613#issuecomment-623525749 System tests job: https://jenkins.confluent.io/job/system-test-kafka-branch-builder/3928/ This is an automated

[GitHub] [kafka] ijuma commented on pull request #8607: KAFKA-9731: Disable immediate fetch response for hw propagation if replica selector is not defined

2020-05-04 Thread GitBox
ijuma commented on pull request #8607: URL: https://github.com/apache/kafka/pull/8607#issuecomment-623470067 retest this please This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [kafka] cadonna commented on a change in pull request #8613: KAFKA-6145: Set HighAvailabilityTaskAssignor as default in streams_upgrade_test.py

2020-05-04 Thread GitBox
cadonna commented on a change in pull request #8613: URL: https://github.com/apache/kafka/pull/8613#discussion_r419496703 ## File path: tests/kafkatest/tests/streams/streams_upgrade_test.py ## @@ -532,20 +532,22 @@ def do_rolling_bounce(self, processor, counter,

[GitHub] [kafka] d8tltanc opened a new pull request #8610: KAKFA-9942: --entity-default flag is not working for alternating / describing configs in AdminClient

2020-05-04 Thread GitBox
d8tltanc opened a new pull request #8610: URL: https://github.com/apache/kafka/pull/8610 *More detailed description of your change, The client-side passes an empty string "" to the server controller indicating that the quota changes apply to the default entity. However, the server

[GitHub] [kafka] showuon opened a new pull request #8611: MINOR: Format the notation content for better readability

2020-05-04 Thread GitBox
showuon opened a new pull request #8611: URL: https://github.com/apache/kafka/pull/8611 **before:** ![image](https://user-images.githubusercontent.com/43372967/80954688-745c4580-8e30-11ea-9330-fe7f6321adce.png) Here, the notation words are not in different format, makes it hard

[GitHub] [kafka] edoardocomar commented on a change in pull request #4204: KAFKA-5238: BrokerTopicMetrics can be recreated after topic is deleted

2020-05-04 Thread GitBox
edoardocomar commented on a change in pull request #4204: URL: https://github.com/apache/kafka/pull/4204#discussion_r419313971 ## File path: core/src/main/scala/kafka/server/ReplicaManager.scala ## @@ -1035,11 +1035,13 @@ class ReplicaManager(val config: KafkaConfig,

[GitHub] [kafka] dajac opened a new pull request #8609: KAFKA-9946; StopReplicaRequest deletePartition changes may cause premature topic deletion handling in controller

2020-05-04 Thread GitBox
dajac opened a new pull request #8609: URL: https://github.com/apache/kafka/pull/8609 ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation - [ ] Verify test coverage and CI build status - [ ] Verify documentation (including upgrade

[GitHub] [kafka] nizhikov commented on pull request #8592: KAFKA-3184: Add Checkpoint for In-memory State Store

2020-05-04 Thread GitBox
nizhikov commented on pull request #8592: URL: https://github.com/apache/kafka/pull/8592#issuecomment-623399649 retest this please This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [kafka] nizhikov edited a comment on pull request #8592: KAFKA-3184: Add Checkpoint for In-memory State Store

2020-05-04 Thread GitBox
nizhikov edited a comment on pull request #8592: URL: https://github.com/apache/kafka/pull/8592#issuecomment-623398837 retest this please This is an automated message from the Apache Git Service. To respond to the

[GitHub] [kafka] nizhikov removed a comment on pull request #8592: KAFKA-3184: Add Checkpoint for In-memory State Store

2020-05-04 Thread GitBox
nizhikov removed a comment on pull request #8592: URL: https://github.com/apache/kafka/pull/8592#issuecomment-623398837 retest this please This is an automated message from the Apache Git Service. To respond to the

<    3   4   5   6   7   8   9   10   11   12   >