[jira] [Comment Edited] (KAFKA-10284) Group membership update due to static member rejoin should be persisted

2020-07-23 Thread Akshay Sharma (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10284?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17163248#comment-17163248 ] Akshay Sharma edited comment on KAFKA-10284 at 7/23/20, 6:24 AM: - Hi

[jira] [Commented] (KAFKA-10284) Group membership update due to static member rejoin should be persisted

2020-07-23 Thread Akshay Sharma (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10284?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17163248#comment-17163248 ] Akshay Sharma commented on KAFKA-10284: --- Hi [~bchen225242]/[~guozhang], I've raised the bug

[GitHub] [kafka] huxihx commented on pull request #9051: KAFKA-10268: dynamic config like "--delete-config log.retention.ms" doesn't work

2020-07-23 Thread GitBox
huxihx commented on pull request #9051: URL: https://github.com/apache/kafka/pull/9051#issuecomment-662835750 retest this please This is an automated message from the Apache Git Service. To respond to the message, please log

[jira] [Commented] (KAFKA-10205) NullPointerException in StreamTask

2020-07-23 Thread Igor Soarez (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10205?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17163394#comment-17163394 ] Igor Soarez commented on KAFKA-10205: - I'm happy take this one on.   > NullPointerException in

[jira] [Assigned] (KAFKA-10205) NullPointerException in StreamTask

2020-07-23 Thread Igor Soarez (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10205?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Igor Soarez reassigned KAFKA-10205: --- Assignee: Igor Soarez > NullPointerException in StreamTask >

[GitHub] [kafka] bob-barrett commented on pull request #9054: KAFKA-10282: Remove Log metrics immediately when deleting log

2020-07-23 Thread GitBox
bob-barrett commented on pull request #9054: URL: https://github.com/apache/kafka/pull/9054#issuecomment-662841978 While addressing the feedback, I realized I had missed the case when replacing a current log with a future log as part of altering a partition's log dir. We also deferred

[GitHub] [kafka] stanislavkozlovski commented on pull request #9050: KAFKA-10193: Add preemption for controller events that have callbacks

2020-07-23 Thread GitBox
stanislavkozlovski commented on pull request #9050: URL: https://github.com/apache/kafka/pull/9050#issuecomment-662860332 > add preempt(): Unit method for all ControllerEvent so that all events (and future events) must implement it > for events that have callbacks, move the preemption

[GitHub] [kafka] showuon commented on pull request #9062: KAFKA-8098: fix the flaky test by disabling the auto commit to avoid member rejoining

2020-07-23 Thread GitBox
showuon commented on pull request #9062: URL: https://github.com/apache/kafka/pull/9062#issuecomment-662919173 @feyman2016 @huxihx , since you have experience in this test before, could you review this small PR? Thanks.

[GitHub] [kafka] dajac commented on a change in pull request #9051: KAFKA-10268: dynamic config like "--delete-config log.retention.ms" doesn't work

2020-07-23 Thread GitBox
dajac commented on a change in pull request #9051: URL: https://github.com/apache/kafka/pull/9051#discussion_r459252113 ## File path: core/src/test/scala/integration/kafka/server/DynamicBrokerReconfigurationTest.scala ## @@ -775,6 +775,24 @@ class

[GitHub] [kafka] stanislavkozlovski commented on a change in pull request #9050: KAFKA-10193: Add preemption for controller events that have callbacks

2020-07-23 Thread GitBox
stanislavkozlovski commented on a change in pull request #9050: URL: https://github.com/apache/kafka/pull/9050#discussion_r459262136 ## File path: core/src/test/scala/unit/kafka/controller/ControllerIntegrationTest.scala ## @@ -598,6 +603,86 @@ class ControllerIntegrationTest

[GitHub] [kafka] showuon opened a new pull request #9062: KAFKA-8098: fix the flaky test by disabling the auto commit to avoid member rejoining

2020-07-23 Thread GitBox
showuon opened a new pull request #9062: URL: https://github.com/apache/kafka/pull/9062 ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation - [ ] Verify test coverage and CI build status - [ ] Verify documentation (including upgrade

[jira] [Comment Edited] (KAFKA-8154) Buffer Overflow exceptions between brokers and with clients

2020-07-23 Thread Paul Webb (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-8154?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17163344#comment-17163344 ] Paul Webb edited comment on KAFKA-8154 at 7/23/20, 8:52 AM: Hi.  Please note

[jira] [Assigned] (KAFKA-9343) Add ps command for Kafka and zookeeper process on z/OS.

2020-07-23 Thread Shuo Zhang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9343?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shuo Zhang reassigned KAFKA-9343: - Assignee: Shuo Zhang > Add ps command for Kafka and zookeeper process on z/OS. >

[jira] [Commented] (KAFKA-8154) Buffer Overflow exceptions between brokers and with clients

2020-07-23 Thread Paul Webb (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-8154?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17163344#comment-17163344 ] Paul Webb commented on KAFKA-8154: -- Hi.  Please note that we were recently affected by this issue.  I

[GitHub] [kafka] leonardge opened a new pull request #9063: Fixed deprecated Gradle build Properties.

2020-07-23 Thread GitBox
leonardge opened a new pull request #9063: URL: https://github.com/apache/kafka/pull/9063 Gradle properties: `baseName`, `classifier` and `version` has been deprecated. So I have change these to `archiveBaseName`, `archiveClassifier` and `archiveVersion`. More infomration

[jira] [Commented] (KAFKA-8098) Flaky Test AdminClientIntegrationTest#testConsumerGroups

2020-07-23 Thread Luke Chen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-8098?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17163397#comment-17163397 ] Luke Chen commented on KAFKA-8098: -- In the test, we first test removing 1 member from group, and then

[jira] [Comment Edited] (KAFKA-8037) KTable restore may load bad data

2020-07-23 Thread Bruno Cadonna (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-8037?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17163485#comment-17163485 ] Bruno Cadonna edited comment on KAFKA-8037 at 7/23/20, 12:04 PM: - I find

[jira] [Comment Edited] (KAFKA-8037) KTable restore may load bad data

2020-07-23 Thread Bruno Cadonna (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-8037?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17163485#comment-17163485 ] Bruno Cadonna edited comment on KAFKA-8037 at 7/23/20, 12:21 PM: - I find

[jira] [Commented] (KAFKA-8582) Consider adding an ExpiredWindowRecordHandler to Suppress

2020-07-23 Thread Igor Piddubnyi (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-8582?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17163529#comment-17163529 ] Igor Piddubnyi commented on KAFKA-8582: --- Hi [~mjsax], as discussed in PR please assign the ticket

[jira] [Comment Edited] (KAFKA-9531) java.net.UnknownHostException loop on VM rolling update using CNAME

2020-07-23 Thread Thiago Santos (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9531?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17163590#comment-17163590 ] Thiago Santos edited comment on KAFKA-9531 at 7/23/20, 1:45 PM: I am

[jira] [Comment Edited] (KAFKA-9531) java.net.UnknownHostException loop on VM rolling update using CNAME

2020-07-23 Thread Thiago Santos (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9531?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17163590#comment-17163590 ] Thiago Santos edited comment on KAFKA-9531 at 7/23/20, 1:44 PM: I am

[GitHub] [kafka] dajac commented on a change in pull request #9060: KAFKA-9274: Remove `retries` from InternalTopicManager

2020-07-23 Thread GitBox
dajac commented on a change in pull request #9060: URL: https://github.com/apache/kafka/pull/9060#discussion_r459258170 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/InternalTopicManager.java ## @@ -96,13 +104,15 @@ public

[GitHub] [kafka] dajac commented on a change in pull request #9060: KAFKA-9274: Remove `retries` from InternalTopicManager

2020-07-23 Thread GitBox
dajac commented on a change in pull request #9060: URL: https://github.com/apache/kafka/pull/9060#discussion_r459258170 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/InternalTopicManager.java ## @@ -96,13 +104,15 @@ public

[jira] [Comment Edited] (KAFKA-8154) Buffer Overflow exceptions between brokers and with clients

2020-07-23 Thread Paul Webb (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-8154?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17163344#comment-17163344 ] Paul Webb edited comment on KAFKA-8154 at 7/23/20, 8:53 AM: [~rsivaram]   

[jira] [Updated] (KAFKA-9343) Add ps command for Kafka and zookeeper process on z/OS.

2020-07-23 Thread Shuo Zhang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9343?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shuo Zhang updated KAFKA-9343: -- Fix Version/s: 2.6.0 > Add ps command for Kafka and zookeeper process on z/OS. >

[GitHub] [kafka] mimaison commented on pull request #8295: KAFKA-9627: Replace ListOffset request/response with automated protocol

2020-07-23 Thread GitBox
mimaison commented on pull request #8295: URL: https://github.com/apache/kafka/pull/8295#issuecomment-662968116 Rebased on trunk This is an automated message from the Apache Git Service. To respond to the message, please log

[jira] [Commented] (KAFKA-8037) KTable restore may load bad data

2020-07-23 Thread Bruno Cadonna (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-8037?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17163485#comment-17163485 ] Bruno Cadonna commented on KAFKA-8037: -- I find the idea of putting records in its original byte

[jira] [Commented] (KAFKA-9531) java.net.UnknownHostException loop on VM rolling update using CNAME

2020-07-23 Thread Thiago Santos (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9531?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17163590#comment-17163590 ] Thiago Santos commented on KAFKA-9531: -- I am experiencing the same problem. When i start a local

[jira] [Comment Edited] (KAFKA-10205) NullPointerException in StreamTask

2020-07-23 Thread Igor Soarez (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10205?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17163394#comment-17163394 ] Igor Soarez edited comment on KAFKA-10205 at 7/23/20, 2:01 PM: --- I'm happy

[GitHub] [kafka] vitojeng opened a new pull request #9069: KAFKA-5876: Apply UnknownStateStoreException for Interactive Queries

2020-07-23 Thread GitBox
vitojeng opened a new pull request #9069: URL: https://github.com/apache/kafka/pull/9069 follow-up #8200 KAFKA-5876's PR break into multiple parts, this PR is part 2: apply UnknownStateStoreException ### Committer Checklist (excluded from commit message) - [ ] Verify

[GitHub] [kafka] mjsax commented on a change in pull request #9060: KAFKA-9274: Remove `retries` from InternalTopicManager

2020-07-23 Thread GitBox
mjsax commented on a change in pull request #9060: URL: https://github.com/apache/kafka/pull/9060#discussion_r459793713 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/InternalTopicManager.java ## @@ -96,13 +104,15 @@ public

[GitHub] [kafka] guozhangwang commented on a change in pull request #9047: KAFKA-9274: Remove `retries` for global task

2020-07-23 Thread GitBox
guozhangwang commented on a change in pull request #9047: URL: https://github.com/apache/kafka/pull/9047#discussion_r459799708 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/GlobalStateManagerImpl.java ## @@ -299,7 +318,17 @@ private void

[GitHub] [kafka] guozhangwang commented on a change in pull request #9060: KAFKA-9274: Remove `retries` from InternalTopicManager

2020-07-23 Thread GitBox
guozhangwang commented on a change in pull request #9060: URL: https://github.com/apache/kafka/pull/9060#discussion_r459800202 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/InternalTopicManager.java ## @@ -154,27 +164,34 @@ public

[GitHub] [kafka] vitojeng commented on a change in pull request #9069: KAFKA-5876: Apply UnknownStateStoreException for Interactive Queries

2020-07-23 Thread GitBox
vitojeng commented on a change in pull request #9069: URL: https://github.com/apache/kafka/pull/9069#discussion_r459805054 ## File path: streams/src/test/java/org/apache/kafka/streams/KafkaStreamsTest.java ## @@ -693,6 +695,16 @@ public void

[jira] [Commented] (KAFKA-10284) Group membership update due to static member rejoin should be persisted

2020-07-23 Thread Guozhang Wang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10284?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17164063#comment-17164063 ] Guozhang Wang commented on KAFKA-10284: --- What [~ableegoldman] described seems aligned to this, BUT

[jira] [Resolved] (KAFKA-10268) dynamic config like "--delete-config log.retention.ms" doesn't work

2020-07-23 Thread huxihx (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10268?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] huxihx resolved KAFKA-10268. Fix Version/s: 2.7.0 Resolution: Fixed > dynamic config like "--delete-config log.retention.ms"

[GitHub] [kafka] mjsax commented on a change in pull request #9047: KAFKA-9274: Remove `retries` for global task

2020-07-23 Thread GitBox
mjsax commented on a change in pull request #9047: URL: https://github.com/apache/kafka/pull/9047#discussion_r459790103 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/GlobalStateManagerImpl.java ## @@ -131,11 +135,40 @@ public void

[GitHub] [kafka] mjsax commented on a change in pull request #9047: KAFKA-9274: Remove `retries` for global task

2020-07-23 Thread GitBox
mjsax commented on a change in pull request #9047: URL: https://github.com/apache/kafka/pull/9047#discussion_r459790323 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/GlobalStateManagerImpl.java ## @@ -299,7 +318,17 @@ private void

[GitHub] [kafka] mjsax commented on a change in pull request #9047: KAFKA-9274: Remove `retries` for global task

2020-07-23 Thread GitBox
mjsax commented on a change in pull request #9047: URL: https://github.com/apache/kafka/pull/9047#discussion_r459791370 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/GlobalStateManagerImpl.java ## @@ -299,7 +318,17 @@ private void

[GitHub] [kafka] mjsax commented on a change in pull request #9047: KAFKA-9274: Remove `retries` for global task

2020-07-23 Thread GitBox
mjsax commented on a change in pull request #9047: URL: https://github.com/apache/kafka/pull/9047#discussion_r459791741 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/GlobalStateManagerImpl.java ## @@ -299,7 +318,17 @@ private void

[GitHub] [kafka] huxihx commented on pull request #9051: KAFKA-10268: dynamic config like "--delete-config log.retention.ms" doesn't work

2020-07-23 Thread GitBox
huxihx commented on pull request #9051: URL: https://github.com/apache/kafka/pull/9051#issuecomment-663309863 @rajinisivaram Thanks for the review, merging to trunk This is an automated message from the Apache Git Service.

[GitHub] [kafka] huxihx merged pull request #9051: KAFKA-10268: dynamic config like "--delete-config log.retention.ms" doesn't work

2020-07-23 Thread GitBox
huxihx merged pull request #9051: URL: https://github.com/apache/kafka/pull/9051 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [kafka] showuon commented on a change in pull request #9029: KAFKA-10255: Fix flaky testOneWayReplicationWithAutoOffsetSync test

2020-07-23 Thread GitBox
showuon commented on a change in pull request #9029: URL: https://github.com/apache/kafka/pull/9029#discussion_r459818087 ## File path: connect/mirror/src/test/java/org/apache/kafka/connect/mirror/MirrorConnectorsIntegrationTest.java ## @@ -62,6 +65,7 @@ private static

[GitHub] [kafka] piddubnyi commented on pull request #9017: KAFKA-8582 [WIP] Add ability to handle late messages in streams-aggregation

2020-07-23 Thread GitBox
piddubnyi commented on pull request #9017: URL: https://github.com/apache/kafka/pull/9017#issuecomment-663037679 Hi @mjsax, I commented the ticket to get it assigned. Regarding the KIP, I just created a fresh account in Confluence, however, it looks like there are no rights to trigger

[GitHub] [kafka] mimaison commented on a change in pull request #9029: KAFKA-10255: Fix flaky testOneWayReplicationWithAutoOffsetSync test

2020-07-23 Thread GitBox
mimaison commented on a change in pull request #9029: URL: https://github.com/apache/kafka/pull/9029#discussion_r459460614 ## File path: connect/mirror/src/test/java/org/apache/kafka/connect/mirror/MirrorConnectorsIntegrationTest.java ## @@ -62,6 +65,7 @@ private static

[GitHub] [kafka] asdaraujo commented on a change in pull request #8730: KAFKA-10048: Possible data gap for a consumer after a failover when u…

2020-07-23 Thread GitBox
asdaraujo commented on a change in pull request #8730: URL: https://github.com/apache/kafka/pull/8730#discussion_r459536318 ## File path: connect/mirror/src/main/java/org/apache/kafka/connect/mirror/MirrorCheckpointTask.java ## @@ -132,7 +132,7 @@ public String version() {

[GitHub] [kafka] ijuma commented on a change in pull request #9065: KAFKA-10301: Do not clear Partition#remoteReplicasMap during partition assignment updates

2020-07-23 Thread GitBox
ijuma commented on a change in pull request #9065: URL: https://github.com/apache/kafka/pull/9065#discussion_r459563205 ## File path: core/src/main/scala/kafka/cluster/Partition.scala ## @@ -678,11 +678,13 @@ class Partition(val topicPartition: TopicPartition,

[GitHub] [kafka] mjsax commented on a change in pull request #9064: KAFKA-10205: Documentation and handling of non deterministic Topologies

2020-07-23 Thread GitBox
mjsax commented on a change in pull request #9064: URL: https://github.com/apache/kafka/pull/9064#discussion_r459581717 ## File path: streams/src/main/java/org/apache/kafka/streams/StreamsBuilder.java ## @@ -49,6 +49,9 @@ /** * {@code StreamsBuilder} provide the high-level

[jira] [Commented] (KAFKA-10134) High CPU issue during rebalance in Kafka consumer after upgrading to 2.5

2020-07-23 Thread Guozhang Wang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10134?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17163759#comment-17163759 ] Guozhang Wang commented on KAFKA-10134: --- [~zhowei] Did your run include both the log4j improvement

[jira] [Updated] (KAFKA-10301) Partition#remoteReplicasMap can be empty in certain race conditions

2020-07-23 Thread Stanislav Kozlovski (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10301?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stanislav Kozlovski updated KAFKA-10301: Description: In Partition#updateAssignmentAndIsr, we would previously update the

[jira] [Created] (KAFKA-10302) Ensure thread-safe access to Partition#remoteReplicasMap

2020-07-23 Thread Stanislav Kozlovski (Jira)
Stanislav Kozlovski created KAFKA-10302: --- Summary: Ensure thread-safe access to Partition#remoteReplicasMap Key: KAFKA-10302 URL: https://issues.apache.org/jira/browse/KAFKA-10302 Project: Kafka

[GitHub] [kafka] stanislavkozlovski opened a new pull request #9065: KAFKA-10301: Do not clear Partition#remoteReplicasMap during partition assignment updates

2020-07-23 Thread GitBox
stanislavkozlovski opened a new pull request #9065: URL: https://github.com/apache/kafka/pull/9065 We would previously update the map by adding the new replicas to the map and then removing the old ones. During a recent refactoring, we changed the logic to first clear the map and then add

[GitHub] [kafka] ijuma commented on pull request #9065: KAFKA-10301: Do not clear Partition#remoteReplicasMap during partition assignment updates

2020-07-23 Thread GitBox
ijuma commented on pull request #9065: URL: https://github.com/apache/kafka/pull/9065#issuecomment-663069630 ok to test This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [kafka] stanislavkozlovski commented on pull request #9065: KAFKA-10301: Do not clear Partition#remoteReplicasMap during partition assignment updates

2020-07-23 Thread GitBox
stanislavkozlovski commented on pull request #9065: URL: https://github.com/apache/kafka/pull/9065#issuecomment-663088134 Currently working on introducing a test case for this This is an automated message from the Apache Git

[GitHub] [kafka] mjsax commented on a change in pull request #9060: KAFKA-9274: Remove `retries` from InternalTopicManager

2020-07-23 Thread GitBox
mjsax commented on a change in pull request #9060: URL: https://github.com/apache/kafka/pull/9060#discussion_r459577643 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/InternalTopicManager.java ## @@ -96,13 +104,15 @@ public

[GitHub] [kafka] junrao commented on pull request #8657: KAFKA-8334 Make sure the thread which tries to complete delayed reque…

2020-07-23 Thread GitBox
junrao commented on pull request #8657: URL: https://github.com/apache/kafka/pull/8657#issuecomment-663109443 @chia7712: Only 6 test failures in the latest run with your PR.

[jira] [Created] (KAFKA-10301) RemoteReplicasMap can be empty in certain race conditions

2020-07-23 Thread Stanislav Kozlovski (Jira)
Stanislav Kozlovski created KAFKA-10301: --- Summary: RemoteReplicasMap can be empty in certain race conditions Key: KAFKA-10301 URL: https://issues.apache.org/jira/browse/KAFKA-10301 Project:

[jira] [Updated] (KAFKA-10301) Partition#remoteReplicasMap can be empty in certain race conditions

2020-07-23 Thread Stanislav Kozlovski (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10301?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stanislav Kozlovski updated KAFKA-10301: Summary: Partition#remoteReplicasMap can be empty in certain race conditions

[GitHub] [kafka] stanislavkozlovski commented on a change in pull request #9065: KAFKA-10301: Do not clear Partition#remoteReplicasMap during partition assignment updates

2020-07-23 Thread GitBox
stanislavkozlovski commented on a change in pull request #9065: URL: https://github.com/apache/kafka/pull/9065#discussion_r459527097 ## File path: core/src/main/scala/kafka/cluster/Partition.scala ## @@ -678,11 +678,13 @@ class Partition(val topicPartition: TopicPartition,

[jira] [Commented] (KAFKA-10301) Partition#remoteReplicasMap can be empty in certain race conditions

2020-07-23 Thread Stanislav Kozlovski (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17163686#comment-17163686 ] Stanislav Kozlovski commented on KAFKA-10301: - cc [~rhauch] - this would be good to get in

[GitHub] [kafka] mimaison commented on a change in pull request #9007: KAFKA-10120: Deprecate DescribeLogDirsResult.all() and .values()

2020-07-23 Thread GitBox
mimaison commented on a change in pull request #9007: URL: https://github.com/apache/kafka/pull/9007#discussion_r459540733 ## File path: clients/src/main/java/org/apache/kafka/clients/admin/KafkaAdminClient.java ## @@ -2306,6 +2310,22 @@ void handleFailure(Throwable

[GitHub] [kafka] mumrah commented on a change in pull request #9008: KAFKA-9629 Use generated protocol for Fetch API

2020-07-23 Thread GitBox
mumrah commented on a change in pull request #9008: URL: https://github.com/apache/kafka/pull/9008#discussion_r459499911 ## File path: clients/src/main/java/org/apache/kafka/common/protocol/RecordsWriter.java ## @@ -0,0 +1,169 @@ +/* + * Licensed to the Apache Software

[GitHub] [kafka] AshishRoyJava commented on pull request #9034: KAFKA-10246 : AbstractProcessorContext topic() throws NPE

2020-07-23 Thread GitBox
AshishRoyJava commented on pull request #9034: URL: https://github.com/apache/kafka/pull/9034#issuecomment-663066844 @abbccdda Unit test added. This is an automated message from the Apache Git Service. To respond to the

[GitHub] [kafka] dajac commented on a change in pull request #9060: KAFKA-9274: Remove `retries` from InternalTopicManager

2020-07-23 Thread GitBox
dajac commented on a change in pull request #9060: URL: https://github.com/apache/kafka/pull/9060#discussion_r459582710 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/InternalTopicManager.java ## @@ -96,13 +104,15 @@ public

[jira] [Updated] (KAFKA-10301) Partition#remoteReplicasMap can be empty in certain race conditions

2020-07-23 Thread Stanislav Kozlovski (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10301?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stanislav Kozlovski updated KAFKA-10301: Description: In Partition#updateAssignmentAndIsr, we would previously update the

[GitHub] [kafka] stanislavkozlovski commented on pull request #9065: KAFKA-10301: Do not clear Partition#remoteReplicasMap during partition assignment updates

2020-07-23 Thread GitBox
stanislavkozlovski commented on pull request #9065: URL: https://github.com/apache/kafka/pull/9065#issuecomment-663065197 cc @ijuma This is an automated message from the Apache Git Service. To respond to the message, please

[jira] [Created] (KAFKA-10303) kafka producer says connect failed in cluster mode

2020-07-23 Thread Yogesh BG (Jira)
Yogesh BG created KAFKA-10303: - Summary: kafka producer says connect failed in cluster mode Key: KAFKA-10303 URL: https://issues.apache.org/jira/browse/KAFKA-10303 Project: Kafka Issue Type: Bug

[GitHub] [kafka] mimaison commented on pull request #9029: KAFKA-10255: Fix flaky testOneWayReplicationWithAutoOffsetSync test

2020-07-23 Thread GitBox
mimaison commented on pull request #9029: URL: https://github.com/apache/kafka/pull/9029#issuecomment-663094946 While not part of your changes, I noticed the tests assumptions are pretty loose. For example, we assume

[GitHub] [kafka] mjsax commented on pull request #9052: MINOR: TopologyTestDriver should not require dummy parameters

2020-07-23 Thread GitBox
mjsax commented on pull request #9052: URL: https://github.com/apache/kafka/pull/9052#issuecomment-663107263 Only flaky tests failed. I updated the corresponding Jira tickets. This is an automated message from the Apache Git

[jira] [Commented] (KAFKA-9013) Flaky Test MirrorConnectorsIntegrationTest#testReplication

2020-07-23 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9013?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17163749#comment-17163749 ] Matthias J. Sax commented on KAFKA-9013:

[jira] [Commented] (KAFKA-10255) Fix flaky testOneWayReplicationWithAutorOffsetSync1 test

2020-07-23 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17163747#comment-17163747 ] Matthias J. Sax commented on KAFKA-10255: - Two more: *

[GitHub] [kafka] chia7712 edited a comment on pull request #8657: KAFKA-8334 Make sure the thread which tries to complete delayed reque…

2020-07-23 Thread GitBox
chia7712 edited a comment on pull request #8657: URL: https://github.com/apache/kafka/pull/8657#issuecomment-662810186 > Could you rebase again? I will run the system tests after that. Thanks. done. the known flaky ```group_mode_transactions_test.py``` is traced by #9059

[jira] [Commented] (KAFKA-8582) Consider adding an ExpiredWindowRecordHandler to Suppress

2020-07-23 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-8582?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17163770#comment-17163770 ] Matthias J. Sax commented on KAFKA-8582: Added you to the list of contributors and assigned the

[jira] [Assigned] (KAFKA-8582) Consider adding an ExpiredWindowRecordHandler to Suppress

2020-07-23 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-8582?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias J. Sax reassigned KAFKA-8582: -- Assignee: Igor Piddubnyi > Consider adding an ExpiredWindowRecordHandler to Suppress

[jira] [Commented] (KAFKA-10284) Group membership update due to static member rejoin should be persisted

2020-07-23 Thread Sophie Blee-Goldman (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10284?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17163796#comment-17163796 ] Sophie Blee-Goldman commented on KAFKA-10284: - You know, I think we actually hit this too,

[jira] [Commented] (KAFKA-10284) Group membership update due to static member rejoin should be persisted

2020-07-23 Thread Boyang Chen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10284?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17163871#comment-17163871 ] Boyang Chen commented on KAFKA-10284: - [~akshaysh] I didn't see any trace that the group coordinator

[jira] [Updated] (KAFKA-9161) Close gaps in Streams configs documentation

2020-07-23 Thread Sophie Blee-Goldman (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9161?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sophie Blee-Goldman updated KAFKA-9161: --- Fix Version/s: 2.6.0 > Close gaps in Streams configs documentation >

[GitHub] [kafka] ijuma commented on a change in pull request #9065: KAFKA-10301: Do not clear Partition#remoteReplicasMap during partition assignment updates

2020-07-23 Thread GitBox
ijuma commented on a change in pull request #9065: URL: https://github.com/apache/kafka/pull/9065#discussion_r459588501 ## File path: core/src/main/scala/kafka/cluster/Partition.scala ## @@ -678,11 +678,13 @@ class Partition(val topicPartition: TopicPartition,

[jira] [Commented] (KAFKA-10134) High CPU issue during rebalance in Kafka consumer after upgrading to 2.5

2020-07-23 Thread Guozhang Wang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10134?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17163761#comment-17163761 ] Guozhang Wang commented on KAFKA-10134: --- BTW I found that the main latency during rebalance is on

[GitHub] [kafka] mjsax commented on pull request #9064: KAFKA-10205: Documentation and handling of non deterministic Topologies

2020-07-23 Thread GitBox
mjsax commented on pull request #9064: URL: https://github.com/apache/kafka/pull/9064#issuecomment-663113463 Btw: The PR should be against `trunk`. This is an automated message from the Apache Git Service. To respond to the

[GitHub] [kafka] mjsax commented on pull request #9017: KAFKA-8582 [WIP] Add ability to handle late messages in streams-aggregation

2020-07-23 Thread GitBox
mjsax commented on pull request #9017: URL: https://github.com/apache/kafka/pull/9017#issuecomment-663122659 I found your wiki account and granted write access. You should be all set. This is an automated message from the

[jira] [Commented] (KAFKA-10000) Atomic commit of source connector records and offsets

2020-07-23 Thread Ning Zhang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-1?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17163802#comment-17163802 ] Ning Zhang commented on KAFKA-1: Hi Chris, the purpose of this ticket is very interesting. I

[GitHub] [kafka] mjsax commented on pull request #9060: KAFKA-9274: Remove `retries` from InternalTopicManager

2020-07-23 Thread GitBox
mjsax commented on pull request #9060: URL: https://github.com/apache/kafka/pull/9060#issuecomment-663135369 Jenkins failed on know flaky tests only. This is an automated message from the Apache Git Service. To respond to

[jira] [Commented] (KAFKA-7540) Flaky Test ConsumerBounceTest#testClose

2020-07-23 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-7540?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17163803#comment-17163803 ] Matthias J. Sax commented on KAFKA-7540:

[jira] [Commented] (KAFKA-10255) Fix flaky testOneWayReplicationWithAutorOffsetSync1 test

2020-07-23 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17163804#comment-17163804 ] Matthias J. Sax commented on KAFKA-10255: - And one more: 

[GitHub] [kafka] soondenana commented on a change in pull request #9054: KAFKA-10282: Remove Log metrics immediately when deleting log

2020-07-23 Thread GitBox
soondenana commented on a change in pull request #9054: URL: https://github.com/apache/kafka/pull/9054#discussion_r459603473 ## File path: core/src/main/scala/kafka/log/LogManager.scala ## @@ -1151,6 +1144,12 @@ class LogManager(logDirs: Seq[File], } } } + +

[GitHub] [kafka] abbccdda commented on a change in pull request #8512: KAFKA-6024: Consider moving validation in KafkaConsumer ahead of call to acquireAndEnsureOpen()

2020-07-23 Thread GitBox
abbccdda commented on a change in pull request #8512: URL: https://github.com/apache/kafka/pull/8512#discussion_r459648674 ## File path: clients/src/main/java/org/apache/kafka/clients/consumer/KafkaConsumer.java ## @@ -1388,9 +1388,9 @@ public void commitSync() { */

[GitHub] [kafka] stanislavkozlovski commented on a change in pull request #9065: KAFKA-10301: Do not clear Partition#remoteReplicasMap during partition assignment updates

2020-07-23 Thread GitBox
stanislavkozlovski commented on a change in pull request #9065: URL: https://github.com/apache/kafka/pull/9065#discussion_r459596274 ## File path: core/src/main/scala/kafka/cluster/Partition.scala ## @@ -678,11 +678,13 @@ class Partition(val topicPartition: TopicPartition,

[GitHub] [kafka] stanislavkozlovski commented on a change in pull request #9065: KAFKA-10301: Do not clear Partition#remoteReplicasMap during partition assignment updates

2020-07-23 Thread GitBox
stanislavkozlovski commented on a change in pull request #9065: URL: https://github.com/apache/kafka/pull/9065#discussion_r459599939 ## File path: core/src/main/scala/kafka/cluster/Partition.scala ## @@ -678,11 +678,13 @@ class Partition(val topicPartition: TopicPartition,

[GitHub] [kafka] mjsax commented on pull request #9060: KAFKA-9274: Remove `retries` from InternalTopicManager

2020-07-23 Thread GitBox
mjsax commented on pull request #9060: URL: https://github.com/apache/kafka/pull/9060#issuecomment-663134416 Only the `StreamsStandbyTask.test_standby_tasks_rebalance` system test failed and it's know to be buggy. This is

[GitHub] [kafka] ning2008wisc commented on pull request #9029: KAFKA-10255: Fix flaky testOneWayReplicationWithAutoOffsetSync test

2020-07-23 Thread GitBox
ning2008wisc commented on pull request #9029: URL: https://github.com/apache/kafka/pull/9029#issuecomment-663147296 totally agree that it may be better to revisit the tests in MM2 and I created a ticket https://issues.apache.org/jira/browse/KAFKA-10304 and assign it to myself.

[jira] [Created] (KAFKA-10304) Revisit and improve the tests of MirrorMaker 2

2020-07-23 Thread Ning Zhang (Jira)
Ning Zhang created KAFKA-10304: -- Summary: Revisit and improve the tests of MirrorMaker 2 Key: KAFKA-10304 URL: https://issues.apache.org/jira/browse/KAFKA-10304 Project: Kafka Issue Type: Test

[GitHub] [kafka] stanislavkozlovski commented on a change in pull request #9065: KAFKA-10301: Do not clear Partition#remoteReplicasMap during partition assignment updates

2020-07-23 Thread GitBox
stanislavkozlovski commented on a change in pull request #9065: URL: https://github.com/apache/kafka/pull/9065#discussion_r459645411 ## File path: core/src/test/scala/unit/kafka/cluster/PartitionLockTest.scala ## @@ -116,6 +117,56 @@ class PartitionLockTest extends Logging {

[GitHub] [kafka] jeffkbkim commented on a change in pull request #9050: KAFKA-10193: Add preemption for controller events that have callbacks

2020-07-23 Thread GitBox
jeffkbkim commented on a change in pull request #9050: URL: https://github.com/apache/kafka/pull/9050#discussion_r459647273 ## File path: core/src/test/scala/unit/kafka/controller/ControllerIntegrationTest.scala ## @@ -598,6 +603,86 @@ class ControllerIntegrationTest extends

[GitHub] [kafka] stanislavkozlovski commented on a change in pull request #9065: KAFKA-10301: Do not clear Partition#remoteReplicasMap during partition assignment updates

2020-07-23 Thread GitBox
stanislavkozlovski commented on a change in pull request #9065: URL: https://github.com/apache/kafka/pull/9065#discussion_r459598439 ## File path: core/src/test/scala/unit/kafka/cluster/PartitionLockTest.scala ## @@ -116,6 +117,56 @@ class PartitionLockTest extends Logging {

[GitHub] [kafka] ijuma commented on pull request #9065: KAFKA-10301: Do not clear Partition#remoteReplicasMap during partition assignment updates

2020-07-23 Thread GitBox
ijuma commented on pull request #9065: URL: https://github.com/apache/kafka/pull/9065#issuecomment-663130390 ok to test This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [kafka] ijuma commented on a change in pull request #9065: KAFKA-10301: Do not clear Partition#remoteReplicasMap during partition assignment updates

2020-07-23 Thread GitBox
ijuma commented on a change in pull request #9065: URL: https://github.com/apache/kafka/pull/9065#discussion_r459607476 ## File path: core/src/test/scala/unit/kafka/utils/PoolTest.scala ## @@ -0,0 +1,41 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one or

[jira] [Commented] (KAFKA-10255) Fix flaky testOneWayReplicationWithAutorOffsetSync1 test

2020-07-23 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17163807#comment-17163807 ] Matthias J. Sax commented on KAFKA-10255: -

[GitHub] [kafka] mjsax commented on pull request #9047: KAFKA-9274: Remove `retries` for global task

2020-07-23 Thread GitBox
mjsax commented on pull request #9047: URL: https://github.com/apache/kafka/pull/9047#issuecomment-663136110 Flaky tests only. This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [kafka] ijuma commented on a change in pull request #9065: KAFKA-10301: Do not clear Partition#remoteReplicasMap during partition assignment updates

2020-07-23 Thread GitBox
ijuma commented on a change in pull request #9065: URL: https://github.com/apache/kafka/pull/9065#discussion_r459616154 ## File path: core/src/test/scala/unit/kafka/cluster/PartitionLockTest.scala ## @@ -116,6 +117,56 @@ class PartitionLockTest extends Logging {

  1   2   >