Re: Null provider and failing early

I think they should be ignored, but preserved. On Tue, Aug 27, 2013 at 11:40 AM, Tim Penhey tim.pen...@canonical.com wrote: On 27/08/13 11:50, Andrew Wilkins wrote: On Tue, Aug 27, 2013 at 8:44 AM, Tim Penhey tim.pen...@canonical.com mailto:tim.pen...@canonical.com wrote: Perhaps we

Re: Focus for the next three weeks

Sorry to add more wood to the pile, but 1.14.0 needs to go out, basically now. https://launchpad.net/juju-core/+milestone/1.14.0 Shows three issues (one is merged on trunk, but needs backporting) On Tue, Sep 10, 2013 at 1:39 PM, Tim Penhey tim.pen...@canonical.com wrote: Hi folks, Lets start

1.15.0 release this week ?

Hello, What is the temperature of folks about doing a 1.15.0 release this week ? My spider senses make me think it is worth more time to bed down the tools changes. Thoughts ? Dave -- Juju-dev mailing list Juju-dev@lists.ubuntu.com Modify settings or unsubscribe at:

Juju 1.14.0 draft release notes

https://docs.google.com/a/canonical.com/document/d/1PNtuwad70FrbtdyA0Wx4-yKLGGguA7P62sa_Bfsfi7U/edit# Waiting on the final 1.14.0 issues to be resolved before we can push this to Jamespage for Saucy. -- Juju-dev mailing list Juju-dev@lists.ubuntu.com Modify settings or unsubscribe at:

Re: 1.14 doesn't actually build

Only goose and juju-core have tags. If you add a tag to gwacl, please update scripts/build-release-tarball/build-release-tarball.sh On Tue, Sep 17, 2013 at 8:07 AM, Ian Booth ian.bo...@canonical.com wrote: Surely when we tag a release, we also tag the matching revisions of all the dependencies?

Re: Consistent test failures with saucy

Have a hunt in the code, i bet there is something that lists all the series from P through to R, but doesn't include saucy, possibly in fixtures or the dummy provider On Mon, Sep 30, 2013 at 9:31 AM, Tim Penhey tim.pen...@canonical.com wrote: Hi folks, Most of the upgrade worked fine. I am

Re: Basic Juju-Core CI is up

THIS IS GREAT! I especially like the fact I don't need 2fa or a million ssh tunnels to view the build status. Kudos for developing in the open. On Wed, Nov 13, 2013 at 7:13 AM, Curtis Hovey-Canonical cur...@canonical.com wrote: We have established basic CI of juju-core. The jenkin's instance is

Re: Synchronous Bootstrap

\o/ On Tue, Dec 3, 2013 at 5:31 PM, Andrew Wilkins andrew.wilk...@canonical.com wrote: Ahoy, Just wanted to inform everyone that synchronous bootstrap has landed on trunk. If you've got any scripts that bootstrap an environment and expect it to chug away in the background, then some script

juju bootstrap w/ gccgo built cli and tools

Good news, everyone! We are ---this--- close to getting a gccgo build juju working. lucky(~/src/launchpad.net/juju-core) % juju bootstrap -v --upload-tools verbose is deprecated with the current meaning, use show-log 2013-12-05 05:57:50 INFO juju.environs open.go:156 environment info already

Re: juju bootstrap w/ gccgo built cli and tools

On Fri, Dec 6, 2013 at 3:39 PM, John Arbash Meinel j...@arbash-meinel.com wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 2013-12-06 6:24, David Cheney wrote: Ok, good news first. gccgo compiled tools work fine. statically linking libgo also makes the tools as self contained

saucy images on hp cloud

Hello, I am trying to deploy a saucy machine (via the ubuntu charm) on hp cloud. lucky(~/src/launchpad.net/juju-core) % juju deploy -v --repository=$HOME/charms local:saucy/ubuntu verbose is deprecated with the current meaning, use show-log 2014-02-04 01:33:46 INFO juju api.go:231 connecting to

Re: saucy images on hp cloud

an updated stream. -thanks, Antonio Rosales On Tue, Feb 4, 2014 at 3:37 AM, David Cheney david.che...@canonical.com wrote: Hello, I am trying to deploy a saucy machine (via the ubuntu charm) on hp cloud. lucky(~/src/launchpad.net/juju-core) % juju deploy -v --repository=$HOME/charms

Re: MySQL charm: hook failed: config-changed

I don't think this is related to the amount of memory provided, especially as Daniele is using the local provider. 2014-02-03 16:07:23 INFO juju.worker.uniter context.go:255 HOOK Unable to open /sys/kernel/security/apparmor/.replace - Permission denied 2014-02-03 16:07:23 INFO juju.worker.uniter

Re: MySQL charm: hook failed: config-changed

, 2014 at 9:30 AM, David Cheney david.che...@canonical.comwrote: https://bugs.launchpad.net/juju-core/+bug/1236994 is a dup of https://bugs.launchpad.net/juju-core/+bug/1247299, both of which are claimed to be resolved. Daniele, if this is still a problem with the latest development release

Re: saucy images on hp cloud

Hi Antonio, Do you have an ETA or a ticket number for this issue ? Cheers Dave On Wed, Feb 5, 2014 at 3:09 PM, David Cheney david.che...@canonical.comwrote: Hi Antonio, Do you have an ETA or a ticket number for this issue ? Cheers Dave On Wed, Feb 5, 2014 at 7:45 AM, David

Re: no log tests

Hi Rog, I tried this but it causes unrelated test failures as tests which scan for output now no longer find anything as the global log level is raised to ERROR. Maybe this is a bug. Cheers Dave On Thu, Mar 27, 2014 at 8:21 AM, roger peppe rogpe...@gmail.com wrote: Alternatively you can

Go 1.3 beta can build Juju

Hello, Go 1.3 beta will ship this week, or at some point before the conference on the 24th. For a long time Go 1.3 beta could not build Juju properly, the tests would crash the runtime and other strange issues. I've been able to work with the upstream to provide them with a working trusty image

Re: Go 1.3 beta can build Juju

On Thu, Apr 17, 2014 at 11:22 AM, Tim Penhey tim.pen...@canonical.com wrote: On 17/04/14 13:20, David Cheney wrote: Hello, Go 1.3 beta will ship this week, or at some point before the conference on the 24th. For a long time Go 1.3 beta could not build Juju properly, the tests would crash

Re: Go 1.3 beta can build Juju

On Thu, Apr 17, 2014 at 11:24 AM, Tim Penhey tim.pen...@canonical.com wrote: On 17/04/14 13:24, David Cheney wrote: On Thu, Apr 17, 2014 at 11:22 AM, Tim Penhey tim.pen...@canonical.com wrote: On 17/04/14 13:20, David Cheney wrote: Hello, Go 1.3 beta will ship this week, or at some point

Re: juju 1.20.0 and future plans.

Excellent writeup. I agree with your conclusions -- we must reduce the number of open issues, not reclassify them. My vote has always been to close an issue that we cannot realistically fix in the next cycle, but I understand this has always been unpopular. On Fri, Apr 18, 2014 at 5:47 AM, Curtis

Re: utils/ssh updates

On Sun, Apr 27, 2014 at 8:19 AM, Martin Packman martin.pack...@canonical.com wrote: I've poked utils/ssh a bit during gophercon. Unfortuately the update to use tip of go.crypto can't land right now as it requires a couple of standard library crypto bits that go 1.1.2 lacks. Perhaps we can

Re: Preferred wrapping for long function declarations

I don't want to have this bikeshed - I vote for people to use their best judgement and permit anything which fits through gofmt. On Tue, May 13, 2014 at 3:37 PM, John Meinel j...@arbash-meinel.com wrote: In the risk of running a bikeshedding paint-fest, I'm curious what the best-recommended

Re: Making juju work better with gccgo

Thanks Tim, I think we're in the position that even if you don't use gccgo for your own development (understandable, it is slower), now that we have platforms we support in Trusty that must use gccgo, armv8 and ppc64el, for any new development, the code has to pass under both compilers. This is

Re: [Proposal] Requiring Go 1.2 across the board

Wilkins andrew.wilk...@canonical.com wrote: On Fri, May 16, 2014 at 3:08 PM, David Cheney david.che...@canonical.com wrote: Hello, This is a proposal that we raise the minimum Go spec from Go 1.1 to Go 1.2. Motivation: * Now that T is out, we have to support Juju on two series (Precise

What is required to switch back to using the tip of goose ?

Why is the Openstack provider pinned to an old version of lauchpad.net/goose ? What is required to use the latest version ? -- Juju-dev mailing list Juju-dev@lists.ubuntu.com Modify settings or unsubscribe at: https://lists.ubuntu.com/mailman/listinfo/juju-dev

Re: What is required to switch back to using the tip of goose ?

to do so. I believe it is a 3 character fix for Get() but I haven't really tested the rest. John =:- On Fri, May 16, 2014 at 12:47 PM, David Cheney david.che...@canonical.com wrote: Why is the Openstack provider pinned to an old version of lauchpad.net/goose ? What is required to use

Re: What is required to switch back to using the tip of goose ?

Oh yes, we are talking about the same thing. I'll propose a branch On Fri, May 16, 2014 at 7:50 PM, David Cheney david.che...@canonical.com wrote: There also appears to be a small API breakage # launchpad.net/juju-core/provider/openstack provider/openstack/storage.go:59: assignment count

Re: What is required to switch back to using the tip of goose ?

FYI. This change has landed, please do the godeps dance. On Fri, May 16, 2014 at 7:54 PM, David Cheney david.che...@canonical.com wrote: Oh yes, we are talking about the same thing. I'll propose a branch On Fri, May 16, 2014 at 7:50 PM, David Cheney david.che...@canonical.com wrote

Re: store migration

On Tue, May 20, 2014 at 11:55 PM, Francesco Banconi francesco.banc...@canonical.com wrote: Hi all, FYI this morning the UI team discussed about possibile paths to migrate the store code from lp:juju-core to Github. We are sharing this plan so that we can synchronize/collaborate with other

Re: (not) using loggo in github.com/juju/errgo

SGTM. https://github.com/juju/errgo/pull/6 On Tue, May 20, 2014 at 10:06 PM, John Meinel j...@arbash-meinel.com wrote: I'm fine having our split out packages depend on each other where it is actually useful (errors clearly depends on errgo), but it does sound like loggo isn't a very strong

Re: store migration

With regard to the thirdparty package in core, I don't see that we need it any more. The only thing in it is pbkdf2, which is available from go.crypto which we import from anyway for ssh authorised keys functionality. So I say we nuke it. I'm going to fix this right now. -- Juju-dev

Re: (not) using loggo in github.com/juju/errgo

This has been done. github.com/juju/errgo no longer has a dependency on github.com/juju/loggo On Wed, May 21, 2014 at 7:39 AM, David Cheney david.che...@canonical.com wrote: SGTM. https://github.com/juju/errgo/pull/6 On Tue, May 20, 2014 at 10:06 PM, John Meinel j...@arbash-meinel.com wrote

Re: moving bzr wip branch to git

Nice On Wed, Jun 4, 2014 at 2:08 PM, Jesse Meek jesse.m...@canonical.com wrote: So the command that worked for me (thanks for the help Tim) was: ~/go/src/github.com/juju/juju$ (cd ~/go/src/launchpad.net/juju-core bzr diff --color=never -r ancestor::parent) | patch -p0 --merge -- Juju-dev

Re: Juju is on github

Make it so On Thu, Jun 5, 2014 at 6:59 AM, Menno Smits menno.sm...@canonical.com wrote: On 5 June 2014 06:58, Jorge Niedbalski jorge.niedbal...@canonical.com wrote: 2cents: Why not rename the CONTRIBUTING file to CONTRIBUTING.md so it will be rendered as a markdown file by github? That

Re: End Of Review marker

Rietveld also supports git On Thu, Jun 12, 2014 at 8:46 PM, Ian Booth ian.bo...@canonical.com wrote: It's also the same when you are responding to review comments. You want to mark them all as Done (or whatever) and have those go out in a batch to let the reviewer know they can come back and

Re: Splitting out state/api into its own repo

On Fri, Jun 27, 2014 at 4:21 PM, John Meinel j...@arbash-meinel.com wrote: Just my quick thought, I think moving it out from state/api into just a top level api would be reasonable and a lot less clumsy than trying to pull it out into an entirely separate repository. +1 I don't think the api

Re: Landing bot job changed

Additionally, the bot is no longer reporting back to the PR that the build failed to merge. On Mon, Jul 7, 2014 at 11:11 AM, David Cheney david.che...@canonical.com wrote: The lander is broken + exit 0 All passed, sending merge /tmp/hudson6791049747065303228.sh: line 44: /home/ubuntu

Conditional compilation primer

Hello, Tim asked me to circulate this to aide those who have to review code that deals with conditional compilation. http://dave.cheney.net/2013/10/12/how-to-use-conditional-compilation-with-the-go-build-tool Cheers Dave -- Juju-dev mailing list Juju-dev@lists.ubuntu.com Modify settings or

Re: Can we get rid of the hash(password) dance?

Yes, please! On Thu, Jul 17, 2014 at 2:49 PM, John Meinel j...@arbash-meinel.com wrote: Michael is working on changing how we handle sessions with Mongo, and noticed that his first attempt started running into Auth failures. It turned out that this was because of the hash(password) dance. (For

Possible landing bot issues

Hello, I think there are two problems with the current landing bot. 1. the bot doesn't appear to NACK changes that are not gofmt'd, this means changes land which others cannot fix because their .gitconfig prevents them. 2. the bot doesn't appear to be enforcing it's lockdown rules as the

Re: Possible landing bot issues

I managed to sneak one in an hour ago, is the fix live ? On Thu, Jul 31, 2014 at 10:18 AM, Ian Booth ian.bo...@canonical.com wrote: I think there are two problems with the current landing bot. Thanks for raising the issues. 1. the bot doesn't appear to NACK changes that are not gofmt'd,

apiserver/testing.FakeAuthoriser is not a good mock

Hello, This message serves as background to a series of changes coming soon. The goal of this message, and the changes that follow, is to describe the problems that I see with the FakeAuthoriser and a describe in general terms the steps I propose to address those shortcomings. Background: The

Re: apiserver/testing.FakeAuthoriser is not a good mock

On Thu, Jul 31, 2014 at 5:12 PM, William Reade william.re...@canonical.com wrote: On Thu, Jul 31, 2014 at 7:30 AM, David Cheney david.che...@canonical.com wrote: Proposal: remove Authoriser.GetAuthEntity() and replace all calls with Authoriser.GetAuthTag(). I have a branch for this, it's 30

CI tests are installing Juju on the CI machine ...

Creating config file /etc/mercurial/hgrc.d/hgext.rc with new version Setting up zip (3.0-4) ... Setting up juju-core (1.20.1-0ubuntu1~12.04.1~juju1) ... update-alternatives: using /usr/lib/juju-1.20.1/bin/juju to provide /usr/bin/juju (juju) in auto mode. Setting up rsyslog-gnutls

Re: Port ranges - restricting opening and closing ranges

Yes, absolutely. On Tue, Aug 5, 2014 at 8:33 PM, Domas Monkus domas.mon...@canonical.com wrote: A follow-up question: should closing a port that was not opened previous to that result in an error? Domas On Fri, Jun 27, 2014 at 2:13 PM, Matthew Williams matthew.willi...@canonical.com

Re: avoiding unnecessarily entering upgrade mode

SGTM. On Wed, Aug 6, 2014 at 11:10 AM, Menno Smits menno.sm...@canonical.com wrote: Right now, a Juju machine agent is in upgrade mode from the moment it starts until the upgrade-steps worker is finished. During this period API logins are heavily restricted and most of the agent's workers

Re: Label: Ready For Review

, David Cheney david.che...@canonical.com wrote: How can we remove the label once the review has been done ? On Tue, Aug 12, 2014 at 4:33 AM, Nate Finch nate.fi...@canonical.com wrote: I made a label on github.com/juju/juju (and coincidentally github.com/juju/utils) called Ready For Review

Re: getting rid of all-machines.log

Ian asked me to post my thoughts here. I am not in favour of applications rolling their own logs, I believe that applications should not know anything about their log output, they should just dump it all to stdout and another process should take care of shuttling the data, logging it, culling it,

Re: Juju trunk now is compatible with Mongo 2.6

Will CI failures using mongodb-2.6 be considered critical and block the build ? On Fri, Aug 15, 2014 at 10:07 AM, Ian Booth ian.bo...@canonical.com wrote: A little while back we started work as a background task to port Juju to work with Mongo 2.6. After a final push from Andrew to get

Re: First customer pain point pull request - default-hook

Nope, still not receiving you clearly On Mon, Aug 18, 2014 at 7:20 AM, Tim Penhey tim.pen...@canonical.com wrote: -BEGIN PGP MESSAGE- Charset: windows-1252 Version: GnuPG v1 hQIMA233D38ktbXXAQ/+OxwEOmqX/SS+lyJGh7WBYOZge3P8G9+bdu0u8v/sGioD

Re: getting rid of all-machines.log

Hi Horatio, I don't see a way to resolve the very disparate set of opinions you've highlighted below. It's also not clear from your email who is responsible for making a decision. I suggest reframing the discussion as user stories. ie * As a Juju user with a Windows workstation I want to use

Re: getting rid of all-machines.log

On Wed, Aug 27, 2014 at 3:04 PM, Ian Booth ian.bo...@canonical.com wrote: On 27/08/14 14:56, John Meinel wrote: My personal vote would be: a) Use something that can write directly to multiple syslog receivers over a TLS encrypted connection from inside the jujud binary (e.g. don't use

Re: gccgo internal compiler errors

nah, we have a fix upstream, we just need to get that backported to trusty then this becomes a non issue. On Fri, Aug 29, 2014 at 7:44 PM, Matthew Williams matthew.willi...@canonical.com wrote: As it's something we need to be doing for a while yet is there value in adding this as a task that

State should not depend on the API server

Hello, This is an introductory email to explain my upcoming series of pull requests. The theme is simple: state must not depend on the api server. This is currently not true, state depends on api/params because some of the api types have leaked into the state package and are being directly

Re: State should not depend on the API server

in the Agents/Clients. John =:- On Mon, Sep 1, 2014 at 9:40 AM, David Cheney david.che...@canonical.com wrote: Hello, This is an introductory email to explain my upcoming series of pull requests. The theme is simple: state must not depend on the api server. This is currently not true

Re: Logger prefixes for api/apiserver are changing

Wow. I'm sorry I broke that, it didn't even occur to me. I wonder if there is a better way to handle this default case of the name of the logger follows the package path), ie var logger = loggo.Logger() // or something, it could be a new method, logger.Default(), or something. which will

Re: Logger prefixes for api/apiserver are changing

I'll take thumper's temperature for this feature at the standup and see what he thinks. On Wed, Sep 3, 2014 at 12:30 AM, Eric Snow eric.s...@canonical.com wrote: On Tue, Sep 2, 2014 at 5:07 AM, David Cheney david.che...@canonical.com wrote: I wonder if there is a better way to handle

Re: Copyright information in headers

I think this is needless busy work, I vote that as long as there is a copyright header with _a_ year, that is sufficient. On Thu, Sep 4, 2014 at 7:50 AM, Ian Booth ian.bo...@canonical.com wrote: Hi folks The question recently came up in reviews as to whether we should be updating the date

Re: A beginner's adventure in Charm authoring

On Fri, Sep 5, 2014 at 5:04 AM, Nate Finch nate.fi...@canonical.com wrote: given that we currently use the path, you can't have one charm for multiple series anyway. For deploying local: charms, symlinks work fine here. This would at least be better than what we have right now, and would be

Re: ReviewBoard is now the official review tool for juju

Is there a setting to make reviewboard show the diff in a review by the default ? For some reason for me it always requires me to hit the 'view diff' link. On Tue, Sep 16, 2014 at 6:39 AM, Ian Booth ian.bo...@canonical.com wrote: On 16/09/14 00:50, Eric Snow wrote: On Mon, Sep 15, 2014 at

Re: State should not depend on the API server

On Tue, Sep 16, 2014 at 7:59 PM, William Reade william.re...@canonical.com wrote: On Thu, Sep 11, 2014 at 3:35 PM, Nate Finch nate.fi...@canonical.com wrote: I don't see how having different identical structs that are updated simultaneously in any way prevents any problems with compatibility.

Re: ReviewBoard is now the official review tool for juju

On Tue, Sep 16, 2014 at 7:27 PM, roger peppe roger.pe...@canonical.com wrote: On 16 September 2014 09:22, Jonathan Aquilina jaquil...@eagleeyet.net wrote: If i am not mistaken if you have multiple commits in a branch git has something built in called git squash. This obviously eliminates the 5

Re: Doing chained diffs w/ Reviewboard

+1 to that On Thu, Sep 18, 2014 at 7:53 PM, Adam Collard adam.coll...@canonical.com wrote: On 18 September 2014 10:49, John Meinel j...@arbash-meinel.com wrote: Has anyone succeeded in getting this to work? The steps I tried to do were: git co master git pull upstream master git co

Re: Doing chained diffs w/ Reviewboard

, David Cheney david.che...@canonical.com wrote: +1 to that On Thu, Sep 18, 2014 at 7:53 PM, Adam Collard adam.coll...@canonical.com wrote: On 18 September 2014 10:49, John Meinel j...@arbash-meinel.com wrote: Has anyone succeeded in getting this to work? The steps I tried to do were: git co

Re: Is ReviewBoard a good thing?

There were three problem reviewboard was supposed to address, review comments are sent immediately, no side by side diffs, and no way to to chained proposals. I think that over the last few months we've all learnt to live with the first issue On the second, github now does nice side by side

Re: Is ReviewBoard a good thing?

On Sat, Sep 20, 2014 at 1:02 AM, Eric Snow eric.s...@canonical.com wrote: On Thu, Sep 18, 2014 at 6:32 PM, David Cheney david.che...@canonical.com wrote: There were three problem reviewboard was supposed to address, review comments are sent immediately, no side by side diffs, and no way

Re: psa pls don't use transactions for single doc unobserved atomic updates

Hi Kapil, I'm sure that the 'put everything in a transaction' pattern is applied unilaterally. Do you have some specific operations in mind ? Dave On Mon, Sep 22, 2014 at 7:46 AM, Kapil Thangavelu kapil.thangav...@canonical.com wrote: Its sort of misses the point on why we're doing client

Re: Versioned packages and testing dependencies

John, Roger, This situation right here is why I am strongly opposed to the gopkg.in versioning model. I recommend reverting to the original launchpad location. Dave On Mon, Sep 22, 2014 at 9:56 PM, roger peppe roger.pe...@canonical.com wrote: That's an interesting observation and I think I

Is there a setting in ReviewBoard to let me see *both* the comments and the diffs

Hi Reviewboard is driving me nuts. Either it can't do this, or I have put it in some mode where it does this, but it can only show me the review comments *OR* the diff, but not both. Is there a setting that shows both diffs and the stream of review comments _on_the_same_screen ? Dave --

Re: how to update dependencies.tsv

Does your $GOPATH include more than one entry ? The make target should probably just expect godeps to be in your $PATH. On Wed, Oct 29, 2014 at 6:37 PM, Dimiter Naydenov dimiter.nayde...@canonical.com wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 +1, in fact there is already a

Re: Please stop adding dependencies to the state package

This is https://bugs.launchpad.net/juju-core/+bug/1392520 I have assigned it to myself. On Fri, Nov 14, 2014 at 10:33 AM, Eric Snow eric.s...@canonical.com wrote: On Thu, Nov 13, 2014 at 4:05 PM, David Cheney david.che...@canonical.com wrote: Hello, Please stop adding dependencies

Re: Too space, or not two space

To quote Butterick's http://practicaltypography.com/one-space-between-sentences.html I think two spaces look bet­ter so that’s what I’m go­ing to use. I’m telling you the rule. If you want to put per­sonal taste ahead of the rule, I can’t stop you. But per­sonal taste doesn’t make the rule

Re: Too space, or not two space

I think you guys have more things to worry about than the spacing style for comments. I'm happy to let this discussion die at this point. -- Juju-dev mailing list Juju-dev@lists.ubuntu.com Modify settings or unsubscribe at: https://lists.ubuntu.com/mailman/listinfo/juju-dev

Re: git clients vulnerability found

Fortunately all of us run an operating system with a case sensitive file system, right ? On Fri, Dec 19, 2014 at 8:32 AM, Horacio Duran horacio.du...@canonical.com wrote: Heads up people https://github.com/blog/1938-vulnerability-announced-update-your-git-clients apparently there is a

Re: separating out golang juju client from

There is no reason for the 130 (at last count) packages that constitute juju-core (not counting the dozens of other packages we bring in as dependencies) to live in the same repository. If licensing is the lever that we use to break up this monolithic repository, consider me +1 On Fri, Dec 19,

What are blocks ?

Hello, Can someone direct me to the design documents for the enigmatic 'block' functionality which is showing up in the review queue. Thanks Dave -- Juju-dev mailing list Juju-dev@lists.ubuntu.com Modify settings or unsubscribe at: https://lists.ubuntu.com/mailman/listinfo/juju-dev

Re: Testing on windows

It is clear that we need blocking CI jobs for Windows and CentOS -- has this been added to the Nuremberg agenda ? On Thu, Mar 19, 2015 at 10:24 PM, Gabriel Samfira gsamf...@cloudbasesolutions.com wrote: On 19.03.2015 12:07, Michael Foord wrote: Do all tests pass (or skip) on Windows now? Do we

Re: Proposal: move package replicaset to its own GitHub repo

Do it! On Wed, Mar 25, 2015 at 9:22 PM, Nate Finch nate.fi...@canonical.com wrote: +100, thanks for doing this, Andrew! On Wed, Mar 25, 2015 at 6:16 AM, roger peppe roger.pe...@canonical.com wrote: This seems like a grand plan to me. On 25 March 2015 at 08:12, Andrew Wilkins

Re: Public Service Annoucement

Why doesn't the bot run this hook ? On Fri, Apr 24, 2015 at 9:54 PM, Matthew Williams matthew.willi...@canonical.com wrote: There's a very useful pre-push hook available for juju that does useful things like run gofmt, go vet, checks we can build etc. If you don't have it setup there's some

Re: Public Service Annoucement

if it changed things. (As I understand it) John =:- On Fri, Apr 24, 2015 at 3:56 PM, David Cheney david.che...@canonical.com wrote: Why doesn't the bot run this hook ? On Fri, Apr 24, 2015 at 9:54 PM, Matthew Williams matthew.willi...@canonical.com wrote: There's a very useful pre-push hook

linux/arm64 benchmark improvements

Hello, Here are the results of the work Aram and I did last week on improving the performance of our arm64 port of Go. This is comparing the build from April 06 (before we started) to today (April 16th). http://paste.ubuntu.com/10831430/ Cheers Dave -- Juju-dev mailing list

Please run your tests with -race

Hello, TL;DR - juju has lots of problems with data races, please test your code with the -race flag to ensure it doesn't get worse while we try to fix the problem. Longer version: In debugging https://bugs.launchpad.net/bugs/1456398 I found that there are multiple data races in the Juju code

Re: Please run your tests with -race

that as folks are writing tests in packages, races in at least that file, an possibly that package should be fixed. Tim On 21/05/15 12:12, David Cheney wrote: Hello, TL;DR - juju has lots of problems with data races, please test your code with the -race flag to ensure it doesn't get worse while we

Re: I'm concerned

This should be achievable. go test sends SIGQUIT on timeout, we can setup a SIGQUIT handler in the topmost suite (or import it as a side effect package), do whatever cleanup is needed, then os.Exit, unhandle the signal and try to send SIGQUIT to ourselves, or just panic. On Wed, Jun 17, 2015 at

Re: Pointer Receivers on Error() and String() methods

Yup, I agree with Rog. This is fixing the problem in the wrong place. On Mon, Aug 24, 2015 at 5:14 PM, roger peppe roger.pe...@canonical.com wrote: I'm afraid I'm not convinced. Declaring the Error method on the pointer receiver is idiomatic (just grep for ' Error\(' in the Go source) and is a

Re: ppc64le timeouts cursing things

On Fri, Jul 17, 2015 at 5:08 AM, Dimiter Naydenov dimiter.nayde...@canonical.com wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 17.07.2015 12:07, James Tunnicliffe wrote: /me opens can of worms Thanks for starting the discussion :) Having spent perhaps too long trying to

version.Current changes

Hello, This is an informational message to explain the recent changes to version.Current. version.Current used to be a version.Binary value consisting of the version number, an architecture and a series value. As of this afternoon, version.Current is now a version.Number value; series and arch

Re: Cheryl graduating

Congratulations Cheryl! On Tue, Sep 1, 2015 at 11:46 AM, Tim Penhey wrote: > Hi folks, > > I have been very happy with the quality of Cheryl's reviews and the time > is right for her to be considered a fully graduated reviewer. > > Thanks for all the reviews Cheryl. > >

Re: Upgrading minimum Go version?

Martin: Can you setup a unit test job that uses Go 1.5 ? I will apply the same process I did for the -race job, to get the build voting, then reenable the tests that were skipped. On Fri, Nov 27, 2015 at 12:24 AM, Martin Packman wrote: > On 26/11/2015, Andrew

Re: utils/fslock needs to DIAF

to develop a lock type that does the best available for each platform using conditional compilation. On Tue, Dec 1, 2015 at 11:47 AM, Andrew Wilkins <andrew.wilk...@canonical.com> wrote: > On Tue, Dec 1, 2015 at 8:03 AM David Cheney <david.che...@canonical.com> > wrote: >>

Re: utils/fslock needs to DIAF

Doesn't look like there is windows support, and it uses fcntl (flock) under the hood, which is what we have now. On Tue, Dec 1, 2015 at 10:55 AM, Casey Marshall wrote: > How about github.com/camlistore/lock ? > > On Mon, Nov 30, 2015 at 5:43 PM, Tim Penhey

Reviews for merges _from_ master to feature branches

Hello, Why are reviewers being created for merges from master to feature branches ? What purpose does this serve ? Thanks Dave -- Juju-dev mailing list Juju-dev@lists.ubuntu.com Modify settings or unsubscribe at: https://lists.ubuntu.com/mailman/listinfo/juju-dev

Re: utils/fslock needs to DIAF

On Tue, Dec 1, 2015 at 10:43 AM, Tim Penhey wrote: > Hi folks, > > The fslock was a mistake that I added to the codebase some time back. It > provided an overly simplistic solution to a more complex problem. > > Really the filesystem shouldn't be used as a locking

Re: utils/fslock needs to DIAF

Please no. The better way is to use an abstract unix domain socket to create a mutex. On Tue, Dec 1, 2015 at 10:56 AM, Andrew Wilkins wrote: > On Tue, Dec 1, 2015 at 7:43 AM Tim Penhey wrote: >> >> Hi folks, >> >> The fslock was a mistake

Re: Reviews for merges _from_ master to feature branches

on merge conflicts resolved? > > > On Mon, Nov 30, 2015, 7:18 PM David Cheney <david.che...@canonical.com> > wrote: >> >> Hello, >> >> Why are reviewers being created for merges from master to feature >> branches ? What purpose does this serve ? >>

Re: Upgrading minimum Go version?

As of this morning, the unit tests pass on xenial (thanks to Andrew for getting them over the hump) using Go 1.5 On Tue, Dec 1, 2015 at 3:21 AM, Curtis Hovey-Canonical wrote: > On Mon, Nov 30, 2015 at 10:36 AM, John Meinel wrote: >> Given how often

Re: utils/fslock needs to DIAF

On Tue, Dec 1, 2015 at 11:00 AM, Andrew Wilkins <andrew.wilk...@canonical.com> wrote: > On Tue, Dec 1, 2015 at 7:57 AM David Cheney <david.che...@canonical.com> > wrote: >> >> Doesn't look like there is windows support, and it uses fcntl (flock) >> under

Re: utils/fslock needs to DIAF

http://0pointer.de/blog/projects/locking.html In short, opening the same file twice and asserting a lock on it will succeed. On Tue, Dec 1, 2015 at 12:04 PM, Andrew Wilkins <andrew.wilk...@canonical.com> wrote: > On Tue, Dec 1, 2015 at 8:57 AM David Cheney <david.che...@canonical.

Re: utils/fslock needs to DIAF

spx >> >> On Mon, Nov 30, 2015 at 8:29 PM Andrew Wilkins >> <andrew.wilk...@canonical.com> wrote: >>> >>> On Tue, Dec 1, 2015 at 9:07 AM David Cheney <david.che...@canonical.com> >>> wrote: >>>> >>>> http://0pointer.

The CI build time continue to rise alarmingly

CI build times are now an average of 36 minutes. That means in a typical 8 hour work day, assuming doing nothing other than landing branches, less than 16 commits can be landed. While bugs can be worked on and reviewed in parallel, landing is a sequential action that blocks everyone, and given

  1   2   >