Re: [PATCH 1 of 5] e-mail: describe and clarify e-mail settings in the ini file

2015-07-13 Thread Mads Kiilerich
On 07/13/2015 09:26 PM, Thomas De Schampheleire wrote: On Mon, Jul 13, 2015 at 8:19 PM, Mads Kiilerich m...@kiilerich.com wrote: On 07/13/2015 10:45 AM, Thomas De Schampheleire wrote: # HG changeset patch # User Thomas De Schampheleire thomas.de.schamphele...@gmail.com # Date 1436644666 -7200

Re: Kallithea and Celery on Windows - can we use Celery 3.X instead of 2.1 - 2.3?

2015-07-08 Thread Mads Kiilerich
I would love to update to celery 3 - that would also fix some stability issues. It is however a major update, and I think their API changed. It thus requires some development work to make it work. Probably not much it and doesn't require much knowledge of the Kallithea codebase, but requires

Re: how can I lock a branch in a Kallithea Hg repository?

2015-07-08 Thread Mads Kiilerich
On 07/07/2015 02:03 PM, Todd Morgan wrote: Evening folks, I have a requirement to lock a branch in some of my mercurial repositories - so that only a very small set of users can actually push to the branch (eg the develop branch if using the git-flow model -

Re: [PATCH 4 of 4] autocomplete: consistently show 'username (Full Name)'

2015-06-24 Thread Mads Kiilerich
On 06/24/2015 05:15 PM, Thomas De Schampheleire wrote: On June 23, 2015 10:00:00 PM CEST, Thomas De Schampheleire patrickdeping...@gmail.com wrote: # HG changeset patch # User Thomas De Schampheleire thomas.de.schamphele...@gmail.com # Date 1435088059 -7200 # Tue Jun 23 21:34:19 2015

[PATCH] user: show 'Firstname Lastname (username)' and use string formatting instead of appending strings

2015-06-24 Thread Mads Kiilerich
# HG changeset patch # User Mads Kiilerich mad...@unity3d.com # Date 1435153690 -7200 # Wed Jun 24 15:48:10 2015 +0200 # Node ID 03befc961f641bfef6a5892f97ba1242dd2c7d88 # Parent 2619c73a230323c2b936a481732d9a63e191278d user: show 'Firstname Lastname (username)' and use string formatting

Re: [PATCH 2 of 2] pullrequest: internally use username iso userid when adding reviewers

2015-06-23 Thread Mads Kiilerich
On 06/22/2015 10:17 PM, Thomas De Schampheleire wrote: On Mon, Jun 22, 2015 at 7:21 PM, Mads Kiilerich m...@kiilerich.com wrote: On 06/22/2015 06:45 PM, Thomas De Schampheleire wrote: # HG changeset patch # User Thomas De Schampheleire thomas.de.schamphele...@gmail.com # Date 1434744060 -7200

Re: [PATCH 1 of 2] model: check for invalid users centrally

2015-06-23 Thread Mads Kiilerich
On 06/22/2015 10:09 PM, Thomas De Schampheleire wrote: On Mon, Jun 22, 2015 at 7:05 PM, Mads Kiilerich m...@kiilerich.com wrote: On 06/22/2015 06:45 PM, Thomas De Schampheleire wrote: # HG changeset patch # User Thomas De Schampheleire thomas.de.schamphele...@gmail.com # Date 1434984724 -7200

Re: [PATCH 0 of 7] tests: remove hardcoded strings defined symbolically in kallithea/tests/__init__.py

2015-06-20 Thread Mads Kiilerich
On 06/20/2015 10:37 PM, Thomas De Schampheleire wrote: Some trivial cleanups related to hardcoded strings in tests. I think another school of thought is that tests should be as simple, static and explicit as possible. To avoid begging the question they are asking, they should avoid any

[PATCH 1 of 2] pullrequsts: really create a comment when creating a PR and setting status to 'under review'

2015-06-18 Thread Mads Kiilerich
# HG changeset patch # User Mads Kiilerich mad...@unity3d.com # Date 1434647232 -7200 # Thu Jun 18 19:07:12 2015 +0200 # Node ID 7b75c8877364c24c72281759d9959255def3b159 # Parent 5fb4e6f884cec710b34736756d4eadaa53dd51d0 pullrequsts: really create a comment when creating a PR and setting

Re: [PATCH] backout pullrequests: don't add automatic 'status change' message - it will be added in template

2015-06-18 Thread Mads Kiilerich
On 06/17/2015 07:40 AM, Jan Heylen wrote: What I also wanted to say is that the original change is most probably not the issue, it just triggers an underlying issue... Yeah, the issue were elsewhere. Thanks for pointing in the right direction! My 5 cents in solving it: * It is not the first

Re: Talk on Kallithea at OSCON

2015-06-18 Thread Mads Kiilerich
On 06/04/2015 03:04 PM, Bradley M. Kuhn wrote: I am writing to let you all know that my talk on Kallithea was accepted at OSCON: http://www.oscon.com/open-source-2015/public/schedule/detail/42015 Some of you saw an earlier version of this talk at FOSDEM earlier this year. As you may

Re: [PATCH] backout pullrequests: don't add automatic 'status change' message - it will be added in template

2015-06-16 Thread Mads Kiilerich
On 06/16/2015 08:31 PM, Jan Heylen wrote: # HG changeset patch # User Jan Heylen heyl...@gmail.com # Date 1434479490 -7200 # Tue Jun 16 20:31:30 2015 +0200 # Node ID 3ff99546a950144258be3078b4483e7cebd5d720 # Parent 53d68f201e4602d3f2ccfcd27107d2ebea2deea2 backout pullrequests: don't add

Re: [PATCH] notification: use Sender and From header to clarify comment and pull request mails

2015-06-16 Thread Mads Kiilerich
On 06/15/2015 04:23 PM, Thomas De Schampheleire wrote: On Mon, Jun 15, 2015 at 2:10 PM, Mads Kiilerich m...@kiilerich.com wrote: On 06/14/2015 09:05 PM, Thomas De Schampheleire wrote: Hi Mads, On Fri, Jun 12, 2015 at 11:41 PM, Mads Kiilerich m...@kiilerich.com wrote: Anyway, how about

Re: [PATCH] backout pullrequests: don't add automatic 'status change' message - it will be added in template

2015-06-16 Thread Mads Kiilerich
On 06/16/2015 08:31 PM, Jan Heylen wrote: # HG changeset patch # User Jan Heylen heyl...@gmail.com # Date 1434479490 -7200 # Tue Jun 16 20:31:30 2015 +0200 # Node ID 3ff99546a950144258be3078b4483e7cebd5d720 # Parent 53d68f201e4602d3f2ccfcd27107d2ebea2deea2 backout pullrequests: don't add

Re: [PATCH] notification: use Sender and From header to clarify comment and pull request mails

2015-06-15 Thread Mads Kiilerich
On 06/14/2015 09:05 PM, Thomas De Schampheleire wrote: Hi Mads, On Fri, Jun 12, 2015 at 11:41 PM, Mads Kiilerich m...@kiilerich.com wrote: Anyway, how about a first patch that refactors and consistently renames mail_from to envelope_from (which seems to be the right technical term for what

Re: [PATCH] notification: use Sender and From header to clarify comment and pull request mails

2015-06-13 Thread Mads Kiilerich
On 06/13/2015 08:41 AM, Thomas De Schampheleire wrote: On 06/13/2015 08:41 AM, Thomas De Schampheleire wrote: On June 12, 2015 11:41:30 PM CEST, Mads Kiilerich m...@kiilerich.com wrote: On 06/12/2015 09:09 PM, Thomas De Schampheleire wrote: # HG changeset patch # User Cedric De Herdt

Re: [PATCH] comments: remove dysfunctional comment bubble on compare and file views (issue #84)

2015-06-12 Thread Mads Kiilerich
On 06/11/2015 10:59 AM, Thomas De Schampheleire wrote: # HG changeset patch # User Thomas De Schampheleire thomas.de_schamphele...@alcatel-lucent.com # Date 1432734170 -7200 # Wed May 27 15:42:50 2015 +0200 # Node ID d63188974baec38503601ef0efd33a75711280a2 # Parent

Re: [PATCH] notification: use Sender and From header to clarify comment and pull request mails

2015-06-12 Thread Mads Kiilerich
On 06/12/2015 09:09 PM, Thomas De Schampheleire wrote: # HG changeset patch # User Cedric De Herdt cedric.de_he...@alcatel-lucent.com # Date 1434135934 -7200 # Fri Jun 12 21:05:34 2015 +0200 # Node ID c9c5310da1771baed04e70fb45293b8d212e8bb9 # Parent

Re: Journal view: Possibility to filter out various actions from the view, such as the pulled from... action?

2015-06-08 Thread Mads Kiilerich
On 06/08/2015 11:29 AM, Christian Stimming wrote: Dear community, in the default configuration, the journal part of the kallithea web page notes all the various actions per day. The actions include user xy pushed into A/B, and xy started following A/B, and xy pulled from A/B. Is there any

Kallithea 0.2.2 coming soon - start testing

2015-06-06 Thread Mads Kiilerich
Hi We have collected a number of bugfixes on the stable branch and I think it is about time to cut an official 0.2.2 release. A draft of the release note can be found on https://bitbucket.org/conservancy/kallithea/wiki/releasenotes . If you are using the stable release, please start

Re: [PATCH 1 of 1 v2] login: preserve GET arguments throughout login redirection (issue #104)

2015-06-06 Thread Mads Kiilerich
On 06/04/2015 07:40 PM, Thomas De Schampheleire wrote: On June 4, 2015 6:55:30 PM CEST, Mads Kiilerich m...@kiilerich.com wrote: On 05/31/2015 01:41 PM, Thomas De Schampheleire wrote: # HG changeset patch # User Thomas De Schampheleire thomas.de.schamphele...@gmail.com # Date 1432065035 -7200

Re: [PATCH 1 of 3 v3] admin: users: factorize check for default user

2015-06-04 Thread Mads Kiilerich
On 06/03/2015 10:05 PM, Thomas De Schampheleire wrote: # HG changeset patch # User Thomas De Schampheleire thomas.de.schamphele...@gmail.com # Date 1433359538 -7200 # Wed Jun 03 21:25:38 2015 +0200 # Node ID 6a6119935ed636def910c4c4495ac2e4213d9ae7 # Parent

Re: Making pytest the standard test suite (instead of nose)

2015-05-31 Thread Mads Kiilerich
On 05/31/2015 12:57 PM, Thomas De Schampheleire wrote: Hi, I've been using pytest for a while now, and think we should consider making it the default test suite instead of nose. As I see it, there are following points to do: 1. silence the database setup code by default. Currently, the

Re: [PATCH PoC] secure password reset implementation

2015-05-27 Thread Mads Kiilerich
On 05/17/2015 02:07 AM, Andrew Shadura wrote: # HG changeset patch # User Andrew Shadura and...@shadura.me # Date 1431821238 -7200 # Sun May 17 02:07:18 2015 +0200 # Node ID 8d43a8174c960779437c2d8de7a0906a8cd14128 # Parent cb911e90e205bdb18fc2e2bd66549ea388d00413 secure password reset

[PATCH 0 of 1] Cleaned up

2015-05-27 Thread Mads Kiilerich
I pushed some indentation/linewrapping cleanup contained in the original patch. That makes it easier to spot the actual changes - see the following patch. I can now see more clearly that the patch is a simple step in the right direction. I also think it could be improved by more consistently talk

[PATCH 1 of 1] Refer to “remote repository” and “clone” consistently in templates

2015-05-27 Thread Mads Kiilerich
# HG changeset patch # User Ben Finney b...@benfinney.id.au # Date 1429660546 -36000 # Wed Apr 22 09:55:46 2015 +1000 # Node ID 80d0f17ab57f146c0c316d9dcd83d01ebdad72f1 # Parent 2c1ae0b188ae5f5fde6369f76803a1170592b90d Refer to “remote repository” and “clone” consistently in templates. diff

Re: [PATCH v2] auth: let users log in using their email address

2015-05-25 Thread Mads Kiilerich
On 05/17/2015 01:04 PM, Andrew Shadura wrote: Hello, On Sun, 17 May 2015 03:12:20 +0200 Mads Kiilerich mads-h1iwDtBV6gO1Z/+hsey...@public.gmane.org wrote: Correct me if I'm wrong, but if I read the code correctly, the check here will have no effect (which is why I haven't added it). Ok

Re: [DEMO] automatic saving of draft comments

2015-05-25 Thread Mads Kiilerich
On 05/25/2015 10:06 AM, Jan Heylen wrote: Any comments? I don't understand the references to blur. What problem do you think it would or wouldn't solve? For the general demo, I think the UI as it is would be a regression. The color emphasis of drafts do not seem efficient to me. I would

Re: [DEMO] automatic saving of draft comments

2015-05-25 Thread Mads Kiilerich
On 05/25/2015 09:57 PM, Thomas De Schampheleire wrote: On May 25, 2015 9:41:12 PM CEST, Mads Kiilerich m...@kiilerich.com wrote: On 05/25/2015 10:06 AM, Jan Heylen wrote: Any comments? I don't understand the references to blur. What problem do you think it would or wouldn't solve? Blur

Re: [PATCH] utils: return 'never' when the age is None

2015-05-21 Thread Mads Kiilerich
On 05/21/2015 08:15 PM, Andrew Shadura wrote: # HG changeset patch # User Andrew Shadura and...@shadura.me # Date 1432232093 -7200 # Thu May 21 20:14:53 2015 +0200 # Node ID 3737e67c7cbb89750dd8b3b5f76a003678792f3f # Parent 8d43a8174c960779437c2d8de7a0906a8cd14128 utils: return 'never'

Re: [PATCH] login: preserve GET arguments throughout login redirection (issue #104)

2015-05-20 Thread Mads Kiilerich
On 05/20/2015 09:22 AM, Thomas De Schampheleire wrote: # HG changeset patch # User Thomas De Schampheleire thomas.de.schamphele...@gmail.com # Date 1432065035 -7200 # Tue May 19 21:50:35 2015 +0200 # Node ID cedc3ee5ef792a77a515997c90b38099f4688166 # Parent

Re: [PATCH PoC] secure password reset implementation

2015-05-20 Thread Mads Kiilerich
On 05/20/2015 10:38 AM, Andrew Shadura wrote: Hello, On Tue, 19 May 2015 17:10:46 +0200 Mads Kiilerich m...@kiilerich.com wrote: @@ -296,10 +300,19 @@ class UserModel(BaseModel): user_email = data['email'] user = User.get_by_email(user_email) +timestamp = int

Re: [PATCH] login: preserve GET arguments throughout login redirection (issue #104)

2015-05-20 Thread Mads Kiilerich
On 05/20/2015 09:27 AM, Thomas De Schampheleire wrote: On Wed, May 20, 2015 at 9:22 AM, Thomas De Schampheleire patrickdeping...@gmail.com wrote: # HG changeset patch # User Thomas De Schampheleire thomas.de.schamphele...@gmail.com # Date 1432065035 -7200 # Tue May 19 21:50:35 2015 +0200 #

Re: Adding global and per-repo settings to Kallithea

2015-05-20 Thread Mads Kiilerich
On 05/19/2015 02:04 PM, Thomas De Schampheleire wrote: Hi, I would like to get some clarification/discussion on adding new settings to Kallithea, both global and per-repo settings. For global settings, there is a 'settings' table that has one row per setting, each setting having a name, value

Re: [PATCH] privacy: don't tell users what is the reason for a failed login

2015-05-19 Thread Mads Kiilerich
On 05/16/2015 05:04 PM, Andrew Shadura wrote: # HG changeset patch # User Andrew Shadura and...@shadura.me # Date 1431788631 -7200 # Sat May 16 17:03:51 2015 +0200 # Node ID cb911e90e205bdb18fc2e2bd66549ea388d00413 # Parent 388a6eada55925cb55cd2368e47a6115d833b4c1 privacy: don't tell users

Re: [PATCH PoC] secure password reset implementation

2015-05-19 Thread Mads Kiilerich
On 05/17/2015 02:07 AM, Andrew Shadura wrote: # HG changeset patch # User Andrew Shadura and...@shadura.me # Date 1431821238 -7200 # Sun May 17 02:07:18 2015 +0200 # Node ID 8d43a8174c960779437c2d8de7a0906a8cd14128 # Parent cb911e90e205bdb18fc2e2bd66549ea388d00413 secure password reset

Re: [PATCH v2] auth: let users log in using their email address

2015-05-16 Thread Mads Kiilerich
On 05/17/2015 02:11 AM, Andrew Shadura wrote: Hello, On Sun, 17 May 2015 01:50:56 +0200 Mads Kiilerich m...@kiilerich.com wrote: diff --git a/kallithea/controllers/login.py b/kallithea/controllers/login.py --- a/kallithea/controllers/login.py +++ b/kallithea/controllers/login.py @@ -121,9

Re: [PATCH 1 of 6 v2] admin: users: factorize check for default user

2015-05-16 Thread Mads Kiilerich
On 05/14/2015 10:15 PM, Thomas De Schampheleire wrote: On Tue, May 12, 2015 at 2:46 AM, Mads Kiilerich m...@kiilerich.com wrote: On 05/10/2015 08:22 PM, Thomas De Schampheleire wrote: # HG changeset patch # User Thomas De Schampheleire thomas.de.schamphele...@gmail.com # Date 1430943590 -7200

Re: [PATCH v2] auth: let users log in using their email address

2015-05-16 Thread Mads Kiilerich
On 05/16/2015 03:49 PM, Andrew Shadura wrote: # HG changeset patch # User Andrew Shadura and...@shadura.me # Date 1431709586 -7200 # Fri May 15 19:06:26 2015 +0200 # Node ID 93de511e84fe940786acf468789a77daed83a461 # Parent 95bffe63997d40bfab5ae6b8d1a54859d6275471 auth: let users log in

Re: [PATCH] auth: let users log in using their email address

2015-05-16 Thread Mads Kiilerich
On 05/16/2015 03:53 PM, Andrew Shadura wrote: FWIW: The only other place where users have to care about their (and others) login is in @mention. It would be nice to be able to specify email addresses there too. @usern...@example.com should work in the scanner (regexp) and auto completer. Some

Re: [PATCH] pullrequest/compare: add logical changeset index to clarify the order

2015-05-16 Thread Mads Kiilerich
On 05/16/2015 10:46 PM, Thomas De Schampheleire wrote: On Fri, May 15, 2015 at 11:26 PM, Mads Kiilerich m...@kiilerich.com wrote: I'm not sure how much of a win I think it is ... but ok. A mouseover tooltip could perhaps explain what the number means - especially if the tip was different

Re: [PATCH] auth: let users log in using their email address

2015-05-15 Thread Mads Kiilerich
On 05/15/2015 07:06 PM, Andrew Shadura wrote: # HG changeset patch # User Andrew Shadura and...@shadura.me # Date 1431709586 -7200 # Fri May 15 19:06:26 2015 +0200 # Node ID 1a7787acd1276557128ac6f8cd274b39c86ebbae # Parent 95bffe63997d40bfab5ae6b8d1a54859d6275471 auth: let users log in

Re: [PATCH 1 of 2 v2] tests: move pytest settings from kallithea/tests/pytest.ini to setup.cfg

2015-05-15 Thread Mads Kiilerich
On 05/14/2015 09:47 PM, Thomas De Schampheleire wrote: # HG changeset patch # User Thomas De Schampheleire thomas.de.schamphele...@gmail.com # Date 1431630347 -7200 # Thu May 14 21:05:47 2015 +0200 # Node ID 6a7b32b3fdc09d515dc68c347b60e9d8d07a1a5e # Parent

Re: [PATCH] pullrequest/compare: add logical changeset index to clarify the order

2015-05-15 Thread Mads Kiilerich
On 05/13/2015 09:25 PM, Thomas De Schampheleire wrote: # HG changeset patch # User Thomas De Schampheleire thomas.de.schamphele...@gmail.com # Date 1431287504 -7200 # Sun May 10 21:51:44 2015 +0200 # Node ID e19127e4040d1817bbec77118ca7377644f76a64 # Parent

Re: [PATCH] tests: restrict pytest test collection to kallithea/tests

2015-05-13 Thread Mads Kiilerich
On 05/13/2015 10:17 PM, Marc Abramowitz wrote: Yeah, that seems reasonable. Thomas' patch and/or my suggestion? ;-) /Mads On Wed, May 13, 2015 at 12:34 PM, Mads Kiilerich m...@kiilerich.com mailto:m...@kiilerich.com wrote: On 05/13/2015 09:26 PM, Thomas De Schampheleire wrote

Example of test failure output with pytest

2015-05-13 Thread Mads Kiilerich
Hi Some pytest feedback: I'm sorry for being lazy and not approaching upstream, but it is so appealing to talk directly to the friendly ambassadors ;-) One use case, with https://bitbucket.org/conservancy/kallithea/commits/9b8ba0f1c87b4fe89481b2c2c8723f6636d147cd , I got (valid) test

Re: Strings with markup

2015-05-09 Thread Mads Kiilerich
On 05/09/2015 01:49 PM, Vitt2, Peter wrote: Hi, I just stumbled upon some strings with some kind of markup that I don’t know about. For examples see kallithea/lib/helpers.py:756 and following: '[deleted] repository’ What is the purpose of the brackets? You are translating? These strings

Re: DXR-like source indexing and browsing

2015-05-07 Thread Mads Kiilerich
On 05/07/2015 02:38 PM, Nochum Sossonko wrote: Hi, Would there be any interest in integrating a DXR-like browser/indexer? See http://dxr.mozilla.org for an example of a running DXR system, it is invaluable in large projects with a lot of code to wade through. Integrating into Kallithea

Re: How can I use existing LDAP groups to authorise users in Kallithea?

2015-05-07 Thread Mads Kiilerich
On 05/07/2015 02:35 PM, Todd Morgan wrote: Hi everyone, I managed to get my Kallithea authenticating nicely using LDAP (a small typo in the LDAP Search filter was the cause). You can perhaps contribute some debugging hints to the documentation. can authenticate my users AOK now (getting

Re: [PATCH] diff view: fix tab width, move diff markers a bit to the left

2015-05-05 Thread Mads Kiilerich
On 05/05/2015 01:30 PM, Andrew Shadura wrote: # HG changeset patch # User Andrew Shadura and...@shadura.me # Date 1430825240 -7200 # Tue May 05 13:27:20 2015 +0200 # Node ID 7dca6303d91ddb98bcc62f085d5342609a4d40b2 # Parent 0c58b6dc55120dd609daf7f13b02f5c128292fb7 diff view: fix tab width,

Re: [PATCH] diff view: improve appearance of line numbers

2015-05-05 Thread Mads Kiilerich
On 05/05/2015 06:15 PM, Andrew Shadura wrote: # HG changeset patch # User Andrew Shadura and...@shadura.me # Date 1430842380 -7200 # Tue May 05 18:13:00 2015 +0200 # Node ID c49fd027ae6491270795db939dcd724d6e29b3fd # Parent 4347c8958b9442dac9744e3f4e1e2282ffa25ce7 diff view: improve

Re: Re : What is the least obtrusive means of migrating a large number

2015-05-03 Thread Mads Kiilerich
On 05/04/2015 01:21 AM, Todd Morgan wrote: Let me ask a different question then :-) (as CROWD and LDAP are both acceptable options for me as they represent the same information - crowd is just easier to setup and limit its scope). Note: There is no evidence that Crowd is causing any problems

Re: What is the least obtrusive means of migrating a large number of users to Kallithea when using LDAP and/or Crowd external authentication?

2015-05-03 Thread Mads Kiilerich
On 05/03/2015 03:41 PM, Todd Morgan wrote: Hi everyone, I'm trying to setup a new Kallithea (0.2.1) installation on Win2k12, which is working OK using a vanilla installation as detailed previously. My problem is that now I need to bring on approximately 200+ users to this system but I

Re: [PATCH PoC] Use webassets and lesscpy to precompile LESS into CSS and (optionally) minify JavaScript

2015-04-30 Thread Mads Kiilerich
On 04/27/2015 02:39 PM, Andrew Shadura wrote: Hello, On Mon, 27 Apr 2015 13:33:04 +0200 Mads Kiilerich m...@kiilerich.com wrote: It would be nice to get some introduction to what that means and why we would do it - perhaps also some assessment of the pros and cons. Well, probably. The idea

Re: [PATCH v2] ChangesetCommentsModel: refactor duplicate code

2015-04-30 Thread Mads Kiilerich
On 04/30/2015 07:06 AM, Jan Heylen wrote: # HG changeset patch # User Jan Heylen heyl...@gmail.com # Date 1430370318 -7200 # Thu Apr 30 07:05:18 2015 +0200 # Node ID 406c95a068096edec2b8ffdedf2a0d1caced14a4 # Parent 71140b7c9abfcb34db70792c39e09a4e4796efb1 ChangesetCommentsModel: refactor

Re: [PATCH] ChangesetCommentsModel: refactor duplicate code

2015-04-29 Thread Mads Kiilerich
On 04/29/2015 10:09 PM, Jan Heylen wrote: # HG changeset patch # User Jan Heylen heyl...@gmail.com # Date 1430323563 -7200 # Wed Apr 29 18:06:03 2015 +0200 # Node ID 8ead3310a073d6453b926b891f1a59a0fcf6c6b5 # Parent 71140b7c9abfcb34db70792c39e09a4e4796efb1 ChangesetCommentsModel: refactor

Re: [RFC] Search box

2015-04-27 Thread Mads Kiilerich
On 04/27/2015 09:31 AM, Thomas De Schampheleire wrote: On Sun, Apr 26, 2015 at 10:23 PM, Mads Kiilerich m...@kiilerich.com wrote: On 04/26/2015 09:17 PM, Thomas De Schampheleire wrote: Redirecting to a search 'page' in order to be able to enter search terms is not very user-friendly and makes

Re: [PATCH 3 of 4] pullrequests: add pull_request_nice_id

2015-04-26 Thread Mads Kiilerich
On 04/25/2015 08:33 PM, Thomas De Schampheleire wrote: # HG changeset patch # User Thomas De Schampheleire thomas.de.schamphele...@gmail.com # Date 1429265659 -7200 # Fri Apr 17 12:14:19 2015 +0200 # Node ID 3d17f0d2a96eac41e6bf4312df1f6af476cce4ad # Parent

Re: [RFC] Search box

2015-04-26 Thread Mads Kiilerich
On 04/26/2015 09:17 PM, Thomas De Schampheleire wrote: Redirecting to a search 'page' in order to be able to enter search terms is not very user-friendly and makes searching harder than it should be. Yes, it would be weird if that search page only contained one input field. I do however not

Re: [PATCH] ignore the .cache folder created by pytest-cache

2015-04-26 Thread Mads Kiilerich
Am 25. April 2015 02:43:06 MESZ, schrieb Mads Kiilerich m...@kiilerich.com: On 04/24/2015 10:29 PM, Ronny Pfannschmidt wrote: # HG changeset patch # User Ronny Pfannschmidtopensou...@ronnypfannschmidt.de # Date 1429907346 -7200 # Fri Apr 24 22:29:06 2015 +0200 # Node

Re: [PATCH RFC] pullrequest: reverse order of changeset list

2015-04-26 Thread Mads Kiilerich
On 04/25/2015 10:23 PM, Thomas De Schampheleire wrote: # HG changeset patch # User Thomas De Schampheleire thomas.de.schamphele...@gmail.com # Date 1429991014 -7200 # Sat Apr 25 21:43:34 2015 +0200 # Node ID 7f62f8ef3acc8ce197156d138936a56329f0d151 # Parent

Re: [PATCH 2 of 7] notification: allow multiple body parts in templates

2015-04-26 Thread Mads Kiilerich
On 04/24/2015 11:47 PM, Jan Heylen wrote: On Fri, Apr 24, 2015 at 7:20 PM, Mads Kiilerich m...@kiilerich.com wrote: On 04/14/2015 06:03 PM, Jan Heylen wrote: # HG changeset patch # User Jan Heylen heyl...@gmail.com # Date 1427469226 -3600 # Fri Mar 27 16:13:46 2015 +0100 # Node ID

Re: [PATCH 4 of 7] changeset: draft comment on changesets

2015-04-26 Thread Mads Kiilerich
On 04/24/2015 11:47 PM, Jan Heylen wrote: On Fri, Apr 24, 2015 at 7:21 PM, Mads Kiilerich m...@kiilerich.com wrote: On 04/14/2015 06:03 PM, Jan Heylen wrote: # HG changeset patch # User Jan Heylen heyl...@gmail.com # Date 1427526729 -3600 # Sat Mar 28 08:12:09 2015 +0100 # Node ID

Re: [PATCH 2 of 7] notification: allow multiple body parts in templates

2015-04-24 Thread Mads Kiilerich
On 04/14/2015 06:03 PM, Jan Heylen wrote: # HG changeset patch # User Jan Heylen heyl...@gmail.com # Date 1427469226 -3600 # Fri Mar 27 16:13:46 2015 +0100 # Node ID 55ba8e68269da8fb0c33c65711a57b4fd9e1b675 # Parent cb41b8211291b55bcd7c77919f714791927b8045 notification: allow multiple body

Re: [PATCH 6 of 7] frontend: change comment workflow

2015-04-24 Thread Mads Kiilerich
On 04/14/2015 06:03 PM, Jan Heylen wrote: # HG changeset patch # User Jan Heylen heyl...@gmail.com # Date 1428986395 -7200 # Tue Apr 14 06:39:55 2015 +0200 # Node ID b1b3c859230ce5997f7820788dd331748e277525 # Parent 48a64173a2187e3ea2822df54b3d0096176e76e3 frontend: change comment workflow

Re: [PATCH 1 of 2] css: make 'add comment' button look more like a button (issue #77)

2015-04-23 Thread Mads Kiilerich
On 04/22/2015 02:20 PM, Andrew Shadura wrote: # HG changeset patch # User Andrew Shadura and...@shadura.me # Date 1429703987 -7200 # Wed Apr 22 13:59:47 2015 +0200 # Branch stable # Node ID 539f3da5d965459d2221d10b6724585e60104f7d # Parent 74b5e0318d4e961081daca2833c4ffe520e59e62 css: make

Re: [PATCH 2 of 2] css: add text +/- markers to the diff to improve readability for colour blind (fixes #77)

2015-04-23 Thread Mads Kiilerich
On 04/22/2015 02:20 PM, Andrew Shadura wrote: # HG changeset patch # User Andrew Shadura and...@shadura.me # Date 1429705229 -7200 # Wed Apr 22 14:20:29 2015 +0200 # Branch stable # Node ID a06804c28d744fb153c3e083277429094a134495 # Parent 539f3da5d965459d2221d10b6724585e60104f7d css: add

Re: [PATCH 1 of 2] css: make 'add comment' button look more like a button (issue #77)

2015-04-22 Thread Mads Kiilerich
On 04/22/2015 02:20 PM, Andrew Shadura wrote: # HG changeset patch # User Andrew Shadura and...@shadura.me # Date 1429703987 -7200 # Wed Apr 22 13:59:47 2015 +0200 # Branch stable # Node ID 539f3da5d965459d2221d10b6724585e60104f7d # Parent 74b5e0318d4e961081daca2833c4ffe520e59e62 css: make

Re: [PATCH] compat: import defaultdict from collections, sqlalchemy 0.8.0 dropped the shim

2015-04-22 Thread Mads Kiilerich
On 04/21/2015 07:04 PM, Andrew Shadura wrote: # HG changeset patch # User Andrew Shadura and...@shadura.me # Date 1429635852 -7200 # Tue Apr 21 19:04:12 2015 +0200 # Branch stable # Node ID 74b5e0318d4e961081daca2833c4ffe520e59e62 # Parent 7aef2c2289c8a1ee450d7f8624e731d7c89d99d3 compat:

Re: [PATCH] pullrequests: add support for custom pull request id prefix

2015-04-22 Thread Mads Kiilerich
On 04/22/2015 09:58 AM, Thomas De Schampheleire wrote: On Tue, Apr 21, 2015 at 4:37 PM, Mads Kiilerich m...@kiilerich.com wrote: On 04/21/2015 10:19 AM, Thomas De Schampheleire wrote: On Tue, Apr 21, 2015 at 3:21 PM, Mads Kiilerich m...@kiilerich.com wrote: On 04/21/2015 06:20 AM, Thomas De

Re: [PATCH] comments: display username and name instead of only username

2015-04-21 Thread Mads Kiilerich
On 04/21/2015 08:23 AM, Thomas De Schampheleire wrote: On Mon, Apr 20, 2015 at 9:13 PM, Mads Kiilerich m...@kiilerich.com wrote: On 04/20/2015 06:51 AM, Thomas De Schampheleire wrote: I would go for: - pull request author: full name (username) - pull request reviewers: full name (username

Re: [PATCH PoC] hacks: the concept of python files that will be loaded and can monkeypatch Kallithea internals

2015-04-21 Thread Mads Kiilerich
On 04/21/2015 10:18 AM, Thomas De Schampheleire wrote: On Tue, Apr 21, 2015 at 3:05 PM, Mads Kiilerich m...@kiilerich.com wrote: On 04/21/2015 06:34 AM, Thomas De Schampheleire wrote: +import imp import logging import kallithea import platform @@ -43,12 +45,25 @@ from

Re: [PATCH] css: make 'add comment' button look more like a button

2015-04-21 Thread Mads Kiilerich
On 04/21/2015 01:36 PM, Andrew Shadura wrote: # HG changeset patch # User Andrew Shadura and...@shadura.me # Date 1429637769 -7200 # Tue Apr 21 19:36:09 2015 +0200 # Node ID fe9a1f5d259c186b7d9cd0c3e10aa99217a37fed # Parent c7997c7ed325ddea499549a3d66dc5f006fcba33 css: make 'add comment'

Re: [PATCH] pullrequests: add support for custom pull request id prefix

2015-04-20 Thread Mads Kiilerich
On 04/20/2015 05:55 AM, Thomas De Schampheleire wrote: On Sun, Apr 19, 2015 at 6:16 PM, Mads Kiilerich m...@kiilerich.com wrote: I would probably take a patch that moved the hardcoded # naming to a method on the PullRequest db model, similar to how we have .url . It would be very much like

Re: [PATCH] pullrequests: add support for custom pull request id prefix

2015-04-20 Thread Mads Kiilerich
On 04/20/2015 06:02 AM, Thomas De Schampheleire wrote: On Sun, Apr 19, 2015 at 6:42 PM, Mads Kiilerich m...@kiilerich.com wrote: By the way ... it has been mentioned before that the term pull request is weird for most workflows. Inspired by discussions with people at the Mercurial sprint, I

Re: [PATCH 1 of 3] changeset_status: add unit tests for calculation of overall status

2015-04-19 Thread Mads Kiilerich
On 04/19/2015 06:06 AM, Thomas De Schampheleire wrote: Both of your comments sounded fine to me, but I see the commits are already applied. Do you expect a follow-up on this patch or did you change your mind? Please make a follow-up patch if you agree. /Mads

Re: [PATCH] comments: avoid confusing 'No comments' on empty general comments

2015-04-19 Thread Mads Kiilerich
On 04/19/2015 06:05 AM, Thomas De Schampheleire wrote: On Sun, Apr 19, 2015 at 12:37 AM, Mads Kiilerich m...@kiilerich.com wrote: On 04/18/2015 04:12 PM, Thomas De Schampheleire wrote: # HG changeset patch # User Thomas De Schampheleire thomas.de.schamphele...@gmail.com # Date 1429294302 -7200

Re: [PATCH] pullrequests: add support for custom pull request id prefix

2015-04-19 Thread Mads Kiilerich
By the way ... it has been mentioned before that the term pull request is weird for most workflows. Inspired by discussions with people at the Mercurial sprint, I think I am settling on using the term series. It is all about presenting a series of changes / patches / changesets so they can be

Re: Unable to integrate Celery upon windows using Kallithea 0.2.1 on Win2k12

2015-04-19 Thread Mads Kiilerich
On 04/19/2015 09:11 AM, Todd Morgan wrote: Hi, I'm trying to set up a new Kallithea 0.2.1 installation upon a Win2k12 box (clean - nothing else installed). I am able to get Kallithea working AOK without Celery and RabbitMQ - but I have a large number of repos (100+) to support so I need the

Re: [PATCH] pullrequests: add support for custom pull request id prefix

2015-04-19 Thread Mads Kiilerich
On 04/19/2015 03:54 AM, Thomas De Schampheleire wrote: On Sun, Apr 19, 2015 at 12:20 AM, Mads Kiilerich m...@kiilerich.com wrote: On 04/18/2015 04:11 PM, Thomas De Schampheleire wrote: # HG changeset patch # User Thomas De Schampheleire thomas.de.schamphele...@gmail.com # Date 1429265659 -7200

Re: [PATCH 0 of 7] save multiple comments at once

2015-04-19 Thread Mads Kiilerich
On 04/19/2015 06:18 AM, Jan Heylen wrote: Hi, anybody some spare time to have a look at these patches? I haven't had as much time as it deserves. My main unsolicited thought is that I would see this as something closely related to having versioning of comments so they can be edited or

Re: [PATCH] pullrequests: add support for custom pull request id prefix

2015-04-18 Thread Mads Kiilerich
On 04/18/2015 04:11 PM, Thomas De Schampheleire wrote: # HG changeset patch # User Thomas De Schampheleire thomas.de.schamphele...@gmail.com # Date 1429265659 -7200 # Fri Apr 17 12:14:19 2015 +0200 # Node ID 6e760af6050e567239155a7a43b5ab02eddf877d # Parent

Re: [PATCH 1 of 3] changeset_status: add unit tests for calculation of overall status

2015-04-18 Thread Mads Kiilerich
On 04/18/2015 04:11 PM, Thomas De Schampheleire wrote: # HG changeset patch # User Thomas De Schampheleire thomas.de.schamphele...@gmail.com # Date 1429274977 -7200 # Fri Apr 17 14:49:37 2015 +0200 # Node ID 928837725c3c0d8e7e8fbef23b7e12d5a4ddb66c # Parent

Re: [PATCH] comments: avoid confusing 'No comments' on empty general comments

2015-04-18 Thread Mads Kiilerich
On 04/18/2015 04:12 PM, Thomas De Schampheleire wrote: # HG changeset patch # User Thomas De Schampheleire thomas.de.schamphele...@gmail.com # Date 1429294302 -7200 # Fri Apr 17 20:11:42 2015 +0200 # Node ID e25ee448dae32e2e21f1b66763dae468f45c00f0 # Parent

Re: [PATCH 0 of 2] new commits push notification -- incomplete and not really working

2015-04-18 Thread Mads Kiilerich
On 04/18/2015 03:54 PM, Andrew Shadura wrote: Hello everyone, During the last few days I've been trying to develop a patch to implement email notifications about incoming commits. The final version of the patch working locally is here, but: i) it's hardcoded for one email address, i.e. it

Re: [SECURITY ISSUE] CVE-2015-0276: Lack of CSRF attack protection enables gaining unauthorised access to users' accounts

2015-04-13 Thread Mads Kiilerich
On 04/10/2015 01:28 PM, Kallithea Security Team wrote: Dear users, We've discovered a security issue in Kallithea. We forgot to mention: Thanks to Paul van Empelen for reporting the issue. /Mads ___ kallithea-general mailing list

Mailing list problems

2015-04-06 Thread Mads Kiilerich
Hi Kallithea Community It seems like a badly configured spam filter has discarded mails since April 1st. No joke. If you have sent any mails that doesn't appear on http://lists.sfconservancy.org/pipermail/kallithea-general/2015q2/ , please resend. Feel free to CC me so I can verify they

Re: [PATCH] base: add request time to footer

2015-03-31 Thread Mads Kiilerich
On 03/31/2015 07:46 PM, Thomas De Schampheleire wrote: On March 31, 2015 5:05:01 PM CEST, Mads Kiilerich m...@kiilerich.com wrote: On 03/31/2015 05:00 PM, Thomas De Schampheleire wrote: # HG changeset patch # User Thomas De Schampheleire thomas.de.schamphele...@gmail.com # Date 1427813112

Re: Invitation to adopt pytest month

2015-03-29 Thread Mads Kiilerich
On 03/28/2015 08:54 PM, Thomas De Schampheleire wrote: On Sat, Mar 28, 2015 at 12:13 AM, Brianna Laugher brianna.laug...@gmail.com wrote: Well, I'm kind of making it up as I go, but I envisage something like · initial familiarisation with project, discussion of aims (which we have done a bit

Re: [PATCH 1 of 5] auth: do not redirect to login page on invalid API key

2015-03-25 Thread Mads Kiilerich
On 03/25/2015 12:01 PM, Thomas De Schampheleire wrote: # HG changeset patch # User Thomas De Schampheleire thomas.de.schamphele...@gmail.com # Date 1427269791 -3600 # Wed Mar 25 08:49:51 2015 +0100 # Node ID c5828585502f1a061f162abe8cbd181c17039843 # Parent

Re: [PATCH 2 of 5] auth: return early in LoginRequired on invalid IP

2015-03-25 Thread Mads Kiilerich
On 03/25/2015 12:01 PM, Thomas De Schampheleire wrote: # HG changeset patch # User Thomas De Schampheleire thomas.de.schamphele...@gmail.com # Date 1427271075 -3600 # Wed Mar 25 09:11:15 2015 +0100 # Node ID 43b0bc9088d3eedacf7610ffbf2f4b429ae98c45 # Parent

Re: [PATCH 3 of 5] auth: return early in LoginRequired on API key validation

2015-03-25 Thread Mads Kiilerich
On 03/25/2015 12:01 PM, Thomas De Schampheleire wrote: # HG changeset patch # User Thomas De Schampheleire thomas.de.schamphele...@gmail.com # Date 1427274589 -3600 # Wed Mar 25 10:09:49 2015 +0100 # Node ID 32ced9e32b506c7441339f67da3c4237de0e6fa3 # Parent

Re: [PATCH 5 of 5] auth: fix tests after changing API key handling

2015-03-25 Thread Mads Kiilerich
On 03/25/2015 12:01 PM, Thomas De Schampheleire wrote: # HG changeset patch # User Thomas De Schampheleire thomas.de.schamphele...@gmail.com # Date 1427279629 -3600 # Wed Mar 25 11:33:49 2015 +0100 # Node ID eaeea9ea95b036e8d5eaac16aea1e6c8c62868c9 # Parent

Re: [oss-security] Dulwich security issue (fwd)

2015-03-23 Thread Mads Kiilerich
On 03/23/2015 09:14 AM, Adi Kriegisch wrote: Hey! ...anything we need to do about that? I don't know. I guess all we can do is to inform all users that they probably have it installed as a dependency and that they should upgrade. We could perhaps make a secure version mandatory in next

Re: [PATCH] pullrequests: saving raw_id instead of branch in org_ref

2015-03-23 Thread Mads Kiilerich
On 03/20/2015 01:18 PM, Thomas De Schampheleire wrote: Regardless of this TODO, I think the patch is fine in removing a different behavior depending on the fact that the PR head happens to be the tip at the time of PR creation or not. Yes - I was verifying it in production. Pushed - thanks!

Re: [PATCH 0 of 1 RFC] login-required pragma

2015-03-23 Thread Mads Kiilerich
On 03/22/2015 02:34 PM, Thomas De Schampheleire wrote: Hi Mads, On Fri, Mar 20, 2015 at 1:09 AM, Mads Kiilerich m...@kiilerich.com wrote: On 03/19/2015 09:34 PM, Thomas De Schampheleire wrote: Hi, Issue I'm trying to solve is this: we're implementing a script to create a pull request

Re: [oss-security] Dulwich security issue (fwd)

2015-03-23 Thread Mads Kiilerich
On 03/23/2015 04:00 PM, Adi Kriegisch wrote: 0.9.9 seems to be a fix for 0.9.8 that does a version update too but it does not seem to be pip installable from any known sources. It is now available with pip install --upgrade dulwich==0.9.9 - after patching Kallithea setup.py and expanding the

Re: what is the issue with database changes?

2015-03-20 Thread Mads Kiilerich
On 03/20/2015 05:44 PM, Jan Heylen wrote: On Fri, Mar 20, 2015 at 5:28 PM, Mads Kiilerich m...@kiilerich.com wrote: I think Matt's response in this thread gives a good answer to why not and is a relevant challenge but doesn't give a good answer to then how. It would be nice if the described

Re: Invitation to adopt pytest month

2015-03-19 Thread Mads Kiilerich
On 03/19/2015 11:30 PM, Brianna Laugher wrote: Hello, I am a contributor to the testing library pytest, and in April we are holding adopt pytest month. We are inviting open source projects who are interested in possibly taking up pytest, to be paired with experienced pytest users, who can help

Re: [PATCH 0 of 1 RFC] login-required pragma

2015-03-19 Thread Mads Kiilerich
On 03/19/2015 09:34 PM, Thomas De Schampheleire wrote: Hi, Issue I'm trying to solve is this: we're implementing a script to create a pull request directly from a repo, without using the web interface. This script uses an API key to authenticate. When authentication fails (invalid API key) you

<    1   2   3   4   5   6   >