D29051: Add ecm_generate_dbus_service_file

kossebau added a comment. A unit test would be good to have. The test for ECMGeneratePkgConfigFile might be a sample for this. INLINE COMMENTS > ECMGenerateDBusServiceFile.cmake:17 > +# > +# A D-Bus service file ``.service` will will be generated and > installed > +# in the relevant D-Bus

D29573: ECMGenerateExportHeader: add generation of *_DEPRECATED_VERSION_BELATED()

This revision was automatically updated to reflect the committed changes. Closed by commit R240:cc8bccadcdb9: ECMGenerateExportHeader: add generation of *_DEPRECATED_VERSION_BELATED() (authored by kossebau). REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE

D29573: ECMGenerateExportHeader: add generation of *_DEPRECATED_VERSION_BELATED()

kossebau created this revision. kossebau added reviewers: Frameworks, Build System, dfaure. Herald added projects: Frameworks, Build System. Herald added subscribers: kde-buildsystem, kde-frameworks-devel. kossebau requested review of this revision. REVISION SUMMARY Now and then tagging some

D29274: ECMGeneratePriFile: make the pri files relocatable

kossebau added a comment. D29096 also wants to touch those entries, for different reasons. You may want to align here. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D29274 To: dfaure, vatra, kfunk, apol Cc:

D29051: Add ecm_generate_dbus_service_file

kossebau added a comment. Any chance for a simple unit test to check the generation does what is expected (or catches bad input)? :) INLINE COMMENTS > ECMGenerateDBusServiceFile.cmake:22 > +# are to be installed in the same directory as the D-Bus daemon. On other > platforms > +# must

D28355: Introduce function ecm_install_configured_file

kossebau added a comment. A bit unsure if the arg name "TEMPLATES" is good, or if perhaps should be renamed to "INPUT". Just mentioning, not preferring one over the other. So far have not found existing samples to take as lead for consistent argument naming. For completeness, would be

D28355: Introduce function ecm_install_configured_file

kossebau added a reviewer: Build System. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D28355 To: davidedmundson, #build_system Cc: apol, kossebau, pino, kde-frameworks-devel, kde-buildsystem, LeGast00n, cblack, bencreasy, michaelh, ngraham, bruns

D29096: Prefix includes and libs dir with QT_SYSROOT

kossebau added reviewers: Build System, apol, vkrause, kfunk. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D29096 To: ablu, #build_system, apol, vkrause, kfunk Cc: kossebau, kde-frameworks-devel, kde-buildsystem, LeGast00n, cblack, bencreasy, michaelh,

D29096: Prefix includes and libs dir with QT_SYSROOT

kossebau added a comment. Thanks for the explanation, fear though I am missing some details and thus have not yet understood the problem and the solution. Not having done much cross-compilation-library-setups naively I would have thought that when building a library which uses

D29097: Adapt FindKF5 to stricter checks in newer find_package_handle_standard_args

This revision was automatically updated to reflect the committed changes. Closed by commit R240:ebc874095b4d: Adapt FindKF5 to stricter checks in newer find_package_handle_standard_args (authored by kossebau). REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE

D29096: Prefix includes and libs dir with QT_SYSROOT

kossebau added a comment. No current clue about qmake, just wondering from my little knowledge: how does having $$[QT_SYSROOT] here influence any QMAKEPATH env var set? Would pri files installed into a custom prefix still be found? REPOSITORY R240 Extra CMake Modules REVISION DETAIL

D29097: Adapt FindKF5 to stricter checks in newer find_package_handle_standard_args

kossebau added a comment. Warning: I have not really investigated in full detail if the current code of FindKF5 is completely sane besides a quick check, more or less assume that it has worked all the time, so the new warning here can be silenced. REPOSITORY R240 Extra CMake Modules

D29097: Adapt FindKF5 to stricter checks in newer find_package_handle_standard_args

kossebau created this revision. kossebau added reviewers: Frameworks, Build System. Herald added projects: Frameworks, Build System. Herald added subscribers: kde-buildsystem, kde-frameworks-devel. kossebau requested review of this revision. TEST PLAN KF modules configure build as before, same

D29051: Add ecm_generate_dbus_service_file

kossebau added a comment. Some first quick comments, not yet looked at code itself. Misses also link file from doc/. INLINE COMMENTS > ECMGenerateDBusServiceFile.cmake:6 > +# This module provides the ``ecm_generate_dbus_service_file`` function for > +# generating a D-Bus service file. >

D28355: Introduce function ecm_install_configured_file

kossebau added inline comments. INLINE COMMENTS > kossebau wrote in ECMConfiguredInstall.cmake:62 > These strings (besides the last obviously) should get added with whitespace > suffix, to handle the case where multiple are added, no? Not yet got to > test/run things, just guessing by reading

D28355: Introduce function ecm_install_configured_file

kossebau added a comment. Quick review while I had some spare minutes, to keep things going. INLINE COMMENTS > ECMConfiguredInstall.cmake:5 > +# > +# Take a list of files, runs configure_file and installs it in the given > location. > +# Perhaps "install" -> "install the result" >

D28355: Introduce function ecm_install_configured_file

kossebau added a comment. A .rst file in the docs/module/ directory is needed, otherwise the documentation generation will not pick up this, as it runs only over docs/. Please enable the documentation generation in your ecm build and check for yourself, by e.g. ensuring `BUILD_HTML_DOCS`

D28253: ECMPoQmToolsTest: have separate moc files for tr_thread_test 1 & 2

This revision was automatically updated to reflect the committed changes. Closed by commit R240:6136a9742626: ECMPoQmToolsTest: have separate moc files for tr_thread_test 1 2 (authored by kossebau). REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE

Re: ECM unittest fails, why?

Am Dienstag, 24. März 2020, 07:48:22 CET schrieb Friedrich W. H. Kossebau: > Am Montag, 23. März 2020, 20:30:59 CET schrieb Friedrich W. H. Kossebau: > > Am Sonntag, 22. März 2020, 10:50:39 CET schrieb David Faure: > > > The CI for ECM has been failing ever since the tes

D28253: ECMPoQmToolsTest: have separate moc files for tr_thread_test 1 & 2

kossebau created this revision. kossebau added reviewers: Frameworks, Build System, dfaure. Herald added projects: Frameworks, Build System. Herald added subscribers: kde-buildsystem, kde-frameworks-devel. kossebau requested review of this revision. REPOSITORY R240 Extra CMake Modules BRANCH

Re: ECM unittest fails, why?

Am Dienstag, 24. März 2020, 08:37:56 CET schrieb Ben Cooksley: > On Tue, Mar 24, 2020 at 7:48 PM Friedrich W. H. Kossebau > > wrote: > > Why CI does this order, but not locally for us, no clue so far. > > Could this ordering be a race condition by any chance? >

Re: ECM unittest fails, why?

Am Montag, 23. März 2020, 20:30:59 CET schrieb Friedrich W. H. Kossebau: > Am Sonntag, 22. März 2020, 10:50:39 CET schrieb David Faure: > > The CI for ECM has been failing ever since the tests were re-enabled. > > > > https://build.kde.org/job/Frameworks/view/Platform%20

Re: ECM unittest fails, why?

Am Sonntag, 22. März 2020, 10:50:39 CET schrieb David Faure: > The CI for ECM has been failing ever since the tests were re-enabled. > > https://build.kde.org/job/Frameworks/view/Platform%20-%20SUSEQt5.12/job/extr > a-cmake-modules/job/kf5-qt5%20SUSEQt5.12/103/console shows that >

D27150: Add ecm_qt_install_logging_categories & ecm_qt_export_logging_category

kossebau added a comment. In D27150#619735 , @bruns wrote: > You have ommited to update the minimum ECM version in all cases AFAICS. Because that bump is done by the release scripts, and I did not want to mess with them. In general

D27269: Use ecm_qt_install_logging_categories over manual categories file

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R241:f385d5716762: Use ecm_qt_install_logging_categories over manual categories file (authored by kossebau). CHANGED PRIOR

D27178: Use ecm_qt_install_logging_categories over manual categories file

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R246:19cd6b195279: Use ecm_qt_install_logging_categories over manual categories file (authored by kossebau). CHANGED PRIOR

D27270: Use ecm_qt_install_logging_categories over manual categories files

This revision was automatically updated to reflect the committed changes. Closed by commit R174:473ec03799d6: Use ecm_qt_install_logging_categories over manual categories files (authored by kossebau). REPOSITORY R174 KContacts CHANGES SINCE LAST UPDATE

D27151: Use ecm_qt_install_logging_categories over manual categories file

This revision was automatically updated to reflect the committed changes. Closed by commit R244:fcb1eff1c610: Use ecm_qt_install_logging_categories over manual categories file (authored by kossebau). REPOSITORY R244 KCoreAddons CHANGES SINCE LAST UPDATE

D27150: Add ecm_qt_install_logging_categories & ecm_qt_export_logging_category

This revision was automatically updated to reflect the committed changes. Closed by commit R240:86041b6d8634: Add ecm_qt_install_logging_categories ecm_qt_export_logging_category (authored by kossebau). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D27150?vs=75312=75421#toc REPOSITORY

D27270: Use ecm_qt_install_logging_categories over manual categories files

kossebau added a dependency: D27150: Add ecm_qt_install_logging_categories & ecm_qt_export_logging_category. REPOSITORY R174 KContacts REVISION DETAIL https://phabricator.kde.org/D27270 To: kossebau, #build_system, #frameworks, broulik, mlaurent Cc: kde-frameworks-devel, LeGast00n, cblack,

D27150: Add ecm_qt_install_logging_categories & ecm_qt_export_logging_category

kossebau added a dependent revision: D27270: Use ecm_qt_install_logging_categories over manual categories files. REPOSITORY R240 Extra CMake Modules BRANCH addautomaticcategoriesgeneration REVISION DETAIL https://phabricator.kde.org/D27150 To: kossebau, #build_system, #frameworks,

D27270: Use ecm_qt_install_logging_categories over manual categories files

kossebau created this revision. kossebau added reviewers: Build System, Frameworks, broulik, mlaurent. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. kossebau requested review of this revision. TEST PLAN Generated files match entries of existing manual

D27269: Use ecm_qt_install_logging_categories over manual categories file

kossebau added a dependency: D27150: Add ecm_qt_install_logging_categories & ecm_qt_export_logging_category. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D27269 To: kossebau, #build_system, #frameworks, broulik, mlaurent Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2,

D27269: Use ecm_qt_install_logging_categories over manual categories file

kossebau created this revision. kossebau added reviewers: Build System, Frameworks, broulik, mlaurent. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. kossebau requested review of this revision. TEST PLAN Generated file matches entries of existing manual

D27150: Add ecm_qt_install_logging_categories & ecm_qt_export_logging_category

kossebau added a dependent revision: D27269: Use ecm_qt_install_logging_categories over manual categories file. REPOSITORY R240 Extra CMake Modules BRANCH addautomaticcategoriesgeneration REVISION DETAIL https://phabricator.kde.org/D27150 To: kossebau, #build_system, #frameworks,

D27150: Add ecm_qt_install_logging_categories & ecm_qt_export_logging_category

kossebau updated this revision to Diff 75312. kossebau added a comment. Add support for also generating renamecategories files REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27150?vs=75069=75312 BRANCH addautomaticcategoriesgeneration

D27150: Add ecm_qt_install_logging_categories & ecm_qt_export_logging_category

kossebau added a comment. In D27150#608492 , @mlaurent wrote: > In D27150#608491 , @kossebau wrote: > > > In D27150#608318 , @mlaurent wrote: > > > >

D27150: Add ecm_qt_install_logging_categories & ecm_qt_export_logging_category

kossebau added a comment. In D27150#608318 , @mlaurent wrote: > Yep you need to create a file name "foo.renamecategories" where you change the categorie name > > 1. old module namenew module name > > for example "log_mailfilteragent

D27150: Add ecm_qt_install_logging_categories & ecm_qt_export_logging_category

kossebau added a comment. @mlaurent Wasn't there also something which tells kdebugsettings about renamed categories? Is that documented anywhere? Could that be supported by some additional macro or adaption of the existing/new ones? REPOSITORY R240 Extra CMake Modules BRANCH

D26394: ECMGeneratePriFile: Fix static configurations

kossebau added a comment. Pushed a8c3ab79912fcb25d7e59a04c08752a9252a5f08 as hotfix for now. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D26394 To: kfunk, dfaure, winterz, vkrause, apol Cc: kossebau, lbeltrame, cgiboudeaux, kde-frameworks-devel,

D26394: ECMGeneratePriFile: Fix static configurations

kossebau added inline comments. INLINE COMMENTS > ECMGeneratePriFile.cmake:183 > + set(PRI_TARGET_MODULE_CONFIG "") > + get_target_property(target_type ${EGPF_LIB_NAME} TYPE) > + if (target_type STREQUAL "STATIC_LIBRARY") Hmpf, this adds the firm assumption that EGPF_LIB_NAME actually is a

D27150: Add ecm_qt_install_logging_categories & ecm_qt_export_logging_category

kossebau added a comment. Good. So will land this next Tuesday, Feb 11th then, so other people will have had 7 days of feedback opportunity. REPOSITORY R240 Extra CMake Modules BRANCH addautomaticcategoriesgeneration REVISION DETAIL https://phabricator.kde.org/D27150 To: kossebau,

D27150: Add ecm_qt_install_logging_categories & ecm_qt_export_logging_category

kossebau added a comment. @mlaurent Thanks for review :) Do you happen to know any more complex usages of ecm_qt_declare_logging_category and/or manual category definitions which can and should be checked for how these new methods would work out? I have not really researched bigger parts

D27178: Use ecm_qt_install_logging_categories over manual categories file

kossebau added a comment. Another example, here with categories declared in different directories, yet a single place where the categories file is generated and installed. REPOSITORY R246 Sonnet REVISION DETAIL https://phabricator.kde.org/D27178 To: kossebau, #build_system,

D27150: Add ecm_qt_install_logging_categories & ecm_qt_export_logging_category

kossebau added a dependent revision: D27178: Use ecm_qt_install_logging_categories over manual categories file. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D27150 To: kossebau, #build_system, #frameworks, broulik, mlaurent Cc: kde-frameworks-devel,

D27178: Use ecm_qt_install_logging_categories over manual categories file

kossebau added a dependency: D27150: Add ecm_qt_install_logging_categories & ecm_qt_export_logging_category. REPOSITORY R246 Sonnet REVISION DETAIL https://phabricator.kde.org/D27178 To: kossebau, #build_system, #frameworks, broulik, mlaurent Cc: kde-frameworks-devel, LeGast00n, GB_2,

D27150: Add ecm_qt_install_logging_categories & ecm_qt_export_logging_category

kossebau updated this revision to Diff 75069. kossebau added a comment. in doc also be explicit that ecm_qt_install_logging_categories can be in another directory, just needs to be called last REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE

D27178: Use ecm_qt_install_logging_categories over manual categories file

kossebau created this revision. kossebau added reviewers: Build System, Frameworks, broulik, mlaurent. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. kossebau requested review of this revision. TEST PLAN Entries of generated file match existing file,

D27150: Add ecm_qt_install_logging_categories & ecm_qt_export_logging_category

kossebau added a comment. See D27150 as an example next to the test and docs for how this would be used. The ecm_qt_export_logging_category also is kept similar to ecm_qt_declare_logging_category in case someone wants to turn the manual definition to a

D27151: Use ecm_qt_install_logging_categories over manual categories file

kossebau added a dependency: D27150: Add ecm_qt_install_logging_categories & ecm_qt_export_logging_category. REPOSITORY R244 KCoreAddons REVISION DETAIL https://phabricator.kde.org/D27151 To: kossebau, #build_system, #frameworks, broulik, mlaurent Cc: kde-frameworks-devel, LeGast00n, GB_2,

D27151: Use ecm_qt_install_logging_categories over manual categories file

kossebau created this revision. kossebau added reviewers: Build System, Frameworks, broulik, mlaurent. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. kossebau requested review of this revision. TEST PLAN Diff of generated file matches existing file, besides

D27150: Add ecm_qt_install_logging_categories & ecm_qt_export_logging_category

kossebau added a dependent revision: D27151: Use ecm_qt_install_logging_categories over manual categories file. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D27150 To: kossebau, #build_system, #frameworks, broulik, mlaurent Cc: kde-frameworks-devel,

D27150: Add ecm_qt_install_logging_categories & ecm_qt_export_logging_category

kossebau added inline comments. INLINE COMMENTS > ECMQtDeclareLoggingCategory.cmake:76 > +# FILE > +# DESTINATION > +# [SORT] Why the need for explicit DESTINATION argument, where almost all use-cases will use ${KDE_INSTALL_LOGGINGCATEGORIESDIR}? Because

D27150: Add ecm_qt_install_logging_categories & ecm_qt_export_logging_category

kossebau created this revision. kossebau added reviewers: Build System, Frameworks, broulik, mlaurent. Herald added projects: Frameworks, Build System. Herald added subscribers: kde-buildsystem, kde-frameworks-devel. kossebau requested review of this revision. REVISION SUMMARY Having to

D26670: ki18n_wrap_ui: error when file doesn't exist

kossebau added inline comments. INLINE COMMENTS > KF5I18nMacros.cmake.in:52 > foreach (_current_FILE ${ARGN}) > - > + if(NOT EXISTS ${CMAKE_CURRENT_LIST_DIR}/${_current_FILE}) > + message(SEND_ERROR This assumes a relative path given. It might make sense to also deal with

D26626: Allow to also pass a target instead of list of sources to KCONFIG_ADD_KCFG_FILES

kossebau added a comment. While touching this file, you might want to fix this file and make it self-contained by also having a `include(CMakeParseArguments)` at the begin, could be done as direct commit, no review needed IMHO :) No comment on the actual new method API, I yet have to

D26245: Set SYSCONFDIR to /etc when CMAKE_INSTALL_SYSCONFDIR is etc relative to /usr

kossebau added a comment. (Just remember that using KDE_INSTALL_KNSRCDIR though needs at least KNewStuffCore from KF 5.57 (hint was missing in API dox, proposing D26248 to fix that).) Myself also need to reserve time to look closer at it, hoping to

D24568: Provide clang-format target with a KDE Frameworks style file

kossebau added a comment. This has been missing the link from an rst file in docs/, so the documentation generation picks up the file. Fixed with c4890d5c03ed79f0c87da861b6608bbd46c2162c REPOSITORY R240 Extra

D23550: CMake config files: use as min dep version the Qt version we built against

kossebau abandoned this revision. kossebau added a comment. Oh well, seems no-one else sees the light yet ;) Given this IMHO wrong data in the current CMake config files does not do actual harm in 99.9 % cases I will discard this for now, and just do it correctly (for what I see) only in my

D25589: ECMGenerateExportHeader: add NO_BUILD_SET_DEPRECATED_WARNINGS_SINCE flag

kossebau added a comment. In D25589#570375 , @dfaure wrote: > My head hurts a bit but I think I understand this now ;) Indeed, this gets more & more complex, I hope in time for ECM6 there are enough samples collected from real-world

D25589: ECMGenerateExportHeader: add NO_BUILD_SET_DEPRECATED_WARNINGS_SINCE flag

This revision was automatically updated to reflect the committed changes. Closed by commit R240:23d868a07712: ECMGenerateExportHeader: add NO_BUILD_SET_DEPRECATED_WARNINGS_SINCE flag (authored by kossebau). REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE

D25626: Fix EcmGenerateExportHeader tests on Windows

kossebau accepted this revision. kossebau added a comment. This revision is now accepted and ready to land. Yay, thanks for fixing this. Not sure if `if(MSVC)` is the proper condition, due to not being into the windows side of things, so that part better has someone check who enters the dark

D23550: CMake config files: use as min dep version the Qt version we built against

kossebau added a comment. Just, the built binary no longer has that theoretical minimum dependency, it needs at least the Qt version the very instance of kcoreaddons was built against. REPOSITORY R244 KCoreAddons REVISION DETAIL https://phabricator.kde.org/D23550 To: kossebau,

D23550: CMake config files: use as min dep version the Qt version we built against

kossebau added a comment. In D23550#569552 , @cgiboudeaux wrote: > In D23550#569485 , @kossebau wrote: > > > ping :) No-one any opinion? > > > Sure :) > -1. The Config file is supposed to

D23550: CMake config files: use as min dep version the Qt version we built against

kossebau added a comment. ping :) No-one any opinion? REPOSITORY R244 KCoreAddons REVISION DETAIL https://phabricator.kde.org/D23550 To: kossebau, #frameworks, #build_system Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24990: KDEFrameworkCompilerSettings: enable all Qt % KF deprecation warnings

kossebau added a comment. In D24990#564667 , @kossebau wrote: > Hm, only noticed now that this actually has an unwanted sideeffects: it triggers deprecation warnings for all deprecated warning also inside each library itself. Which is not what

D25589: ECMGenerateExportHeader: add NO_BUILD_SET_DEPRECATED_WARNINGS_SINCE flag

kossebau created this revision. kossebau added reviewers: Build System, Frameworks, dfaure. Herald added projects: Frameworks, Build System. Herald added subscribers: kde-buildsystem, kde-frameworks-devel. kossebau requested review of this revision. REVISION SUMMARY The original intention has

D24990: KDEFrameworkCompilerSettings: enable all Qt % KF deprecation warnings

kossebau added a comment. In D24990#564670 , @dfaure wrote: > So we need to set FOO_DISABLE_DEPRECATED_BEFORE_AND_AT to N-1 while building FOO itself, right? Either magically here, or manually in every module... Nono,

D24990: KDEFrameworkCompilerSettings: enable all Qt % KF deprecation warnings

kossebau added a comment. Hm, only noticed now that this actually has an unwanted sideeffects: it triggers deprecation warnings for all deprecated warning also inside each library itself. Which is not what one wants. Because so far FOO_DISABLE_DEPRECATED_BEFORE_AND_AT as set while

D24990: KDEFrameworkCompilerSettings: enable all Qt % KF deprecation warnings

This revision was automatically updated to reflect the committed changes. Closed by commit R240:879769daf047: KDEFrameworkCompilerSettings: enable all Qt % KF deprecation warnings (authored by kossebau). REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE

D24990: KDEFrameworkCompilerSettings: enable all Qt % KF deprecation warnings

kossebau added a comment. Merci, will land later tonight. Bonnes vacances :) REPOSITORY R240 Extra CMake Modules BRANCH enableallqtkfdeprecationwarningsforframeworks REVISION DETAIL https://phabricator.kde.org/D24990 To: kossebau, #frameworks, #build_system, apol, dfaure Cc: dfaure,

D24990: KDEFrameworkCompilerSettings: enable all Qt % KF deprecation warnings

kossebau added a subscriber: dfaure. kossebau added a comment. @dfaure Hi. Any chance you you can sneak in before you are away (enjoy :) ) to remove the "-DQT_DEPRECATED_WARNINGS_SINCE=0x06" from all the KF modules in the next days? Otherwise would land this here with just the

D24990: KDEFrameworkCompilerSettings: enable all Qt % KF deprecation warnings

kossebau created this revision. kossebau added reviewers: Frameworks, Build System. Herald added projects: Frameworks, Build System. Herald added subscribers: kde-buildsystem, kde-frameworks-devel. kossebau requested review of this revision. REPOSITORY R240 Extra CMake Modules BRANCH

D24841: Use modern way to set the C/CXX standard

kossebau added a comment. In D24841#552842 , @vonreth wrote: > Where are those tests running? I'm only aware of https://build.kde.org/job/Frameworks/job/extra-cmake-modules/ The tests are currntly sadly skipped on CI, compare T11858

D24568: Provide clang-format target with a common KDE style file

kossebau added subscribers: nalvarez, ochurlaud. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D24568 To: cullmann, #frameworks Cc: ochurlaud, nalvarez, kossebau, aacid, davidedmundson, dhaumann, apol, ognarb, kde-frameworks-devel, kde-buildsystem,

D24568: Provide clang-format target with a common KDE style file

kossebau added a comment. There is also https://techbase.kde.org/Policies/Frameworks_Coding_Style which though missed the move from techbase to community, other than the other policies. I suspect that page should be moved over now as well, to become the real KF coding style page (so

D23789: Add ECMGenerateExportHeader, for improved handling of deprecated API

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R240:7b15c20dafc9: Add ECMGenerateExportHeader, for improved handling of deprecated API (authored by kossebau). CHANGED

D23789: Add ECMGenerateExportHeader, for improved handling of deprecated API

kossebau added a comment. To keep the momentum, now going to merge, given there was no objection when I pointed out the plan to move forward both here and in the email to frameworks-devel. I assume no-one has time enough to wrap their brain around this as well and/or too many other

D23789: Add ECMGenerateExportHeader, for improved handling of deprecated API

kossebau updated this revision to Diff 67620. kossebau marked an inline comment as done. kossebau added a comment. switch to do generation-time decision about deprecated(text) attribute usage GCC/Clang are mostly ABI-compatible, so mixing and linking of artifacts from both compilers can

D23789: Add ECMGenerateExportHeader, for improved handling of deprecated API

kossebau retitled this revision from "Add ECMGenerateExportHeaders, for improved handling of deprecated API" to "Add ECMGenerateExportHeader, for improved handling of deprecated API". REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D23789 To: kossebau,

D23789: Add ECMGenerateExportHeaders, for improved handling of deprecated API

kossebau updated this revision to Diff 67584. kossebau added a comment. improve documentation, especially about the generated C++ macros REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23789?vs=67554=67584 BRANCH addgenerateexportheader

D23789: Add ECMGenerateExportHeaders, for improved handling of deprecated API

kossebau marked 2 inline comments as done. kossebau added inline comments. INLINE COMMENTS > dfaure wrote in ECMGenerateExportHeader.cmake:269 > Really? Isn't doWhat excluded only if EXCLUDE_DEPRECATED_BEFORE_AND_AT is set > to 5.12.0? > With 5.0.0 it's still available, no? > > I'm also

D23789: Add ECMGenerateExportHeaders, for improved handling of deprecated API

kossebau updated this revision to Diff 67554. kossebau marked an inline comment as done. kossebau added a comment. - update to David's findings in the docs REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23789?vs=67523=67554 BRANCH

D20984: Add ECMAddQmlModule

kossebau added a dependent revision: D21356: Port to ECMAddQmlModule, add plugins.qmltypes files. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D20984 To: kossebau, #plasma, apol Cc: apol, kde-frameworks-devel, kde-buildsystem, LeGast00n, GB_2, bencreasy,

D20984: Add ECMAddQmlModule

kossebau added a dependent revision: D21344: Port to ECMAddQmlModule. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D20984 To: kossebau, #plasma, apol Cc: apol, kde-frameworks-devel, kde-buildsystem, LeGast00n, GB_2, bencreasy, michaelh, ngraham, bruns

D20984: Add ECMAddQmlModule

kossebau abandoned this revision. kossebau added a comment. @apol Thanks again for your review work. I am still a bit unsure about the usefulness and completeness of this macro, even more as I would not call myself a QML expert who has seen all corners. And given the lack of feedback

D23789: Add ECMGenerateExportHeaders, for improved handling of deprecated API

kossebau added a comment. So, given the lack of further change proposals or objections, I would proceed to push this in the next days (Thurday evening or Friday morning), to have 3 weeks of pre-5.64 real world testing by CI and people running from git master. See also

D23789: Add ECMGenerateExportHeaders, for improved handling of deprecated API

kossebau updated this revision to Diff 67523. kossebau added a comment. - add missing group defaulting for warning settings, got lost in rebase before REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23789?vs=67324=67523 BRANCH

D23789: Add ECMGenerateExportHeaders, for improved handling of deprecated API

kossebau added reviewers: Frameworks, Build System. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D23789 To: kossebau, #frameworks, #build_system Cc: chehrlic, dfaure, cgiboudeaux, kde-frameworks-devel, kde-buildsystem, LeGast00n, GB_2, bencreasy,

D23789: Add ECMGenerateExportHeaders, for improved handling of deprecated API

kossebau retitled this revision from "RFC: Add ECMGenerateExportHeaders, for improved handling of deprecated API" to "Add ECMGenerateExportHeaders, for improved handling of deprecated API". REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D23789 To: kossebau

D23789: RFC: Add ECMGenerateExportHeaders, for improved handling of deprecated API

kossebau updated this revision to Diff 67324. kossebau added a comment. - extend unit tests to cover library group macro variants Sadly blows up by all combinations unit test time to >1 min on old machine REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE

D23789: RFC: Add ECMGenerateExportHeaders, for improved handling of deprecated API

kossebau added a comment. In D23789#540033 , @dfaure wrote: > I found confirmation in cmake's Tests/RunCMake/GenerateExportHeader/reference/ Not sure what you exactly mean, can you please specify confirmation for what? And what this

D23789: RFC: Add ECMGenerateExportHeaders, for improved handling of deprecated API

kossebau updated this revision to Diff 67220. kossebau added a comment. - extend *_VERSION_DEPRECATED to expect third argument "text" first experimental consumption time support for "text" output with GCC compiler - make *_NO_DEPRECATED a proper shortcut for DISABLE_BEFORE_AND_AT=CURRENT

D23789: RFC: Add ECMGenerateExportHeaders, for improved handling of deprecated API

kossebau added a comment. In D23789#539940 , @dfaure wrote: > I see the theoretical problem, but how could this ever be a problem in practice? > On Unix all compilers support the same syntax (`__attribute__ ((__deprecated__))`), so you'd

D23789: RFC: Add ECMGenerateExportHeaders, for improved handling of deprecated API

kossebau added a comment. Quick Update (week 40): Locally have added experimental code to even set the proper attribute for GCC compiler, so we get e.g.: /home/koder/Kode/kdegit/kf5/frameworks/kparts/tests/notepad.cpp: In constructor ‘NotepadPart::NotepadPart(QWidget*, QObject*,

D23789: RFC: Add ECMGenerateExportHeaders, for improved handling of deprecated API

kossebau added a comment. Thanks for your reply, Christian :) In D23789#538876 , @chehrlic wrote: > In D23789#536338 , @kossebau wrote: > > > Actual questions I have: > > > > - why is

D23789: RFC: Add ECMGenerateExportHeaders, for improved handling of deprecated API

kossebau updated this revision to Diff 66670. kossebau added a comment. add first set of unit tests covering the main functionality. Feedback on principal approach wanted! Also add some fixes to actual macro code found by the tests already :) REPOSITORY R240 Extra CMake Modules

D24159: new module ECMSourceVersionControl

kossebau added a comment. In D24159#536388 , @kossebau wrote: > Should the new module be part of public ECM macros? Then it misses a documentation linking file `docs/module/ECMSourceVersionControl.rst` I am blind, ignore me. REPOSITORY

D24159: new module ECMSourceVersionControl

kossebau added a comment. Should the new module be part of public ECM macros? Then it misses a documentation linking file `docs/module/ECMSourceVersionControl.rst` Would be also good to have this variable being set mentioned in KDECompilerSettings, unless this is also not under public

D23789: RFC: Add ECMGenerateExportHeaders, for improved handling of deprecated API

kossebau added a subscriber: chehrlic. kossebau added a comment. @chehrlic Hi. As I just discovered, you are the author of the macros for Qt (commit ) which I took as inspiration/blue print when

  1   2   3   4   >