Am Freitag, 19. September 2014, 22:57:40 schrieb René J.V. Bertin:
On Sept. 20, 2014, 12:26 a.m., Christoph Feck wrote:
You added APPLE to the if() but not always to the matching endif()...
True. But that's optional, no?
The endif needs to have either a matching argument to the last if or
On Sept. 20, 2014, 12:26 a.m., Christoph Feck wrote:
You added APPLE to the if() but not always to the matching endif()...
René J.V. Bertin wrote:
True. But that's optional, no?
On Saturday September 20 2014, Rolf Eike Beer wrote regarding Re: Review
Request 120287: [OS X] make
On Sept. 19, 2014, 10:24 nachm., Martin Gräßlin wrote:
overall I rather tend to -1 for these changes. I consider changing the
build system in a long term release as way too risky considering that the
core development doesn't use this iteration any more. Any unintended
breakage (e.g.
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120287/#review67023
---
CMakeLists.txt
On Sept. 20, 2014, 10:20 a.m., Martin Gräßlin wrote:
CMakeLists.txt, lines 225-234
https://git.reviewboard.kde.org/r/120287/diff/3/?file=313626#file313626line225
tabs instead of whitespaces
I looked into those yesterday, and cannot find tabs on my end. No idea where
they'd come
On Sept. 20, 2014, 10:20 vorm., Martin Gräßlin wrote:
CMakeLists.txt, lines 225-234
https://git.reviewboard.kde.org/r/120287/diff/3/?file=313626#file313626line225
tabs instead of whitespaces
René J.V. Bertin wrote:
I looked into those yesterday, and cannot find tabs on my
On Sept. 20, 2014, 10:25 vorm., René J.V. Bertin wrote:
While we're discussing krdb's function on non-X11 systems:
I seem to recall that the colour theme selector kcm had an effect like it
has under X11: applying the new theme to running applications instantly. I
can no longer
On Sept. 20, 2014, 10:20 vorm., Martin Gräßlin wrote:
libs/CMakeLists.txt, line 10
https://git.reviewboard.kde.org/r/120287/diff/3/?file=313630#file313630line10
why is that Darwin and all other cases are APPLE?
René J.V. Bertin wrote:
Good one. Look just a bit down from that
On Sept. 20, 2014, 10:20 a.m., Martin Gräßlin wrote:
kcontrol/krdb/krdb.cpp, line 56
https://git.reviewboard.kde.org/r/120287/diff/3/?file=313628#file313628line56
added newline
Ah, the famous German rigor ... is this really an issue, shouldn't that empty
line have been there in
On Sept. 20, 2014, 10:20 vorm., Martin Gräßlin wrote:
kcontrol/krdb/krdb.cpp, line 56
https://git.reviewboard.kde.org/r/120287/diff/3/?file=313628#file313628line56
added newline
René J.V. Bertin wrote:
Ah, the famous German rigor ... is this really an issue, shouldn't that
On Sept. 20, 2014, 8:20 vorm., Martin Gräßlin wrote:
kcontrol/krdb/krdb.cpp, line 56
https://git.reviewboard.kde.org/r/120287/diff/3/?file=313628#file313628line56
added newline
René J.V. Bertin wrote:
Ah, the famous German rigor ... is this really an issue, shouldn't that
On Sept. 20, 2014, 10:25 a.m., René J.V. Bertin wrote:
While we're discussing krdb's function on non-X11 systems:
I seem to recall that the colour theme selector kcm had an effect like it
has under X11: applying the new theme to running applications instantly. I
can no longer
On Sept. 20, 2014, 10:20 a.m., Martin Gräßlin wrote:
kcontrol/krdb/krdb.cpp, line 56
https://git.reviewboard.kde.org/r/120287/diff/3/?file=313628#file313628line56
added newline
René J.V. Bertin wrote:
Ah, the famous German rigor ... is this really an issue, shouldn't that
On Sept. 18, 2014, 9:19 vorm., Thomas Lübking wrote:
drkonqi/main.cpp, line 47
https://git.reviewboard.kde.org/r/119498/diff/2/?file=312509#file312509line47
this sounds fishy - at least the comment to be incorrect?
i hope that OSX does not just actually abort() when you call
On Sept. 20, 2014, 8:20 vorm., Martin Gräßlin wrote:
kcontrol/krdb/krdb.cpp, line 56
https://git.reviewboard.kde.org/r/120287/diff/3/?file=313628#file313628line56
added newline
René J.V. Bertin wrote:
Ah, the famous German rigor ... is this really an issue, shouldn't that
On Sept. 18, 2014, 11:19 a.m., Thomas Lübking wrote:
drkonqi/main.cpp, line 47
https://git.reviewboard.kde.org/r/119498/diff/2/?file=312509#file312509line47
this sounds fishy - at least the comment to be incorrect?
i hope that OSX does not just actually abort() when you call
On Sept. 20, 2014, 10:20 a.m., Martin Gräßlin wrote:
kcontrol/krdb/krdb.cpp, line 56
https://git.reviewboard.kde.org/r/120287/diff/3/?file=313628#file313628line56
added newline
René J.V. Bertin wrote:
Ah, the famous German rigor ... is this really an issue, shouldn't that
On Juli 29, 2014, 3:33 nachm., Aleix Pol Gonzalez wrote:
kinit/kinit.cpp, line 1481
https://git.reviewboard.kde.org/r/119497/diff/1/?file=293442#file293442line1481
do you need $DISPLAY in OS X?
René J.V. Bertin wrote:
Nope. It can be set if the user has XQuartz installed and
On Sept. 20, 2014, 10:20 a.m., Martin Gräßlin wrote:
CMakeLists.txt, lines 225-234
https://git.reviewboard.kde.org/r/120287/diff/3/?file=313626#file313626line225
tabs instead of whitespaces
René J.V. Bertin wrote:
I looked into those yesterday, and cannot find tabs on my
On Sept. 18, 2014, 9:19 vorm., Thomas Lübking wrote:
drkonqi/main.cpp, line 47
https://git.reviewboard.kde.org/r/119498/diff/2/?file=312509#file312509line47
this sounds fishy - at least the comment to be incorrect?
i hope that OSX does not just actually abort() when you call
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120287/
---
(Updated Sept. 20, 2014, 12:51 p.m.)
Review request for KDE Software on
-226bc0673aa1__patchreview-20140920.patch
Thanks,
René J.V. Bertin
, which had no tabs when I uploaded it
https://git.reviewboard.kde.org/media/uploaded/files/2014/09/20/b212730f-6258-4277-851c-226bc0673aa1__patchreview-20140920.patch
Thanks,
René J.V. Bertin
it.
Checksum: 3989cdd46af3c891e570974d66c330403dcd41c4ee5e17a372fa385080cbabd1
https://git.reviewboard.kde.org/media/uploaded/files/2014/09/20/b212730f-6258-4277-851c-226bc0673aa1__patchreview-20140920.patch
Thanks,
René J.V. Bertin
: 3989cdd46af3c891e570974d66c330403dcd41c4ee5e17a372fa385080cbabd1
https://git.reviewboard.kde.org/media/uploaded/files/2014/09/20/b212730f-6258-4277-851c-226bc0673aa1__patchreview-20140920.patch
Thanks,
René J.V. Bertin
, which had no tabs when I uploaded it.
Checksum: 3989cdd46af3c891e570974d66c330403dcd41c4ee5e17a372fa385080cbabd1
https://git.reviewboard.kde.org/media/uploaded/files/2014/09/20/b212730f-6258-4277-851c-226bc0673aa1__patchreview-20140920.patch
Thanks,
René J.V. Bertin
it.
Checksum: 3989cdd46af3c891e570974d66c330403dcd41c4ee5e17a372fa385080cbabd1
https://git.reviewboard.kde.org/media/uploaded/files/2014/09/20/b212730f-6258-4277-851c-226bc0673aa1__patchreview-20140920.patch
Thanks,
René J.V. Bertin
when I uploaded it.
Checksum: 3989cdd46af3c891e570974d66c330403dcd41c4ee5e17a372fa385080cbabd1
https://git.reviewboard.kde.org/media/uploaded/files/2014/09/20/b212730f-6258-4277-851c-226bc0673aa1__patchreview-20140920.patch
Thanks,
René J.V. Bertin
copy of the diff file saved locally, which had no tabs when I uploaded it.
Checksum: 3989cdd46af3c891e570974d66c330403dcd41c4ee5e17a372fa385080cbabd1
https://git.reviewboard.kde.org/media/uploaded/files/2014/09/20/b212730f-6258-4277-851c-226bc0673aa1__patchreview-20140920
://git.reviewboard.kde.org/media/uploaded/files/2014/09/20/b212730f-6258-4277-851c-226bc0673aa1__patchreview-20140920.patch
Thanks,
René J.V. Bertin
had no tabs when I uploaded it.
Checksum: 3989cdd46af3c891e570974d66c330403dcd41c4ee5e17a372fa385080cbabd1
https://git.reviewboard.kde.org/media/uploaded/files/2014/09/20/b212730f-6258-4277-851c-226bc0673aa1__patchreview-20140920.patch
Thanks,
René J.V. Bertin
-226bc0673aa1__patchreview-20140920.patch
Thanks,
René J.V. Bertin
: 3989cdd46af3c891e570974d66c330403dcd41c4ee5e17a372fa385080cbabd1
https://git.reviewboard.kde.org/media/uploaded/files/2014/09/20/b212730f-6258-4277-851c-226bc0673aa1__patchreview-20140920.patch
Thanks,
René J.V. Bertin
://git.reviewboard.kde.org/media/uploaded/files/2014/09/20/b212730f-6258-4277-851c-226bc0673aa1__patchreview-20140920.patch
Thanks,
René J.V. Bertin
: 3989cdd46af3c891e570974d66c330403dcd41c4ee5e17a372fa385080cbabd1
https://git.reviewboard.kde.org/media/uploaded/files/2014/09/20/b212730f-6258-4277-851c-226bc0673aa1__patchreview-20140920.patch
Thanks,
René J.V. Bertin
saved locally, which had no tabs when I uploaded it.
Checksum: 3989cdd46af3c891e570974d66c330403dcd41c4ee5e17a372fa385080cbabd1
https://git.reviewboard.kde.org/media/uploaded/files/2014/09/20/b212730f-6258-4277-851c-226bc0673aa1__patchreview-20140920.patch
Thanks,
René J.V. Bertin
-851c-226bc0673aa1__patchreview-20140920.patch
Thanks,
René J.V. Bertin
: 3989cdd46af3c891e570974d66c330403dcd41c4ee5e17a372fa385080cbabd1
https://git.reviewboard.kde.org/media/uploaded/files/2014/09/20/b212730f-6258-4277-851c-226bc0673aa1__patchreview-20140920.patch
Thanks,
René J.V. Bertin
On July 29, 2014, 3:33 p.m., Aleix Pol Gonzalez wrote:
kinit/kinit.cpp, line 1481
https://git.reviewboard.kde.org/r/119497/diff/1/?file=293442#file293442line1481
do you need $DISPLAY in OS X?
René J.V. Bertin wrote:
Nope. It can be set if the user has XQuartz installed and
: 3989cdd46af3c891e570974d66c330403dcd41c4ee5e17a372fa385080cbabd1
https://git.reviewboard.kde.org/media/uploaded/files/2014/09/20/b212730f-6258-4277-851c-226bc0673aa1__patchreview-20140920.patch
Thanks,
René J.V. Bertin
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119372/#review67082
---
Ship it!
Ship It!
- David Faure
On Sept. 19, 2014, 11:56
On Juli 29, 2014, 3:33 nachm., Aleix Pol Gonzalez wrote:
kinit/kinit.cpp, line 1481
https://git.reviewboard.kde.org/r/119497/diff/1/?file=293442#file293442line1481
do you need $DISPLAY in OS X?
René J.V. Bertin wrote:
Nope. It can be set if the user has XQuartz installed and
On July 29, 2014, 3:33 p.m., Aleix Pol Gonzalez wrote:
kinit/kinit.cpp, line 1481
https://git.reviewboard.kde.org/r/119497/diff/1/?file=293442#file293442line1481
do you need $DISPLAY in OS X?
René J.V. Bertin wrote:
Nope. It can be set if the user has XQuartz installed and
On Sept. 19, 2014, 10:16 vorm., Ben Cooksley wrote:
Unless anyone has any objections in the next 24 hours, I think this can go
in as it makes Dr Konqi usable on another platform.
+1 - Shit It ... from my side.
Certainly no technical concerns remaining here - but i'm not the code
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119498/#review67098
---
Ship it!
Ship It!
- Ian Wadham
On Sept. 18, 2014, 10:57
45 matches
Mail list logo
