submitted the
bug-report and also has written the patch.
Diffs
-
kdecore/services/kmimetype.cpp 955bf62
kdecore/services/kmimetyperepository.cpp 6ff3d16
Diff: http://git.reviewboard.kde.org/r/102391/diff/
Testing
---
Thanks,
Peter Penz
no review-request would have
been necessary for this fix, but of course it is exemplary doing it this way
:-))
- Peter Penz
On June 18, 2012, 1:47 a.m., Jekyll Wu wrote:
---
This is an automatically generated e-mail. To reply, visit:
http
On 06/10/2012 11:20 AM, Aaron J. Seigo wrote:
On Sunday, June 10, 2012 03:23:04 José Manuel SantamarÃa Lema wrote:
#1 dolphin:
#2 gwenview
#6 kontact executing various components: calendar, to-do list, journal
#7 kmail links
these are all the same crash, or at least related to each other. it
. So I've only added a
small comment to the signal...
- Peter Penz
On May 19, 2012, 6:54 a.m., Hui Ni wrote:
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104988
during the next days.
- Peter Penz
On April 16, 2012, 1:26 p.m., Dawit Alemayehu wrote:
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104614
On April 16, 2012, 2:03 p.m., Peter Penz wrote:
Thanks for the patch, I've not been aware that this caching-issue can be
solved like this :-) I guess this patch has not been applied to the latest
master: DolphinView does not have a dir-lister anymore (it has been moved
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104033/#review10769
---
Ship it!
Thanks for the patch, looks fine!
- Peter Penz
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103730/#review9929
---
Ship it!
Thanks for the patch, looks fine!
- Peter Penz
. Definitely a go
from a Dolphin point of view to get this in before 4.8.0 got tagged. Thanks a
lot for this patch - I stumbled above those issues myself already but did not
have the time yet to check KFilePlacesView...
- Peter Penz
On Jan. 12, 2012, 4:42 p.m., Christoph Feck wrote
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103040/#review7928
---
Ship it!
Thanks Christoph, looks perfect!
- Peter Penz
On Oct. 5, 2011, 11:30 a.m., David Faure wrote:
Why the setMaxLength?? What if one wants to type in a long URL?
Also, I can't reproduce the bug here (kde-4.7), but maybe only because the
big icon button makes the dialog quite large?
Greg T wrote:
indeed, the setmaxLength was
:-(
- Peter Penz
On Oct. 3, 2011, 1:25 a.m., Andrius da Costa Ribas wrote:
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102758
On Oct. 3, 2011, 7:28 a.m., Peter Penz wrote:
I always recommend to get in contact with the maintainers of an application
_before_ investigating so much work into a new feature. In this case I'm
very sorry to say that this cannot get pushed because of the following
reasons:
- I'm
On Sept. 6, 2011, 4:28 p.m., Sebastian Doerner wrote:
Looks good to me. Peter, are you fine with this? The plugin itself will
follow next.
Peter Penz wrote:
@Frank: I'm fine with the interface extensions!
@Vishesh: Thanks for the patch, it looks fine. Please give me
request for KDE Base Apps and Peter Penz.
Summary
---
Zoom DolphinView when mouse wheel is scrolled with CRTL button pressed.
Diffs
-
dolphin/src/kitemviews/kitemlistcontainer.cpp 0d2637d
dolphin/src/views/dolphinview.h 7c81ea8
dolphin/src/views/dolphinview.cpp 0991401
Apps and Peter Penz.
Summary
---
Zoom DolphinView when mouse wheel is scrolled with CRTL button pressed.
Diffs
-
dolphin/src/kitemviews/kitemlistcontainer.cpp 0d2637d
dolphin/src/views/dolphinview.h 7c81ea8
dolphin/src/views/dolphinview.cpp 0991401
Diff: http
/
---
(Updated Aug. 29, 2011, 9:14 a.m.)
Review request for KDE Base Apps and Peter Penz.
Summary
---
Allow opening files and directories by pressing 'Enter' key. In case multiple
files are selected when enter is pressed, all of them are opened. In case of
multiple directories
On Aug. 29, 2011, 9:40 a.m., Peter Penz wrote:
Thanks for the update! Looks good and is exactly like the proposal you,
Frank and I discussed per e-mail. As usual I've added a punch of my
nitpicking stuff ;-) Please push it to master after fixing, you don't need
to add another diff
:
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102447/
---
(Updated Aug. 26, 2011, 8:51 p.m.)
Review request for KDE Base Apps and Peter Penz
:
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102447/
---
(Updated Aug. 27, 2011, 7:31 a.m.)
Review request for KDE Base Apps and Peter Penz.
Summary
---
Honours the KGlobalSettings
On Aug. 27, 2011, 9:31 a.m., Peter Penz wrote:
Thanks for the update, but could you please revert the changes with
KGlobalSettings::changeCursorOverIcon()? I consider this option an
unnecessary micro-option and plan to implement the same behavior as in
Dolphin 1.7.
Tirtha
:
http://git.reviewboard.kde.org/r/102465/
---
(Updated Aug. 27, 2011, 8:36 p.m.)
Review request for KDE Base Apps and Peter Penz.
Summary
---
This patch allows finding items by typing on the keyboard while
On Aug. 27, 2011, 9:08 p.m., Peter Penz wrote:
Thanks for this patch. As discussed per e-mail already I think from a
design point of view this is fine and the patch looks good! I've added
quite a lot of nitpicking comments, would be great if you could fix those
things and do one
/
---
(Updated Aug. 25, 2011, 7:23 p.m.)
Review request for KDE Base Apps and Peter Penz.
Summary
---
Currently, if a file is deleted by an external application, and the directory
containing that file is open in Dolphin, the change
On Aug. 20, 2011, 3 p.m., Commit Hook wrote:
This review has been submitted with commit
ae3b7a48ec0e34ac64c5531ec45b1f898594898a by Peter Penz to branch KDE/4.7.
Thanks for the update of the patch, it works nice now! I did some minor
modifications (the button should not trigger
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102391/
---
Review request for kdelibs and David Faure.
Summary
---
If
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102345/#review5783
---
Thanks for the patch! I agree that the KUrlNavigator should be
:
http://git.reviewboard.kde.org/r/102328/
---
(Updated Aug. 15, 2011, 1:16 p.m.)
Review request for KDE Base Apps and Peter Penz.
Summary
---
This patch applies to dolphin/src/views/renamedialog.cpp and
dolphin/src/views
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102319/#review5683
---
Ship it!
Thanks for the patch, looks fine! Please push it to
On Aug. 14, 2011, 10:31 a.m., Peter Penz wrote:
Thanks for the patch, looks fine! Please push it to master (if you don't
have a git-account please let me know and I'll push it for you)
Jussi Judin wrote:
No I don't so you need to do it.
I've pushed it to master now :-)
- Peter
On July 11, 2011, 9 p.m., Peter Penz wrote:
Thanks for the patch, looks good!
Peter Penz wrote:
Committed to 4.7 (is already fixed for Dolphin 2.0 that will get merged
to master around beginning of August)
Marcel Partap wrote:
still nothing pushed to public repo. huh
/
---
(Updated July 11, 2011, 9:25 p.m.)
Review request for KDE Base Apps, David Faure and Peter Penz.
Summary
---
The auto-calculated width of columns always is same regardless of custom font
style so there was sure
://git.reviewboard.kde.org/r/101924/
---
(Updated July 11, 2011, 9:39 p.m.)
Review request for KDE Base Apps, David Faure and Peter Penz.
Summary
---
What was strange that background highlighting and actual item selection were
/
---
(Updated July 11, 2011, 9:39 p.m.)
Review request for KDE Base Apps, David Faure and Peter Penz.
Summary
---
What was strange that background highlighting and actual item selection were
drawn independently from each other and the bogus highlighting
/
---
(Updated June 12, 2011, 8:21 p.m.)
Review request for KDE Base Apps and Peter Penz.
Summary
---
Using Dolphin in default mode in master /4.7.) whithout menubar the user has
no actions to report a bug or switch language. Patch adds
.)
Review request for kdelibs, David Faure and Peter Penz.
Summary
---
This way it is easier to recognise links to images etc.
Depends on https://git.reviewboard.kde.org/r/101569/
This addresses bug 190579.
http://bugs.kde.org/show_bug.cgi?id=190579
Diffs
/
---
(Updated June 10, 2011, 7:52 p.m.)
Review request for KDE Base Apps and Peter Penz.
Summary
---
Depends on https://git.reviewboard.kde.org/r/101569/
This addresses bug 190579.
http://bugs.kde.org/show_bug.cgi?id=190579
Diffs
-
dolphin/src
/
---
(Updated June 10, 2011, 10:11 p.m.)
Review request for KDE Base Apps and Peter Penz.
Summary
---
That way if a wrong protocol had been entered the currently watched directory
will be returned.
This addresses bug 274890.
http://bugs.kde.org/show_bug.cgi?id=274890
Diffs
. To reply, visit:
http://git.reviewboard.kde.org/r/101449/
---
(Updated May 27, 2011, 4:04 p.m.)
Review request for KDE Base Apps and Peter Penz.
Summary
---
If no item is selected then pressing right moves to a column view
/
---
(Updated May 27, 2011, 4:04 p.m.)
Review request for KDE Base Apps and Peter Penz.
Summary
---
If no item is selected then pressing right moves to a column view with child
url, instead of the first index.
This addresses bug 263110.
http://bugs.kde.org/show_bug.cgi?id
:
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101454/
---
(Updated May 27, 2011, 10:19 p.m.)
Review request for KDE Base Apps and Peter Penz.
Summary
---
So far this works only
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101096/#review2571
---
Ship it!
Thanks, looks good!
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101076/#review2551
---
Ship it!
Thanks, looks good!
- Peter
On April 10, 2011,
On March 10, 2011, 8:05 a.m., Peter Penz wrote:
Thanks a lot for this good patch, please commit :-) Would also be great if
this could be backported to 4.6.2.
I've committed the patch and backported it to 4.6.
- Peter
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100717/
---
Review request for kdelibs and David Faure.
Summary
---
The patch
---
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/6332/#review9634
---
Looks good from my point of view! I'd still suggest to wait a few
/
---
(Updated Jan. 10, 2011, 10:24 a.m.)
Review request for kdelibs and Peter Penz.
Summary
---
When sorting by name KDirSortFilterProxyModel uses UDS_DISPLAY_NAME. The
latter, however, is not unique. This results in strange GUI behaviour like
swapping items. This patch
---
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/6267/
---
Review request for kdelibs and Kevin Ottens.
Summary
---
For KDE SC
48 matches
Mail list logo
