Re: Review Request 122320: use xcb-screen count instead of qguiapplication.screens

2015-02-04 Thread Nick Shaforostoff
could run kcminit_startup and reboot also went fine. Thanks, Nick Shaforostoff

Re: Review Request 122320: use xcb-screen count instead of qguiapplication.screens

2015-02-04 Thread Nick Shaforostoff
--- On Фев. 4, 2015, 12:31 д.п., Nick Shaforostoff wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122320

Re: Review Request 122320: use xcb-screen count instead of qguiapplication.screens

2015-02-03 Thread Nick Shaforostoff
:15 після полудня, Nick Shaforostoff wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122320/ --- (Updated Лют. 2, 2015, 9

Re: Review Request 122320: use xcb-screen count instead of qguiapplication.screens

2015-02-03 Thread Nick Shaforostoff
to do something like: if (XCB_XCB_FOUND) target_link_libraries(kdeinit_kcminit XCB::XCB) endif() Nick Shaforostoff wrote: it compiles even if i remove find_package(XCB) -- XCB::XCB variable is just empty then update: probably this is because XCB is already found

Re: Review Request 122320: use xcb-screen count instead of qguiapplication.screens

2015-02-02 Thread Nick Shaforostoff
on ubuntu vivid alpha 32-bit, replaced binaries and libraries in the system and successfuly could run kcminit_startup and reboot also went fine. Thanks, Nick Shaforostoff

Re: Review Request 122320: use xcb-screen count instead of qguiapplication.screens

2015-01-31 Thread Nick Shaforostoff
and successfuly could run kcminit_startup and reboot also went fine. Thanks, Nick Shaforostoff

Re: Review Request 122270: port kcminit away from kdelibs4support

2015-01-29 Thread Nick Shaforostoff
--list' and kcminit AAA Thanks, Nick Shaforostoff

Re: Review Request 122270: port kcminit away from kdelibs4support

2015-01-29 Thread Nick Shaforostoff
--- On Січ. 29, 2015, 11:58 до полудня, Nick Shaforostoff wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122270

Re: Review Request 122270: port kcminit away from kdelibs4support

2015-01-29 Thread Nick Shaforostoff
it, the QGuiApplication::screens().count() 1 check is, as has been pointed out in this review several times, still wrong for sure. Do you intend to keep working on this code? (to get rid of QGuiApplication and perhaps the ini read) Nick Shaforostoff wrote: sorry, should i revert the commit

Review Request 122320: use xcb-screen count instead of qguiapplication.screens

2015-01-29 Thread Nick Shaforostoff
/main.cpp 1008966 Diff: https://git.reviewboard.kde.org/r/122320/diff/ Testing --- i have built kcminit on ubuntu vivid alpha 32-bit, replaced binaries and libraries in the system and successfuly could run kcminit_startup and reboot also went fine. Thanks, Nick Shaforostoff

Re: Review Request 122270: port kcminit away from kdelibs4support

2015-01-28 Thread Nick Shaforostoff
an xcb_connection_t - if that fails we don't have an X-Server. If it succeeds we can check the number of screens. Nick Shaforostoff wrote: understood, but the question remains: is kcminit the best place to do multihead-related stuff? Thomas Lübking wrote: It's required by KApplication and while

Re: Review Request 122270: port kcminit away from kdelibs4support

2015-01-28 Thread Nick Shaforostoff
an xcb_connection_t - if that fails we don't have an X-Server. If it succeeds we can check the number of screens. Nick Shaforostoff wrote: understood, but the question remains: is kcminit the best place to do multihead-related stuff? Thomas Lübking wrote: It's required by KApplication and while

Re: Review Request 122270: port kcminit away from kdelibs4support

2015-01-28 Thread Nick Shaforostoff
' and kcminit AAA Thanks, Nick Shaforostoff

Re: Review Request 122270: port kcminit away from kdelibs4support

2015-01-28 Thread Nick Shaforostoff
an xcb_connection_t - if that fails we don't have an X-Server. If it succeeds we can check the number of screens. Nick Shaforostoff wrote: understood, but the question remains: is kcminit the best place to do multihead-related stuff? Thomas Lübking wrote: It's required by KApplication and while

Re: Review Request 122270: port kcminit away from kdelibs4support

2015-01-27 Thread Nick Shaforostoff
generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122270/#review74806 --- On Січ. 27, 2015, 3:10 до полудня, Nick Shaforostoff wrote: --- This is an automatically

Re: Review Request 122270: port kcminit away from kdelibs4support

2015-01-27 Thread Nick Shaforostoff
against QtGui Diffs (updated) - startkde/kcminit/CMakeLists.txt ffae38c startkde/kcminit/main.h 1140b77 startkde/kcminit/main.cpp 4724323 Diff: https://git.reviewboard.kde.org/r/122270/diff/ Testing --- compiled, ran 'kcminit --list' and kcminit AAA Thanks, Nick Shaforostoff

Re: Review Request 122270: port kcminit away from kdelibs4support

2015-01-27 Thread Nick Shaforostoff
an xcb_connection_t - if that fails we don't have an X-Server. If it succeeds we can check the number of screens. Nick Shaforostoff wrote: understood, but the question remains: is kcminit the best place to do multihead-related stuff? Thomas Lübking wrote: It's required by KApplication and while

Re: Review Request 122270: port kcminit away from kdelibs4support

2015-01-26 Thread Nick Shaforostoff
for it. http://www.kde-forum.org/artikel/16920/kde-multihead-environment-variable.html we still can avoid qtgui linkage and possibli ini file read by adding a cmdline option or generally move KDE_MULTIHEAD setup to another place (close to it's users?) - Nick Shaforostoff On Jan. 27, 2015, 3:10

Review Request 122270: port kcminit away from kdelibs4support

2015-01-26 Thread Nick Shaforostoff
/kcminit/CMakeLists.txt ffae38c startkde/kcminit/main.h 1140b77 startkde/kcminit/main.cpp 4724323 Diff: https://git.reviewboard.kde.org/r/122270/diff/ Testing --- compiled, ran 'kcminit --list' and kcminit AAA Thanks, Nick Shaforostoff

Review Request: make Speller::spellCheckerFound() return true when the dict for the current language is found (important when there was no dict for default language)

2012-01-18 Thread Nick Shaforostoff
. http://bugs.kde.org/show_bug.cgi?id=256896 Diffs - kdeui/sonnet/highlighter.cpp 3f478f0 Diff: http://git.reviewboard.kde.org/r/103729/diff/diff Testing --- Thanks, Nick Shaforostoff

Re: Review Request: check if enough disk space available before even starting to copy each file

2011-12-16 Thread Nick Shaforostoff
Testing --- files get copied fine. if i copy a bunch of files including one big file (created with dd if=/dev/zero of=file.out bs=1MB count=300), then the copying process stops when it gets to this big file (i have small disk on my virtual machine, only 400 mb free) Thanks, Nick

Review Request: check if enough disk space available before even starting to copy each file

2011-12-14 Thread Nick Shaforostoff
when it gets to this big file (i have small disk on my virtual machine, only 400 mb free) Thanks, Nick Shaforostoff

KRandomSequence and 64-bit

2011-12-09 Thread Nick Shaforostoff
Hi all. I see that KRandomSequence uses longs everywhere. long on 64-bit gcc systems is 8 bytes long, while int is always 4. maybe this is ok overall, but e.g. it uses KRandom::random() return value inside, which is int. so i suppose this can actually make the sequence less random. i propose

Review Request: optimize kcolorscheme consting time: avoid calculating luma for the same colors multiple times

2011-12-06 Thread Nick Shaforostoff
/103348/diff/diff Testing --- kwrite starts fine with the new kdeui lib Thanks, Nick Shaforostoff

Re: Review Request: optimize kcolorscheme consting time: avoid calculating luma for the same colors multiple times

2011-12-06 Thread Nick Shaforostoff
with it, but i couldn't push to kdelibs. is it because of lack of permissions? - Nick Shaforostoff On Dec. 6, 2011, 5:53 p.m., Nick Shaforostoff wrote: --- This is an automatically generated e-mail. To reply, visit: http

Re: Review Request: optimize kcolorscheme consting time: avoid calculating luma for the same colors multiple times

2011-12-06 Thread Nick Shaforostoff
On Dec. 6, 2011, 5:58 p.m., Nick Shaforostoff wrote: I have an account called shaforo. i could push to kdepimlibs with it, but i couldn't push to kdelibs. is it because of lack of permissions? Alexander Potashev wrote: You need to clone the `kdelibs` repo from `g