Re: Review Request 127866: Oxygen: Fix QCache usage

doesn't matter much, because the runtime cost of re-generating the cached values is probably much larger. FIFOCache looks like a simple solution to the problems that Coverity found with QCache (at least if the max cost is bounded) - nice! - Frank Reininghaus On May 22, 2016, 4:20 a.m., Michael

Re: Review Request 127866: Oxygen: Fix QCache usage

> On May 15, 2016, 8:51 a.m., Hugo Pereira Da Costa wrote: > > To be honest, I am quite puzzle by this whole thing. > > Now, every insertion in the cache requires at least two searches in there > > and (in many case) at least one copy constructor being called. This is > > quite expansive ...

Re: QString -> QStringLiteral conversions might make applications crash on exit

Hi, 2016-02-29 19:04 GMT+01:00 Milian Wolff: > On Friday, February 26, 2016 1:37:57 AM CET Frank Reininghaus wrote: >> Hi everyone, >> >> sorry if most of you know about this already, but since it seems that >> QStringLiterals are being introduced ev

Re: QString -> QStringLiteral conversions might make applications crash on exit

Hi Albert, 2016-02-28 11:54 GMT+01:00 Albert Astals Cid: > El Friday 26 February 2016, a les 01:37:57, Frank Reininghaus va escriure: >> Hi everyone, >> >> sorry if most of you know about this already, but since it seems that >> QStringLiterals are being introduced ev

Re: Review Request 127111: kurlnavigator: add new signal selectParentOfPreviousUrl

l. To reply, visit: > https://git.reviewboard.kde.org/r/127111/ > --- > > (Updated Feb. 18, 2016, 9:53 p.m.) > > > Review request for Dolphin, KDE Frameworks, Emmanuel Pescosta, and Frank > Reininghaus. > > > Bug

Re: Review Request 126894: Refactor the listjobtest to allow listing of multile paths.

overhead is added to each allocation. Each allocation takes at least 32 bytes of memory when using GCC+glibc on a 64-bit system. But I guess that there must be a better way than the `cin.ignore()` hack to easily get the real memory usage. - Frank Reininghaus On Jan. 26, 2016, 3:34 nachm

Re: I developed a workaround for Qt5.4 DND bug that KDE apps might need

Hi, 2016-01-16 14:35 GMT+01:00 PCMan: > On Sat, Jan 16, 2016 at 6:20 PM, Kevin Krammer wrote: >> >> Hi, >> >> On Saturday, 2016-01-16, 12:43:53, PCMan wrote: >> >> > Since DND is crucial for a modern desktop environment and it's an >> > upstream >> > bug, I believe that KDE is also affected. >> >

Re: Review Request 126750: Make KIconDialog and its sub-dialog Qt::WindowModal, rather than Qt::NonModal

currently do not > have a full self-built Plasma session running. It could probably be checked > by opening the "Properties..." of a file in FolderView, clicking the icon, > and then opening the "Browse..." sub dialog of the KIconDialog. This should > hopefully not lock the

Review Request 126750: Make KIconDialog and its sub-dialog Qt::WindowModal, rather than Qt::NonModal

then opening the "Browse..." sub dialog of the KIconDialog. This should hopefully not lock the entire Plasma session (because the dialogs are window modal, and not application modal). If anyone finds problems with that or has ideas for improvement, please let me know! Thanks,

Re: Review Request 125995: Only install konqpopupmenuplugin.desktop in kde-baseapps if the KF5 version is less than 5.16

marked as submitted. Review request for KDE Base Apps and David Faure. Changes --- Submitted with commit b919367c8550024aca53c7f4d219a5b4c3317964 by Frank Reininghaus to branch frameworks. Repository: kde-baseapps Description --- KIO installs this file since version 5.16. Even

Review Request 125995: Only install konqpopupmenuplugin.desktop in kde-baseapps if the KF5 version is less than 5.16

prior to 5.16 and install the file (which is needed to make the context menu for files work properly in Dolphin, FolderView, Konqueror, etc.). Thanks, Frank Reininghaus

Re: Review Request 125515: Preserve relative link targets when copying symlinks.

find a fail-safe solution with a dynamically increasing buffer prettier, but it's so extremely unlikely that this will ever cause problems that it's not worth arguing about it :-) - Frank Reininghaus On Okt. 10, 2015, 3:29 nachm., David Faure wrote

Re: Jenkins-kde-ci: kio master kf5-qt5 » Linux,gcc - Build # 119 - Still Unstable!

Am 07.10.2015 22:25 schrieb "Albert Astals Cid" <aa...@kde.org>: > > El Tuesday 06 October 2015, a les 19:20:00, Frank Reininghaus va escriure: > > Hi, > > > > 2015-10-06 15:04 GMT+02:00 <no-re...@kde.org>: > > > GENERAL INFO > > > &

Re: Review Request 125425: Add the desktop file that is required for adding services to the context menu for files and directories

marked as submitted. Review request for KDE Frameworks and David Faure. Changes --- Submitted with commit 4b24b70c93523c5bc56c90c04a5a666331e96a1b by Frank Reininghaus to branch master. Bugs: 350769 https://bugs.kde.org/show_bug.cgi?id=350769 Repository: kio Description

Re: Review Request 124983: Move the desktop files and file templates for the "Create New..." menu from kde-baseapps to kio

marked as submitted. Review request for KDE Frameworks and David Faure. Changes --- Submitted with commit 1b98a313983b75f3340639e5cd9519c56fca7113 by Frank Reininghaus to branch master. Bugs: 349654 https://bugs.kde.org/show_bug.cgi?id=349654 Repository: kio Description

Re: Jenkins-kde-ci: kio master kf5-qt5 » Linux,gcc - Build # 119 - Still Unstable!

Hi, 2015-10-06 15:04 GMT+02:00 : > > GENERAL INFO > > BUILD UNSTABLE > Build URL: > https://build.kde.org/job/kio%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/119/ > Project: PLATFORM=Linux,compiler=gcc > Date of build: Tue, 06 Oct 2015 12:34:13 + > Build duration: 14

Re: Review Request 125515: Preserve relative link targets when copying symlinks.

1000 bytes are guaranteed to be enough. Some quick Googling tells me that path lengths of 4096 are possible. Maybe we could allocate a temporary large array on the heap if the readlink call fails with the 1000 byte buffer on the stack? - Frank Reininghaus On Okt. 4, 2015, 9:24 vorm., David

Re: Review Request 125425: Add the desktop file that is required for adding services to the context menu for files and directories

Frank --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125425/#review86276 --- On Okt. 3, 2015, 7:50 vorm., Frank Reining

Re: Review Request 125425: Add the desktop file that is required for adding services to the context menu for files and directories

, Frank Reininghaus ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 125425: Add the desktop file that is required for adding services to the context menu for files and directories

oth, > > querying for both and skipping the installation of > > konqpopupmenuplugin.desktop if the KIO version is > 5.15? > > Frank Reininghaus wrote: > If we change the ServiceType entry in the file, then every service menu > will have to be changed, right

Re: Review Request 125425: Add the desktop file that is required for adding services to the context menu for files and directories

ServiceType/file name mismatch. - Frank --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125425/#review86028 --- On Sept. 27,

Review Request 125425: Add the desktop file that is required for adding services to the context menu for files and directories

/widgets/CMakeLists.txt 820cd34 src/widgets/kioservicemenuplugin.desktop PRE-CREATION Diff: https://git.reviewboard.kde.org/r/125425/diff/ Testing --- Konsole service actions are shown in the context menu again. Thanks, Frank Reininghaus

Re: Review Request 124983: Move the desktop files and file templates for the "Create New..." menu from kde-baseapps to kio

te New..." menu was empty then, but it is populated again with this patch. Thanks, Frank Reininghaus ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 125268: Fix signal-slot connections in KNewFileMenuPrivate::confirmCreatingHiddenDir(QString)

: it is possible to create hidden directories, and it is also possible to choose a new name. Thanks, Frank Reininghaus ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 125268: Fix signal-slot connections in KNewFileMenuPrivate::confirmCreatingHiddenDir(QString)

marked as submitted. Review request for KDE Frameworks and David Faure. Changes --- Submitted with commit 689fd43ae226ad026dd2fb6e198a5fef40c24b13 by Frank Reininghaus to branch master. Bugs: 352770 https://bugs.kde.org/show_bug.cgi?id=352770 Repository: kio Description

Re: Review Request 125158: add logic to use icons for default xdg user dirs

add a .directory file with the desired icon name. Is there a reason why the problem can't be solved this way? - Frank Reininghaus On Sept. 11, 2015, 10:50 vorm., Harald Sitter wrote: > > --- > This is an automatically generat

Review Request 124983: Move the desktop files and file templates for the Create New... menu from kde-baseapps to kio

, Frank Reininghaus ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: KSyCoca, Thread safety, and Cache invalidation

Hi, 2015-06-21 16:54 GMT+02:00 David Faure: On Friday 19 June 2015 22:00:09 Vishesh Handa wrote: On Sat, Jun 13, 2015 at 9:26 PM, David Faure wrote: 3 bis: I assume the threads without an event loop have some way to get tasks, right? So when the gui thread gets notified about ksycoca

Re: Review Request 112328: Add case sensitive sorting option to KGlobalSettings and KDirSortFilterProxyModel

On Sept. 4, 2013, 2:38 nachm., Martin Gräßlin wrote: KGlobalSettings moved into KDE4Support in frameworks 5. I would suggest to not add new API to an already deprecated class. Maybe you want to provide a patch for the proper way in frameworks? Marin, could you explain what the proper

Re: Baloo Widgets and its future

Hi, first of all, thanks for all the time and energy that you have put into FileMetaDataWidget in the past, Vishesh! 2015-05-14 12:15 GMT+02:00 Vishesh Handa: On Wed, May 13, 2015 at 10:25 PM, Albert Astals Cid wrote: Where would you put the code if not in baloo-widgets? Before the

Re: Review Request 123724: Use QTemporaryFile instead of hardcoding /tmp.

On Mai 12, 2015, 3:49 nachm., Jan Kundrát wrote: Was the old code a part of some release? If yes, this should get a CVE security announcement because it allows a local attacker to e.g. force you to overwirte some of your user's files. Michael Palimaka wrote: It looks like it was

Re: Review Request 122556: Bump Qt version to 5.4

On Feb. 13, 2015, 10:39 nachm., Marko Käning wrote: I'd vote for keeping it compatible to Qt 5.3, if that's possible. Inge Wallin wrote: +1. Depending on 5.4 in applications already is bad enough even though it can sometimes be necessary but I am against it for our base stuff.

Re: Review Request 122475: Fix bug 343906 - Unable to handle plain directory paths as QUrl

On Feb. 9, 2015, 10:01 nachm., Kevin Kofler wrote: IMHO, QUrl::fromUserInput(str, QString() QUrl::AssumeLocalFile) would be safer. Or do you really think dolphin nonexistentfile should look up nonexistentfile over DNS? Thomas Lübking wrote: +1, notably since

Re: Changes to our Git infrastructure

Hi, 2015-01-05 19:03 GMT+01:00 Jeff Mitchell: On 5 Jan 2015, at 12:40, Boudewijn Rempt wrote: All this back-and-forth about cli tools actually sounds weird to me. I know that the beginners who start hacking on Krita would never use any of them. Git on the command line is often already

Re: OSX/CI: kio placed files erroneously due to missing required backslash in path

Hi, 2014-12-23 9:44 GMT+01:00 David Faure: On Tuesday 23 December 2014 00:59:56 Marko Käning wrote: Fixed in http://commits.kde.org/kio/c5522b6931908d3fd8ad97555a3edf2a3e859b50 Ooops, should I have pushed this through Gerrit before committing? Nope, that's fine, trivial fix. Thanks!

Re: Review Request 118452: Reduce the memory usage of UDSEntry by using QVector, rather than QHash, for the internal data storage

. - Frank --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118452/#review72334 --- On Dez. 11, 2014, 10:08 nachm., Frank Reininghaus

Re: Review Request 118452: Reduce the memory usage of UDSEntry by using QVector, rather than QHash, for the internal data storage

/2014/12/09/038e443c-78eb-443b-b33a-b451b28d10ea__UDSEntry-benchmarks.png Thanks, Frank Reininghaus ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 118452: Reduce the memory usage of UDSEntry by using QVector, rather than QHash, for the internal data storage

://git.reviewboard.kde.org/media/uploaded/files/2014/12/09/038e443c-78eb-443b-b33a-b451b28d10ea__UDSEntry-benchmarks.png Thanks, Frank Reininghaus ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo

Re: Review Request 121248: Don't exclude /dev/shm from the possible directories to watch

On Dez. 18, 2014, 9:41 vorm., David Faure wrote: Ship It! Do you have a KDE git account, Alberto? If not, please let us know. We can then push the commit to kdelibs and forward-port it to KF5 for you. - Frank --- This is an

Change in kio[master]: Apply the edited URL to the navigator when clicking the Che...

Frank Reininghaus has uploaded a new change for review. https://gerrit.vesnicky.cesnet.cz/r/233 Change subject: Apply the edited URL to the navigator when clicking the Check button .. Apply the edited URL to the navigator

Re: Review Request 118452: Reduce the memory usage of UDSEntry by using QVector, rather than QHash, for the internal data storage

--- On Dez. 9, 2014, 10:44 nachm., Frank Reininghaus wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118452

Re: Review Request 118452: Reduce the memory usage of UDSEntry by using QVector, rather than QHash, for the internal data storage

). - Frank --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118452/#review71763 --- On Dez. 9, 2014, 10:44 nachm., Frank Reininghaus wrote

Re: Review Request 118452: Reduce the memory usage of UDSEntry by using QVector, rather than QHash, for the internal data storage

://git.reviewboard.kde.org/media/uploaded/files/2014/12/09/038e443c-78eb-443b-b33a-b451b28d10ea__UDSEntry-benchmarks.png Thanks, Frank Reininghaus ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 121248: Don't exclude /dev/shm from the possible directories to watch

being committed to the KDE/4.14 branch, which would be pointless otherwise). If not, the patch can at least be used for the next KF5 release, to which it should be forward-ported anyway. - Frank Reininghaus On Nov. 25, 2014, 8:15 nachm., Alberto Sánchez Molero wrote

Re: Review Request 118452: Reduce the memory usage of UDSEntry by using QVector, rather than QHash, for the internal data storage

Thanks, Frank Reininghaus ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 119607: Support for .hidden files

On Sept. 14, 2014, 3:27 nachm., Frank Reininghaus wrote: src/core/kfileitem.h, line 262 https://git.reviewboard.kde.org/r/119607/diff/2/?file=301216#file301216line262 Since we probably do not want to make it possible that all users of this class can make items hidden, I'm

Re: How to port KTabBar::mouseMiddleClick?

Hi, 2014-11-06 2:59 GMT+01:00 Milian Wolff: Hey all, what do I do to get middle-click-closes-tab in Qt 5 without KTabBar? Previously, we used KTabBar and its mouseMiddleClick signal. AFAIK, currently the only solution is to subclass QTabBar, override the mousePressEvent method and emit a

Re: Review Request 120666: Get user's permission before executing scripts or desktop files

On Okt. 23, 2014, 11:14 vorm., Emmanuel Pescosta wrote: src/widgets/krun.cpp, line 1013 https://git.reviewboard.kde.org/r/120666/diff/2/?file=321616#file321616line1013 Any reason why using show instead of exec? Exec would avoid the rather complex and error-prone code path.

Re: Review Request 119892: [Dolphin] Implement Add to archive option when dragging and dropping onto an archive file in dolphin

in that situation, i.e., move/copy/link the dropped items in the directory that contains the text file where the items are dropped. - Frank Reininghaus On Aug. 21, 2014, 9:11 p.m., Arjun Ak wrote: --- This is an automatically generated e-mail

Re: Review Request 119678: add a target named project_doc for each project in the tree, to generate developer documention

single repository? - Frank Reininghaus On Aug. 9, 2014, 12:43 a.m., Mathieu Tarral wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119678

Re: Review Request 119701: Fix bug #334271 : bad display of Dolphin status bar wdgets when a high DPI resolution is used

) could be done directly in KCapacityBar though, such that all applications which use that class benefit from them. - Frank Reininghaus On Aug. 12, 2014, 5:28 a.m., Mathieu Tarral wrote: --- This is an automatically generated e-mail

KDE applications December 2014 release

Hello everyone, after KDE SC 4.14, the next release of the KDE applications that are part of the KDE SC is planned for December. It will contain not only applications that are still based on Qt4+kdelibs 4.x, but also applications that have the first stable release of their Qt5+KF5 ports [1]. All

KDE applications December 2014 release

Hello everyone, after KDE SC 4.14, the next release of the KDE applications that are part of the KDE SC is planned for December. It will contain not only applications that are still based on Qt4+kdelibs 4.x, but also applications that have the first stable release of their Qt5+KF5 ports [1]. All

Re: Review Request 119543: Removed all KDialogs from balooWidgets

On July 30, 2014, 8:54 a.m., Vishesh Handa wrote: src/tagwidget.cpp, line 180 https://git.reviewboard.kde.org/r/119543/diff/1/?file=294417#file294417line180 Any reason you've combined the too functions? I don't remember why, but there was a point when it split up.

Re: Review Request 119543: Removed all KDialogs from balooWidgets

use a QScopedPointer? Thomas Braxton wrote: Or you could just make it not a pointer and it cleans itself up. Felix Eisele wrote: Good idea! Frank Reininghaus wrote: No, this is a **very bad** idea. Creating the dialog on the stack as a child of this and then executing its

Re: KDE Applications December 2014 release: which apps are targeting Qt4/Qt5?

Hi, 2014-07-22 11:11 GMT+02:00 Todd: On Jul 22, 2014 12:30 AM, Frank Reininghaus wrote: 2014-07-21 23:34 GMT+02:00 Albert Astals Cid: El Dilluns, 21 de juliol de 2014, a les 13:26:32, Frank Reininghaus va escriure: [...] I've created a draft of a wiki page where this information could

KDE Applications December 2014 release: which apps are targeting Qt4/Qt5?

Hello everyone, after KDE SC 4.14, the next release of the KDE applications that are part of the KDE SC is planned for December. It will contain not only applications that are still based on Qt4+kdelibs 4.x, but also applications that have the first stable release of their Qt5+KF5 ports [1]. All

Re: KDE Applications December 2014 release: which apps are targeting Qt4/Qt5?

Hi, 2014-07-21 23:34 GMT+02:00 Albert Astals Cid: El Dilluns, 21 de juliol de 2014, a les 13:26:32, Frank Reininghaus va escriure: Hello everyone, after KDE SC 4.14, the next release of the KDE applications that are part of the KDE SC is planned for December. It will contain not only

Re: Review Request 118994: make CTRL+SHIFT+T reopen last closed tab

On July 20, 2014, 9:56 p.m., Frank Reininghaus wrote: Thank you very much for working on this, Arjun, and thanks also for your very good suggestions, Emmanuel! I apologize for not responding earlier. I was a bit busy at work recently and did not really find the time to check all

Re: Review Request 118994: make CTRL+SHIFT+T reopen last closed tab

/dolphinmainwindow.cpp https://git.reviewboard.kde.org/r/118994/#comment43499 I would prefer setEnabled(count 0) (because it makes it clear at first sight that the argument is a bool), but that might be a matter of taste. - Frank Reininghaus On July 6, 2014, 1:58 p.m., Arjun Ak wrote

Re: KConfig build fails

Hi, 2014-07-14 23:21 GMT+02:00 David Gil Oliva: Hi! KConfig build fails with this messages, all of them related to QBasicAtomicInt. Are they KF5 bugs? probably this is the same issue that has been discussed in https://git.reviewboard.kde.org/r/119257/ ? According to David F., this might

Re: Review Request 118994: make CTRL+SHIFT+T reopen last closed tab

On June 29, 2014, 2:50 p.m., Emmanuel Pescosta wrote: Thanks for the patch! I really like the idea to implement CTRL+SHIFT+T to reopen the previously closed tab, makes Dolphin more browser like :) But please implement this feature in master, because: 1. Dolphins frameworks

Re: Review Request 118858: Fix crashes in KUrlNavigator that are caused by accesses to objects which have been deleted in nested event loops

://git.reviewboard.kde.org/r/118858/diff/ Testing --- Cannot reproduce the crashes any more. The menus in KUrlNavigator still work fine for me. Thanks, Frank Reininghaus

Re: Bug 92237: patch submitted, but... is anyone watching?

Hi, 2014-06-22 13:04 GMT+02:00 Simon Bachmann: May I draw your attention to bug 92237? (https://bugs.kde.org/show_bug.cgi?id=92237) No, this is not a please-get-this-issue-fixed-ASAP kind of message. It's just that I submitted a patch to that bug a few weeks ago, and I'm afraid no one

Re: Dolphin PDF preview - strange behaviour

Hi, 2014-06-24 13:42 GMT+02:00 Leonardo Giordani: Hi all, I get a very strange behaviour in Dolphin when dealing some PDF files (I do not yet know why just some of them). The preview shows an image that is larger than the actual page, with a big white area. I tried to split the PDF

Re: Review Request 118858: Fix crashes in KUrlNavigator that are caused by accesses to objects which have been deleted in nested event loops

) - kfile/kurlnavigator.cpp f5dfc81 kfile/kurlnavigatorbutton.cpp 6cb40b1 Diff: https://git.reviewboard.kde.org/r/118858/diff/ Testing --- Cannot reproduce the crashes any more. The menus in KUrlNavigator still work fine for me. Thanks, Frank Reininghaus

Re: Review Request 118775: Make KFileItem a Q_MOVABLE type

/ Testing --- Unit tests still pass. I verified that the memory usage of a KFileItemList with many items decreases as expected. Thanks, Frank Reininghaus ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org

Review Request 118858: Fix crashes in KUrlNavigator that are caused by accesses to objects which have been deleted in nested event loops

. The menus in KUrlNavigator still work fine for me. Thanks, Frank Reininghaus

Re: Review Request 118775: Make KFileItem a Q_MOVABLE type

Diff: https://git.reviewboard.kde.org/r/118775/diff/ Testing --- Unit tests still pass. I verified that the memory usage of a KFileItemList with many items decreases as expected. Thanks, Frank Reininghaus ___ Kde-frameworks-devel mailing

KCoreAddons does not install most of its headers on my system

Hello everyone, I tried to set up a separate Qt5+KF5 build in release mode. Unfortunately, I did not succeed :-( The first package that fails to build (even if I repeat the kdesrc-build process many times) is kservice. The comiler reports [ 30%] Building CXX object

Review Request 118775: Make KFileItem a Q_MOVABLE type

with many items decreases as expected. Thanks, Frank Reininghaus ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 118775: Make KFileItem a Q_MOVABLE type

. - Frank --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118775/#review60179 --- On June 16, 2014, 7:58 a.m., Frank Reininghaus wrote

Re: Review Request 118452: Reduce the memory usage of UDSEntry by using QVector, rather than QHash, for the internal data storage

://git.reviewboard.kde.org/r/118452/#review59479 --- On June 1, 2014, 1:50 p.m., Frank Reininghaus wrote: --- This is an automatically generated e-mail. To reply, visit: https

Re: Review Request 118269: Fix crash when showing the confirmation dialog for trash/delete operations

://git.reviewboard.kde.org/r/118269/diff/ Testing --- Fixes the crash for me, and the confirmation dialog works as expected (i.e., the user can choose if the file should really be deleted/trashed or not). Thanks, Frank Reininghaus ___ Kde-frameworks

Re: Review Request 118269: Fix crash when showing the confirmation dialog for trash/delete operations

! - Frank --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118269/#review58902 --- On May 22, 2014, 9:39 p.m., Frank Reininghaus wrote

Re: KIO directory listing - CPU slows down SSD

Hi, 2014-06-02 18:42 GMT+02:00 Aaron J. Seigo: On Thursday, May 29, 2014 16:32:28 Mark Gaiser wrote: dolphin on a massive folder. In fact, those that use kio::listdir for listing folders only have interfaces that become usable when all entries are fetched. assuming these UIs receive

Re: KIO directory listing - CPU slows down SSD

Hi, 2014-06-02 20:54 GMT+02:00 Mark Gaiser: On Mon, Jun 2, 2014 at 6:42 PM, Aaron J. Seigo wrote: On Thursday, May 29, 2014 16:32:28 Mark Gaiser wrote: dolphin on a massive folder. In fact, those that use kio::listdir for listing folders only have interfaces that become usable when all

Re: KIO directory listing - CPU slows down SSD

Hi, 2014-06-02 23:39 GMT+02:00 Frank Reininghaus: Hi, 2014-06-02 20:54 GMT+02:00 Mark Gaiser: On Mon, Jun 2, 2014 at 6:42 PM, Aaron J. Seigo wrote: On Thursday, May 29, 2014 16:32:28 Mark Gaiser wrote: dolphin on a massive folder. In fact, those that use kio::listdir for listing folders

Review Request 118452: Reduce the memory usage of UDSEntry by using QVector, rather than QHash, for the internal data storage

, Frank Reininghaus ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 118450: Add null-pointer safety check to KonqOperations::pasteInfo(const KUrl) (to fix a crash on Wayland)

more. Thanks, Frank Reininghaus

Re: Review Request 118450: Add null-pointer safety check to KonqOperations::pasteInfo(const KUrl) (to fix a crash on Wayland)

the crash, but I'm pretty sure that at least a crash with the reported backtrace will not happen any more. Thanks, Frank Reininghaus

Review Request 118269: Fix crash when showing the confirmation dialog for trash/delete operations

, and the confirmation dialog works as expected (i.e., the user can choose if the file should really be deleted/trashed or not). Thanks, Frank Reininghaus ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde

Re: Review Request 117044: Avoid unnecessary automounting in KDiskFreeSpaceInfo::freeSpaceInfo

to revert this patch - maybe a better solution which prevents automounting can be found for master/frameworks, but IMHO we should not take any further risks in KDE/4.13. Any objections? - Frank Reininghaus On May 6, 2014, 8:01 p.m., Tomáš Trnka wrote

Re: Review Request 118128: Use actual bytes formatter for sizes in KDirModel

really want that the detailed listview in dolphin? I can more easily recognize the biggest number by being the one with most digits, than having to go through a list of kB, MB, and GB values. It might even break the sorting by size. Let's ask Frank Reininghaus, but I'm not sure

Re: KIO directory listing - CPU slows down SSD

Hi Mark, 2014-05-11 21:57 GMT+02:00 Mark Gaiser: Hi, I've been playing with KIO speed improvements for quite a while now and found some very interesting issues with KIO in combination with my SSD drive: Samsung SSD 840 PRO Series. My testcase is one directory filled with 500.000 files to

Re: [PATCH] apperd: Restrict creation of KJobs to the more interesting transaction roles.

Hi, 2014-05-04 21:33 GMT+02:00 Marc Schmitzer: Hi everybody, I've hacked up a patch to apperd that (for me) fixes KDE BUG #318864 [1]. The commit message and patch are inlined below, it would be awesome if this would be reviewed and merged. Please tell me if I should submit the patch any

Re: Review Request 117930: Catch more exceptions in Baloo::FileFetchJob::doStart()

On May 1, 2014, 1:23 p.m., Frank Reininghaus wrote: Note 1: an even better fix would probably be to repair or delete and re-create the broken database if a Xapian::DatabaseOpeningError exception is thrown, but my knowledge of the Baloo/Xapian internals is not sufficient

Re: Review Request 117930: Catch more exceptions in Baloo::FileFetchJob::doStart()

/ Testing --- Unit tests still pass. Thanks, Frank Reininghaus Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe

Review Request 117930: Catch more exceptions in Baloo::FileFetchJob::doStart()

libraries that can throw exceptions should try as hard as possible to catch all exceptions. Diffs - src/file/lib/filefetchjob.cpp 21f5520 Diff: https://git.reviewboard.kde.org/r/117930/diff/ Testing --- Unit tests still pass. Thanks, Frank Reininghaus Visit http://mail.kde.org

Re: Review Request 117930: Catch more exceptions in Baloo::FileFetchJob::doStart()

, but without backtrace. Maybe it's thrown at the same location, I don't know. - Frank Reininghaus On May 1, 2014, 1:14 p.m., Frank Reininghaus wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org

Re: Review Request 117799: Clean up private slots in KCompletion

straightforward transformation, and I haven't spotted anything that looks like it could break things. Considering that the tests still work for you, I think that there is no reason not to push it. - Frank Reininghaus On April 26, 2014, 11:23 p.m., David Gil Oliva wrote

Re: KDE applications 4.14 LTS or 4.15?

Hi, 2014-04-29 19:32 GMT+02:00 Albert Astals Cid: El Dimarts, 29 d'abril de 2014, a les 18:13:20, Mario Fux va escriure: Am Samstag, 26. April 2014, 16.48:22 schrieb Kevin Krammer: Morning Kevin On Friday, 2014-04-25, 21:09:34, Mario Fux wrote: Morning gals and guys First: there

Re: Disabling baloo-integration possible?

Hi, 2014-04-09 21:29 GMT+02:00: Hi Vishesh, On 08 Apr 2014, at 10:36 , Vishesh Handa wrote: will it be possible to run KDE without baloo enabled? Yes. You can go to System Settings - Desktop Search - Exclude Folders, and add your $HOME directory over there. Otherwise you can also edit the

Re: Review Request 116886: Refactor private variables of KCompletion

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116886/#review53705 --- Ship it! Looks reasonable to me, thanks! - Frank

Re: Review Request 116886: Refactor private variables of KCompletion

, one could make 'order' a bitfield and move it next to the bools. - Frank Reininghaus On March 18, 2014, 11:01 p.m., David Gil Oliva wrote: --- This is an automatically generated e-mail. To reply, visit: https

Re: MacPorts: Running KDE ports on Apple OS X

Hi Ian, 2014-03-15 7:10 GMT+01:00 Ian Wadham: [...] And I said it would be nice to have some regular testing of Apple and Windows implementations of KDE. Well ... the response was quite antagonistic at first, but I am old and thick-skinned and I stood my ground ... :-) [...] First I would

Re: What to test for 4.13?

Hi, 2014-03-15 16:04 GMT+01:00: So, e.g. KDE is at version 4.12.2!!! (My SuSE's were never as current as MacPorts has been in years.) And, I want to underline that the building of almost all KDE4 ports seems to have been going flawless in the last while. Which is amazing, given there are

Re: What to test for 4.13?

Hi, 2014-03-09 7:33 GMT+01:00 Ian Wadham: Hi Kevin and Frank, On 08/03/2014, at 11:02 PM, Kevin Krammer wrote: On Saturday, 2014-03-08, 21:47:07, Ian Wadham wrote: On 08/03/2014, at 6:43 PM, Frank Reininghaus wrote: 2014-03-08 4:38 GMT+01:00 Ian Wadham: While we are on the topic of testing

Re: What to test for 4.13?

Hi, 2014-03-08 4:38 GMT+01:00 Ian Wadham: On 07/03/2014, at 9:29 PM, Jos Poortvliet wrote: The first beta of our applications and platform 4.13 is out. There are some major changes, the introduction of Baloo being first and foremost among them. But there is more. We (the promo team) would

Re: Review Request 116542: Fix compilation with clang 3.4.

and thanks for taking care of it. I wasn't aware at all that there might be a problem if the operator== is declared outside the namespace, but if I had been, then I would have put it inside he namespace, of course. So Ship it! from me too. - Frank Reininghaus On March 2, 2014, 8:20 p.m., Milian Wolff

  1   2   3   >