Re: Anyone interested in taking over Trojitá ?

2022-01-30 Thread Jan Kundrát
On neděle 26. prosince 2021 11:49:58 CET, Albert Astals Cid wrote: Hello, Albert with Security Team hat here. Trojitá hasn't been released for over 5 years and doesn't seem to have any active developers left. It has a [reasonably important] security issue and we need someone to take care

D5788: Add syntax highlighting for YANG data modeling language

2017-06-17 Thread Jan Kundrát
jkt added a comment. Re "extracting bits from the RFC", RFC 6020 says (among other things) that //"Code Components extracted from this document must include Simplified BSD License text as described in Section 4.e of the Trust Legal Provisions and are provided without warranty as described

D5788: Add syntax highlighting for YANG data modeling language

2017-06-17 Thread Jan Kundrát
jkt accepted this revision. jkt added a comment. Oops, sorry, I forgot to comment here. I appreciate your conversion, it works really nicely! Compared to the vim version, my QtCreator theme is not highlighting the `true` and `false` keywords in statements such as `mandatory true;`.

Re: Differential e-mail subject re-arrangement

2017-03-02 Thread Jan Kundrát
On čtvrtek 2. března 2017 9:08:25 CET, Ben Cooksley wrote: In regards to the way email subjects are treated, I've now customised the metamta.differential.subject-prefix preference on our installation to be blank, to the "[Differential]" part should no longer be present. Roughly at the time you

Re: CI Requirements - Lessons Not Learnt?

2017-01-12 Thread Jan Kundrát
On čtvrtek 12. ledna 2017 15:28:08 CET, Kevin Kofler wrote: What will happen now is that they will revert your commits that require the unavailable version of the library. It is just more work for us packagers Hi Kevin, do you have some examples of distribution maintainers actually doing such

Re: CI Requirements - Lessons Not Learnt?

2017-01-11 Thread Jan Kundrát
On středa 11. ledna 2017 6:57:50 CET, Martin Gräßlin wrote: That doesn't work. Such inflexibility take away the advantage of having a CI. What base system(s) do you prefer to target as a developer, Martin? A CI system can have different sets of base images for different projects (and

Re: What's kde-core-devel for?

2016-12-19 Thread Jan Kundrát
KDE has expanded over the last few years to include projects which are not based on kdelibs or kf5 (or even Qt). There are e-mails about new project incubation, upcoming conferences and CFPs and other semi-social topics. I am interested in these discussions and I thought that this is what k-c-d

Re: Review Request 129426: refactor gpg finding

2016-11-20 Thread Jan Kundrát
> On Nov. 18, 2016, 8:05 p.m., Andreas Sturmlechner wrote: > > CMakeLists.txt, line 37 > > > > > > that looks to me as if it does the opposite as in $description; prefer > > the old one to the new one. > >

Re: announcement: Kwave is in kdereview

2016-10-17 Thread Jan Kundrát
On úterý 11. října 2016 21:41:09 CEST, Thomas Eschenbacher wrote: the _(...) macro has nothing to do with i18n Isn't that a bit confusing? Underscore is used by gettext to mean the *opposite* from what Kwave uses it for. It is also a reserved identifier in C++. Inventing non-standard idioms

Re: KDE CI enforcing ECMEnableSanitizers.cmake/KDECompilerSettings.cmake?

2016-04-26 Thread Jan Kundrát
On Wednesday, 27 April 2016 01:21:22 CEST, Albert Astals Cid wrote: It is strange that your Qt5-only tests are failing, may it be that they are loading some plugin that is linked against some KF5 lib? Qt guesses what platform one is running on in order to blend with it. In KDE and under the

Re: kdewebkit?

2016-04-22 Thread Jan Kundrát
On Thursday, 21 April 2016 18:33:51 CEST, David Edmundson wrote: -postCheckoutCommand=./init-repository -f +postCheckoutCommand=./init-repository -f --module-subest=default,qtwebkit That parameter is called --module-subset, not --module-subest (on both places). -- Trojitá, a fast Qt IMAP

Re: QString -> QStringLiteral conversions might make applications crash on exit

2016-02-29 Thread Jan Kundrát
On Monday, 29 February 2016 23:16:22 CET, Frank Reininghaus wrote: If something like "do not use QStringLiteral in plugins" will be the conclusion from this issue, then I'm all for continuing to use QStringLiteral everywhere else in order to avoid heap allocations. The conclusion is "do not

Re: QString -> QStringLiteral conversions might make applications crash on exit

2016-02-26 Thread Jan Kundrát
On Friday, 26 February 2016 01:37:57 CET, Frank Reininghaus wrote: This becomes a problem if the read-only data that the QString refers to are not there any more, which can happen if the QString was stored in a global static object from one library, and the QStringLiteral is from another

Re: test failures on http://ci-logs.kde.flaska.net

2016-01-03 Thread Jan Kundrát
And indeed the value of XDG_DATA_DIRS in http://ci-logs.kde.flaska.net/7f/7f50569d59eabc20897f54fb97483bd7f8b89d63/rebuilddep/rebuilddep-kf5-qt55-clang-el7/3cef5be/shell_output.log is long and messy and has /usr/share in front (so it's viewed as being "on top of" the kde mimetype file, while

Re: Change to Mail Infrastructure - SPF and DKIM verification will now be enforced

2015-12-09 Thread Jan Kundrát
I've taken the liberty to remove the ad-hominem which you used. I'm not happy with your approach to this discussion, but I'll try to stick with the technical points. There is active work within the DMARC WG, with first drafts being published only *two months ago* [1]. My suggestion for

Re: Change to Mail Infrastructure - SPF and DKIM verification will now be enforced

2015-12-08 Thread Jan Kundrát
On Tuesday, 8 December 2015 10:19:51 CET, Ben Cooksley wrote: a) Clearing the "subject_prefix" setting b) Clearing "msg_header" and "msg_footer" c) Disabling "scrub_nondigest" and "first_strip_reply_to" Depending on who posts to your list, you may also need to: a) Set "reply_goes_to_list" to

Re: Change to Mail Infrastructure - SPF and DKIM verification will now be enforced

2015-12-08 Thread Jan Kundrát
On Tuesday, 8 December 2015 16:09:43 CET, Nicolás Alvarez wrote: It is irrelevant what our personal preference about doing modifications to messages is (like the tag in the subject). The fact of life is that there *are* mail providers out there (like Yahoo) which are already enforcing DMARC

Re: Change to Mail Infrastructure - SPF and DKIM verification will now be enforced

2015-12-08 Thread Jan Kundrát
On Friday, 4 December 2015 10:56:42 CET, Ben Cooksley wrote: To be specific I will be enabling the following line: On-BadSignature tempfail within the configuration of OpenDKIM on our servers. Thanks, but that's not a full answer. What is the proposed content of the following DNS

Re: Change to Mail Infrastructure - SPF and DKIM verification will now be enforced

2015-12-04 Thread Jan Kundrát
On Friday, 4 December 2015 10:56:42 CET, Ben Cooksley wrote: Note that in the long run with DMARC looming you will need to switch to #2 anyway, and keeping your current behaviour will likely lead to mail from people who use Yahoo / AOL / etc ending up in the spam folder with many mailing list

Re: Change to Mail Infrastructure - SPF and DKIM verification will now be enforced

2015-12-03 Thread Jan Kundrát
On Thursday, 3 December 2015 07:13:07 CET, Ben Cooksley wrote: I will be re-enabling DKIM validation in one week's time - which will then break subscriptions to Debian mailing lists (as any email from anyone who has enabled DKIM which hits their lists will not be accepted by KDE email

Re: Scope of framework integration plugin?

2015-11-30 Thread Jan Kundrát
On Monday, 30 November 2015 14:45:41 CET, René J. V. Bertin wrote: Would you really expect Qt to accept a patch that allows generic applications to use font role specifications from KF5? Yes, I think that such a goal is fully in line with Qt's attempt at being reasonably cross-platform.

Re: Build and test failures with Qt 5.6 and Qt 5.3

2015-11-09 Thread Jan Kundrát
On Monday, 9 November 2015 08:21:21 CET, Martin Graesslin wrote: I'm sorry, but I'm not able to reproduce the failure on my local Qt 5.6 setup. The failures look like there is no WM running on the CI system, maybe openbox crashed? (We had that before that our tests were able to trigger

Re: Build and test failures with Qt 5.6 and Qt 5.3

2015-11-08 Thread Jan Kundrát
On Sunday, 8 November 2015 12:17:19 CET, David Faure wrote: Any chance you could do some debugging around there? I'm afraid I don't have time and motivation to fix this, sorry. I'll be happy to spin a VM with an identical setup for you, though, if you're OK with IPv6-only access. If so,

Re: Build and test failures with Qt 5.6 and Qt 5.3

2015-11-08 Thread Jan Kundrát
On Saturday, 7 November 2015 11:59:48 CET, David Faure wrote: Having this for all of KF5 would definitely be useful. And it's done now: http://ci-logs.kde.flaska.net/matrix.html - [5.3] ballo, missing QList::join - [5.3] knewstuff, QTimer::singleShot and new slots - [5.3] modemmanager-qt,

Re: Build and test failures with Qt 5.6 and Qt 5.3

2015-11-07 Thread Jan Kundrát
Hi David, thanks for looking into this. I'm happy that you find the additional coverage useful. At this time, the infrastructure cannot easily send out automated e-mails only upon a change in the state of a build job -- if someone has some time and is willing to improve this, I'll be happy to

Re: Build and test failures with Qt 5.6 and Qt 5.3

2015-11-07 Thread Jan Kundrát
On Saturday, 7 November 2015 22:38:16 CET, Ivan Čukić wrote: - [5.3] kactivities: won't build due to QQuickWidget::setClearColor which is 5.4+ only. It should be ok now. I've added a work-around (essentially how the method is implemented in 5.4 and 5.5).

Build and test failures with Qt 5.6 and Qt 5.3

2015-11-06 Thread Jan Kundrát
Hi folks, please take a look at the CI status matrix at [1]. TL;DR: There are build failures with Qt 5.3, plenty of test failures, and some test failures specific to the still unreleased Qt 5.6. Oh, and a cmake 3.4-git regression that I'm not going to bother you with. Reported, known,

Re: marble builds when it shouldn't

2015-09-22 Thread Jan Kundrát
On Tuesday, 22 September 2015 13:00:38 CEST, Harald Sitter wrote: Also on a more general note: I think it would be handy if all builds used CMAKE_VERBOSE_MAKEFILE=TRUE to get verbose make output which would make it easier to notice when things such as -DNDEBUG are passed to gcc. Absolutely --

Re: Bringing back rsibreak from unmaintained

2015-08-18 Thread Jan Kundrát
On Monday, 17 August 2015 20:04:04 CEST, Albert Astals Cid wrote: Other comments? Nice, happy to see it -- it builds here, with a bunch of warnings: [2/29] Generating index.cache.bz2 index.docbook:2: element para: validity error : ID gnu-fdl already defined element div: validity error : ID

Re: Bringing back rsibreak from unmaintained

2015-08-18 Thread Jan Kundrát
On Wednesday, 19 August 2015 01:00:13 CEST, Christoph Feck wrote: -- Build files have been written to: /local/build/kf5/rsibreak /local/git/extragear/utils/rsibreak/src/rsitimer.cpp:26:20: fatal error: kdebug.h: No such file or directory A missing dep on kde4libssupport,

Re: Bringing back rsibreak from unmaintained

2015-08-18 Thread Jan Kundrát
On Wednesday, 19 August 2015 00:30:01 CEST, Albert Astals Cid wrote: These messages are not new, IMHO does not apply to this request of bringing back from unmaintiained ;) I agree that it's not a blocker of course, but you asked for feedback :). However, the worst thing is that the passive

Re: Plasma Applet for Audio Volume for kdereview

2015-08-14 Thread Jan Kundrát
On Thursday, 6 August 2015 12:43:28 CEST, Martin Klapetek wrote: You can still use kmix with Plasma, there is even a port to kf5 though I'm not sure what's its state. FYI, I've been running with the KF5 kmix for a couple of months without any issues. I'm using just plain old ALSA, not PA.

Re: 3 UDSEntry optimizations

2015-07-20 Thread Jan Kundrát
On Sunday, 19 July 2015 23:11:05 CEST, Mark Gaiser wrote: Regarding gerrit. How can i make patch 2 and 3 dependent on 1? You did a good job. A correct way is to produce three commits locally, 1 being parent of 2 and 2 being a parent of 3, and push these to refs/for/master, which is what you

Re: Review Request 124386: Fix build with Qt 5.4

2015-07-19 Thread Jan Kundrát
marked as submitted. Review request for KDE Frameworks. Changes --- Submitted with commit b54a1b2dab13569d73ec5ba55358689e8849cc01 by Jan Kundrát to branch master. Repository: kidletime Description --- The QJsonArray::operator-() got added in qtbase's commit 7dce9622 which is only

Re: Review Request 124384: Fix build with Qt 5.4

2015-07-19 Thread Jan Kundrát
marked as submitted. Review request for KDE Frameworks. Changes --- Submitted with commit bc0848882cea3943c69a1dfb6ca427fa11d07ef9 by Jan Kundrát to branch master. Repository: kwindowsystem Description --- The QJsonArray::operator-() got added in qtbase's commit 7dce9622 which

Review Request 124385: Fix build failure with clang 3.4.2

2015-07-18 Thread Jan Kundrát
--- Thanks, Jan Kundrát ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 124385: Fix build failure with clang 3.4.2

2015-07-18 Thread Jan Kundrát
marked as submitted. Review request for KDE Frameworks. Changes --- Submitted with commit 4316ecb1b96a758afda79a0108d008f001171734 by Jan Kundrát to branch master. Repository: kitemmodels Description --- autotests/kextracolumnsproxymodeltest.cpp:68:9: error: control may reach end

Review Request 124384: Fix build with Qt 5.4

2015-07-18 Thread Jan Kundrát
Description --- The QJsonArray::operator-() got added in qtbase's commit 7dce9622 which is only present in Qt 5.4. Diffs - src/pluginwrapper.cpp c3eed03d559308ad4d158a5de112febb50e6c93e Diff: https://git.reviewboard.kde.org/r/124384/diff/ Testing --- Thanks, Jan Kundrát

Review Request 124386: Fix build with Qt 5.4

2015-07-18 Thread Jan Kundrát
--- The QJsonArray::operator-() got added in qtbase's commit 7dce9622 which is only present in Qt 5.4. Diffs - src/kidletime.cpp 675cd2bc1642906c0fe21fa2f674549f85cf0aac Diff: https://git.reviewboard.kde.org/r/124386/diff/ Testing --- Thanks, Jan Kundrát

A CI dashboard with multiple versions of Qt5 on Linux

2015-06-11 Thread Jan Kundrát
Hi, if you would like to check how well the KF5 builds cope with multiple Qt5 versions, take a look at this page generated from the Zuul/Gerrit CI system: http://ci-logs.kde.flaska.net/matrix.html I am open for suggestions for service improvements, so if you have an idea on how to make this

A CI dashboard with multiple versions of Qt5 on Linux

2015-06-11 Thread Jan Kundrát
Hi, if you would like to check how well the KF5 builds cope with multiple Qt5 versions, take a look at this page generated from the Zuul/Gerrit CI system: http://ci-logs.kde.flaska.net/matrix.html I am open for suggestions for service improvements, so if you have an idea on how to make this

Re: A CI dashboard with multiple versions of Qt5 on Linux

2015-06-11 Thread Jan Kundrát
On Friday, 12 June 2015 01:29:59 CEST, Scarlett Clark wrote: Question, is your Qt5.2 patched? I'm pretty sure that it was a vanilla build straight from git on CentOS 7 back in December 2014. I have no idea what failure you saw and I agree that no patches is a good general approach, but I

Shift+Delete shortcut for cut standard action

2015-06-03 Thread Jan Kundrát
Hi, the kconfigwidgets library defines Shift+Del as a standard alternative shortcut for the Cut action. This dates back to 2001 [1]. A problem with this shortcut is that applications traditionally use Shift+Del as a shortcut for forced delete, or to distinguish move-to-trash from delete.

Re: [kde-guidelines] Shift+Delete shortcut for cut standard action

2015-06-03 Thread Jan Kundrát
On Wednesday, 3 June 2015 20:42:32 CEST, Thomas Lübking wrote: I assume Jan intended to turn it into some delete+expunge for Trojitá. Nope, this is about Gwenview and an existing bugreport. Dolphin (you confirmed that), Digikam (I saw that code), Gwenview (I saw that code), KMail (bugzilla

Re: Something has gone horribly wrong.. Linux builds carnage.

2015-05-14 Thread Jan Kundrát
On Thursday, 14 May 2015 17:40:09 CEST, Scarlett Clark wrote: I woke up this morning to a sea of red. Almost all of the linux builds are failing. It looks like QT5 was triggered by an scm change, but hard to tell as it was also started and aborted by kaning. Sune reported this to Thiago who

Re: Review Request 123743: Fix missing category to silence `desktop-file-validate`

2015-05-13 Thread Jan Kundrát
marked as submitted. Review request for KDE Frameworks. Changes --- Submitted with commit aa3c4e7797940e53433dfbd38a1bdc4b0a5727a6 by Jan Kundrát to branch master. Repository: ksshaskpass Description --- src/org.kde.ksshaskpass.desktop: error: (will be fatal in the future): value

Re: Review Request 123731: Cleanup handling of notifications closing

2015-05-12 Thread Jan Kundrát
is nullptr already? If not, can you fix the cause of that? src/notifybypopup.cpp (line 491) https://git.reviewboard.kde.org/r/123731/#comment55062 Is there an enum for this? Using that instead of a comment which explains what a magic value is about sounds much better. - Jan Kundrát On May 12

Review Request 123743: Fix missing category to silence `desktop-file-validate`

2015-05-12 Thread Jan Kundrát
. Either this one, or let's remove the Security bit altogether. Diffs - src/org.kde.ksshaskpass.desktop a5fa682b7e6195be2474f2547714d71d68dd7284 Diff: https://git.reviewboard.kde.org/r/123743/diff/ Testing --- Thanks, Jan Kundrát

Re: Review Request 123724: Use QTemporaryFile instead of hardcoding /tmp.

2015-05-12 Thread Jan Kundrát
get a CVE security announcement because it allows a local attacker to e.g. force you to overwirte some of your user's files. - Jan Kundrát On May 12, 2015, 12:49 p.m., Michael Palimaka wrote: --- This is an automatically generated e

Re: Versioning of Frameworks

2015-05-10 Thread Jan Kundrát
On Sunday, 10 May 2015 15:39:02 CEST, David Faure wrote: Qt *is* splitted. It's just that the splitted libs are released together. The splitting of Qt is not full and complete, however. Modules tend to use each other's internal APIs, and that's the biggest reason for not supporting random

Review Request 123700: Fix build with cmake 2.8.12.2

2015-05-09 Thread Jan Kundrát
of the situation. [1] https://mail.kde.org/pipermail/kde-frameworks-devel/2014-December/020713.html BUG: 347399 REVIEW: 123700 Diffs - src/match.cpp f84a824 Diff: https://git.reviewboard.kde.org/r/123700/diff/ Testing --- Thanks, Jan Kundrát

Re: KDE Frameworks 5.10.0 released

2015-05-09 Thread Jan Kundrát
Hi David, could you please clarify the release procedure, in particular what determines whether commits pushed after the -rc1 tag are included or not? I pushed a Qt 5.5 build fix to kitemmodels yesterday, but it apparently didn't make it through. Not a big deal, of course, but it got me

Re: Review Request 123679: Fix build with Qt 5.5

2015-05-08 Thread Jan Kundrát
marked as submitted. Review request for KDE Frameworks and Stephen Kelly. Changes --- Submitted with commit d598382536d8c9982bba3ee210869e50d1313dff by Jan Kundrát to branch master. Repository: kitemmodels Description --- Turns out that there's apparently no overload accepting

Review Request 123679: Fix build with Qt 5.5

2015-05-07 Thread Jan Kundrát
: https://git.reviewboard.kde.org/r/123679/diff/ Testing --- Thanks, Jan Kundrát ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Versioning of Frameworks

2015-05-06 Thread Jan Kundrát
Hi Christian, I think that the stuff you're looking for (reducing version churn) can also be provided by having stable branches for selected parts of KF5. IMHO this can be quite an elegant solution given the usual cat-herding problem of FLOSS where people just do what they want to do. Those

Gerrit upgraded to 2.11

2015-04-22 Thread Jan Kundrát
Hi, we're now running with Gerrit 2.11. This brings a couple of new features and changes. My personal favorite is the online editing via web browser. One can now fix up small changes in patches without going to git. It's also possible to create new changes from scratch, without touching Git

Re: Distros and QtWebEngine

2015-04-20 Thread Jan Kundrát
On Monday, 20 April 2015 21:14:51 CEST, Sune Vuorela wrote: And Red Hat is following Fedora. RHEL might not be a good example here because they are a rather a strange beast. RHEL has actually never shipped QtWebKit (!) and they also aren't shipping Qt5 so far. Cheers, Jan -- Trojitá, a

Re: Distros and QtWebEngine

2015-04-20 Thread Jan Kundrát
On Monday, 20 April 2015 21:12:44 CEST, Franz Fellner wrote: Is it really necessary to use a multiprocess web framework just to view HTML mails? I suppose that it is necessary to use an HTML content renderer which: - is still supported, - remains reasonably secure and up-to-date, - provides

Re: stable-KF5-QT5 QT version...

2015-04-18 Thread Jan Kundrát
On Saturday, 18 April 2015 17:17:16 CEST, Scarlett Clark wrote: qt5: { kf5-qt5: 5.4.1, stable-kf5-qt5: 5.3.2 }, The impression which I got in my earlier inquiries about this topic was that there's no KDE-wide consensus on which Qt5 version is the oldest

Re: Review Request 122978: Add unit test for crash of bug 343976

2015-03-16 Thread Jan Kundrát
know the code and API asumptions to know whether it's better to just Q_ASSERT in the other methods (`setText` etc.), but even if it was better to assert crash, this patch does provide a big improvement :). - Jan Kundrát On March 16, 2015, 12:04 p.m., Martin Gräßlin wrote

Re: Review Request 122908: Fix segfaults due to missing screens

2015-03-16 Thread Jan Kundrát
missing. Diffs - src/kwindoweffects_x11.cpp 661a0af95a7a1757c5ae863270434b0c2d5c0a26 Diff: https://git.reviewboard.kde.org/r/122908/diff/ Testing --- Thanks, Jan Kundrát ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org

Re: Review Request 122978: Add unit test for crash of bug 343976

2015-03-16 Thread Jan Kundrát
=optimized out) at /home/jkt/work/prog/trojita/src/Gui/main.cpp:217 ``` src/platformtheme/kdeplatformsystemtrayicon.cpp https://git.reviewboard.kde.org/r/122978/#comment53282 What about just: if (m_menu) - Jan Kundrát On March 16, 2015, 10:58 a.m., Martin Gräßlin wrote

KDeclarative doesn't build with Qt 5.2 due to QOpenGLContext::isOpenGLES() from plotter

2015-03-12 Thread Jan Kundrát
Hi, kdeclarative doesn't build on Qt 5.2 since commit 25c37a8a599f66e65be44ef99fd1fc8ca55dd477 [1] which introduced a hard dep on QOpenGLContext::isOpenGLES(), which is 5.3+ only. That commit was merged almost two months ago. Seems that I should configure some breakage notifications from the

Review Request 122908: Fix segfaults due to missing screens

2015-03-11 Thread Jan Kundrát
Diff: https://git.reviewboard.kde.org/r/122908/diff/ Testing --- Thanks, Jan Kundrát ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 122843: Mark QuickAddons as its own project.

2015-03-06 Thread Jan Kundrát
this! - Jan Kundrát On March 6, 2015, 4:07 p.m., Michael Palimaka wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122843

Re: Another proposal for modernization of our infrastructure

2015-02-03 Thread Jan Kundrát
On Tuesday, 3 February 2015 12:37:30 CEST, Martin Sandsmark wrote: So everyone with a KDE account will be able to push to any KDE project, bypassing Gerrit? Yes. -- Trojitá, a fast Qt IMAP e-mail client -- http://trojita.flaska.net/

Re: Another proposal for modernization of our infrastructure

2015-02-03 Thread Jan Kundrát
On Tuesday, 3 February 2015 11:36:37 CEST, Martin Sandsmark wrote: On Fri, Jan 30, 2015 at 11:44:22PM -0200, Thiago Macieira wrote: Many of your complaints about usability (threading, replies, etc.) are solved or at least partially addressed in the new Gerrit UI, which versions like 2.7

Re: Another proposal for modernization of our infrastructure

2015-02-03 Thread Jan Kundrát
On Tuesday, 3 February 2015 11:48:30 CEST, Martin Sandsmark wrote: As mentioned already, we've been using Gerrit at work for quite a while now, and having the code broken up by comments (sometimes many lines in case of a discussion) makes it extremely hard to actually follow the flow of the

Re: Another proposal for modernization of our infrastructure

2015-02-03 Thread Jan Kundrát
On Tuesday, 3 February 2015 11:53:30 CEST, Martin Sandsmark wrote: I think the point was more that what Gerrit has fixed were simple UI glitches, not radical improvements that change the existing design to make it easier for less experienced or casual users (or even experienced users, but that's

Re: Another proposal for modernization of our infrastructure

2015-02-02 Thread Jan Kundrát
On Monday, 2 February 2015 11:22:57 CEST, David Jarvie wrote: I occasionally contributed patches in the past to Qt, but since the current gerrit setup was introduced I've never even contemplated doing so because it looks too much effort to get to grips with. It's far too off-putting for

Re: Another proposal for modernization of our infrastructure

2015-01-31 Thread Jan Kundrát
On Friday, 30 January 2015 03:30:55 CEST, Kevin Kofler wrote: Unfortunately, file level strikes me as a less than helpful default. Can this be changed to line-level merges in our instance? (I think the ideal would be to use git's native merging algorithm(s), but I expect some limitations due

Re: Another proposal for modernization of our infrastructure

2015-01-31 Thread Jan Kundrát
On Saturday, 31 January 2015 22:09:36 CEST, Thomas Lübking wrote: Aside that this is an exhaustive HowTo on git and gerrit*, there're apparently upload your plain diff webfrontends. (Though I think the question was brought up and not answered how follow-up patches are handled - eg. whether

Re: Another proposal for modernization of our infrastructure

2015-01-31 Thread Jan Kundrát
On Saturday, 31 January 2015 21:38:23 CEST, Inge Wallin wrote: It is one thing if there is one tool that is totally too weak to work for experienced people and one tool that is awesome but very difficult to learn. But that's not the situation we have here. I think we have one tool that is

Re: Another proposal for modernization of our infrastructure

2015-01-31 Thread Jan Kundrát
On Thursday, 29 January 2015 19:31:20 CEST, Eike Hein wrote: Just for the record: I consider you a KDE sysadmin (you're administrating infra used by KDE, after all), so I meant the kde.org more general. Thanks. I forgot about this mail, and I realize that I am not sure whether my reply was

Re: Another proposal for modernization of our infrastructure

2015-01-31 Thread Jan Kundrát
On Saturday, 31 January 2015 12:20:15 CEST, Inge Wallin wrote: Given how few of our community who have participated so far, I think it borders on pure falsehood to claim clear consensus on *anything*. I would put more like some people want it, and I can certainly see the appeal. Fair enough,

Re: Another proposal for modernization of our infrastructure

2015-01-31 Thread Jan Kundrát
On Thursday, 29 January 2015 22:57:33 CEST, Ben Cooksley wrote: Given that upstream has had multiple attempts now at an improved interface, I would question whether they would be willing to accept a user interface which is suitable for our needs. It appears that they are quite comfortable with

Re: Another proposal for modernization of our infrastructure

2015-01-31 Thread Jan Kundrát
On Thursday, 29 January 2015 21:03:32 CEST, Eike Hein wrote: I think it's a real concern, and I'm wary of we can patch it away because carrying a huge custom patch delta for UI mods is what kept us from upgrading Bugzilla for multiple years. I think is it realistic that we can maintain this and

Re: Another proposal for modernization of our infrastructure

2015-01-31 Thread Jan Kundrát
On Saturday, 31 January 2015 11:14:01 CEST, Ben Cooksley wrote: Fixing a usability glitch and accepting a radical redesign of your interface are completely different. Your mail suggested that they apparently do not care about improving their UI, because if they did, they would have solved

Re: Another proposal for modernization of our infrastructure

2015-01-31 Thread Jan Kundrát
On Thursday, 29 January 2015 23:11:29 CEST, Eike Hein wrote: Maybe, but this is actually something I like from the Phabricator proposal: It provides an impression of our relationship with Phabricator upstream, which it says is a good and constructive one. I believe that our relation with the

Re: Another proposal for modernization of our infrastructure

2015-01-31 Thread Jan Kundrát
On Saturday, 31 January 2015 13:08:07 CEST, Inge Wallin wrote: Well, all of the above and more. Hosting, electricity, networking, I'm including all of the above as HW costs in my proposal. We (KDE) do not have our own datacenter after all. manual work as the number of physical machines

Re: Another proposal for modernization of our infrastructure

2015-01-30 Thread Jan Kundrát
On Thursday, 29 January 2015 12:25:57 CEST, Jan Kundrát wrote: Hi Martin, thanks for an excellent idea, sorting headers before actual code changes makes a lot of sense. I have a quick'n'dirty patch at [1]. The patch has been merged upstream and will be released in next version (2.11). I'll

Re: Feature matrix for future infrastructure

2015-01-29 Thread Jan Kundrát
On Thursday, 29 January 2015 12:49:17 CEST, Christoph Feck wrote: If it even allows to edit a change request from a different person online, then I *want that*. I find it much more time consuming and demotivating to nitpick small style/whitespace changes, than to simply edit them out. Yes,

Re: Another proposal for modernization of our infrastructure

2015-01-29 Thread Jan Kundrát
On Wednesday, 28 January 2015 13:14:14 CEST, Martin Gräßlin wrote: Navigation through the code is difficult, you cannot see the complete change in one, but have to go through each file. This is something I consider as unfortunate as normally I prefer reading the changes to the header before

Re: Another proposal for modernization of our infrastructure

2015-01-29 Thread Jan Kundrát
On Thursday, 29 January 2015 18:22:35 CEST, Eike Hein wrote: One thing I'm unclear on: Does the gerrit test instance run on machines administrated by kde.org these days? The VM runs at my workplace. The KDE sysadmins have root access, PostgreSQL backups are automatically pushed to a KDE

Re: Another proposal for modernization of our infrastructure

2015-01-28 Thread Jan Kundrát
On Wednesday, 28 January 2015 10:08:54 CEST, Ben Cooksley wrote: 1) Most applications integrate extremely poorly with LDAP. They basically take the details once on first login and don't sync the details again after that (this is what both Chiliproject and Reviewboard do). How does Gerrit perform

Re: Feature matrix for future infrastructure

2015-01-28 Thread Jan Kundrát
On Monday, 26 January 2015 18:11:34 CEST, Thomas Lübking wrote: Eg. I can very well see that somebody concerned w/ i18n would like to lookup code via cgit (or similar - no flames here, please ;-), download a single file, fix a so far untranslated string, diff -pru it with the original and

Re: Sysadmin report on the modernization of our infrastructure

2015-01-27 Thread Jan Kundrát
On Tuesday, 27 January 2015 09:51:46 CEST, Ben Cooksley wrote: Jenkins provides rich tracking of tests, code coverage and code quality (eg: cppcheck) in addition to checking if it builds. Zuul is designed to determine if it builds and if tests fail - providing a binary pass/fail response. This

Re: Feature matrix for future infrastructure

2015-01-24 Thread Jan Kundrát
On Friday, 23 January 2015 15:21:34 CEST, Boudewijn Rempt wrote: There is no way an artist who has a nice patch for Krita is ever going to be able to inducted into becoming a Krita developer if they have to follow instructions like this: https://techbase.kde.org/Development/Gerrit Hi

Re: Sysadmin report on the modernization of our infrastructure

2015-01-21 Thread Jan Kundrát
Please read Bens article again. We do this currently and its not working. This is what needs to be replaced. Phabricator seems to support this, or so they say, **and** is does what Gerrit does. So why not use that and have everything integrated? It's not as simple as picking a WWW git

Re: Sysadmin report on the modernization of our infrastructure

2015-01-21 Thread Jan Kundrát
On Wednesday, 21 January 2015 16:28:20 CEST, Thomas Lübking wrote: - The major concern about gerrit seems about scratch repos and I think I found a quite old bug/request on this which might cross trivial approaches w/ scripts? [1] Otoh, it seems Phabricator doesn't support scratch repos right

Re: Sysadmin report on the modernization of our infrastructure

2015-01-21 Thread Jan Kundrát
On Wednesday, 21 January 2015 15:54:52 CEST, Milian Wolff wrote: 6) The discussion focuses in highlighting Phabricator's benefits, which is understandable from your point of view. However, much of the same things can be said about Gerrit as well, especially its backing by a well-known player,

Re: Sysadmin report on the modernization of our infrastructure

2015-01-21 Thread Jan Kundrát
On Wednesday, 21 January 2015 20:07:21 CEST, Ben Cooksley wrote: 1) A detailed list of the issues which a competing proposal would have to address. Some glimpse of this is in the last paragraph, but that's just a very high-level description. Could you please provide a list of functionality that

Re: Sysadmin report on the modernization of our infrastructure

2015-01-21 Thread Jan Kundrát
On Wednesday, 21 January 2015 23:57:07 CEST, Ben Cooksley wrote: Using either http://www.guywarner.com/2014/06/part-2-integrating-phabricator-and.html or http://www.dctrwatson.com/2013/01/jenkins-and-phabricator/ or a variation thereof. That is quite some custom code that one has to maintain,

Re: Sysadmin report on the modernization of our infrastructure

2015-01-21 Thread Jan Kundrát
On Wednesday, 21 January 2015 23:12:33 CEST, Thomas Lübking wrote: The bug cooked up for asking google about gerrit and scratch repos. The problem is that pushing into any branch would close a review - I can only assume it was linked in the mail thread I found because a similar issue would

Re: Sysadmin report on the modernization of our infrastructure

2015-01-21 Thread Jan Kundrát
Hi Ben, thanks for your proposal. A couple of points which I'm missing from the text, and a few further questions as well: 1) A detailed list of the issues which a competing proposal would have to address. Some glimpse of this is in the last paragraph, but that's just a very high-level

Re: Required and supported Qt versions

2015-01-09 Thread Jan Kundrát
On Tuesday, 30 December 2014 09:32:08 CEST, David Faure wrote: Ideally every released minor version since 5.2 :-) i.e. 5.2, 5.3, 5.4. Possibly even dev. Hi, the CI which is plugged into Gerrit now checks the following combinations: - Qt 5.2.1, GCC 4.8.2 (RHEL7), release mode - Qt 5.3.2, clang

Re: Qt 5 buildability

2015-01-09 Thread Jan Kundrát
On Thursday, 8 January 2015 22:59:53 CEST, Ben Cooksley wrote: QtWebEngine won't build unless you have nss-devel installed (which it complains about) but it also won't build unless libcap-devel is installed (which it doesn't complain about - you only find out when the compiler bails out on you).

Re: Changes to our Git infrastructure

2015-01-06 Thread Jan Kundrát
On Monday, 5 January 2015 20:57:47 CEST, Frank Reininghaus wrote: Ultimately, a constant stream of newcomers is the only thing that keeps a free software project alive in the long term. Yes, as long as these newcomers eventually get enough interest and enough skills to become maintainers. I

Re: Changes to our Git infrastructure

2015-01-06 Thread Jan Kundrát
On Tuesday, 6 January 2015 07:40:01 CEST, Ian Wadham wrote: a) I do not know anything about Dr K, but I will try and find someone who does. b) Unfortunately there is nobody available any more who knows anything about Dr K, but I (or another suggested guy) will try to help. How

Re: Changes to our Git infrastructure

2015-01-06 Thread Jan Kundrát
On Monday, 5 January 2015 22:22:19 CEST, Boudewijn Rempt wrote: Usually, half-way through they ask me, why doesn't KDE use github I do not understand how stuff would change if we used GitHub, though. There would still be that huge gap of not understanding which of the repos to use. I think

  1   2   >