---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120879/#review69383
---
Ship it!
Ship It!
- Lamarque Souza
On Oct. 29, 2014, 4:27
/r/120573/#comment47629
QFile::remove() does not work with directories. You should use
QDir().rmdir() instead, which only works as long as the directory is empty
though.
- Lamarque Souza
On Oct. 13, 2014, 5:32 p.m., René J.V. Bertin wrote
redundant to me. Can you check if it still works without this change?
- Lamarque Souza
On July 21, 2014, 8:08 a.m., zhang jun wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119381
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119381/#review62833
---
Ship it!
Ship It!
- Lamarque Souza
On July 21, 2014, 8:08
/powerdevilupowerbackend.cpp
https://git.reviewboard.kde.org/r/119088/#comment42813
A line with 'delete job' before this return is missing here.
- Lamarque Souza
On July 2, 2014, 5:45 p.m., Martin Bříza wrote:
---
This is an automatically generated e-mail
Hi all,
I agree that Plasma NM should go to kde/workspace. In the past the only
thing that prevented that was the fact that we needed to change
translatable strings from time to time, which obviously does not comply
with the string freeze. Now that kde/workspace is released more often that
should
repo from my work.
- Lamarque Souza
On May 23, 2014, 6:48 p.m., Sebastian Kügler wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118286
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118286/#review58377
---
Ship it!
Ship It!
- Lamarque Souza
On May 23, 2014, 6:48
2014 19:51:05 Lamarque Souza wrote:
I understood that, I just do not know all the other things we need to do
to make NMQt/MMQt part of KF5. And yes, I agree in making NMQt/MMQt part
of
KF5. The other doubt I still have is where _kde_add_platform_definitions
is defined. By what I could
2014 19:51:05 Lamarque Souza wrote:
I understood that, I just do not know all the other things we need to
do
to make NMQt/MMQt part of KF5. And yes, I agree in making NMQt/MMQt
part
of
KF5. The other doubt I still have is where
_kde_add_platform_definitions
is defined. By what
kde...@unormal.org wrote:
Am Montag, 07. April 2014, 14.38:14 schrieb Lamarque Souza:
Hi all,
Morning Lamarque
I have cloned ECM git repo and looked at it. I agree that it is small and
it has useful features for NMQt/MMQt. I like the fact that it provides a
FindNetworkManager.cmake. Ok
Hi all,
I have cloned ECM git repo and looked at it. I agree that it is small and
it has useful features for NMQt/MMQt. I like the fact that it provides a
FindNetworkManager.cmake. Ok, we can make ECM a hard dependency for
NMQt/MMQt.
My only concern now is the kde-modules that Jan used in
probably change versions, releasing etc.
Jan
On Monday 07 of April 2014 09:38 Lamarque Souza wrote:
Hi all,
I have cloned ECM git repo and looked at it. I agree that it is small and
it has useful features for NMQt/MMQt. I like the fact that it provides a
FindNetworkManager.cmake. Ok, we can
Qt API for
NetworkManager/ModemManager, so you can manage connections and devices.
Jan
On Friday 04 of April 2014 05:29 Lamarque Souza wrote:
Both libraries are meant to be reusable. What I meant with merge is the
fact that the branches frameworks in NMQt and MMQt depends on KF5's
cmake
Ottens er...@kde.org escreveu:
Hello,
On Thursday 03 April 2014 20:19:45 Lamarque Souza wrote:
Well, NetworkManagerQt and ModemManagerQt are Qt only libraries since the
beginning. They are not meant to depend on any KDE libraries as I said,
so
they are not meant to be merged to KF5.
Note
V. Souza
KDE's Network Management maintainer
http://planetkde.org/pt-br
On Sat, Apr 5, 2014 at 12:08 PM, Albert Astals Cid aa...@kde.org wrote:
El Divendres, 4 d'abril de 2014, a les 07:57:26, Lamarque Souza va
escriure:
NMQt and MMQt used to be backends for Solid. We moved them from Solid
Is using ECM required to be part of KF5?
Lamarque V. Souza
KDE's Network Management maintainer
http://planetkde.org/pt-br
On Sat, Apr 5, 2014 at 12:56 PM, Albert Astals Cid aa...@kde.org wrote:
El Dissabte, 5 d'abril de 2014, a les 12:39:27, Lamarque Souza va escriure:
In CMakeLists.txt
Hi all,
1) I do not see a real need to rename (again) ModemManagerQt and
NetworkManagerQt. They are named that way to indicate they depend only on
Qt and not on any library created by KDE, so they are tier1 since the
beginning. I am not familiar with KF5's library naming conventions but I
would
keep them Qt only and not depend on KF5, the opposite is ok though.
Lamarque V. Souza
KDE's Network Management maintainer
http://planetkde.org/pt-br
On Thu, Apr 3, 2014 at 1:11 PM, Jan Grulich jgrul...@redhat.com wrote:
On Thursday 03 of April 2014 12:52 Lamarque Souza wrote:
Hi all,
1
on reviewboard. Can you
provide the correct patch?
I looked into the raw patch and I think the return 1 line that you commented
should be kept when the action is not upgrade.
- Lamarque Souza
On March 30, 2014, 3:47 a.m., Andrei Amuraritei wrote
the mentioned return 1
line, otherwise we will have a memory leak.
- Lamarque Souza
On March 30, 2014, 3:47 a.m., Andrei Amuraritei wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117175
On March 30, 2014, 11:23 a.m., Lamarque Souza wrote:
Hi, there is an error when trying to show the patch on reviewboard. Can you
provide the correct patch?
I looked into the raw patch and I think the return 1 line that you
commented should be kept when the action is not upgrade
On March 30, 2014, 11:23 a.m., Lamarque Souza wrote:
Hi, there is an error when trying to show the patch on reviewboard. Can you
provide the correct patch?
I looked into the raw patch and I think the return 1 line that you
commented should be kept when the action is not upgrade
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117129/#review54406
---
Ship it!
Ship It!
- Lamarque Souza
On March 27, 2014, 9
://git.reviewboard.kde.org/r/117129/#comment38025
Just confirming that Plasma NM 0.9.0.x disables autoconnect for wifi shared
connections. Your patch also disables autoconnect for wired shared connections,
which is correct too.
- Lamarque Souza
On March 27, 2014, 9:21 p.m., Xuetian Weng wrote
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116098/#review51909
---
Ship it!
Ship It!
- Lamarque Souza
On March 4, 2014, 4:13
On March 4, 2014, 4:42 p.m., Lamarque Souza wrote:
Ship It!
Lamarque Souza wrote:
This should be ported to branches master and NM/0.9.8 as well.
Alexander Richardson wrote:
How should I commit it? Commit to oldest branch and then merge? Or rather
put this into qt5
for everybody. Is there any real
issue solved by GNUInstallDirs that cannot be solved by -DLIB_SUFFIX=64?
- Lamarque Souza
On March 1, 2014, 11:14 a.m., Alexander Richardson wrote:
---
This is an automatically generated e-mail
/
Testing (updated)
---
Tested by the bug reporter and it fixes the problem for him.
Thanks,
Lamarque Souza
/
Testing (updated)
---
Tested by the bug reporter and it fixes the problem for him.
Thanks,
Lamarque Souza
___
Kde-hardware-devel mailing list
Kde-hardware-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-hardware-devel
.
http://bugs.kde.org/show_bug.cgi?id=324954
Diffs
-
solid/solid/backends/udev/udevnetworkinterface.cpp 06dc907
Diff: http://git.reviewboard.kde.org/r/112869/diff/
Testing
---
No testing but it is pretty obvious that we should not left that socket opened.
Thanks,
Lamarque Souza
.
http://bugs.kde.org/show_bug.cgi?id=324954
Diffs
-
solid/solid/backends/udev/udevnetworkinterface.cpp 06dc907
Diff: http://git.reviewboard.kde.org/r/112869/diff/
Testing
---
No testing but it is pretty obvious that we should not left that socket opened.
Thanks,
Lamarque Souza
-modemGsmCardIface.GetOperatorId() call and let the user decice if he/she
wants to use the synchronous or asynchronous API. We should not force a
synchronous API here. The same is valid for getSpn() below.
- Lamarque Souza
On Sept. 2, 2013, 9:54 p.m., Anant Kamath wrote
://git.reviewboard.kde.org/r/111918/#comment27622
Well, I thought about DisplayPointerEventSource but it is too long. Display
pointer is one thing and the event source for the display pointer is another
thing, this patch is about the later.
- Lamarque Souza
On Aug. 8, 2013, 9:04 a.m., Ivan Čukić wrote
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111918/#review37380
---
Patch looks good to me, no objections.
- Lamarque Souza
parameter. It is not used and SmsInterface's destructor
already deletes this object.
- Lamarque Souza
On July 3, 2013, 5:49 p.m., Anant Kamath wrote:
---
This is an automatically generated e-mail. To reply, visit:
http
.
modemgsmsmsinterface_p.h
http://git.reviewboard.kde.org/r/111366/#comment26021
This does not seem the correct place to add this define. It should be in a
general header that other headers can use it as well, like generic-types.h.
- Lamarque Souza
On July 2, 2013, 6:36 p.m., Anant Kamath wrote
ModemManager's source code.
Let's hope this works out for everybody.
- Lamarque Souza
On July 2, 2013, 9:35 p.m., Anant Kamath wrote:
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111366
/111295/#comment25923
change this method's name to importSecretsFromPlainTextFiles.
- Lamarque Souza
On June 29, 2013, 8:11 a.m., Jan Grulich wrote:
---
This is an automatically generated e-mail. To reply, visit:
http
for the
returned value.
- Lamarque Souza
On May 15, 2013, 7:39 p.m., José Millán Soto wrote:
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110459
.
Shouldn't this variable go to version.h? klipper_version is defined there.
- Lamarque Souza
On May 15, 2013, 7:39 p.m., José Millán Soto wrote:
---
This is an automatically generated e-mail. To reply, visit:
http
.
drkonqi/reportinterface.cpp
http://git.reviewboard.kde.org/r/110687/#comment24624
same here.
- Lamarque Souza
On May 28, 2013, 11:01 a.m., Jekyll Wu wrote:
---
This is an automatically generated e-mail. To reply, visit:
http
/110670/#comment24571
What is exactly the bug this patch is trying to solve? Is there any bug
entry in bugzilla for it (or them)?
- Lamarque Souza
On May 27, 2013, 1:14 p.m., Oliver Henshaw wrote:
---
This is an automatically
[2] https://git.reviewboard.kde.org/r/110331
kwalletd/kwalletd.cpp
http://git.reviewboard.kde.org/r/110328/#comment23931
password is a QString, right? Then you should use password.clear() here
instead of assigning an empty QString. That avoids creating a temporary QString.
- Lamarque
On May 6, 2013, 4:40 p.m., Lamarque Souza wrote:
kwalletd/kwalletd.h, line 226
http://git.reviewboard.kde.org/r/110328/diff/1/?file=142372#file142372line226
Why split this feature into three different review requests? One of
your requests [2] is just one line change and the other
I have just taken my first bus during this jorney. I see you in 30 hours :-/
Em 16/04/2013 12:57, Lamarque V. Souza lamar...@kde.org escreveu:
**
Em Sunday 14 April 2013, Jan Grulich escreveu:
On 04/14/2013 01:44 AM, Lukáš Tinkl wrote:
Dne 14.4.2013 01:06, Daniel Vrátil napsal(a):
On Feb. 20, 2011, 3:51 p.m., Lukáš Tinkl wrote:
Looks OK to me
Lamarque Souza wrote:
Can this patch be commited to trunk?
Lamarque Souza wrote:
Ok, I will commit this patch then.
Patch submitted. I do not know why but it has not been marked as so. Someone
please close
On Feb. 20, 2011, 3:51 p.m., Lukáš Tinkl wrote:
Looks OK to me
Lamarque Souza wrote:
Can this patch be commited to trunk?
Ok, I will commit this patch then.
- Lamarque
---
This is an automatically generated e-mail. To reply
On Jan. 21, 2011, 12:38 p.m., Sebastian Kügler wrote:
Patch looks good, though api docs for the two public methods would be good.
Thanks for looking into this annoying issue!
I have added the changes Sebas requested and commited the changes. Please close
this review request.
- Lamarque
---
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/5599/#review8077
---
101 - 150 of 150 matches
Mail list logo
