Re: Information regarding upcoming Gitlab Migration: clarifications

use either of the 'quick config' schemes like kdesrc-build-setup or kdesrc-build --initial-setup), but to leave the built-in default unchanged. So in essence, existing kdesrc-build users (who had a folder-based layout by default unless they went out of their way to find the right option) saw no change, but new users would have that option pre-set for them in the config. Regards, - Michael Pyne

Re: Information regarding upcoming Gitlab Migration: clarifications

use either of the 'quick config' schemes like kdesrc-build-setup or kdesrc-build --initial-setup), but to leave the built-in default unchanged. So in essence, existing kdesrc-build users (who had a folder-based layout by default unless they went out of their way to find the right option) saw no change, but new users would have that option pre-set for them in the config. Regards, - Michael Pyne

Re: Information regarding upcoming Gitlab Migration: clarifications

use either of the 'quick config' schemes like kdesrc-build-setup or kdesrc-build --initial-setup), but to leave the built-in default unchanged. So in essence, existing kdesrc-build users (who had a folder-based layout by default unless they went out of their way to find the right option) saw no change, but new users would have that option pre-set for them in the config. Regards, - Michael Pyne

Re: Notice of upcoming changes to the behaviour of the anongit network

https://community.kde.org/Sysadmin/GitKdeOrgManual#Let_Git_rewrite_URL_prefixes). kdesrc-build configures git to understand this "kde:" prefix by default. Regards, - Michael Pyne

Re: Notice of upcoming changes to the behaviour of the anongit network

https://community.kde.org/Sysadmin/GitKdeOrgManual#Let_Git_rewrite_URL_prefixes). kdesrc-build configures git to understand this "kde:" prefix by default. Regards, - Michael Pyne

Re: Notice of upcoming changes to the behaviour of the anongit network

https://community.kde.org/Sysadmin/GitKdeOrgManual#Let_Git_rewrite_URL_prefixes). kdesrc-build configures git to understand this "kde:" prefix by default. Regards, - Michael Pyne

Re: Update on Status of Gitlab Migration

de: repositories use the kde:foo syntax, where the 'foo' comes from the 'repopath' parameter of the sysadmin/repo-metadata YAML files. We may need to do on-the-fly conversion of the kde: repo paths if they won't be expressible as 'kde:foo' in the future, but we should have the information needed to do this in kdesrc-build to make this happen on-the-fly. Regards, - Michael Pyne

Re: Update on Status of Gitlab Migration

de: repositories use the kde:foo syntax, where the 'foo' comes from the 'repopath' parameter of the sysadmin/repo-metadata YAML files. We may need to do on-the-fly conversion of the kde: repo paths if they won't be expressible as 'kde:foo' in the future, but we should have the information needed to do this in kdesrc-build to make this happen on-the-fly. Regards, - Michael Pyne

Re: Update on Status of Gitlab Migration

de: repositories use the kde:foo syntax, where the 'foo' comes from the 'repopath' parameter of the sysadmin/repo-metadata YAML files. We may need to do on-the-fly conversion of the kde: repo paths if they won't be expressible as 'kde:foo' in the future, but we should have the information needed to do this in kdesrc-build to make this happen on-the-fly. Regards, - Michael Pyne

D26839: demote plugin load errors from warning to debug level + reword

mpyne accepted this revision. mpyne added a comment. Agreed, let's commit. REPOSITORY R244 KCoreAddons BRANCH master REVISION DETAIL https://phabricator.kde.org/D26839 To: sitter, mpyne, ngraham Cc: ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D26405: Add mime type for backtraces saved from DrKonqi

mpyne accepted this revision. mpyne added a comment. This revision is now accepted and ready to land. Thanks Harald. Patch looks good and I've checked that the file name pattern is what Dr. Konqi uses by default. One question though, @broulik you mentioned there's also text/x-apport, should

D24046: Allow triggering sort from QML

mpyne added inline comments. INLINE COMMENTS > broulik wrote in personssortfilterproxymodel.h:53 > "You can ... reimplement virtual functions defined in the primary base class > hierarchy (that is, virtuals defined in the first non-virtual base class, or > in that class's first non-virtual

D23205: [KProcessList] Optimize KProcessList::processInfo

mpyne accepted this revision. mpyne added a comment. This revision is now accepted and ready to land. I've reviewed the patch and it's good, you've addressed the issues that were noted by Aleix already, so please commit and we can address anything that might pop up as it happens. REPOSITORY

D23800: Use ECMGenerateExportHeader to manage deprecated API better

mpyne accepted this revision. mpyne added a comment. This revision is now accepted and ready to land. The change looks good and builds in various combinations of CMake options (after I installed the changeset from D23789 ). I encountered that excluding

Re: KDE incubator candidate request for marK tool

ent accounts if you haven't already done so. >From there, you and/or your sponsor can put in a request to our system administrators to create a repository. See http://sysadmin.kde.org/tickets/ to do so. Regards, - Michael Pyne

Re: kdesrc-build messes with environment

/kde/kdesrc-build/issues/29 for the bug report. I have built a patch that might work and would appreciate if you could test. Regards, - Michael Pyne

D20092: New class KOSRelease - a parser for os-release files

mpyne accepted this revision. mpyne added a comment. +1 to @aacid's comment about relicensing. The code is good and easy to review. Only comment I had was to think about using a warning or error when unable to parse the file. I think that the `ID_LIKE` handling could be done by

D20008: Fix uninitialized value in SimpleJobPrivate

This revision was automatically updated to reflect the committed changes. Closed by commit R241:920d2c4ca7d5: kjobs: Fix compiler warning for uninit value in SimpleJobPrivate. (authored by mpyne). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE

D20008: Fix uninitialized value in SimpleJobPrivate

mpyne created this revision. mpyne added reviewers: dfaure, Frameworks, apol. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. mpyne requested review of this revision. REVISION SUMMARY As reported in bug 404474 ,

Re: Gitlab Evaluation & Migration

really > slick. That would be slick. I wonder if Gitlab exposes an API for that (ideally something that doesn't involve kdesrc-build having to store your creds)? Potentially this API https://docs.gitlab.com/ee/api/projects.html#fork-project (though it's documented for EE not CE)? Regards, - Michael Pyne

Re: Building KDE statically

ll. I'm impressed you convinced stock kdesrc-build to make this work, even with pre-built executables. Have you looked into things like Snap or Flatpak at all as a way to ease deployments? Or is this meant to be a bit more crossplatform (Linux, macOS, Windows)? Regards, - Michael Pyne

D18137: delete copy constructor and assignment operator of some public classes

mpyne accepted this revision. mpyne added a comment. This revision is now accepted and ready to land. The KSharedDataCache change is definitely correct. I've not done much with the kdelibs migrator but I agree with the logic and the implementation. Have you tried building some of the other

Re: How to kdesrc-build a specific release?

lease let us know, we could add a working configuration as an example in kdesrc-build. Regards, - Michael Pyne

D17647: Fix KGlobalAccel build with Qt 5.13 prerelease

This revision was automatically updated to reflect the committed changes. Closed by commit R268:c96d012b6d47: Fix KGlobalAccel build with Qt 5.13 prerelease. (authored by mpyne). REPOSITORY R268 KGlobalAccel CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17647?vs=47743=47775

D17647: Fix KGlobalAccel build with Qt 5.13 prerelease

mpyne created this revision. mpyne added reviewers: Frameworks, graesslin. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. mpyne requested review of this revision. REVISION SUMMARY After a recent system upgrade to Qt git `dev` branch (for upcoming 5.13),

Re: Building KDE (phonon-vlc) fails

t; Any idea on what I am missing here? Perhaps you need a package libvlccore-dev or similar? The FindLIBVLC in phonon-vlc checks for both libvlc and for libvlccore but only gives the one error message if either one is missing. Regards, - Michael Pyne

D17446: cmake macros: Port away from deprecated ECM var in kcoreaddons_add_plugin

This revision was automatically updated to reflect the committed changes. Closed by commit R244:1285c4bf5552: cmake macros: Port away from deprecated ECM var in kcoreaddons_add_plugin (authored by mpyne). REPOSITORY R244 KCoreAddons CHANGES SINCE LAST UPDATE

D17446: cmake macros: Port away from deprecated ECM var in kcoreaddons_add_plugin

mpyne created this revision. mpyne added reviewers: Frameworks, elvisangelaccio, apol, dfaure. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. mpyne requested review of this revision. REVISION SUMMARY As reported in bug 401888

D17078: Make it possible to use KAboutData/License/Person from QML

mpyne added a comment. In D17078#363886 , @apol wrote: > In D17078#363772 , @anthonyfieroni wrote: > > > You can't change parameters in methods or constructors, it's a BIC. > > >

Re: Regression in Frameworks - DBus Hangs

any sort that I see in either KF5 or kde/workspace for "quitOnLastWindowClosed" is in kxmlgui (for KMainWindow). There aren't many recent commits so anyone who can reproduce the hang should have a quick job verifying if reverting some of those would help or not. [1] Using git -P log --since="8 weeks ago" -G quitOnLastWindow --oneline for each git repository Regards, - Michael Pyne

Re: Password field security and information leaking

pplication is able to use a secure password entry widget, it could perhaps be possible to be able to safely set or update authentication credentials in the same app config U/I (i.e. have the app itself serve the pinentry-qt role). Regards, - Michael Pyne

D16189: kio_help: Fix crash in QCoreApplication when accessing help://

This revision was automatically updated to reflect the committed changes. Closed by commit R241:cf3b0d102855: kio_help: Fix crash in QCoreApplication when accessing help://. (authored by mpyne). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16189?vs=43569=43593

Re: New Contributor...

/30/kdes-goals-2018-and-beyond) is to improve this process. If you come across anything that seems like a barrier we'd like to know so we can address it for future members of the Community. Regards, - Michael Pyne

Re: KDE4 build question: turning off hidden visibility?

CXX_FLAGS, though try to do this in a way that maintains the existing KDE settings. Regards, - Michael Pyne

D16189: kio_help: Fix crash in QCoreApplication when accessing help://

mpyne created this revision. mpyne added reviewers: Frameworks, sitter. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. mpyne requested review of this revision. REVISION SUMMARY A recent commit d428fc8e6447ede81f1e1911d0b66b39265672f3

D8256: Add _XOPEN_SOURCE to C definitions

mpyne added a comment. Sorry, if I'd been able to check this earlier I'd have warned against pushing, this was the kind of concern I was addressing with my earlier comment about FreeBSD. I had run into a lot of those issues when trying to get KF5 to build on Alpine. Adding an

D15076: Build failures with KSyntaxHighlighting 5.49

mpyne added a comment. The ECM documentation points to a specific change that may be related: https://api.kde.org/ecm/kde-module/KDECMakeSettings.html#build-settings Using the `KDE_SKIP_BUILD_SETTINGS` option that is described just leads to different build failures for me, however. I

D15076: Build failures with KSyntaxHighlighting 5.49

mpyne added a comment. I don't know the cause myself but the ECM version works up until 5.38.0 in my own testing. So presumably the change in behavior is something introduced in that release of ECM? REPOSITORY R55 Cantor REVISION DETAIL https://phabricator.kde.org/D15076 To: asemke,

D13627: [KSharedDataCache] Assume lock before flush changes

mpyne added a comment. I'd say to leave the code alone if this the change isn't needed to fix a bug. REPOSITORY R244 KCoreAddons REVISION DETAIL https://phabricator.kde.org/D13627 To: anthonyfieroni, davidedmundson, dfaure, #frameworks, hein, mpyne Cc: mpyne, hein, kde-frameworks-devel,

D14908: Bindings: Add support for scoped enums

mpyne accepted this revision. mpyne added a comment. This revision is now accepted and ready to land. LGTM and there's been plenty of time for a NAK. I say let's commit. REPOSITORY R240 Extra CMake Modules BRANCH scoped_enum REVISION DETAIL https://phabricator.kde.org/D14908 To:

D14984: Explicitly request Qt 5.7's QtQuick to make use of Connections.enabled

This revision was automatically updated to reflect the committed changes. Closed by commit R169:b23e642e5ac4: Explicitly request Qt 5.7s QtQuick to make use of Connections.enabled (authored by mpyne). REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE

D14908: Bindings: Add support for scoped enums

mpyne added a comment. As long as older versions of LLVM result in the Python binding generation step being skipped completely (we already check for libclang in the find-package for this, right?), I don't think the dependency increase is a problem. REPOSITORY R240 Extra CMake Modules

D14984: Explicitly request Qt 5.7's QtQuick to make use of Connections.enabled

mpyne created this revision. mpyne added reviewers: Frameworks, Plasma, mart. Herald added a project: Kirigami. Herald added a subscriber: plasma-devel. mpyne requested review of this revision. REVISION SUMMARY I recently rebuilt my Qt, KF5, and Plasma 5 environments from scratch. I noticed

D13627: [KSharedDataCache] Assume lock before flush changes

mpyne accepted this revision. mpyne added a comment. This change has worked fine for me in my testing (including KDE games and Plasma themes) so I think it's fine to commit. REPOSITORY R244 KCoreAddons REVISION DETAIL https://phabricator.kde.org/D13627 To: anthonyfieroni,

D14908: Bindings: Add support for scoped enums

mpyne added a comment. LGTM but then I don't use the Python bindings. Have you already tried the kcoreaddons build to see if this makes it work where it had failed before? REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D14908 To: bruns, #frameworks Cc:

D13627: [KSharedDataCache] Assume lock before flush changes

mpyne added a comment. The patch looks OK but I'm a bit worried about trying to lock the cache at the same time we're potentially trying to delete a KSharedDataCache so I'm going to recompile and do some stress and sanity tests first. REPOSITORY R244 KCoreAddons REVISION DETAIL

D12233: Avoid manipulation of lists with quadratic complexity

mpyne accepted this revision. mpyne added a comment. I don't use Baloo directly but I've taken a look from a code sanity perspective and agree with @dhaumann that the change is a proper port of the existing logic. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D12233

D13627: [KIconThemes] Isolate private data from race conditions

mpyne added a comment. In D13627#287837 , @anthonyfieroni wrote: > https://phabricator.kde.org/source/kiconthemes/browse/master/src/kiconloader.cpp$603 > So the problem maybe not here as IconLoader loads icons but in icon writer >

Re: Version Error while building KDE frameworks and Qt5

s Qt. There are some detailed instructions on building from source at https://community.kde.org/Guidelines_and_HOWTOs/Build_from_source which may help. Regards, - Michael Pyne

Re: kdesrc-build: PolkitQt5-1

On Wed, May 16, 2018 at 11:38:02AM +0200, gregor.mi.sw wrote: > On 16.05.2018 10:53, Christophe Giboudeaux wrote: > > Hi, > > > > On mercredi 16 mai 2018 05:17:02 CEST Michael Pyne wrote: > >> > >> The only thing that comes to mind is the possibility of usi

Re: kdesrc-build: PolkitQt5-1

On Wed, May 16, 2018 at 10:25:14AM +0200, gregor.mi.sw wrote: > On 16.05.2018 05:17, Michael Pyne wrote: > > On Tue, May 15, 2018 at 10:33:17AM +0200, gregor.mi.sw wrote: > >> Hello Michael, > >> > >> I just started a full rebuild and closely watched the CMak

Re: kdesrc-build: PolkitQt5-1

ough I'm planning just to modify kdesrc-build to set the variable regardless just in case. To avoid --refresh-build you can call "kdesrc-build --reconfigure kauth" to re-run CMake first without deleting the build directory. [1] https://cmake.org/cmake/help/latest/command/find_package.html Regards, - Michael Pyne

Re: kdesrc-build: cmake should take local (instead of system-wide) cmake modules

On Sat, May 12, 2018 at 02:23:47PM +0200, gregor.mi.sw wrote: > On 10.05.2018 02:22, Michael Pyne wrote: > > On Wed, May 09, 2018 at 01:12:10PM +0200, gregor.mi.sw wrote: > >> Am 09.05.2018 08:19 schrieb Ben Cooksley: > >>> On Wed, May 9, 2018 at 9:28 AM, grego

Re: kdesrc-build: cmake should take local (instead of system-wide) cmake modules

ould ../build also be ok? ../build should work but I'd recommend ~/kde/build for clarity. > make-options -j4 > svn-server svn+ssh://s...@svn.kde.org/home/kde > end global Regards, - Michael Pyne

Re: kdesrc-build: cmake should take local (instead of system-wide) cmake modules

hough there is a cache, default .kdesrc-build-data in the same directory as your kdesrc-buildrc). However the CMake package to find when a CMake module config file is loaded is based on the CMake paths when the module config file was *installed*. So all imported libraries would have be reinstalled to fully fix the paths. I've had these problems over the years and I've almost always found it easier just to remove the CMake module config files entirely before reinstalling to force it to be regenerated. It may be easiest to remove the install directory completely and use "kdesrc-build --refresh-build" to avoid interference from previously-installed cruft. Regards, - Michael Pyne

Re: KAuth helper trouble

r returns any output and doesn't take as long as it > should. Is there any way I can get better debugging output to see > what is happening? qDebug() should work OK but tools like GammaRay might make it easier to trace between signal/slot emissions (once the missing event loop is fixed, that is). Regards, - Michael Pyne

Re: Unable to compile KWidgetsAddons

ending work or associated important files that you might have in the source directory! Regards, - Michael Pyne

Re: Unable to compile KWidgetsAddons

pertise to be able to pin down why it doesn't understand what compiler features are available for gcc or what code is asking for these features in the first place. Regards, - Michael Pyne

Re: KDE in prefix install

On Thu, Mar 29, 2018 at 12:19:26PM +0200, Allan Sandfeld Jensen wrote: > On Donnerstag, 29. März 2018 03:26:08 CEST Michael Pyne wrote: > > I can document that. I assume the Wiki page for building from source is > > where you would expect to find that? Or were you looking at the &

Re: KDE in prefix install

y and just doesn't install them (maybe it would with "make-install-prefix sudo" enabled)? Or do we just need to add some appropriate flags to cmake when building kauth? Regards, - Michael Pyne

D11290: [UDevManager] Already filter for subsystem before querying

mpyne added a comment. I never had the bug myself, I just grepped through the attached log to see if it made sense or not. :) I'll close the bug for now, if it doesn't fix the issue then it'll just get reopened. REPOSITORY R245 Solid REVISION DETAIL https://phabricator.kde.org/D11290

D11290: [UDevManager] Already filter for subsystem before querying

mpyne added a comment. Any reason not to close the bug 391738? I can do so but wanted to make sure it wasn't intentionally left open. REPOSITORY R245 Solid REVISION DETAIL https://phabricator.kde.org/D11290 To: broulik, #frameworks, davidedmundson Cc: mpyne, ngraham, michaelh

Re: KF5 Conversion problems

On Sun, Mar 11, 2018 at 08:40:56PM +0700, Robin Atwood wrote: > On Sunday 11 March 2018, Michael Pyne wrote: > > > Yes, but the problem is the /usr/include/kdialog.h when it should be > > > finding /usr/include/KF5/KDELibs4Support/kdialog.h. I have > > > find_

Re: KF5 Conversion problems

think it would still find the right QDialog though. That's why it sounds like there's 2 problems. I think the issue here is that there is no longer a QtGui/QDialog. The right path would be in QtWidgets/QDialog with Qt5. It's better (and now recommended) just to use a '#include ' (and in general, #include ). Regards, - Michael Pyne

D10989: Check for nullptr in indexForNode

mpyne added a comment. I'm not sure the job could have been deleted before `KDialogJobUiDelegate::showErrorMessage()` since much of the call stack before then involves making method calls on the job. KDirLister::handleError(KIO::Job*) (kdirlister.cpp:81) makes a call to `job->error()`

D10168: Use nullptr for passing a null pointer to crc32

mpyne accepted this revision. mpyne added a comment. This revision is now accepted and ready to land. Actually `-Wzero-as-null-pointer-constant` is probably a good idea, and this is a correct fix. A decade ago when everything was going from 32 to 64-bits, we ran into a JuK crash bug because

D10450: Generate a custom target in kcoreaddons_desktop_to_json

mpyne added a comment. OK then, I think @kossebau is right in that this is a dependency issue in the `lookandfeel` part of plasma-desktop. The `kcm_lookandfeel` target declares the JSON dependency (with the CMake macro) in time for CMake to care about it and ensure the generated build

D10450: Generate a custom target in kcoreaddons_desktop_to_json

mpyne added a comment. In D10450#208453 , @kossebau wrote: > So just to make sure we are all on the same page: for what I have understood meanwhile is what is missing but needed here is a dependency rule between > a) the generated JSON file

D10450: Generate a custom target in kcoreaddons_desktop_to_json

mpyne added a comment. What about this? I can't change the diff since I didn't create the RR, but this seems to cause the required dependency rules to be added and works for me to build plasma-desktop. The only real addition is the `add_dependencies` call. I tried this without the

D10450: Generate a custom target in kcoreaddons_desktop_to_json

mpyne added a comment. Yes, I think I agree with @rakuco. Especially since the fix for D10485 ended up being reverted. I still think a separate fix is needed for kcm_lookandfeel, but the issue is that the `kcoreaddons_desktop_to_json` macro generates a

D10450: Generate a custom target in kcoreaddons_desktop_to_json

mpyne added a comment. So what's the conclusion here? Is this only a bug in kcm_lookandfeel or do we think that some follow-on changes are still required in `kcoreaddons_desktop_to_json`? REPOSITORY R244 KCoreAddons REVISION DETAIL https://phabricator.kde.org/D10450 To: tcberner,

Re: Closing old Plasma 4 bugs

k for myself but I'd be very much in favor or loosening restrictions on bug permissions to at least allow for community bug triaging. It's the kind of task that requires community involvement anyways (for testing in environments devs can't easily reproduce) and I think anything we do that gives the broader user community more 'ownership' into the bug database would lead to a more accurate and useful bug database. Regards, - Michael Pyne

Re: Adding application to KDE and getting image of current

h ecosystems expand (e.g. when wheels started JuK, AWS was still 5-6 years away), and usually your free time goes down as you get older, especially if you get a "significant other" or even children. Regards, - Michael Pyne

Re: Babe project - Legal feedback

/would/ be nice to be able to have 'virtual' parties with close friends without all having to be in the same room :), but getting there may be thorny. Regards, - Michael Pyne

Re: Quick and dirty packaging

ared Qt libs and then preferring them? CMAKE_MODULE_PATH (as an environment variable) should control where CMake looks for CMake config files, you may want to make sure that your /path/to/static/qt/lib/cmake is placed first in that environment variable. Other than that I'm not sure. Regards, - Michael Pyne

Re: Quick and dirty packaging

se however and so I'm not sure how easy it is to use, but something in that category seems like the best bet IMHO. Regards, - Michael Pyne

D9823: Optimize: use QMetaObject::invokeMethod with functor

mpyne accepted this revision. mpyne added a comment. LGTM REPOSITORY R244 KCoreAddons REVISION DETAIL https://phabricator.kde.org/D9823 To: mwolff, dfaure, apol, mpyne Cc: mpyne, #frameworks

D9334: Remove cmake 3.10+ warning for users of K_PLUGIN_FACTORY and K_PLUGIN_FACTORY_WITH_JSON

mpyne added a comment. In https://phabricator.kde.org/D9334#180881, @kossebau wrote: > In https://phabricator.kde.org/D9334#180830, @mpyne wrote: > > > In fact this appears to force files containing `K_PLUGIN_FACTORY*` into being evaluated by CMake's AUTOMOC (other warning fixes

D9334: Remove cmake 3.10+ warning for users of K_PLUGIN_FACTORY and K_PLUGIN_FACTORY_WITH_JSON

mpyne added a comment. In fact this appears to force files containing `K_PLUGIN_FACTORY*` into being evaluated by CMake's AUTOMOC (other warning fixes removed files from consideration by CMake AUTOMOC). CMake itself appears to have had an interface change for AUTOMOC between 3.8 and

D9277: Remove cmake warning about generating moc file

mpyne added a comment. @aacid you might be thinking of my KI18n fix for ui*.h files in https://phabricator.kde.org/D9118, but I'm sure there's other examples. I'll point out that Kevin looked at my patch as well and recommended something like `set_source_files_properties(${_header}

D9128: [knewstuff] Respect global variable

mpyne added a comment. OK, if no one else has objections I'd say to commit. REPOSITORY R304 KNewStuff REVISION DETAIL https://phabricator.kde.org/D9128 To: anthonyfieroni, leinir, dfaure, mpyne Cc: mpyne, #frameworks

D9128: [knewstuff] Respect global variable

mpyne accepted this revision. mpyne added a comment. This revision is now accepted and ready to land. I think the change looks good. But if the cache here is holding a *weak* pointer to a `Cache` then every user of this s_cache should be checking for null pointers each time, right? We can

D9118: ki18n cmake macros: Mark UIC-generated .h files to skip AUTOMOC by default

This revision was automatically updated to reflect the committed changes. Closed by commit R249:6e3b70843566: cmake: Mark UIC-generated .h files to skip AUTOMOC by default. (authored by mpyne). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D9118?vs=23312=23478#toc REPOSITORY R249

D9120: Fix a memory leak

mpyne added a comment. I think `~KuitStaticData()` *does* delete domainSetups. But deleting that QHash doesn't delete the underlying values. That means the real leak is at "Kuit::setupForDomain(QByteArray const&) (kuitmarkup.cpp:504)". If that's the case, then adding a destructor to

Re: kcrash, fork, and stdout/stderr

f it was responsible for the initial launch. Regards, - Michael Pyne

D9118: ki18n cmake macros: Mark UIC-generated .h files to skip AUTOMOC by default

mpyne added a comment. In https://phabricator.kde.org/D9118#174892, @aacid wrote: > Will this cause trouble with older cmake versions? Good question, I haven't tried it. I've verified that `set_property` at least is present in 2.8.12

D9118: ki18n cmake macros: Mark UIC-generated .h files to skip AUTOMOC by default

mpyne created this revision. mpyne added reviewers: Frameworks, Build System, Localization. Restricted Application added a project: Frameworks. REVISION SUMMARY CMake in 3.10.0 has started warning that `.h` files which are automatically generated have historically been left out of AUTOMOC, and

D8256: Add _XOPEN_SOURCE to C definitions

mpyne added a comment. As I mentioned on the KDE bug, there is a possibility that changes like this would break FreeBSD. FreeBSD operates by a model of exporting symbols by default for legacy/BSD-specific needs. However if a feature flag is set, it limits its exports to *only* that

Re: kdesrc-build setup for building qt5 before plasma

e made in the "global" section of the kdesrc-buildrc for it to work, details are described at the top of the attached file. Regards, - Michael Pyne # For this all to work, you also need to add the following line # to the global section of your kdesrc-buildrc, and make sure to # uncomment it

D8992: Warn about errors when parsing json files

mpyne accepted this revision. This revision is now accepted and ready to land. REPOSITORY R244 KCoreAddons BRANCH master REVISION DETAIL https://phabricator.kde.org/D8992 To: apol, #frameworks, mpyne

D8871: Don't look for /etc/kderc every single time

mpyne accepted this revision. mpyne added a comment. This revision is now accepted and ready to land. +1 REPOSITORY R237 KConfig BRANCH master REVISION DETAIL https://phabricator.kde.org/D8871 To: apol, #frameworks, mpyne Cc: mpyne

Re: Adding build info attribute to KAboutData to improve bug report data?

like "setBugReportDetail" (since this is intended to support improved bug reports) or "setSourceRevision" (which describes what we're actually capturing). Just my thoughts, happy to support it going in however makes the mose sense. Regards, - Michael Pyne

Re: Building Qt with kdesrc-build

efore any KDE-based modules, and you'll want to make sure your qtdir setting points to where you want kdesrc-build to install Qt5 to. Regards, - Michael Pyne # For this all to work, you also need to add the following line # to the global section of your kdesrc-buildrc, and make sure to # uncomment it

D8207: Use https for KDE urls

mpyne added a comment. I support the idea, but I think there's a few more spots where we can convert http:// to https://. I ran `ag --only-matching --no-heading 'http:.*k.*\.org'` in the kcoreaddons source directory, with the current version of this patch already applied, and got the

D8002: Improve DesktopFileParser heuristic for finding old-style service desktop entries

This revision was automatically updated to reflect the committed changes. Closed by commit R244:4bdc7bb199ec: desktoptojson: Improve legacy service type detection heuristic. (authored by mpyne). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D8002?vs=19963=20361#toc REPOSITORY R244

D8002: Improve DesktopFileParser heuristic for finding old-style service desktop entries

mpyne added inline comments. INLINE COMMENTS > graesslin wrote in desktopfileparser.cpp:547 > Be careful with for and qt containers. This causes a detach. Either use the > old variant or wrap the list in qAsConst ( which is new in 5.7) OK. I think we settled on Qt 5.6 for now at the request

D8002: Improve DesktopFileParser heuristic for finding old-style service desktop entries

mpyne added a comment. Any objections? If not I'll try to commit in the next few days. REPOSITORY R244 KCoreAddons REVISION DETAIL https://phabricator.kde.org/D8002 To: mpyne, #frameworks

D8002: Improve DesktopFileParser heuristic for finding old-style service desktop entries

mpyne created this revision. mpyne added a reviewer: Frameworks. Restricted Application added a project: Frameworks. REVISION SUMMARY When we adopted JSON plugin metadata for services, we also included compatibility code so that we could continue to load the older Desktop Entry format for KDE

Re: Repositories to be dropped for KDE Applications 17.12 since they still use kdelibs4

ot completely crazy it could serve as a good base. I had already given up on the hard slow of a port and started a rewrite but if KapiX's work gets us closer I will get something in releaseable shape in time for 17.12. Regards, - Michael Pyne

D7281: KCoreAddons: Enforce hidden symbol visibility in nested private classes

mpyne added a comment. In https://phabricator.kde.org/D7281#135053, @kossebau wrote: > @mpyne: Beware, I have such patches prepared for all of KF :) OK, I'll hold off on this one pending your KF5-wide patchset ;) REPOSITORY R244 KCoreAddons REVISION DETAIL

  1   2   3   4   5   6   >