Re: Review Request 129397: Set environment variables from KLaunchRequest when starting new process

[Jan Grulich]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129397/
---

(Updated Lis. 16, 2016, 7:32 dop.)


Review request for KDE Frameworks, David Edmundson and David Faure.


Changes
---

Use QString::mid() instead of QString::right().


Repository: kinit


Description
---

One more patch in the series adding support for launching apps on a discrete 
gpu. When using KToolInvocation to start an app we call klauncher for which we 
need to set required env variables which needs to be set to actually run the 
app on the discrete gpu.


Diffs (updated)
-

  src/klauncher/klauncher.cpp 828038b 

Diff: https://git.reviewboard.kde.org/r/129397/diff/


Testing
---


Thanks,

Jan Grulich

Re: Review Request 129277: Use built-in QByteArrayList type instead of our own.

[Gleb Popov]

> On Nov. 16, 2016, 2:37 a.m., Christoph Feck wrote:
> > Any hope that this could have fixed the cause for bug 345871?

Can't comment on that, since I've been developing on FreeBSD, and our UDisks2 
implementation doesn't handle partitions properly yet.


- Gleb


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129277/#review100864
---


On Oct. 31, 2016, 1:49 p.m., Gleb Popov wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129277/
> ---
> 
> (Updated Oct. 31, 2016, 1:49 p.m.)
> 
> 
> Review request for Solid.
> 
> 
> Repository: solid
> 
> 
> Description
> ---
> 
> This patch replaces uses of `typedef QList ByteArrayList;` with 
> built-in `QByteArrayList` type. This type was in Qt since 5.4, while Solid 
> requires 5.5.
> 
> 
> Diffs
> -
> 
>   src/solid/devices/backends/udisks2/udisks2.h 0abf915 
>   src/solid/devices/backends/udisks2/udisksdevice.cpp 5283c2a 
>   src/solid/devices/backends/udisks2/udisksmanager.cpp 1e149c2 
>   src/solid/devices/backends/udisks2/udisksstorageaccess.cpp 1bd6acf 
> 
> Diff: https://git.reviewboard.kde.org/r/129277/diff/
> 
> 
> Testing
> ---
> 
> Compiles, mounting works.
> 
> 
> Thanks,
> 
> Gleb Popov
> 
>

Re: Review Request 129277: Use built-in QByteArrayList type instead of our own.

[Christoph Feck]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129277/#review100864
---



Any hope that this could have fixed the cause for bug 345871?

- Christoph Feck


On Oct. 31, 2016, 11:49 a.m., Gleb Popov wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129277/
> ---
> 
> (Updated Oct. 31, 2016, 11:49 a.m.)
> 
> 
> Review request for Solid.
> 
> 
> Repository: solid
> 
> 
> Description
> ---
> 
> This patch replaces uses of `typedef QList ByteArrayList;` with 
> built-in `QByteArrayList` type. This type was in Qt since 5.4, while Solid 
> requires 5.5.
> 
> 
> Diffs
> -
> 
>   src/solid/devices/backends/udisks2/udisks2.h 0abf915 
>   src/solid/devices/backends/udisks2/udisksdevice.cpp 5283c2a 
>   src/solid/devices/backends/udisks2/udisksmanager.cpp 1e149c2 
>   src/solid/devices/backends/udisks2/udisksstorageaccess.cpp 1bd6acf 
> 
> Diff: https://git.reviewboard.kde.org/r/129277/diff/
> 
> 
> Testing
> ---
> 
> Compiles, mounting works.
> 
> 
> Thanks,
> 
> Gleb Popov
> 
>

Re: Review Request 129341: [kwallet] boost::shared_ptr -> std::shared_ptr

[Andreas Sturmlechner]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129341/
---

(Updated Nov. 15, 2016, 8:54 p.m.)


Review request for KDE Frameworks.


Changes
---

HAVE_QGPGME -> HAVE_GPGMEPP


Repository: kwallet


Description (updated)
---

Dropping implicit boost usage.
Also, rename HAVE_QGPGME to HAVE_GPGMEPP.


Diffs (updated)
-

  src/runtime/kwalletd/CMakeLists.txt 5092a7e77a1ca7203827e444c11310566b2cc8b5 
  src/runtime/kwalletd/backend/CMakeLists.txt 
2f99bc3cca89dd7a194f46cb314d2f7f90f931f3 
  src/runtime/kwalletd/backend/backendpersisthandler.h 
a6682353d62fd63e88a0de6277801c624c794c74 
  src/runtime/kwalletd/backend/backendpersisthandler.cpp 
413d4cd23ef1e15b75cd366061f07f179241af58 
  src/runtime/kwalletd/backend/kwalletbackend.h 
4811a58e942685b01ed097ef15c2838e3833865c 
  src/runtime/kwalletd/backend/kwalletbackend.cc 
43f30a545d36b64b102c794de3625621a694983e 
  src/runtime/kwalletd/knewwalletdialog.h 
ea71fbc7d59fdd05da7ce395e371dd7fdf91e49d 
  src/runtime/kwalletd/knewwalletdialog.cpp 
0d9ffb8ed469536cee9d4055ac0bd001fff115a0 
  src/runtime/kwalletd/kwalletd.cpp ca7d4ffbdff4178878b3c705921ef2b1970e0dbd 
  src/runtime/kwalletd/kwalletwizard.h 4cf8de424af800716e7c779d6d419eae4b54e426 
  src/runtime/kwalletd/kwalletwizard.cpp 
cd52e54a668554fc0e14f4ad4cb29ba6f27fd330 

Diff: https://git.reviewboard.kde.org/r/129341/diff/


Testing
---


Thanks,

Andreas Sturmlechner

Re: KDE Frameworks 5.28.0 released

[Dominik Haumann]

On Tue, Nov 15, 2016 at 2:37 PM, David Faure  wrote:
> 15th November 2016. KDE today announces the release of KDE Frameworks 5.28.0.
>
> KDE Frameworks are 70 addon libraries to Qt which provide a wide variety of·
> commonly needed functionality in mature, peer reviewed and well tested·
> libraries with friendly licensing terms. For an introduction see the·
> Frameworks 5.0 release announcement.
>
> New framework: syntax-highlighting
> Syntax highlighting engine for Kate syntax definitions
>
> This is a stand-alone implementation of the Kate syntax highlighting engine.
> It's meant as a building block for text editors as well as for simple
> highlighted text rendering (e.g. as HTML), supporting both integration with a
> custom editor as well as a ready-to-use QSyntaxHighlighter sub-class.

Nitpick: The announcement [1] is missing this paragraph :-)

[1] https://www.kde.org/announcements/kde-frameworks-5.28.0.php

Besides that, good work everyone and thanks for the release & packaging work!

Greetings
Dominik

Re: KDE Frameworks 5.28.0 released

[Dominik Haumann]

On Tue, Nov 15, 2016 at 2:37 PM, David Faure  wrote:
> 15th November 2016. KDE today announces the release of KDE Frameworks 5.28.0.
>
> KDE Frameworks are 70 addon libraries to Qt which provide a wide variety of·
> commonly needed functionality in mature, peer reviewed and well tested·
> libraries with friendly licensing terms. For an introduction see the·
> Frameworks 5.0 release announcement.
>
> New framework: syntax-highlighting
> Syntax highlighting engine for Kate syntax definitions
>
> This is a stand-alone implementation of the Kate syntax highlighting engine.
> It's meant as a building block for text editors as well as for simple
> highlighted text rendering (e.g. as HTML), supporting both integration with a
> custom editor as well as a ready-to-use QSyntaxHighlighter sub-class.

Nitpick: The announcement [1] is missing this paragraph :-)

[1] https://www.kde.org/announcements/kde-frameworks-5.28.0.php

Besides that, good work everyone and thanks for the release & packaging work!

Greetings
Dominik

Re: Review Request 129379: [baloo] Remove unused functions

[Christian Ehrlicher]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129379/
---

(Updated Nov. 15, 2016, 7:58 p.m.)


Status
--

This change has been marked as submitted.


Review request for Baloo and David Faure.


Changes
---

Submitted with commit e40689fb56fbcd12ca4eeaef1b44e93f5afc6d7d by Christian 
Ehrlicher to branch master.


Repository: baloo


Description
---

As discussed in REVIEW 129186 there is a lot of bit rotting in coding.cpp/.h. 
With this patch I removed all the unused stuff and moved out a temporary buffer 
to avoid reallocating this buffer on every call to putDifferentialVarInt32()


Diffs
-

  src/codecs/coding.h 3d55a40 
  src/codecs/coding.cpp 73e2fa2 
  src/codecs/positioncodec.cpp 22f4895 

Diff: https://git.reviewboard.kde.org/r/129379/diff/


Testing
---

Unittests still working as expected


Thanks,

Christian Ehrlicher

Re: KDE/Qt Flatpak SDK/Runtime

[Brüns , Stefan]

On Dienstag, 15. November 2016 18:00:34 CET Aleix Pol wrote:
> On Tue, Nov 15, 2016 at 1:16 PM, Matthias Kuhn  wrote:
> 
> I would like to see how much pyqt increases the size of the (not yet
> optimized) runtime. I agree it can be interesting, but I'm not sure by
> how much.
> Also the fact that there's so many approaches for python Qt bindings
> doesn't make things much simpler, and that's python alone. Does that
> mean we want to have all languages in there? I'll be happy to work
> with anyone who wants to get PyQt in their application, if we see that
> we're getting so much projects that need PyQt that it makes sense,
> then by all means it should go in.
> 
> Having different run-times for applications that use KDE Frameworks
> and applications that don't feels like shooting ourselves in the foot,
> at this moment. Note that in Flatpak runtimes don't extend each other,
> they duplicate, AFAIK.

If I understand http://flatpak.org/developer.html correctly:
- optional/add-on parts can be referenced using Extensions
- you may use several extensions from application and/or runtime

Also runtimes seem to stack, see e.g. 
https://git.gnome.org/browse/gnome-sdk-images/tree/org.gnome.Sdk.json.in

As far as I understand the OSTree repository format, even distinct runtimes 
which have overlapping content will not duplicate storage or download 
requirements, as OSTree is a content-addressed storage, although I may be 
wrong here.

Kind regards,

Stefan

Re: Dropping kdelibs4-based applications in KDE Applications 17.12

[Albert Astals Cid]

El dimarts, 15 de novembre de 2016, a les 19:53:43 CET, Ben Cooksley va 
escriure:
> On Tue, Nov 15, 2016 at 11:27 AM, Albert Astals Cid  wrote:
> > El divendres, 11 de novembre de 2016, a les 18:24:42 CET, Christoph Feck
> > va
> > 
> > escriure:
> >> On 11.11.2016 16:45, Dominik Haumann wrote:
> >> > On Thu, Nov 10, 2016 at 11:42 PM, Albert Astals Cid  
wrote:
> >> >> Hi, my proposal would be to make KDE Applications 17.08 the last
> >> >> release
> >> >> we
> >> >> accept applications based on kdelibs4, that means people have a year
> >> >> until KDE Applications 17.12 to port the applications from the list
> >> >> below to KF5.
> >> >> 
> >> >> The ones that aren't ported we would just drop to unmaintained or if
> >> >> they
> >> >> have an active developer team that somehow doesn't want to move to KF5
> >> >> they could move to "extreagear".
> >> 
> >> Will we still release the KDE4 platform for not-yet-ported extragear
> >> applications (Amarok etc.) with 17.12?
> >> 
> >> If we stop releasing it, then we should also move all unported
> >> applications to 'unmaintained'. Any developer willing to port can
> >> surrect it from there.
> > 
> > I personally think that's a bit extreme tbh, if a group of developers are
> > stubbornly fixated in developing for kdelibs4 and not KF5 I don't see why
> > we should not let them do the releases if they want to.
> > 
> > But this seems a bit hypothetical, I *hope* any actively maintained
> > "extregear" app will be KF5-based in a year :)
> 
> From my perspective, i'd like to drop CI support for Qt 4 based code
> as soon as possible. Keeping it alive requires a whole additional set
> of jobs and associated infrastructure, for something which receives
> little development attention (comparatively).
> 
> Chances are we'll have to keep this support alive until Applications
> 17.08 is released, at which point I think we should drop it
> completely, even if Extragear projects continue to use KDE 4 / Qt 4
> based sources.

Fair (unless someone from those KDE 4/Qt 4 projects steps up to provide the 
womanpower/hardwarepower/anypower needed to keep CI for those running).

Cheers,
  Albert

> 
> > Cheers,
> > 
> >   Albert
> 
> Regards,
> Ben

Re: Dropping kdelibs4-based applications in KDE Applications 17.12

[Albert Astals Cid]

El dimarts, 15 de novembre de 2016, a les 19:53:43 CET, Ben Cooksley va 
escriure:
> On Tue, Nov 15, 2016 at 11:27 AM, Albert Astals Cid  wrote:
> > El divendres, 11 de novembre de 2016, a les 18:24:42 CET, Christoph Feck
> > va
> > 
> > escriure:
> >> On 11.11.2016 16:45, Dominik Haumann wrote:
> >> > On Thu, Nov 10, 2016 at 11:42 PM, Albert Astals Cid  
wrote:
> >> >> Hi, my proposal would be to make KDE Applications 17.08 the last
> >> >> release
> >> >> we
> >> >> accept applications based on kdelibs4, that means people have a year
> >> >> until KDE Applications 17.12 to port the applications from the list
> >> >> below to KF5.
> >> >> 
> >> >> The ones that aren't ported we would just drop to unmaintained or if
> >> >> they
> >> >> have an active developer team that somehow doesn't want to move to KF5
> >> >> they could move to "extreagear".
> >> 
> >> Will we still release the KDE4 platform for not-yet-ported extragear
> >> applications (Amarok etc.) with 17.12?
> >> 
> >> If we stop releasing it, then we should also move all unported
> >> applications to 'unmaintained'. Any developer willing to port can
> >> surrect it from there.
> > 
> > I personally think that's a bit extreme tbh, if a group of developers are
> > stubbornly fixated in developing for kdelibs4 and not KF5 I don't see why
> > we should not let them do the releases if they want to.
> > 
> > But this seems a bit hypothetical, I *hope* any actively maintained
> > "extregear" app will be KF5-based in a year :)
> 
> From my perspective, i'd like to drop CI support for Qt 4 based code
> as soon as possible. Keeping it alive requires a whole additional set
> of jobs and associated infrastructure, for something which receives
> little development attention (comparatively).
> 
> Chances are we'll have to keep this support alive until Applications
> 17.08 is released, at which point I think we should drop it
> completely, even if Extragear projects continue to use KDE 4 / Qt 4
> based sources.

Fair (unless someone from those KDE 4/Qt 4 projects steps up to provide the 
womanpower/hardwarepower/anypower needed to keep CI for those running).

Cheers,
  Albert

> 
> > Cheers,
> > 
> >   Albert
> 
> Regards,
> Ben

Re: KDE/Qt Flatpak SDK/Runtime

[Aleix Pol]

On Tue, Nov 15, 2016 at 1:16 PM, Matthias Kuhn  wrote:
> Hi Aleix,
>
> Thanks for the quick feedback
>
> On 11/15/2016 12:44 AM, Aleix Pol wrote:
>> Hi Matthias,
>> Really happy to see there's interest!
>>
>> On Mon, Nov 14, 2016 at 12:44 PM, Matthias Kuhn  wrote:
>>> Hi,
>>>
>>> I'm a developer of QGIS [1] which makes heavy use of Qt libraries. I was
>>> very happy to see the work on a KDE flatpak repository which already
>>> packages Qt [2].
>>>
>>> I have recently been looking into a couple of different approaches to
>>> ship app bundles and flatpak sounds like a very interesting one.
>>>
>>> To not duplicate work I would like to ask if there is interest for a
>>> collaboration. In particular, for our needs:
>>>
>>>  * We require the QtLocation module. Are there plans for adding this?
>>>I will be happy to share a trivial patch that adds this.
>> In general I'd say that this possibly should be part of the
>> application, now Qt's cmake scripts have a limitation where they all
>> need to be in the same prefix. Because of how Flatpak is put together,
>> this means it needs to be in the runtime, if you have a patch please
>> send it my way.
> Cool, happy to do so as soon as I'm back on my desktop (it's actually a
> simple copy-paste of the other recipes, replacing the Qt module with
> QtLocation).
>
>>
>>>  * We also require other components which are closely related to Qt:
>>>Qt Cryptographic Architecture (QCA), QWT, QScintilla, PyQt5, would
>>>you be interested in integrating them into this repository as well?
>> Few applications need this, I would recommend to get these into the
>> application. I know it feels a bit arbitrary, but I wouldn't want to
>> get all the dependencies in there, since we'd also lose the grip on
>> what we're offering as well.
>>
>> At the moment what we're putting is Qt, KDE Frameworks and few bits to
>> integrate visually with Plasma.
>> I guess that there's few additional things that could be included, I
>> also see value in 3rd parties using our runtime, but I don't really
>> want the runtime to grow beyond usefulness. (I don't know about many
>> KDE applications using QWT or QScintilla).
>
> I don't mind too much about QWT or QScintilla, but I think there's quite
> a few applications that could be interested in shipping with PyQt as
> dependency.
>
> As I wrote before, one other possibility would be to split up the
> current KDE runtime into a Qt runtime and a KDE runtime.
> On top of the Qt runtime you could build all the common KDE libraries
> with bells and whistles (which we don't require on our side) and we
> could put our extra libraries into a QtExtras runtime so there's no
> reason to ship them along with your runtime.
>
> Do you think that would make maintenance more complicated than necessary
> or do you expect other bad side-effects?

I would like to see how much pyqt increases the size of the (not yet
optimized) runtime. I agree it can be interesting, but I'm not sure by
how much.
Also the fact that there's so many approaches for python Qt bindings
doesn't make things much simpler, and that's python alone. Does that
mean we want to have all languages in there? I'll be happy to work
with anyone who wants to get PyQt in their application, if we see that
we're getting so much projects that need PyQt that it makes sense,
then by all means it should go in.

Having different run-times for applications that use KDE Frameworks
and applications that don't feels like shooting ourselves in the foot,
at this moment. Note that in Flatpak runtimes don't extend each other,
they duplicate, AFAIK.

Aleix

Re: Review Request 129394: [filenamesearch] Fix huge ram usage in kded module

[David Faure]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129394/#review100862
---



This fix makes sense to me (well, I suggested it) ;)

As to why it doesn't work, that requires more info about how filenamesearch 
URLs are actually being used. Is this documented somewhere, or does it require 
testing and debugging?

- David Faure


On Nov. 14, 2016, 11:44 a.m., Anthony Fieroni wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129394/
> ---
> 
> Review request for KDE Frameworks, Anthony Fieroni, David Faure, and Emmanuel 
> Pescosta.
> 
> 
> Repository: kio-extras
> 
> 
> Description
> ---
> 
> Bug is introduced in https://git.reviewboard.kde.org/r/129297/
> When is fixed new kio-extras realease is needed for 16.08 branch.
> 
> 
> Diffs
> -
> 
>   filenamesearch/kded/filenamesearchmodule.cpp 3f9f582 
> 
> Diff: https://git.reviewboard.kde.org/r/129394/diff/
> 
> 
> Testing
> ---
> 
> No big ram usage but still not works as expected.
> 1. Perform search in Dolphin
> 2. Delete one result item
> 3. View must be update, but it's not
> 
> 
> Thanks,
> 
> Anthony Fieroni
> 
>

Jenkins-kde-ci: kwindowsystem master kf5-qt5 » Linux,All,gcc - Build # 88 - Fixed!

[no-reply]

GENERAL INFO

BUILD SUCCESS
Build URL: 
https://build.kde.org/job/kwindowsystem%20master%20kf5-qt5/PLATFORM=Linux,Variation=All,compiler=gcc/88/
Project: PLATFORM=Linux,Variation=All,compiler=gcc
Date of build: Tue, 15 Nov 2016 16:31:20 +
Build duration: 1 min 47 sec

CHANGE SET
Revision 0e1bdd767dd798e275e6e8c07785859bb8dfd3f1 by kde: (Remove accidentally 
added virtual method)
  change: edit src/kwindowinfo_dummy_p.h
  change: edit src/kwindowinfo_p.h
  change: edit src/kwindowinfo.cpp


JUNIT RESULTS

Name: (root) Failed: 0 test(s), Passed: 13 test(s), Skipped: 0 test(s), Total: 
13 test(s)

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 4/5 (80%)FILES 44/50 (88%)CLASSES 44/50 (88%)LINE 6806/9081 
(75%)CONDITIONAL 3796/7069 (54%)

By packages
  
autotests
FILES 15/15 (100%)CLASSES 15/15 (100%)LINE 2940/3011 
(98%)CONDITIONAL 1616/3115 (52%)
autotests.helper
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 7/10 (70%)CONDITIONAL 
3/6 (50%)
src
FILES 14/16 (88%)CLASSES 14/16 (88%)LINE 778/1434 
(54%)CONDITIONAL 317/710 (45%)
src.platforms.wayland
FILES 0/2 (0%)CLASSES 0/2 (0%)LINE 0/89 (0%)CONDITIONAL 0/2 (0%)
src.platforms.xcb
FILES 14/16 (88%)CLASSES 14/16 (88%)LINE 3081/4537 
(68%)CONDITIONAL 1860/3236 (57%)

Jenkins-kde-ci: kwindowsystem master kf5-qt5 » Linux,All,gcc - Build # 88 - Fixed!

[no-reply]

GENERAL INFO

BUILD SUCCESS
Build URL: 
https://build.kde.org/job/kwindowsystem%20master%20kf5-qt5/PLATFORM=Linux,Variation=All,compiler=gcc/88/
Project: PLATFORM=Linux,Variation=All,compiler=gcc
Date of build: Tue, 15 Nov 2016 16:31:20 +
Build duration: 1 min 47 sec

CHANGE SET
Revision 0e1bdd767dd798e275e6e8c07785859bb8dfd3f1 by kde: (Remove accidentally 
added virtual method)
  change: edit src/kwindowinfo_dummy_p.h
  change: edit src/kwindowinfo_p.h
  change: edit src/kwindowinfo.cpp


JUNIT RESULTS

Name: (root) Failed: 0 test(s), Passed: 13 test(s), Skipped: 0 test(s), Total: 
13 test(s)

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 4/5 (80%)FILES 44/50 (88%)CLASSES 44/50 (88%)LINE 6806/9081 
(75%)CONDITIONAL 3796/7069 (54%)

By packages
  
autotests
FILES 15/15 (100%)CLASSES 15/15 (100%)LINE 2940/3011 
(98%)CONDITIONAL 1616/3115 (52%)
autotests.helper
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 7/10 (70%)CONDITIONAL 
3/6 (50%)
src
FILES 14/16 (88%)CLASSES 14/16 (88%)LINE 778/1434 
(54%)CONDITIONAL 317/710 (45%)
src.platforms.wayland
FILES 0/2 (0%)CLASSES 0/2 (0%)LINE 0/89 (0%)CONDITIONAL 0/2 (0%)
src.platforms.xcb
FILES 14/16 (88%)CLASSES 14/16 (88%)LINE 3081/4537 
(68%)CONDITIONAL 1860/3236 (57%)

Re: Review Request 129405: KCollapsibleGroupBox: don't hide widgets, override focus policy instead

[Elvis Angelaccio]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129405/
---

(Updated Nov. 15, 2016, 4:27 p.m.)


Status
--

This change has been marked as submitted.


Review request for KDE Frameworks, KDE Usability, Christoph Feck, and David 
Edmundson.


Changes
---

Submitted with commit 1076908c344674d2be4f4825f18f6f3900a09620 by Elvis 
Angelaccio to branch master.


Repository: kwidgetsaddons


Description
---

Currently it's not possible to hide widgets in a KCollapsibleGroupBox, because 
the groupbox hides all chidren on collapse event and shows them on expand event.

The rationale was explained in this comment: "when collapsed hide contents to 
save resources and more importantly get it out the focus chain"

The focus chain problem can be solved by overriding/restoring the focus policy 
of children widgets, without changing their visibility.


Diffs
-

  autotests/kcollapsiblegroupbox_test.h 
b7f538217f480ea48bc28f098c7968fe21dda676 
  autotests/kcollapsiblegroupbox_test.cpp 
4c458c4f700e498c178a637c29d6cc78ab8c267c 
  src/kcollapsiblegroupbox.cpp 273110e995cb25f28a815cb28125c4678ca2ab28 
  tests/kcollapsiblegroupboxtest.cpp 5a2900e63e42fa81f909c7d1fff0d07033edb025 

Diff: https://git.reviewboard.kde.org/r/129405/diff/


Testing
---

Test app has been expanded with an hidden checkbox

* Make sure the new checkbox stays hidden after expanding the groupbox.
* With both groups collapsed, make sure the tab-focus goes from the first group 
to the second one (skipping the 7 checkboxes in the first group).


File Attachments


Before: hidden checkbox is visible
  
https://git.reviewboard.kde.org/media/uploaded/files/2016/11/15/25c50bd2-aa00-42ea-b9b5-38f3d1abddff__Spectacle.d20127.png
After: hidden checkbox is hidden
  
https://git.reviewboard.kde.org/media/uploaded/files/2016/11/15/815551e3-9987-4851-8025-50d44989f600__Spectacle.W20858.png


Thanks,

Elvis Angelaccio

Re: Review Request 129397: Set environment variables from KLaunchRequest when starting new process

[David Faure]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129397/#review100861
---




src/klauncher/klauncher.cpp (line 558)


I suggested mid(pos+1), which is much simpler than right(length - pos - 1).

Also, don't call indexOf() twice, put it in a local variable.


- David Faure


On Nov. 15, 2016, 7:57 a.m., Jan Grulich wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129397/
> ---
> 
> (Updated Nov. 15, 2016, 7:57 a.m.)
> 
> 
> Review request for KDE Frameworks, David Edmundson and David Faure.
> 
> 
> Repository: kinit
> 
> 
> Description
> ---
> 
> One more patch in the series adding support for launching apps on a discrete 
> gpu. When using KToolInvocation to start an app we call klauncher for which 
> we need to set required env variables which needs to be set to actually run 
> the app on the discrete gpu.
> 
> 
> Diffs
> -
> 
>   src/klauncher/klauncher.cpp 828038b 
> 
> Diff: https://git.reviewboard.kde.org/r/129397/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Jan Grulich
> 
>

Jenkins-kde-ci: khtml master kf5-qt5 » Linux,gcc - Build # 118 - Fixed!

[no-reply]

GENERAL INFO

BUILD SUCCESS
Build URL: 
https://build.kde.org/job/khtml%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/118/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Tue, 15 Nov 2016 15:16:13 +
Build duration: 21 min

CHANGE SET
No changes


JUNIT RESULTS

Name: (root) Failed: 0 test(s), Passed: 3 test(s), Skipped: 0 test(s), Total: 3 
test(s)

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 19/23 (83%)FILES 308/626 (49%)CLASSES 308/626 (49%)LINE 3032/94748 
(3%)CONDITIONAL 2832/151320 (2%)

By packages
  
default>
FILES 2/8 (25%)CLASSES 2/8 (25%)LINE 2/592 (0%)CONDITIONAL 
4/681 (1%)
autotests
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 53/57 (93%)CONDITIONAL 
27/56 (48%)
src
FILES 20/31 (65%)CLASSES 20/31 (65%)LINE 931/8839 
(11%)CONDITIONAL 811/18510 (4%)
src.css
FILES 12/25 (48%)CLASSES 12/25 (48%)LINE 32/9368 
(0%)CONDITIONAL 32/15687 (0%)
src.dom
FILES 29/40 (73%)CLASSES 29/40 (73%)LINE 61/7091 
(1%)CONDITIONAL 66/4876 (1%)
src.ecma
FILES 24/50 (48%)CLASSES 24/50 (48%)LINE 27/8351 
(0%)CONDITIONAL 47/19677 (0%)
src.editing
FILES 5/7 (71%)CLASSES 5/7 (71%)LINE 20/2100 (1%)CONDITIONAL 
11/4033 (0%)
src.html
FILES 21/47 (45%)CLASSES 21/47 (45%)LINE 21/10643 
(0%)CONDITIONAL 42/15981 (0%)
src.imload
FILES 4/31 (13%)CLASSES 4/31 (13%)LINE 24/854 (3%)CONDITIONAL 
14/641 (2%)
src.imload.decoders
FILES 8/8 (100%)CLASSES 8/8 (100%)LINE 19/616 (3%)CONDITIONAL 
10/684 (1%)
src.misc
FILES 13/27 (48%)CLASSES 13/27 (48%)LINE 837/3716 
(23%)CONDITIONAL 707/5250 (13%)
src.platform
FILES 0/1 (0%)CLASSES 0/1 (0%)LINE 0/2 (0%)CONDITIONAL 0/0 
(100%)
src.platform.graphics
FILES 0/16 (0%)CLASSES 0/16 (0%)LINE 0/534 (0%)CONDITIONAL 
0/308 (0%)
src.platform.graphics.qt
FILES 0/7 (0%)CLASSES 0/7 (0%)LINE 0/248 (0%)CONDITIONAL 0/172 
(0%)
src.platform.text
FILES 0/1 (0%)CLASSES 0/1 (0%)LINE 0/7 (0%)CONDITIONAL 0/4 (0%)
src.rendering
FILES 48/97 (49%)CLASSES 48/97 (49%)LINE 64/23896 
(0%)CONDITIONAL 95/32659 (0%)
src.svg
FILES 72/147 (49%)CLASSES 72/147 (49%)LINE 746/5897 
(13%)CONDITIONAL 816/14527 (6%)
src.svg.graphics
FILES 7/14 (50%)CLASSES 7/14 (50%)LINE 7/283 (2%)CONDITIONAL 
14/342 (4%)
src.svg.graphics.qt
FILES 6/6 (100%)CLASSES 6/6 (100%)LINE 6/156 (4%)CONDITIONAL 
12/319 (4%)
src.ui.findbar
FILES 2/4 (50%)CLASSES 2/4 (50%)LINE 21/505 (4%)CONDITIONAL 
8/908 (1%)
src.ui.passwordbar
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 28/60 (47%)CONDITIONAL 
39/106 (37%)
src.xml
FILES 20/38 (53%)CLASSES 20/38 (53%)LINE 116/9560 
(1%)CONDITIONAL 59/13175 (0%)
src.xpath
FILES 9/15 (60%)CLASSES 9/15 (60%)LINE 17/1373 (1%)CONDITIONAL 
18/2724 (1%)

Jenkins-kde-ci: khtml master kf5-qt5 » Linux,gcc - Build # 118 - Fixed!

[no-reply]

GENERAL INFO

BUILD SUCCESS
Build URL: 
https://build.kde.org/job/khtml%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/118/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Tue, 15 Nov 2016 15:16:13 +
Build duration: 21 min

CHANGE SET
No changes


JUNIT RESULTS

Name: (root) Failed: 0 test(s), Passed: 3 test(s), Skipped: 0 test(s), Total: 3 
test(s)

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 19/23 (83%)FILES 308/626 (49%)CLASSES 308/626 (49%)LINE 3032/94748 
(3%)CONDITIONAL 2832/151320 (2%)

By packages
  
default>
FILES 2/8 (25%)CLASSES 2/8 (25%)LINE 2/592 (0%)CONDITIONAL 
4/681 (1%)
autotests
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 53/57 (93%)CONDITIONAL 
27/56 (48%)
src
FILES 20/31 (65%)CLASSES 20/31 (65%)LINE 931/8839 
(11%)CONDITIONAL 811/18510 (4%)
src.css
FILES 12/25 (48%)CLASSES 12/25 (48%)LINE 32/9368 
(0%)CONDITIONAL 32/15687 (0%)
src.dom
FILES 29/40 (73%)CLASSES 29/40 (73%)LINE 61/7091 
(1%)CONDITIONAL 66/4876 (1%)
src.ecma
FILES 24/50 (48%)CLASSES 24/50 (48%)LINE 27/8351 
(0%)CONDITIONAL 47/19677 (0%)
src.editing
FILES 5/7 (71%)CLASSES 5/7 (71%)LINE 20/2100 (1%)CONDITIONAL 
11/4033 (0%)
src.html
FILES 21/47 (45%)CLASSES 21/47 (45%)LINE 21/10643 
(0%)CONDITIONAL 42/15981 (0%)
src.imload
FILES 4/31 (13%)CLASSES 4/31 (13%)LINE 24/854 (3%)CONDITIONAL 
14/641 (2%)
src.imload.decoders
FILES 8/8 (100%)CLASSES 8/8 (100%)LINE 19/616 (3%)CONDITIONAL 
10/684 (1%)
src.misc
FILES 13/27 (48%)CLASSES 13/27 (48%)LINE 837/3716 
(23%)CONDITIONAL 707/5250 (13%)
src.platform
FILES 0/1 (0%)CLASSES 0/1 (0%)LINE 0/2 (0%)CONDITIONAL 0/0 
(100%)
src.platform.graphics
FILES 0/16 (0%)CLASSES 0/16 (0%)LINE 0/534 (0%)CONDITIONAL 
0/308 (0%)
src.platform.graphics.qt
FILES 0/7 (0%)CLASSES 0/7 (0%)LINE 0/248 (0%)CONDITIONAL 0/172 
(0%)
src.platform.text
FILES 0/1 (0%)CLASSES 0/1 (0%)LINE 0/7 (0%)CONDITIONAL 0/4 (0%)
src.rendering
FILES 48/97 (49%)CLASSES 48/97 (49%)LINE 64/23896 
(0%)CONDITIONAL 95/32659 (0%)
src.svg
FILES 72/147 (49%)CLASSES 72/147 (49%)LINE 746/5897 
(13%)CONDITIONAL 816/14527 (6%)
src.svg.graphics
FILES 7/14 (50%)CLASSES 7/14 (50%)LINE 7/283 (2%)CONDITIONAL 
14/342 (4%)
src.svg.graphics.qt
FILES 6/6 (100%)CLASSES 6/6 (100%)LINE 6/156 (4%)CONDITIONAL 
12/319 (4%)
src.ui.findbar
FILES 2/4 (50%)CLASSES 2/4 (50%)LINE 21/505 (4%)CONDITIONAL 
8/908 (1%)
src.ui.passwordbar
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 28/60 (47%)CONDITIONAL 
39/106 (37%)
src.xml
FILES 20/38 (53%)CLASSES 20/38 (53%)LINE 116/9560 
(1%)CONDITIONAL 59/13175 (0%)
src.xpath
FILES 9/15 (60%)CLASSES 9/15 (60%)LINE 17/1373 (1%)CONDITIONAL 
18/2724 (1%)

Jenkins-kde-ci: khtml master stable-kf5-qt5 » Linux,gcc - Build # 118 - Fixed!

[no-reply]

GENERAL INFO

BUILD SUCCESS
Build URL: 
https://build.kde.org/job/khtml%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/118/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Tue, 15 Nov 2016 15:33:51 +
Build duration: 6 min 30 sec

CHANGE SET
No changes


JUNIT RESULTS

Name: (root) Failed: 0 test(s), Passed: 3 test(s), Skipped: 0 test(s), Total: 3 
test(s)

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 19/23 (83%)FILES 308/626 (49%)CLASSES 308/626 (49%)LINE 3032/94748 
(3%)CONDITIONAL 2853/152454 (2%)

By packages
  
default>
FILES 2/8 (25%)CLASSES 2/8 (25%)LINE 2/592 (0%)CONDITIONAL 
4/683 (1%)
autotests
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 53/57 (93%)CONDITIONAL 
27/56 (48%)
src
FILES 20/31 (65%)CLASSES 20/31 (65%)LINE 931/8839 
(11%)CONDITIONAL 832/18732 (4%)
src.css
FILES 12/25 (48%)CLASSES 12/25 (48%)LINE 32/9368 
(0%)CONDITIONAL 32/15763 (0%)
src.dom
FILES 29/40 (73%)CLASSES 29/40 (73%)LINE 61/7091 
(1%)CONDITIONAL 66/4880 (1%)
src.ecma
FILES 24/50 (48%)CLASSES 24/50 (48%)LINE 27/8351 
(0%)CONDITIONAL 47/19781 (0%)
src.editing
FILES 5/7 (71%)CLASSES 5/7 (71%)LINE 20/2100 (1%)CONDITIONAL 
11/4037 (0%)
src.html
FILES 21/47 (45%)CLASSES 21/47 (45%)LINE 21/10643 
(0%)CONDITIONAL 42/16139 (0%)
src.imload
FILES 4/31 (13%)CLASSES 4/31 (13%)LINE 24/854 (3%)CONDITIONAL 
14/641 (2%)
src.imload.decoders
FILES 8/8 (100%)CLASSES 8/8 (100%)LINE 19/616 (3%)CONDITIONAL 
10/692 (1%)
src.misc
FILES 13/27 (48%)CLASSES 13/27 (48%)LINE 837/3716 
(23%)CONDITIONAL 707/5318 (13%)
src.platform
FILES 0/1 (0%)CLASSES 0/1 (0%)LINE 0/2 (0%)CONDITIONAL 0/0 
(100%)
src.platform.graphics
FILES 0/16 (0%)CLASSES 0/16 (0%)LINE 0/534 (0%)CONDITIONAL 
0/308 (0%)
src.platform.graphics.qt
FILES 0/7 (0%)CLASSES 0/7 (0%)LINE 0/248 (0%)CONDITIONAL 0/176 
(0%)
src.platform.text
FILES 0/1 (0%)CLASSES 0/1 (0%)LINE 0/7 (0%)CONDITIONAL 0/4 (0%)
src.rendering
FILES 48/97 (49%)CLASSES 48/97 (49%)LINE 64/23896 
(0%)CONDITIONAL 95/32971 (0%)
src.svg
FILES 72/147 (49%)CLASSES 72/147 (49%)LINE 746/5897 
(13%)CONDITIONAL 816/14593 (6%)
src.svg.graphics
FILES 7/14 (50%)CLASSES 7/14 (50%)LINE 7/283 (2%)CONDITIONAL 
14/344 (4%)
src.svg.graphics.qt
FILES 6/6 (100%)CLASSES 6/6 (100%)LINE 6/156 (4%)CONDITIONAL 
12/329 (4%)
src.ui.findbar
FILES 2/4 (50%)CLASSES 2/4 (50%)LINE 21/505 (4%)CONDITIONAL 
8/910 (1%)
src.ui.passwordbar
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 28/60 (47%)CONDITIONAL 
39/106 (37%)
src.xml
FILES 20/38 (53%)CLASSES 20/38 (53%)LINE 116/9560 
(1%)CONDITIONAL 59/13239 (0%)
src.xpath
FILES 9/15 (60%)CLASSES 9/15 (60%)LINE 17/1373 (1%)CONDITIONAL 
18/2752 (1%)

Jenkins-kde-ci: khtml master stable-kf5-qt5 » Linux,gcc - Build # 118 - Fixed!

[no-reply]

GENERAL INFO

BUILD SUCCESS
Build URL: 
https://build.kde.org/job/khtml%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/118/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Tue, 15 Nov 2016 15:33:51 +
Build duration: 6 min 30 sec

CHANGE SET
No changes


JUNIT RESULTS

Name: (root) Failed: 0 test(s), Passed: 3 test(s), Skipped: 0 test(s), Total: 3 
test(s)

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 19/23 (83%)FILES 308/626 (49%)CLASSES 308/626 (49%)LINE 3032/94748 
(3%)CONDITIONAL 2853/152454 (2%)

By packages
  
default>
FILES 2/8 (25%)CLASSES 2/8 (25%)LINE 2/592 (0%)CONDITIONAL 
4/683 (1%)
autotests
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 53/57 (93%)CONDITIONAL 
27/56 (48%)
src
FILES 20/31 (65%)CLASSES 20/31 (65%)LINE 931/8839 
(11%)CONDITIONAL 832/18732 (4%)
src.css
FILES 12/25 (48%)CLASSES 12/25 (48%)LINE 32/9368 
(0%)CONDITIONAL 32/15763 (0%)
src.dom
FILES 29/40 (73%)CLASSES 29/40 (73%)LINE 61/7091 
(1%)CONDITIONAL 66/4880 (1%)
src.ecma
FILES 24/50 (48%)CLASSES 24/50 (48%)LINE 27/8351 
(0%)CONDITIONAL 47/19781 (0%)
src.editing
FILES 5/7 (71%)CLASSES 5/7 (71%)LINE 20/2100 (1%)CONDITIONAL 
11/4037 (0%)
src.html
FILES 21/47 (45%)CLASSES 21/47 (45%)LINE 21/10643 
(0%)CONDITIONAL 42/16139 (0%)
src.imload
FILES 4/31 (13%)CLASSES 4/31 (13%)LINE 24/854 (3%)CONDITIONAL 
14/641 (2%)
src.imload.decoders
FILES 8/8 (100%)CLASSES 8/8 (100%)LINE 19/616 (3%)CONDITIONAL 
10/692 (1%)
src.misc
FILES 13/27 (48%)CLASSES 13/27 (48%)LINE 837/3716 
(23%)CONDITIONAL 707/5318 (13%)
src.platform
FILES 0/1 (0%)CLASSES 0/1 (0%)LINE 0/2 (0%)CONDITIONAL 0/0 
(100%)
src.platform.graphics
FILES 0/16 (0%)CLASSES 0/16 (0%)LINE 0/534 (0%)CONDITIONAL 
0/308 (0%)
src.platform.graphics.qt
FILES 0/7 (0%)CLASSES 0/7 (0%)LINE 0/248 (0%)CONDITIONAL 0/176 
(0%)
src.platform.text
FILES 0/1 (0%)CLASSES 0/1 (0%)LINE 0/7 (0%)CONDITIONAL 0/4 (0%)
src.rendering
FILES 48/97 (49%)CLASSES 48/97 (49%)LINE 64/23896 
(0%)CONDITIONAL 95/32971 (0%)
src.svg
FILES 72/147 (49%)CLASSES 72/147 (49%)LINE 746/5897 
(13%)CONDITIONAL 816/14593 (6%)
src.svg.graphics
FILES 7/14 (50%)CLASSES 7/14 (50%)LINE 7/283 (2%)CONDITIONAL 
14/344 (4%)
src.svg.graphics.qt
FILES 6/6 (100%)CLASSES 6/6 (100%)LINE 6/156 (4%)CONDITIONAL 
12/329 (4%)
src.ui.findbar
FILES 2/4 (50%)CLASSES 2/4 (50%)LINE 21/505 (4%)CONDITIONAL 
8/910 (1%)
src.ui.passwordbar
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 28/60 (47%)CONDITIONAL 
39/106 (37%)
src.xml
FILES 20/38 (53%)CLASSES 20/38 (53%)LINE 116/9560 
(1%)CONDITIONAL 59/13239 (0%)
src.xpath
FILES 9/15 (60%)CLASSES 9/15 (60%)LINE 17/1373 (1%)CONDITIONAL 
18/2752 (1%)

Jenkins-kde-ci: kio master kf5-qt5 » Linux,gcc - Build # 270 - Fixed!

[no-reply]

GENERAL INFO

BUILD SUCCESS
Build URL: 
https://build.kde.org/job/kio%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/270/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Tue, 15 Nov 2016 15:08:43 +
Build duration: 5 min 12 sec

CHANGE SET
Revision 5618af6c7267877672246a6600f69af974d84bf7 by scripty: (Upgrade KF5 
version to 5.29.0.)
  change: edit CMakeLists.txt


JUNIT RESULTS

Name: (root) Failed: 0 test(s), Passed: 52 test(s), Skipped: 0 test(s), Total: 
52 test(s)

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 21/21 (100%)FILES 271/340 (80%)CLASSES 271/340 (80%)LINE 29272/51403 
(57%)CONDITIONAL 16019/38159 (42%)

By packages
  
autotests
FILES 66/66 (100%)CLASSES 66/66 (100%)LINE 7818/8142 
(96%)CONDITIONAL 4372/8542 (51%)
autotests.http
FILES 9/9 (100%)CLASSES 9/9 (100%)LINE 543/544 
(100%)CONDITIONAL 200/336 (60%)
autotests.kcookiejar
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 179/198 (90%)CONDITIONAL 
60/90 (67%)
src.core
FILES 96/116 (83%)CLASSES 96/116 (83%)LINE 7797/14144 
(55%)CONDITIONAL 4264/9073 (47%)
src.core.kssl
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 35/93 (38%)CONDITIONAL 
3/6 (50%)
src.filewidgets
FILES 26/36 (72%)CLASSES 26/36 (72%)LINE 3404/7559 
(45%)CONDITIONAL 1260/4381 (29%)
src.gui
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 104/110 (95%)CONDITIONAL 
46/72 (64%)
src.ioslaves.file
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 443/841 (53%)CONDITIONAL 
329/725 (45%)
src.ioslaves.http
FILES 8/8 (100%)CLASSES 8/8 (100%)LINE 1763/3778 
(47%)CONDITIONAL 1259/3432 (37%)
src.ioslaves.http.kcookiejar
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 620/781 (79%)CONDITIONAL 
602/831 (72%)
src.ioslaves.trash
FILES 7/9 (78%)CLASSES 7/9 (78%)LINE 704/1138 (62%)CONDITIONAL 
377/757 (50%)
src.ioslaves.trash.tests
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 686/764 (90%)CONDITIONAL 
445/936 (48%)
src.kioslave
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 14/27 (52%)CONDITIONAL 
5/10 (50%)
src.kntlm
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 373/385 (97%)CONDITIONAL 
111/138 (80%)
src.kpasswdserver
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 377/594 (63%)CONDITIONAL 
280/580 (48%)
src.kpasswdserver.autotests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 283/286 (99%)CONDITIONAL 
146/256 (57%)
src.urifilters.fixhost
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 25/34 (74%)CONDITIONAL 
36/54 (67%)
src.urifilters.ikws
FILES 5/10 (50%)CLASSES 5/10 (50%)LINE 240/725 (33%)CONDITIONAL 
146/542 (27%)
src.urifilters.localdomain
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 19/26 (73%)CONDITIONAL 
14/22 (64%)
src.urifilters.shorturi
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 239/268 (89%)CONDITIONAL 
333/414 (80%)
src.widgets
FILES 32/64 (50%)CLASSES 32/64 (50%)LINE 3606/10966 
(33%)CONDITIONAL 1731/6962 (25%)

Jenkins-kde-ci: kio master kf5-qt5 » Linux,gcc - Build # 270 - Fixed!

[no-reply]

GENERAL INFO

BUILD SUCCESS
Build URL: 
https://build.kde.org/job/kio%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/270/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Tue, 15 Nov 2016 15:08:43 +
Build duration: 5 min 12 sec

CHANGE SET
Revision 5618af6c7267877672246a6600f69af974d84bf7 by scripty: (Upgrade KF5 
version to 5.29.0.)
  change: edit CMakeLists.txt


JUNIT RESULTS

Name: (root) Failed: 0 test(s), Passed: 52 test(s), Skipped: 0 test(s), Total: 
52 test(s)

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 21/21 (100%)FILES 271/340 (80%)CLASSES 271/340 (80%)LINE 29272/51403 
(57%)CONDITIONAL 16019/38159 (42%)

By packages
  
autotests
FILES 66/66 (100%)CLASSES 66/66 (100%)LINE 7818/8142 
(96%)CONDITIONAL 4372/8542 (51%)
autotests.http
FILES 9/9 (100%)CLASSES 9/9 (100%)LINE 543/544 
(100%)CONDITIONAL 200/336 (60%)
autotests.kcookiejar
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 179/198 (90%)CONDITIONAL 
60/90 (67%)
src.core
FILES 96/116 (83%)CLASSES 96/116 (83%)LINE 7797/14144 
(55%)CONDITIONAL 4264/9073 (47%)
src.core.kssl
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 35/93 (38%)CONDITIONAL 
3/6 (50%)
src.filewidgets
FILES 26/36 (72%)CLASSES 26/36 (72%)LINE 3404/7559 
(45%)CONDITIONAL 1260/4381 (29%)
src.gui
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 104/110 (95%)CONDITIONAL 
46/72 (64%)
src.ioslaves.file
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 443/841 (53%)CONDITIONAL 
329/725 (45%)
src.ioslaves.http
FILES 8/8 (100%)CLASSES 8/8 (100%)LINE 1763/3778 
(47%)CONDITIONAL 1259/3432 (37%)
src.ioslaves.http.kcookiejar
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 620/781 (79%)CONDITIONAL 
602/831 (72%)
src.ioslaves.trash
FILES 7/9 (78%)CLASSES 7/9 (78%)LINE 704/1138 (62%)CONDITIONAL 
377/757 (50%)
src.ioslaves.trash.tests
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 686/764 (90%)CONDITIONAL 
445/936 (48%)
src.kioslave
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 14/27 (52%)CONDITIONAL 
5/10 (50%)
src.kntlm
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 373/385 (97%)CONDITIONAL 
111/138 (80%)
src.kpasswdserver
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 377/594 (63%)CONDITIONAL 
280/580 (48%)
src.kpasswdserver.autotests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 283/286 (99%)CONDITIONAL 
146/256 (57%)
src.urifilters.fixhost
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 25/34 (74%)CONDITIONAL 
36/54 (67%)
src.urifilters.ikws
FILES 5/10 (50%)CLASSES 5/10 (50%)LINE 240/725 (33%)CONDITIONAL 
146/542 (27%)
src.urifilters.localdomain
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 19/26 (73%)CONDITIONAL 
14/22 (64%)
src.urifilters.shorturi
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 239/268 (89%)CONDITIONAL 
333/414 (80%)
src.widgets
FILES 32/64 (50%)CLASSES 32/64 (50%)LINE 3606/10966 
(33%)CONDITIONAL 1731/6962 (25%)

Jenkins-kde-ci: khtml master stable-kf5-qt5 » Linux,gcc - Build # 117 - Failure!

[no-reply]

GENERAL INFO

BUILD FAILURE
Build URL: 
https://build.kde.org/job/khtml%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/117/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Tue, 15 Nov 2016 14:32:27 +
Build duration: 18 min

CHANGE SET
Revision dcc1355cc5c0656b61ecc591b8dd6ebdd0cfb098 by scripty: (Upgrade KF5 
version to 5.29.0.)
  change: edit CMakeLists.txt

Jenkins-kde-ci: kxmlgui master kf5-qt5 » Linux,gcc - Build # 101 - Fixed!

[no-reply]

GENERAL INFO

BUILD SUCCESS
Build URL: 
https://build.kde.org/job/kxmlgui%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/101/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Tue, 15 Nov 2016 15:08:43 +
Build duration: 1 min 36 sec

CHANGE SET
No changes


JUNIT RESULTS

Name: (root) Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 
test(s)

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 2/2 (100%)FILES 39/68 (57%)CLASSES 39/68 (57%)LINE 4010/9254 
(43%)CONDITIONAL 2182/6443 (34%)

By packages
  
autotests
FILES 11/11 (100%)CLASSES 11/11 (100%)LINE 1345/1357 
(99%)CONDITIONAL 603/1220 (49%)
src
FILES 28/57 (49%)CLASSES 28/57 (49%)LINE 2665/7897 
(34%)CONDITIONAL 1579/5223 (30%)

Jenkins-kde-ci: kxmlgui master kf5-qt5 » Linux,gcc - Build # 101 - Fixed!

[no-reply]

GENERAL INFO

BUILD SUCCESS
Build URL: 
https://build.kde.org/job/kxmlgui%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/101/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Tue, 15 Nov 2016 15:08:43 +
Build duration: 1 min 36 sec

CHANGE SET
No changes


JUNIT RESULTS

Name: (root) Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 
test(s)

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 2/2 (100%)FILES 39/68 (57%)CLASSES 39/68 (57%)LINE 4010/9254 
(43%)CONDITIONAL 2182/6443 (34%)

By packages
  
autotests
FILES 11/11 (100%)CLASSES 11/11 (100%)LINE 1345/1357 
(99%)CONDITIONAL 603/1220 (49%)
src
FILES 28/57 (49%)CLASSES 28/57 (49%)LINE 2665/7897 
(34%)CONDITIONAL 1579/5223 (30%)

Jenkins-kde-ci: khtml master kf5-qt5 » Linux,gcc - Build # 117 - Failure!

[no-reply]

GENERAL INFO

BUILD FAILURE
Build URL: 
https://build.kde.org/job/khtml%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/117/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Tue, 15 Nov 2016 14:21:06 +
Build duration: 16 min

CHANGE SET
Revision dcc1355cc5c0656b61ecc591b8dd6ebdd0cfb098 by scripty: (Upgrade KF5 
version to 5.29.0.)
  change: edit CMakeLists.txt

Jenkins-kde-ci: kpty master kf5-qt5 » Linux,gcc - Build # 131 - Fixed!

[no-reply]

GENERAL INFO

BUILD SUCCESS
Build URL: 
https://build.kde.org/job/kpty%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/131/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Tue, 15 Nov 2016 14:32:17 +
Build duration: 1 min 37 sec

CHANGE SET
No changes


JUNIT RESULTS

Name: (root) Failed: 0 test(s), Passed: 2 test(s), Skipped: 0 test(s), Total: 2 
test(s)

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 2/2 (100%)FILES 8/8 (100%)CLASSES 8/8 (100%)LINE 438/560 
(78%)CONDITIONAL 129/249 (52%)

By packages
  
autotests
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 114/114 
(100%)CONDITIONAL 42/78 (54%)
src
FILES 6/6 (100%)CLASSES 6/6 (100%)LINE 324/446 (73%)CONDITIONAL 
87/171 (51%)

Jenkins-kde-ci: kpty master kf5-qt5 » Linux,gcc - Build # 131 - Fixed!

[no-reply]

GENERAL INFO

BUILD SUCCESS
Build URL: 
https://build.kde.org/job/kpty%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/131/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Tue, 15 Nov 2016 14:32:17 +
Build duration: 1 min 37 sec

CHANGE SET
No changes


JUNIT RESULTS

Name: (root) Failed: 0 test(s), Passed: 2 test(s), Skipped: 0 test(s), Total: 2 
test(s)

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 2/2 (100%)FILES 8/8 (100%)CLASSES 8/8 (100%)LINE 438/560 
(78%)CONDITIONAL 129/249 (52%)

By packages
  
autotests
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 114/114 
(100%)CONDITIONAL 42/78 (54%)
src
FILES 6/6 (100%)CLASSES 6/6 (100%)LINE 324/446 (73%)CONDITIONAL 
87/171 (51%)

Jenkins-kde-ci: kcompletion master kf5-qt5 » Linux,gcc - Build # 103 - Fixed!

[no-reply]

GENERAL INFO

BUILD SUCCESS
Build URL: 
https://build.kde.org/job/kcompletion%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/103/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Tue, 15 Nov 2016 14:26:31 +
Build duration: 3 min 54 sec

CHANGE SET
No changes


JUNIT RESULTS

Name: (root) Failed: 0 test(s), Passed: 5 test(s), Skipped: 0 test(s), Total: 5 
test(s)

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 2/2 (100%)FILES 21/24 (88%)CLASSES 21/24 (88%)LINE 1982/3232 
(61%)CONDITIONAL 982/2367 (41%)

By packages
  
autotests
FILES 5/5 (100%)CLASSES 5/5 (100%)LINE 528/528 
(100%)CONDITIONAL 297/590 (50%)
src
FILES 16/19 (84%)CLASSES 16/19 (84%)LINE 1454/2704 
(54%)CONDITIONAL 685/1777 (39%)

Jenkins-kde-ci: kcompletion master kf5-qt5 » Linux,gcc - Build # 103 - Fixed!

[no-reply]

GENERAL INFO

BUILD SUCCESS
Build URL: 
https://build.kde.org/job/kcompletion%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/103/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Tue, 15 Nov 2016 14:26:31 +
Build duration: 3 min 54 sec

CHANGE SET
No changes


JUNIT RESULTS

Name: (root) Failed: 0 test(s), Passed: 5 test(s), Skipped: 0 test(s), Total: 5 
test(s)

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 2/2 (100%)FILES 21/24 (88%)CLASSES 21/24 (88%)LINE 1982/3232 
(61%)CONDITIONAL 982/2367 (41%)

By packages
  
autotests
FILES 5/5 (100%)CLASSES 5/5 (100%)LINE 528/528 
(100%)CONDITIONAL 297/590 (50%)
src
FILES 16/19 (84%)CLASSES 16/19 (84%)LINE 1454/2704 
(54%)CONDITIONAL 685/1777 (39%)

Jenkins-kde-ci: kxmlgui master kf5-qt5 » Linux,gcc - Build # 100 - Failure!

[no-reply]

GENERAL INFO

BUILD FAILURE
Build URL: 
https://build.kde.org/job/kxmlgui%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/100/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Tue, 15 Nov 2016 14:25:35 +
Build duration: 58 sec

CHANGE SET
Revision 12510986bf58b074bc23394ee4bec0f0c4187fcc by scripty: (Upgrade KF5 
version to 5.29.0.)
  change: edit CMakeLists.txt

Jenkins-kde-ci: kauth master stable-kf5-qt5 » Linux,gcc - Build # 135 - Fixed!

[no-reply]

GENERAL INFO

BUILD SUCCESS
Build URL: 
https://build.kde.org/job/kauth%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/135/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Tue, 15 Nov 2016 14:23:21 +
Build duration: 2 min 31 sec

CHANGE SET
No changes


JUNIT RESULTS

Name: (root) Failed: 0 test(s), Passed: 3 test(s), Skipped: 0 test(s), Total: 3 
test(s)

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 3/3 (100%)FILES 16/21 (76%)CLASSES 16/21 (76%)LINE 538/817 
(66%)CONDITIONAL 201/424 (47%)

By packages
  
autotests
FILES 6/7 (86%)CLASSES 6/7 (86%)LINE 250/269 (93%)CONDITIONAL 
149/256 (58%)
src
FILES 9/12 (75%)CLASSES 9/12 (75%)LINE 194/361 (54%)CONDITIONAL 
27/98 (28%)
src.backends.dbus
FILES 1/2 (50%)CLASSES 1/2 (50%)LINE 94/187 (50%)CONDITIONAL 
25/70 (36%)

Re: python binding's __init__.py

[Stephen Kelly]

Harald Sitter wrote:

> Alohas
> 
> I am currently trying to package kitemmodels' python bindings. The
> module generator installs
> 
> -./usr/lib/python2.7/dist-packages/PyKF5/__init__.py
> -./usr/lib/python2.7/dist-packages/PyKF5/KItemModels.so
> 
> This will cause a fairly shitty problem on packaging level, when a
> second framework wants to generate bindings. Both would be installing
> __init__.py in the same path, thus conflicting with one another, thus
> making the packages not co-installable.
> 
> I rather think we need a pykf5 framework which does nothing more than
> install an empty __init__.py which will need to be installed to use
> any bindings OR change the installation path to fully isolate the
> directories PyKF5ItemModels/KItemModels.so.
> Latter will make for ugly code on the python side, so I think the
> former approach would be the best solution.

Hi Harald,

Thanks for working on this!

Could you review the discussion in

 http://comments.gmane.org/gmane.comp.kde.distributions/92

?

My hope was that packagers could choose one of the KF5 packages which 
provides an __init__.py and use the file from that package, and remove it 
from any other py-kf5 packages. Is that workable? 

The file might get content in the future (such as version information, 
module information, documentation), but that will continue to be generated 
by ECM and will be versioned by whatever code in ECM generates the content.

Thanks,

Steve.

Jenkins-kde-ci: kglobalaccel master stable-kf5-qt5 » Linux,gcc - Build # 137 - Fixed!

[no-reply]

GENERAL INFO

BUILD SUCCESS
Build URL: 
https://build.kde.org/job/kglobalaccel%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/137/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Tue, 15 Nov 2016 14:23:21 +
Build duration: 2 min 35 sec

CHANGE SET
No changes


JUNIT RESULTS

Name: (root) Failed: 0 test(s), Passed: 2 test(s), Skipped: 0 test(s), Total: 2 
test(s)

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 4/4 (100%)FILES 19/21 (90%)CLASSES 19/21 (90%)LINE 1109/1636 
(68%)CONDITIONAL 604/1357 (45%)

By packages
  
autotests
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 244/256 (95%)CONDITIONAL 
103/202 (51%)
src
FILES 6/7 (86%)CLASSES 6/7 (86%)LINE 292/413 (71%)CONDITIONAL 
163/282 (58%)
src.runtime
FILES 10/11 (91%)CLASSES 10/11 (91%)LINE 490/840 
(58%)CONDITIONAL 289/764 (38%)
src.runtime.plugins.xcb
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 83/127 (65%)CONDITIONAL 
49/109 (45%)

Jenkins-kde-ci: kglobalaccel master stable-kf5-qt5 » Linux,gcc - Build # 137 - Fixed!

[no-reply]

GENERAL INFO

BUILD SUCCESS
Build URL: 
https://build.kde.org/job/kglobalaccel%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/137/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Tue, 15 Nov 2016 14:23:21 +
Build duration: 2 min 35 sec

CHANGE SET
No changes


JUNIT RESULTS

Name: (root) Failed: 0 test(s), Passed: 2 test(s), Skipped: 0 test(s), Total: 2 
test(s)

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 4/4 (100%)FILES 19/21 (90%)CLASSES 19/21 (90%)LINE 1109/1636 
(68%)CONDITIONAL 604/1357 (45%)

By packages
  
autotests
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 244/256 (95%)CONDITIONAL 
103/202 (51%)
src
FILES 6/7 (86%)CLASSES 6/7 (86%)LINE 292/413 (71%)CONDITIONAL 
163/282 (58%)
src.runtime
FILES 10/11 (91%)CLASSES 10/11 (91%)LINE 490/840 
(58%)CONDITIONAL 289/764 (38%)
src.runtime.plugins.xcb
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 83/127 (65%)CONDITIONAL 
49/109 (45%)

Jenkins-kde-ci: kio master stable-kf5-qt5 » Linux,gcc - Build # 273 - Fixed!

[no-reply]

GENERAL INFO

BUILD SUCCESS
Build URL: 
https://build.kde.org/job/kio%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/273/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Tue, 15 Nov 2016 14:18:21 +
Build duration: 5 min 43 sec

CHANGE SET
Revision 5618af6c7267877672246a6600f69af974d84bf7 by scripty: (Upgrade KF5 
version to 5.29.0.)
  change: edit CMakeLists.txt


JUNIT RESULTS

Name: (root) Failed: 0 test(s), Passed: 52 test(s), Skipped: 0 test(s), Total: 
52 test(s)

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 21/21 (100%)FILES 271/340 (80%)CLASSES 271/340 (80%)LINE 29299/51403 
(57%)CONDITIONAL 16028/38159 (42%)

By packages
  
autotests
FILES 66/66 (100%)CLASSES 66/66 (100%)LINE 7818/8142 
(96%)CONDITIONAL 4372/8542 (51%)
autotests.http
FILES 9/9 (100%)CLASSES 9/9 (100%)LINE 543/544 
(100%)CONDITIONAL 200/336 (60%)
autotests.kcookiejar
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 179/198 (90%)CONDITIONAL 
60/90 (67%)
src.core
FILES 96/116 (83%)CLASSES 96/116 (83%)LINE 7818/14144 
(55%)CONDITIONAL 4272/9073 (47%)
src.core.kssl
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 35/93 (38%)CONDITIONAL 
3/6 (50%)
src.filewidgets
FILES 26/36 (72%)CLASSES 26/36 (72%)LINE 3402/7559 
(45%)CONDITIONAL 1258/4381 (29%)
src.gui
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 104/110 (95%)CONDITIONAL 
46/72 (64%)
src.ioslaves.file
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 443/841 (53%)CONDITIONAL 
329/725 (45%)
src.ioslaves.http
FILES 8/8 (100%)CLASSES 8/8 (100%)LINE 1763/3778 
(47%)CONDITIONAL 1259/3432 (37%)
src.ioslaves.http.kcookiejar
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 620/781 (79%)CONDITIONAL 
602/831 (72%)
src.ioslaves.trash
FILES 7/9 (78%)CLASSES 7/9 (78%)LINE 704/1138 (62%)CONDITIONAL 
377/757 (50%)
src.ioslaves.trash.tests
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 686/764 (90%)CONDITIONAL 
445/936 (48%)
src.kioslave
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 14/27 (52%)CONDITIONAL 
5/10 (50%)
src.kntlm
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 373/385 (97%)CONDITIONAL 
111/138 (80%)
src.kpasswdserver
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 377/594 (63%)CONDITIONAL 
280/580 (48%)
src.kpasswdserver.autotests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 283/286 (99%)CONDITIONAL 
146/256 (57%)
src.urifilters.fixhost
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 25/34 (74%)CONDITIONAL 
36/54 (67%)
src.urifilters.ikws
FILES 5/10 (50%)CLASSES 5/10 (50%)LINE 240/725 (33%)CONDITIONAL 
146/542 (27%)
src.urifilters.localdomain
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 19/26 (73%)CONDITIONAL 
14/22 (64%)
src.urifilters.shorturi
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 239/268 (89%)CONDITIONAL 
333/414 (80%)
src.widgets
FILES 32/64 (50%)CLASSES 32/64 (50%)LINE 3614/10966 
(33%)CONDITIONAL 1734/6962 (25%)

Jenkins-kde-ci: kio master stable-kf5-qt5 » Linux,gcc - Build # 273 - Fixed!

[no-reply]

GENERAL INFO

BUILD SUCCESS
Build URL: 
https://build.kde.org/job/kio%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/273/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Tue, 15 Nov 2016 14:18:21 +
Build duration: 5 min 43 sec

CHANGE SET
Revision 5618af6c7267877672246a6600f69af974d84bf7 by scripty: (Upgrade KF5 
version to 5.29.0.)
  change: edit CMakeLists.txt


JUNIT RESULTS

Name: (root) Failed: 0 test(s), Passed: 52 test(s), Skipped: 0 test(s), Total: 
52 test(s)

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 21/21 (100%)FILES 271/340 (80%)CLASSES 271/340 (80%)LINE 29299/51403 
(57%)CONDITIONAL 16028/38159 (42%)

By packages
  
autotests
FILES 66/66 (100%)CLASSES 66/66 (100%)LINE 7818/8142 
(96%)CONDITIONAL 4372/8542 (51%)
autotests.http
FILES 9/9 (100%)CLASSES 9/9 (100%)LINE 543/544 
(100%)CONDITIONAL 200/336 (60%)
autotests.kcookiejar
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 179/198 (90%)CONDITIONAL 
60/90 (67%)
src.core
FILES 96/116 (83%)CLASSES 96/116 (83%)LINE 7818/14144 
(55%)CONDITIONAL 4272/9073 (47%)
src.core.kssl
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 35/93 (38%)CONDITIONAL 
3/6 (50%)
src.filewidgets
FILES 26/36 (72%)CLASSES 26/36 (72%)LINE 3402/7559 
(45%)CONDITIONAL 1258/4381 (29%)
src.gui
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 104/110 (95%)CONDITIONAL 
46/72 (64%)
src.ioslaves.file
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 443/841 (53%)CONDITIONAL 
329/725 (45%)
src.ioslaves.http
FILES 8/8 (100%)CLASSES 8/8 (100%)LINE 1763/3778 
(47%)CONDITIONAL 1259/3432 (37%)
src.ioslaves.http.kcookiejar
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 620/781 (79%)CONDITIONAL 
602/831 (72%)
src.ioslaves.trash
FILES 7/9 (78%)CLASSES 7/9 (78%)LINE 704/1138 (62%)CONDITIONAL 
377/757 (50%)
src.ioslaves.trash.tests
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 686/764 (90%)CONDITIONAL 
445/936 (48%)
src.kioslave
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 14/27 (52%)CONDITIONAL 
5/10 (50%)
src.kntlm
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 373/385 (97%)CONDITIONAL 
111/138 (80%)
src.kpasswdserver
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 377/594 (63%)CONDITIONAL 
280/580 (48%)
src.kpasswdserver.autotests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 283/286 (99%)CONDITIONAL 
146/256 (57%)
src.urifilters.fixhost
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 25/34 (74%)CONDITIONAL 
36/54 (67%)
src.urifilters.ikws
FILES 5/10 (50%)CLASSES 5/10 (50%)LINE 240/725 (33%)CONDITIONAL 
146/542 (27%)
src.urifilters.localdomain
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 19/26 (73%)CONDITIONAL 
14/22 (64%)
src.urifilters.shorturi
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 239/268 (89%)CONDITIONAL 
333/414 (80%)
src.widgets
FILES 32/64 (50%)CLASSES 32/64 (50%)LINE 3614/10966 
(33%)CONDITIONAL 1734/6962 (25%)

Jenkins-kde-ci: kwindowsystem master kf5-qt5 » Linux,All,gcc - Build # 87 - Unstable!

[no-reply]

GENERAL INFO

BUILD UNSTABLE
Build URL: 
https://build.kde.org/job/kwindowsystem%20master%20kf5-qt5/PLATFORM=Linux,Variation=All,compiler=gcc/87/
Project: PLATFORM=Linux,Variation=All,compiler=gcc
Date of build: Tue, 15 Nov 2016 14:12:32 +
Build duration: 7 min 44 sec

CHANGE SET
Revision a98f9736bcf83584c8b56f5b60db1a37b24f2cc1 by scripty: (Upgrade KF5 
version to 5.29.0.)
  change: edit CMakeLists.txt


JUNIT RESULTS

Name: (root) Failed: 3 test(s), Passed: 10 test(s), Skipped: 0 test(s), Total: 
13 test(s)Failed: TestSuite.kwindowsystem-kwindowinfox11testFailed: 
TestSuite.kwindowsystem-kwindowsystem_threadtestFailed: 
TestSuite.kwindowsystem-kwindowsystemx11test

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 4/5 (80%)FILES 39/49 (80%)CLASSES 39/49 (80%)LINE 5658/8636 
(66%)CONDITIONAL 3080/6581 (47%)

By packages
  
autotests
FILES 14/14 (100%)CLASSES 14/14 (100%)LINE 2400/2564 
(94%)CONDITIONAL 1292/2627 (49%)
autotests.helper
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 7/10 (70%)CONDITIONAL 
3/6 (50%)
src
FILES 12/16 (75%)CLASSES 12/16 (75%)LINE 603/1436 
(42%)CONDITIONAL 289/710 (41%)
src.platforms.wayland
FILES 0/2 (0%)CLASSES 0/2 (0%)LINE 0/89 (0%)CONDITIONAL 0/2 (0%)
src.platforms.xcb
FILES 12/16 (75%)CLASSES 12/16 (75%)LINE 2648/4537 
(58%)CONDITIONAL 1496/3236 (46%)

Jenkins-kde-ci: kservice master kf5-qt5 » Linux,gcc - Build # 142 - Fixed!

[no-reply]

GENERAL INFO

BUILD SUCCESS
Build URL: 
https://build.kde.org/job/kservice%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/142/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Tue, 15 Nov 2016 14:09:58 +
Build duration: 4 min 33 sec

CHANGE SET
Revision 03f13beb62e3571fe92501d331b997a56b38caf2 by scripty: (Upgrade KF5 
version to 5.29.0.)
  change: edit CMakeLists.txt


JUNIT RESULTS

Name: (root) Failed: 0 test(s), Passed: 11 test(s), Skipped: 0 test(s), Total: 
11 test(s)

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 6/7 (86%)FILES 75/84 (89%)CLASSES 75/84 (89%)LINE 5466/7983 
(68%)CONDITIONAL 2961/6138 (48%)

By packages
  
autotests
FILES 14/14 (100%)CLASSES 14/14 (100%)LINE 1444/1530 
(94%)CONDITIONAL 891/1768 (50%)
src.kbuildsycoca
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 61/67 (91%)CONDITIONAL 
15/20 (75%)
src.kdeinit
FILES 0/2 (0%)CLASSES 0/2 (0%)LINE 0/326 (0%)CONDITIONAL 0/262 
(0%)
src.plugin
FILES 2/3 (67%)CLASSES 2/3 (67%)LINE 47/100 (47%)CONDITIONAL 
36/96 (38%)
src.services
FILES 29/30 (97%)CLASSES 29/30 (97%)LINE 1762/3042 
(58%)CONDITIONAL 758/1888 (40%)
src.sycoca
FILES 26/31 (84%)CLASSES 26/31 (84%)LINE 2044/2798 
(73%)CONDITIONAL 1227/2054 (60%)
tests.pluginlocator
FILES 3/3 (100%)CLASSES 3/3 (100%)LINE 108/120 (90%)CONDITIONAL 
34/50 (68%)

Jenkins-kde-ci: kservice master kf5-qt5 » Linux,gcc - Build # 142 - Fixed!

[no-reply]

GENERAL INFO

BUILD SUCCESS
Build URL: 
https://build.kde.org/job/kservice%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/142/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Tue, 15 Nov 2016 14:09:58 +
Build duration: 4 min 33 sec

CHANGE SET
Revision 03f13beb62e3571fe92501d331b997a56b38caf2 by scripty: (Upgrade KF5 
version to 5.29.0.)
  change: edit CMakeLists.txt


JUNIT RESULTS

Name: (root) Failed: 0 test(s), Passed: 11 test(s), Skipped: 0 test(s), Total: 
11 test(s)

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 6/7 (86%)FILES 75/84 (89%)CLASSES 75/84 (89%)LINE 5466/7983 
(68%)CONDITIONAL 2961/6138 (48%)

By packages
  
autotests
FILES 14/14 (100%)CLASSES 14/14 (100%)LINE 1444/1530 
(94%)CONDITIONAL 891/1768 (50%)
src.kbuildsycoca
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 61/67 (91%)CONDITIONAL 
15/20 (75%)
src.kdeinit
FILES 0/2 (0%)CLASSES 0/2 (0%)LINE 0/326 (0%)CONDITIONAL 0/262 
(0%)
src.plugin
FILES 2/3 (67%)CLASSES 2/3 (67%)LINE 47/100 (47%)CONDITIONAL 
36/96 (38%)
src.services
FILES 29/30 (97%)CLASSES 29/30 (97%)LINE 1762/3042 
(58%)CONDITIONAL 758/1888 (40%)
src.sycoca
FILES 26/31 (84%)CLASSES 26/31 (84%)LINE 2044/2798 
(73%)CONDITIONAL 1227/2054 (60%)
tests.pluginlocator
FILES 3/3 (100%)CLASSES 3/3 (100%)LINE 108/120 (90%)CONDITIONAL 
34/50 (68%)

Jenkins-kde-ci: kpty master kf5-qt5 » Linux,gcc - Build # 130 - Unstable!

[no-reply]

GENERAL INFO

BUILD UNSTABLE
Build URL: 
https://build.kde.org/job/kpty%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/130/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Tue, 15 Nov 2016 14:09:58 +
Build duration: 1 min 31 sec

CHANGE SET
Revision 79f650b2eac3eee09b82680f0cc8f2c5f0cdd2f1 by scripty: (Upgrade KF5 
version to 5.29.0.)
  change: edit CMakeLists.txt


JUNIT RESULTS

Name: (root) Failed: 1 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 2 
test(s)Failed: TestSuite.kptyprocesstest

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 2/2 (100%)FILES 8/8 (100%)CLASSES 8/8 (100%)LINE 434/560 
(78%)CONDITIONAL 128/249 (51%)

By packages
  
autotests
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 114/114 
(100%)CONDITIONAL 42/78 (54%)
src
FILES 6/6 (100%)CLASSES 6/6 (100%)LINE 320/446 (72%)CONDITIONAL 
86/171 (50%)

Jenkins-kde-ci: kauth master stable-kf5-qt5 » Linux,gcc - Build # 134 - Failure!

[no-reply]

GENERAL INFO

BUILD FAILURE
Build URL: 
https://build.kde.org/job/kauth%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/134/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Tue, 15 Nov 2016 14:00:59 +
Build duration: 56 sec

CHANGE SET
Revision 0cc9ff2983e7cb14c1ca08a8756e04f013120810 by scripty: (Upgrade KF5 
version to 5.29.0.)
  change: edit CMakeLists.txt

Jenkins-kde-ci: kcompletion master kf5-qt5 » Linux,gcc - Build # 102 - Failure!

[no-reply]

GENERAL INFO

BUILD FAILURE
Build URL: 
https://build.kde.org/job/kcompletion%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/102/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Tue, 15 Nov 2016 14:03:48 +
Build duration: 1 min 18 sec

CHANGE SET
Revision bb03b1d846860e875186370c11a05eb1ad80ce9c by scripty: (Upgrade KF5 
version to 5.29.0.)
  change: edit CMakeLists.txt

Jenkins-kde-ci: kglobalaccel master stable-kf5-qt5 » Linux,gcc - Build # 136 - Failure!

[no-reply]

GENERAL INFO

BUILD FAILURE
Build URL: 
https://build.kde.org/job/kglobalaccel%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/136/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Tue, 15 Nov 2016 14:00:59 +
Build duration: 1 min 24 sec

CHANGE SET
Revision a233030cc025dd859869b128985e0ca800df45e1 by scripty: (Upgrade KF5 
version to 5.29.0.)
  change: edit CMakeLists.txt

Jenkins-kde-ci: kwindowsystem master kf5-qt5 » Linux,All,gcc - Build # 86 - Fixed!

[no-reply]

GENERAL INFO

BUILD SUCCESS
Build URL: 
https://build.kde.org/job/kwindowsystem%20master%20kf5-qt5/PLATFORM=Linux,Variation=All,compiler=gcc/86/
Project: PLATFORM=Linux,Variation=All,compiler=gcc
Date of build: Tue, 15 Nov 2016 13:42:43 +
Build duration: 2 min 4 sec

CHANGE SET
No changes


JUNIT RESULTS

Name: (root) Failed: 0 test(s), Passed: 13 test(s), Skipped: 0 test(s), Total: 
13 test(s)

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 4/5 (80%)FILES 44/50 (88%)CLASSES 44/50 (88%)LINE 6812/9083 
(75%)CONDITIONAL 3806/7069 (54%)

By packages
  
autotests
FILES 15/15 (100%)CLASSES 15/15 (100%)LINE 2940/3011 
(98%)CONDITIONAL 1616/3115 (52%)
autotests.helper
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 7/10 (70%)CONDITIONAL 
3/6 (50%)
src
FILES 14/16 (88%)CLASSES 14/16 (88%)LINE 779/1436 
(54%)CONDITIONAL 319/710 (45%)
src.platforms.wayland
FILES 0/2 (0%)CLASSES 0/2 (0%)LINE 0/89 (0%)CONDITIONAL 0/2 (0%)
src.platforms.xcb
FILES 14/16 (88%)CLASSES 14/16 (88%)LINE 3086/4537 
(68%)CONDITIONAL 1868/3236 (58%)

Re: Review Request 129400: Avoid potential access of .last() on empty list

[Marco Martin]

> On Nov. 14, 2016, 1:40 p.m., Aleix Pol Gonzalez wrote:
> > src/kpackagetool/kpackagetool.cpp, line 502
> > 
> >
> > Then just change to `QStandardPath::locate`?
> 
> David Edmundson wrote:
> Sounds sensible to me. Though I don't really know this code.
> Marco, should I do that?

err, comment in the review below was intended as answer for this thread (damn 
ui ;)


- Marco


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129400/#review100834
---


On Nov. 14, 2016, 1:35 p.m., David Edmundson wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129400/
> ---
> 
> (Updated Nov. 14, 2016, 1:35 p.m.)
> 
> 
> Review request for KDE Frameworks and Plasma.
> 
> 
> Repository: kpackage
> 
> 
> Description
> ---
> 
> locateAll can return nothing, therefore we can't always call .last() on
> it.
> 
> Existing code should be able to handle an empty package root as the user
> could also also have provided a broken package root as an argument.
> 
> 
> Diffs
> -
> 
>   src/kpackagetool/kpackagetool.cpp 6135e14ba717d579553036f9ed7874813046a1db 
> 
> Diff: https://git.reviewboard.kde.org/r/129400/diff/
> 
> 
> Testing
> ---
> 
> Ran kpackagetool --generate-index -g
> 
> Previously asserted. No longer asserted.
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

Re: Review Request 129400: Avoid potential access of .last() on empty list

[Marco Martin]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129400/#review100858
---


Fix it, then Ship it!




other than that, ship it


src/kpackagetool/kpackagetool.cpp (line 502)


no, locate would return the first most suitable it found, that is usually 
the local one under ~/.local

whuile this being with global option we need the system one instead. I 
don't see an option in qstandardpaths to ignore the local stuff, so using the 
last one of the things returned by locateAll is the better heuristic i found 
for having this behavior


- Marco Martin


On Nov. 14, 2016, 1:35 p.m., David Edmundson wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129400/
> ---
> 
> (Updated Nov. 14, 2016, 1:35 p.m.)
> 
> 
> Review request for KDE Frameworks and Plasma.
> 
> 
> Repository: kpackage
> 
> 
> Description
> ---
> 
> locateAll can return nothing, therefore we can't always call .last() on
> it.
> 
> Existing code should be able to handle an empty package root as the user
> could also also have provided a broken package root as an argument.
> 
> 
> Diffs
> -
> 
>   src/kpackagetool/kpackagetool.cpp 6135e14ba717d579553036f9ed7874813046a1db 
> 
> Diff: https://git.reviewboard.kde.org/r/129400/diff/
> 
> 
> Testing
> ---
> 
> Ran kpackagetool --generate-index -g
> 
> Previously asserted. No longer asserted.
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

KDE Frameworks 5.28.0 released

[David Faure]

15th November 2016. KDE today announces the release of KDE Frameworks 5.28.0.

KDE Frameworks are 70 addon libraries to Qt which provide a wide variety of·
commonly needed functionality in mature, peer reviewed and well tested·
libraries with friendly licensing terms. For an introduction see the·
Frameworks 5.0 release announcement.

New framework: syntax-highlighting
Syntax highlighting engine for Kate syntax definitions

This is a stand-alone implementation of the Kate syntax highlighting engine.
It's meant as a building block for text editors as well as for simple 
highlighted text rendering (e.g. as HTML), supporting both integration with a 
custom editor as well as a ready-to-use QSyntaxHighlighter sub-class.

Breeze Icons

  update kstars action icons (bug 364981)
  Breeze Dark is listed as Breeze in System Settings wrong .themes file (bug 
370213)

Extra CMake Modules

  Make KDECMakeSettings work with KDE_INSTALL_DIRS_NO_DEPRECATED
  Don't require the python bindings dependencies for ECM
  Add the PythonModuleGeneration module

KActivitiesStats

  Ignoring link status when sortin UsedResources and LinkedResources model

KDE Doxygen Tools

  [CSS] reverse changes done by doxygen 1.8.12
  Add doxygenlayout file
  Update way of defining group names

KAuth

  Make sure we can do more than one request
  Make sure we get to know about progress by reading the program output

KConfig

  Make sure we don't break compilation with past broken units
  Don't be fatal on File field not being properly parsed

KCoreAddons

  Display bad url
  Load user avatars from AccountsServicePath if it exists (bug 370362)

KDeclarative

  [QtQuickRendererSettings] Fix default to be empty instead of "false"

KDELibs 4 Support

  Make the France flag actually use all the pixmap

KDocTools

  Fix 'checkXML5 generates html files in workdir for valid docbooks' (bug 
371987)

KIconThemes

  Support non integer scale factors in kiconengine (bug 366451)

KIdleTime

  Disabled spamming the console output with 'waiting for' messages

KImageFormats

  imageformats/kra.h - overrides for KraPlugin capabilities() and create()

KIO

  Fix HTTP date format sent by kio_http to always use the C locale (bug 
372005)
  KACL: fix memory leaks detected by ASAN
  Fix memory leaks in KIO::Scheduler, detected by ASAN
  Removed duplicate clear button (bug 369377)
  Fix editing autostart entries when /usr/local/share/applications doesn't 
exist (bug 371194)
  [KOpenWithDialog] Hide TreeView header
  Sanitize the symlink name buffer size (bug 369275)
  Properly finish DropJobs when triggered is not emitted (bug 363936)
  ClipboardUpdater: fix another crash on Wayland (bug 359883)
  ClipboardUpdater: fix crash on Wayland (bug 370520)
  Support non integer scale factors in KFileDelegate (bug 366451)
  kntlm: Distinguish between NULL and empty domain
  Don't show overwrite dialog if file name is empty
  kioexec: use friendly filenames
  Fix focus ownership if url is changed before showing the widget
  Major performance improvement when turning previews off in the file dialog 
(bug 346403)

KItemModels

  Add python bindings

KJS

  Export FunctionObjectImp, used by khtml's debugger

KNewStuff

  Separate sort roles and filters
  Make it possible to query installed entries

KNotification

  Don't deref an object we haven't referenced when notification has no action
  KNotification will no longer crash when using it in a QGuiApplication and no 
notification service is running (bug 370667)
  Fix crashes in NotifyByAudio

KPackage Framework

  Make sure we're looking both for json and desktop metadata
  Guard against Q_GLOBAL_STATIC being destroyed at app shutdown
  Fix dangling pointer in KPackageJob (bug 369935)
  Remove discovery associated to a key when removing a definition
  Generate the icon into the appstream file

KPty

  Use ulog-helper on FreeBSD isntead of utempter
  search harder for utempter using basic cmake prefix as well
  workaround find_program ( utempter ...) failure(s)
  use ECM path to find utempter binary, more reliable than simple cmake prefix

KRunner

  i18n: handle strings in kdevtemplate files

KTextEditor

  Breeze Dark: Darken current-line background color for better readability 
(bug 371042)
  Sorted Dockerfile instructions
  Breeze (Dark): Make comments a bit lighter for better readability (bug 
371042)
  Fix CStyle and C++/boost indenters when automatic brackets enabled (bug 
370715)
  Add modeline 'auto-brackets'
  Fix inserting text after end of file (rare case)
  Fix invalid xml highlighting files
  Maxima: Remove hard-coded colors, fix itemData Label
  Add OBJ, PLY and STL syntax definitions
  Add syntax highlighting support for Praat

KUnitConversion

  New Thermal and Electrical Units and Unit Convienience Function

KWallet Framework

  If Gpgmepp is not found, try to use KF5Gpgmepp
  Use Gpgmepp from GpgME-1.7.0

KWayland

  Improved relocatability of CMake export
  [tools] Fix generation of wayland_pointer_p.h
  

KDE Frameworks 5.28.0 released

[David Faure]

15th November 2016. KDE today announces the release of KDE Frameworks 5.28.0.

KDE Frameworks are 70 addon libraries to Qt which provide a wide variety of·
commonly needed functionality in mature, peer reviewed and well tested·
libraries with friendly licensing terms. For an introduction see the·
Frameworks 5.0 release announcement.

New framework: syntax-highlighting
Syntax highlighting engine for Kate syntax definitions

This is a stand-alone implementation of the Kate syntax highlighting engine.
It's meant as a building block for text editors as well as for simple 
highlighted text rendering (e.g. as HTML), supporting both integration with a 
custom editor as well as a ready-to-use QSyntaxHighlighter sub-class.

Breeze Icons

  update kstars action icons (bug 364981)
  Breeze Dark is listed as Breeze in System Settings wrong .themes file (bug 
370213)

Extra CMake Modules

  Make KDECMakeSettings work with KDE_INSTALL_DIRS_NO_DEPRECATED
  Don't require the python bindings dependencies for ECM
  Add the PythonModuleGeneration module

KActivitiesStats

  Ignoring link status when sortin UsedResources and LinkedResources model

KDE Doxygen Tools

  [CSS] reverse changes done by doxygen 1.8.12
  Add doxygenlayout file
  Update way of defining group names

KAuth

  Make sure we can do more than one request
  Make sure we get to know about progress by reading the program output

KConfig

  Make sure we don't break compilation with past broken units
  Don't be fatal on File field not being properly parsed

KCoreAddons

  Display bad url
  Load user avatars from AccountsServicePath if it exists (bug 370362)

KDeclarative

  [QtQuickRendererSettings] Fix default to be empty instead of "false"

KDELibs 4 Support

  Make the France flag actually use all the pixmap

KDocTools

  Fix 'checkXML5 generates html files in workdir for valid docbooks' (bug 
371987)

KIconThemes

  Support non integer scale factors in kiconengine (bug 366451)

KIdleTime

  Disabled spamming the console output with 'waiting for' messages

KImageFormats

  imageformats/kra.h - overrides for KraPlugin capabilities() and create()

KIO

  Fix HTTP date format sent by kio_http to always use the C locale (bug 
372005)
  KACL: fix memory leaks detected by ASAN
  Fix memory leaks in KIO::Scheduler, detected by ASAN
  Removed duplicate clear button (bug 369377)
  Fix editing autostart entries when /usr/local/share/applications doesn't 
exist (bug 371194)
  [KOpenWithDialog] Hide TreeView header
  Sanitize the symlink name buffer size (bug 369275)
  Properly finish DropJobs when triggered is not emitted (bug 363936)
  ClipboardUpdater: fix another crash on Wayland (bug 359883)
  ClipboardUpdater: fix crash on Wayland (bug 370520)
  Support non integer scale factors in KFileDelegate (bug 366451)
  kntlm: Distinguish between NULL and empty domain
  Don't show overwrite dialog if file name is empty
  kioexec: use friendly filenames
  Fix focus ownership if url is changed before showing the widget
  Major performance improvement when turning previews off in the file dialog 
(bug 346403)

KItemModels

  Add python bindings

KJS

  Export FunctionObjectImp, used by khtml's debugger

KNewStuff

  Separate sort roles and filters
  Make it possible to query installed entries

KNotification

  Don't deref an object we haven't referenced when notification has no action
  KNotification will no longer crash when using it in a QGuiApplication and no 
notification service is running (bug 370667)
  Fix crashes in NotifyByAudio

KPackage Framework

  Make sure we're looking both for json and desktop metadata
  Guard against Q_GLOBAL_STATIC being destroyed at app shutdown
  Fix dangling pointer in KPackageJob (bug 369935)
  Remove discovery associated to a key when removing a definition
  Generate the icon into the appstream file

KPty

  Use ulog-helper on FreeBSD isntead of utempter
  search harder for utempter using basic cmake prefix as well
  workaround find_program ( utempter ...) failure(s)
  use ECM path to find utempter binary, more reliable than simple cmake prefix

KRunner

  i18n: handle strings in kdevtemplate files

KTextEditor

  Breeze Dark: Darken current-line background color for better readability 
(bug 371042)
  Sorted Dockerfile instructions
  Breeze (Dark): Make comments a bit lighter for better readability (bug 
371042)
  Fix CStyle and C++/boost indenters when automatic brackets enabled (bug 
370715)
  Add modeline 'auto-brackets'
  Fix inserting text after end of file (rare case)
  Fix invalid xml highlighting files
  Maxima: Remove hard-coded colors, fix itemData Label
  Add OBJ, PLY and STL syntax definitions
  Add syntax highlighting support for Praat

KUnitConversion

  New Thermal and Electrical Units and Unit Convienience Function

KWallet Framework

  If Gpgmepp is not found, try to use KF5Gpgmepp
  Use Gpgmepp from GpgME-1.7.0

KWayland

  Improved relocatability of CMake export
  [tools] Fix generation of wayland_pointer_p.h
  

Re: Review Request 129400: Avoid potential access of .last() on empty list

[David Edmundson]

> On Nov. 14, 2016, 1:40 p.m., Aleix Pol Gonzalez wrote:
> > src/kpackagetool/kpackagetool.cpp, line 502
> > 
> >
> > Then just change to `QStandardPath::locate`?

Sounds sensible to me. Though I don't really know this code.
Marco, should I do that?


- David


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129400/#review100834
---


On Nov. 14, 2016, 1:35 p.m., David Edmundson wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129400/
> ---
> 
> (Updated Nov. 14, 2016, 1:35 p.m.)
> 
> 
> Review request for KDE Frameworks and Plasma.
> 
> 
> Repository: kpackage
> 
> 
> Description
> ---
> 
> locateAll can return nothing, therefore we can't always call .last() on
> it.
> 
> Existing code should be able to handle an empty package root as the user
> could also also have provided a broken package root as an argument.
> 
> 
> Diffs
> -
> 
>   src/kpackagetool/kpackagetool.cpp 6135e14ba717d579553036f9ed7874813046a1db 
> 
> Diff: https://git.reviewboard.kde.org/r/129400/diff/
> 
> 
> Testing
> ---
> 
> Ran kpackagetool --generate-index -g
> 
> Previously asserted. No longer asserted.
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

Re: Review Request 129405: KCollapsibleGroupBox: don't hide widgets, override focus policy instead

[David Edmundson]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129405/#review100839
---


Fix it, then Ship it!





src/kcollapsiblegroupbox.cpp (line 47)


why int and not Qt::FocusPolicy?

it'll save you casting later.


- David Edmundson


On Nov. 15, 2016, 11:06 a.m., Elvis Angelaccio wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129405/
> ---
> 
> (Updated Nov. 15, 2016, 11:06 a.m.)
> 
> 
> Review request for KDE Frameworks, KDE Usability, Christoph Feck, and David 
> Edmundson.
> 
> 
> Repository: kwidgetsaddons
> 
> 
> Description
> ---
> 
> Currently it's not possible to hide widgets in a KCollapsibleGroupBox, 
> because the groupbox hides all chidren on collapse event and shows them on 
> expand event.
> 
> The rationale was explained in this comment: "when collapsed hide contents to 
> save resources and more importantly get it out the focus chain"
> 
> The focus chain problem can be solved by overriding/restoring the focus 
> policy of children widgets, without changing their visibility.
> 
> 
> Diffs
> -
> 
>   autotests/kcollapsiblegroupbox_test.h 
> b7f538217f480ea48bc28f098c7968fe21dda676 
>   autotests/kcollapsiblegroupbox_test.cpp 
> 4c458c4f700e498c178a637c29d6cc78ab8c267c 
>   src/kcollapsiblegroupbox.cpp 273110e995cb25f28a815cb28125c4678ca2ab28 
>   tests/kcollapsiblegroupboxtest.cpp 5a2900e63e42fa81f909c7d1fff0d07033edb025 
> 
> Diff: https://git.reviewboard.kde.org/r/129405/diff/
> 
> 
> Testing
> ---
> 
> Test app has been expanded with an hidden checkbox
> 
> * Make sure the new checkbox stays hidden after expanding the groupbox.
> * With both groups collapsed, make sure the tab-focus goes from the first 
> group to the second one (skipping the 7 checkboxes in the first group).
> 
> 
> File Attachments
> 
> 
> Before: hidden checkbox is visible
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2016/11/15/25c50bd2-aa00-42ea-b9b5-38f3d1abddff__Spectacle.d20127.png
> After: hidden checkbox is hidden
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2016/11/15/815551e3-9987-4851-8025-50d44989f600__Spectacle.W20858.png
> 
> 
> Thanks,
> 
> Elvis Angelaccio
> 
>

Re: Review Request 129405: KCollapsibleGroupBox: don't hide widgets, override focus policy instead

[Heiko Tietze]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129405/#review100856
---


Ship it!




Looks good from the usability POV, hidden items should kept invisible whether 
or not expanded. 

Some random thoughts: Enabled state should be respected correctly; as you write 
"focus policy" make sure the tab sequence works well. And finally we should 
define a behaviour when all children are hidden: I'd recommend to still show 
the expander and just accept the possible zero content. Alignment is relevant 
too meaning the anchored control must not have a large space to the collapsed 
list with hidden items.

- Heiko Tietze


On Nov. 15, 2016, 11:06 vorm., Elvis Angelaccio wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129405/
> ---
> 
> (Updated Nov. 15, 2016, 11:06 vorm.)
> 
> 
> Review request for KDE Frameworks, KDE Usability, Christoph Feck, and David 
> Edmundson.
> 
> 
> Repository: kwidgetsaddons
> 
> 
> Description
> ---
> 
> Currently it's not possible to hide widgets in a KCollapsibleGroupBox, 
> because the groupbox hides all chidren on collapse event and shows them on 
> expand event.
> 
> The rationale was explained in this comment: "when collapsed hide contents to 
> save resources and more importantly get it out the focus chain"
> 
> The focus chain problem can be solved by overriding/restoring the focus 
> policy of children widgets, without changing their visibility.
> 
> 
> Diffs
> -
> 
>   autotests/kcollapsiblegroupbox_test.h 
> b7f538217f480ea48bc28f098c7968fe21dda676 
>   autotests/kcollapsiblegroupbox_test.cpp 
> 4c458c4f700e498c178a637c29d6cc78ab8c267c 
>   src/kcollapsiblegroupbox.cpp 273110e995cb25f28a815cb28125c4678ca2ab28 
>   tests/kcollapsiblegroupboxtest.cpp 5a2900e63e42fa81f909c7d1fff0d07033edb025 
> 
> Diff: https://git.reviewboard.kde.org/r/129405/diff/
> 
> 
> Testing
> ---
> 
> Test app has been expanded with an hidden checkbox
> 
> * Make sure the new checkbox stays hidden after expanding the groupbox.
> * With both groups collapsed, make sure the tab-focus goes from the first 
> group to the second one (skipping the 7 checkboxes in the first group).
> 
> 
> File Attachments
> 
> 
> Before: hidden checkbox is visible
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2016/11/15/25c50bd2-aa00-42ea-b9b5-38f3d1abddff__Spectacle.d20127.png
> After: hidden checkbox is hidden
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2016/11/15/815551e3-9987-4851-8025-50d44989f600__Spectacle.W20858.png
> 
> 
> Thanks,
> 
> Elvis Angelaccio
> 
>

Re: KDE/Qt Flatpak SDK/Runtime

[Matthias Kuhn]

Hi Aleix,

Thanks for the quick feedback

On 11/15/2016 12:44 AM, Aleix Pol wrote:
> Hi Matthias,
> Really happy to see there's interest!
>
> On Mon, Nov 14, 2016 at 12:44 PM, Matthias Kuhn  wrote:
>> Hi,
>>
>> I'm a developer of QGIS [1] which makes heavy use of Qt libraries. I was
>> very happy to see the work on a KDE flatpak repository which already
>> packages Qt [2].
>>
>> I have recently been looking into a couple of different approaches to
>> ship app bundles and flatpak sounds like a very interesting one.
>>
>> To not duplicate work I would like to ask if there is interest for a
>> collaboration. In particular, for our needs:
>>
>>  * We require the QtLocation module. Are there plans for adding this?
>>I will be happy to share a trivial patch that adds this.
> In general I'd say that this possibly should be part of the
> application, now Qt's cmake scripts have a limitation where they all
> need to be in the same prefix. Because of how Flatpak is put together,
> this means it needs to be in the runtime, if you have a patch please
> send it my way.
Cool, happy to do so as soon as I'm back on my desktop (it's actually a
simple copy-paste of the other recipes, replacing the Qt module with
QtLocation).

>
>>  * We also require other components which are closely related to Qt:
>>Qt Cryptographic Architecture (QCA), QWT, QScintilla, PyQt5, would
>>you be interested in integrating them into this repository as well?
> Few applications need this, I would recommend to get these into the
> application. I know it feels a bit arbitrary, but I wouldn't want to
> get all the dependencies in there, since we'd also lose the grip on
> what we're offering as well.
>
> At the moment what we're putting is Qt, KDE Frameworks and few bits to
> integrate visually with Plasma.
> I guess that there's few additional things that could be included, I
> also see value in 3rd parties using our runtime, but I don't really
> want the runtime to grow beyond usefulness. (I don't know about many
> KDE applications using QWT or QScintilla).

I don't mind too much about QWT or QScintilla, but I think there's quite
a few applications that could be interested in shipping with PyQt as
dependency.

As I wrote before, one other possibility would be to split up the
current KDE runtime into a Qt runtime and a KDE runtime.
On top of the Qt runtime you could build all the common KDE libraries
with bells and whistles (which we don't require on our side) and we
could put our extra libraries into a QtExtras runtime so there's no
reason to ship them along with your runtime.

Do you think that would make maintenance more complicated than necessary
or do you expect other bad side-effects?

Regards
Matthias

>
> Often it's more about just copying the recipes from one application in
> another, that's in part why I took the initial approach of getting all
> recipes in the same repository.
> https://quickgit.kde.org/?p=flatpak-kde-applications.git=tree
>
> Aleix

-- 
Matthias Kuhn
OPENGIS.ch - https://www.opengis.ch
Spatial • (Q)GIS • PostGIS • Open Source




signature.asc
Description: OpenPGP digital signature

Re: Review Request 129396: Allow to read X-KDE-RunOnDiscreteGpu property from desktop file + take this option into account when starting service using KToolInvocation

[Jan Grulich]

> On Lis. 14, 2016, 10:32 odp., David Faure wrote:
> > src/kdeinit/ktoolinvocation.cpp, line 107
> > 
> >
> > Err that's a weird D-Bus name, isn't it? Should this become a 
> > freedesktop standard?
> > Did you talk to hadess about it, before we make it a de-facto standard 
> > with a weird name?
> > 
> > 
> > And then why not standardize the name of the key in the .desktop file 
> > while at it?
> > 
> > x...@freedesktop.org is where to discuss both.
> 
> Jan Grulich wrote:
> I sent him an email and he responded that he is not interested in making 
> this a standard and doesn't consider this as a weird name. If the name 
> changes in future I hope they will at least keep the old service name for 
> backward compatibility, meanwhile I guess we have to keep this name.

After a discussion on #plasma we decided to implement this in powerdevil 
instead so we don't rely on 3rd party tool. Same applies for review 129399.


- Jan


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129396/#review100845
---


On Lis. 15, 2016, 7:58 dop., Jan Grulich wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129396/
> ---
> 
> (Updated Lis. 15, 2016, 7:58 dop.)
> 
> 
> Review request for KDE Frameworks and David Faure.
> 
> 
> Repository: kservice
> 
> 
> Description
> ---
> 
> $SUMMARY says it all I guess, this patch allows to read 
> X-KDE-RunOnDiscreteGpu property which can be now set from KPropertiesDialog, 
> see review 129395. Also when running an application using KToolInvocation 
> (e.g. when running an app from panel or desktop) take this property into 
> account and set required variable accordingly.
> 
> 
> Diffs
> -
> 
>   src/kdeinit/ktoolinvocation.cpp c9eb922 
>   src/services/kservice.h 66525b4 
>   src/services/kservice.cpp 6574367 
> 
> Diff: https://git.reviewboard.kde.org/r/129396/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Jan Grulich
> 
>

Re: Review Request 129405: KCollapsibleGroupBox: don't hide widgets, override focus policy instead

[Elvis Angelaccio]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129405/
---

(Updated Nov. 15, 2016, 11:06 a.m.)


Review request for KDE Frameworks, KDE Usability, Christoph Feck, and David 
Edmundson.


Changes
---

Added screenshots before/after, but they just show that the last checkbox is 
hidden as expected. Unfortunately screenshots cannot catch the focus with the 
Tab key.


Repository: kwidgetsaddons


Description
---

Currently it's not possible to hide widgets in a KCollapsibleGroupBox, because 
the groupbox hides all chidren on collapse event and shows them on expand event.

The rationale was explained in this comment: "when collapsed hide contents to 
save resources and more importantly get it out the focus chain"

The focus chain problem can be solved by overriding/restoring the focus policy 
of children widgets, without changing their visibility.


Diffs
-

  autotests/kcollapsiblegroupbox_test.h 
b7f538217f480ea48bc28f098c7968fe21dda676 
  autotests/kcollapsiblegroupbox_test.cpp 
4c458c4f700e498c178a637c29d6cc78ab8c267c 
  src/kcollapsiblegroupbox.cpp 273110e995cb25f28a815cb28125c4678ca2ab28 
  tests/kcollapsiblegroupboxtest.cpp 5a2900e63e42fa81f909c7d1fff0d07033edb025 

Diff: https://git.reviewboard.kde.org/r/129405/diff/


Testing
---

Test app has been expanded with an hidden checkbox

* Make sure the new checkbox stays hidden after expanding the groupbox.
* With both groups collapsed, make sure the tab-focus goes from the first group 
to the second one (skipping the 7 checkboxes in the first group).


File Attachments (updated)


Before: hidden checkbox is visible
  
https://git.reviewboard.kde.org/media/uploaded/files/2016/11/15/25c50bd2-aa00-42ea-b9b5-38f3d1abddff__Spectacle.d20127.png
After: hidden checkbox is hidden
  
https://git.reviewboard.kde.org/media/uploaded/files/2016/11/15/815551e3-9987-4851-8025-50d44989f600__Spectacle.W20858.png


Thanks,

Elvis Angelaccio

python binding's __init__.py

[Harald Sitter]

Alohas

I am currently trying to package kitemmodels' python bindings. The
module generator installs

-./usr/lib/python2.7/dist-packages/PyKF5/__init__.py
-./usr/lib/python2.7/dist-packages/PyKF5/KItemModels.so

This will cause a fairly shitty problem on packaging level, when a
second framework wants to generate bindings. Both would be installing
__init__.py in the same path, thus conflicting with one another, thus
making the packages not co-installable.

I rather think we need a pykf5 framework which does nothing more than
install an empty __init__.py which will need to be installed to use
any bindings OR change the installation path to fully isolate the
directories PyKF5ItemModels/KItemModels.so.
Latter will make for ugly code on the python side, so I think the
former approach would be the best solution.

HS

Re: Review Request 129405: KCollapsibleGroupBox: don't hide widgets, override focus policy instead

[Heiko Tietze]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129405/#review100850
---



Picture, or it didn't happen :-) (before/after would be nice)

- Heiko Tietze


On Nov. 15, 2016, 9:53 vorm., Elvis Angelaccio wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129405/
> ---
> 
> (Updated Nov. 15, 2016, 9:53 vorm.)
> 
> 
> Review request for KDE Frameworks, KDE Usability, Christoph Feck, and David 
> Edmundson.
> 
> 
> Repository: kwidgetsaddons
> 
> 
> Description
> ---
> 
> Currently it's not possible to hide widgets in a KCollapsibleGroupBox, 
> because the groupbox hides all chidren on collapse event and shows them on 
> expand event.
> 
> The rationale was explained in this comment: "when collapsed hide contents to 
> save resources and more importantly get it out the focus chain"
> 
> The focus chain problem can be solved by overriding/restoring the focus 
> policy of children widgets, without changing their visibility.
> 
> 
> Diffs
> -
> 
>   autotests/kcollapsiblegroupbox_test.h 
> b7f538217f480ea48bc28f098c7968fe21dda676 
>   autotests/kcollapsiblegroupbox_test.cpp 
> 4c458c4f700e498c178a637c29d6cc78ab8c267c 
>   src/kcollapsiblegroupbox.cpp 273110e995cb25f28a815cb28125c4678ca2ab28 
>   tests/kcollapsiblegroupboxtest.cpp 5a2900e63e42fa81f909c7d1fff0d07033edb025 
> 
> Diff: https://git.reviewboard.kde.org/r/129405/diff/
> 
> 
> Testing
> ---
> 
> Test app has been expanded with an hidden checkbox
> 
> * Make sure the new checkbox stays hidden after expanding the groupbox.
> * With both groups collapsed, make sure the tab-focus goes from the first 
> group to the second one (skipping the 7 checkboxes in the first group).
> 
> 
> Thanks,
> 
> Elvis Angelaccio
> 
>

Re: Review Request 129396: Allow to read X-KDE-RunOnDiscreteGpu property from desktop file + take this option into account when starting service using KToolInvocation

[Jan Grulich]

> On Lis. 14, 2016, 10:32 odp., David Faure wrote:
> > src/kdeinit/ktoolinvocation.cpp, line 107
> > 
> >
> > Err that's a weird D-Bus name, isn't it? Should this become a 
> > freedesktop standard?
> > Did you talk to hadess about it, before we make it a de-facto standard 
> > with a weird name?
> > 
> > 
> > And then why not standardize the name of the key in the .desktop file 
> > while at it?
> > 
> > x...@freedesktop.org is where to discuss both.

I sent him an email and he responded that he is not interested in making this a 
standard and doesn't consider this as a weird name. If the name changes in 
future I hope they will at least keep the old service name for backward 
compatibility, meanwhile I guess we have to keep this name.


- Jan


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129396/#review100845
---


On Lis. 15, 2016, 7:58 dop., Jan Grulich wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129396/
> ---
> 
> (Updated Lis. 15, 2016, 7:58 dop.)
> 
> 
> Review request for KDE Frameworks and David Faure.
> 
> 
> Repository: kservice
> 
> 
> Description
> ---
> 
> $SUMMARY says it all I guess, this patch allows to read 
> X-KDE-RunOnDiscreteGpu property which can be now set from KPropertiesDialog, 
> see review 129395. Also when running an application using KToolInvocation 
> (e.g. when running an app from panel or desktop) take this property into 
> account and set required variable accordingly.
> 
> 
> Diffs
> -
> 
>   src/kdeinit/ktoolinvocation.cpp c9eb922 
>   src/services/kservice.h 66525b4 
>   src/services/kservice.cpp 6574367 
> 
> Diff: https://git.reviewboard.kde.org/r/129396/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Jan Grulich
> 
>

Re: Review Request 129405: KCollapsibleGroupBox: don't hide widgets, override focus policy instead

[Elvis Angelaccio]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129405/
---

(Updated Nov. 15, 2016, 9:53 a.m.)


Review request for KDE Frameworks, KDE Usability, Christoph Feck, and David 
Edmundson.


Changes
---

Also add unit test.


Repository: kwidgetsaddons


Description
---

Currently it's not possible to hide widgets in a KCollapsibleGroupBox, because 
the groupbox hides all chidren on collapse event and shows them on expand event.

The rationale was explained in this comment: "when collapsed hide contents to 
save resources and more importantly get it out the focus chain"

The focus chain problem can be solved by overriding/restoring the focus policy 
of children widgets, without changing their visibility.


Diffs (updated)
-

  autotests/kcollapsiblegroupbox_test.h 
b7f538217f480ea48bc28f098c7968fe21dda676 
  autotests/kcollapsiblegroupbox_test.cpp 
4c458c4f700e498c178a637c29d6cc78ab8c267c 
  src/kcollapsiblegroupbox.cpp 273110e995cb25f28a815cb28125c4678ca2ab28 
  tests/kcollapsiblegroupboxtest.cpp 5a2900e63e42fa81f909c7d1fff0d07033edb025 

Diff: https://git.reviewboard.kde.org/r/129405/diff/


Testing
---

Test app has been expanded with an hidden checkbox

* Make sure the new checkbox stays hidden after expanding the groupbox.
* With both groups collapsed, make sure the tab-focus goes from the first group 
to the second one (skipping the 7 checkboxes in the first group).


Thanks,

Elvis Angelaccio