KDE CI: Frameworks ktexteditor kf5-qt5 FreeBSDQt5.9 - Build # 23 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20ktexteditor%20kf5-qt5%20FreeBSDQt5.9/23/ Project: Frameworks ktexteditor kf5-qt5 FreeBSDQt5.9 Date of build: Sun, 04 Feb 2018 04:15:55 + Build duration: 39 min and counting JUnit Tests

KDE CI: Frameworks plasma-framework kf5-qt5 FreeBSDQt5.9 - Build # 34 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20FreeBSDQt5.9/34/ Project: Frameworks plasma-framework kf5-qt5 FreeBSDQt5.9 Date of build: Sun, 04 Feb 2018 04:16:09 + Build duration: 36 min and counting

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.7 - Build # 111 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.7/111/ Project: Frameworks kio kf5-qt5 SUSEQt5.7 Date of build: Sun, 04 Feb 2018 04:15:36 + Build duration: 35 min and counting JUnit Tests Name: (root)

KDE CI: Frameworks ktexteditor kf5-qt5 SUSEQt5.10 - Build # 37 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20ktexteditor%20kf5-qt5%20SUSEQt5.10/37/ Project: Frameworks ktexteditor kf5-qt5 SUSEQt5.10 Date of build: Sun, 04 Feb 2018 04:15:55 + Build duration: 29 min and counting JUnit Tests

KDE CI: Frameworks krunner kf5-qt5 SUSEQt5.7 - Build # 15 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20krunner%20kf5-qt5%20SUSEQt5.7/15/ Project: Frameworks krunner kf5-qt5 SUSEQt5.7 Date of build: Sun, 04 Feb 2018 04:15:46 + Build duration: 23 min and counting JUnit Tests Name:

KDE CI: Frameworks krunner kf5-qt5 FreeBSDQt5.9 - Build # 7 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20krunner%20kf5-qt5%20FreeBSDQt5.9/7/ Project: Frameworks krunner kf5-qt5 FreeBSDQt5.9 Date of build: Sun, 04 Feb 2018 04:15:46 + Build duration: 23 min and counting JUnit Tests Name:

KDE CI: Frameworks plasma-framework kf5-qt5 SUSEQt5.7 - Build # 61 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20SUSEQt5.7/61/ Project: Frameworks plasma-framework kf5-qt5 SUSEQt5.7 Date of build: Sun, 04 Feb 2018 04:16:09 + Build duration: 21 min and counting JUnit

KDE CI: Frameworks kio kf5-qt5 FreeBSDQt5.9 - Build # 92 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20FreeBSDQt5.9/92/ Project: Frameworks kio kf5-qt5 FreeBSDQt5.9 Date of build: Sun, 04 Feb 2018 04:15:36 + Build duration: 20 min and counting JUnit Tests Name: (root)

KDE CI: Frameworks ktexteditor kf5-qt5 SUSEQt5.7 - Build # 38 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20ktexteditor%20kf5-qt5%20SUSEQt5.7/38/ Project: Frameworks ktexteditor kf5-qt5 SUSEQt5.7 Date of build: Sun, 04 Feb 2018 04:15:55 + Build duration: 18 min and counting JUnit Tests

KDE CI: Frameworks plasma-framework kf5-qt5 SUSEQt5.10 - Build # 58 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20SUSEQt5.10/58/ Project: Frameworks plasma-framework kf5-qt5 SUSEQt5.10 Date of build: Sun, 04 Feb 2018 04:16:09 + Build duration: 12 min and counting JUnit

KDE CI: Frameworks krunner kf5-qt5 SUSEQt5.10 - Build # 15 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20krunner%20kf5-qt5%20SUSEQt5.10/15/ Project: Frameworks krunner kf5-qt5 SUSEQt5.10 Date of build: Sun, 04 Feb 2018 04:15:46 + Build duration: 3 min 42 sec and counting JUnit Tests

KDE CI: Frameworks kcoreaddons kf5-qt5 SUSEQt5.10 - Build # 41 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kcoreaddons%20kf5-qt5%20SUSEQt5.10/41/ Project: Frameworks kcoreaddons kf5-qt5 SUSEQt5.10 Date of build: Sun, 04 Feb 2018 02:18:50 + Build duration: 5 min 15 sec and counting JUnit Tests

KDE CI: Frameworks kcoreaddons kf5-qt5 SUSEQt5.7 - Build # 36 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kcoreaddons%20kf5-qt5%20SUSEQt5.7/36/ Project: Frameworks kcoreaddons kf5-qt5 SUSEQt5.7 Date of build: Sun, 04 Feb 2018 02:18:50 + Build duration: 4 min 25 sec and counting JUnit Tests

KDE CI: Frameworks kcoreaddons kf5-qt5 FreeBSDQt5.9 - Build # 25 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kcoreaddons%20kf5-qt5%20FreeBSDQt5.9/25/ Project: Frameworks kcoreaddons kf5-qt5 FreeBSDQt5.9 Date of build: Sun, 04 Feb 2018 02:18:51 + Build duration: 3 min 51 sec and counting JUnit

D10286: Fix C# var regex

wesdawg edited the summary of this revision. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D10286 To: wesdawg, #framework_syntax_highlighting Cc: #frameworks, #framework_syntax_highlighting, michaelh, genethomas, ngraham, cullmann, vkrause, dhaumann

D10286: Fix C# var regex

wesdawg created this revision. wesdawg added a reviewer: Framework: Syntax Highlighting. wesdawg created this object with visibility "All Users". wesdawg added a project: Framework: Syntax Highlighting. Restricted Application added a project: Frameworks. Restricted Application added a subscriber:

KDE CI: Frameworks kio kf5-qt5 FreeBSDQt5.9 - Build # 91 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20FreeBSDQt5.9/91/ Project: Frameworks kio kf5-qt5 FreeBSDQt5.9 Date of build: Sat, 03 Feb 2018 23:37:15 + Build duration: 11 min and counting JUnit Tests Name: (root)

D10282: Use the destination KFileItem object to figure out of it's writable instead of creating a KFileItemListProperties which basically does the same thing but more expensive.

This revision was automatically updated to reflect the committed changes. Closed by commit R241:68a832c9e2aa: Use the destination KFileItem object to figure out of its writable instead of… (authored by markg). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE

D10282: Use the destination KFileItem object to figure out of it's writable instead of creating a KFileItemListProperties which basically does the same thing but more expensive.

ngraham accepted this revision. This revision is now accepted and ready to land. REPOSITORY R241 KIO BRANCH kfileitemproperties_optimization REVISION DETAIL https://phabricator.kde.org/D10282 To: markg, dfaure, ngraham Cc: ngraham, #frameworks, michaelh

D10282: Use the destination KFileItem object to figure out of it's writable instead of creating a KFileItemListProperties which basically does the same thing but more expensive.

markg created this revision. markg added a reviewer: dfaure. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. markg requested review of this revision. REVISION SUMMARY Use KFileItem::isWritable instead of the detour with

Re: Adding application to KDE and getting image of current

What refactoring? Just add a separate window for editiong annotations and a small "Edit" button to the bottom row, that opens this separate window. I had some work in progress in this direction, but currently lacking time to finish it... 2018-02-03 23:15 GMT+03:00 Damir Porobic

Re: Babe project - Legal feedback

I will get in touch with the kde e.v. I just want to make clear that I wouldn't implement such system without discussing it beforehand with the community. This is just an open discussion I wanted to have to get feedback. The platform I'm working on so far has nothing to be sorry about, legally.

Re: Babe project - Legal feedback

El dissabte, 3 de febrer de 2018, a les 21:26:24 CET, Nicolás Alvarez va escriure: > 2018-02-03 17:07 GMT-03:00 Albert Astals Cid : > > El dissabte, 3 de febrer de 2018, a les 18:07:27 CET, Camilo Higuita > > Rodriguez> > > va escriure: > >> Hi,everyone > >> > >> I'd like to

Re: Adding application to KDE and getting image of current

Not only android, but for plasma mobile, and there's a lot more than just take a screenshot of the whole application, for example: Add text over a screenshot or stickers to... Select a rectangle section instead of the whole screen If a screenshot of a selected part is text in a image, save

Re: Adding application to KDE and getting image of current

Camilo Higuita Rodriguez ha scritto: > Excuse mentioned jump into the conversation out of the blue. > > Something that would be really cool is to refactor spectacle or ksnip to make > use of qqc2 with Kirigami pointing to plans mobile too.  > If that were the case and you feel interested I could

Re: Adding application to KDE and getting image of current

Excuse mentioned jump into the conversation out of the blue. Something that would be really cool is to refactor spectacle or ksnip to make use of qqc2 with Kirigami pointing to plans mobile too. If that were the case and you feel interested I could jump in and help. Camilo On Feb 3, 2018 3:23

Re: Babe project - Legal feedback

On February 3, 2018 at 1:19:33 PM, Camilo Higuita Rodriguez ( chigui...@unal.edu.co) wrote: My case is the following, let's say that there's a feature for streaming audio, and the users stream the song they are listening to, what would go down in that case? Who's in legal troubles? Also if I

Re: Adding application to KDE and getting image of current

Thanks so much for understanding! Spectacle currently has no formal maintainer, but myself and a few others are serving this role in a de facto capacity. The Spectacle Phabricator project (https://phabricator.kde.org/project/view/78/) would be a good place to coordinate. We would welcome a

Re: Babe project - Legal feedback

My case is the following, let's say that there's a feature for streaming audio, and the users stream the song they are listening to, what would go down in that case? Who's in legal troubles? Also if I were to send an mp3 over email to a few friends, where's the illegal stand point there? The

Re: Babe project - Legal feedback

On February 3, 2018 at 1:08:06 PM, Albert Astals Cid (aa...@kde.org) wrote: El dissabte, 3 de febrer de 2018, a les 18:07:27 CET, Camilo Higuita Rodriguez va escriure: > Hi,everyone > > I'd like to discuss something with the community, and maybe get some legal > input: > > As some of you might

Re: Adding application to KDE and getting image of current

I do see your point here and it indeed makes sense. I could invest some time and add the annotation features (and eventually other stuff) to Spectacle. The lack of those features is actually the reason why we're having this discussion, so it would make sense to resolve them. Does Spectacle have

Re: Babe project - Legal feedback

Reproducing, publicly performing or redistributing a copyrighted work without a license is illegal almost everywhere (China/Russia/etc. may be exceptions).  RIP The Pirate Pay, Megaupload, etc.  Not that some folks haven't made a ton of money doing it anyway until a crack-down.  Andreas

Re: Babe project - Legal feedback

Hello Camilo, Not a lawyer either and you would need confirmation from a legal expert, but you questions are not hard: > 1- I would like to either have the option to *stream live* the music an > user is currently listening to to a group of friends. here the music file > isn't being storaged in

Re: Babe project - Legal feedback

El dissabte, 3 de febrer de 2018, a les 18:07:27 CET, Camilo Higuita Rodriguez va escriure: > Hi,everyone > > I'd like to discuss something with the community, and maybe get some legal > input: > > As some of you might already know I'm working on a open online platform to > share music

D10279: add 24px media-album-cover icon

ngraham added reviewers: VDG, andreaska. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D10279 To: astippich, #breeze, #vdg, andreaska Cc: ngraham, #frameworks, michaelh

D10279: add 24px media-album-cover icon

astippich added a comment. It just adds a missing link to an already existing icon, is a screenshot needed? REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D10279 To: astippich, #breeze Cc: ngraham, #frameworks, michaelh

Re: Adding application to KDE and getting image of current

Am 2018-02-03 20:36, schrieb Nate Graham: I know, my answer sucks. I really do hate to have to bring it up. And I don't mean to throw cold water on your project or your enthusiasm! KSnip looks cool. The thing is, single-developer projects tend to have a predictable lifecycle: lots of energy and

D10205: fileindexerconfig: Introduce canBeSearched()

ngraham accepted this revision as: Baloo, ngraham. This revision is now accepted and ready to land. REPOSITORY R293 Baloo BRANCH search (branched from master) REVISION DETAIL https://phabricator.kde.org/D10205 To: michaelh, #frameworks, #dolphin, #baloo, mgallien, ngraham Cc:

D10279: add 24px media-album-cover icon

ngraham added a comment. Before-and-after screenshots? REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D10279 To: astippich, #breeze Cc: ngraham, #frameworks, michaelh

D10279: add 24px media-album-cover icon

astippich created this revision. astippich added a reviewer: Breeze. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. astippich requested review of this revision. REVISION SUMMARY media-album-cover icon is missing for the 24px size,

Re: Babe project - Legal feedback

Am 2018-02-03 18:07, schrieb Camilo Higuita Rodriguez: Hi,everyone I'd like to discuss something with the community, and maybe get some legal input: As some of you might already know I'm working on a open online platform to share music information between users, such as public playlists,

D10113: baloo-widgets: Emit metaDataRequestFinished once per request

ngraham accepted this revision. REPOSITORY R824 Baloo Widgets BRANCH signalavailable (branched from master) REVISION DETAIL https://phabricator.kde.org/D10113 To: michaelh, elvisangelaccio, smithjd, vhanda, ngraham, #dolphin, #frameworks Cc: dhaumann

Re: Adding application to KDE and getting image of current

I know, my answer sucks. I really do hate to have to bring it up. And I don't mean to throw cold water on your project or your enthusiasm! KSnip looks cool. The thing is, single-developer projects tend to have a predictable lifecycle: lots of energy and progress in the beginning, then around

D9672: Don't emit error signal before we tried all list commands.

wcpan updated this revision to Diff 26460. wcpan added a comment. Don't emit error signal before we tried all list commands. Use a special error code to skip error reporting. REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9672?vs=24747=26460 BRANCH

D10278: Do not emit error until all commands have been tried.

wcpan created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. wcpan requested review of this revision. REPOSITORY R241 KIO BRANCH fix-ftp-list REVISION DETAIL https://phabricator.kde.org/D10278 AFFECTED FILES

Re: Babe project - Legal feedback

Hey Camilo, not an expert but I recommend you to ask a lawyer. Just think of Youtube: There are different viewing restrictions depending on the country you are living in. Maybe streaming audio is equal... You could also ask the streaming service providers how to proceed... Cheers, Christian Am

D10273: Create proper SocketAddress

chinmoyr added a comment. In https://phabricator.kde.org/D10273#200254, @thiago wrote: > That doesn't make sense. There's QFile::encodeName in the code I was talking talking about FdSender which is used only in kauth helper. REPOSITORY R241 KIO REVISION DETAIL

D10273: Create proper SocketAddress

thiago added a comment. That doesn't make sense. There's QFile::encodeName in the code. Is there a section of the library that is used in elevated privilege code, but not all of it? REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D10273 To: chinmoyr, #frameworks

Re: Adding application to KDE and getting image of current

Yeah, I was kind of afraid that you would say that. When I started to work on the project I hadn't thought about extending any other projects, mostly due to my limited knowledge of Qt at that time. Now I have invested a lot of time and effort into this project and it seems to be working fine

D10113: baloo-widgets: Emit metaDataRequestFinished once per request

elvisangelaccio accepted this revision as: elvisangelaccio. This revision is now accepted and ready to land. REPOSITORY R824 Baloo Widgets BRANCH signalavailable (branched from master) REVISION DETAIL https://phabricator.kde.org/D10113 To: michaelh, elvisangelaccio, smithjd, vhanda,

D10273: Create proper SocketAddress

chinmoyr added inline comments. INLINE COMMENTS > thiago wrote in fdsender.cpp:24 > The problem here is the API. Why is it using std::string in the first place? The idea was to use std c++ and avoid qt throughout the class because the code will be executed with elevated privileges. REPOSITORY

D10273: Create proper SocketAddress

thiago added a comment. Looks good. INLINE COMMENTS > fdsender.cpp:24 > > FdSender::FdSender(const std::string ) > : m_socketDes(-1) The problem here is the API. Why is it using std::string in the first place? REPOSITORY R241 KIO REVISION DETAIL

D9966: [KIO] Fix issues with sharing of file descriptor

chinmoyr added inline comments. INLINE COMMENTS > thiago wrote in fdreceiver.cpp:88 > __APPLE__ is there. My question is about OpenBSD, NetBSD and DragonflyBSD. > Are you breaking them? You may not know the answer, but you need to document > the issue if you intentionally cause a Failure To

D9966: [KIO] Fix issues with sharing of file descriptor

thiago added a comment. The patch that I can see accomplishes what the description says it should do. And I agree with the idea of the patch. INLINE COMMENTS > dfaure wrote in fdreceiver.cpp:88 > This is UNIX-only, but indeed OSX is missing. Does that support getpeereid? __APPLE__ is

D8056: Improve usability of "Open With" dialog by adding option to filter the application tree

ngraham added a comment. Needs a rebase on top of master, FWIW. Can't wait to have this! REPOSITORY R241 KIO BRANCH openwithdialog-filter-app-tree REVISION DETAIL https://phabricator.kde.org/D8056 To: simgunz, dfaure, #frameworks, #vdg, ngraham, rkflx Cc: rkflx, romangg, fabianr,

D10273: Create proper SocketAddress

chinmoyr updated this revision to Diff 26451. chinmoyr added a comment. Fixed buffer overflow. REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10273?vs=26445=26451 BRANCH master REVISION DETAIL https://phabricator.kde.org/D10273 AFFECTED FILES

Re: Adding application to KDE and getting image of current

I love the idea of annotations built into a screenshot tool! Our users have been asking for this. However, I hate to be that guy, but have you considered extending Spectacle instead? Spectacle is mature, well-integrated into KDE Plasma, has all the features highlighted on

D10273: Create proper SocketAddress

ossi added inline comments. INLINE COMMENTS > sharefd_p.h:61 > +const size_t pathSize = finalPath.size(); > +if (pathSize > 5 && pathSize < sizeof(a.sun_path) - 1) { > #ifdef __linux__ you now have a buffer overflow on linux. you need to split the conditional. REPOSITORY

Babe project - Legal feedback

Hi,everyone I'd like to discuss something with the community, and maybe get some legal input: As some of you might already know I'm working on a open online platform to share music information between users, such as public playlists, comments on tracks and on the playback progress like

D9966: [KIO] Fix issues with sharing of file descriptor

chinmoyr edited the summary of this revision. REPOSITORY R241 KIO BRANCH master REVISION DETAIL https://phabricator.kde.org/D9966 To: chinmoyr, #frameworks, thiago, dfaure, ossi Cc: ngraham, fvogt, lbeltrame, dfaure, michaelh

D9966: [KIO] Fix issues with sharing of file descriptor

chinmoyr updated this revision to Diff 26446. chinmoyr added a comment. Moved changes related to SocketAddress to https://phabricator.kde.org/D10273. Changed #error to #warning. So even if an OS does not have getpeereid or getsockopt compilation will still succeed but copying files will

D10273: Create proper SocketAddress

chinmoyr updated this revision to Diff 26445. chinmoyr added a comment. Check for null byte at index 1 in case of returning address length on linux. Use size of finalPath as pathSize. REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10273?vs=26443=26445

D10273: Create proper SocketAddress

chinmoyr updated this revision to Diff 26443. chinmoyr added a comment. Fixed typos REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10273?vs=26441=26443 BRANCH master REVISION DETAIL https://phabricator.kde.org/D10273 AFFECTED FILES

D10273: Create proper SocketAddress

chinmoyr updated this revision to Diff 26441. chinmoyr added a comment. Used QByteArray in FdSender Undoed behavioral changes. REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10273?vs=26438=26441 BRANCH master REVISION DETAIL

D10273: Create proper SocketAddress

ossi added inline comments. INLINE COMMENTS > fdsender.cpp:27 > { > +SocketAddress addr(path.c_str()); > +if (!addr.address()) { this actually constructs a qbytearray. that should be probably explicit. a better approach would be moving the class' interface to qbytearray (or actually

D10273: Create proper SocketAddress

chinmoyr updated this revision to Diff 26438. chinmoyr added a comment. Corrected number of bytes to be copied. Added unlink(). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10273?vs=26436=26438 BRANCH master REVISION DETAIL

D10273: Create proper SocketAddress

ossi added inline comments. INLINE COMMENTS > chinmoyr wrote in sharefd_p.h:60 > I just feel like the job of SocketAddress should be to create the address > structure and not perform any file operation. Removal of the socket file > should be handled by file ioslave or FdReceiver. that's a

D10273: Create proper SocketAddress

chinmoyr marked 2 inline comments as not done. chinmoyr added inline comments. INLINE COMMENTS > ossi wrote in sharefd_p.h:60 > you still need to address that *somehow* ;) I just feel like the job of SocketAddress should be to create the address structure and not perform any file operation.

D10273: Create proper SocketAddress

ossi added inline comments. INLINE COMMENTS > sharefd_p.h:60 > -::strcpy(a.sun_path, finalPath.c_str()); > -::unlink(finalPath.c_str()); > -#endif you still need to address that *somehow* ;) > sharefd_p.h:61 > +if (pathSize > 0 && pathSize < sizeof(a.sun_path) - 1) { >

D10273: Create proper SocketAddress

chinmoyr updated this revision to Diff 26436. chinmoyr marked 3 inline comments as done. chinmoyr added a comment. Added space on correct side of & and on either sides of binary operators. Used memcpy. Restored original position of data member. REPOSITORY R241 KIO CHANGES SINCE LAST

D10273: Create proper SocketAddress

ossi added inline comments. INLINE COMMENTS > fdreceiver.h:45 > +QString m_path; > +QSocketNotifier *m_readNotifier; > }; why are you moving the member? it doesn't matter in this case, but generally it's better to have the bigger members first, concentrating in particular on equal

D10273: Create proper SocketAddress

chinmoyr created this revision. chinmoyr added a reviewer: Frameworks. Restricted Application added a project: Frameworks. chinmoyr requested review of this revision. REVISION SUMMARY This patch changes SocketAddress class to create an address structure for a pathname socket (on all

D8056: Improve usability of "Open With" dialog by adding option to filter the application tree

rkflx added a comment. In https://phabricator.kde.org/D8056#200013, @simgunz wrote: > I cannot push so someone needs to do it for me. No problem, I can do it for you. REPOSITORY R241 KIO BRANCH openwithdialog-filter-app-tree REVISION DETAIL

D10245: Add more default user locations to Places model/panel

rkflx added a comment. @spoorun You make it sound like the sidebar is the only way to access those folders. That's not true: The file dialog opens in "Home" by default, where you can directly click on Pictures and the other folders anyway. Regarding not adapting the file dialog to

KDE CI: Frameworks kwidgetsaddons kf5-qt5 SUSEQt5.7 - Build # 23 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20kwidgetsaddons%20kf5-qt5%20SUSEQt5.7/23/ Project: Frameworks kwidgetsaddons kf5-qt5 SUSEQt5.7 Date of build: Sat, 03 Feb 2018 13:06:20 + Build duration: 3 min 45 sec and counting JUnit

KDE CI: Frameworks kwidgetsaddons kf5-qt5 FreeBSDQt5.9 - Build # 16 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20kwidgetsaddons%20kf5-qt5%20FreeBSDQt5.9/16/ Project: Frameworks kwidgetsaddons kf5-qt5 FreeBSDQt5.9 Date of build: Sat, 03 Feb 2018 13:04:43 + Build duration: 3 min 23 sec and counting

KDE CI: Frameworks kwidgetsaddons kf5-qt5 SUSEQt5.7 - Build # 22 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kwidgetsaddons%20kf5-qt5%20SUSEQt5.7/22/ Project: Frameworks kwidgetsaddons kf5-qt5 SUSEQt5.7 Date of build: Sat, 03 Feb 2018 12:59:07 + Build duration: 7 min 11 sec and counting JUnit

KDE CI: Frameworks kwidgetsaddons kf5-qt5 SUSEQt5.10 - Build # 24 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20kwidgetsaddons%20kf5-qt5%20SUSEQt5.10/24/ Project: Frameworks kwidgetsaddons kf5-qt5 SUSEQt5.10 Date of build: Sat, 03 Feb 2018 13:03:07 + Build duration: 2 min 23 sec and counting JUnit

KDE CI: Frameworks kwidgetsaddons kf5-qt5 FreeBSDQt5.9 - Build # 15 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kwidgetsaddons%20kf5-qt5%20FreeBSDQt5.9/15/ Project: Frameworks kwidgetsaddons kf5-qt5 FreeBSDQt5.9 Date of build: Sat, 03 Feb 2018 12:59:07 + Build duration: 5 min 31 sec and counting

KDE CI: Frameworks kwidgetsaddons kf5-qt5 SUSEQt5.10 - Build # 23 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kwidgetsaddons%20kf5-qt5%20SUSEQt5.10/23/ Project: Frameworks kwidgetsaddons kf5-qt5 SUSEQt5.10 Date of build: Sat, 03 Feb 2018 12:59:07 + Build duration: 3 min 59 sec and counting JUnit

D9966: [KIO] Fix issues with sharing of file descriptor

dfaure added a comment. Right, the port to QByteArray could be splitted out of this socket security fix commit. REPOSITORY R241 KIO BRANCH master REVISION DETAIL https://phabricator.kde.org/D9966 To: chinmoyr, #frameworks, thiago, dfaure, ossi Cc: ngraham, fvogt, lbeltrame, dfaure,

Re: Adding application to KDE and getting image of current

The link that gives a hint on what needs to be done is under the "Incubated Projects" section, I've expected it under "Incubation Process".   I've created a page based on the template and added a link to "Incubated Projects" under "Candidates", don't know if I was supposed to do that or someone

D10261: Use the KFileItemListProperties copy constructor instead of the conversion from KFileItemList to KFileItemListProperties. This saves re-evaluating all items.

This revision was automatically updated to reflect the committed changes. Closed by commit R241:32b3bbcd16fd: Use the KFileItemListProperties copy constructor instead of the conversion from… (authored by markg). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE

D10261: Use the KFileItemListProperties copy constructor instead of the conversion from KFileItemList to KFileItemListProperties. This saves re-evaluating all items.

jtamate accepted this revision. This revision is now accepted and ready to land. REPOSITORY R241 KIO BRANCH KFileItemListProperties_stage2 REVISION DETAIL https://phabricator.kde.org/D10261 To: markg, dfaure, jtamate Cc: #frameworks, michaelh, ngraham

D10257: KUrlMimeData: fix handling of PreferLocalUrls

jtamate accepted this revision. jtamate added a comment. Looks good (and symmetric). Is it difficult to create a new test? REPOSITORY R244 KCoreAddons BRANCH master REVISION DETAIL https://phabricator.kde.org/D10257 To: dfaure, mwolff, jtamate, markg Cc: markg, ngraham,

D9966: [KIO] Fix issues with sharing of file descriptor

ossi added a comment. In https://phabricator.kde.org/D9966#199979, @dfaure wrote: > Thiago: now it's ready for your review ;) if he wants to look past the already pointed out non-atomicity. i for one just refuse to look at this mess any further.

KDE CI: Frameworks kwidgetsaddons kf5-qt5 SUSEQt5.7 - Build # 21 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kwidgetsaddons%20kf5-qt5%20SUSEQt5.7/21/ Project: Frameworks kwidgetsaddons kf5-qt5 SUSEQt5.7 Date of build: Sat, 03 Feb 2018 11:22:14 + Build duration: 20 min and counting JUnit Tests

KDE CI: Frameworks kdelibs4support kf5-qt5 SUSEQt5.10 - Build # 25 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kdelibs4support%20kf5-qt5%20SUSEQt5.10/25/ Project: Frameworks kdelibs4support kf5-qt5 SUSEQt5.10 Date of build: Sat, 03 Feb 2018 11:12:59 + Build duration: 28 min and counting JUnit

D8056: Improve usability of "Open With" dialog by adding option to filter the application tree

simgunz added a comment. Good! I cannot push so someone needs to do it for me. Soon, I'll have more free time, and I'll try to polish the code (remove fetch more, use Qt 5.10 recursive filtering). REPOSITORY R241 KIO BRANCH openwithdialog-filter-app-tree REVISION DETAIL

KDE CI: Frameworks kdelibs4support kf5-qt5 SUSEQt5.7 - Build # 26 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kdelibs4support%20kf5-qt5%20SUSEQt5.7/26/ Project: Frameworks kdelibs4support kf5-qt5 SUSEQt5.7 Date of build: Sat, 03 Feb 2018 11:12:59 + Build duration: 18 min and counting JUnit Tests

D8056: Improve usability of "Open With" dialog by adding option to filter the application tree

dfaure accepted this revision. dfaure added a comment. This revision is now accepted and ready to land. Thanks, looks ok to me now. Well, all that code about incremental fetching (canFetchMore/fetchMore) only to then fetch everything upfront, could be simplified to just create the full

KDE CI: Frameworks kwidgetsaddons kf5-qt5 SUSEQt5.10 - Build # 22 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kwidgetsaddons%20kf5-qt5%20SUSEQt5.10/22/ Project: Frameworks kwidgetsaddons kf5-qt5 SUSEQt5.10 Date of build: Sat, 03 Feb 2018 11:22:14 + Build duration: 3 min 8 sec and counting JUnit

KDE CI: Frameworks kwidgetsaddons kf5-qt5 FreeBSDQt5.9 - Build # 14 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kwidgetsaddons%20kf5-qt5%20FreeBSDQt5.9/14/ Project: Frameworks kwidgetsaddons kf5-qt5 FreeBSDQt5.9 Date of build: Sat, 03 Feb 2018 11:22:14 + Build duration: 2 min 56 sec and counting

KDE CI: Frameworks kdelibs4support kf5-qt5 FreeBSDQt5.9 - Build # 20 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kdelibs4support%20kf5-qt5%20FreeBSDQt5.9/20/ Project: Frameworks kdelibs4support kf5-qt5 FreeBSDQt5.9 Date of build: Sat, 03 Feb 2018 11:12:59 + Build duration: 8 min 34 sec and counting

D9966: [KIO] Fix issues with sharing of file descriptor

dfaure added a comment. Thanks, looks ok to me now. Thiago: now it's ready for your review ;) REPOSITORY R241 KIO BRANCH master REVISION DETAIL https://phabricator.kde.org/D9966 To: chinmoyr, #frameworks, thiago, dfaure, ossi Cc: ngraham, fvogt, lbeltrame, dfaure, michaelh

D9966: [KIO] Fix issues with sharing of file descriptor

chinmoyr updated this revision to Diff 26421. chinmoyr added a comment. 1. Used QByteArray in SocketAddress. 2. Rearranged members of FdReceiver. 3. Removed changes not directly related to these fixes. REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE

D9966: [KIO] Fix issues with sharing of file descriptor

chinmoyr reopened this revision. This revision is now accepted and ready to land. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D9966 To: chinmoyr, #frameworks, thiago, dfaure, ossi Cc: ngraham, fvogt, lbeltrame, dfaure, michaelh

KDE CI: Frameworks kio kf5-qt5 FreeBSDQt5.9 - Build # 89 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20FreeBSDQt5.9/89/ Project: Frameworks kio kf5-qt5 FreeBSDQt5.9 Date of build: Sat, 03 Feb 2018 10:37:13 + Build duration: 12 min and counting JUnit Tests Name: (root)

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.7 - Build # 107 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.7/107/ Project: Frameworks kio kf5-qt5 SUSEQt5.7 Date of build: Sat, 03 Feb 2018 10:18:43 + Build duration: 20 min and counting JUnit Tests Name: (root)

D10266: Improve error handling in file ioslave

This revision was automatically updated to reflect the committed changes. Closed by commit R241:27aa3764c0bf: Improve error handling in file ioslave (authored by chinmoyr). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10266?vs=26417=26420 REVISION DETAIL

  1   2   >