Re: Is there (going to be) an auto-retracer service for KDE?

On Tue, Apr 27, 2021 at 2:16 PM Halla Rempt wrote: > > On Monday, 26 April 2021 13:07:17 CEST Harald Sitter wrote: > > Also going off on a tangent: On windows I understand the store already > > has crash tracking and all that stuff implemented, I expect the same > >

Re: Is there (going to be) an auto-retracer service for KDE?

On Mon, Apr 26, 2021 at 12:34 PM Halla Rempt wrote: > > On Monday, 26 April 2021 11:26:38 CEST Harald Sitter wrote: > > * get a core instead of a trace - sounds simpler than it is because > > cores can be huge and network speed may be limited. google's breakpad > > has a

Re: Is there (going to be) an auto-retracer service for KDE?

On Sun, Apr 25, 2021 at 10:38 PM Albert Astals Cid wrote: > KDE can't do retracing because KDE hasn't built the packages people use > (except KDE Neon). I've mused on this in the past and I think it can be done, it's just a lot of work that in particular also will need to involve some web

Re: Including instead of , does it upset POSIX?

at header, but are all > * contained in the namespace @c std (except for names which are defined > * as macros in C). > */ > > > And then I made similar commits to a lot of the other Frameworks (not all, > since the build failed > for some of them, so I left them alone)

Re: Including instead of , does it upset POSIX?

FWIW this goes beyond errno. See clang-tidy's modernize-deprecated-headers for a comprehensive list HS

Re: Including LayerShellQt in Plasma in time for 5.22

- I'm like a broken record at this point: some of the cmake files and the json file lack licensing details. please run `reuse lint` to check the list. it's incredibly close to being fully licensed - you include KDEClangFormat but don't actually seem to enable it - along a similar note: the code

Re: KQuickImageEditor in KDEReview

- really close to 100% reuse cover. plz consider adding data to KQuickImageEditorConfig.cmake.in and src/controls/plugins.qmltypes - in fact... shouldn't the qmltypes file be generated at build time? - there's commented out KDEFrameworkCompilerSettings in CMakeLists, please remove it, Friedrich

Re: Koko in KDEReview

On 16.03.21 20:10, Carl Schwan wrote: > Le mardi, mars 16, 2021 12:55 PM, Harald Sitter a écrit : > >> On Tue, Mar 16, 2021 at 12:49 PM Harald Sitter sit...@kde.org wrote: >> > >>> Yay! > > Thanks for the big review :) > >>>

Re: Koko in KDEReview

On Tue, Mar 16, 2021 at 12:49 PM Harald Sitter wrote: > > Yay! > > - please get a bugzilla produce created for it > - COPYING-CMAKE-SCRIPTS seems unused > - the find_package calls on qt5 probably should be versioned on > whatever version you actually tested with, curre

Re: Koko in KDEReview

Yay! - please get a bugzilla produce created for it - COPYING-CMAKE-SCRIPTS seems unused - the find_package calls on qt5 probably should be versioned on whatever version you actually tested with, currently it's unversioned which I doubt is correct - same for kquickimageeditor - kquickimageeditor

Re: How are tier 1 framework qm translations supposed to be loaded?

On Tue, Jan 26, 2021 at 10:35 AM Halla Rempt wrote: > > It turns out that we have several problems with loading translations in > Krita. Qt and ki18n translations seem to follow different rules with regards > to users setting a language other than the platform language, on different >

Re: New repo in kdereview: plasma-settings

On 25.01.21 08:05, Bhushan Shah wrote: > Hello everyone! > > I want to move plasma-settings repo to kdereview, it is settings > application used by the Plasma Mobile, it is based on Kirigami. > > https://invent.kde.org/plasma-mobile/plasma-settings > > Main difference between plasma-settings

Re: New repo in kdereview: plasma-angelfish

On 25.01.21 06:55, Bhushan Shah wrote: > Hello everyone! > > Yet another Plasma Mobile repository in kdereview: > > https://invent.kde.org/plasma-mobile/plasma-angelfish > > Plasma Angelfish is browser written in Kirigami which uses the > QtWebengine for rendering web pages. It is optimized

Re: New repo in kdereview: plasma-phonebook

On 25.01.21 06:48, Bhushan Shah wrote: > Hello everyone! > > I am back with more Plasma Mobile related repositories in kdereview. I > want to move plasma-phonebook in kdereview. plasma-phonebook is kirigami > based phonebook application, it uses kpeople backends like kpeoplesink, > kpeoplevcard,

Re: PSA: Please do not use KDEFrameworkCompilerSettings for non-KF projects

On 19.01.21 16:57, Friedrich W. H. Kossebau wrote: > Hi, > > the docs of the module tell us: > "KDEFrameworkCompilerSettings - Set stricter compile and link flags for KDE > Frameworks modules." > https://api.kde.org/ecm/kde-module/KDEFrameworkCompilerSettings.html > > And it has been meant that

Re: RFC: suffix ".in" instead of ".cmake" for template files to substitution processing

On 04.01.21 08:21, Friedrich W. H. Kossebau wrote: > Hi, > > [replies only to kde-devel@kde.org, please] > > tl;dr This is a proposal to standardize on the suffix ".in" for input/ > template files passed to cmake's configure_file() in KDE projects. > > > When it comes to naming the files

Re: Merge tags in master branch?

Hej On 23.11.20 16:11, Bhushan Shah wrote: > Hello, > > So I have one question regarding the how we do the framework versioning. > Namely the tags, > > So currently some packages have a versioned tags on their master branch, > > i.e > > karchive: > > ➜ git describe > v5.76.0-1-g7304c28 > >

Re: CMake kauth_install_* with system kauth and user CMAKE_INSTALL_PREFIX

On 19.10.20 17:44, Ingo Klöcker wrote: > On Montag, 19. Oktober 2020 17:22:22 CEST Milian Wolff wrote: >> On Montag, 19. Oktober 2020 17:21:28 CEST Harald Sitter wrote: >>> I'm not sure it's a good idea, but we could treat this like >>> KDE_INSTALL_USE_QT_SYS_PATHS. By d

Re: CMake kauth_install_* with system kauth and user CMAKE_INSTALL_PREFIX

On 19.10.20 17:06, Milian Wolff wrote: > On Montag, 19. Oktober 2020 16:56:27 CEST Harald Sitter wrote: >> On 19.10.20 12:30, Milian Wolff wrote: >>> On Montag, 19. Oktober 2020 11:27:29 CEST Harald Sitter wrote: >>>> Yo >>>> >>>>

Re: CMake kauth_install_* with system kauth and user CMAKE_INSTALL_PREFIX

On 19.10.20 12:30, Milian Wolff wrote: > On Montag, 19. Oktober 2020 11:27:29 CEST Harald Sitter wrote: >> Yo >> >> On 18.10.20 10:11, Milian Wolff wrote: >>> Hey all, >>> >>> since some time now I'm only compiling parts of KF5 selectively

Re: CMake kauth_install_* with system kauth and user CMAKE_INSTALL_PREFIX

Yo On 18.10.20 10:11, Milian Wolff wrote: > Hey all, > > since some time now I'm only compiling parts of KF5 selectively into a custom > prefix. Most notably, I'm only interested in ktexteditor and syntax- > highlighting, and would like to obtain all other frameworks through my > distribution

Re: stale MR triaging - you can help!

On 16.10.20 10:00, Albert Astals Cid wrote: > El dimarts, 13 d’octubre de 2020, a les 15:53:10 CEST, Harald Sitter va > escriure: >> Moin >> >> As promised in a previous mail I've set up a system that helps us find >> stale MRs to ensure patches don't fall by the

Re: stale MR triaging - you can help!

On 16.10.20 10:00, Albert Astals Cid wrote: > El dimarts, 13 d’octubre de 2020, a les 15:53:10 CEST, Harald Sitter va > escriure: >> Moin >> >> As promised in a previous mail I've set up a system that helps us find >> stale MRs to ensure patches don't fall by the

Re: Supported C++ standard (aka compiler version) Overview Table for various distros?

On Wed, Oct 14, 2020 at 11:33 AM Milian Wolff wrote: > Does anyone know if there's an overview page similar to [1], but for Linux > distributions? https://repology.org/project/gcc/versions is the closest thing I know. Mileage may vary as distributions tend to have multiple compiler versions

stale MR triaging - you can help!

Moin As promised in a previous mail I've set up a system that helps us find stale MRs to ensure patches don't fall by the wayside. Lists are filed as issues on invent. To help out you can hit the bell to subscribe to `New issue` events at https://invent.kde.org/sysadmin/gitlab-triaging First

stale MR triaging - you can help!

Moin As promised in a previous mail I've set up a system that helps us find stale MRs to ensure patches don't fall by the wayside. Lists are filed as issues on invent. To help out you can hit the bell to subscribe to `New issue` events at https://invent.kde.org/sysadmin/gitlab-triaging First

Re: KDiagram - Persistent FTBFS for stable branch on Windows

On 12.10.20 11:23, Milian Wolff wrote: > On Montag, 12. Oktober 2020 11:11:22 CEST Ben Cooksley wrote: >> Hi KDiagram Developers, >> >> The stable branch of KDiagram has been persistently failing to build from >> source now on Windows for a period greater than 5 days. > > Hey Ben, > > can you

Re: KDiagram - Persistent FTBFS for stable branch on Windows

On 12.10.20 11:23, Milian Wolff wrote: > On Montag, 12. Oktober 2020 11:11:22 CEST Ben Cooksley wrote: >> Hi KDiagram Developers, >> >> The stable branch of KDiagram has been persistently failing to build from >> source now on Windows for a period greater than 5 days. > > Hey Ben, > > can you

D28745: Skip caching thumbnails on encrypted filesystems

sitter added a comment. > Could this be delegated onto someone who knows Solid or should I try figuring it out by myself? Alas, I'm not sure there is anyone who feels responsible enough for solid, so you'll probably have to give it a go yourself. REPOSITORY R320 KIO Extras REVISION

D28745: Skip caching thumbnails on encrypted filesystems

sitter added a comment. In D28745#676452 , @marcingu wrote: > !PING. > I need help from someone with good understanding of Solid to continue. > > I'm don't know how to determinate if StorageAccess device is encrypted or not. I wanted to

Re: plasma-systemmonitor in kdereview

On 01.10.20 14:36, Arjen Hiemstra wrote: > On Thursday, 1 October 2020 14:11:16 CEST Harald Sitter wrote: >> On 01.10.20 11:36, Arjen Hiemstra wrote: >>> Hello, >>> >>> I'd hereby like to announce that plasma-systemmonitor is in kdereview. It >>>

Re: plasma-systemmonitor in kdereview

On 01.10.20 11:36, Arjen Hiemstra wrote: > Hello, > > I'd hereby like to announce that plasma-systemmonitor is in kdereview. It can > be found at https://invent.kde.org/plasma/plasma-systemmonitor . > > plasma-systemmonitor is a new system monitor UI built with Kirigami. It makes > use of the

Re: stale MR triage

On 19.09.20 02:18, Albert Astals Cid wrote: > Not really, the thing is, for Okular i knew that all things that were old > didn't need my attention, it was either on the patch author to come back and > fix something or someone else should be the one reviewing, so just looking at > the last

Re: stale MR triage

On Fri, Sep 18, 2020 at 3:09 AM Ben Cooksley wrote: > > On Fri, 18 Sep 2020, 2:58 am Harald Sitter, wrote: >> >> Griaß eich! > > > Hi Harald, > >> >> In the KF6 BOF we were chatting about merge requests not being nearly >> as actively watched be

Re: stale MR triage

On Fri, Sep 18, 2020 at 12:36 AM Albert Astals Cid wrote: > > El dijous, 17 de setembre de 2020, a les 16:57:32 CEST, Harald Sitter va > escriure: > > Griaß eich! > > > > In the KF6 BOF we were chatting about merge requests not being nearly > > as activ

stale MR triage

Griaß eich! In the KF6 BOF we were chatting about merge requests not being nearly as actively watched because people didn't necessarily subscribe to all projects. While that is a solvable problem by asking people to kindly subscribe, it got us thinking that we should have a way to deal with stale

D28855: put minimumkeepsize actually in the netpref KCM

sitter abandoned this revision. sitter added a comment. moved to https://invent.kde.org/frameworks/kio/-/merge_requests/123 REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D28855 To: sitter, ngraham, dfaure Cc: ahmadsamir, kde-frameworks-devel, LeGast00n, cblack,

Re: plasma-disks in kdereview

It's been 3 weeks so I'm considering it in good enough shape for moving to plasma. Thanks! :) On Tue, Aug 4, 2020 at 3:46 PM Harald Sitter wrote: > > Hey > > It'd be awesome if I could get some eyes at the new > https://invent.kde.org/system/plasma-disks which implements sma

Re: Extend metainfo.yaml files with License Information

On Mon, Aug 17, 2020 at 8:24 PM Andreas Cord-Landwehr wrote: > > Thanks! I will answer inline: > > On Montag, 17. August 2020 17:47:40 CEST Harald Sitter wrote: > [...] > > > **First question:** Shall we only list ONE or ALL licenses, same for the > > > license

Re: Extend metainfo.yaml files with License Information

On Mon, Aug 17, 2020 at 2:16 PM Andreas Cord-Landwehr wrote: > > Hi, I am currently looking into extending our metainfo.yaml files to provide > information about the outbound licenses of the artefacts that are provided by > a framework. Here a few examples: > > Attica: Provides libattica, which

D7563: Add privilegeExecution field to file protocol description

sitter added a comment. In D7563#676151 , @cblack wrote: > In D7563#674682 , @sitter wrote: > > > This really cannot land right now IMHO. Dolphin can actually deadlock itself because it uses way too

D7563: Add privilegeExecution field to file protocol description

sitter added inline comments. INLINE COMMENTS > file_unix.cpp:1372 > +break; > +default: > +Q_UNREACHABLE(); I'd advise handling default cases. The compiler can no longer warn of unhandled enum values when default is used. Instead I'd convert the entire switch into a

Re: plasma-disks in kdereview

On Wed, Aug 5, 2020 at 12:00 AM Albert Astals Cid wrote: > > El dimarts, 4 d’agost de 2020, a les 15:46:20 CEST, Harald Sitter va escriure: > > Hey > > > > It'd be awesome if I could get some eyes at the new > > https://invent.kde.org/system/plasma-disks which i

plasma-disks in kdereview

Hey It'd be awesome if I could get some eyes at the new https://invent.kde.org/system/plasma-disks which implements smart monitoring as requested in https://bugs.kde.org/show_bug.cgi?id=254313 I've opted to not put it in kinfocenter directly because it is a bit much with its own kded module and

Re: Policy on forward declarations for things from external libraries

On Fri, Jul 31, 2020 at 5:56 PM Vlad Zahorodnii wrote: > > Howdy, > > From time to time, I find myself in a situation where a code reviewer > suggests to replace #include with the corresponding class > forward declaration. Such discussions usually get us nowhere because > neither the code

Re: xml_mimetypes5 and kcoreaddons

On Sun, Jul 19, 2020 at 1:56 PM David Faure wrote: > > On mercredi 15 juillet 2020 12:24:34 CEST Harald Sitter wrote: > > On Wed, Jul 15, 2020 at 12:39 AM David Faure wrote: > > > On mardi 14 juillet 2020 19:35:41 CEST Albert Astals Cid wrote: > > > > El dimart

Re: xml_mimetypes5 and kcoreaddons

On Wed, Jul 15, 2020 at 12:39 AM David Faure wrote: > > On mardi 14 juillet 2020 19:35:41 CEST Albert Astals Cid wrote: > > El dimarts, 14 de juliol de 2020, a les 15:14:38 CEST, Jonathan Riddell va > escriure: > > > We're playing with translations in neon packages and looking at > > >

Re: CMake source files without license

On Mon, Jun 22, 2020 at 11:27 PM Elvis Angelaccio wrote: > > Hi, > > I was wondering, is there a reason why our CMakeLists.txt files often do > not contain a license? The majority are probably trivial works that nobody can really claim copyright on and to that end cannot extend a license either.

D7563: Add privilegeExecution field to file protocol description

sitter requested changes to this revision. sitter added a comment. This revision now requires changes to proceed. This really cannot land right now IMHO. Dolphin can actually deadlock itself because it uses way too much nested event looping and will be entirely unresponsive to mouse inputs

D29745: look for kded as runtime dep

This revision was automatically updated to reflect the committed changes. Closed by commit R241:15869b83200f: look for kded as runtime dep (authored by sitter). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29745?vs=82839=83201 REVISION DETAIL

Re: Recent breakage in kwallet

here's my understanding of the problem: firstly, this is likely only a problem on debian-derived systems. and also only with blowfish debian has this patch [1] which on *actual* little endian systems (x86,arm64...) would run the conditional branches. the thing to note is that not only QBO is

D29381: Thumbnail text: use libmagic to detect encoding

sitter added a comment. Browsing the code it looks like it mmaps the file though? And when I add some strategic sleeping I can verify that file goes towards shared memory. Oh, I suppose the trouble is that load gets called each ::create? Simply wrap it in a cpp class and static scope it

D29381: Thumbnail text: use libmagic to detect encoding

sitter added a comment. LGTM. Seeing as I don't have much background knowledge I'm not comfortable accepting though. I guess if nobody comes up with better options by next week feel free to land. REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D29381 To: meven,

D29743: sftp: map sftp_open error to kio error

This revision was automatically updated to reflect the committed changes. Closed by commit R320:07e44cb1b536: sftp: map sftp_open error to kio error (authored by sitter). REPOSITORY R320 KIO Extras CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29743?vs=82835=82903 REVISION DETAIL

D29745: look for kded as runtime dep

sitter created this revision. sitter added a reviewer: dfaure. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. sitter requested review of this revision. REVISION SUMMARY kded is called over dbus to talk to the proxyscout, and also to track uidelegate

D29743: sftp: map sftp_open error to kio error

sitter created this revision. sitter added a reviewer: feverfew. Herald added projects: Dolphin, Frameworks. Herald added subscribers: kfm-devel, kde-frameworks-devel. sitter requested review of this revision. REVISION SUMMARY sftp gives out more relevant errors such as

D29634: sftp: break large writes into multiple requests

This revision was automatically updated to reflect the committed changes. Closed by commit R320:1df6174834bb: sftp: break large writes into multiple requests (authored by sitter). REPOSITORY R320 KIO Extras CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29634?vs=82723=82834

D29526: Thumbnails: make thumbnail generation dpr-aware

sitter added a comment. You do seem to calculate the deviceWidth and height an awful lot, it makes reading a bit clunky. I'd much rather have the multiplication done once and then always use the var instead. In fact, perhaps it'd make sense to have createV3 feed the values into the

D29634: sftp: break large writes into multiple requests

sitter edited the test plan for this revision. REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D29634 To: sitter, ngraham, meven Cc: meven, feverfew, kde-frameworks-devel, kfm-devel, waitquietly, azyx, nikolaik, pberestov, iasensio, aprcela, fprice, LeGast00n,

D29634: sftp: break large writes into multiple requests

sitter updated this revision to Diff 82723. sitter added a comment. - rejigger write segmentation into new sftpWrite function used by both the put() and write() - fix length calculation - refine buf size comment REPOSITORY R320 KIO Extras CHANGES SINCE LAST UPDATE

D29634: sftp: break large writes into multiple requests

sitter added inline comments. INLINE COMMENTS > meven wrote in kio_sftp.cpp:58 > Why not change it now to 32 * 1024 then ? > I guess you tested this value works at least with openssh. > > I guess the best solution would be to ask/figure out the server buffer size. > > What does gvfs, or other

D29634: sftp: break large writes into multiple requests

sitter created this revision. sitter added a reviewer: ngraham. Herald added projects: Dolphin, Frameworks. Herald added subscribers: kfm-devel, kde-frameworks-devel. sitter requested review of this revision. REVISION SUMMARY servers have arbitrary limits that we should stay below. to ensure

D29461: Fix kio-extras build on Windows

sitter added a comment. Pid changes look fine, though perhaps we should just throw those two lines away? With Qt5 logging the pid is fairly pointless because one can simply set QT_MESSAGE_PATTERN to include the pid when necessary https://doc.qt.io/qt-5/qtglobal.html#qSetMessagePattern

D29381: Thumbnail text: use libmagic to detect encoding

sitter added inline comments. INLINE COMMENTS > meven wrote in textcreator.cpp:38 > Without libmagic, it is current state basically UTF-8 with bom detection > otherwise local codec. > > I did not test exhaustive encodings so I wanted to let the door open for > users to not rely on libmagic. >

D29381: Thumbnail text: use libmagic to detect encoding

sitter added a comment. I have zero background knowledge here, but it really feels like there must be an existing solution to this problem other than libmagic. Like how does kate figure out the encoding of a text file. INLINE COMMENTS > Findlibmagic.cmake:1 > +# - Try to find libssh > +#

D29149: Fix kio-extras compilation with -DQT_NO_CAST_TO_ASCII

sitter added inline comments. INLINE COMMENTS > dfaure wrote in CMakeLists.txt:60 > Isn't that what I did here? Now all of kio-extras gets that flag. > > And BTW everything built by kdesrc-build actually builds with this flag > (since I have it in my kdesrc-buildrc). But that doesn't allow

D29149: Fix kio-extras compilation with -DQT_NO_CAST_TO_ASCII

sitter accepted this revision. sitter added a comment. This revision is now accepted and ready to land. Sure, I was referring to the smb module, not even kio-extras as a whole. ^^ Anyway, diff looks reasonable. REPOSITORY R320 KIO Extras BRANCH master REVISION DETAIL

D29149: Fix kio-extras compilation with -DQT_NO_CAST_TO_ASCII

sitter added a comment. Shouldn't we just make the entire thing QT_NO_CAST_TO_ASCII by default? REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D29149 To: dfaure, thiago, sitter Cc: kde-frameworks-devel, kfm-devel, azyx, nikolaik, pberestov, iasensio, aprcela,

D29063: Fix testpackage-appstream: XDG_DATA_DIRS needs to be explicitly extended

sitter added a comment. Looks reasonable. @apol thoughts? REPOSITORY R290 KPackage REVISION DETAIL https://phabricator.kde.org/D29063 To: kossebau, #frameworks, mart, apol, sitter, bcooksley Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D28909: smb: port to Result system to force serialization of error/finish condition

sitter added inline comments. INLINE COMMENTS > dfaure wrote in kio_smb.h:96 > Whenever we port a 3rd slave to it ;-) Sure, if you think it's solid enough from an API POV. I was thinking that we should amend the slavebase API for KF6 in general. Instead of having error/finished/opened all

D6794: assert the testpackage appstream data validates

sitter added a comment. @bcooksley I would think the CI image needs to ship some general purpose schemas. install https://software.opensuse.org/package/gsettings-desktop-schemas I guess. If it's still not working right with that installed I can take a look at what's missing. The

D28909: smb: port to Result system to force serialization of error/finish condition

sitter created this revision. sitter added a reviewer: dfaure. Herald added projects: Dolphin, Frameworks. Herald added subscribers: kfm-devel, kde-frameworks-devel. sitter requested review of this revision. REVISION SUMMARY the Result system was originally introduced to the FTP slave and now

D28855: put minimumkeepsize actually in the netpref KCM

sitter added a comment. Coding style is actually wildly inconsistent in that file, so I've stuck to what similar other lines have. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D28855 To: sitter, ngraham, dfaure Cc: ahmadsamir, kde-frameworks-devel, LeGast00n, cblack,

D28855: put minimumkeepsize actually in the netpref KCM

sitter added a comment. And didn't we have a better spinny box for byte units somewhere? Where the user can put `1 byte` or `1 kib` or `1 gib` and the box knows what to do? REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D28855 To: sitter, ngraham, dfaure Cc:

D28855: put minimumkeepsize actually in the netpref KCM

sitter added a comment. F8240046: Screenshot_20200415_164836.png I'm very open for better labels, it's a horrible concept to explain in a few words. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D28855 To: sitter, ngraham,

D28855: put minimumkeepsize actually in the netpref KCM

sitter updated this revision to Diff 80204. sitter added a comment. improve label a tad REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28855?vs=80203=80204 BRANCH master REVISION DETAIL https://phabricator.kde.org/D28855 AFFECTED FILES

D28855: put minimumkeepsize actually in the netpref KCM

sitter created this revision. sitter added reviewers: ngraham, dfaure. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. sitter requested review of this revision. REVISION SUMMARY I didn't even know it was a thing! by the looks of it the setting only applies

D28679: [KPropertiesDialog] Disable changing dir icon on samba shares

sitter added a comment. Hm. So, this is a bit complicated I've noticed. Let's consider the following cases: - `desktop:` is not a local file but can set and read dir icons without penalty - `camera:` is not a local file AND `Class=:local` BUT (I think?) cannot set dir icons as it

D28679: [KPropertiesDialog] Disable changing dir icon on samba shares

sitter added a comment. Looks reasonable. Though... Shouldn't that rather be any protocol that isn't `file`? Or at least all that are remote? (assuming we have a way of telling which slaves are remote) If I open sftp it also shows no dir icons yet lets me set one. REPOSITORY R241 KIO

D28336: Drop klauncher usage from KCrash

sitter accepted this revision. sitter added inline comments. This revision is now accepted and ready to land. INLINE COMMENTS > kcrash.cpp:627 > > void KCrash::startProcess(int argc, const char *argv[], bool waitAndExit) > { This seems to serve no purpose anymore. startProcessInternal could

D28463: do not install testengine

This revision was automatically updated to reflect the committed changes. Closed by commit R242:6e39c1de5bb3: do not install testengine (authored by sitter). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28463?vs=78974=79464 REVISION

D28513: smb: use prettyname.kio-discovery-wsd for hostname of wsdiscoveries

This revision was automatically updated to reflect the committed changes. Closed by commit R320:daec307b59e9: smb: use prettyname.kio-discovery-wsd for hostname of wsdiscoveries (authored by sitter). REPOSITORY R320 KIO Extras CHANGES SINCE LAST UPDATE

D27804: smb: add hack to support spaces in workgroup names

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R320:f40191a147c9: smb: add hack to support spaces in workgroup names (authored by sitter). CHANGED PRIOR TO COMMIT

D27902: smb: figure out the best host to use for the UDS_URL

sitter abandoned this revision. REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D27902 To: sitter, ngraham, dfaure Cc: meven, kde-frameworks-devel, kfm-devel, azyx, nikolaik, pberestov, iasensio, fprice, LeGast00n, cblack, fbampaloukas, alexde, GB_2, Codezela,

D28513: smb: use prettyname.kio-discovery-wsd for hostname of wsdiscoveries

sitter updated this revision to Diff 79234. sitter added a comment. chop instead of convoluted remove REPOSITORY R320 KIO Extras CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28513?vs=79220=79234 BRANCH smb-lazy-resolve REVISION DETAIL https://phabricator.kde.org/D28513

D27504: smb faster copy to local

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R320:46b5fb425c14: smb: fast copy (authored by sitter). REPOSITORY R320 KIO Extras CHANGES SINCE LAST UPDATE

D27504: smb faster copy to local

sitter edited the summary of this revision. REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D27504 To: sitter, ngraham, cfeck, #frameworks, #dolphin Cc: mmustac, meven, hallas, anthonyfieroni, asturmlechner, kde-frameworks-devel, kfm-devel, nikolaik, pberestov,

D28513: smb: use prettyname.kio-discovery-wsd for hostname of wsdiscoveries

sitter added inline comments. INLINE COMMENTS > kossebau wrote in kio_smb_browse.cpp:239 > `QString::remove()` operates on the object itself, no need to assign back to > host. > > Besides, why not use `QString::chop(wsdSuffix.size())` ? Mh. Good point indeed, I'll move to chop. Thanks!

D28513: smb: use prettyname.kio-discovery-wsd for hostname of wsdiscoveries

sitter updated this revision to Diff 79220. sitter added a comment. reshuffle: instead of using .local directly use a fake .kio-disocvery-wsd suffix. look for that at listing time and redirect to name.local or name as appropriate this prevents dnssd results form incorrectly getting run

D28513: smb: use prettyname.kio-discovery-wsd for hostname of wsdiscoveries

sitter retitled this revision from "smb: use prettyname.local for hostname of wsdiscoveries" to "smb: use prettyname.kio-discovery-wsd for hostname of wsdiscoveries". sitter edited the summary of this revision. REPOSITORY R320 KIO Extras BRANCH smb-lazy-resolve REVISION DETAIL

D28513: smb: use prettyname.local for hostname of wsdiscoveries

sitter added a comment. Stable was the plan, yes. I've thought of some complications with this approach though. Actually a combination of two 1. the .local match also applies to dnssd 2. all linux VMs I've checked wouldn't be able to resolve netbios names natively as the relevant

D28513: smb: use prettyname.local for hostname of wsdiscoveries

sitter added a comment. Competes with D27902 While this diff runs the risk of not being able to resolve 100% of the time (sans ip address fallback in listDir) it has the huge advantage that discovery isn't getting super slow when multiple wsd hosts are

D28513: smb: use prettyname.local for hostname of wsdiscoveries

sitter created this revision. sitter added reviewers: ngraham, meven. Herald added projects: Dolphin, Frameworks. Herald added subscribers: kfm-devel, kde-frameworks-devel. sitter requested review of this revision. REVISION SUMMARY previously we simply used the ip address. this is fairly

D28488: [Fstab] Ensure uniqueness for all filesystem types

sitter added inline comments. INLINE COMMENTS > bruns wrote in fstabhandling.cpp:131 > I got the impression you liked being lax. Guess only when the shoe is on the > other foot. I do like being lax! I literally gave you a ship it despite your comment being literally wrong. Picking on useless

D28488: [Fstab] Ensure uniqueness for all filesystem types

sitter added inline comments. INLINE COMMENTS > bruns wrote in fstabhandling.cpp:131 > You let the old comment pass without any further remarks, but now you start > nitpicking? > > From the acessibility viewpoint of the mount, it is unique. The previous comment was factually correct, it never

D28488: [Fstab] Ensure uniqueness for all filesystem types

sitter accepted this revision. This revision is now accepted and ready to land. REPOSITORY R245 Solid BRANCH fix_comment REVISION DETAIL https://phabricator.kde.org/D28488 To: bruns, #frameworks, meven, broulik, sitter Cc: broulik, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh,

D28488: [Fstab] Ensure uniqueness for all filesystem types

sitter added inline comments. INLINE COMMENTS > bruns wrote in fstabhandling.cpp:131 > The first mount is no longer visible, it is shadowed by the first one. You > can not read any files from it or write to it. You can not unmount it. The comment is still wrong. REPOSITORY R245 Solid

D28488: [Fstab] Ensure uniqueness for all filesystem types

sitter added inline comments. INLINE COMMENTS > bruns wrote in fstabhandling.cpp:131 > Of course they are - you can just mount one fs at a path at any time. λ ajax ~ → sudo mount -t cifs //bear.local/foo /mnt -o user=me λ ajax ~ → sudo mount -t cifs //bear.local/foo /mnt -o

D28488: [Fstab] Ensure uniqueness for all filesystem types

sitter requested changes to this revision. sitter added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > fstabhandling.cpp:131 > +// for different users. Make sure it is unique by appending the > +// mountpoint (which is unique). > +return source +

D28476: Samba: Ensure to differenciate mounts sharing the same source

sitter accepted this revision. sitter added a comment. This revision is now accepted and ready to land. You know, I may have noticed this when working on kinfocenter and then quickly forgotten about it again  Good stuff! REPOSITORY R245 Solid BRANCH master REVISION DETAIL

<    1   2   3   4   5   6   7   8   9   10   >