D10446: Add KLanguageName

sitter added a comment. Stacking the functions seems to work fine QString KLanguageName::nameForCode(const QString ) { const QStringList parts = QLocale().name().split(QChar('_')); return nameForCodeInLocale(code, parts.at(0)); } I do have various

D17310: Improve Kile icon with LaTeX font

trickyricky26 edited the test plan for this revision. REPOSITORY R266 Breeze Icons BRANCH improve-kile-icon (branched from master) REVISION DETAIL https://phabricator.kde.org/D17310 To: trickyricky26, #vdg, ngraham, #kile Cc: mludwig, ndavis, ngraham, kde-frameworks-devel, michaelh,

Re: Missing newline check

David Faure wrote: > IMHO text editors should (and most do) just ensure a newline is present at > the end so that this all works without human intervention. Well, there are cases where you don't want your editor to mess with existing files that way. The right thing to do is to make this feature

D17545: Do not stat move/copy job if the destination file system does not support writing

shubham updated this revision to Diff 47549. shubham added a comment. Unit test REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17545?vs=47503=47549 REVISION DETAIL https://phabricator.kde.org/D17545 AFFECTED FILES autotests/jobtest.cpp

D17545: Do not stat move/copy job if the destination file system does not support writing

shubham marked an inline comment as done. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D17545 To: shubham, #frameworks, dfaure Cc: davidedmundson, ngraham, broulik, kde-frameworks-devel, michaelh, bruns

D17500: Restore mobipocket extractor

astippich added a comment. In D17500#376221 , @aacid wrote: > In D17500#375753 , @astippich wrote: > > > Oh, thanks for the hint, didn't know that. That makes it a lot more complicated than a

D17466: Fix doxygen markdown rendering

This revision was automatically updated to reflect the committed changes. Closed by commit R264:28dca00d2f3a: Fix doxygen markdown rendering (authored by argonel). REPOSITORY R264 KApiDox CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17466?vs=47230=47589 REVISION DETAIL

D10742: get rid of the raw KFileItem pointers in KCoreDirListerCache

elvisangelaccio reopened this revision. elvisangelaccio added inline comments. This revision is now accepted and ready to land. INLINE COMMENTS > kcoredirlister.cpp:1576-1577 > +for (auto kit = dir->lstItems.begin(), kend = > dir->lstItems.end(); kit != kend; ++kit) { >

D17310: Improve Kile icon with LaTeX font

trickyricky26 edited the test plan for this revision. REPOSITORY R266 Breeze Icons BRANCH improve-kile-icon (branched from master) REVISION DETAIL https://phabricator.kde.org/D17310 To: trickyricky26, #vdg, ngraham, #kile Cc: mludwig, ndavis, ngraham, kde-frameworks-devel, michaelh,

D14631: Adds a new RenameDialog to KIO with more options for batch renaming

emateli marked 3 inline comments as done. emateli added a comment. There's still some work to do with the actual BatchRenameClass now and the d-pointer pattern. I'll update this in a few days. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D14631 To: emateli,

D17310: Improve Kile icon with LaTeX font

loh.tar added a comment. For me is these root sign nondescript. When the orig old blue symbol is not desired, how about to freshen it up? How? I don't know. Perhaps Black & White just as all your other offers on these rectangular sheet of paper? Furthermore exist these splash-screen. So

D17500: Restore mobipocket extractor

ltoscano added a comment. In D17500#376854 , @astippich wrote: > In D17500#376221 , @aacid wrote: > > > In D17500#375753 , @astippich wrote: > > > > >

D17595: Upstream Dolphin's file rename dialog

ngraham added a dependent revision: D17597: Use newly-upstreamed rename dialog from KIO. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D17595 To: ngraham, #frameworks, #dolphin, broulik Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17528: Refactor SlaveInterface::calcSpeed

bruns added inline comments. INLINE COMMENTS > slaveinterface.cpp:102 > +// Minimum list size is 1 and maximum list size is 8. Delta is calculated > +// using first and last item from the list at least every 900 msecs. > + .. at most ... > slaveinterface.cpp:203 > d->filesize

D17593: Notify if a default provider failed to download

apol created this revision. apol added reviewers: Frameworks, leinir. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. apol requested review of this revision. REVISION SUMMARY Otherwise we end up waiting forever without really knowing what happened.

D17594: Notify about the provider not being loaded

apol created this revision. apol added reviewers: Frameworks, leinir. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. apol requested review of this revision. REVISION SUMMARY Adopts D17593 REPOSITORY R304 KNewStuff

D17595: Upstream Dolphin's file rename dialog

ngraham created this revision. ngraham added reviewers: Frameworks, Dolphin, broulik. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. ngraham requested review of this revision. REVISION SUMMARY KIO didn't actually have its own rename dialog, which is

D17596: [KDirOperator] Allow renaming files from the context menu

ngraham created this revision. ngraham added reviewers: Frameworks, Dolphin. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. ngraham requested review of this revision. REVISION SUMMARY BUG: 189482 FIXED-IN: 5.54 TEST PLAN [image goes here] - Using

D17595: Upstream Dolphin's file rename dialog

ngraham added a dependent revision: D17596: [KDirOperator] Allow renaming files from the context menu. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D17595 To: ngraham, #frameworks, #dolphin, broulik Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17596: [KDirOperator] Allow renaming files from the context menu

ngraham edited the summary of this revision. ngraham edited the test plan for this revision. ngraham added a dependency: D17595: Upstream Dolphin's file rename dialog. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D17596 To: ngraham, #frameworks, #dolphin Cc:

D17355: Align Plasma QML button content in center if it has an icon

mart added a comment. in general, buttons with icons may be stacked vertically, which for me makes a general -1 REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D17355 To: GB_2, #plasma, #vdg Cc: mart, davidedmundson, apol, ngraham, #vdg,

D17355: Align Plasma QML button content in center if it has an icon

mart added a comment. In D17355#371722 , @GB_2 wrote: > Improved code. > How `qmlscene tests/components/button.qml` looks like: > F6457867: Plasma QML Button Content Align qmlscene (1).png > For

D17355: Align Plasma QML button content in center if it has an icon

mart added a comment. pleaase add the changes to plasmacomponents3 as well REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D17355 To: GB_2, #plasma, #vdg Cc: mart, davidedmundson, apol, ngraham, #vdg, kde-frameworks-devel, #plasma,

Kopete and Libjingle

This patch needs tested for Kopete https://phabricator.kde.org/D13231 But I don't know how to test it. Does anyone use jabber and video conferencing through it with libjingle? I signed up for accounts at this server https://jabber.hot-chilli.net/forms/create/ and I can send messages from

T3689: Add abi compliance checker to CI

knauss added a revision: D17579: Handle cases where tailing "/" in CMAKE_PREFIX_PATH fails the detection of additional include directories.. TASK DETAIL https://phabricator.kde.org/T3689 To: knauss Cc: dfaure, kde-frameworks-devel, bcooksley, sysadmin, scarlettclark, aacid, knauss,

D17528: Refactor SlaveInterface::calcSpeed

chinmoyr updated this revision to Diff 47567. chinmoyr added a comment. Used a structure to group size and time. REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17528?vs=47518=47567 BRANCH master REVISION DETAIL https://phabricator.kde.org/D17528

D17528: Refactor SlaveInterface::calcSpeed

dfaure requested changes to this revision. dfaure added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > slaveinterface.cpp:112 > +const TransferInfo first = d->transfer_details.first(); > +const TransferInfo last = d->transfer_details.last(); > +

D17310: Improve Kile icon with LaTeX font

trickyricky26 updated this revision to Diff 47591. trickyricky26 edited the test plan for this revision. trickyricky26 added a comment. - Usr silver pen design to improve contrast REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17310?vs=47364=47591

D17310: Improve Kile icon with LaTeX font

trickyricky26 added a comment. I have made another design based on @ndavis feedback: F6477088: kile-alternative.svg.png F6477093: Original root a with pen screenshot.png This uses the root a design from the

D14631: Adds a new RenameDialog to KIO with more options for batch renaming

ngraham added a comment. @dfaure, how's this looking now? REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D14631 To: emateli, #frameworks, dfaure, mlaurent Cc: mlaurent, asensi, rkflx, dfaure, aacid, ngraham, kde-frameworks-devel, michaelh, bruns

D17355: Align Plasma QML button content in center if it has an icon

GB_2 planned changes to this revision. GB_2 added a comment. In D17355#376973 , @mart wrote: > in general, buttons with icons may be stacked vertically, which for me makes a general -1 But it's not consistent with Qt Widgets and looks