D20209: Add support for KBookmarkOwner to communicate if it has tabs open

dfaure accepted this revision. This revision is now accepted and ready to land. REPOSITORY R294 KBookmarks BRANCH add_tabs_open (branched from master) REVISION DETAIL https://phabricator.kde.org/D20209 To: hallas, #frameworks, ngraham, cfeck, dfaure Cc: kde-frameworks-devel, michaelh,

D20606: Add action to toggle folding of child ranges

loh.tar added a comment. In D20606#451744 , @mwolff wrote: > In D20606#451459 , @dhaumann wrote: > > > I would prefer a context menu that has this as action. This is much better discoverable and

KDE CI: Frameworks » ktexteditor » kf5-qt5 SUSEQt5.12 - Build # 84 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/ktexteditor/job/kf5-qt5%20SUSEQt5.12/84/ Project: kf5-qt5 SUSEQt5.12 Date of build: Tue, 23 Apr 2019 19:48:33 + Build duration: 11 min and counting BUILD ARTIFACTS

KDE CI: Frameworks » ktexteditor » kf5-qt5 SUSEQt5.10 - Build # 98 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/ktexteditor/job/kf5-qt5%20SUSEQt5.10/98/ Project: kf5-qt5 SUSEQt5.10 Date of build: Tue, 23 Apr 2019 19:48:33 + Build duration: 8 min 41 sec and counting BUILD ARTIFACTS

KDE CI: Frameworks » ktexteditor » kf5-qt5 FreeBSDQt5.12 - Build # 101 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/ktexteditor/job/kf5-qt5%20FreeBSDQt5.12/101/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Tue, 23 Apr 2019 19:48:33 + Build duration: 7 min 7 sec and counting JUnit Tests Name:

D20700: Add "edit-remove" icon symlink and add 22px version of "paint-none" and "edit-none"

This revision was automatically updated to reflect the committed changes. Closed by commit R266:7c6559bdb86f: Add edit-remove icon symlink and add 22px version of paint-none and edit… (authored by GB_2). REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE

D20697: Review IconBorder

This revision was automatically updated to reflect the committed changes. Closed by commit R39:57781f34d234: Review IconBorder (authored by loh.tar). REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20697?vs=56839=56843 REVISION DETAIL

D20697: Review IconBorder

cullmann accepted this revision. cullmann added a comment. This revision is now accepted and ready to land. This works for me fine with KDevelop. Please commit. Thanks REVISION DETAIL https://phabricator.kde.org/D20697 To: loh.tar, #ktexteditor, dhaumann, cullmann Cc: cullmann,

D20697: Review IconBorder

loh.tar updated this revision to Diff 56839. loh.tar edited the test plan for this revision. loh.tar added a comment. try to fix annotation issue completely untested :-/ CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20697?vs=56694=56839 REVISION DETAIL

D20697: Review IconBorder

cullmann added a comment. I am not sure one can delay the updateGeometry stuff until one paints. REVISION DETAIL https://phabricator.kde.org/D20697 To: loh.tar, #ktexteditor, dhaumann, cullmann Cc: cullmann, dhaumann, kwrite-devel, kde-frameworks-devel, #ktexteditor, domson, michaelh,

D20697: Review IconBorder

cullmann requested changes to this revision. cullmann added a comment. This revision now requires changes to proceed. Unfortunately, the annotation stuff regressed. I tried KDevelop, right click on text => Git -> Annotation... See pre-patch and post-patch pictures below, the too small one

D20209: Add support for KBookmarkOwner to communicate if it has tabs open

hallas added inline comments. INLINE COMMENTS > dfaure wrote in kbookmarkmenu.cpp:150 > Technically this is only needed if the number of open tabs went from "< 2" to > ">= 2" or vice versa. > When going from, say, 20 to 21, we don't need to refill the menu. > So the code could be > >

D20209: Add support for KBookmarkOwner to communicate if it has tabs open

hallas updated this revision to Diff 56837. hallas marked an inline comment as done. hallas added a comment. Review comments REPOSITORY R294 KBookmarks CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20209?vs=56744=56837 BRANCH add_tabs_open (branched from master) REVISION

D20700: Add "edit-remove" icon symlink and add 22px version of "paint-none" and "edit-none"

ndavis accepted this revision. ndavis added a comment. This revision is now accepted and ready to land. LGTM REPOSITORY R266 Breeze Icons BRANCH add-edit-remove-icon (branched from master) REVISION DETAIL https://phabricator.kde.org/D20700 To: GB_2, #vdg, ndavis Cc: ngraham, ndavis,

D20766: Use appropriate background color for text previews

cullmann added a comment. I actually think the theme should contain all colors hard-coded and KTextEditor should properly use that instead of currently the mix of hardcoded/defaults. The only automatism should be (in my eyes) to switch between a light/dark variant automatic depending on

D20700: Add "edit-remove" icon symlink and add 22px version of "paint-none" and "edit-none"

GB_2 updated this revision to Diff 56835. GB_2 added a comment. Fix one 16px path point REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20700?vs=56834=56835 BRANCH add-edit-remove-icon (branched from master) REVISION DETAIL

D20700: Add "edit-remove" icon symlink and add 22px version of "paint-none" and "edit-none"

GB_2 retitled this revision from "Add "edit-remove" icon symlink and add 22px version of "paint-none"" to "Add "edit-remove" icon symlink and add 22px version of "paint-none" and "edit-none"". REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D20700 To: GB_2, #vdg,

D20700: Add "edit-remove" icon symlink and add 22px version of "paint-none"

GB_2 updated this revision to Diff 56834. GB_2 added a comment. (Hopefully) fix icons and add 22px version of `edit-none` REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20700?vs=56747=56834 BRANCH add-edit-remove-icon (branched from master)

D20766: Use appropriate background color for text previews

kossebau added a comment. I am even more confused that switching back to "Breeze" from "Breeze Dark", I can still reproduce things when just switching to dark color themes only. So possibly that is enough, and I was before potentially fooled by some running processes, despite making sure no

T3689: Add abi compliance checker to CI

knauss added a revision: D20769: abi-compliance-checker: disable clang include directories completly.. TASK DETAIL https://phabricator.kde.org/T3689 To: knauss Cc: danders, davidedmundson, dfaure, kde-frameworks-devel, bcooksley, sysadmin, scarlettclark, aacid, knauss, alexeymin, kaning,

D20766: Use appropriate background color for text previews

vkrause added subscribers: cullmann, dhaumann. vkrause added a comment. In D20766#454891 , @kossebau wrote: > So, switching also the Plasma Theme to "Breeze Dark", I started to be able to reproduce: seems that the default text color is

D20766: Use appropriate background color for text previews

eshalygin added a comment. I would welcome the same palette in the file preview as the one I see in ktexteditor when open the file REVISION DETAIL https://phabricator.kde.org/D20766 To: eshalygin, kossebau, cfeck Cc: vkrause, cfeck, meven, broulik, kde-frameworks-devel, kfm-devel, alexde,

D20766: Use appropriate background color for text previews

cfeck requested changes to this revision. cfeck added a comment. Before we can support both dark and light themes we need to investigate the KSyntaxHighlighting issue found by Friedrich. Later we could request a light or dark theme depending on the lightness of the QPalette entry, but I

D20766: Use appropriate background color for text previews

kossebau added a comment. So, switching also the Plasma Theme to "Breeze Dark", I started to be able to reproduce: seems that the default text color is influenced by that. Which seems a side-effect not to be expected. And this patch here just a work-around for the symptom. We ask

D20766: Use appropriate background color for text previews

kossebau requested changes to this revision. kossebau added a subscriber: vkrause. kossebau added a comment. This revision now requires changes to proceed. For one, I cannot reproduce the bug. With all the dark UI color themes I tested, I always had proper contrasted dark text colors in the

D20693: Remove pixelated border

ngraham added a comment. To show that a thumbnail clickable, switching to the pointing hand cursor when hovering over a thumbnail could work. However I notice that the actual list delegates in the browse view seem to add frames and shadows to the thumbnails there, and they look okay.

D20766: Use appropriate background color for text previews

kossebau added a comment. BTW, just a note while testing: while the thumbnails curently are not cached but always rerendered on demand (due to flag in metadata), there currently is no update mechanism to update the thumbnails already shown e.g. in Dolphin when the UI color theme changes.

D20766: Use appropriate background color for text previews

ngraham edited the summary of this revision. REVISION DETAIL https://phabricator.kde.org/D20766 To: eshalygin, kossebau, cfeck Cc: cfeck, meven, broulik, kde-frameworks-devel, kfm-devel, alexde, feverfew, michaelh, spoorun, navarromorales, firef, ngraham, andrebarros, bruns, emmanuelp,

D20766: Use appropriate background color for text previews

kossebau added a reviewer: cfeck. REVISION DETAIL https://phabricator.kde.org/D20766 To: eshalygin, kossebau, cfeck Cc: cfeck, meven, broulik, kde-frameworks-devel, kfm-devel, alexde, feverfew, michaelh, spoorun, navarromorales, firef, ngraham, andrebarros, bruns, emmanuelp, mikesomov

D20766: Use appropriate background color for text previews

kossebau added a subscriber: cfeck. kossebau added a comment. Thanks for the patch. Hm, somehow I remember from my testing for D19432 that highlighting color did not take active UI color theme into account, has that changed meanwhile? In any case,

D20092: New class KOSRelease - a parser for os-release files

This revision was automatically updated to reflect the committed changes. Closed by commit R244:1bedee3ca534: New class KOSRelease - a parser for os-release files (authored by sitter). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D20092?vs=55338=56813#toc REPOSITORY R244 KCoreAddons

KDE CI: Frameworks » kcoreaddons » kf5-qt5 FreeBSDQt5.12 - Build # 38 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20FreeBSDQt5.12/38/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Tue, 23 Apr 2019 11:32:18 + Build duration: 1 min 51 sec and counting JUnit Tests Name:

D20196: Add Notify capability to KConfigXT

davidedmundson accepted this revision. This revision is now accepted and ready to land. REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D20196 To: broulik, #frameworks, dfaure, davidedmundson Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D20693: Remove pixelated border

leinir added a comment. In D20693#454799 , @sitter wrote: > In D20693#454750 , @leinir wrote: > > > So yes, in principle i'd certainly like there to be some kind of background or outline to suggest

D20196: Add Notify capability to KConfigXT

broulik added a comment. Ping REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D20196 To: broulik, #frameworks, dfaure, davidedmundson Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D20693: Remove pixelated border

sitter added a comment. In D20693#454750 , @leinir wrote: > So yes, in principle i'd certainly like there to be some kind of background or outline to suggest clickability, but the current state (and any other generic rectangular background we

D20693: Remove pixelated border

leinir added a comment. In D20693#454783 , @sitter wrote: > LGTM on a technical level. On a visual level also +1 because I hate that drop shadow with a fierce passion. > > @leinir lxr says a similar thumb is also used for some of the

D20765: Add input methods to input method status bar button

This revision was automatically updated to reflect the committed changes. Closed by commit R39:14ff5dd8674f: Add input methods to input method status bar button (authored by broulik). REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20765?vs=56804=56809

D20765: Add input methods to input method status bar button

cullmann accepted this revision. cullmann added a comment. This revision is now accepted and ready to land. Good idea! REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D20765 To: broulik, #kate, dhaumann, cullmann Cc: cullmann, kwrite-devel, kde-frameworks-devel,

D20693: Remove pixelated border

sitter added a comment. LGTM on a technical level. On a visual level also +1 because I hate that drop shadow with a fierce passion. @leinir lxr says a similar thumb is also used for some of the KAboutPerson stuff in kxmlgui. it may be prudent to also remove the thumb there, I expect it

D20525: [InformationPanel] Use the new inline configuration mode

This revision was automatically updated to reflect the committed changes. Closed by commit R318:ecf1ae6d0b16: [InformationPanel] Use the new inline configuration mode (authored by bruns). REPOSITORY R318 Dolphin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20525?vs=56732=56808

D20766: Use appropriate background color for text previews

eshalygin marked an inline comment as done. REVISION DETAIL https://phabricator.kde.org/D20766 To: eshalygin, kossebau Cc: meven, broulik, kde-frameworks-devel, kfm-devel, alexde, feverfew, michaelh, spoorun, navarromorales, firef, ngraham, andrebarros, bruns, emmanuelp, mikesomov

D20766: Use appropriate background color for text previews

meven added inline comments. INLINE COMMENTS > textcreator.cpp:7 Too many lines removed here, it should not compile anymore. Just a small editing mistake I guess. REVISION DETAIL https://phabricator.kde.org/D20766 To: eshalygin, kossebau Cc: meven, broulik, kde-frameworks-devel, kfm-devel,

D20700: Add "edit-remove" icon symlink and add 22px version of "paint-none"

ndavis added a comment. More like center version in this SVG: F6788395: paint-none.svg.2019_04_23_05_53_37.0.svg F6788396: Screenshot_20190423_055953.png Notice how the lines appear to have a thickness

D20766: Use appropriate background color for text previews

eshalygin updated this revision to Diff 56806. eshalygin added a comment. Replace KColorScheme with QPalette CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20766?vs=56805=56806 REVISION DETAIL https://phabricator.kde.org/D20766 AFFECTED FILES thumbnail/textcreator.cpp To:

D20766: Use appropriate background color for text previews

broulik added a reviewer: kossebau. REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D20766 To: eshalygin, kossebau Cc: broulik, kde-frameworks-devel, kfm-devel, alexde, feverfew, meven, michaelh, spoorun, navarromorales, firef, ngraham, andrebarros, bruns,

D20693: Remove pixelated border

leinir added a comment. In D20693#454733 , @ndavis wrote: > +1 for the change to the large thumbnail, but I think the smaller thumbnails need something to show that they can be clicked. The problem as described in my comment where i

D20766: Use appropriate background color for text previews

broulik added inline comments. INLINE COMMENTS > textcreator.cpp:140 > > -QColor bgColor = QColor ( 245, 245, 245 ); // light-grey > background > -m_pixmap.fill( bgColor ); > +m_pixmap.fill( > KColorScheme(QPalette::Active).background().color() ); >

D20766: Use appropriate background color for text previews

eshalygin created this revision. Herald added projects: Dolphin, Frameworks. Herald added subscribers: kfm-devel, kde-frameworks-devel. eshalygin requested review of this revision. REVISION SUMMARY Text previews are unreadable (in fact look empty) with dark colour schemes because of the

D20693: Remove pixelated border

ndavis added a comment. +1 for the change to the large thumbnail, but I think the smaller thumbnails need something to show that they can be clicked. REPOSITORY R304 KNewStuff REVISION DETAIL https://phabricator.kde.org/D20693 To: leinir, #knewstuff, ngraham, sitter, #vdg Cc: ndavis,

D20765: Add input methods to input method status bar button

broulik created this revision. broulik added reviewers: Kate, dhaumann. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. broulik requested review of this revision. REVISION SUMMARY Even though it indicates VI mode vs Normal mode clicking it

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.10 - Build # 84 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.10/84/ Project: kf5-qt5 SUSEQt5.10 Date of build: Tue, 23 Apr 2019 08:34:33 + Build duration: 10 min and counting BUILD ARTIFACTS

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.12 - Build # 77 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.12/77/ Project: kf5-qt5 SUSEQt5.12 Date of build: Tue, 23 Apr 2019 08:34:33 + Build duration: 10 min and counting BUILD ARTIFACTS

KDE CI: Frameworks » plasma-framework » kf5-qt5 FreeBSDQt5.12 - Build # 87 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20FreeBSDQt5.12/87/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Tue, 23 Apr 2019 08:34:33 + Build duration: 6 min 19 sec and counting JUnit Tests

D20693: Remove pixelated border

leinir added a reviewer: VDG. leinir added a comment. Adding VDG because this is a visual change. To the visual commenters: This is intended as a first step, removing the old drop-shadow method (see also the related bug for a more severe version of that drop-shadow being shown very

D20761: Remove pixelated border

leinir added a reviewer: VDG. leinir added a comment. Adding VDG because this is a visual change. To the visual commenters: This is intended as a first step, removing the old drop-shadow method (see also the related bug for a more severe version

KDE CI: Frameworks » kpackage » kf5-qt5 SUSEQt5.10 - Build # 24 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kpackage/job/kf5-qt5%20SUSEQt5.10/24/ Project: kf5-qt5 SUSEQt5.10 Date of build: Tue, 23 Apr 2019 07:44:18 + Build duration: 2 min 8 sec and counting BUILD ARTIFACTS

KDE CI: Frameworks » kpackage » kf5-qt5 SUSEQt5.12 - Build # 21 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kpackage/job/kf5-qt5%20SUSEQt5.12/21/ Project: kf5-qt5 SUSEQt5.12 Date of build: Tue, 23 Apr 2019 07:44:18 + Build duration: 1 min 53 sec and counting BUILD ARTIFACTS

KDE CI: Frameworks » kpackage » kf5-qt5 FreeBSDQt5.12 - Build # 23 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kpackage/job/kf5-qt5%20FreeBSDQt5.12/23/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Tue, 23 Apr 2019 07:44:18 + Build duration: 1 min 25 sec and counting JUnit Tests Name:

D20749: autotests: don't fail appstream test because of anything on stderr

This revision was automatically updated to reflect the committed changes. Closed by commit R290:131715c8dcd0: autotests: dont fail appstream test because of anything on stderr (authored by dfaure). REPOSITORY R290 KPackage CHANGES SINCE LAST UPDATE

D20693: Remove pixelated border

leinir added a comment. Before patch: F6788195: image.png After patch: F6788193: image.png REPOSITORY R304 KNewStuff REVISION DETAIL https://phabricator.kde.org/D20693 To: leinir, #knewstuff, ngraham,

D20693: Remove pixelated border

leinir added a comment. In D20693#454173 , @ngraham wrote: > This patch doesn't apply: > >INFO Base commit is not in local repository; trying to fetch. > Created and checked out branch arcpatch-D20693. > Checking patch

D20693: Remove pixelated border

leinir updated this revision to Diff 56794. leinir added a comment. Attempt to use arcanist, hopefully with less data loss this time REPOSITORY R304 KNewStuff CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20693?vs=56613=56794 BRANCH no-pixelated-border (branched from master)

D20761: Remove pixelated border

leinir abandoned this revision. REPOSITORY R304 KNewStuff REVISION DETAIL https://phabricator.kde.org/D20761 To: leinir Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D20761: Remove pixelated border

leinir created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. leinir requested review of this revision. REVISION SUMMARY In the before-times, drop shadows were considered vitally important on everything, and so it was introduced to