KDE CI: Frameworks » knewstuff » kf5-qt5 WindowsMSVCQt5.13 - Build # 23 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/knewstuff/job/kf5-qt5%20WindowsMSVCQt5.13/23/ Project: kf5-qt5 WindowsMSVCQt5.13 Date of build: Tue, 22 Oct 2019 03:10:21 + Build duration: 31 min and counting CONSOLE OUTPUT

D24841: Use modern way to set the C/CXX standad

vonreth updated this revision to Diff 68488. vonreth added a comment. - Raise CMake requirements to 3.5 REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24841?vs=68486=68488 BRANCH cmake_c_standard REVISION DETAIL

D24841: Use modern way to set the C/CXX standad

dfaure added a comment. Dunno, it's harder to justify in a standalone review :) "Increase dependency, just because" ;) REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D24841 To: vonreth, dfaure, cullmann Cc: aacid, chehrlic, kde-frameworks-devel,

D24841: Use modern way to set the C/CXX standad

vonreth added a comment. I guess we should do that in a separate review? REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D24841 To: vonreth, dfaure, cullmann Cc: aacid, chehrlic, kde-frameworks-devel, kde-buildsystem, LeGast00n, GB_2, bencreasy,

D24841: Use modern way to set the C/CXX standad

dfaure added a comment. Works for me. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D24841 To: vonreth, dfaure, cullmann Cc: aacid, chehrlic, kde-frameworks-devel, kde-buildsystem, LeGast00n, GB_2, bencreasy, michaelh, ngraham, bruns

D24841: Use modern way to set the C/CXX standad

vonreth updated this revision to Diff 68486. vonreth added a comment. Fix REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24841?vs=68478=68486 BRANCH cmake_c_standard REVISION DETAIL https://phabricator.kde.org/D24841 AFFECTED FILES

KDE CI: Frameworks » breeze-icons » kf5-qt5 WindowsMSVCQt5.13 - Build # 50 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/breeze-icons/job/kf5-qt5%20WindowsMSVCQt5.13/50/ Project: kf5-qt5 WindowsMSVCQt5.13 Date of build: Mon, 21 Oct 2019 18:26:06 + Build duration: 2 hr 2 min and counting JUnit Tests

D24841: Use modern way to set the C/CXX standad

aacid added a comment. If you want to increase cmake dependency, we should at least increase it to 3.5 https://repology.org/project/cmake/badges REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D24841 To: vonreth, dfaure, cullmann Cc: aacid,

D24841: Use modern way to set the C/CXX standad

dfaure requested changes to this revision. dfaure added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > KDECompilerSettings.cmake:208 > +set(CMAKE_C_STANDARD 90) > +set(CMAKE_CXX_STANDARD_REQUIRED 11) > That's not how it works. You want

KDE CI: Frameworks » ktexteditor » kf5-qt5 FreeBSDQt5.13 - Build # 126 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/ktexteditor/job/kf5-qt5%20FreeBSDQt5.13/126/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Mon, 21 Oct 2019 19:53:24 + Build duration: 9 min 58 sec and counting JUnit Tests Name:

KDE CI: Frameworks » ktexteditor » kf5-qt5 FreeBSDQt5.13 - Build # 125 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/ktexteditor/job/kf5-qt5%20FreeBSDQt5.13/125/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Mon, 21 Oct 2019 19:33:00 + Build duration: 18 min and counting JUnit Tests Name:

KDE CI: Frameworks » ktexteditor » kf5-qt5 FreeBSDQt5.13 - Build # 124 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/ktexteditor/job/kf5-qt5%20FreeBSDQt5.13/124/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Mon, 21 Oct 2019 19:25:55 + Build duration: 7 min 0 sec and counting JUnit Tests Name:

D24755: [KStatusNotifierItem] Optionaly, do not take menu ownership

kmaterka added a comment. Moved to D24843 REPOSITORY R289 KNotifications REVISION DETAIL https://phabricator.kde.org/D24755 To: kmaterka, #frameworks, davidedmundson, broulik, nicolasfella Cc: anthonyfieroni, kde-frameworks-devel, LeGast00n, GB_2,

KDE CI: Frameworks » ktexteditor » kf5-qt5 FreeBSDQt5.13 - Build # 123 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/ktexteditor/job/kf5-qt5%20FreeBSDQt5.13/123/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Mon, 21 Oct 2019 19:19:23 + Build duration: 6 min 27 sec and counting JUnit Tests Name:

KDE CI: Frameworks » ktexteditor » kf5-qt5 FreeBSDQt5.13 - Build # 122 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/ktexteditor/job/kf5-qt5%20FreeBSDQt5.13/122/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Mon, 21 Oct 2019 19:07:17 + Build duration: 12 min and counting JUnit Tests Name:

D19504: Extend KHtmlView::print() to use a predefined QPrinter instance

This revision was automatically updated to reflect the committed changes. Closed by commit R313:2d8cba050729: Extend KHtmlView::print() to use a predefined QPrinter instance (authored by habacker). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D19504?vs=67894=68479#toc REPOSITORY R313

D24841: Use modern way to set the C/CXX standad

vonreth updated this revision to Diff 68478. vonreth added a comment. CMAKE_CXX_STANDARD_REQUIRED REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24841?vs=68475=68478 BRANCH cmake_c_standard REVISION DETAIL

D24841: Use modern way to set the C/CXX standad

vonreth edited the summary of this revision. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D24841 To: vonreth, dfaure, cullmann Cc: chehrlic, kde-frameworks-devel, kde-buildsystem, LeGast00n, GB_2, bencreasy, michaelh, ngraham, bruns

D24841: Use modern way to set the C/CXX standad

vonreth added a comment. In D24841#551653 , @chehrlic wrote: > I would also use CMAKE_CXX_STANDARD_REQUIRED to make sure the compiler actually *can* c++11, otherwise the flag is only added when the compiler supports it. Should not make much

KDE CI: Frameworks » ktexteditor » kf5-qt5 FreeBSDQt5.13 - Build # 121 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/ktexteditor/job/kf5-qt5%20FreeBSDQt5.13/121/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Mon, 21 Oct 2019 18:46:56 + Build duration: 20 min and counting JUnit Tests Name:

D24841: Use modern way to set the C/CXX standad

chehrlic added a comment. I would also use CMAKE_CXX_STANDARD_REQUIRED to make sure the compiler actually *can* c++11, otherwise the flag is only added when the compiler supports it. Should not make much difference nowadays but since it's in ECM... REPOSITORY R240 Extra CMake Modules

D24841: Use modern way to set the C/CXX standad

vonreth updated this revision to Diff 68475. vonreth added a comment. Change message REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24841?vs=68473=68475 BRANCH cmake_c_standard REVISION DETAIL https://phabricator.kde.org/D24841 AFFECTED

D24841: Use modern way to set the C/CXX standad

vonreth added reviewers: dfaure, cullmann. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D24841 To: vonreth, dfaure, cullmann Cc: kde-frameworks-devel, kde-buildsystem, LeGast00n, GB_2, bencreasy, michaelh, ngraham, bruns

D24841: Use modern way to set the C/CXX standad

vonreth created this revision. Herald added projects: Frameworks, Build System. Herald added subscribers: kde-buildsystem, kde-frameworks-devel. vonreth requested review of this revision. REVISION SUMMARY Raise C from C89 ti C90 as C89 is not supported by the CMAKE flag

D21235: Add handling of fuseiso filesystem type

hallas updated this revision to Diff 68472. hallas added a comment. Reorder functions to make diff smaller REPOSITORY R245 Solid CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21235?vs=68324=68472 BRANCH add_handling_of_fuseiso (branched from master) REVISION DETAIL

D21235: Add handling of fuseiso filesystem type

hallas marked an inline comment as done. hallas added inline comments. INLINE COMMENTS > bruns wrote in fstabhandling.cpp:301 > Please keep these functions at their current position, just adds unnecessary > noise in the diff. Good point :) REPOSITORY R245 Solid REVISION DETAIL

D24827: auto-enable KIO_ASSERT_SLAVE_STATES also for from-git builds

dfaure requested changes to this revision. dfaure added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > CMakeLists.txt:49 > if(KIO_ASSERT_SLAVE_STATES AND NOT CMAKE_BUILD_TYPE MATCHES "[Dd]ebug$") > -message(FATAL_ERROR "KIO_ASSERT_SLAVE_STATES option

D24598: Update elisa icon

This revision was automatically updated to reflect the committed changes. Closed by commit R266:a51651fd91a2: Update elisa icon (authored by astippich). REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24598?vs=68192=68470 REVISION DETAIL

D24593: Modified breeze shadows

ngraham added a comment. Is this ready for formal review now or are you still tweaking and/or soliciting comments? REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D24593 To: niccolove, #vdg Cc: Luwx, filipf, ngraham, davidedmundson,

D23951: Improve panel options menu entries

This revision was automatically updated to reflect the committed changes. Closed by commit R242:bbe0148db5d1: Improve panel options menu entries (authored by GB_2). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23951?vs=68467=68469

D23951: Improve panel options menu entries

mart accepted this revision. This revision is now accepted and ready to land. REPOSITORY R242 Plasma Framework (Library) BRANCH arcpatch-D23951 REVISION DETAIL https://phabricator.kde.org/D23951 To: GB_2, #plasma, #vdg, mart Cc: davidedmundson, ngraham, #vdg, kde-frameworks-devel,

D23951: Improve panel options menu entries

GB_2 removed a dependent revision: D24162: Hide "Lock Widgets" button from panel edit mode toolbar. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D23951 To: GB_2, #plasma, #vdg, mart Cc: davidedmundson, ngraham, #vdg, kde-frameworks-devel, #plasma,

D23951: Improve panel options menu entries

GB_2 edited the summary of this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D23951 To: GB_2, #plasma, #vdg, mart Cc: davidedmundson, ngraham, #vdg, kde-frameworks-devel, #plasma, LeGast00n, GB_2, michaelh, bruns

D23951: Improve and clean up panel options menu entries

GB_2 updated this revision to Diff 68467. GB_2 added a comment. Don't hide lock action here REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23951?vs=8=68467 BRANCH arcpatch-D23951 REVISION DETAIL

D23951: Improve panel options menu entries

GB_2 retitled this revision from "Improve and clean up panel options menu entries" to "Improve panel options menu entries". GB_2 edited the summary of this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D23951 To: GB_2, #plasma, #vdg, mart

D23951: Improve and clean up panel options menu entries

GB_2 marked an inline comment as done. GB_2 added a comment. In D23951#551472 , @mart wrote: > i'm not sure i would hardcode the behavior Only show "Unlock Widgets" in the UI (hide "Lock Widgets" from the UI) i would try to go from the context

D24773: kio_trash: Add size, modification, access and create date for trash:/

ngraham added a comment. In D24773#551245 , @meven wrote: > I would argue that "Disk space usage" and "Size" might be confusing to users. A folder size is the size of his content idiomatically. > That is our current usage of Size field for

D23951: Improve and clean up panel options menu entries

mart added a comment. probably some special casing for that action will still be needed in the panel, but should be ok REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D23951 To: GB_2, #plasma, #vdg, mart Cc: davidedmundson, ngraham, #vdg,

D24676: Port the KSSLD D-Bus interface from KSslError to QSslError

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R241 KIO BRANCH master REVISION DETAIL https://phabricator.kde.org/D24676 To: vkrause, apol Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24799: Port away from deprecated SmallIcon method

This revision was automatically updated to reflect the committed changes. Closed by commit R295:3b082be3acdd: Port away from deprecated SmallIcon method (authored by vkrause). REPOSITORY R295 KCMUtils CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24799?vs=68347=68454 REVISION

D24676: Port the KSSLD D-Bus interface from KSslError to QSslError

vkrause added a comment. ping? REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D24676 To: vkrause Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23951: Improve and clean up panel options menu entries

GB_2 added a comment. In D23951#551472 , @mart wrote: > i'm not sure i would hardcode the behavior Only show "Unlock Widgets" in the UI (hide "Lock Widgets" from the UI) i would try to go from the context menu plugin instead and not adding the

D23951: Improve and clean up panel options menu entries

mart requested changes to this revision. This revision now requires changes to proceed. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D23951 To: GB_2, #plasma, #vdg, mart Cc: davidedmundson, ngraham, #vdg, kde-frameworks-devel, #plasma, LeGast00n,

D23951: Improve and clean up panel options menu entries

mart added a comment. i'm not sure i would hardcode the behavior Only show "Unlock Widgets" in the UI (hide "Lock Widgets" from the UI) i would try to go from the context menu plugin instead and not adding the action there by default (but still possible to add it) REPOSITORY R242 Plasma

D23951: Improve and clean up panel options menu entries

davidedmundson added a comment. > Ping. It's already accepted by Marco isn't it? INLINE COMMENTS > containment.cpp:126 > +if (d->type == Types::PanelContainment || d->type == > Types::CustomPanelContainment) { > +configAction->setText(i18nc("%1 is the name of the

D23951: Improve and clean up panel options menu entries

GB_2 added a comment. Ping. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D23951 To: GB_2, #plasma, #vdg, mart Cc: ngraham, #vdg, kde-frameworks-devel, #plasma, LeGast00n, GB_2, michaelh, bruns

D23537: extend state verification to open connection commands

sitter added a comment. I've actually started work on a more general system for this. Will update soon. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D23537 To: sitter, dfaure Cc: fsitter, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23537: extend state verification to open connection commands

sitter planned changes to this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D23537 To: sitter, dfaure Cc: fsitter, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24755: [KStatusNotifierItem] Optionaly, do not take menu ownership

kmaterka added a comment. > First, it will not have memory leaks, we take ownership on parentless menu, on menu that has a parent, it will destroy it by parent-child cleanups. Yes, eventually menu will be deleted. I'm thinking about the situation when someone has: if

D24755: [KStatusNotifierItem] Optionaly, do not take menu ownership

kmaterka abandoned this revision. kmaterka added a comment. This is a dead end, I will implement different solution in QPA (KDEPlatformSystemTrayIcon) plugin. REPOSITORY R289 KNotifications REVISION DETAIL https://phabricator.kde.org/D24755 To: kmaterka, #frameworks, davidedmundson,

Re: Quick Charts in KDE Review

Hi Arjen, 1. I don't see any checks in the autotests. Would it be easy to compare the displayed chart against a reference screenshot image, in each of the tests? The same screenshots could also help developers understand what kind of charts kquickcharts is good for. 2. How to add a grid, ticks

D24755: [KStatusNotifierItem] Optionaly, do not take menu ownership

anthonyfieroni added a comment. In D24755#551320 , @kmaterka wrote: > In D24755#550415 , @anthonyfieroni wrote: > > > That should be fine, in QPA we have a tray icon per sni, update menu should be

Re: Quick Charts in KDE Review

On 21-10-2019 15:22, Arjen Hiemstra wrote: Hi, Quick Charts has been moved to KDE review. The intent is to make it a Tier 1 framework. Quick Charts is a QML module that implements a set of high-performance, GPU accelerated charts. Currently the main user of it is a new KSysGuard UI I have been

Quick Charts in KDE Review

Hi, Quick Charts has been moved to KDE review. The intent is to make it a Tier 1 framework. Quick Charts is a QML module that implements a set of high-performance, GPU accelerated charts. Currently the main user of it is a new KSysGuard UI I have been working on, but once it is part of

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.12 - Build # 283 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.12/283/ Project: kf5-qt5 SUSEQt5.12 Date of build: Mon, 21 Oct 2019 13:24:03 + Build duration: 12 min and counting BUILD ARTIFACTS

D24821: Add ManagedConfigModule

ngraham added a dependent revision: D24822: Port the desktoptheme kcm to ManagedConfigModule. REPOSITORY R296 KDeclarative REVISION DETAIL https://phabricator.kde.org/D24821 To: ervin, #plasma, #frameworks, mart, bport, davidedmundson Cc: davidedmundson, bport, kde-frameworks-devel,

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.13 - Build # 152 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.13/152/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Mon, 21 Oct 2019 13:24:03 + Build duration: 10 min and counting JUnit Tests Name: projectroot

D24824: Remove outdated comment about [$e] expansion

This revision was automatically updated to reflect the committed changes. Closed by commit R296:4eddf7a469e1: Remove outdated comment about [$e] expansion (authored by davidedmundson). REPOSITORY R296 KDeclarative CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24824?vs=68415=68432

D24755: [KStatusNotifierItem] Optionaly, do not take menu ownership

kmaterka added a comment. In D24755#550415 , @anthonyfieroni wrote: > That should be fine, in QPA we have a tray icon per sni, update menu should be on same object which will not be a problem, check it. There are two objects in QPA that

KDE CI: Frameworks » breeze-icons » kf5-qt5 WindowsMSVCQt5.13 - Build # 49 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/breeze-icons/job/kf5-qt5%20WindowsMSVCQt5.13/49/ Project: kf5-qt5 WindowsMSVCQt5.13 Date of build: Mon, 21 Oct 2019 07:43:11 + Build duration: 5 hr 41 min and counting CONSOLE OUTPUT

D24826: Enforce 100 chars line width

cullmann added a comment. See the other task: columnlimit 0 leads to endless long lines and is a unusable default. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D24826 To: romangg, #frameworks, cullmann Cc: winterz, zzag, kde-frameworks-devel,

D24826: Enforce 100 chars line width

winterz added a comment. I am a long-time advocate of columnLimits; however, in our modern world of programming I think 100 is too short. 240 may be a bit too long: in my personal coding style scripts I try to limit to 120. even 120 is hard to achieve sometimes. I feel that 240 is a

D24826: Enforce 100 chars line width

zzag added a comment. I suggest to set ColumnLimit to 0 by default and allow projects to override it. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D24826 To: romangg, #frameworks, cullmann Cc: zzag, kde-frameworks-devel, kde-buildsystem, LeGast00n,

Heads-up for developers working _on_ KF modules: how to mark deprecated API from now on

Hi, tldr; For deprecated API of KDE Frameworks modules please use ECMGenerateExportHeader and the respective macros to mark & wrap deprecated API, otherwise the whole effort breaks down. Question: where would you expect the documentation for how to do this? The introduction of

D24826: Enforce 100 chars line width

cullmann added a comment. Perhaps easiest way to see what happens: apply it to one of your things and vary the value. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D24826 To: romangg, #frameworks, cullmann Cc: kde-frameworks-devel, kde-buildsystem,

D24821: Add ManagedConfigModule

davidedmundson accepted this revision. davidedmundson added a comment. > Indeed the alternative is registerSettings(), I went for the less explicit "children settings" mechanism mostly because it was closer to the older system around KCModule which was very much working by convention.

D24821: Add ManagedConfigModule

ervin added a comment. In D24821#551179 , @davidedmundson wrote: > Nice! > > I'm not super sold on magically doing findChildren to get the config skeletons over an explicit > registerSettings(KCoreConfigSkeleton*). > > I'm not

D24826: Enforce 100 chars line width

romangg added a comment. In D24826#551280 , @cullmann wrote: > As explained in the thread on https://phabricator.kde.org/T11214, this will make the formatting ugly as hell, as if you have long method names, stuff is broken in arbitrary bad

D24657: Add support for _GTK_FRAME_EXTENTS

zzag removed a dependent revision: D24660: [x11] Add support for _GTK_FRAME_EXTENTS. REPOSITORY R278 KWindowSystem REVISION DETAIL https://phabricator.kde.org/D24657 To: zzag, #kwin Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24826: Enforce 100 chars line width

cullmann added a comment. As explained in the thread on https://phabricator.kde.org/T11214, this will make the formatting ugly as hell, as if you have long method names, stuff is broken in arbitrary bad ways. I don't want to change that, if nobody can avoid the resulting breakage.

D24828: KRun: don't override user preferred app when opening local *.*html and co. files

ahmadsamir created this revision. ahmadsamir added reviewers: Frameworks, dfaure. Herald added a project: Frameworks. ahmadsamir requested review of this revision. REVISION SUMMARY KRun unconditionally opened files with mimetype text/html (and co.) with the browser application set in

D24827: auto-enable KIO_ASSERT_SLAVE_STATES also for from-git builds

sitter created this revision. sitter added a reviewer: dfaure. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. sitter requested review of this revision. REVISION SUMMARY testing high level functionality of a bunch of relevant slaves yielded no obvious

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.12 - Build # 282 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.12/282/ Project: kf5-qt5 SUSEQt5.12 Date of build: Mon, 21 Oct 2019 10:48:14 + Build duration: 43 min and counting BUILD ARTIFACTS

D24826: Enforce 100 chars line width

romangg created this revision. romangg added reviewers: Frameworks, cullmann. Herald added projects: Frameworks, Build System. Herald added subscribers: kde-buildsystem, kde-frameworks-devel. romangg requested review of this revision. REVISION SUMMARY The KDE Frameworks style recommended a 100

D24825: Add hideOnWindowDeactivate to PlasmaComponents.Dialog

kmaterka added a comment. This is a first step to solve 401016 : "Touchpad plasmoid [confirmation dialog] remains open when losing focus, I think that it is inconsistent since other elements of tray close themselves after switching away."

D24825: Add hideOnWindowDeactivate to PlasmaComponents.Dialog

kmaterka edited the summary of this revision. kmaterka added reviewers: Plasma, Frameworks. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D24825 To: kmaterka, #plasma, #frameworks Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24773: kio_trash: Add size, modification, access and create date for trash:/

meven marked 2 inline comments as done. meven added a comment. In D24773#551087 , @dfaure wrote: > I meant in the Dolphin view. RMB / Properties and calculating the size is available for trash:/. See

D24825: Add hideOnWindowDeactivate to PlasmaComponents.Dialog

kmaterka created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. kmaterka requested review of this revision. REVISION SUMMARY When using Dialog or QueryDialog it should be possible to set hideOnWindowDeactivate flag. REPOSITORY R242 Plasma

D24263: edit mode action

This revision was automatically updated to reflect the committed changes. Closed by commit R242:acbb200ac2cc: edit mode action (authored by mart). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D24263?vs=68224=68422#toc REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST

D24824: Remove outdated comment about [$e] expansion

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R296 KDeclarative BRANCH master REVISION DETAIL https://phabricator.kde.org/D24824 To: davidedmundson, apol Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.13 - Build # 151 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.13/151/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Mon, 21 Oct 2019 10:48:19 + Build duration: 13 min and counting JUnit Tests Name: projectroot

D24350: [src/kpac/*] replace deprecated foreach with range for

This revision was automatically updated to reflect the committed changes. Closed by commit R241:103e13c2765e: [src/kpac/*] replace deprecated foreach with range for (authored by ahmadsamir). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24350?vs=68395=68419

D24821: Add ManagedConfigModule

davidedmundson added inline comments. INLINE COMMENTS > managedconfigmodule.h:116 > + * > + * If you want to make the ConfigModule available only conditionally (i.e. > show in > + * the list of available modules only if some test succeeds) then you can use I know this is just copy paste, but

D24824: Remove outdated comment about [$e] expansion

davidedmundson created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. davidedmundson requested review of this revision. REVISION SUMMARY This was dropped in KConfig due to security reasons a while ago. REPOSITORY R296 KDeclarative

D24821: Add ManagedConfigModule

bport accepted this revision. bport added a comment. This revision is now accepted and ready to land. Ok for me, when David remarks are addressed REPOSITORY R296 KDeclarative REVISION DETAIL https://phabricator.kde.org/D24821 To: ervin, #plasma, #frameworks, mart, bport Cc:

D24821: Add ManagedConfigModule

davidedmundson added a comment. Nice! I'm not super sold on magically doing findChildren to get the config skeletons over an explicit registerSettings(KCoreConfigSkeleton*). I'm not against it either, but could you expand on the rationale. INLINE COMMENTS >

KDE CI: Frameworks » knotifications » kf5-qt5 WindowsMSVCQt5.13 - Build # 27 - Still unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/knotifications/job/kf5-qt5%20WindowsMSVCQt5.13/27/ Project: kf5-qt5 WindowsMSVCQt5.13 Date of build: Sun, 20 Oct 2019 20:26:51 + Build duration: 13 hr and counting JUnit Tests

D24821: Add ManagedConfigModule

ervin updated this revision to Diff 68411. ervin added a comment. Addresses bport's comment REPOSITORY R296 KDeclarative CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24821?vs=68408=68411 REVISION DETAIL https://phabricator.kde.org/D24821 AFFECTED FILES

D24821: Add ManagedConfigModule

bport requested changes to this revision. bport added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > managedconfigmodule.cpp:96 > +{ > +return false; > +} Like above I think we need to set it to true > managedconfigmodule.h:210 > + * > + * By

D24821: Add ManagedConfigModule

ervin created this revision. ervin added reviewers: Plasma, Frameworks, mart. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. ervin requested review of this revision. REVISION SUMMARY This is a new type of ConfigModule which will manage the state of

D24663: Use ECMGenerateExportHeader to manage deprecated API better

zzag added a comment. In D24663#549764 , @kossebau wrote: > @zzag Hi. Any chance you can have time to review this today/the WE? One of the last ECMGenerateExportHeader patches. Hi, sorry for the late response. Yes, I think this change

D24773: kio_trash: Add size, modification, access and create date for trash:/

dfaure requested changes to this revision. dfaure added a comment. This revision now requires changes to proceed. I meant in the Dolphin view. RMB / Properties and calculating the size is available for trash:/. See http://www.davidfaure.fr/2019/dolphin_properties_dialog_for_trash.png I

D24754: Fix KNSCore::Cache fetching when initialising Engine

This revision was automatically updated to reflect the committed changes. Closed by commit R304:8977627cab85: Fix KNSCore::Cache fetching when initialising Engine (authored by leinir). REPOSITORY R304 KNewStuff CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24754?vs=68284=68404

D24350: [src/kpac/*] replace deprecated foreach with range for

dfaure accepted this revision. This revision is now accepted and ready to land. REPOSITORY R241 KIO BRANCH ahmad/foreach-kpac (branched from master) REVISION DETAIL https://phabricator.kde.org/D24350 To: ahmadsamir, dfaure Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham,

D24686: Replace usage of deprecated SlaveBase::config() by SlaveBase::configValue

meven added a comment. In D24686#550567 , @elvisangelaccio wrote: > It's always ok to bump the KF5 version as long as you do it before the dependency freeze day set by the release team. So I guess it is the case here : Apps 19.12 is

D24773: kio_trash: Add size, modification, access and create date for trash:/

meven marked 3 inline comments as done. meven added inline comments. INLINE COMMENTS > dfaure wrote in trashimpl.cpp:1088 > This method could be const, right? No becauseof the call to `list()` that cannot be const. > dfaure wrote in trashimpl.cpp:1104 > This looks very slow. We have a cache

D24773: kio_trash: Add size, modification, access and create date for trash:/

meven updated this revision to Diff 68402. meven added a comment. Use TrashSizeCache to file directory size, do not add creation date to the UDSEntry, better use UDSEntry reserve/clear REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24773?vs=68281=68402

D24773: kio_trash: Add size, modification, access and create date for trash:/

meven edited the summary of this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D24773 To: meven, #frameworks, ngraham, elvisangelaccio, dfaure Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns