D27444: Added plasmoid heading svg

ndavis added a comment. Why do the outside edges have different opacity from the center part? BTW, this patch is saying it depends on a commit that doesn't exist in git master. REPOSITORY R242 Plasma Framework (Library) BRANCH top_area (branched from master) REVISION DETAIL

D28033: Create ExpandableListItem

davidedmundson added inline comments. INLINE COMMENTS > ExpandableListItem.qml:2 > +/* > + * Copyright 2020 Nate Graham > + * It shouldn't be in PC3. It's new API from qqc2.A > ExpandableListItem.qml:23 > +import org.kde.plasma.core 2.0 as PlasmaCore > +import org.kde.plasma.plasmoid 2.0 >

D28033: Create ExpandableListItem

ngraham updated this revision to Diff 77603. ngraham added a comment. - Add an opacity animation when expanded view is shown - Add a button on the right to expand and collapse the expanded view - Clean and simplify expand()/collapse() code a bit REPOSITORY R242 Plasma Framework

D27951: Allow users to change dropAction to MoveAction through kdeglobals

trmdi added a comment. In D27951#627283 , @ngraham wrote: > My interpretation of the use case is that a user who chooses dndToMove prefers Move over Copy and Link, but not necessarily Extract or Set as Wallpaper, since those are

D24390: Add more file and directories to exclude filters

bruns abandoned this revision. bruns added a comment. open questions unanswered, does not look right/useful REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D24390 To: bruns, #baloo, ngraham, ognarb Cc: bruns, ngraham, kde-frameworks-devel, #baloo, hurikhan77,

D24390: Add more file and directories to exclude filters

bruns commandeered this revision. bruns added a reviewer: ognarb. bruns added a comment. open questions unanswered ... REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D24390 To: bruns, #baloo, ngraham, ognarb Cc: bruns, ngraham, kde-frameworks-devel, #baloo,

D25743: Expose IndexerState enum to QML

bruns added a comment. In D25743#619435 , @davidedmundson wrote: > > Ping. > > Will do on Sunday (after tagging) Which Sunday? ;-) REPOSITORY R293 Baloo BRANCH master REVISION DETAIL https://phabricator.kde.org/D25743 To:

D28033: Create ExpandableListItem

ngraham added a comment. If it were a flat button, I'd want to make the default action button flat too, or else they wouldn't match. Here's how that would look: F8174983: Toolbuttons.png And here's how it would look with both of them as non-flat

D28039: optimize dynamic regex matching

dhaumann accepted this revision. dhaumann added a comment. This revision is now accepted and ready to land. I guess this is OK, but the concept of a "skip offset" is a bit fuzzy to me. INLINE COMMENTS > rule_p.h:126 > + > +protected: > +bool m_dynamic = false; I dislike this protected

D27695: WIP: Create a new TopArea element using widgets/toparea svg

ngraham added a task: T10470: Improve the visuals of tray popups. REPOSITORY R242 Plasma Framework (Library) BRANCH master REVISION DETAIL https://phabricator.kde.org/D27695 To: niccolove, mart, ngraham Cc: ngraham, davidedmundson, ahiemstra, kde-frameworks-devel, LeGast00n, cblack,

D27444: Added plasmoid heading svg

ngraham added a task: T10470: Improve the visuals of tray popups. REPOSITORY R242 Plasma Framework (Library) BRANCH top_area (branched from master) REVISION DETAIL https://phabricator.kde.org/D27444 To: niccolove, #vdg, ngraham, ndavis Cc: mart, kde-frameworks-devel, LeGast00n, cblack,

D27695: WIP: Create a new TopArea element using widgets/toparea svg

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Excellent work. REPOSITORY R242 Plasma Framework (Library) BRANCH master REVISION DETAIL https://phabricator.kde.org/D27695 To: niccolove, mart, ngraham Cc: ngraham,

D27444: Added plasmoid heading svg

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. @ndavis does the SVG look good to you? REPOSITORY R242 Plasma Framework (Library) BRANCH top_area (branched from master) REVISION DETAIL https://phabricator.kde.org/D27444 To:

D27951: Allow users to change dropAction to MoveAction through kdeglobals

ngraham added a comment. In D27951#627078 , @trmdi wrote: > I think the user has to choose. When he chose dndToMove, that means he prefers the move action to others (copy, link, extract, set as wallpaper...) My interpretation of the use

Re: KIO: try to assign an icon to action submenus

On 3/13/20 2:18 PM, David Faure wrote: > On mardi 3 mars 2020 18:29:47 CET Chloe Kudryavtsev wrote: >> Currently, action submenus (X-KDE-Submenu) have no icons. >> This patch makes it inherit the icon of the first action. > > I wonder if this is always wanted? The icon for the first action might

D27544: Fix update scenarios with no explicit downloadlink selected

ngraham accepted this revision as: ngraham. ngraham added a comment. This revision is now accepted and ready to land. Probably wait for at least one more review from someone smarter and more familiar with this code than I am. :) REPOSITORY R304 KNewStuff BRANCH fix-update (branched from

T11950: Reduce the pain of working on monochrome Breeze icons

davidhurka added a comment. This is how my source file for find-location (D27983 ) looks in inkscape. F8174793: Screenshot_20200313_201936.png Would it be nice to post such screenshots in Revisions, instead

D28039: optimize dynamic regex matching

cullmann added a comment. For the example from the bug this makes the difference between ~30 seconds on a 4 Ghz machine to << 1 second ;=) REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D28039 To: cullmann, dhaumann, vkrause, nibags Cc: kwrite-devel,

D28039: optimize dynamic regex matching

cullmann created this revision. cullmann added reviewers: dhaumann, vkrause, nibags. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. cullmann requested review of this revision. REVISION SUMMARY allow such matches to be cached, too, by

D28014: smb: do not double finish

ngraham accepted this revision. This revision is now accepted and ready to land. REPOSITORY R320 KIO Extras BRANCH smb-mount-doublefinish REVISION DETAIL https://phabricator.kde.org/D28014 To: sitter, ngraham Cc: kde-frameworks-devel, kfm-devel, pberestov, iasensio, fprice, LeGast00n,

D28015: extend indexer to detect dynamic=true regexes that have no place holders to adapt

cullmann added a comment. Better, but VHDL hl is still very slow, need to take a deeper look into it :/ REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D28015 To: cullmann, nibags, dhaumann, vkrause Cc: kwrite-devel, kde-frameworks-devel, rrosch,

D28015: extend indexer to detect dynamic=true regexes that have no place holders to adapt

This revision was automatically updated to reflect the committed changes. Closed by commit R216:e6090be50f0d: extend indexer to detect dynamic=true regexes that have no place holders to… (authored by cullmann). REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE

Re: KIO: try to assign an icon to action submenus

On mardi 3 mars 2020 18:29:47 CET Chloe Kudryavtsev wrote: > Currently, action submenus (X-KDE-Submenu) have no icons. > This patch makes it inherit the icon of the first action. I wonder if this is always wanted? The icon for the first action might not be representative of what the other

D27695: WIP: Create a new TopArea element using widgets/toparea svg

niccolove added a comment. Works for me! REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D27695 To: niccolove, mart, ngraham Cc: ngraham, davidedmundson, ahiemstra, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, bruns

D28033: Create ExpandableListItem

ngraham edited the test plan for this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D28033 To: ngraham, #vdg, #plasma Cc: bruns, niccolove, cblack, davidre, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham

D28033: Create ExpandableListItem

davidre added a comment. In D28033#627192 , @ngraham wrote: > In D28033#627184 , @cblack wrote: > > > In D28033#627180 , @davidre wrote: > > > > > I

D28033: Create ExpandableListItem

ngraham added a comment. In D28033#627184 , @cblack wrote: > In D28033#627180 , @davidre wrote: > > > I would love if we could find a way to show that the item is expandable > > > I would

D27695: WIP: Create a new TopArea element using widgets/toparea svg

niccolove updated this revision to Diff 77588. niccolove added a comment. Fixed inset REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27695?vs=77482=77588 BRANCH master REVISION DETAIL https://phabricator.kde.org/D27695 AFFECTED

D28033: Create ExpandableListItem

ngraham added a subscriber: bruns. ngraham added a comment. Discussion points: - Is this even the right paradigm to use for extra actions? Or should we instead use a SwipeListItem and put the extra actions in an overflow menu, and use the expanded view only for custom content? -

D28033: Create ExpandableListItem

niccolove added a comment. Strongly agree on having a single component. By the way, all these lists have the issue that the button only appearing on hover is very touch-unfriendly. This does not have to be addressed in this patch, but it having it implemented in only one place makes it much

D28033: Create ExpandableListItem

cblack added a comment. In D28033#627180 , @davidre wrote: > I would love if we could find a way to show that the item is expandable I would probably use a pointing down arrow without a stem when collapsed, and pointing up when open.

D28032: [StorageDevices] Fix order of notification connect and initialization

This revision was automatically updated to reflect the committed changes. Closed by commit R293:d771f908cb44: [StorageDevices] Fix order of notification connect and initialization (authored by bruns). REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE

D28033: Create ExpandableListItem

davidre added a comment. I would love if we could find a way to show that the item is expandable REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D28033 To: ngraham, #vdg, #plasma Cc: davidre, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh,

D28033: Create ExpandableListItem

ngraham added a dependent revision: D28037: [Applet] Port to ExpandableListItem. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D28033 To: ngraham, #vdg, #plasma Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28032: [StorageDevices] Fix order of notification connect and initialization

davidedmundson accepted this revision. This revision is now accepted and ready to land. REPOSITORY R293 Baloo BRANCH submit REVISION DETAIL https://phabricator.kde.org/D28032 To: bruns, #baloo, ngraham, davidedmundson Cc: kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, cblack,

D28033: Create ExpandableListItem

ngraham added a dependent revision: D28035: [Applet] Port to ExpandableListItem. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D28033 To: ngraham, #vdg, #plasma Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28033: Create ExpandableListItem

ngraham added a dependent revision: D28034: [WIP] [Applet] Port to ExpandableListItem. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D28033 To: ngraham, #vdg, #plasma Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28033: Create ExpandableListItem

ngraham added a dependent revision: D28036: [Applet] Port to ExpandableListItem. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D28033 To: ngraham, #vdg, #plasma Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28033: Create ExpandableListItem

ngraham created this revision. ngraham added reviewers: VDG, Plasma. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. ngraham requested review of this revision. REVISION SUMMARY This patch creates the `ExpandableListItem`, a re-usable PlasmaComponents3 item

D28032: [StorageDevices] Fix order of notification connect and initialization

bruns created this revision. bruns added reviewers: Baloo, ngraham. Herald added projects: Frameworks, Baloo. Herald added a subscriber: kde-frameworks-devel. bruns requested review of this revision. REVISION SUMMARY There is a small timeframe between cache initialization and connection of

D27923: [FileIndexScheduler] Cleanup firstRun handling

bruns updated this revision to Diff 77580. bruns added a comment. fix deprecation REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27923?vs=77309=77580 BRANCH submit REVISION DETAIL https://phabricator.kde.org/D27923 AFFECTED FILES

D28015: extend indexer to detect dynamic=true regexes that have no place holders to adapt

cullmann added a comment. Yes, I will fix the issues and then commit this as one thingy. Thanks for taking a look :=) My colleague was very unhappy with the VHDL performance :P The highlighting shouldn't take as long as a hardware simulator. REPOSITORY R216 Syntax Highlighting BRANCH

D28015: extend indexer to detect dynamic=true regexes that have no place holders to adapt

dhaumann accepted this revision. dhaumann added a comment. This revision is now accepted and ready to land. I guess in a followup commit the reported issues will be fixed? :-) REPOSITORY R216 Syntax Highlighting BRANCH master REVISION DETAIL https://phabricator.kde.org/D28015 To:

D28020: New class ProcessLauncherJob in KIOGui

davidedmundson added a comment. From the POV of the task at hand, it's great. If we are making new public API I have some minor requests for things we want in future. INLINE COMMENTS > kprocessrunner.cpp:39 > + > +KProcessRunner::KProcessRunner(const KService::Ptr , const > QList ,

D28030: Also expose the true minimum size to QML

vkrause created this revision. vkrause added a reviewer: svuorela. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. vkrause requested review of this revision. REVISION SUMMARY Useful in case you want to implement manual scaling there, for example. REPOSITORY

D27951: Allow users to change dropAction to MoveAction through kdeglobals

trmdi added a comment. In D27951#627041 , @ngraham wrote: > In D27951#626346 , @trmdi wrote: > > > When drop an image to the desktop in the FolderView layout, there would be no menu, so users can

D27882: Move KProcessRunner into it's own file

davidedmundson abandoned this revision. davidedmundson added a comment. Outdated by David F's patch REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D27882 To: davidedmundson, apol Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27951: Allow users to change dropAction to MoveAction through kdeglobals

ngraham added a comment. In D27951#626346 , @trmdi wrote: > When drop an image to the desktop in the FolderView layout, there would be no menu, so users can not change the wallpaper by drag in this case. How do you think about this? In

KDE CI: Frameworks » kdeclarative » kf5-qt5 FreeBSDQt5.13 - Build # 87 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kdeclarative/job/kf5-qt5%20FreeBSDQt5.13/87/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Fri, 13 Mar 2020 15:32:35 + Build duration: 1 min 5 sec and counting JUnit Tests Name:

D28028: [KCM Controls GridDelegate] Use `ShadowedRectangle`

This revision was automatically updated to reflect the committed changes. Closed by commit R296:517bcca389d9: [KCM Controls GridDelegate] Use `ShadowedRectangle` (authored by broulik). REPOSITORY R296 KDeclarative CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28028?vs=77567=77571

D21604: Fix building with Qt 5.13

carewolf abandoned this revision. carewolf added a comment. Done independently REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D21604 To: carewolf, bruns, ngraham Cc: alexeymin, kde-frameworks-devel, #baloo, hurikhan77, lots0logs, LeGast00n, cblack, fbampaloukas,

D28028: [KCM Controls GridDelegate] Use `ShadowedRectangle`

broulik edited the test plan for this revision. REPOSITORY R296 KDeclarative REVISION DETAIL https://phabricator.kde.org/D28028 To: broulik, #plasma Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28028: [KCM Controls GridDelegate] Use `ShadowedRectangle`

mart accepted this revision. This revision is now accepted and ready to land. REPOSITORY R296 KDeclarative REVISION DETAIL https://phabricator.kde.org/D28028 To: broulik, #plasma, mart Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28028: [KCM Controls GridDelegate] Use `ShadowedRectangle`

broulik created this revision. broulik added a reviewer: Plasma. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. broulik requested review of this revision. REVISION SUMMARY Instead of expensive `DropShadow` layer. TEST PLAN Left is before, right is after

D27999: [DesktopExecParser] Open {ssh, telnet, rlogin}:// urls with ktelnetservice

feverfew added a comment. don't merge yet, looking at the code I sense something might break here but I need some time to do my own testing first. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D27999 To: ahmadsamir, #frameworks, dfaure, sitter, meven, feverfew Cc:

D17816: Support for xattrs on kio copy/move

cochise updated this revision to Diff 77559. cochise added a comment. As @dfaure sugested, moved the attribute copy logic to a function on file_unix.cpp. As a side effect we lost hability to copy extened attributes of directories, (they are not copied, but created in CopyJob but now all

D17816: Support for xattrs on kio copy/move

cochise commandeered this revision. cochise edited reviewers, added: tmarshall; removed: cochise. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D17816 To: cochise, dfaure, chinmoyr, bruns, #frameworks, tmarshall Cc: scheirle, anthonyfieroni, tmarshall, arrowd, cfeck,

D27947: Port away from deprecated QList::toSet()

ahmadsamir added inline comments. INLINE COMMENTS > apol wrote in kcoredirlister.cpp:1045 > Is this to force dir at the end? You mean at the front? I am not sure, but I matched the behaviour of the original code, it first appended "dir" then the QUrl list from canonicalUrls. It sort of makes

D21466: Recommend rebooting after installing Samba

sitter edited the summary of this revision. REPOSITORY R432 File Sharing (Samba) integration BRANCH recommend-rebooting (branched from master) REVISION DETAIL https://phabricator.kde.org/D21466 To: ngraham, #vdg, #frameworks, #dolphin, apol, sitter Cc: anthonyfieroni, sitter, bruns

D27965: [KPasswdServer] replace foreach with range/index-based for

ahmadsamir updated this revision to Diff 77554. ahmadsamir added a comment. QList::erase() invalidates the iterators REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27965?vs=77477=77554 BRANCH l-kpasswdserver (branched from master) REVISION DETAIL

D27986: Allow providing an error message from the application

sitter added a comment. Looks alright to me now.  REPOSITORY R285 KCrash REVISION DETAIL https://phabricator.kde.org/D27986 To: apol, #frameworks, sitter, dfaure Cc: dfaure, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27947: Port away from deprecated QList::toSet()

apol added inline comments. INLINE COMMENTS > kcoredirlister.cpp:1045 > + > +QList dirs({dir}); > +dirs.append(urlList); Is this to force dir at the end? REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D27947 To: ahmadsamir, #frameworks, dfaure, meven Cc: apol,

D27986: Allow providing an error message from the application

apol updated this revision to Diff 77552. apol added a comment. nullptr REPOSITORY R285 KCrash CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27986?vs=77551=77552 BRANCH master REVISION DETAIL https://phabricator.kde.org/D27986 AFFECTED FILES src/kcrash.cpp

D27947: Port away from deprecated QList::toSet()

ahmadsamir added a comment. Ping. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D27947 To: ahmadsamir, #frameworks, dfaure, meven Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27986: Allow providing an error message from the application

sitter added inline comments. INLINE COMMENTS > kcrash.cpp:107 > + > +static char *s_kcrashErrorMessage; > Q_GLOBAL_STATIC(KCrash::CoreConfig, s_coreConfig) Still needs to be set to nullptr. REPOSITORY R285 KCrash REVISION DETAIL https://phabricator.kde.org/D27986 To: apol, #frameworks,

D27986: Allow providing an error message from the application

apol updated this revision to Diff 77551. apol added a comment. cleanup REPOSITORY R285 KCrash CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27986?vs=77522=77551 BRANCH master REVISION DETAIL https://phabricator.kde.org/D27986 AFFECTED FILES src/kcrash.cpp

D28002: [WIP]Allow disabling of data collection

gvgeo added a comment. >> Currently data is collected by default, with no way of disabling it. > > That's far from true. Things are off by default. Most providers are not run at all. > The commit message is either confused or misleading. I made an assumption, based on the

D28002: [WIP]Allow disabling of data collection

gvgeo edited the summary of this revision. REPOSITORY R849 User Feedback Collection Framework REVISION DETAIL https://phabricator.kde.org/D28002 To: gvgeo, #frameworks, apol, vkrause Cc: davidedmundson, #frameworks

D28020: New class ProcessLauncherJob in KIOGui

dfaure created this revision. dfaure added reviewers: apol, davidedmundson, nicolasfella, vkrause, broulik. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. dfaure requested review of this revision. REVISION SUMMARY This is meant to replace

D27986: Allow providing an error message from the application

sitter added inline comments. INLINE COMMENTS > kcrash.cpp:107 > + > +static char* s_kcrashErrorMessage; > Q_GLOBAL_STATIC(KCrash::CoreConfig, s_coreConfig) - on wrong side of space needs defining to nullptr > kcrash.cpp:994 > +{ > +s_kcrashErrorMessage =

KDE CI: Frameworks » kirigami » kf5-qt5 SUSEQt5.13 - Build # 231 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kirigami/job/kf5-qt5%20SUSEQt5.13/231/ Project: kf5-qt5 SUSEQt5.13 Date of build: Fri, 13 Mar 2020 09:33:48 + Build duration: 2 min 19 sec and counting BUILD ARTIFACTS

KDE CI: Frameworks » kirigami » kf5-qt5 SUSEQt5.12 - Build # 378 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kirigami/job/kf5-qt5%20SUSEQt5.12/378/ Project: kf5-qt5 SUSEQt5.12 Date of build: Fri, 13 Mar 2020 09:33:48 + Build duration: 1 min 40 sec and counting BUILD ARTIFACTS

KDE CI: Frameworks » kirigami » kf5-qt5 FreeBSDQt5.13 - Build # 220 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kirigami/job/kf5-qt5%20FreeBSDQt5.13/220/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Fri, 13 Mar 2020 09:33:48 + Build duration: 47 sec and counting JUnit Tests Name:

KDE CI: Frameworks » kirigami » kf5-qt5 SUSEQt5.13 - Build # 230 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/kirigami/job/kf5-qt5%20SUSEQt5.13/230/ Project: kf5-qt5 SUSEQt5.13 Date of build: Fri, 13 Mar 2020 09:17:00 + Build duration: 42 sec and counting CONSOLE OUTPUT [...truncated 349

KDE CI: Frameworks » kirigami » kf5-qt5 SUSEQt5.12 - Build # 377 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/kirigami/job/kf5-qt5%20SUSEQt5.12/377/ Project: kf5-qt5 SUSEQt5.12 Date of build: Fri, 13 Mar 2020 09:17:00 + Build duration: 1 min 7 sec and counting CONSOLE OUTPUT [...truncated

KDE CI: Frameworks » kirigami » kf5-qt5 FreeBSDQt5.13 - Build # 219 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/kirigami/job/kf5-qt5%20FreeBSDQt5.13/219/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Fri, 13 Mar 2020 09:17:00 + Build duration: 27 sec and counting CONSOLE OUTPUT [...truncated

D27999: [DesktopExecParser] Open {ssh, telnet, rlogin}:// urls with ktelnetservice

ahmadsamir updated this revision to Diff 77538. ahmadsamir added a comment. As pointed out by dfaure, we have to make sure the unit test passes even if KIO isn't installed (which might be the case on the KDE CI system). Since we aren't actually executing the ktelnetservice5 binary and only

D27540: KCModule: Indicate when a setting has been changed from the default or previous value

ervin added a comment. In D27540#617485 , @ervin wrote: > And now you got a screenshot as well. Waiting for further feedback now. Ping? This patch was first created three weeks ago now. Note that look in D27840

D27724: Syncronise setNeedsSave between KCModule and ConfigModule in both directions

meven added inline comments. INLINE COMMENTS > kcmoduleqml.cpp:87 > + > +// changed is also manipulated extermally by KCModule, we need to keep > the Quick implementation in sync > +// TODO KF6 remove the differed "emit changed" in KConfigModule and then > we can remove this here

D28016: KWindowSystem: deprecate KStartupInfoData::launchedBy, unused

zzag added a comment. Do you know why LAUNCHED_BY was added? The spec [1] has no a single word about its potential use cases. [1] https://specifications.freedesktop.org/startup-notification-spec/startup-notification-latest.txt REPOSITORY R278 KWindowSystem REVISION DETAIL

D28016: KWindowSystem: deprecate KStartupInfoData::launchedBy, unused

broulik added a comment. Anything WId also probably won't work on Wayland, so +1 REPOSITORY R278 KWindowSystem REVISION DETAIL https://phabricator.kde.org/D28016 To: dfaure, zzag, broulik, davidedmundson Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27999: [DesktopExecParser] Open {ssh, telnet, rlogin}:// urls with ktelnetservice

meven added a comment. Good to me REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D27999 To: ahmadsamir, #frameworks, dfaure, sitter, meven, feverfew Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D25010: [StatJob] Use A QFlag to specify the details returned by StatJob

meven marked 2 inline comments as done. meven added inline comments. INLINE COMMENTS > kossebau wrote in statjob.h:203 > Ah, was already fixed. 5434ffd0c655b0996e881fec605dc988a672d85c REPOSITORY R241 KIO REVISION

D27966: KParts: add PartLoader as replacement to KMimeTypeTrader for parts

dfaure added a comment. Yeah I guess "looks reasonable" is the most I can expect :-) Any chance you could take a look at https://phabricator.kde.org/D27967 which is needed for this to land? Thanks. REPOSITORY R306 KParts REVISION DETAIL https://phabricator.kde.org/D27966 To:

D27999: [DesktopExecParser] Open {ssh, telnet, rlogin}:// urls with ktelnetservice

dfaure added a comment. Thanks, looks better. One possible problem left: if KIO has never been installed, I guess QStandardPaths::findExecutable(QStringLiteral("ktelnetservice5")) won't find it in builddir/bin. You could push and see what CI says, or you could test locally what happens

D28016: KWindowSystem: deprecate KStartupInfoData::launchedBy, unused

dfaure created this revision. dfaure added reviewers: zzag, broulik, davidedmundson. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. dfaure requested review of this revision. REVISION SUMMARY KRun bothers with a WId in many places just to end up calling

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.13 - Build # 331 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.13/331/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Fri, 13 Mar 2020 06:46:01 + Build duration: 6 min 11 sec and counting JUnit Tests Name:

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.13 - Build # 330 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.13/330/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Fri, 13 Mar 2020 06:38:23 + Build duration: 7 min 35 sec and counting JUnit Tests Name:

KDE CI: Frameworks » kservice » kf5-qt5 SUSEQt5.12 - Build # 126 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kservice/job/kf5-qt5%20SUSEQt5.12/126/ Project: kf5-qt5 SUSEQt5.12 Date of build: Fri, 13 Mar 2020 06:36:48 + Build duration: 2 min 10 sec and counting BUILD ARTIFACTS

KDE CI: Frameworks » kservice » kf5-qt5 SUSEQt5.13 - Build # 100 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kservice/job/kf5-qt5%20SUSEQt5.13/100/ Project: kf5-qt5 SUSEQt5.13 Date of build: Fri, 13 Mar 2020 06:36:48 + Build duration: 2 min 10 sec and counting BUILD ARTIFACTS

KDE CI: Frameworks » kservice » kf5-qt5 FreeBSDQt5.13 - Build # 96 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kservice/job/kf5-qt5%20FreeBSDQt5.13/96/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Fri, 13 Mar 2020 06:36:48 + Build duration: 2 min 12 sec and counting JUnit Tests Name:

KDE CI: Frameworks » kcoreaddons » kf5-qt5 FreeBSDQt5.13 - Build # 117 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20FreeBSDQt5.13/117/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Fri, 13 Mar 2020 06:35:43 + Build duration: 1 min 49 sec and counting JUnit Tests Name:

D27999: [DesktopExecParser] Open {ssh, telnet, rlogin}:// urls with ktelnetservice

ahmadsamir marked 3 inline comments as done. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D27999 To: ahmadsamir, #frameworks, dfaure, sitter, meven, feverfew Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27999: [DesktopExecParser] Open {ssh, telnet, rlogin}:// urls with ktelnetservice

ahmadsamir updated this revision to Diff 77533. ahmadsamir added a comment. - Use QStandardPaths::findExecutable(), as the path isn't hardcoded to /usr/bin/ on all systems - More QVERIFY() REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27999?vs=77521=77533