D28444: WIP/RFC: Add ECMCargo module

IlyaBizyaev added a comment. In D28444#638430 , @cblack wrote: > more than half of Ikona's CMakeLists.txt is boilerplate dedicated to integrating Rust with the rest of the project I don't understand why your function needs a list of Rust

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.14 - Build # 25 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.14/25/ Project: kf5-qt5 FreeBSDQt5.14 Date of build: Tue, 31 Mar 2020 04:19:19 + Build duration: 49 min and counting JUnit Tests Name: projectroot

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.14 - Build # 15 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.14/15/ Project: kf5-qt5 SUSEQt5.14 Date of build: Tue, 31 Mar 2020 04:19:19 + Build duration: 19 min and counting BUILD ARTIFACTS

D28203: Move corner fold to top right in 24 icons

ndavis added inline comments. INLINE COMMENTS > davidhurka wrote in filename-title-amarok.svg:8 > I realized that http://notmart.org/blog/2016/05/icon-colors/ and > https://community.kde.org/Guidelines_and_HOWTOs/Icon_Workflow_Tips#Stylesheets > contratict in the class names. One uses

KDE CI: Frameworks » baloo » kf5-qt5 SUSEQt5.12 - Build # 231 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/baloo/job/kf5-qt5%20SUSEQt5.12/231/ Project: kf5-qt5 SUSEQt5.12 Date of build: Tue, 31 Mar 2020 01:41:09 + Build duration: 2 min 11 sec and counting BUILD ARTIFACTS

KDE CI: Frameworks » baloo » kf5-qt5 SUSEQt5.14 - Build # 10 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/baloo/job/kf5-qt5%20SUSEQt5.14/10/ Project: kf5-qt5 SUSEQt5.14 Date of build: Tue, 31 Mar 2020 01:41:09 + Build duration: 2 min 9 sec and counting BUILD ARTIFACTS

D28452: Fix baloo compile

usta closed this revision. usta added a comment. I still need to learn how to use arc land properly REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D28452 To: usta, #baloo, ngraham, cblack Cc: kde-frameworks-devel, #baloo, hurikhan77, lots0logs, LeGast00n, cblack,

D28452: Fix baloo compile

usta added a commit: R293:ac7f7df21366: Fix compile. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D28452 To: usta, #baloo, ngraham, cblack Cc: kde-frameworks-devel, #baloo, hurikhan77, lots0logs, LeGast00n, cblack, fbampaloukas, GB_2, domson, ashaposhnikov, michaelh,

KDE CI: Frameworks » baloo » kf5-qt5 WindowsMSVCQt5.14 - Build # 44 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/baloo/job/kf5-qt5%20WindowsMSVCQt5.14/44/ Project: kf5-qt5 WindowsMSVCQt5.14 Date of build: Tue, 31 Mar 2020 01:41:09 + Build duration: 1 min 2 sec and counting

KDE CI: Frameworks » baloo » kf5-qt5 FreeBSDQt5.14 - Build # 18 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/baloo/job/kf5-qt5%20FreeBSDQt5.14/18/ Project: kf5-qt5 FreeBSDQt5.14 Date of build: Tue, 31 Mar 2020 01:41:09 + Build duration: 1 min 19 sec and counting JUnit Tests Name:

D28452: Fix baloo compile

cblack accepted this revision. This revision is now accepted and ready to land. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D28452 To: usta, #baloo, ngraham, cblack Cc: kde-frameworks-devel, #baloo, hurikhan77, lots0logs, LeGast00n, cblack, fbampaloukas, GB_2, domson,

D28444: WIP/RFC: Add ECMCargo module

cblack added a comment. In D28444#638435 , @apol wrote: > Will this make all the boilerplate in ikona disappear? It'll bring it down to the same level as everything else. REPOSITORY R240 Extra CMake Modules REVISION DETAIL

D28452: Fix baloo compile

usta added a reviewer: ngraham. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D28452 To: usta, #baloo, ngraham Cc: kde-frameworks-devel, #baloo, hurikhan77, lots0logs, LeGast00n, cblack, fbampaloukas, GB_2, domson, ashaposhnikov, michaelh, astippich, spoorun, ngraham,

D28452: Fix baloo compile

usta edited the summary of this revision. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D28452 To: usta, #baloo Cc: kde-frameworks-devel, #baloo, hurikhan77, lots0logs, LeGast00n, cblack, fbampaloukas, GB_2, domson, ashaposhnikov, michaelh, astippich, spoorun, ngraham,

D28452: Fix baloo compile

usta added a reviewer: Baloo. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D28452 To: usta, #baloo Cc: kde-frameworks-devel, #baloo, hurikhan77, lots0logs, LeGast00n, cblack, fbampaloukas, GB_2, domson, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns,

D28452: Fix baloo compile

usta created this revision. usta added a project: Baloo. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. usta requested review of this revision. REVISION SUMMARY __FUNC__ => __func__ REPOSITORY R293 Baloo REVISION DETAIL

KDE CI: Frameworks » kcoreaddons » kf5-qt5 FreeBSDQt5.14 - Build # 4 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20FreeBSDQt5.14/4/ Project: kf5-qt5 FreeBSDQt5.14 Date of build: Tue, 31 Mar 2020 01:00:21 + Build duration: 3 min 45 sec and counting JUnit Tests Name:

D28397: Replace Vokoscreen with VokoscreenNG

apol added a comment. In D28397#638434 , @harogaston wrote: > In D28397#637602 , @pino wrote: > > > please do //not// change translated keys (eg `Name[lang]`) in desktop-alike files when you change

D28444: WIP/RFC: Add ECMCargo module

apol added a comment. > I feel like one of the reasons KDE doesn't use Rust more is that using it in the build system side is pain. Case in point: more than half of Ikona's CMakeLists.txt is boilerplate dedicated to integrating Rust with the rest of the project. I'd like to get this in ECM

D28397: Replace Vokoscreen with VokoscreenNG

harogaston added a comment. In D28397#637602 , @pino wrote: > please do //not// change translated keys (eg `Name[lang]`) in desktop-alike files when you change the English string: we have a system in place to handle translations Do I

D28444: WIP/RFC: Add ECMCargo module

cblack added a comment. In D28444#638428 , @apol wrote: > I wonder if this is covering a very widespread use-case. If there's just one application that needs it, it could make sense to keep it there and once it's polished, we put it in ECM to

D28444: WIP/RFC: Add ECMCargo module

apol added a comment. Code per se looks okay, not that I've ever used a rust workspace. It does need documentation though. See other ECM modules to see what it looks like. I wonder if this is covering a very widespread use-case. If there's just one application that needs it, it

KDE CI: Frameworks » kcalendarcore » kf5-qt5 FreeBSDQt5.14 - Build # 2 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kcalendarcore/job/kf5-qt5%20FreeBSDQt5.14/2/ Project: kf5-qt5 FreeBSDQt5.14 Date of build: Mon, 30 Mar 2020 21:54:21 + Build duration: 31 min and counting JUnit Tests Name:

KDE CI: Frameworks » baloo » kf5-qt5 FreeBSDQt5.14 - Build # 17 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/baloo/job/kf5-qt5%20FreeBSDQt5.14/17/ Project: kf5-qt5 FreeBSDQt5.14 Date of build: Mon, 30 Mar 2020 21:18:26 + Build duration: 1 min 19 sec and counting CONSOLE OUTPUT

KDE CI: Frameworks » baloo » kf5-qt5 SUSEQt5.14 - Build # 9 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/baloo/job/kf5-qt5%20SUSEQt5.14/9/ Project: kf5-qt5 SUSEQt5.14 Date of build: Mon, 30 Mar 2020 21:17:23 + Build duration: 1 min 7 sec and counting CONSOLE OUTPUT [...truncated 694

KDE CI: Frameworks » baloo » kf5-qt5 WindowsMSVCQt5.14 - Build # 43 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/baloo/job/kf5-qt5%20WindowsMSVCQt5.14/43/ Project: kf5-qt5 WindowsMSVCQt5.14 Date of build: Mon, 30 Mar 2020 21:16:53 + Build duration: 49 sec and counting CONSOLE OUTPUT

KDE CI: Frameworks » baloo » kf5-qt5 SUSEQt5.12 - Build # 230 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/baloo/job/kf5-qt5%20SUSEQt5.12/230/ Project: kf5-qt5 SUSEQt5.12 Date of build: Mon, 30 Mar 2020 21:16:35 + Build duration: 57 sec and counting CONSOLE OUTPUT [...truncated 691

KDE CI: Frameworks » baloo » kf5-qt5 SUSEQt5.12 - Build # 229 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/baloo/job/kf5-qt5%20SUSEQt5.12/229/ Project: kf5-qt5 SUSEQt5.12 Date of build: Mon, 30 Mar 2020 21:15:19 + Build duration: 1 min 14 sec and counting CONSOLE OUTPUT [...truncated

D28396: [MTimeDB] Consolidate time interval handling code

This revision was automatically updated to reflect the committed changes. Closed by commit R293:45db016af9ed: [MTimeDB] Consolidate time interval handling code (authored by bruns). REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28396?vs=78782=78935 REVISION

D28394: [AdvancedQueryParser] Test if quoted phrases are passed correctly

This revision was automatically updated to reflect the committed changes. Closed by commit R293:a73f732c50e0: [AdvancedQueryParser] Test if quoted phrases are passed correctly (authored by bruns). REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE

D28393: [Term] Provide toString(Term) overload for QTest

This revision was automatically updated to reflect the committed changes. Closed by commit R293:a32d1c622627: [Term] Provide toString(Term) overload for QTest (authored by bruns). REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28393?vs=78771=78933 REVISION

D28392: [ResultIterator] Remove unneeded SearchStore forward declaration

This revision was automatically updated to reflect the committed changes. Closed by commit R293:0ce534752415: [ResultIterator] Remove unneeded SearchStore forward declaration (authored by bruns). REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE

D28349: Fix Warnings

bruns added a comment. @iasensio - are you using NFS? INLINE COMMENTS > kdirwatch.cpp:946 > if (KFileSystemType::fileSystemType(e->path) == > KFileSystemType::Nfs) { > preferredMethod = m_nfsPreferredMethod; > } m_nfsPreferredMethod defaults to

D28349: Fix Warnings

iasensio added a comment. I seemed to reach the unreachable when I tried to open an external HDD on dolphin: https://bugs.kde.org/show_bug.cgi?id=419428 `ASSERT failure in Q_UNREACHABLE(): "Q_UNREACHABLE was reached", file /home/isma/kde/src/kcoreaddons/src/lib/io/kdirwatch.cpp, line

D28444: WIP/RFC: Add ECMCargo module

IlyaBizyaev added a comment. I'm not good at CMake modules, but maybe this code (which I used in a project) is useful: https://github.com/Devolutions/CMakeRust REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D28444 To: cblack, #frameworks,

D28355: Introduce function ecm_install_configured_file

kossebau added inline comments. INLINE COMMENTS > kossebau wrote in ECMConfiguredInstall.cmake:62 > These strings (besides the last obviously) should get added with whitespace > suffix, to handle the case where multiple are added, no? Not yet got to > test/run things, just guessing by reading

D28355: Introduce function ecm_install_configured_file

kossebau added a comment. Quick review while I had some spare minutes, to keep things going. INLINE COMMENTS > ECMConfiguredInstall.cmake:5 > +# > +# Take a list of files, runs configure_file and installs it in the given > location. > +# Perhaps "install" -> "install the result" >

KDE CI: Frameworks » kwayland » kf5-qt5 FreeBSDQt5.14 - Build # 6 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kwayland/job/kf5-qt5%20FreeBSDQt5.14/6/ Project: kf5-qt5 FreeBSDQt5.14 Date of build: Mon, 30 Mar 2020 17:13:51 + Build duration: 26 min and counting JUnit Tests Name:

D28444: WIP/RFC: Add ECMCargo module

cblack created this revision. cblack added reviewers: Frameworks, Build System. Herald added projects: Frameworks, Build System. Herald added subscribers: kde-buildsystem, kde-frameworks-devel. cblack requested review of this revision. REVISION SUMMARY The ECMCargo module allows for easy usage

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.14 - Build # 14 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.14/14/ Project: kf5-qt5 SUSEQt5.14 Date of build: Mon, 30 Mar 2020 17:03:02 + Build duration: 20 min and counting BUILD ARTIFACTS

KDE CI: Frameworks » kwayland » kf5-qt5 SUSEQt5.12 - Build # 121 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kwayland/job/kf5-qt5%20SUSEQt5.12/121/ Project: kf5-qt5 SUSEQt5.12 Date of build: Mon, 30 Mar 2020 17:13:51 + Build duration: 5 min 16 sec and counting BUILD ARTIFACTS

KDE CI: Frameworks » kwayland » kf5-qt5 SUSEQt5.14 - Build # 2 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kwayland/job/kf5-qt5%20SUSEQt5.14/2/ Project: kf5-qt5 SUSEQt5.14 Date of build: Mon, 30 Mar 2020 17:13:47 + Build duration: 4 min 55 sec and counting BUILD ARTIFACTS

D27338: Provide an initial implementation for input-method-unstable-v1

apol added a comment. Can we not have the discussion here? I added them already. REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D27338 To: apol, #kwin, #frameworks Cc: davidedmundson, zzag, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28442: Fix warnings

This revision was automatically updated to reflect the committed changes. apol marked an inline comment as done. Closed by commit R127:3a7f50d5f55b: Fix warnings (authored by apol). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D28442?vs=78909=78923#toc REPOSITORY R127 KWayland

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.14 - Build # 24 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.14/24/ Project: kf5-qt5 FreeBSDQt5.14 Date of build: Mon, 30 Mar 2020 17:03:02 + Build duration: 4 min 6 sec and counting JUnit Tests Name:

D28440: Mark KIOFuse mounts as Probably slow

This revision was automatically updated to reflect the committed changes. Closed by commit R241:ec5adbccc23d: Mark KIOFuse mounts as Probably slow (authored by feverfew). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28440?vs=78907=78920 REVISION DETAIL

D28440: Mark KIOFuse mounts as Probably slow

broulik accepted this revision. broulik added a comment. Makes sense since we generally don't want to access those directly anyway REPOSITORY R241 KIO BRANCH slowKIOFUse (branched from master) REVISION DETAIL https://phabricator.kde.org/D28440 To: feverfew, #frameworks, dfaure,

D28440: Mark KIOFuse mounts as Probably slow

meven accepted this revision. meven added a comment. This revision is now accepted and ready to land. Seems fine to me. REPOSITORY R241 KIO BRANCH slowKIOFUse (branched from master) REVISION DETAIL https://phabricator.kde.org/D28440 To: feverfew, #frameworks, dfaure, broulik, bruns,

D28442: Fix warnings

zzag accepted this revision. zzag added inline comments. This revision is now accepted and ready to land. INLINE COMMENTS > buffer_interface.cpp:287-291 > size.width(), > size.height(), >

D27338: Provide an initial implementation for input-method-unstable-v1

zzag added a comment. In D27338#638128 , @davidedmundson wrote: > We can't just make up policy changes ad-hoc on a review request to make it different to every other class in KWayland. Heh, if we really don't want to deviate from the

D27983: Make find-location show a magnifier on a map, to be different to mark-location

ngraham added a comment. Feel free to land this now. REPOSITORY R266 Breeze Icons BRANCH create-find-location REVISION DETAIL https://phabricator.kde.org/D27983 To: davidhurka, #vdg, ngraham, ndavis Cc: ngraham, ndavis, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, bruns

D28203: Move corner fold to top right in 24 icons

ngraham added a comment. You can land this now. We can address the discrepancy between highlight and button focus color usage elsewhere. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D28203 To: davidhurka, #vdg, ndavis, ngraham Cc: ngraham,

D27356: Fix EWMH non-compliance for NET::{OnScreenDisplay, CriticalNotification}

ngraham added a comment. Thanks for the patch! REPOSITORY R278 KWindowSystem REVISION DETAIL https://phabricator.kde.org/D27356 To: catherinez, #kwin, davidedmundson Cc: ngraham, davidedmundson, broulik, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, bruns

D28442: Fix warnings

apol created this revision. apol added reviewers: Frameworks, KWin. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. apol requested review of this revision. REVISION SUMMARY Remove unused variables and members. We were often storing the q of classes without

D28440: Mark KIOFuse mounts as Probably slow

ngraham added a reviewer: meven. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D28440 To: feverfew, #frameworks, dfaure, broulik, bruns, meven Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28372: Added a merged look to the plasmoidheading and remove roundedborders

ngraham added a comment. Awesome, might be something to explore! I think this patch should probably go in too, since even if we have headerbar-style headers, there are still going to be cases where we'll want a second row to put more controls in. But yeah, for the common case of just a

D28396: [MTimeDB] Consolidate time interval handling code

ngraham accepted this revision. This revision is now accepted and ready to land. REPOSITORY R293 Baloo BRANCH submit REVISION DETAIL https://phabricator.kde.org/D28396 To: bruns, #baloo, ngraham Cc: kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, cblack, fbampaloukas, GB_2,

D28394: [AdvancedQueryParser] Test if quoted phrases are passed correctly

ngraham accepted this revision. This revision is now accepted and ready to land. REPOSITORY R293 Baloo BRANCH submit REVISION DETAIL https://phabricator.kde.org/D28394 To: bruns, #baloo, ngraham Cc: kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, cblack, fbampaloukas, GB_2,

D28393: [Term] Provide toString(Term) overload for QTest

ngraham accepted this revision. This revision is now accepted and ready to land. REPOSITORY R293 Baloo BRANCH submit REVISION DETAIL https://phabricator.kde.org/D28393 To: bruns, #baloo, ngraham Cc: kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, cblack, fbampaloukas, GB_2,

D28392: [ResultIterator] Remove unneeded SearchStore forward declaration

ngraham accepted this revision. This revision is now accepted and ready to land. REPOSITORY R293 Baloo BRANCH submit REVISION DETAIL https://phabricator.kde.org/D28392 To: bruns, #baloo, ngraham Cc: kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, cblack, fbampaloukas, GB_2,

D28440: Mark KIOFuse mounts as Probably slow

feverfew added reviewers: Frameworks, dfaure, broulik, bruns. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D28440 To: feverfew, #frameworks, dfaure, broulik, bruns Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28440: Mark KIOFuse mounts as Probably slow

feverfew created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. feverfew requested review of this revision. REVISION SUMMARY Mark KIOFuse mounts as "Probably Slow". Note that this isn't always true, there are plenty of slaves that simply

D28372: Added a merged look to the plasmoidheading and remove roundedborders

ahiemstra added subscribers: ndavis, ahiemstra. ahiemstra added a comment. The same thing was actually proposed by I think @ndavis a while back, see https://phabricator.kde.org/T10470#219994 . To summarize, it's perfectly technically possible and I actually rather like it. REPOSITORY

D27338: Provide an initial implementation for input-method-unstable-v1

davidedmundson added a comment. > After reading some inline comments in D28295 , I think it would be better to get rid of the nested private class thing. We won't need to use Q_DECL_HIDDEN and this is what Qt folks do. :-) We can't just make up

D27338: Provide an initial implementation for input-method-unstable-v1

zzag added a comment. > If it makes you happy. But we're building with opt-in export symbols, it shouldn't make much of a difference. After reading some inline comments in D28295 , I think it would be better to get rid of the nested private class

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.14 - Build # 23 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.14/23/ Project: kf5-qt5 FreeBSDQt5.14 Date of build: Mon, 30 Mar 2020 13:50:20 + Build duration: 4 min 38 sec and counting JUnit Tests Name:

D28298: Reduce superfluous changedEntriesChanged emissions

leinir added inline comments. INLINE COMMENTS > Button.qml:90 > -value: ghnsDialog.engine.changedEntries > -} > Given the various annoying side effects of the cleaner solutions, perhaps reintroduce this, but add a "when" clause to ensure it only happens when we want it to? Maybe

D28355: Introduce function ecm_install_configured_file

davidedmundson updated this revision to Diff 78887. davidedmundson added a comment. All of the things! Only strips suffix ".in". REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28355?vs=78693=78887 BRANCH master REVISION DETAIL

D28423: [kioclient] Fix 'kioclient5 --commands' usage messages

This revision was automatically updated to reflect the committed changes. Closed by commit R126:30a713025624: [kioclient] Fix kioclient5 --commands usage messages (authored by ahmadsamir). REPOSITORY R126 KDE CLI Utilities CHANGES SINCE LAST UPDATE

D28423: [kioclient] Fix 'kioclient5 --commands' usage messages

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R126 KDE CLI Utilities BRANCH l-help-messages (branched from master) REVISION DETAIL https://phabricator.kde.org/D28423 To: ahmadsamir, #frameworks, dfaure, apol Cc: kde-frameworks-devel,

D28421: Add static method to check start condition

This revision was automatically updated to reflect the committed changes. Closed by commit R309:fe5c63b177a1: Add static method to check start condition (authored by hchain). REPOSITORY R309 KService CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28421?vs=78864=78870 REVISION

D28421: Add static method to check start condition

davidedmundson accepted this revision. This revision is now accepted and ready to land. REPOSITORY R309 KService REVISION DETAIL https://phabricator.kde.org/D28421 To: hchain, davidedmundson, broulik, dfaure, kossebau Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham,

D28421: Add static method to check start condition

hchain retitled this revision from "Add a new standalone executable to replace X-KDE-Autostart-Condition" to "Add static method to check start condition". hchain edited the summary of this revision. hchain edited the test plan for this revision. REPOSITORY R309 KService REVISION DETAIL

D28421: Add static method to check start condition

hchain updated this revision to Diff 78864. hchain added a comment. void REPOSITORY R309 KService CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28421?vs=78863=78864 REVISION DETAIL https://phabricator.kde.org/D28421 AFFECTED FILES src/services/kautostart.cpp

D28421: Add a new standalone executable to replace X-KDE-Autostart-Condition

hchain updated this revision to Diff 78863. hchain added a comment. remove binary REPOSITORY R309 KService CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28421?vs=78848=78863 REVISION DETAIL https://phabricator.kde.org/D28421 AFFECTED FILES src/services/kautostart.cpp

D28221: Don't write default value to configuration file when default value came from /etc/* file

bport added a comment. > !hasDefault() checks [system config files] and therefore should stay. Otherwise, when the situation is C++=1 system=2 and value to be written is 1 you'll revert() i.e. not write anything and then re-read 2, oops. > Sounds like you should add a unittest for this

D28128: Add force save behavior to KEntryMap

bport updated this revision to Diff 78861. bport marked 3 inline comments as done. bport added a comment. Take in consideration ervin feedback REPOSITORY R237 KConfig CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28128?vs=78503=78861 REVISION DETAIL

D28221: Don't write default value to configuration file when default value came from /etc/* file

bport updated this revision to Diff 78862. bport added a comment. Take in consideration dfaure and ervin feedback REPOSITORY R237 KConfig CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28221?vs=78292=78862 REVISION DETAIL https://phabricator.kde.org/D28221 AFFECTED FILES

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.14 - Build # 22 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.14/22/ Project: kf5-qt5 FreeBSDQt5.14 Date of build: Mon, 30 Mar 2020 08:39:49 + Build duration: 19 min and counting JUnit Tests Name: projectroot

KDE CI: Frameworks » kcoreaddons » kf5-qt5 FreeBSDQt5.14 - Build # 3 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20FreeBSDQt5.14/3/ Project: kf5-qt5 FreeBSDQt5.14 Date of build: Mon, 30 Mar 2020 08:37:39 + Build duration: 16 min and counting JUnit Tests Name:

D28387: [QueryTest] Make phrase test case data driven and extend

This revision was automatically updated to reflect the committed changes. Closed by commit R293:07c3c2550507: [QueryTest] Make phrase test case data driven and extend (authored by bruns). REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28387?vs=78757=78858

D28384: [Extractor] Delay mimetype check, cleanup debug output

This revision was automatically updated to reflect the committed changes. Closed by commit R293:6e0dd3e35389: [Extractor] Delay mimetype check, cleanup debug output (authored by bruns). REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28384?vs=78745=78857

D27951: Allow users to change dropAction to MoveAction through kdeglobals

trmdi added a comment. In D27951#637690 , @meven wrote: > Look into kde connect kioslave. > That does not concern this diff much though. I don't understand this. I'm using KMountPoint to check if source and dest are on the same

KDE CI: Frameworks » kcoreaddons » kf5-qt5 SUSEQt5.12 - Build # 175 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20SUSEQt5.12/175/ Project: kf5-qt5 SUSEQt5.12 Date of build: Mon, 30 Mar 2020 08:37:39 + Build duration: 3 min 3 sec and counting BUILD ARTIFACTS

D28423: [kioclient] Fix 'kioclient5 --commands' usage messages

ahmadsamir created this revision. ahmadsamir added reviewers: Frameworks, dfaure, apol. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ahmadsamir requested review of this revision. REVISION SUMMARY It should use 'kioclient5'. REPOSITORY R126 KDE CLI Utilities

D28355: Introduce function ecm_install_configured_file

davidedmundson added a comment. I agree with almost all those suggestions. Though it's a lot more complex, so I might need some help with some of that. As for intended usages, it came up on: D28305 for a lot of .service files with a binary location

D28421: Add a new standalone executable to replace X-KDE-Autostart-Condition

davidedmundson added inline comments. INLINE COMMENTS > hchain wrote in kde-systemd-start-condition.cpp:20 > so I could silently join the arguments with spaces ? As long as kde-systemd-start-condition "foo bar:foo bar:foo:true" does work properly, we can leave this as-is and just make sure

D28421: Add a new standalone executable to replace X-KDE-Autostart-Condition

hchain added inline comments. INLINE COMMENTS > davidedmundson wrote in kde-systemd-start-condition.cpp:17 > Should it be showHelp(255)? > > Not that we should end up here in the generated case. I intentionally return 0 here to mimic the behavior of KAutostart which returns true if the

D27455: FileWidgets: Ignore Return events from KDirOperator

ahmadsamir added a comment. I tested this diff, and it seemed to work as expected. REPOSITORY R241 KIO BRANCH arcpatch-D27455 REVISION DETAIL https://phabricator.kde.org/D27455 To: meven, dfaure, ngraham, #frameworks Cc: ahmadsamir, kde-frameworks-devel, LeGast00n, cblack, GB_2,

D28421: Add a new standalone executable to replace X-KDE-Autostart-Condition

davidedmundson added a comment. Code is fine; both the change in KAutostart and the helper. I'm not sure if this the helper should be in the framework. X-KDE-Autostart condition is very tied to Plasma doing the booting, at which point we're better off putting the binary in

D27455: FileWidgets: Ignore Return events from KDirOperator

ahmadsamir added inline comments. INLINE COMMENTS > kfilewidget.cpp:1913 > +} else if (watched == d->ops && event->type() == QEvent::KeyPress) { > +if (keyEvent->key() == Qt::Key_Return) { > +// ignore return events from the KDirOperator I would combine the two if's

D28421: Add a new standalone executable to replace X-KDE-Autostart-Condition

hchain created this revision. hchain added reviewers: davidedmundson, broulik, dfaure, kossebau. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. hchain requested review of this revision. REVISION SUMMARY For systemd autostart generator will add a

D27356: Fix EWMH non-compliance for NET::{OnScreenDisplay, CriticalNotification}

This revision was automatically updated to reflect the committed changes. Closed by commit R278:d3bc79da9256: Fix EWMH non-compliance for NET::{OnScreenDisplay,CriticalNotification} (authored by catherinez, committed by zzag). REPOSITORY R278 KWindowSystem CHANGES SINCE LAST UPDATE

D27951: Allow users to change dropAction to MoveAction through kdeglobals

meven added a comment. In D27951#637118 , @trmdi wrote: > In D27951#637038 , @dfaure wrote: > > > Indeed. Bug in kio_file, fixed in D28388 . > > > Ok, it

D28295: Introduce KNotificationJobUiDelegate

broulik updated this revision to Diff 78839. broulik added a comment. - Use `QScopedPointer` - No nested private class - Store `description` and use it as notification title REPOSITORY R289 KNotifications CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28295?vs=78644=78839

D28295: Introduce KNotificationJobUiDelegate

broulik marked 5 inline comments as done. REPOSITORY R289 KNotifications REVISION DETAIL https://phabricator.kde.org/D28295 To: broulik, #frameworks, nicolasfella, dfaure Cc: kossebau, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28295: Introduce KNotificationJobUiDelegate

broulik added a comment. > To get the description, just connect to the description signal and store it, until the time you need to show the error? Should the jew app start jobs have one, maybe? REPOSITORY R289 KNotifications REVISION DETAIL https://phabricator.kde.org/D28295 To: