D9048: [kglobalaccel] Drop QWidget dependency

anthonyfieroni added inline comments. INLINE COMMENTS > davidedmundson wrote in CMakeLists.txt:36 > lib still uses widgets, I doubt this will compile. > If it does, it's because it's pulled in from something else. > > (in fact the runtime links against them too, but for a hidden window to >

D9048: [kglobalaccel] Drop QWidget dependency

anthonyfieroni updated this revision to Diff 23132. anthonyfieroni added a comment. It compiles. REPOSITORY R268 KGlobalAccel CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9048?vs=23126=23132 REVISION DETAIL https://phabricator.kde.org/D9048 AFFECTED FILES CMakeLists.txt

D9048: [kglobalaccel] Drop QWidget dependency

anthonyfieroni created this revision. anthonyfieroni added reviewers: davidedmundson, apol. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. REPOSITORY R268 KGlobalAccel REVISION DETAIL https://phabricator.kde.org/D9048 AFFECTED

D8964: Fix two bugs in KMessageWidget

anthonyfieroni added a comment. It looks good. INLINE COMMENTS > kmessagewidget.cpp:348 > +d->content->move(0, 0); > +setFixedHeight(d->content->height()); > +} Those it should be setFixedHeight(sizeHint().height()); REPOSITORY R236 KWidgetsAddons

D9005: fix crash during file copy after message box warning

anthonyfieroni added a comment. You can discard this one in front of https://phabricator.kde.org/D9004 REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D9005 To: jtamate, #frameworks, dfaure Cc: anthonyfieroni, elvisangelaccio

D8007: popplerextractor: don't try to guess the title if there isn't one.

anthonyfieroni added a comment. About me it's a good feature after all. It should be simplified e.g. only when title is empty and parse only header of first page. REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D8007 To: flameeyes, #frameworks, mgallien Cc:

D9004: Input validation of SubJobs

anthonyfieroni accepted this revision. anthonyfieroni added inline comments. INLINE COMMENTS > kcompositejob.cpp:98 > { > +Q_D(KCompositeJob); > // Did job have an error ? This is not needed anymore. REPOSITORY R244 KCoreAddons REVISION DETAIL https://phabricator.kde.org/D9004

D9004: Input validation of SubJobs

anthonyfieroni added inline comments. INLINE COMMENTS > kcompositejob.cpp:104 > setErrorText(job->errorText()); > -emitResult(); > +// Finish this KCompositeJob only if it has no subjobs > +if (d->subjobs.isEmpty()) { David mean to finish job on first error,

D8366: Factoring out lists of url data within KFilePlacesModelTest

anthonyfieroni added a comment. Ship it, it's only tests and looks good. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D8366 To: franckarrecot, renatoo, ervin, mlaurent Cc: anthonyfieroni, ervin, ngraham, mlaurent, #frameworks

D9004: Input validation of SubJobs

anthonyfieroni added inline comments. INLINE COMMENTS > dfaure wrote in kcompositejob.cpp:102 > When a subclass calls this slotResult implementation, they expect the > behaviour of "finish with an error if the subjob had an error". > > But NOT emitResult in the normal case (no error), since we

D9004: Input validation of SubJobs

anthonyfieroni added inline comments. INLINE COMMENTS > dfaure wrote in kcompositejob.cpp:102 > No no no this is all wrong, please don't change the logic here. > After a subjob is done, we might want to start another one. > Most KIO jobs work like that. Yeah, you are right, but we ever emit on

D8536: Add more hashing algorithms to KPropertiesDialog

anthonyfieroni added a comment. > ! In https://phabricator.kde.org/D8536#172105, @elvisangelaccio wrote: > > Unfortunately many websites only show you the SHA1 or, even worse, only the MD5 of the file. As I said, it doesn't matter that your preferred algo is e.g. SHA256, if the website

D8536: Add more hashing algorithms to KPropertiesDialog

anthonyfieroni added inline comments. INLINE COMMENTS > kpropertiesdialog.cpp:2904-2906 > +if (calculateButton == nullptr || copyButton == nullptr) { > +return; > +} It's a private function, i can't image why it can be call with null pointers :) REPOSITORY R241 KIO REVISION

D9004: Input validation of SubJobs

anthonyfieroni added a comment. In https://phabricator.kde.org/D9004#172096, @jtamate wrote: > - I can't reproduce now bug 364039 even without a patched kio But to be correct as needed KIO' one should land too when David accept it. INLINE COMMENTS > kcompositejob.cpp:104 >

D9005: fix crash during file copy after message box warning

anthonyfieroni added a comment. +1 Could you please check, while you are on KCoreAddons and KIO for other jobs that emitting result in same way? REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D9005 To: jtamate, #frameworks, dfaure Cc: anthonyfieroni,

D9004: Input validation of SubJobs

anthonyfieroni requested changes to this revision. anthonyfieroni added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > kcompositejob.cpp:67 > +if (d->subjobs.removeAll(job) > 0) { > +job->setParent(nullptr); > +return true; We don't want to

D8983: Properly parse dates in cookies when running in non-English locale

anthonyfieroni added inline comments. INLINE COMMENTS > kcookiejar.cpp:78-84 > +static const char *const day_name[] = { > + "Mon", "Tue", "Wed", "Thu", "Fri", "Sat", "Sun" > +}; > +for (int i = 0; i < 7; ++i) { > +// No need to check for long names

D9001: Better handle of subjobs

anthonyfieroni added a comment. It should be two different patches, one in KIO and one in KCoreAddons. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D9001 To: jtamate, #frameworks, dfaure Cc: anthonyfieroni, ltoscano

D8999: KJob: add start(int delay) method

anthonyfieroni added inline comments. INLINE COMMENTS > rjvbb wrote in kjob.cpp:98 > In fact, are you sure that KJob::start won't be ambiguous? Trying to compile > this with clang++ I get > > src/lib/jobs/kjob.cpp:98:5: error: no matching function for call to > 'singleShot' >

D8999: KJob: add start(int delay) method

anthonyfieroni added inline comments. INLINE COMMENTS > kjob.cpp:98 > +{ > +QTimer::singleShot(delay, this, SLOT(start())); > +} Use new syntax QTimer::singleShot(delay, this, ::start); > kjob.h:182 > + */ > +Q_SCRIPTABLE virtual void start(int delay); > + You cannot add a

D8971: Port from QDom to QXmlStreamReader

anthonyfieroni added inline comments. INLINE COMMENTS > currency.cpp:713 > +const auto multiplier = > attributes.value(QLatin1String("rate")).toDouble(); > +if (multiplier != 0) { > +

D8098: Strip down and re-write the baloo tags KIO slave

anthonyfieroni added inline comments. INLINE COMMENTS > kio_tags.cpp:363 > + > +if (result.decodedUrl.contains(QStringLiteral("?//")) || > chopLastSection) { > +result.tag = result.tag.section(QDir::separator(), 0, -2); Better reverse conditions if (chopLastSection

D8908: KDateComboBox: fix dateChanged() not emitted after typing a date

anthonyfieroni added a comment. +1 REPOSITORY R236 KWidgetsAddons REVISION DETAIL https://phabricator.kde.org/D8908 To: dfaure, cfeck, dvratil Cc: anthonyfieroni, #frameworks, #kde_pim

D8908: KDateComboBox: fix dateChanged() not emitted after typing a date

anthonyfieroni added inline comments. INLINE COMMENTS > kdatecombobox.cpp:350-351 > +connect(lineEdit(), ::returnPressed, this, [this]() { > +emit dateEntered(date()); > +emit dateChanged(date()); > +}); Why not d->enterDate(date()); ? REPOSITORY R236

D8811: [knewstuff] Do not leak ImageLoader on error

This revision was automatically updated to reflect the committed changes. Closed by commit R304:ab6a48778bbe: [knewstuff] Do not leak ImageLoader on error (authored by anthonyfieroni). REPOSITORY R304 KNewStuff CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8811?vs=22408=22501

D8811: [knewstuff] Do not leak ImageLoader on error

anthonyfieroni updated this revision to Diff 22408. REPOSITORY R304 KNewStuff CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8811?vs=22391=22408 REVISION DETAIL https://phabricator.kde.org/D8811 AFFECTED FILES src/core/engine.cpp src/core/imageloader.cpp

D8811: [knewstuff] Do not leak ImageLoader on error

anthonyfieroni added inline comments. INLINE COMMENTS > leinir wrote in engine.cpp:536 > You did add l to the capture, but unless i'm missing something super > obvious... you're not using it ;) i meant to do something like add `<< > l->job()->errorText()` to the debug statement so we can see

D8811: [knewstuff] Do not leak ImageLoader on error

anthonyfieroni updated this revision to Diff 22391. REPOSITORY R304 KNewStuff CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8811?vs=22371=22391 REVISION DETAIL https://phabricator.kde.org/D8811 AFFECTED FILES src/core/engine.cpp src/core/imageloader.cpp

D8811: [knewstuff] Do not leak ImageLoader on error

anthonyfieroni marked an inline comment as done. REPOSITORY R304 KNewStuff REVISION DETAIL https://phabricator.kde.org/D8811 To: anthonyfieroni, leinir, dfaure Cc: broulik, #frameworks, ZrenBot

D8811: [knewstuff] Do not leak ImageLoader on error

anthonyfieroni updated this revision to Diff 22371. REPOSITORY R304 KNewStuff CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8811?vs=22308=22371 REVISION DETAIL https://phabricator.kde.org/D8811 AFFECTED FILES src/core/engine.cpp src/core/imageloader.cpp

D8811: [knewstuff] Do not leak ImageLoader on error

anthonyfieroni added inline comments. INLINE COMMENTS > broulik wrote in engine.cpp:536 > You're copying `entry` into the lambda just for a debug. If / when someone want to read debug messages, they will be consistent. > broulik wrote in imageloader_p.h:59 > Why have this argument if you're

D8811: [knewstuff] Do not leak ImageLoader on error

anthonyfieroni created this revision. anthonyfieroni added reviewers: leinir, dfaure. anthonyfieroni added a project: KNewStuff. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY 1. Notify engine to not observe image

D5111: Provide demo/preview for checkable menu items

anthonyfieroni added a dependent revision: D8741: [kget] Fix a crash when opening the transfer history dialog. REPOSITORY R113 Oxygen Theme REVISION DETAIL https://phabricator.kde.org/D5111 To: rjvbb, hpereiradacosta, jriddell, zhigalin, anthonyfieroni Cc: ltoscano, kde-mac, #frameworks

D5111: Provide demo/preview for checkable menu items

anthonyfieroni removed a dependent revision: D8741: [kget] Fix a crash when opening the transfer history dialog. REPOSITORY R113 Oxygen Theme REVISION DETAIL https://phabricator.kde.org/D5111 To: rjvbb, hpereiradacosta, jriddell, zhigalin, anthonyfieroni Cc: ltoscano, kde-mac, #frameworks

D8536: Add more hashing algorithms to KPropertiesDialog

anthonyfieroni added a comment. In https://phabricator.kde.org/D8536#165865, @elvisangelaccio wrote: > As I mentioned, using //only// a combobox doesn't work, because the main functionality (= check integrity of downloaded files) is now harder to use. In other hand moslty user

D8536: Add more hashing algorithms to KPropertiesDialog

anthonyfieroni added inline comments. INLINE COMMENTS > kpropertiesdialog.cpp:2657 > +class KChecksumAlgorithmListModel: public QAbstractListModel { > +QVector algorithms; > + Make it static const and initialize it here. > kpropertiesdialog.cpp:2681-2682 > +QVariant data(const

D8705: Remove Qt5::Widgets as a dependency

anthonyfieroni added a comment. One more place -> kselectionowner.cpp:37 Dropping can't be done before KF6 :) REPOSITORY R278 KWindowSystem REVISION DETAIL https://phabricator.kde.org/D8705 To: apol, #frameworks Cc: anthonyfieroni

D7401: Solid/Mac : fleshing out the skeleton IOKit backend (WIP)

anthonyfieroni added inline comments. INLINE COMMENTS > cfhelper.cpp:51-56 > +static QVariant q_toVariant(const CFTypeRef , bool verbose=false) > { > const CFTypeID typeId = CFGetTypeID(obj); > +// if (verbose) { > +// qWarning() << "CFTypeID for obj" << obj << "=" << typeId <<

D8348: Add a section for removable devices

anthonyfieroni added inline comments. INLINE COMMENTS > kfileplacesitem.cpp:90 > > +if (m_device.udi().isEmpty()) > +updateDeviceInfo(m_bookmark.metaDataItem(QStringLiteral("UDI"))); Braces even on one line block. > kfileplacesitem.cpp:328 > +{ > +if (m_device.udi() != udi) {

D8347: KIO::PreviewJob::defaultPlugins() function

anthonyfieroni added inline comments. INLINE COMMENTS > previewjob.cpp:740 > +{ > +QStringList blacklist = QStringList() > +<< QStringLiteral("textthumbnail"); const QStringList blackList = { QStringLiteral("textthumbnail") }; REPOSITORY R241 KIO REVISION

D8333: fix some indenters from randomly invoking indent

anthonyfieroni added inline comments. INLINE COMMENTS > kateindentscript.cpp:47 > > m_triggerCharactersSet = true; > But if triggerCharacters are undefined this variable should be false, no? REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D8333 To: brauch,

D8303: Show Date Modified information by default in Dolphin's Information Panel and Tooltips

anthonyfieroni added a comment. Baloo doesn't have active developers so you can add Aacid to accept it. INLINE COMMENTS > metadatafilter.cpp:44 > { > const int currentVersion = 6; // increase version, if the blacklist of > disabled > // properties should be updated Increase it

D7446: Add a Recent Documents places item to Dolphin and file pickers by default

anthonyfieroni added a comment. > In https://phabricator.kde.org/D7446#154790, @ngraham wrote: > I'm not sure exactly what this is referring to. Can you clarify? https://api.kde.org/frameworks/kconfigwidgets/html/classKRecentFilesAction.html REPOSITORY R241 KIO REVISION DETAIL

D8243: Implement support for categories on KfilesPlacesView

anthonyfieroni added inline comments. INLINE COMMENTS > renatoo wrote in kfileplacesview.cpp:169 > Humm I did not know about this opt.index property. Did some debug here and > it is always -1 . > > Sorry but I am not sure why should I care about opt.index? Checking the > "index" arg is not

D8243: Implement support for categories on KfilesPlacesView

anthonyfieroni added inline comments. INLINE COMMENTS > renatoo wrote in kfileplacesview.cpp:169 > m_dragModeCount is used as workaround to draw items on floating window during > the drag. > > When drag starts it save the number of selected items and until we draw all > selected items once we

D8243: Implement support for categories on KfilesPlacesView

anthonyfieroni added inline comments. INLINE COMMENTS > anthonyfieroni wrote in kfileplacesview.cpp:1150 > This calculation makes no sense to me. We have ((x - (y/2) * rowCount) / > rowCount so rowCount can be removed no? Now i see i'm in wrong :) REPOSITORY R241 KIO REVISION DETAIL

D8243: Implement support for categories on KfilesPlacesView

anthonyfieroni added inline comments. INLINE COMMENTS > kfileplacesview.cpp:169 > +// if is drawing the floating element used by drag/drop, does not > draw the header > +if (m_dragModeCount == 0) { > +drawSectionHeader(painter, opt, index); Why you are sure that

D8243: Implement support for categories on KfilesPlacesView

anthonyfieroni added inline comments. INLINE COMMENTS > kfileplacesview.cpp:424 > +if (m_sectionHeaderHeight == -1) { > +m_sectionHeaderHeight = option.fontMetrics.height(); > +} So you mean sizeHint have a right height ? This height store looks like a workaround. REPOSITORY

D7446: Add a Recent Documents places item to Dolphin and file pickers by default

anthonyfieroni added a comment. You can add recent documents as an action like in Kate. Places model looks in not correct destination. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D7446 To: ngraham, #dolphin, #kde_applications, broulik, elvisangelaccio, dfaure,

D8243: Implement support for categories on KfilesPlacesView

anthonyfieroni added inline comments. INLINE COMMENTS > kfileplacesview.cpp:104 > + > +int m_sectionRole; > + const > kfileplacesview.cpp:1065-1066 > const int maxWidth = q->viewport()->width() - textWidth - 4 * margin - 1; > -const int maxHeight = ((q->height() - (fm.height() /

D8243: Implement support for categories on KfilesPlacesView

anthonyfieroni added a reviewer: dfaure. anthonyfieroni added inline comments. INLINE COMMENTS > kfileplacesview.h:37 > */ > -class KIOFILEWIDGETS_EXPORT KFilePlacesView : public QListView > +class KIOFILEWIDGETS_EXPORT KFilePlacesView : public KCategorizedView > { You cannot do that, you

D7660: Fix a regression caused by changing backspace key behavior

anthonyfieroni added inline comments. INLINE COMMENTS > katedocument.cpp:3169-3223 > if (!(config()->backspaceIndents())) { > // ordinary backspace > -KTextEditor::Cursor beginCursor(line, > view->textLayout(c)->previousCursorPosition(c.column())); > +

D7884: - Increase size of trailing mark

anthonyfieroni added inline comments. INLINE COMMENTS > katerenderer.cpp:272 > + > +pen.setWidthF(spaceWidth() / (3.5 - (m_markerSize * 0.5))); > pen.setCapStyle(Qt::RoundCap); You can move width calculation in setmarkersize to safe unwanted calculations. > katerenderer.h:406 >

D7750: fix crash when more than one instances of ExtractorCollection are destructed

anthonyfieroni added a subscriber: dfaure. anthonyfieroni added a comment. Add @dfaure to accept it. INLINE COMMENTS > extractor.cpp:34 > { > -delete d->m_plugin; > +if (d) { > +if (d->m_pluginLoader.isLoaded()) { d *should* never be nullptr REPOSITORY R286 KFileMetaData

D7870: Don't crash if a client (legally) uses a deleted global

anthonyfieroni added inline comments. INLINE COMMENTS > davidedmundson wrote in blur_interface.cpp:49 > I'm not going to get a callback on a resource if the resource doesn't exist. > (Libwayland would have already crashed if that happens) > > That's not what we're guarding against here. I

D7870: Don't crash if a client (legally) uses a deleted global

anthonyfieroni added inline comments. INLINE COMMENTS > blur_interface.cpp:49 > static Private *cast(wl_resource *r) { > -return reinterpret_cast(wl_resource_get_user_data(r)); > +auto blurManager = >

D7849: Fix the tray icon scaling on HiDPI screens

anthonyfieroni added a comment. So, Kai is right, it roundToIconSize only round size independent from dpi. Then when it used, it should be multiplyed by dpi. REVISION DETAIL https://phabricator.kde.org/D7849 To: pgkos, #plasma Cc: anthonyfieroni, broulik, #frameworks, davidedmundson,

D7750: fix crash when more than one instances of ExtractorCollection are destructed

anthonyfieroni added inline comments. INLINE COMMENTS > extractor.cpp:39-46 > +if (d) { > +if (d->m_pluginLoader.isLoaded()) { > +d->m_pluginLoader.unload(); > +} else { > +delete d->m_plugin; > +} > +} Make a method to call it, here and

D7750: fix crash when more than one instances of ExtractorCollection are destructed

anthonyfieroni added a comment. https://phabricator.kde.org/source/kfilemetadata/browse/master/src/extractorcollection.cpp;621101fd9e9d82be3d84f2140a4bf53ea13fd3f0$137 Look it leak now, no? REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D7750 To: mgallien,

D7531: Update SurfaceInterface outputs when an output global gets destroyed

anthonyfieroni added inline comments. INLINE COMMENTS > surface_interface.cpp:813 > +setOutputs(outputs); > +}}, Qt::UniqueConnection); > } UniqueConnection with lambda ? REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D7531 To:

D5656: Adds method to force the reloading of a document

anthonyfieroni added a comment. Make a protected constructor Document::Document(DocumentPrivate ) : d(dd) {} In KateDocument extend DocumentPrivate with KateDocumentPrivate, override documentReload and give it to base Document KateDocument(...) : Document(*new

D7078: [server] Fix crash when sending selection to a DDI without a DataSource

anthonyfieroni added a comment. But what is point to have a DataOfferInterface without valid source? REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D7078 To: graesslin, #kwin, #plasma, #frameworks Cc: anthonyfieroni, davidedmundson, plasma-devel, leezu, ZrenBot,

Re: Review Request 130179: Improve usability of "Open With" dialog by adding option to filter the application tree

tps://git.reviewboard.kde.org/r/130179/#comment68845> Remove trailing spaces. Kate -> settings -> open/save -> remove trailing spaces -> in entire document - Anthony Fieroni On Юли 12, 2017, 8:33 след обяд, Si

D6473: Crash when replacing new lines with spaces

anthonyfieroni added a comment. https://phabricator.kde.org/source/ktexteditor/browse/master/src/render/katelayoutcache.cpp;ad51cece443bc6bb643fa4ca94293a13d3c2f852$321 The problem is ```realLine >= m_renderer->doc()->lines()``` it return a nullptr. First of all

D6624: do not crash qaccessible by causing a resize in a resize event

anthonyfieroni added inline comments. INLINE COMMENTS > kcharselect.cpp:251 > +connect(timer, ::timeout, [&,timer]() { > +d->_k_resizeCells(); > +timer->deleteLater(); QSignalBlocker blockResize(this) ? REPOSITORY R236 KWidgetsAddons REVISION DETAIL

D6608: [PlasmaComponents Menu] Don't crash on null action

anthonyfieroni added inline comments. INLINE COMMENTS > qmenuitem.cpp:47 > +m_hasExplicitAction = true; > +delete m_action; > +m_action = nullptr; Why delete it? if (!a) { setVisible(false); return; } // m_action stays last one,

D6518: guard against themes without a valid shadow

anthonyfieroni added inline comments. INLINE COMMENTS > dialogshadows.cpp:270 > { > m_shadowPixmaps << q->pixmap(element); > } Validate element (hasElement and > 0) or add default pixmap. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D6518

D6116: Add new stateChanged() signal to active connection

anthonyfieroni added inline comments. INLINE COMMENTS > activeconnection.h:77 > +DeviceRealizeFailedReason, /**< Could not create the software device > link. */ > +DeviceRemoved /** < The device this connection depended on > disappeared. */ > +}; All others are composed

D4711: Ungrab mouse on menu close

anthonyfieroni abandoned this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D4711 To: anthonyfieroni, #plasma, mart, broulik, davidedmundson Cc: mvourlakos, plasma-devel, #frameworks, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed,

D4711: Ungrab mouse on menu close

anthonyfieroni updated this revision to Diff 14014. REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D4711?vs=11600=14014 REVISION DETAIL https://phabricator.kde.org/D4711 AFFECTED FILES src/scriptengines/qml/plasmoid/appletinterface.cpp

D4711: Ungrab mouse on menu close

anthonyfieroni added a reviewer: davidedmundson. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D4711 To: anthonyfieroni, #plasma, mart, broulik, davidedmundson Cc: mvourlakos, plasma-devel, #frameworks, spstarr, progwolff, lesliezhai, ali-mohamed,

Re: Review Request 129983: [RFC] PoC patch for polkit support in kio.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129983/#review103158 --- ping apps 17.04 are out, this ca be useful - Anthony

D5515: Update the ungrabMouse hack for Qt 5.8

anthonyfieroni added a comment. David, it's sould be done in plasma-framework too. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D5515 To: davidedmundson, #plasma, mart Cc: anthonyfieroni, mvourlakos, plasma-devel, #frameworks, spstarr,

D5515: Update the ungrabMouse hack for Qt 5.8

anthonyfieroni added a comment. https://phabricator.kde.org/D4712 https://phabricator.kde.org/D4711 It has one unfixible case, dismiss context menu by clicking on onther window. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D5515 To:

D5368: http slave: send error page after authorization failure

anthonyfieroni added a reviewer: dfaure. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D5368 To: schwab, #frameworks, dfaure Cc: dfaure, ltoscano

Re: Review Request 130013: Make PlainTextExtractor match "text/plain" mimetype

> On March 15, 2017, 6:13 a.m., Anthony Fieroni wrote: > > Ship It! > > Anthony Fieroni wrote: > Can you verify, https://git.reviewboard.kde.org/r/129703/ it is needed to > limit CPU usage or to discard it? > > Igor Poboiko wrote: > I didn't see much per

Re: Review Request 130013: Make PlainTextExtractor match "text/plain" mimetype

> On March 15, 2017, 6:13 a.m., Anthony Fieroni wrote: > > Ship It! Can you verify, https://git.reviewboard.kde.org/r/129703/ it is needed to limit CPU usage or to discard it? - Anthony --- This is an automatically generat

Re: Review Request 130013: Make PlainTextExtractor match "text/plain" mimetype

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/130013/#review102846 --- Ship it! Ship It! - Anthony Fieroni On Март 14, 2017

D5037: KTextEditor: prevent accidental zooming

anthonyfieroni added a comment. Ok, we discard first wheel event cause elapsed timer isn't started, right? I think we can "catch" all events we just make it a bit different, set modifiers in contructor and restart elpased timer on global event override function if desired modifiers

D5037: KTextEditor: prevent accidental zooming

anthonyfieroni added inline comments. INLINE COMMENTS > kateviewinternal.cpp:76 > + > +bool detectZoomingEvent(QWheelEvent *e, bool unsetModifier=true, > Qt::KeyboardModifiers modifier=Qt::ControlModifier) > +{ About me, it's designed to unset modifiers so param looks unwanted. >

Re: Review Request 129985: [kio-extras] Thumbs for audio files

marked as submitted. Review request for KDE Frameworks, David Faure and Elvis Angelaccio. Changes --- Submitted with commit d695d79739550fda37d820d935dbef7ee9187f90 by Anthony Fieroni to branch master. Repository: kio-extras Description --- ^^ Diffs - cmake

Re: Review Request 129985: [kio-extras] Thumbs for audio files

-CREATION thumbnail/audiothumbnail.desktop PRE-CREATION Diff: https://git.reviewboard.kde.org/r/129985/diff/ Testing --- Thanks, Anthony Fieroni

Re: Review Request 129985: [kio-extras] Thumbs for audio files

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129985/#review102777 --- Any other downsides? - Anthony Fieroni On Март 6, 2017

Re: Review Request 129985: [kio-extras] Thumbs for audio files

PRE-CREATION thumbnail/audiothumbnail.desktop PRE-CREATION Diff: https://git.reviewboard.kde.org/r/129985/diff/ Testing --- Thanks, Anthony Fieroni

D4947: [KTextEditor] Expose additional internal View's functionality to the public API

anthonyfieroni added a comment. Milian had in mind that you can take charge of Kompare and implement your ideas rather than release new app. :) REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D4947 To: jsalatas, #ktexteditor, #frameworks, mwolff Cc:

Re: Review Request 129985: [kio-extras] Thumbs for audio files

-CREATION thumbnail/audiothumbnail.desktop PRE-CREATION Diff: https://git.reviewboard.kde.org/r/129985/diff/ Testing --- Thanks, Anthony Fieroni

Re: Review Request 129985: [kio-extras] Thumbs for audio files

/audiothumbnail.desktop PRE-CREATION Diff: https://git.reviewboard.kde.org/r/129985/diff/ Testing --- Thanks, Anthony Fieroni

Re: Review Request 129985: [kio-extras] Thumbs for audio files

> > ``` > > if (TAGLIB_FOUND) > >install(FILES audiothumbnail.desktop DESTINATION > > ${SERVICES_INSTALL_DIR}) > > endif() > > ``` > > Anthony Fieroni wrote: > Yeah, i want to do this. Why it will not work? > > Elvis

Re: Review Request 129985: [kio-extras] Thumbs for audio files

-- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129985/#review102717 --- On Март 5, 2017, 1:27 след обяд, Anthony Fieroni wrote: > > -

Re: Review Request 129985: [kio-extras] Thumbs for audio files

/audiocreator.cpp PRE-CREATION thumbnail/audiothumbnail.desktop PRE-CREATION Diff: https://git.reviewboard.kde.org/r/129985/diff/ Testing --- Thanks, Anthony Fieroni

Re: Review Request 129985: [kio-extras] Thumbs for audio files

----- On Март 5, 2017, 1:27 след обяд, Anthony Fieroni wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/129985/ >

D4847: KAuth integration in document saving

anthonyfieroni added inline comments. INLINE COMMENTS > katetextbuffer.cpp:791 > */ > -QSaveFile saveFile(filename); > -saveFile.setDirectWriteFallback(true); > +QFileDevice *saveFile = new QSaveFile(filename); > +static_cast(saveFile)->setDirectWriteFallback(true); use

Review Request 129985: [kio-extras] Thumbs for audio files

--- Thanks, Anthony Fieroni

[Differential] [Commented On] D4711: Ungrab mouse on menu close

anthonyfieroni added a comment. Yep, same faulty beharior present in all Qt apps, Qupzilla, QtCreator, etc. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D4711 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To:

[Differential] [Commented On] D4711: Ungrab mouse on menu close

anthonyfieroni added a comment. I'm not pretty sure, but https://code.woboq.org/qt5/qtbase/src/widgets/kernel/qwidgetwindow.cpp.html#374 on click at other window we have enter && mouseGrabber REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL

[Differential] [Request, 14 lines] D4711: Ungrab mouse on menu close

anthonyfieroni created this revision. Restricted Application added projects: Plasma, Frameworks. Restricted Application added subscribers: Frameworks, plasma-devel. REVISION SUMMARY Qt 5.8 has a bit changed and ungrabbing at show does not work. REPOSITORY R242 Plasma Framework (Library)

[Differential] [Updated] D4628: Add ability to disable saving in `KTextEditor::Document`

anthonyfieroni added reviewers: KTextEditor, cullmann, dhaumann. REVISION DETAIL https://phabricator.kde.org/D4628 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: russellg, #ktexteditor, cullmann, dhaumann Cc: kwrite-devel, #frameworks

[Differential] [Commented On] D4628: Add ability to disable saving in `KTextEditor::Document`

anthonyfieroni added a comment. Add reviewers KTextEditor, try not add virtual functions to base class :) REVISION DETAIL https://phabricator.kde.org/D4628 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: russellg Cc: kwrite-devel, #frameworks

[Differential] [Commented On] D4234: Change algorithm for autobrace.

anthonyfieroni added a comment. In https://phabricator.kde.org/D4234#85804, @brauch wrote: > Sorry, I wanted to write a reply but failed. My idea was simply to have the algorithm always aim to make parentheses balanced when closing one. You mean when we have 3 open when 1 is

[Differential] [Changed Subscribers] D4234: Change algorithm for autobrace.

anthonyfieroni added inline comments. INLINE COMMENTS > katedocument.cpp:2920-2921 > +(isEndBracket(chars[0]) || > + chars[0] == QLatin1Char('\'') || > + chars[0] == QLatin1Char('\"'))) { > + Why seach a checks ? REPOSITORY R39 KTextEditor

<    1   2   3   4   5   6   7   >