Re: Syndication: Relicense notice

On mardi 30 juin 2020 19:06:22 CEST Christophe Giboudeaux wrote: > [cut] > > According to the relicensecheck script, all developers who pushed changes to > these files allow to relicense files to LGPL-2.0-or-later. > Unless someone has a valid objection, I'll update the

Syndication: Relicense notice

Hi, While porting the syndication files to use the SPDX license format, some files added by Frerich Raabe which originally lived in 'librss' (> 15 years ago) were marked as problematic. dataretriever.{cpp,h} and loader.{cpp,h} only have a partial license header pointing to a COPYING file

D28379: KWidgetsAddons: Convert copyright headers to SPDX expressions

cgiboudeaux added a comment. Can you create an invent MR? I'll look later REPOSITORY R236 KWidgetsAddons REVISION DETAIL https://phabricator.kde.org/D28379 To: cordlandwehr Cc: cgiboudeaux, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29524: ECMGeneratePriFile: fix for ECM_MKSPECS_INSTALL_DIR being absolute

cgiboudeaux accepted this revision. cgiboudeaux added a comment. This revision is now accepted and ready to land. tested successfully with the openSUSE package which uses absolute paths REPOSITORY R240 Extra CMake Modules BRANCH master REVISION DETAIL

D29223: Update Taiwanese holidays

cgiboudeaux added a comment. If everything is sorted and both of you agree, please accept one of the reviews and we'll happily push it if necessary. REVISION DETAIL https://phabricator.kde.org/D29223 To: nhiga, winterz, cgiboudeaux, shrapnel Cc: weisi, #kde_pim, kde-frameworks-devel,

D29372: Taiwan: Use "zh_TW" language code

cgiboudeaux added a comment. D29223 addresses the issue and needs review REPOSITORY R175 KHolidays REVISION DETAIL https://phabricator.kde.org/D29372 To: weisi, winterz Cc: cgiboudeaux, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham,

D29223: Update Taiwanese holidays

cgiboudeaux added a comment. @nhiga Please have a look at D29372 . REPOSITORY R175 KHolidays REVISION DETAIL https://phabricator.kde.org/D29223 To: nhiga, winterz, cgiboudeaux, shrapnel Cc: #kde_pim, kde-frameworks-devel, shrapnel, LeGast00n, cblack,

D29223: Update Taiwanese holidays

cgiboudeaux added a comment. I suppose you rename the file for a good reason. Are there different "official" languages for Taiwan? REPOSITORY R175 KHolidays REVISION DETAIL https://phabricator.kde.org/D29223 To: nhiga, winterz, cgiboudeaux, shrapnel Cc: #kde_pim, kde-frameworks-devel,

D29223: Update Taiwanese holidays

cgiboudeaux added a reviewer: shrapnel. REPOSITORY R175 KHolidays REVISION DETAIL https://phabricator.kde.org/D29223 To: nhiga, winterz, cgiboudeaux, shrapnel Cc: #kde_pim, kde-frameworks-devel, shrapnel, LeGast00n, cblack, fbampaloukas, dcaliste, michaelh, ngraham, bruns, dvasin,

D29097: Adapt FindKF5 to stricter checks in newer find_package_handle_standard_args

cgiboudeaux accepted this revision. This revision is now accepted and ready to land. REPOSITORY R240 Extra CMake Modules BRANCH avoidnewwarningsinfindkf5 REVISION DETAIL https://phabricator.kde.org/D29097 To: kossebau, #frameworks, #build_system, cgiboudeaux Cc: kde-frameworks-devel,

D28891: Nicaragua Holidays

This revision was automatically updated to reflect the committed changes. Closed by commit R175:97139b80e80b: Nicaragua Holidays (authored by carguello, committed by cgiboudeaux). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D28891?vs=80322=80452#toc REPOSITORY R175 KHolidays

D28874: Taiwanese holidays

This revision was automatically updated to reflect the committed changes. Closed by commit R175:4d947fa1ca59: Taiwanese holidays (authored by shrapnel, committed by cgiboudeaux). REPOSITORY R175 KHolidays CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28874?vs=80415=80451 REVISION

D27245: Ki18n: Convert license headers to SPDX statements

cgiboudeaux accepted this revision. This revision is now accepted and ready to land. REPOSITORY R249 KI18n BRANCH spdx REVISION DETAIL https://phabricator.kde.org/D27245 To: cordlandwehr, cgiboudeaux Cc: kossebau, cgiboudeaux, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh,

D27741: KCodecs: Convert license statements to SPDX expressions

cgiboudeaux accepted this revision. This revision is now accepted and ready to land. REPOSITORY R270 KCodecs BRANCH spdx REVISION DETAIL https://phabricator.kde.org/D27741 To: cordlandwehr, cgiboudeaux Cc: cgiboudeaux, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham,

D27738: KCoreAddons: Convert license statements to SPDX expressions

cgiboudeaux accepted this revision. This revision is now accepted and ready to land. REPOSITORY R244 KCoreAddons BRANCH sdpx REVISION DETAIL https://phabricator.kde.org/D27738 To: cordlandwehr, cgiboudeaux Cc: cgiboudeaux, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh,

D27429: ThreadWeaver: Convert license headers to SPDX expressions

cgiboudeaux accepted this revision. REPOSITORY R279 ThreadWeaver BRANCH spdxHeaders REVISION DETAIL https://phabricator.kde.org/D27429 To: cordlandwehr, cgiboudeaux Cc: cgiboudeaux, kde-frameworks-devel, mirko, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27741: KCodecs: Convert license statements to SPDX expressions

cgiboudeaux added inline comments. INLINE COMMENTS > Big5Freq.tab:3 > /* -*- C++ -*- > -* Copyright (C) 1998 > -* > -* > -* Permission is hereby granted, free of charge, to any person obtaining > -* a copy of this software and associated documentation files (the > -* "Software"), to deal

D27601: KConfig: Convert to SPDX license statements

cgiboudeaux accepted this revision. cgiboudeaux added a comment. This revision is now accepted and ready to land. LGTM REPOSITORY R237 KConfig BRANCH spdx REVISION DETAIL https://phabricator.kde.org/D27601 To: cordlandwehr, cgiboudeaux Cc: ognarb, cgiboudeaux, kde-frameworks-devel,

D27738: KCoreAddons: Convert license statements to SPDX expressions

cgiboudeaux added inline comments. INLINE COMMENTS > kshareddatacache.cpp:11 > +placed in the public domain. See http://sites.google.com/site/murmurhash/ > +SPDX-License-Identifier: CC0-1.0 > +*/ Why? REPOSITORY R244 KCoreAddons REVISION DETAIL https://phabricator.kde.org/D27738

D27245: Ki18n: Convert license headers to SPDX statements

cgiboudeaux added a comment. In D27245#619834 , @cordlandwehr wrote: > So, how to move forward with this change? The two open discussion points are: > > - How to handle COPYING files? --> IMO this is a general question that I want to

D27428: KItemViews: Convert license statements to SPDX expressions

cgiboudeaux accepted this revision. cgiboudeaux added a comment. This revision is now accepted and ready to land. LGTM REPOSITORY R276 KItemViews BRANCH spdx REVISION DETAIL https://phabricator.kde.org/D27428 To: cordlandwehr, cgiboudeaux Cc: cgiboudeaux, kde-frameworks-devel,

D27742: Solid: Convert license headers to SPDX expressions

cgiboudeaux accepted this revision. cgiboudeaux added a comment. This revision is now accepted and ready to land. LGTM REPOSITORY R245 Solid BRANCH spdx REVISION DETAIL https://phabricator.kde.org/D27742 To: cordlandwehr, cgiboudeaux Cc: cgiboudeaux, kde-frameworks-devel, LeGast00n,

D27429: ThreadWeaver: Convert license headers to SPDX expressions

cgiboudeaux accepted this revision. cgiboudeaux added a comment. This revision is now accepted and ready to land. LGTM INLINE COMMENTS > main.cpp:1 > -#include > +#include > I don't see what changed here. looks unrelated to this PR REPOSITORY R279 ThreadWeaver BRANCH spdxHeaders

D27601: KConfig: Convert to SPDX license statements

cgiboudeaux added inline comments. INLINE COMMENTS > kconfigbackend_p.h:6 > + > +Portions: > +SPDX-FileCopyrightText: 1997 Matthias Kalle Dalheimer I don't think this is useful > kconfigini_p.h:6 > > - This library is free software; you can redistribute it and/or > - modify it

D27602: KDbusAddons: Convert license statement to SPDX

cgiboudeaux accepted this revision. This revision is now accepted and ready to land. REPOSITORY R271 KDBusAddons BRANCH spdx REVISION DETAIL https://phabricator.kde.org/D27602 To: cordlandwehr, cgiboudeaux Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27603: KDNSSD: Convert license headers to SPDX statements

cgiboudeaux accepted this revision. This revision is now accepted and ready to land. REPOSITORY R272 KDNSSD BRANCH spdx REVISION DETAIL https://phabricator.kde.org/D27603 To: cordlandwehr, cgiboudeaux Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27419: Update Japanese holidays

cgiboudeaux accepted this revision. This revision is now accepted and ready to land. REPOSITORY R175 KHolidays REVISION DETAIL https://phabricator.kde.org/D27419 To: nhiga, dvratil, winterz, cgiboudeaux Cc: #kde_pim, kde-frameworks-devel, LeGast00n, cblack, fbampaloukas, GB_2, dcaliste,

D27363: KHolidays: Convert license statements to SPDX expressions

cgiboudeaux added subscribers: winterz, cgiboudeaux. cgiboudeaux added inline comments. INLINE COMMENTS > holidayregion.cpp:31 > // Copied from qlocale_data_p.h and qlocale.h > -// Copyright (C) 2014 Digia Plc and/or its subsidiary(-ies). > +// SPDX-FileCopyrightText: 2014 Digia Plc and /or its

D27245: Ki18n: Convert license headers to SPDX statements

cgiboudeaux added inline comments. INLINE COMMENTS > cordlandwehr wrote in LGPL-3.0-only.txt:15-17 > Actually, I have no idea. But according to the REUSE specification, the > license files must no be changed and used exactly as provided by SPDX. > All license files, except the LicenseRef files,

D27245: Ki18n: Convert license headers to SPDX statements

cgiboudeaux added a comment. some headers have 3 leading whitespaces, some 4. Can you clarify? INLINE COMMENTS > LGPL-3.0-only.txt:15-17 > + > + > + why are there so many empty lines? > gettext.h:2 > /* Convenience header for conditional use of GNU . > - Copyright (C) 1995-1998,

D27103: KItemModels: Convert license headers to SPDX markers

cgiboudeaux accepted this revision. cgiboudeaux added a comment. This revision is now accepted and ready to land. Please push after fixing the remaining issues REPOSITORY R275 KItemModels BRANCH spdx REVISION DETAIL https://phabricator.kde.org/D27103 To: cordlandwehr, dfaure,

D27103: KItemModels: Convert license headers to SPDX markers

cgiboudeaux added inline comments. INLINE COMMENTS > modeltest.h:4 > > +SPDX-FileCopyrightText: 2013 Digia Plc and /or its subsidiary(-ies) > > +SPDX-FileCopyrightText: 2010 Stephen Kelly Unneeded extra space added for a couple files "and /or"

D27106: Attica: Convert license statements to SPDX markers

cgiboudeaux accepted this revision. This revision is now accepted and ready to land. REPOSITORY R235 Attica BRANCH spdx REVISION DETAIL https://phabricator.kde.org/D27106 To: cordlandwehr, cgiboudeaux Cc: dfaure, cgiboudeaux, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh,

D27297: KGuiAddons: Convert license headers to SPDX statements

cgiboudeaux accepted this revision. cgiboudeaux added a comment. This revision is now accepted and ready to land. LGTM REPOSITORY R273 KGuiAddons BRANCH spdx REVISION DETAIL https://phabricator.kde.org/D27297 To: cordlandwehr, cgiboudeaux Cc: cgiboudeaux, kde-frameworks-devel,

D27234: KPlotting: Convert license statements to SPDX

cgiboudeaux accepted this revision. This revision is now accepted and ready to land. REPOSITORY R277 KPlotting BRANCH spdx REVISION DETAIL https://phabricator.kde.org/D27234 To: cordlandwehr, cgiboudeaux Cc: cgiboudeaux, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham,

D27234: KPlotting: Convert license statements to SPDX

cgiboudeaux added inline comments. INLINE COMMENTS > cordlandwehr wrote in testplot_main.cpp:2-5 > do you mean the "*" character in each comment line? yes. they're added only for a couple files REPOSITORY R277 KPlotting REVISION DETAIL https://phabricator.kde.org/D27234 To: cordlandwehr

D27234: KPlotting: Convert license statements to SPDX

cgiboudeaux added inline comments. INLINE COMMENTS > testplot_main.cpp:2-5 > + * > + * SPDX-FileCopyrightText: 2006 Jason Harris > + * > + * SPDX-License-Identifier: GPL-2.0-or-later extra '*' ? REPOSITORY R277 KPlotting REVISION DETAIL https://phabricator.kde.org/D27234 To:

D27092: Prison: Convert license statements to SPDX identifiers

cgiboudeaux accepted this revision. This revision is now accepted and ready to land. REPOSITORY R280 Prison BRANCH spdx REVISION DETAIL https://phabricator.kde.org/D27092 To: cordlandwehr, cgiboudeaux Cc: cgiboudeaux, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham,

D27231: Convert license statements to SPDX

cgiboudeaux accepted this revision. cgiboudeaux added a comment. This revision is now accepted and ready to land. LGTM once the license file is fixed INLINE COMMENTS > LicenseRef-KDE-Accepted-LGPL.txt:13 > +GNU General Public License for more details. > \ No newline at end of file missing

D27104: Convert license statements to SPDX headers

cgiboudeaux accepted this revision. This revision is now accepted and ready to land. REPOSITORY R243 KArchive BRANCH spdx REVISION DETAIL https://phabricator.kde.org/D27104 To: cordlandwehr, cgiboudeaux Cc: cgiboudeaux, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham,

Re: License Statement Clarification in KArchive

On vendredi 7 février 2020 09:27:49 CET David Faure wrote: > On mercredi 5 février 2020 18:43:10 CET Andreas Cord-Landwehr wrote: > > Hi David, > > > > during the SPDX license marker introduction into KArchive we found the > > following two files in KArchive with ambiguous license statements,

D27103: Convert license headers to SPDX markers

cgiboudeaux added inline comments. INLINE COMMENTS > modeltest.h:4 > > +SPDX-FileCopyrightText: 2013 Digia Plc and /or its subsidiary(-ies) > > +SPDX-FileCopyrightText: 2010 Stephen Kelly redirects to https://www.qt.io/terms-conditions/ nowadays

D27103: Convert license headers to SPDX markers

cgiboudeaux added a comment. same remark as for D27106 . Check if FileContributor is more appropriate. REPOSITORY R275 KItemModels REVISION DETAIL https://phabricator.kde.org/D27103 To: cordlandwehr, dfaure Cc: cgiboudeaux, kde-frameworks-devel,

D27091: Convert license statements to SPDX

cgiboudeaux accepted this revision. This revision is now accepted and ready to land. REPOSITORY R246 Sonnet BRANCH spdx REVISION DETAIL https://phabricator.kde.org/D27091 To: cordlandwehr, cgiboudeaux Cc: cgiboudeaux, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D27092: Update license statements to SPDX identifiers

cgiboudeaux added a comment. +1 LGTM REPOSITORY R280 Prison REVISION DETAIL https://phabricator.kde.org/D27092 To: cordlandwehr Cc: cgiboudeaux, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D27106: Convert license statements to SPDX markers

cgiboudeaux added inline comments. INLINE COMMENTS > COPYING:485 > > -This library is free software; you can redistribute it and/or > -modify it under the terms of the GNU Lesser General Public > -License as published by the Free Software Foundation; either > -version 2.1 of

D27104: Convert license statements to SPDX headers

cgiboudeaux added inline comments. INLINE COMMENTS > krcc.cpp:4 > + > + SPDX-License-Identifier: LGPL-2.0-only OR LGPL-3.0-only OR > LicenseRef-KDE-Accepted-LGPL > */ Same thing here > krcc.h:4 > > - This library is free software; you can redistribute it and/or modify > - it under

D27091: Convert license statements to SPDX

cgiboudeaux added a comment. +1 LGTM REPOSITORY R246 Sonnet REVISION DETAIL https://phabricator.kde.org/D27091 To: cordlandwehr Cc: cgiboudeaux, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26931: Introduce SPDX license headers

cgiboudeaux accepted this revision. This revision is now accepted and ready to land. REPOSITORY R274 KIdleTime BRANCH master REVISION DETAIL https://phabricator.kde.org/D26931 To: cordlandwehr, cgiboudeaux Cc: cgiboudeaux, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26931: Introduce SPDX license headers

cgiboudeaux added a comment. In D26931#601508 , @cgiboudeaux wrote: > In D26931#601505 , @cordlandwehr wrote: > > > Convert to SPDX-FileCopyrightText tags > > > some files have by , can I

D26931: Introduce SPDX license headers

cgiboudeaux added a comment. In D26931#601505 , @cordlandwehr wrote: > Convert to SPDX-FileCopyrightText tags some files have by , can I suggest removing this "by"? REPOSITORY R274 KIdleTime REVISION DETAIL

Re: Fwd: KDE CI: Administration » Dependency Build Applications stable-kf5-qt5 FreeBSDQt5.13 - Build # 49 - Still Failing!

On lundi 27 janvier 2020 10:30:38 CET Ben Cooksley wrote: > Hi all, > > Any ideas why this would have suddenly started to fail like this in KHTML? > From what I can see there haven't been any changes in KHTML itself, so this > would have to be a regression in another Framework/ECM... > > (This

D26931: Introduce SPDX license headers

cgiboudeaux added a comment. LGTM REPOSITORY R274 KIdleTime REVISION DETAIL https://phabricator.kde.org/D26931 To: cordlandwehr Cc: cgiboudeaux, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26752: ECMAddAppIcon: Do not warn about mac and window icons if isnt a OS specific build

cgiboudeaux added a comment. In D26752#597149 , @patrickelectric wrote: > Hi @cgiboudeaux and @bcooksley, there is a reason of why this patch is valid. Have you read the commit message ? > > In #kirogi

D26752: ECMAddAppIcon: Do not warn about mac and window icons if isnt a OS specific build

cgiboudeaux added a comment. In D26752#596949 , @tcanabrava wrote: > > I don't see the gain on having a warning - in a windows system, about > missing mac icons if I'm not *deploying*. Then fix your code. ie only call

D26752: ECMAddAppIcon: Do not warn about mac and window icons if isnt a OS specific build

cgiboudeaux added a comment. In D26752#596809 , @tcanabrava wrote: > That’s not a developer issue, it’s a packaging issue. AUTHOR_WARNING *is* for developers. If you want to hide these warnings, use -Wno-dev [1] [1]

D26752: ECMAddAppIcon: Do not warn about mac and window icons if isnt a OS specific build

cgiboudeaux added a comment. You may use Linux to develop software that's intended to be used also on Mac and Windows. You can't expect developers to have build environment for every platform REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D26752 To:

D26752: ECMAddAppIcon: Do not warn about mac and window icons if isnt a OS specific build

cgiboudeaux requested changes to this revision. cgiboudeaux added a comment. This revision now requires changes to proceed. I object. This warning is for developers. It tells them the icons are missing for some platforms. REPOSITORY R240 Extra CMake Modules REVISION DETAIL

D26202: WIP: Refactor KConfigXT

cgiboudeaux added a comment. In D26202#595846 , @tcanabrava wrote: > I Just reverted this and I'm working on a full build of kde using kdesrc-build --refresh-build, I'll reopen this patch when *all* projects build sucessfully, with a unittest

D26011: Align ECM and Qt setup with Frameworks conventions

cgiboudeaux accepted this revision. cgiboudeaux added inline comments. This revision is now accepted and ready to land. INLINE COMMENTS > CMakeLists.txt:28 > include(ECMSetupVersion) > include(FeatureSummary) > include(ECMQtDeclareLoggingCategory) Remove this one REPOSITORY R174 KContacts

D25975: Relicense some files to LGPLv2+ or v2v3, OK by all contributors according to relicensecheck.pl

cgiboudeaux added inline comments. INLINE COMMENTS > dfaure wrote in kservicefactory.cpp:6-7 > The reason is Waldo Bastian, who agreed to 2-or-3 but not to 2+ > > waba ( 17 LOC): > 7ee6ea605e,ec1dc9339f,307504885e,764b51a72c,f1d9d663e6,010677452e,79787d4962,5dcce58a32,0ef36944f8 > > > He

D25975: Relicense some files to LGPLv2+ or v2v3, OK by all contributors according to relicensecheck.pl

cgiboudeaux accepted this revision. This revision is now accepted and ready to land. REPOSITORY R309 KService BRANCH relicense REVISION DETAIL https://phabricator.kde.org/D25975 To: dfaure, apol, cgiboudeaux Cc: cgiboudeaux, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25975: Relicense some files to LGPLv2+ or v2v3, OK by all contributors according to relicensecheck.pl

cgiboudeaux added inline comments. INLINE COMMENTS > kservicefactory.cpp:6-7 > * modify it under the terms of the GNU Library General Public > - * License version 2 as published by the Free Software Foundation; > + * License as published by the Free Software Foundation; either > + *

D25975: Relicense some files to LGPLv2+ or v2v3, OK by all contributors according to relicensecheck.pl

cgiboudeaux added a comment. Note that you don't have a LGPL-2.0-or-later COPYING file in this repo (there's also no LGPL-2.0-only). COPYING.LIB contains the LGPL-2.1 license which is used by one file in the tests/ folder REPOSITORY R309 KService REVISION DETAIL

D25829: kconfig EBN transport protocol cleanup

This revision was automatically updated to reflect the committed changes. Closed by commit R237:975aaeeff483: kconfig EBN transport protocol cleanup (authored by jhayes, committed by cgiboudeaux). REPOSITORY R237 KConfig CHANGES SINCE LAST UPDATE

D25864: kdeclarative EBN spelling cleanup

This revision was automatically updated to reflect the committed changes. Closed by commit R296:ab35bc727cb7: kdeclarative EBN spelling cleanup (authored by jhayes, committed by cgiboudeaux). REPOSITORY R296 KDeclarative CHANGES SINCE LAST UPDATE

D25866: kholidays EBN transport protocol cleanup

This revision was automatically updated to reflect the committed changes. Closed by commit R175:98e731d68581: kholidays EBN transport protocol cleanup (authored by jhayes, committed by cgiboudeaux). REPOSITORY R175 KHolidays CHANGES SINCE LAST UPDATE

D25864: kdeclarative EBN spelling cleanup

cgiboudeaux accepted this revision. This revision is now accepted and ready to land. REPOSITORY R296 KDeclarative BRANCH ebn-spelling-cleanup (branched from master) REVISION DETAIL https://phabricator.kde.org/D25864 To: jhayes, cgiboudeaux Cc: kde-frameworks-devel, LeGast00n, GB_2,

D25866: kholidays EBN transport protocol cleanup

cgiboudeaux accepted this revision. This revision is now accepted and ready to land. REPOSITORY R175 KHolidays BRANCH ebn-transport-cleanup (branched from master) REVISION DETAIL https://phabricator.kde.org/D25866 To: jhayes, cgiboudeaux Cc: kde-frameworks-devel, LeGast00n, GB_2,

D25753: EBN extra-cmake-modules transport cleanup

cgiboudeaux added a comment. In D25753#572894 , @winterz wrote: > please send me a list of urls that don't have https: and I'll add them to the whitelist The x86-64.org domain is dead. I'm not sure about what could be used instead.

D25753: EBN extra-cmake-modules transport cleanup

This revision was automatically updated to reflect the committed changes. Closed by commit R240:f082ed20e6a8: EBN extra-cmake-modules transport cleanup (authored by jhayes, committed by cgiboudeaux). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D25753?vs=70973=70986#toc REPOSITORY

D25753: EBN extra-cmake-modules transport cleanup

cgiboudeaux accepted this revision. This revision is now accepted and ready to land. REPOSITORY R240 Extra CMake Modules BRANCH ebn-transport-cleanup (branched from master) REVISION DETAIL https://phabricator.kde.org/D25753 To: jhayes, apol, cgiboudeaux Cc: cgiboudeaux,

D25753: EBN extra-cmake-modules transport cleanup

cgiboudeaux added a comment. The sphinx doc URL is https://www.sphinx-doc.org (it just doesn't work without www) REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D25753 To: jhayes, apol, cgiboudeaux Cc: cgiboudeaux, kde-frameworks-devel, kde-buildsystem,

D25493: EBN kmoretools cleanup transport protocol

This revision was automatically updated to reflect the committed changes. Closed by commit R304:19bbe83f5527: EBN kmoretools cleanup transport protocol (authored by jhayes, committed by cgiboudeaux). REPOSITORY R304 KNewStuff CHANGES SINCE LAST UPDATE

D25397: Install .pri file for KAuthCore

This revision was automatically updated to reflect the committed changes. Closed by commit R283:49ed872608fa: Install .pri file for KAuthCore (authored by volkov, committed by cgiboudeaux). REPOSITORY R283 KAuth CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25397?vs=69987=70944

D25752: EBN extra-cmake-modules comments spelling cleanup

This revision was automatically updated to reflect the committed changes. Closed by commit R240:9f441190a36a: EBN extra-cmake-modules comments spelling cleanup (authored by jhayes, committed by cgiboudeaux). REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE

D25448: EBN cleanup of autotests transfer protocol

This revision was automatically updated to reflect the committed changes. Closed by commit R267:b86aa2b10f7d: EBN cleanup of autotests transfer protocol (authored by jhayes, committed by cgiboudeaux). REPOSITORY R267 Oxygen Icons CHANGES SINCE LAST UPDATE

D25719: EBN KActivites transfer protocol cleanup

This revision was automatically updated to reflect the committed changes. Closed by commit R6:8c0352356062: EBN KActivites transfer protocol cleanup (authored by jhayes, committed by cgiboudeaux). REPOSITORY R6 KActivities CHANGES SINCE LAST UPDATE

D25721: EBN kdeclarative transfer protocol cleanup

This revision was automatically updated to reflect the committed changes. Closed by commit R296:342a575c0dd5: EBN kdeclarative transfer protocol cleanup (authored by jhayes, committed by cgiboudeaux). REPOSITORY R296 KDeclarative CHANGES SINCE LAST UPDATE

D25753: EBN extra-cmake-modules transport cleanup

cgiboudeaux added inline comments. INLINE COMMENTS > FindCanberra.cmake:98 > DESCRIPTION "Event sound library" > -URL "http://0pointer.de/lennart/projects/libcanberra; > +URL "https://0pointer.de/lennart/projects/libcanberra; > ) redirects to http://0pointer.net/ which is probably

D25753: EBN extra-cmake-modules transport cleanup

cgiboudeaux requested changes to this revision. cgiboudeaux added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > CMakeLists.txt:35 > PROPERTIES > -URL "http://sphinx-doc.org/; > +URL "https://sphinx-doc.org/; > DESCRIPTION "Tool to

D23550: CMake config files: use as min dep version the Qt version we built against

cgiboudeaux added a comment. In D23550#569554 , @kossebau wrote: > In D23550#569552 , @cgiboudeaux wrote: > > > In D23550#569485 , @kossebau wrote: > >

D23550: CMake config files: use as min dep version the Qt version we built against

cgiboudeaux added a comment. In D23550#569485 , @kossebau wrote: > ping :) No-one any opinion? Sure :) -1. The Config file is supposed to look for the lowest supported version. REPOSITORY R244 KCoreAddons REVISION DETAIL

D25107: Add install dir for systemd units

cgiboudeaux added inline comments. INLINE COMMENTS > KDEInstallDirs.cmake:137-140 > +# [``SYSTEMD_UNIT_INSTALL_DIR``]. Since 5.FIXME > +# ``SYSTEMDUSERUNITDIR`` > +# Systemd uSER Units (``LIBDIR/systemd/user``) > +# [``SYSTEMD_USER_UNIT_INSTALL_DIR``]. Since 5.FIXME These fixme also

D25304: Fix the OpenEXR >= 2.4 detection

cgiboudeaux abandoned this revision. cgiboudeaux added a comment. I applied the patch to our openexr package instead. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D25304 To: cgiboudeaux Cc: arojas, kde-frameworks-devel, kde-buildsystem, LeGast00n,

D25304: Fix the OpenEXR >= 2.4 detection

cgiboudeaux added a comment. In D25304#562561 , @arojas wrote: > > I don't see how that commit is related. > > openEXR 2.3 installs libXXX.so and 2.4 installs libXXX-2_4.so > > > > This is expected afaics. > > No, it's not. That line

D25304: Fix the OpenEXR >= 2.4 detection

cgiboudeaux added a comment. In D25304#562553 , @arojas wrote: > This is a bug in openexr. It does actually try to install the unsuffixed symlinks, but it doesn't take DESTDIR into account, so it tries to install them to the root filesystem

D25304: Fix the OpenEXR >= 2.4 detection

cgiboudeaux added a comment. Note: openEXR >= 2.4 provides CMake configuration modules (OpenEXRConfig.cmake and IlmBaseConfig.cmake). We could also look for those and use the current code as a fallback if the modules can't be found REPOSITORY R240 Extra CMake Modules REVISION DETAIL

D25304: Fix the OpenEXR >= 2.4 detection

cgiboudeaux created this revision. Herald added projects: Frameworks, Build System. Herald added subscribers: kde-buildsystem, kde-frameworks-devel. cgiboudeaux requested review of this revision. REVISION SUMMARY Newer OpenEXR versions add a suffix to the libraries file names. ECM can now

D25223: Avoid side effects during menu initialization

cgiboudeaux added a comment. tested successfully locally. I don't see menus opening on the top left corner when running vlc or hp-systray. REPOSITORY R135 Integration for Qt applications in Plasma REVISION DETAIL https://phabricator.kde.org/D25223 To: kmaterka, #plasma, #frameworks,

D24841: Use modern way to set the C/CXX standard

cgiboudeaux added a comment. Another issue caused by the new CMake 3.5 dependency, some tests fail: > > > 59 - ecm_setup_version-old_simple (Failed) > 60 - ecm_setup_version-old_soversion (Failed) > 61 - ecm_setup_version-old_version_file (Failed) > 62 -

D24882: Don't set C/C++ standards if already set

cgiboudeaux accepted this revision. cgiboudeaux added a comment. This revision is now accepted and ready to land. Thanks! tested successfullly REPOSITORY R240 Extra CMake Modules BRANCH master REVISION DETAIL https://phabricator.kde.org/D24882 To: dfaure, cgiboudeaux Cc:

D24841: Use modern way to set the C/CXX standard

cgiboudeaux added a comment. In D24841#552577 , @dfaure wrote: > Where did -std=gnu++14 come from? The old code above certainly didn't set it. > > Maybe some projects were doing `set(CMAKE_CXX_STANDARD 14)` before including

D24841: Use modern way to set the C/CXX standard

cgiboudeaux added a comment. I'm seeing build failures in several repositories seemingly caused by 6e3c794 (eg akonadi, kasync) Building with clang9, before: `-std=c++0x -std=gnu++14` are set After:

D24841: Use modern way to set the C/CXX standard

cgiboudeaux retitled this revision from "Use modern way to set the C/CXX standad" to "Use modern way to set the C/CXX standard". cgiboudeaux edited the summary of this revision. REPOSITORY R240 Extra CMake Modules BRANCH cmake_c_standard REVISION DETAIL https://phabricator.kde.org/D24841

D24363: Fix several build system errors

cgiboudeaux added a comment. Note: the metainfo file says this framework is tier 3. The subgroup value looks wrong INLINE COMMENTS > CMakeLists.txt:40-41 > +# IconThemes and ConfigWidgets are optional > +find_package(KF5IconThemes) > +find_package(KF5ConfigWidgets) > KF5_DEP_VERSION

D23855: Avoid installing log categorie file to KDE_INSTALL_CONFDIR

cgiboudeaux accepted this revision. cgiboudeaux added a comment. This revision is now accepted and ready to land. Thanks REPOSITORY R159 KActivities Statistics BRANCH arcpatch-D23855 REVISION DETAIL https://phabricator.kde.org/D23855 To: meven, ivan, cgiboudeaux Cc:

D23789: WIP: Add ECMGenerateExportHeaders, for improved handling of deprecated API

cgiboudeaux added a comment. Tests needed :) REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D23789 To: kossebau Cc: cgiboudeaux, kde-frameworks-devel, kde-buildsystem, LeGast00n, GB_2, bencreasy, michaelh, ngraham, bruns

D22143: Add proper logging using ECMQtDeclareLoggingCategory

cgiboudeaux added a comment. In D22143#526887 , @rikmills wrote: > This is installing BOTH /etc/xdg/kactivities-stats.categories AND/usr/share/qlogging-categories5/kactivities-stats.categories which is surely wrong? Indeed. As it

D23552: ECM: remove set_package_properties from FindCanberra

cgiboudeaux added a comment. I'd do the opposite, remove `DESCRIPTION` and `URL` from knotification's CMakeLists.txt and only leave the `PURPOSE` line. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D23552 To: dfaure, cgiboudeaux, sitter Cc: kossebau,

  1   2   3   4   >