Re: setting SOVERSION to 5

2014-02-25 Thread Kevin Ottens
On Tuesday 25 February 2014 17:12:37 Jonathan Riddell wrote: > On Tue, Feb 25, 2014 at 04:55:43PM +0100, Kevin Ottens wrote: > > OK, but then the said change is either in the packaging or in our own > > cmake > > files as we'd have to drop the SOVERSION later on when our

Re: [kde-frameworks-devel] Re: setting SOVERSION to 5

2014-02-25 Thread Kevin Ottens
Hello, On Tuesday 25 February 2014 14:32:27 Jonathan Riddell wrote: > On Tue, Feb 25, 2014 at 03:29:16PM +0100, Kevin Ottens wrote: > > Beside I still don't see a clear motive behind that change (Jonathan > > hinted at helping with packaging but it looks like not all packager

KF5 Update Meeting Minutes 2014-w9

2014-02-25 Thread Kevin Ottens
Hello everyone, This is the minutes of the Week 9 KF5 meeting. As usual it has been held on #kde-devel at 4pm Paris time. Were present: alexmerry, dfaure, krake, mgraesslin, teo, tosky and myself. Announcement: * Alpha 2 will be prepared on saturday; * Please push toward completion of the sti

Re: setting SOVERSION to 5

2014-02-25 Thread Kevin Ottens
On Tuesday 25 February 2014 13:06:25 David Faure wrote: > On Tuesday 25 February 2014 08:04:16 Kevin Ottens wrote: > > On Monday 24 February 2014 20:23:25 šumski wrote: > > > On Monday 24 of February 2014 16:13:48 Jonathan Riddell wrote: > > > ... > > > &

Re: setting SOVERSION to 5

2014-02-24 Thread Kevin Ottens
On Monday 24 February 2014 20:23:25 šumski wrote: > On Monday 24 of February 2014 16:13:48 Jonathan Riddell wrote: > ... > > > Shall I do this change to the frameworks? > > My opinion as a fellow packager is - please don't. IMHO, now that the > versioning is fully correct, it would be really weir

KF5 Update Meeting 2014-w9 Reminder

2014-02-24 Thread Kevin Ottens
Hello all, Just a quick reminder: The next KF5 Update Meeting will happen on #kde-devel tomorrow at 4pm Paris time. See you there! Regards. -- Kévin Ottens, http://ervin.ipsquad.net KDAB - proud supporter of KDE, http://www.kdab.com signature.asc Description: This is a digitally signed mes

Re: Mac OS X Frameworks Frameworks

2014-02-23 Thread Kevin Ottens
Hello, On Monday 24 February 2014 02:49:45 Aleix Pol wrote: > I would say that we should follow however it's done in Qt. So far we've > been trying to provide as much of a similar experience as if it was another > Qt module. Doing so here as well could be interesting too. > > The changes you prop

Re: kguiaddons uses qpa headers?

2014-02-23 Thread Kevin Ottens
On Sunday 23 February 2014 17:47:48 David Faure wrote: > On Sunday 23 February 2014 17:02:55 John Layt wrote: > > Hi, > > > > I'm building all of Frameworks from scratch for the first time, using the > > openSUSE packages for Qt 5.2, and qguiaddons fails with: > > > > [ 24%] Building CXX object >

Re: Porting feedback: Hiding the Help button in KConfigDialog

2014-02-23 Thread Kevin Ottens
On Sunday 23 February 2014 10:08:13 David Faure wrote: > On Monday 17 February 2014 16:00:08 Eike Hein wrote: > > Hi, > > > > in the KDialog-based KConfigDialog of yesteryear, it was fairly easy > > > > to hide the Help button: > > dialog->button(KDialog::Help)->hide(); > > > > This is useful

Re: Frameworks sprint in Barcelona

2014-02-22 Thread Kevin Ottens
On Saturday 22 February 2014 14:44:06 Mark Gaiser wrote: > April 24th is final for the Frameworks sprint. Or is it still possible > to change it to April 3-6? It's final, you wouldn't get me after all on the 3rd, and it's likely pointless to have it without Aurélien. Regards. -- Kévin Ottens, h

Re: Review Request 115827: Add KMainWindow::initialGeometrySet to increase SC

2014-02-21 Thread Kevin Ottens
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115827/#review50455 --- Ship it! Ship It! - Kevin Ottens On Feb. 21, 2014, 7:35

Re: Review Request 115602: Rename kactivitymanagerd

2014-02-21 Thread Kevin Ottens
> On Feb. 21, 2014, 6:29 a.m., Kevin Ottens wrote: > > I understand Ivan point of view. Now I'm wondering about something: Are we > > sure the situation will be the same in the future for a 5 to 6 transition? > > I don't think we can be 100% sure and so we

Re: using KDBusConnectionPool in libraries

2014-02-20 Thread Kevin Ottens
Hello, On Thursday 20 February 2014 20:03:20 Aaron J. Seigo wrote: > I ran into an interesting situation the other day with libkactivities: it > uses KDBusConnectionPool to create connections in a thread-safe manner. > KDBusConnectionPool creates a connection in whatever thread it happens to > be

Re: Review Request 115908: Remove Ki18n from KCompletion dependencies in cmake.in

2014-02-20 Thread Kevin Ottens
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115908/#review50449 --- Ship it! Ship It! - Kevin Ottens On Feb. 20, 2014, 11:51

Re: Review Request 115901: Hide private methods and private slots behind the d-pointer in KLineEdit

2014-02-20 Thread Kevin Ottens
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115901/#review50448 --- Ship it! Ship It! - Kevin Ottens On Feb. 19, 2014, 10:57

Re: Review Request 115695: Rework KNotification to work without KNotify daemon

2014-02-20 Thread Kevin Ottens
agree with Aleix I'd like it to be closer to the target with less regressions before letting it in. You still have a few days. ;-) Also don't forget to update the yaml and the list of frameworks in the wiki, it's moving in tier 3 territory AFAICT. - Kevin Ottens On Feb. 13,

Re: Review Request 115827: Add KMainWindow::initialGeometrySet to increase SC

2014-02-20 Thread Kevin Ottens
827/#comment35497> Should definitely be inlined, but then can go in after that. - Kevin Ottens On Feb. 17, 2014, 10:49 a.m., Martin Gräßlin wrote: > > --- > This is an automatically generated e-mail. To reply,

Re: Review Request 115717: Do not require to have a DISPLAY env variable if WAYLAND_DISPLAY is set

2014-02-20 Thread Kevin Ottens
> On Feb. 19, 2014, 2:07 p.m., Alex Merry wrote: > > I don't think papering over the X11-ness of kdesu like this is the right > > approach. Of course, what this framework really needs is a test app; maybe > > a simple port of the kdesu app from kde-runtime? This kind of "papering over" can on

Re: Review Request 115395: Also pass -fno-exceptions when building with clang

2014-02-20 Thread Kevin Ottens
> On Feb. 3, 2014, 6:07 p.m., Raphael Kubo da Costa wrote: > > Please see the big comment below the elseif line, the link to the > > kde-core-devel and > > http://lists.kde.org/?l=kde-core-devel&m=138244424421211&w=2: the issue > > here is that if you pass -fno-exceptions to clang you need to

Re: Review Request 115207: Improve integration QCommandLineParser <-> KAboutData

2014-02-20 Thread Kevin Ottens
> On Jan. 27, 2014, 7:45 a.m., Kevin Ottens wrote: > > src/lib/kaboutdata.cpp, line 941 > > <https://git.reviewboard.kde.org/r/115207/diff/1/?file=235099#file235099line941> > > > > Not really my type of thing. It's acting on an object behind our back

Re: Review Request 115316: Add demo for KRecentFileList

2014-02-20 Thread Kevin Ottens
> On Jan. 27, 2014, 2:23 a.m., Aleix Pol Gonzalez wrote: > > It's a test, not a demo. If you want, it's for demonstrating the developer > > that he did it right, but I wouldn't see it as documentation. > > > > I would rename it to KRecentFilesAct

Re: Review Request 115896: Import FindDocBook*.cmake from extra-cmake-modules

2014-02-20 Thread Kevin Ottens
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115896/#review50441 --- Ship it! Ship It! - Kevin Ottens On Feb. 19, 2014, 12:47

Re: Review Request 115840: Rename Platform to Frameworks in both about dialogs

2014-02-20 Thread Kevin Ottens
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115840/#review50440 --- Ship it! Ship It! - Kevin Ottens On Feb. 17, 2014, 7:04

Re: Review Request 115816: Remove strigi libs from kf5-frameworks-build-include

2014-02-20 Thread Kevin Ottens
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115816/#review50438 --- Ship it! Ship It! - Kevin Ottens On Feb. 19, 2014, 11:54

Re: Review Request 115876: More generic DocBookXML -> DocBookXML4

2014-02-20 Thread Kevin Ottens
> On Feb. 18, 2014, 11:13 p.m., Alex Merry wrote: > > Does this have any other users than kdoctools? If not, it should probably > > just move to that module. Even if kde4support ends up using it, I don't > > view that as a reason to put it in ECM. > > Luigi Toscano wrote: > There are no

Re: Review Request 115879: DocBookXML has been renamed, use the new exported variables

2014-02-20 Thread Kevin Ottens
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115879/#review50436 --- Ship it! Ship It! - Kevin Ottens On Feb. 18, 2014, 10:54

Re: Review Request 115875: kconfigtest: write everything into a subdirectory

2014-02-20 Thread Kevin Ottens
g/r/115875/#comment35495> Hm we're loosing the test mode for QStandardPaths, I don't think that's desirable. - Kevin Ottens On Feb. 18, 2014, 9:52 p.m., Alexander Richardson wrote: > > --- > This is an auto

Re: Review Request 115602: Rename kactivitymanagerd

2014-02-20 Thread Kevin Ottens
st want to make sure we thought that through. - Kevin Ottens On Feb. 18, 2014, 9:50 p.m., Hrvoje Senjan wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.r

Re: Review Request 115775: Defer to CMake's find_dependency macro if it exists

2014-02-20 Thread Kevin Ottens
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115775/#review50432 --- Ship it! Ship It! - Kevin Ottens On Feb. 18, 2014, 3:49

Re: Review Request 115485: Porting KTranscript from KJS to QtScript

2014-02-20 Thread Kevin Ottens
> On Feb. 20, 2014, 2:36 p.m., Kevin Ottens wrote: > > Any concerns left on that patch? It'd be nice to have it in alpha 2. > > Kevin Krammer wrote: > I guess the main problem is that due to a weird JavaScriptCore internal > thing the unit test crashe

Re: Review Request 115485: Porting KTranscript from KJS to QtScript

2014-02-20 Thread Kevin Ottens
it in alpha 2. - Kevin Ottens On Feb. 16, 2014, 6:54 p.m., Kevin Krammer wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard

Re: Review Request 115702: Check that kconfig_compiler signals get emitted when using KConfigDialog

2014-02-20 Thread Kevin Ottens
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115702/#review50375 --- Ship it! Ship It! - Kevin Ottens On Feb. 16, 2014, 5:03

Re: Review Request 115355: Import the WebP image I/O code from kde-runtime

2014-02-20 Thread Kevin Ottens
don't have more. - Kevin Ottens On Feb. 16, 2014, 12:14 p.m., Alex Merry wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard

Re: Review Request 115710: Hide private methods and slots behind the d-pointer in KHistoryComboBox

2014-02-20 Thread Kevin Ottens
ch is interesting and shouldn't stay in limbo too long. - Kevin Ottens On Feb. 12, 2014, 11:28 p.m., David Gil Oliva wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.review

Re: Review Request 115752: Change DATA_INSTALL_DIR on Mac OS X

2014-02-20 Thread Kevin Ottens
> On Feb. 15, 2014, 3:51 p.m., Alexander Richardson wrote: > > Same Problem on Windows: https://git.reviewboard.kde.org/r/115210/ > > Further discussion needed I guess I'd propose the discussion to be started on list then. Once the discussion is started this patch can be discarded until we reac

Re: Review Request 115028: Inline deprecated KUser::fullName() method

2014-02-20 Thread Kevin Ottens
g/r/115028/#comment35418> Not sure about that... I don't think we want the library itself to use deprecated methods. So knowing about that through warnings would make sense. - Kevin Ottens On Feb. 6, 2014, 5:20 p.m., Alex

Re: Review Request 115504: Only perform tests for plugins that are built

2014-02-20 Thread Kevin Ottens
g/r/115504/#comment35416> Didn't you mean if (BUILD_EPS_PLUGIN) ? This line confuses me. :-) - Kevin Ottens On Feb. 5, 2014, 5:41 p.m., Alex Merry wrote: > > --- > This is an automatically generated e-mail. To r

Re: Review Request 115137: Provide information about the active screen in KWindowSystem

2014-02-20 Thread Kevin Ottens
essed now? Please make a second round of reviews or ship it. - Kevin Ottens On Jan. 31, 2014, 1:01 p.m., Martin Gräßlin wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard

Re: Review Request 114997: Improve KAuth README.md

2014-02-20 Thread Kevin Ottens
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114997/#review50335 --- Ship it! Ship It! - Kevin Ottens On Jan. 28, 2014, 11:48

Re: KItemModels, Solid & KJS licenses

2014-02-20 Thread Kevin Ottens
Hello, On Wednesday 19 February 2014 21:18:31 šumski wrote: > i've started pushing Frameworks to openSUSE Factory (i.e. next openSUSE > release), and our legal review found some issues[1][2][3] with mentioned > frameworks licenses. > Details in the links bellow (basically, certain files are not li

Re: Review Request 115658: Also port KWindowSystem::windowInfo to the flags

2014-02-18 Thread Kevin Ottens
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115658/#review50153 --- Ship it! Ship It! - Kevin Ottens On Feb. 11, 2014, 1:30

KF5 Update Meeting Minutes 2014-w8

2014-02-18 Thread Kevin Ottens
Hello everyone, This is the minutes of the Week 8 KF5 meeting. As usual it has been held on #kde-devel at 4pm Paris time. Were present: afiestas, alexmerry, dfaure, mck182, mgraesslin, sebas, svuorela, teo, tosky and myself. Announcement: * Alpha 1 is out; * Get ready for alpha 2 end of next

KF5 Update Meeting 2014-w8 Reminder

2014-02-16 Thread Kevin Ottens
Hello all, Just a quick reminder: The next KF5 Update Meeting will happen on #kde-devel tomorrow at 4pm Paris time. See you there! Regards. -- Kévin Ottens, http://ervin.ipsquad.net KDAB - proud supporter of KDE, http://www.kdab.com signature.asc Description: This is a digitally signed mes

Re: Review Request 115421: Clean up the CMakeLists.txt files

2014-02-16 Thread Kevin Ottens
Hello, On Saturday 15 February 2014 23:27:40 David Faure wrote: > Looks like a historical thing to me, from before kstyle got integrated into > frameworkintegration. > > If I read git log correctly, this src/kstyle/CMakeLists.txt file comes from > Kévin's commit 3864cfe2347af01b. > > Kévin, any

Re: alpha1 release

2014-02-12 Thread Kevin Ottens
On Wednesday 12 February 2014 10:11:48 David Gil Oliva wrote: > El 12/02/2014 09:46, "Kevin Ottens" escribió: > > On Tuesday 11 February 2014 23:19:39 David Faure wrote: > > > On Thursday 06 February 2014 23:30:25 David Faure wrote: > > > > I have pac

Re: alpha1 release

2014-02-12 Thread Kevin Ottens
On Tuesday 11 February 2014 23:19:39 David Faure wrote: > On Thursday 06 February 2014 23:30:25 David Faure wrote: > > I have packaged up KF5 alpha 1 and uploaded it for packagers. > > And alpha1 is now public ! > > (tarballs published, git tags pushed) Woohoo! Thanks! Reminder: Alpha 2 in 17 d

KF5 Update Meeting Minutes 2014-w7

2014-02-11 Thread Kevin Ottens
Hello everyone, This is the minutes of the Week 6 KF5 meeting. As usual it has been held on #kde-devel at 4pm Paris time. Were present: afiestas, agateau, alexmerry, apol, dfaure, dgilo, krake, mgraesslin, Riddell, teo, tosky and myself. Announcement: * Alpha 1 still not published; * Please

KF5 Update Meeting 2014-w7 Reminder

2014-02-10 Thread Kevin Ottens
Hello all, Just a quick reminder: The next KF5 Update Meeting will happen on #kde-devel tomorrow at 4pm Paris time. See you there! Regards. -- Kévin Ottens, http://ervin.ipsquad.net KDAB - proud supporter of KDE, http://www.kdab.com signature.asc Description: This is a digitally signed mes

Re: alpha1 release

2014-02-06 Thread Kevin Ottens
Hello, On Friday 07 February 2014 06:25:46 Martin Klapetek wrote: > On Thu, Feb 6, 2014 at 11:30 PM, David Faure wrote: > > I have packaged up KF5 alpha 1 and uploaded it for packagers. > > > > Can we consider KF5 frozen all of tomorrow (Friday 7) ? > > I have quite some extensive changes for K

Re: kf5 alpha 1 : attica?

2014-02-06 Thread Kevin Ottens
On Thursday 06 February 2014 07:23:30 Kevin Ottens wrote: > On Thursday 06 February 2014 01:15:15 David Faure wrote: > > Some issues left: > > - who do we write down as maintainer for attica? > > Good question, let's mark it "TBD" until someone dares to step

Re: kf5 alpha 1 : attica?

2014-02-06 Thread Kevin Ottens
On Thursday 06 February 2014 07:23:30 Kevin Ottens wrote: > On Thursday 06 February 2014 01:15:15 David Faure wrote: > > Some issues left: > > - who do we write down as maintainer for attica? > > Good question, let's mark it "TBD" until someone dares to step

Re: Integration Plugin not picked on Wayland

2014-02-06 Thread Kevin Ottens
Hello, On Thursday 06 February 2014 09:37:39 Martin Gräßlin wrote: > Does anyone have an idea why that might be the case and how to properly > investigate this? Guessing: Does the platform plugin for wayland reimplement QPlatformIntegration::themeNames()? Ideally it should provide the same list

Re: kf5 alpha 1 : attica?

2014-02-05 Thread Kevin Ottens
On Thursday 06 February 2014 01:15:15 David Faure wrote: > Some issues left: > - who do we write down as maintainer for attica? Good question, let's mark it "TBD" until someone dares to step up for it. Regards. -- Kévin Ottens, http://ervin.ipsquad.net KDAB - proud supporter of KDE, http://www.

Re: kf5 alpha 1 : attica?

2014-02-05 Thread Kevin Ottens
On Wednesday 05 February 2014 18:39:51 David Faure wrote: > On Wednesday 05 February 2014 09:55:08 Jeremy Whiting wrote: > > I can do the changes if needed. It just needs the changes here: > > http://community.kde.org/Frameworks/Porting_Notes under "Build System" > > ? > > No, it should follow all

KF5 Update Meeting Minutes 2014-w6

2014-02-04 Thread Kevin Ottens
Hello everyone, This is the minutes of the Week 6 KF5 meeting. As usual it has been held on #kde-devel at 4pm Paris time. Were present: agateau, alexmerry, apol, mgraesslin, Riddell, teo, tosky and myself. Announcement: * Alpha 1 didn't get released, dfaure just forgot :-) * It should be rel

Re: kf5 alpha 1 : modules, versions

2014-02-03 Thread Kevin Ottens
On Monday 03 February 2014 10:17:49 David Faure wrote: > Any new module that should be added to this release, compared to TP1? > > Should I include attica? Since this question keeps popping up, let's integrate it. It should also be added to the list: http://community.kde.org/Frameworks/List Als

KF5 Update Meeting 2014-w6 Reminder

2014-02-02 Thread Kevin Ottens
Hello all, Just a quick reminder: The next KF5 Update Meeting will happen on #kde-devel tomorrow at 4pm Paris time. See you there! Regards. -- Kévin Ottens, http://ervin.ipsquad.net KDAB - proud supporter of KDE, http://www.kdab.com signature.asc Description: This is a digitally signed mes

Re: Where to put QML Bindings for KDE frameworks?

2014-01-29 Thread Kevin Ottens
On Wednesday 29 January 2014 09:20:09 Martin Klapetek wrote: > On Tue, Jan 28, 2014 at 7:10 PM, Kevin Ottens wrote: > > I don't think we'll get a one size fit all type of solution, that will > > heavily > > depend on the nature of the framework. For instance so

Re: Where to put QML Bindings for KDE frameworks?

2014-01-28 Thread Kevin Ottens
Hello, On Tuesday 28 January 2014 12:58:01 David Edmundson wrote: > For a task in Plasma I've had to port KKeySequence to render on > QtQuick, using QtQuickControls. > > I expect over time we will see more KDE widgets having QtQuick > implementations as well. Same for a lot of our other framework

KF5 Update Meeting Minutes 2014-w5

2014-01-28 Thread Kevin Ottens
Hello everyone, This is the minutes of the Week 3 KF5 meeting. As usual it has been held on #kde-devel at 4pm Paris time. Were present: afiestas, agateau, alexmerry, apol, dMaggot, mgraesslin, Riddell, sebas, teo, tosky and myself. Announcement: * Maintainers! Maintainers! Maintainers! * Don

Re: Review Request 115316: Add demo for KRecentFileList

2014-01-27 Thread Kevin Ottens
> On Jan. 27, 2014, 2:23 a.m., Aleix Pol Gonzalez wrote: > > It's a test, not a demo. If you want, it's for demonstrating the developer > > that he did it right, but I wouldn't see it as documentation. > > > > I would rename it to KRecentFilesActionTest Yes, definitely a manual test (otherwise

Re: Review Request 115285: Pass the KDE_COLOR_SCHEME_PATH application property to toplevel windows

2014-01-26 Thread Kevin Ottens
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115285/#review48355 --- Ship it! Ship It! - Kevin Ottens On Jan. 24, 2014, 9:36

Re: Review Request 115255: Add x11 platform detection to kkeyserver_x11

2014-01-26 Thread Kevin Ottens
g/r/115255/#comment34195> Warning? And/or assert? - Kevin Ottens On Jan. 23, 2014, 11:30 a.m., Martin Gräßlin wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboar

Re: Review Request 115248: Add runtime detection to KXMessages

2014-01-26 Thread Kevin Ottens
248/#comment34193> Warning? src/kxmessages.cpp <https://git.reviewboard.kde.org/r/115248/#comment34194> Warning for the !d->valid case? - Kevin Ottens On Jan. 23, 2014, 9:03 a.m., Martin Gräßlin wrote: > > ---

Re: Review Request 115230: Add platform check to KSelectionOwner and KSelectionWatcher

2014-01-26 Thread Kevin Ottens
g/r/115230/#comment34192> No chance to issue a warning at runtime when hitting that case? - Kevin Ottens On Jan. 22, 2014, 3:18 p.m., Martin Gräßlin wrote: > > --- > This is an automatically generated e-mail. To reply,

Re: Review Request 115203: Allow compiling with MSVC

2014-01-26 Thread Kevin Ottens
welcome though. - Kevin Ottens On Jan. 22, 2014, 3:13 p.m., Alexander Richardson wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.

Re: Review Request 115209: Fix KDoctools build on Windows

2014-01-26 Thread Kevin Ottens
someone from kdewin though. - Kevin Ottens On Jan. 22, 2014, 3:12 p.m., Alexander Richardson wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.

Re: Review Request 115190: Add unit test for KWindowInfo on X11

2014-01-26 Thread Kevin Ottens
ng on build.kde.org - Kevin Ottens On Jan. 22, 2014, 9:20 a.m., Martin Gräßlin wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard

Re: Review Request 115207: Improve integration QCommandLineParser <-> KAboutData

2014-01-26 Thread Kevin Ottens
to factorize the qApp call, and I see the need for that indeed, then that block should be provided by a separate method (setupApplication(QCoreApplication *)?). - Kevin Ottens On Jan. 21, 2014, 11:36 p.m., Aleix Pol Gonzalez wrote: > > --

Re: Review Request 114989: kapidox and other components from frameworks should use kde5-config instead of kde4-config, remove kde4 references

2014-01-26 Thread Kevin Ottens
tps://git.reviewboard.kde.org/r/114989/#comment34190> Should indeed just say kconfig_compiler. - Kevin Ottens On Jan. 12, 2014, 8:08 p.m., Siddharth Sharma wrote: > > --- > This is an automatically generated e-mail. To reply,

Re: Review Request 115148: Add KWINDOWSYSTEM_ namespace to HAVE_FOO defines

2014-01-26 Thread Kevin Ottens
other HAVE_FOO we have in the other frameworks. You might have opened the pandora box. :-) - Kevin Ottens On Jan. 26, 2014, 5:36 p.m., Alex Merry wrote: > > --- > This is an automatically generated e-mail. To reply, visit

Re: Review Request 114997: Improve KAuth README.md

2014-01-26 Thread Kevin Ottens
997/#comment34189> Agreed, this part needs to be less ambiguous. Looks fine otherwise. - Kevin Ottens On Jan. 26, 2014, 5:39 p.m., Alex Merry wrote: > > --- > This is an automatically generated e-mail. To reply,

Re: Review Request 115028: Allow the building of deprecated code to be disabled

2014-01-26 Thread Kevin Ottens
> On Jan. 27, 2014, 2:14 a.m., Aleix Pol Gonzalez wrote: > > Shouldn't we maybe just remove these? Especially considerign they already > > are deprecated in kdelibs 4. > > > > I don't really like disabling compilation of deprecated symbols, especially > > in this case we're not winning that mu

Re: Review Request 115123: Add an imported target to FindOpenEXR.cmake

2014-01-26 Thread Kevin Ottens
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115123/#review48339 --- Ship it! Ship It! - Kevin Ottens On Jan. 19, 2014, 3:49

Re: Review Request 115268: Replace the KDE_ENABLE_EXCEPTIONS variable with a pair of functions

2014-01-26 Thread Kevin Ottens
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115268/#review48338 --- Ship it! Ship It! - Kevin Ottens On Jan. 23, 2014, 6:18

Re: Review Request 115295: Do not set CMAKE_REQUIRED_DEFINES

2014-01-26 Thread Kevin Ottens
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115295/#review48336 --- Ship it! Ship It! - Kevin Ottens On Jan. 24, 2014, 2:45

Re: Review Request 115296: Do not set CMAKE_REQUIRED_DEFINES

2014-01-26 Thread Kevin Ottens
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115296/#review48337 --- Ship it! Ship It! - Kevin Ottens On Jan. 24, 2014, 2:45

Re: Review Request 115294: Add system API feature macros to CMAKE_REQUIRED_DEFINES

2014-01-26 Thread Kevin Ottens
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115294/#review48334 --- Ship it! Ship It! - Kevin Ottens On Jan. 24, 2014, 2:45

Re: Review Request 115266: Split up Mainpage.dox

2014-01-26 Thread Kevin Ottens
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115266/#review48333 --- Ship it! Ship It! - Kevin Ottens On Jan. 23, 2014, 4:43

Re: Review Request 115264: Split up Mainpage.dox

2014-01-26 Thread Kevin Ottens
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115264/#review48332 --- Ship it! Ship It! - Kevin Ottens On Jan. 23, 2014, 4:15

Re: Review Request 115120: Clean up the CMake files (and a couple of other bits)

2014-01-26 Thread Kevin Ottens
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115120/#review48331 --- Ship it! Ship It! - Kevin Ottens On Jan. 19, 2014, 12:23

Re: Schedule

2014-01-26 Thread Kevin Ottens
Hello, On Monday 27 January 2014 00:28:25 Alex Merry wrote: > Is there a schedule anywhere? I think I wasn't the only one taken by > surprise by Kévin's announcement about the alpha last week. It was in my email about governance. > http://community.kde.org/Frameworks should either host the sch

KF5 Update Meeting 2014-w5 Reminder

2014-01-26 Thread Kevin Ottens
Hello all, Just a quick reminder: The next KF5 Update Meeting will happen on #kde-devel tomorrow at 4pm Paris time. See you there! Regards. -- Kévin Ottens, http://ervin.ipsquad.net KDAB - proud supporter of KDE, http://www.kdab.com signature.asc Description: This is a digitally signed mes

Re: Tier status of attica & kwallet

2014-01-23 Thread Kevin Ottens
On Thursday 23 January 2014 22:47:45 Valentin Rusu wrote: > On Wednesday, January 22, 2014 10:48:00 PM Kevin Ottens wrote: > > On Wednesday 22 January 2014 22:21:47 Valentin Rusu wrote: > > > On Thursday, January 23, 2014 04:24:37 AM Michael Palimaka wrote: > > > &g

Re: Tier status of attica & kwallet

2014-01-22 Thread Kevin Ottens
On Wednesday 22 January 2014 22:21:47 Valentin Rusu wrote: > On Thursday, January 23, 2014 04:24:37 AM Michael Palimaka wrote: > > Hi, > > > > attica seems to have been absorbed as a framework, but does not appear > > to have been assigned a tier. Based on its dependencies, it looks like > > it wo

Re: Authors, maintainers and licenses in apidox

2014-01-22 Thread Kevin Ottens
Hello, On Wednesday 22 January 2014 12:27:29 Alex Merry wrote: > On 22/01/14 06:33, Kevin Ottens wrote: > > On Tuesday 21 January 2014 17:18:36 Alex Merry wrote: > >> Traditionally, the front pages of our apidox has included a list of > >> authors, the maintainer(s

Re: Splitting kde-workspace and kde-runtime proposal

2014-01-22 Thread Kevin Ottens
On Tuesday 21 January 2014 12:05:26 Antonis Tsiapaliokas wrote: > > 1) Create two different groups named plasma-workspace and > > plasma-desktop like frameworks > > 2) Split out every component into individual repos > > 3) Assign repos to the related group. > > > > Advantages: > > > > 1) Easy to

Re: Split classes into separate files?

2014-01-21 Thread Kevin Ottens
Hello, On Wednesday 22 January 2014 00:30:19 David Gil Oliva wrote: > I'm revising KCompletion and I have found that in kcompletion.h you can see > the declaration of KCompletionBase (which is defined in a separate file) > and KCompletionMatches (which is defined in kcompletion.cpp). > > I think

Re: Authors, maintainers and licenses in apidox

2014-01-21 Thread Kevin Ottens
On Tuesday 21 January 2014 17:18:36 Alex Merry wrote: > Traditionally, the front pages of our apidox has included a list of > authors, the maintainer(s) and the license. This is obviously > duplicating/summarising information stored elsewhere, and is easy to let > get out of date. Yes... definite

KF5 Update Meeting Minutes 2014-w4

2014-01-21 Thread Kevin Ottens
Hello everyone, This is the minutes of the Week 3 KF5 meeting. As usual it has been held on #kde-devel at 4pm Paris time. Were present: afiestas, agateau, alexmerry, arichardson, dfaure, mgraesslin, Riddell, tosky and myself. Announcement: * Come on people, we're still short on maintainers!

KF5 Update Meeting 2014-w4 Reminder

2014-01-19 Thread Kevin Ottens
Hello all, Just a quick reminder: The next KF5 Update Meeting will happen on #kde-devel tomorrow at 4pm Paris time. See you there! Regards. -- Kévin Ottens, http://ervin.ipsquad.net KDAB - proud supporter of KDE, http://www.kdab.com signature.asc Description: This is a digitally signed mes

Re: KCrash

2014-01-19 Thread Kevin Ottens
Hello, On Sunday 19 January 2014 18:43:01 David Faure wrote: > KCrash automatically initializes itself with the use of > Q_COREAPP_STARTUP_FUNCTION, provided that apps link to that lib. > > This works OK, except for one thing: it gives no chance for KCrash to add > --nocrashhandler to QCommandLin

Re: KDE Frameworks: Looking for maintainers

2014-01-19 Thread Kevin Ottens
Hello, I thought it'd be interesting to some to get updated stats since my last call to arms. On Monday 13 January 2014 19:40:54 Kevin Ottens wrote: > This is a reminder that we're still looking for maintainers for our > frameworks. Out of the 57 existing frameworks 25 have no

KF5 Update Meeting Minutes 2014-w3

2014-01-14 Thread Kevin Ottens
Hello everyone, This is the minutes of the Week 3 KF5 meeting. As usual it has been held on #kde-devel at 4pm Paris time. Were present: afiestas, agateau, alexmerry, dfaure, mck182, Riddell, valir and myself. Announcement: * We're *still* actively looking for maintainers! Konqi wants YOU! *

Re: kwalletd about to be switched from kde-runtime to kwallet-framework

2014-01-13 Thread Kevin Ottens
On Monday 13 January 2014 20:12:31 Valentin Rusu wrote: > On 01/13/2014 07:54 PM, David Faure wrote: > > On Monday 13 January 2014 16:48:52 Nicolás Alvarez wrote: > >> 2014/1/13 David Faure : > >> > >> If you rename kwallet to kwalletmanager and kwallet-framework to > >> kwallet, people with a clo

KDE Frameworks: Looking for maintainers

2014-01-13 Thread Kevin Ottens
Hello everyone, This is a reminder that we're still looking for maintainers for our frameworks. Out of the 57 existing frameworks 33 have no maintainer (yes, that's almost 60%). I don't know about you, but I find that worrying. The modules without maintainers are spread this way: - 9 are tier

Re: kwalletd about to be switched from kde-runtime to kwallet-framework

2014-01-13 Thread Kevin Ottens
Hello, On Monday 13 January 2014 10:05:26 David Faure wrote: > On Sunday 12 January 2014 19:59:26 Valentin Rusu wrote: > > Please be informed that I successfully imported the git history of > > kwalletd from kde-runtime to kwallet-framework, the I ported it to KF5. > > The code is ready to be push

Re: KDE Frameworks on Inqlude

2014-01-13 Thread Kevin Ottens
Hello, On Sunday 12 January 2014 23:11:09 Cornelius Schumacher wrote: > KDE Frameworks now have a dedicated page on Inqlude. There is a group > listing all frameworks at http://inqlude.org/groups/kde-frameworks.html. > The intention is not to make them stand out, but to have a logical grouping > a

KF5 Update Meeting 2014-w3 Reminder

2014-01-13 Thread Kevin Ottens
Hello all, Just a quick reminder: The next KF5 Update Meeting will happen on #kde-devel tomorrow at 4pm Paris time. See you there! Regards. -- Kévin Ottens, http://ervin.ipsquad.net KDAB - proud supporter of KDE, http://www.kdab.com signature.asc Description: This is a digitally signed mes

Re: KTextEditor & Frameworks question

2014-01-09 Thread Kevin Ottens
On Wednesday 08 January 2014 23:00:02 Alex Merry wrote: > On 08/01/14 22:24, Kevin Ottens wrote: > > I also modified a bit one of the policies: > > http://community.kde.org/Frameworks/Policies#Frameworks_buildsystem_is_con > > sistent (was saying "installation rules&q

<    3   4   5   6   7   8   9   10   11   12   >