D26968: Removed hardcoded values

ndavis added a comment. Anyway, it works as it is, so don't worry about it. REPOSITORY R242 Plasma Framework (Library) BRANCH fix_panel_color REVISION DETAIL https://phabricator.kde.org/D26968 To: niccolove, #vdg, #plasma, ndavis Cc: ndavis, ngraham, kde-frameworks-devel, LeGast00n,

D26968: Removed hardcoded values

ndavis added a comment. In D26968#602031 , @niccolove wrote: > In D26968#601998 , @ndavis wrote: > > > You should remove the color field instead of using `color:currentColor` and

D26968: Removed hardcoded values

ndavis added reviewers: VDG, Plasma. ndavis added a comment. This does have rounded corners and the background is fixed. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D26968 To: niccolove, #vdg, #plasma Cc: ndavis, ngraham, kde-frameworks-devel,

D26968: Removed hardcoded values

ndavis accepted this revision. This revision is now accepted and ready to land. REPOSITORY R242 Plasma Framework (Library) BRANCH fix_panel_color REVISION DETAIL https://phabricator.kde.org/D26968 To: niccolove, #vdg, #plasma, ndavis Cc: ndavis, ngraham, kde-frameworks-devel, LeGast00n,

D26968: Removed hardcoded values

ndavis added a comment. You should remove the color field instead of using `color:currentColor` and `fill:currentColor` REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D26968 To: niccolove Cc: ndavis, ngraham, kde-frameworks-devel, LeGast00n,

D26955: Fix background SVG colors and adjust background SVG corners

ndavis added a comment. In D26955#601984 , @niccolove wrote: > Might the problems of not-rounded corners here be caused from the "adjust background SVG corners" part by any chance? I tried using the same corners as the shadow patch, but

D26758: Fix the size and pixel alignment of checkboxes and radiobuttons

This revision was automatically updated to reflect the committed changes. Closed by commit R242:ad625f68f345: Fix the size and pixel alignment of checkboxes and radiobuttons (authored by ndavis). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE

D26955: Fix background SVG colors and adjust background SVG corners

ndavis added a subscriber: niccolove. ndavis added a comment. In D26955#601684 , @ngraham wrote: > This fixes the color bug, so that's good. :) > > However with Breeze Dark, now I see pointy corners and very weak shadows: F7982216:

D26955: Fix background SVG colors and adjust background SVG corners

ndavis retitled this revision from "Fix background colors and adjust background corners" to "Fix background SVG colors and adjust background SVG corners". REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D26955 To: ndavis, #vdg, #plasma Cc:

D26758: Fix the size and pixel alignment of checkboxes and radiobuttons

ndavis added a comment. In D26758#601675 , @ngraham wrote: > I'd like to be able to verify that by looking at a radio button in the Plasma style but I can't actually find any. Do you know of any place where they're used?

D26758: Fix the size and pixel alignment of checkboxes and radiobuttons

ndavis added a comment. In case it's not clear or for anyone skimming the conversation, I think the tests themselves are broken and can't be relied upon because they break things that normally work OK or at least better than they do in the tests. I don't know QML that well, but I don't see

D26758: Fix the size and pixel alignment of checkboxes and radiobuttons

ndavis added a comment. In D26758#601535 , @ngraham wrote: > Found one small regression in the test suite. The new correct radio button sizing results in vertical misalignment (for both PC2 and PC3): > > Status quo: F7978647:

D26955: Fix background colors and adjust background corners

ndavis created this revision. ndavis added reviewers: VDG, Plasma. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. ndavis requested review of this revision. REVISION SUMMARY The shadows patch before this patch had some problems with the SVGs that caused

D26758: Fix the size and pixel alignment of checkboxes and radiobuttons

ndavis added a comment. Ping. This patch doesn't fix everything, but it's still an improvement over the current state. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D26758 To: ndavis, #plasma, #vdg Cc: davidedmundson, kde-frameworks-devel,

D26920: Change VLC icon to be more like official VLC icons

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R266:e215cca8900f: Change VLC icon to be more like official VLC icons (authored by ndavis). REPOSITORY R266 Breeze Icons

D26920: Change VLC icon to be more like official VLC icons

ndavis edited the summary of this revision. ndavis edited the test plan for this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D26920 To: ndavis, #vdg Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26920: Change VLC icon to be more like official VLC icons

ndavis created this revision. ndavis added a reviewer: VDG. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. ndavis requested review of this revision. REVISION SUMMARY This new icon is more in line with our policy on preserving the branding of apps.

D26441: New icon for KTimeTracker

ndavis requested changes to this revision. ndavis added a subscriber: hellcp. ndavis added a comment. This revision now requires changes to proceed. I have to agree with what @hellcp said in the VDG chat earlier, the mahogany really does not fit. It draws attention to the wrong places and is

D26758: Fix the size and pixel alignment of checkboxes and radiobuttons

ndavis added a comment. In D26758#599231 , @davidedmundson wrote: > Please be sure to run the relevant tests in > > tests/components/ > > with qmlscene > > It'll find more than running random applets Unfortunately, those have

D25015: Update breeze theme shadows

ndavis accepted this revision. REPOSITORY R242 Plasma Framework (Library) BRANCH bettershadows (branched from master) REVISION DETAIL https://phabricator.kde.org/D25015 To: niccolove, #vdg, ngraham, The-Feren-OS-Dev, ndavis Cc: The-Feren-OS-Dev, mart, broulik, cblack, ndavis, manueljlin,

D26758: Fix the size and pixel alignment of checkboxes and radiobuttons

ndavis retitled this revision from "[WIP] Fix the size and pixel alignment of checkboxes and radiobuttons" to "Fix the size and pixel alignment of checkboxes and radiobuttons". REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D26758 To: ndavis,

T12567: Reduce code/effort duplication around color scheme support

ndavis added a comment. In T12567#218405 , @davidedmundson wrote: > The former won't know when to update, the latter can. So we'll need to make property bindings anyway? Or maybe we can use arrays instead of writing 108 individual

T12567: Reduce code/effort duplication around color scheme support

ndavis added a comment. QML can use C++ functions right? Would we still need to make property bindings for all the colors if we had color() functions? TASK DETAIL https://phabricator.kde.org/T12567 To: ndavis Cc: ognarb, plasma-devel, kde-frameworks-devel, ndavis, Orage, LeGast00n,

D25814: [KColorScheme] Add SeparatorColor

ndavis added a comment. I think this is still ultimately the right thing to do. Making the frame/separator color a mix of 2 other colors makes it harder to get just the right color for both the light and dark variations of a theme unless you design the color palettes to solve problems in

T12567: Reduce code/effort duplication around color scheme support

ndavis updated the task description. TASK DETAIL https://phabricator.kde.org/T12567 To: ndavis Cc: plasma-devel, kde-frameworks-devel, ndavis, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, davidre, fbampaloukas, GB_2, ekasprzak, ragreen, domson, michaelh, ahmadsamir, dkardarakos,

D25015: Update breeze theme shadows

ndavis added a comment. Just in case you misunderstood me, when I said create the corners from rounded rectangles, I meant create the rounded rectangle and cut off the parts you don't need so that you're left with corners that you can place however you need. If you're not aware of it, check

D25015: Update breeze theme shadows

ndavis added a comment. I'll trust your judgement on the masks and corners. If there's a problem, it can be patched. I know this stuff can be super janky at times. REPOSITORY R242 Plasma Framework (Library) BRANCH bettershadows (branched from master) REVISION DETAIL

D25015: Update breeze theme shadows

ndavis added a comment. I noticed a few things. --- The masks have a rather odd shape and it's not pixel aligned, which might mean something is wrong: F7891523: Screenshot_20200118_225818.PNG It's different from master, which looks pretty

D26758: [WIP] Fix the size and pixel alignment of checkboxes and radiobuttons

ndavis added a comment. For some reason, the corners of the checkbox indicator don't overlap perfectly with the corners of the base checkbox, even though the corners are exactly the same in the SVGs. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL

D26758: [WIP] Fix the size and pixel alignment of checkboxes and radiobuttons

ndavis edited the test plan for this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D26758 To: ndavis, #plasma, #vdg Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26758: [WIP] Fix the size and pixel alignment of checkboxes and radiobuttons

ndavis edited the summary of this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D26758 To: ndavis, #plasma, #vdg Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26758: [WIP] Fix the size and pixel alignment of checkboxes and radiobuttons

ndavis added a comment. This patch has a few problems and some things to consider. - Changing the size to `units.iconSizes.small` doesn't seem to break any layouts we have, but I have not done extensive testing with 3rd party widgets. - Is the size too small for touch input? If yes,

D26758: [WIP] Fix the size and pixel alignment of checkboxes and radiobuttons

ndavis created this revision. ndavis added reviewers: Plasma, VDG. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. ndavis requested review of this revision. REVISION SUMMARY The checkboxes and radio buttons in plasmashell were signficantly different from

D26703: Add icon for text/vnd.kde.kcrash-report

ndavis accepted this revision. This revision is now accepted and ready to land. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D26703 To: broulik, #vdg, ndavis Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26671: Cleanup and add 22px media repeat icons

ndavis accepted this revision. REPOSITORY R266 Breeze Icons BRANCH repeatIcons REVISION DETAIL https://phabricator.kde.org/D26671 To: astippich, #vdg, ngraham, ndavis Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26649: [KMessageBox] Only allow selecting text in the dialog box using the mouse

ndavis added a comment. In D26649#593825 , @broulik wrote: > So you can't tab around to end up focusing the text field? You currently aren't able to, but after you click with the mouse on the text, you can use the arrow keys to move an I

D26649: [KMessageBox] Only allow selecting text in the dialog box using the mouse

ndavis accepted this revision. This revision is now accepted and ready to land. REPOSITORY R236 KWidgetsAddons BRANCH no-more-keyboard-selectability (branched from master) REVISION DETAIL https://phabricator.kde.org/D26649 To: ngraham, dfaure, #frameworks, #vdg, ndavis Cc:

D26595: Add network-wireless-hotspot icon

ndavis added a comment. In D26595#592368 , @ngraham wrote: > Hmm, at normal size, the 8, 16, and 22px versions look too busy to me.: I kind of agree. > For the 16 and 22px versions, maybe reduce the number of waves and increase the

D26555: Rename 'nepomuk' Plasma Theme icons to 'search'

ndavis accepted this revision. ndavis added a comment. This revision is now accepted and ready to land. Icons in the desktop theme that are made to replace icons in the icon theme need to be kept up to date with the icon theme. I'm accepting this as it is, but if @davidre thinks we should

D25814: [KColorScheme] Add SeparatorColor

ndavis added a subscriber: broulik. ndavis added a comment. In D25814#591053 , @ngraham wrote: > I wonder if a path forward is to move this option into Breeze itself and keep it out of the color scheme. We would add an option for "dark

D26441: New icon for KTimeTracker

ndavis added a comment. The top part looks a bit too flat and wide. There's also nothing attaching it to the body, so it looks like it's floating. I don't think Plasma Blue work well as a body color with no outline. This happens when I select the file in dolphin because it blends in

D26404: Turn application/x-ms-shortcut into an actual shortcut icon

ndavis accepted this revision. ndavis added a comment. This revision is now accepted and ready to land. Make sure you copy to breeze dark as well REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D26404 To: broulik, #vdg, ndavis Cc: ndavis, kde-frameworks-devel,

D26404: Turn application/x-ms-shortcut into an actual shortcut icon

ndavis requested changes to this revision. ndavis added a comment. This revision now requires changes to proceed. For 16/22px, symlinking to existing monochrome link icons is acceptable. This patch does not apply cleanly. The base commit isn't available. REPOSITORY R266 Breeze Icons

D26326: Add application/x-audacity-project icon

ndavis accepted this revision. REPOSITORY R266 Breeze Icons BRANCH arcpatch-D26326 REVISION DETAIL https://phabricator.kde.org/D26326 To: cblack, #vdg, ndavis, ngraham, broulik Cc: cblack, ndavis, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26326: Add application/x-audacity-project icon

ndavis accepted this revision. This revision is now accepted and ready to land. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D26326 To: broulik, #vdg, ndavis, ngraham Cc: ndavis, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

T11950: Reduce the pain of working on monochrome Breeze icons

ndavis added a comment. For the Inkscape optimized svg gradient problem: https://gitlab.com/inkscape/inbox/issues/1121 TASK DETAIL https://phabricator.kde.org/T11950 To: ngraham, ndavis Cc: mglb, #frameworks, mart, trickyricky26, ndavis, #vdg, ngraham, manueljlin, LeGast00n, cblack,

D26326: Add application/x-audacity-project icon

ndavis requested changes to this revision. ndavis added a comment. This revision now requires changes to proceed. Just needs some optimization and it'll be good to go REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D26326 To: broulik, #vdg, ndavis Cc: ndavis,

D26313: Add application/vnd.apple.pkpass icon

ndavis accepted this revision. This revision is now accepted and ready to land. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D26313 To: broulik, #vdg, vkrause, ndavis Cc: ndavis, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26313: Add application/vnd.apple.pkpass icon

ndavis requested changes to this revision. ndavis added a comment. This revision now requires changes to proceed. Nice work! Looks like the 64px version got a part of it knocked out of position: F7851485: Screenshot_20191230_204235.PNG Once

D26146: Delete icon

ndavis accepted this revision. This revision is now accepted and ready to land. REPOSITORY R293 Baloo BRANCH delete-icon (branched from master) REVISION DETAIL https://phabricator.kde.org/D26146 To: ngraham, #baloo, #vdg, IlyaBizyaev, ndavis Cc: kde-frameworks-devel, hurikhan77,

D25878: Use clearer relative dates

ndavis accepted this revision. This revision is now accepted and ready to land. REPOSITORY R244 KCoreAddons BRANCH better-relative-dates (branched from master) REVISION DETAIL https://phabricator.kde.org/D25878 To: ngraham, davidedmundson, #vdg, #frameworks, ndavis Cc: broulik,

D25334: Added transparent blue background to tabbars

ndavis added a comment. In D25334#578285 , @niccolove wrote: > Breeze dark highlight is currently #3daee9 in the Breeze Dark colorscheme. If that's too light, we could darken it there, right? > Currently it's: F7819764:

D25999: Add optional subtitle to grid delegate

ndavis resigned from this revision. ndavis added a comment. This revision now requires review to proceed. Whoops, didn't mean to give my official approval REPOSITORY R296 KDeclarative REVISION DETAIL https://phabricator.kde.org/D25999 To: ngraham, #vdg, #plasma, davidedmundson Cc:

D25999: Add optional subtitle to grid delegate

ndavis accepted this revision. ndavis added a comment. This revision is now accepted and ready to land. +1 visually REPOSITORY R296 KDeclarative BRANCH optional-subtitle (branched from master) REVISION DETAIL https://phabricator.kde.org/D25999 To: ngraham, #vdg, #plasma,

D25897: Add 32, 48 and 64 px user-desktop icons

This revision was automatically updated to reflect the committed changes. Closed by commit R242:bcc1ba205d60: Add 32, 48 and 64 px user-desktop icons (authored by ndavis). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25897?vs=71467=71469

D25897: Add 32, 48 and 64 px user-desktop icons

ndavis edited the test plan for this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D25897 To: ndavis, #plasma, #vdg Cc: ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D25897: Add 32, 48 and 64 px user-desktop icons

ndavis updated this revision to Diff 71467. ndavis added a comment. - increase line thickness for 48 and 64 px REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25897?vs=71303=71467 BRANCH show-desktop-icon (branched from master)

D25897: Add 32, 48 and 64 px user-desktop icons

ndavis added a comment. In D25897#576015 , @ngraham wrote: > The straight lines in the system tray items from my screenshot are definitely 1px strokes. But all the curved lines look thicker by virtue of not being able to align to the pixel

D25296: [RFC] Fix Display Configuration icon margins

ndavis accepted this revision. This revision is now accepted and ready to land. REPOSITORY R242 Plasma Framework (Library) BRANCH fix-xrandr-icon (branched from master) REVISION DETAIL https://phabricator.kde.org/D25296 To: ngraham, #vdg, ndavis Cc: trickyricky26, kde-frameworks-devel,

D25897: Add 32, 48 and 64 px user-desktop icons

ndavis added a comment. In D25897#575934 , @ngraham wrote: > Thanks. However I wonder if the stroke width ought to increase for the larger sizes? Having such skinny lines looks a tad odd to me IMO: > > F7813271:

D25897: Add 32, 48 and 64 px user-desktop icons

ndavis edited the test plan for this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D25897 To: ndavis, #plasma, #vdg Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25897: Add 32, 48 and 64 px user-desktop icons

ndavis created this revision. ndavis added reviewers: Plasma, VDG. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. ndavis requested review of this revision. REVISION SUMMARY This prevents the icon from becoming blurry at fairly normal panel widths. TEST

D25855: Don't show the info icon on the big preview delegate

ndavis accepted this revision. This revision is now accepted and ready to land. REPOSITORY R304 KNewStuff BRANCH dont-show-that-info-icon (branched from master) REVISION DETAIL https://phabricator.kde.org/D25855 To: leinir, #frameworks, #knewstuff, ngraham, abetts, #vdg, ndavis Cc:

D25820: SimpleScreenRecorder icon added

ndavis added a comment. In D25820#574397 , @vinzenzv wrote: > In D25820#574119 , @ndavis wrote: > > > Good start! The lens flare looks upside down > > > That was intentionally to make it

D25814: [KColorScheme] Add SeparatorColor

ndavis added a comment. In D25814#574395 , @filipf wrote: > Already asked in VDG, but repeating here: how would we handle dark separators on really dark color schemes? > > This is the most downloaded color scheme and it won't work well with

D25815: Transmission-Qt tray icon added

ndavis added a comment. wait scratch that, it does work. I had to remove the `22-22-` prefix, which is what you need to do when you have multiple icon sizes. REVISION DETAIL https://phabricator.kde.org/D25815 To: vinzenzv, #vdg, ndavis, ngraham Cc: broulik, ndavis, ngraham, iasensio,

D25815: Transmission-Qt tray icon added

ndavis added a comment. In D25815#574394 , @vinzenzv wrote: > In D25815#574216 , @ndavis wrote: > > > Here's one way to make a nice looking trapezoid in the Breeze style. I started by making a

D25814: [KColorScheme] Add SeparatorColor

ndavis added a comment. In D25814#574356 , @hpereiradacosta wrote: > I meant: do the "light" (with window text color) toolbar icons play well with dark toolbar separators as opposed to current semi-light toolbar separators I assume you

D25814: [KColorScheme] Add SeparatorColor

ndavis added a comment. In D25814#574250 , @hpereiradacosta wrote: > - You should add toolbar separators, tabboxes and group boxes to that. For toolbar separators, I wonder how this would play with monochrome (color-themed) icons. I'm

D25340: Added background colors to active and inactive icon view

This revision was automatically updated to reflect the committed changes. Closed by commit R242:7e52c869de2d: Added background colors to active and inactive icon view (authored by ndavis). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE

D25815: Transmission-Qt tray icon added

ndavis added a comment. Here's one way to make a nice looking trapezoid in the Breeze style. I started by making a stroke with end points in the middle of pixels and the other settings I mentioned in my first comment. Then I converted it to a path and I added a 2px high rectangle to

D25815: Transmission-Qt tray icon added

ndavis added a comment. In D25815#574150 , @broulik wrote: > I chceked transmission git code and the icon name it uses is actually `transmission-tray-icon`, so you want to have a `transmission.svg` file and the "id" to be

D25814: [KColorScheme] Add SeparatorColor

ndavis added a comment. In D25814#574129 , @hpereiradacosta wrote: > Few more comments on this: > > - general: you will never be able to make all the opiniated people happy, and you have to draw a line (otherwise your code will become

D25814: [KColorScheme] Add SeparatorColor

ndavis added a comment. In D25814#574160 , @davidedmundson wrote: > Can we clarify what separators we're referring to. Frames around UI elements and horizontal/vertical lines that separate UI elements. These are the most common

D25820: SimpleScreenRecorder icon added

ndavis requested changes to this revision. ndavis added a comment. This revision now requires changes to proceed. Good start! The lens flare looks upside down and the icon needs more pixel alignment. I feel like the red/green/blue colors of the center area are a bit too dark as well.

D25814: [KColorScheme] Add SeparatorColor

ndavis added a comment. @hpereiradacosta, Fair points and I'm glad you spoke up. JFYI, I'm in no rush to land this and I will consider reserving this change for KF6 if experienced KDE devs think that is best. In D25814#574105 ,

D25815: Transmission-Qt tray icon added

ndavis added a comment. In D25815#574111 , @vinzenzv wrote: > In D25815#574103 , @ndavis wrote: > > > The actual name of the icon is `transmission`, so you would have to rename the file to that and

D25815: Transmission-Qt tray icon added

ndavis added a comment. The actual name of the icon is `transmission`, so you would have to rename the file to that and add `id="transmission"` to the group. Since this is a desktop theme icon, you would also have to add an invisible 22x22 rectangle to the group. However, even after

D25815: Transmission-Qt tray icon added

ndavis requested changes to this revision. ndavis added a comment. This revision now requires changes to proceed. Hey, thanks for the patch! - Breeze usually uses 1px lines, but does use 2px in some instances (mainly centered lines). You can use a 2px thickness at the bottom in this case

D25814: [KColorScheme] Add SeparatorColor

ndavis updated this revision to Diff 71096. ndavis added a comment. - update @since version REPOSITORY R265 KConfigWidgets CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25814?vs=71095=71096 BRANCH separator-color (branched from master) REVISION DETAIL

D25814: [KColorScheme] Add SeparatorColor

ndavis edited the summary of this revision. REPOSITORY R265 KConfigWidgets REVISION DETAIL https://phabricator.kde.org/D25814 To: ndavis, #frameworks, #vdg, dfaure Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25814: [KColorScheme] Add SeparatorColor

ndavis edited the summary of this revision. REPOSITORY R265 KConfigWidgets REVISION DETAIL https://phabricator.kde.org/D25814 To: ndavis, #frameworks, #vdg, dfaure Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25814: [KColorScheme] Add SeparatorColor

ndavis edited the summary of this revision. REPOSITORY R265 KConfigWidgets REVISION DETAIL https://phabricator.kde.org/D25814 To: ndavis, #frameworks, #vdg, dfaure Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25814: [KColorScheme] Add SeparatorColor

ndavis edited the summary of this revision. ndavis added reviewers: Frameworks, VDG, dfaure. REPOSITORY R265 KConfigWidgets REVISION DETAIL https://phabricator.kde.org/D25814 To: ndavis, #frameworks, #vdg, dfaure Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25814: [KColorScheme] Add SeparatorColor

ndavis created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. ndavis requested review of this revision. REVISION SUMMARY Users sometimes ask for the ability to customize the color of separators. When talking about how the next version of

D25340: Added background colors to active and inactive icon view

ndavis edited the summary of this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D25340 To: ndavis, #vdg, ngraham, niccolove Cc: filipf, manueljlin, ngraham, ndavis, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D25340: Added background colors to active and inactive icon view

ndavis edited the test plan for this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D25340 To: ndavis, #vdg, ngraham, niccolove Cc: filipf, manueljlin, ngraham, ndavis, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D25340: Added background colors to active and inactive icon view

ndavis updated this revision to Diff 71092. ndavis added a comment. - change minimized bg opacity to 8% REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25340?vs=71084=71092 BRANCH arcpatch-D25340 (branched from master) REVISION DETAIL

D25340: Added background colors to active and inactive icon view

ndavis updated this revision to Diff 71084. ndavis added a comment. - Change normal bg to 15% opacity - Change minimized bg to 5% opacity REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25340?vs=71050=71084 BRANCH arcpatch-D25340

D25340: Added background colors to active and inactive icon view

ndavis edited the summary of this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D25340 To: ndavis, #vdg, ngraham, niccolove Cc: filipf, manueljlin, ngraham, ndavis, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D25340: Added background colors to active and inactive icon view

ndavis edited the test plan for this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D25340 To: ndavis, #vdg, ngraham, niccolove Cc: filipf, manueljlin, ngraham, ndavis, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D25340: Added background colors to active and inactive icon view

ndavis commandeered this revision. ndavis edited reviewers, added: niccolove; removed: ndavis. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D25340 To: ndavis, #vdg, ngraham, niccolove Cc: filipf, manueljlin, ngraham, ndavis, kde-frameworks-devel,

D25340: Added background colors to active and inactive icon view

ndavis added a comment. @niccolove Do you mind if I commandeer this? I know dealing with these kinds of issues can be super annoying and I'm already used to it. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D25340 To: niccolove, #vdg, ngraham,

D25340: Added background colors to active and inactive icon view

ndavis added a comment. It's still going to be a PITA with manual editing. Maybe there's a way to automate it with `awk`, but I don't know that tool well enough. This should at least make the deleting part easier: `sed --follow-symlinks -i 's/style="opacity:0.05"//' tasks.svg` Do this

D25340: Added background colors to active and inactive icon view

ndavis requested changes to this revision. This revision now requires changes to proceed. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D25340 To: niccolove, #vdg, ngraham, ndavis Cc: filipf, manueljlin, ngraham, ndavis, kde-frameworks-devel,

D25340: Added background colors to active and inactive icon view

ndavis added a comment. Oh wait, here's the problem INLINE COMMENTS > tasks.svg:3206 > + transform="matrix(-1 0 0 -1 36 134)" > + opacity=".16" > + style="opacity:0.05"> Starts here Conflicting opacity values. Set `opacity="0.05"` and delete the conflicting

D25340: Added background colors to active and inactive icon view

ndavis added a comment. In D25340#573654 , @ngraham wrote: > Hmm, I'm not seeing any change, and the difference between open and maximized items is still too subtle IMO: F7804140: Screenshot_20191207_093912.PNG

D25340: Added background colors to active and inactive icon view

ndavis accepted this revision. This revision is now accepted and ready to land. REPOSITORY R242 Plasma Framework (Library) BRANCH backrgound-color-iconviewer (branched from master) REVISION DETAIL https://phabricator.kde.org/D25340 To: niccolove, #vdg, ngraham, ndavis Cc: filipf,

D25340: Added background colors to active and inactive icon view

ndavis requested changes to this revision. ndavis added a comment. This revision now requires changes to proceed. Wait, is a change to tabbar.svg supposed to be in this diff? REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D25340 To: niccolove,

D25340: Added background colors to active and inactive icon view

ndavis accepted this revision. REPOSITORY R242 Plasma Framework (Library) BRANCH backrgound-color-iconviewer (branched from master) REVISION DETAIL https://phabricator.kde.org/D25340 To: niccolove, #vdg, ngraham, ndavis Cc: filipf, manueljlin, ngraham, ndavis, kde-frameworks-devel,

<    1   2   3   4   5   6   7   8   9   10   >